- 05 Jan, 2017 40 commits
-
-
lukasza authored
BUG=677223 Review-Url: https://codereview.chromium.org/2612313002 Cr-Commit-Position: refs/heads/master@{#441736}
-
dtapuska authored
Perform similar cleanup as GestureEvents used in change: https://codereview.chromium.org/2539283002/ Cleanup proposal: https://docs.google.com/document/d/1s4Lfy22CNU1OZ5Rec6Oano_5BvIhdK6uFVsVe7FphKI/edit BUG=625684 Review-Url: https://codereview.chromium.org/2586133003 Cr-Commit-Position: refs/heads/master@{#441735}
-
bcwhite authored
BUG=678040 Review-Url: https://codereview.chromium.org/2616613004 Cr-Commit-Position: refs/heads/master@{#441734}
-
xdai authored
In Chrome OS launcher's start page, we recreate the app tile views if we need to display different numbers of apps compared with the previous time (e.g., install a new app or uninstall an existing app). We need to make sure the number of the displayed apps is properly updated. Otherwise, it might cause browser crash because of retrieving a stale pointer in StartPageView::StartPageTilesContainer::GetTileItemView(). Also refactor related functions. This is a better approach of https://codereview.chromium.org/2605463003/. BUG=675150 Review-Url: https://codereview.chromium.org/2609843004 Cr-Commit-Position: refs/heads/master@{#441733}
-
agable authored
R=michaelpg@chromium.org, pbakaus@chromium.org Review-Url: https://codereview.chromium.org/2487493005 Cr-Commit-Position: refs/heads/master@{#441732}
-
alito authored
BUG= Review-Url: https://codereview.chromium.org/2615493005 Cr-Commit-Position: refs/heads/master@{#441731}
-
shess authored
In V4LocalDatabaseManager, HandleCheck() does a PostTask() to PerformFullHashCheck(), which adds the check to pending_clients_. If the caller calls CancelCheck() before posted task runs, the check won't be cancelled. BUG=660293 Review-Url: https://codereview.chromium.org/2565283008 Cr-Commit-Position: refs/heads/master@{#441730}
-
rdevlin.cronin authored
Event listeners can potentially unregister themselves in the handling of the event, e.g. chrome.foo.onBar.addListener(function listener() { chrome.foo.onBar.removeListener(listener); <do stuff> }); Support this behavior and add a test. BUG=653596 Review-Url: https://codereview.chromium.org/2605353003 Cr-Commit-Position: refs/heads/master@{#441729}
-
pdfium-deps-roller authored
https://pdfium.googlesource.com/pdfium.git/+log/0ef7ba086f9e..e4d611c9c6d8 $ git log 0ef7ba086..e4d611c9c --date=short --no-merges --format='%ad %ae %s' 2017-01-05 tsepez Remove CFX_MapPtrToPtr from xfa/fde. Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Review-Url: https://codereview.chromium.org/2610803004 Cr-Commit-Position: refs/heads/master@{#441728}
-
nicholss authored
This change with allow me to cleanly add interfaces to the GL implementations. The intent is to add interfaces to the different components, but these get lost in the flat client/ directory. Moving display related files to their own location. R=yuweih@chromium.org BUG=671692 Review-Url: https://codereview.chromium.org/2614443003 Cr-Commit-Position: refs/heads/master@{#441727}
-
xdai authored
In order to be consistent with the existing behavior of the Chrome OS Wallpaper Picker App, we don't show the Android Wallpapers App in the launcher. BUG=670328 Review-Url: https://codereview.chromium.org/2617633002 Cr-Commit-Position: refs/heads/master@{#441726}
-
skia-deps-roller authored
https://skia.googlesource.com/skia.git/+log/ac1f09d53bfe..08d57e6ae651 $ git log ac1f09d53..08d57e6ae --date=short --no-merges --format='%ad %ae %s' 2017-01-05 fmalita Remove SK_SUPPORT_LEGACY_EVAL_CUBIC-guarded code 2017-01-05 bsalomon Use nullptr to indicate C locale when using xlocale 2017-01-05 djsollen Add tools to support gdb and simpleperf for android executables. 2017-01-05 benjaminwagner Remove Perf-Android-Clang-NexusPlayer-CPU-Moorefield-x86-Release-Android. 2017-01-05 mtklein GN: add test_app template BUG=666228 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=csmartdalton@google.com Review-Url: https://codereview.chromium.org/2615893002 Cr-Commit-Position: refs/heads/master@{#441725}
-
alokp authored
The new sink incorporates media duration for EOS notification. Previously the default backed fired the EOS notification as soon as it received the EOS buffer, which made the media playback to end much sooner than expected. BUG=internal b/33274894 Review-Url: https://codereview.chromium.org/2583213003 Cr-Commit-Position: refs/heads/master@{#441724}
-
fdoray authored
base::PostDelayedTask(...) is less verbose than base::CreateTaskRunnerWithTraits(TaskTraits())->PostDelayedTask(...). The first usage of base::PostDelayedTaskWithTraits will be in https://codereview.chromium.org/2598483004/. BUG=553459 Review-Url: https://codereview.chromium.org/2613703003 Cr-Commit-Position: refs/heads/master@{#441723}
-
sky authored
Revert of Remove Blimp from waterfall configurations and buildbot recipes. (patchset #3 id:40001 of https://codereview.chromium.org/2607973002/ ) Reason for revert: Reverting in hopes of fixing https://build.chromium.org/p/chromium.linux/builders/Blimp%20Linux%20%28dbg%29/builds/19878 Original issue's description: > Remove Blimp from waterfall configurations and buildbot recipes. > > R=amineer@chromium.org > BUG=677556 > > Review-Url: https://codereview.chromium.org/2607973002 > Cr-Commit-Position: refs/heads/master@{#441714} > Committed: https://chromium.googlesource.com/chromium/src/+/5b0a370f79fa029a4b1a87f09186bfabbd108406 TBR=amineer@chromium.org,dpranke@google.com,dpranke@chromium.org,kmarshall@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=677556 Review-Url: https://codereview.chromium.org/2615633009 Cr-Commit-Position: refs/heads/master@{#441722}
-
gab authored
BUG=672860 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_tsan_rel_ng Review-Url: https://codereview.chromium.org/2596533002 Cr-Commit-Position: refs/heads/master@{#441721}
-
riajiang authored
After fixing WindowTreeClient::RequestClose(window_id) (https://codereview.chromium.org/2604453002/), there's no more place that calls WindowDelegate::OnRequestClose(). BUG=none Review-Url: https://codereview.chromium.org/2613963002 Cr-Commit-Position: refs/heads/master@{#441720}
-
brucedawson authored
These third_party directories were recently removed from DEPS. This removes a couple of references to them. R=scottmg@chromium.org BUG=149684 Review-Url: https://codereview.chromium.org/2611053002 Cr-Commit-Position: refs/heads/master@{#441719}
-
afakhry authored
Adding it such that it shows up in the product-specific data. BUG=676017 TEST=Start the feedback app, open the system information link, an entry named CHROMEOS_FIRMWARE_VERSION should be present with a valid value matching that in /var/log/bios_info.txt. Review-Url: https://codereview.chromium.org/2615603003 Cr-Commit-Position: refs/heads/master@{#441718}
-
asvitkine authored
Turns out, it can be triggered multiple times even if it ran already on the same instance which was unregistered. I discovered this in https://codereview.chromium.org/2561433002 but want to submit this separately since in theory this issue can still exist without that (although much rarer, since usually there's only a single async activity). BUG=632199 Review-Url: https://codereview.chromium.org/2612263003 Cr-Commit-Position: refs/heads/master@{#441717}
-
bnc authored
Also add http2/tools/random_util.{h,cc}. This CL lands server changes 129276755 and 130241330 by jamessynge. BUG=488484 Review-Url: https://codereview.chromium.org/2606733004 Cr-Commit-Position: refs/heads/master@{#441716}
-
xdai authored
This reverts commit 49ff2930. This CL (https://codereview.chromium.org/2605463003/) has been merged to M56, so revert it on Tot. A better fix will be landed later. BUG=675150 TBR=xiyuan@chromium.org Review-Url: https://codereview.chromium.org/2613993002 Cr-Commit-Position: refs/heads/master@{#441715}
-
kmarshall authored
R=amineer@chromium.org BUG=677556 Review-Url: https://codereview.chromium.org/2607973002 Cr-Commit-Position: refs/heads/master@{#441714}
-
cbiesinger authored
If IsFixedSize is true for a dimension, sets the override size accordingly, matching the code in ng_length_utils. Also adds a comment to ng_constraint_space.h for how this works (could've sworn that we already had such a comment) R=eae@chromium.org,atotic@chromium.org BUG=635619 Review-Url: https://codereview.chromium.org/2611033002 Cr-Commit-Position: refs/heads/master@{#441713}
-
mbrunson authored
Changes Snackbar#dismiss to return Promise that resolves when snackbar is fully dismissed. Add check for snackbar that's already dismissed to fix test issue where Snackbar is dismissed repeatedly. BUG=676227 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2602503002 Cr-Commit-Position: refs/heads/master@{#441712}
-
junov authored
This is an experimental prototype API for demonstrating a proposal to use promises instead of requestAnimationFrame for driving animations. This initial implementation uses a delayed task to simulate the BeginFrame signal. Properly hooking-up BeginFrame will be solved in a follow-up code change. This API was discussed here: https://github.com/whatwg/html/issues/2139 BUG=676131 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2594843002 Cr-Commit-Position: refs/heads/master@{#441711}
-
grt authored
BUG=305397 R=gab@chromium.org Review-Url: https://codereview.chromium.org/2611973002 Cr-Commit-Position: refs/heads/master@{#441710}
-
mthiesse authored
VrShell::ContentBoundsChanged was in physical pixels, while VrShellGl::ContentBoundsChanged was in dip. BUG= Review-Url: https://codereview.chromium.org/2612283002 Cr-Commit-Position: refs/heads/master@{#441709}
-
mthiesse authored
This saves ~21.6KB on debug component build, numbers should be similar for other builds. BUG=678636 Review-Url: https://codereview.chromium.org/2615013002 Cr-Commit-Position: refs/heads/master@{#441708}
-
vitaliii authored
Since we want it in M57 and the feature freeze is soon, it is time to enable it by default. BUG=646841 Review-Url: https://codereview.chromium.org/2613643003 Cr-Commit-Position: refs/heads/master@{#441707}
-
estade authored
BUG=624175 Review-Url: https://codereview.chromium.org/2612793006 Cr-Commit-Position: refs/heads/master@{#441706}
-
eugenebut authored
There are 8 fake classes and they deserve a separate directory. BUG=None Review-Url: https://codereview.chromium.org/2614443004 Cr-Commit-Position: refs/heads/master@{#441705}
-
georgesak authored
BUG=671743 Review-Url: https://codereview.chromium.org/2563473002 Cr-Commit-Position: refs/heads/master@{#441704}
-
pavely authored
The test was flaky because after triggering sync cycle it immediately checked for entity count condition without waiting for sync cycle to complete. I've verified that test fails consistently after adding delay in sync cycle. I've added WaitUntilConditionOrTimeout. BUG=672286 R=bzanotti@chromium.org Review-Url: https://codereview.chromium.org/2610303002 Cr-Commit-Position: refs/heads/master@{#441703}
-
stevenjb authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/bcd6eaeaf325..de4d8e3236c7 $ git log bcd6eaeaf..de4d8e323 --date=short --no-merges --format='%ad %ae %s' 2016-12-07 bhthompson Add the android branch name to the metadata json in the sync stage 2016-12-28 stevenjb deploy_chrome: Strip libwidevinecdmadapter.so 2016-12-21 akeshet reword build failure summary message in weekly email 2016-12-21 bhthompson cbuildbot: add more context for the --buildbot flag 2016-12-21 akeshet export_to_gcloud: factor out a bit of code to new shared dslib module 2016-12-21 akeshet cidb: add method for fetching actions since a given time 2016-12-20 akeshet extract_gerrit_history: crawl entire checkout to build database 2016-12-19 akeshet extract_gerrit_history: a script to build a gerrit # to commit database 2016-12-21 laszio afdo: generate llvm compatible afdo files 2017-01-03 vapier cros: deploy: fix typo in help message 2016-12-28 laszio samus-pre-flight-branch: disable hugepage when profiling 2016-12-16 ayatane [sysmon] Merge prodmon features into sysmon 2016-12-16 ayatane [sysmon] Extract _TimedCallback class 2016-12-16 ayatane [sysmon] Fix sysmon process detection 2016-12-16 ayatane [sysmon] Clean up osinfo module 2016-12-16 ayatane [sysmon] Move osinfo metrics to its own module 2016-12-16 ayatane [sysmon] Make PuppetRunSummary private 2016-12-16 ayatane [sysmon] Move osinfo cycles logic 2016-12-16 ayatane [sysmon] Remove useless constants 2016-12-16 ayatane [sysmon] Remove old requirements.txt 2016-12-16 ayatane [sysmon] Move loop class to its own module 2016-12-16 ayatane [sysmon] Remove __init__ hack 2016-12-16 ayatane Use full virtualenv for sysmon 2016-12-22 nxia Move BuilderStatus from manifest_version to build_status. 2016-12-21 nxia Move CL gerrit messages to cl_messages.py 2016-12-21 nxia Move PatchSeries and HelperPool to patch_series module 2016-12-21 ayatane Use explicit virtualenv in virtualenv_wrapper 2016-12-22 chrome-bot Update config settings by config-updater. 2016-12-21 vapier flash: relax PMBR requirement with input image checks 2016-12-15 yueherngl poppy: add builder configuration 2016-12-16 nxia Skip recording metrics for repo.sync on local manifest path. 2016-12-16 nxia Retry git fetch on 'Connection refused' error. 2016-12-15 dgarrett SignerTestsBuilder: Use PreCQSyncStage. 2016-12-19 pprabhu summarize_build_stats: Fix report generation typo. 2016-12-20 vapier paygen: filelib_unittest: avoid using xxd 2016-12-16 pprabhu metrics: Don't raise on nested steps. 2016-12-20 nxia Rename build_info_dict to buildbucket_info_dict 2016-12-14 nxia Retry slaves which failed to pass the critical stages. 2016-12-13 nxia GetSlaveFailures in given buildbucket_ids list. 2016-12-13 nxia GetSlaveStages in given buildbucket_ids list. 2016-12-13 nxia GetSlaveStatues in given buildbucket_ids list. 2016-12-16 nxia Use Buildbucket to schedule chrome-pfq slaves. 2016-12-14 stevenjb deploy_chrome: Make widevine conditional, not optional BUG=none Review-Url: https://codereview.chromium.org/2616763002 Cr-Commit-Position: refs/heads/master@{#441702}
-
jialiul authored
And resolve all the dependencies and tests and so on. BUG=666100 Review-Url: https://codereview.chromium.org/2603433002 Cr-Commit-Position: refs/heads/master@{#441701}
-
mdjones authored
For the remaining cases where the renderer tries to connect to a nonexistent DistillabilityService, make sure the connection was successful before sending a message. BUG=661417 Review-Url: https://codereview.chromium.org/2469803002 Cr-Commit-Position: refs/heads/master@{#441700}
-
fdoray authored
From base/time/time.h: All time classes are copyable, assignable, and occupy 64-bits per instance. As a result, prefer passing them by value: BUG=553459 Review-Url: https://codereview.chromium.org/2611753004 Cr-Commit-Position: refs/heads/master@{#441699}
-
mvanouwerkerk authored
BUG=616090 Review-Url: https://codereview.chromium.org/2608333004 Cr-Commit-Position: refs/heads/master@{#441698}
-
skia-deps-roller authored
https://skia.googlesource.com/skia.git/+log/56770752c28d..ac1f09d53bfe $ git log 56770752c..ac1f09d53 --date=short --no-merges --format='%ad %ae %s' 2017-01-05 msarett Delete SkMakeImageFromPixelRef Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=csmartdalton@google.com Review-Url: https://codereview.chromium.org/2618593003 Cr-Commit-Position: refs/heads/master@{#441697}
-