- 05 Mar, 2020 40 commits
-
-
Jose Lopes authored
This is a repeating callback because it's called from a call chain that links to a loop: * https://cs.chromium.org/chromium/src/media/formats/mp2t/mp2t_stream_parser.cc?rcl=385d1322d09f871a327371f0ded2b2d70714bde2&l=873 * https://cs.chromium.org/chromium/src/media/formats/mp2t/mp2t_stream_parser.cc?rcl=385d1322d09f871a327371f0ded2b2d70714bde2&l=139 * https://cs.chromium.org/chromium/src/media/formats/mp2t/mp2t_stream_parser.cc?rcl=385d1322d09f871a327371f0ded2b2d70714bde2&l=345 This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 1007806 Change-Id: I51a2e7a5b0fe87b114cbedabe2040961d3bb6215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080417 Commit-Queue: Jose Lopes <jabolopes@google.com> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#747205}
-
Vidhan authored
[Autofill] Rename GetElidedValueAt to GetSuggestionValueAt and GetElidedLabelAt to GetSuggestionLabelAt Bug: 1045401 Change-Id: I746756c64e4c9a7e528c6a9441d6b0a777600f64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087624 Commit-Queue: Vidhan Jain <vidhanj@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#747204}
-
Anastasiia Nikolaienko authored
Add Polymer template for the views in login flow, component for buttons and CSS. See http://doc/1WVGl7i7uWTnMEa3MPPVALegDM-7RabDv6z3JrAw53Sg Bug: 1043108 Change-Id: I70d4a1e75e3cdf8889ce211eacb7946db09cba9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007455 Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#747203}
-
Jérôme Lebel authored
The activity indicator is created when needed. It should not be added in -[UserSigninViewController viewDidLoad]. The constraints are correctly created when the indicator is created, in -[UserSigninViewController addActivityIndicatorToView]. Bug introduced with: crrev.com/c/2087214 Related to: crrev.com/c/2079111 Bug: 971989 Change-Id: Id0e08b6884c6c05e15516d987c062eaf691345b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087922 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#747202}
-
Adrienne Walker authored
IndexedDBContext access is going away, and so these tests need to use public mojo interfaces instead of private indexeddb interfaces. This converts some easier browser tests over to using the new interface. Bug: 1015214 Change-Id: I68bb1cd46ff6ae13d8b113d37886a499e0d97276 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088337Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Auto-Submit: enne <enne@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#747201}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/97a3ce0918a0..da7fe17f810a git log 97a3ce0918a0..da7fe17f810a --date=short --first-parent --format='%ad %ae %s' 2020-03-05 primiano@google.com Merge "UI: restrict non-ready features to internal users only" Created with: gclient setdep -r src/third_party/perfetto@da7fe17f810a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I6fb51c1a49093c8bca072cf30ba5b6019e055f39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089029Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747200}
-
Clemens Arbesser authored
This CL also adds support for user actions (e.g., Chips) to the UI framework. User actions now have an optional identifier to properly tie them together with interactions. Bug: b/145043394 Change-Id: Ia72807525063362750eeaca55c455a594c084b5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080267 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#747199}
-
Omer Katz authored
This CL also adds tests to catch this data race and re-enables the incremental marking test that was disabled because of it (CL 2087957). Bug: 986235, 1058622 Change-Id: Icfb06fb08aaede2b20ef89ebcf8406d314577128 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088514Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#747198}
-
Eric Willigers authored
TabbedHostedAndBookmarkApps and WindowedHostedAndBookmarkApps tests are replaced with TabbedHostedAndWebApps and WindowedHostedAndWebApps tests that use no Extensions APIs to create or inspect web apps. Bug: 1054116 Change-Id: Ib3713f63cc9e0708cca7dbebc674ba610ec439b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087309Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#747197}
-
Anna Malova authored
Bug: 1007815 Change-Id: I8074e7e9cb2c59ceb9f06b25259170e1d1bb47ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087348Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Anna Malova <amalova@chromium.org> Cr-Commit-Position: refs/heads/master@{#747196}
-
Jose Lopes authored
This is a repeating callback because it's called from a for loop: * https://cs.chromium.org/chromium/src/media/formats/mp2t/ts_section_pmt.cc?rcl=2072c031d444a367084f6fc8f766b264316b451c&l=111 This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 1007806 Change-Id: I45c07133eed8afd6894c22caa7ef4ff0a4f6167a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080363 Commit-Queue: Jose Lopes <jabolopes@google.com> Reviewed-by:
-
Mark Cogan authored
Removes the final call site for the NTP uma function that used TabModelList to get the active web state. Bug: 1032550 Change-Id: Id4630e2691efd7d60febea20e15bd7fcfe3ff1cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085271Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#747194}
-
Gauthier Ambard authored
The protocol is no longer used as a protocol. The only used in test was looking for a ViewController and it is now only implemented in a Coordinator. Bug: 1038034 Change-Id: Id6ba52f59c484f3b769cee7204c797aef6fc88ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083329 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#747193}
-
Mikel Astiz authored
Change-Id: I71239f7e49bd6b2c19a6a526a2a800108154e3cc Bug: 978430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077717 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#747192}
-
chromium-autoroll authored
Roll silvermont AFDO profile from 82-4044.31-1583145468-benchmark-82.0.4072.0-r1 to 82-4044.31-1583145468-benchmark-82.0.4077.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I9aa67a7dbe78e71d7d30c801fcda4cee7515c4a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089372Reviewed-by:
-
Antonio Gomes authored
This CL ends up also converting ViewHostMsg_DidContentsPreferredSizeChange to mojo as well. The reason is because it happens that blink.mojom.LocalMainFrame.EnablePreferredSizeChangedMode() can trigger the invocation of blink.mojom.LocalMainFrameHost.ContentsPreferredSizeChanged(), but the later can also be invoked independently of the former, hence it is not a "completion callback" like mojo message. Target mojo interfaces are LocalMainFrame/LocalMainFrameHost, respectively. Some of the methods and class variable in RenderViewImpl got moved as-is to WebViewImpl, including: - RenderViewImpl::OnEnablePreferredSizeChangedMode() - RenderViewImpl::UpdatePreferredSize() - RenderViewImpl::send_preferred_size_changes_ - RenderViewImpl::needs_preferred_size_update_ - RenderViewImpl::preferred_size_ The call flow now for mojo.EnablePreferredSizeChangedMode() is browser -> mojo EnablePreferredSizeChangedMode -> blink::LocalFrame -> blink::ChromeClient -> blink::WebViewImpl. BUG=1051155 R=dtapuska@chromium.org Change-Id: I3c6fdc73f9d41b30aeee1f6214ee8a0db6abc76e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068699Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll broadwell AFDO profile from 82-4044.31-1583147204-benchmark-82.0.4075.0-r1 to 82-4044.31-1583147204-benchmark-82.0.4077.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I42d38cddcd00319575213c10a0483130fd483d6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089373Reviewed-by:
-
Finnur Thorarinsson authored
The test selects the first photo, scrolls to the bottom and back up to the top to make sure the selection border is active and of correct size (old bug I encountered once). This should also function as a regression test for bugs like the one seen in issue 1051523 (where a white circle got overlaid on top of all photos). Bug: 1051523, 656015 Change-Id: Ifb119c5e9450be5ef06b303eb3549315c0e4a623 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083178 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#747188}
-
Rushan Suleymanov authored
Add checks during initial update to investigate some crashes. Some checkers guarantee that index will never be out of range for children nodes. It might lead to creating of null bookmark nodes. Bug: 1050776 Change-Id: I2ae5662620ea2b6c9cf8880c205af5f6ec818784 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082383Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#747187}
-
Francois Beaufort authored
This CL makes sure a message is shown to the user when NFC is not supported on the device while Web NFC access has been granted to a website. Messages show up in page info popup and site settings UI. Screenshots: https://bugs.chromium.org/p/chromium/issues/detail?id=1058217#c2 Bug: 1035048, 1055216, 1058217 Change-Id: I4687a353feedd92e233ae1741738aef9bb774ad0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077685 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#747186}
-
Mark Cogan authored
This straightforwardly replaces the use of TabModelList to use BrowserList. Technically this is a functional change because it will check if the passed URL is open in any tab in any window, but that was presumably the desired behavior in the first place. Bug: 1058332 Change-Id: I52075acd0b6e3fa0ccd3bad69ee810769f1031f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087333Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c55fbc4064aa..343ee4e801b1 git log c55fbc4064aa..343ee4e801b1 --date=short --first-parent --format='%ad %ae %s' 2020-03-05 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src 8985fc91089f..c6a4c6d3d8b5 (2 commits) Created with: gclient setdep -r src/third_party/angle@343ee4e801b1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: ianelliott@google.com Change-Id: I863f19d29a2dab725901a17fb74c188412f83ab0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089023Reviewed-by:
-
David Roger authored
The feature using this histogram was not launched yet, and this histogram is still needed for a couple months. This CL extends the lifetime to match Profile.Menu.OpenedAfterAvatarAnimation. These two histograms can then be deprecated after the butter status chip is launched. Fixed: 1043731 Change-Id: I5c0cb055baaf46a45c7d71a13d3c5946a2880f26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087680Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#747183}
-
Noel Gordon authored
This reverts commit e909f808. Reason for revert: I believe this change broke the breadcrumb elider button drop-down menu. No manual test of this change it seems. Original change's description: > Use SVG icon for files-ng elider button > > Bug: 1035691 > Change-Id: I4aac6e02a90dd7e466f937e7f77a928480fb14e5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087860 > Commit-Queue: Alex Danilo <adanilo@chromium.org> > Commit-Queue: Noel Gordon <noel@chromium.org> > Reviewed-by: Noel Gordon <noel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#747113} TBR=noel@chromium.org,adanilo@chromium.org Change-Id: I8764d88a5cfaf1565abfb14762983a21254b8c41 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1035691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089431Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#747182}
-
Sylvain Defresne authored
Assigning a relative value to ios_sdk_platform_path does not work as the variable is used by more than one target/config as some of them are from a different level in the directory hierarchy (thus they require a different rebased value). Instead change build/config/mac/sdk_info.py to output a path that is relative to root_source_dir (i.e. a path starting with //) and fixes the different usage of the ios_sdk_platform_path variable to do the rebase_path as required. Bug: 1058221 Change-Id: I41545765dbf66efb96b8d00246bfe1856dba9bea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087219 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Simon Que <sque@chromium.org> Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#747181}
-
chromium-autoroll authored
Roll airmont AFDO profile from 82-4044.31-1583148634-benchmark-82.0.4075.0-r1 to 82-4044.31-1583148634-benchmark-82.0.4077.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I32034757c7d1bd912a42225296b767d8104e5ca6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089030Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dcb8686f7685..968c87018591 Created with: gclient setdep -r src-internal@968c87018591 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1044616 Tbr: jbudorick@google.com Change-Id: Id042625de2b14ce1722e1f6916e15b63173a21aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089025Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747179}
-
Stepan Khapugin authored
Moves -startUpChromeUIPostCrash:needRestoration: method to SceneController. Bug: 1045658 Change-Id: I3d3890b1480dfe1facfbfe58e01cc4bb8ffd7521 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087614 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/a6d3a2dd41d4..044ecc0b2c65 git log a6d3a2dd41d4..044ecc0b2c65 --date=short --first-parent --format='%ad %ae %s' 2020-03-04 afdx@google.com spirv-fuzz: Fuzzer pass to add equation instructions (#3202) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@044ecc0b2c65 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,ianelliott@google.com Change-Id: I6e7df5c3000ccafad6e90b678d637acd80ea26cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089022Reviewed-by:
-
Yutaka Hirano authored
1: https://crrev.com/c/2074177 2: https://crrev.com/c/2075002 3: [this] This series of CLs implements https://github.com/mikewest/corpp/pull/9. We introduce network::mojom::CrossOriginEmbedderPolicyReporter and its implementation content::CrossOriginEmbedderPolicyReporter, implement the reporting logic in content::CrossOriginEmbedderPolicyReporter and the CORP check, and plumb the mojo interface. This CL creates CrossOriginEmbedderPolicyReport during the frame navigation and dedicated worker initialization, and give it to the network service so that (possibly potential) CORP blocks are reported. Bug: 1052764 Change-Id: Ia39ff8277eb23d96025f5e6fba4e5a4fa6ffde70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076223 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
-
Colin Blundell authored
This CL is another step toward the componentization of ExternalNavigationHandler.java for sharing with WebLayer. It removes the dependence that ExternalNavigationHandler.java currently has on //chrome's WebappScopePolicy.java. This dependence is to assist in determining whether the user is navigating within the context of an installed PWA within which the intent should stay. At this point in time, this is //chrome-level functionality. Hence, we abstract this check through ExternalNavigationDelegate. Bug: 1031465 Change-Id: I65869090553f2cf337db39cfbb9aaac6d341f7e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087678 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#747175}
-
Yutaka Hirano authored
Yoichi landed many CLs for https://crbug.com/865001 and https://crbug.com/967524 and I think it's good to have him as an OWNER. Bug: None Change-Id: I5e3b8d9b362a18d53cdca383cc1c61a9b3beb993 No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086389 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
-
Stepan Khapugin authored
Moves some process-scoped code from -startUpChromeUIPostCrash:needRestoration: * Break down scheduleTasksRequiringBVCWithBrowserState to not include promo-related code. Promo logic will move to Scene. * Move some calls to startUpAfterFirstWindowCreated Bug: 1045658 Change-Id: Iab374d1fc4befedf1f51713d13e00ba4d108c02d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087334 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
-
Yutaka Hirano authored
1: https://crrev.com/c/2074177 2: [this] 3: https://crrev.com/c/2076223 This series of CLs implements https://github.com/mikewest/corpp/pull/9. We introduce network::mojom::CrossOriginEmbedderPolicyReporter and its implementation content::CrossOriginEmbedderPolicyReporter, implement the reporting logic in content::CrossOriginEmbedderPolicyReporter and the CORP check, and plumb the mojo interface. This CL implements the reporting logic in the CORP check. Bug: 1052764 Change-Id: Ia3c4d3aec886c76be6dd32083809e9e447ce2a4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075002 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
-
Miriam Zimmerman authored
This will help the telemetry team debug consent flakes in integration tests. BUG=1041062 TEST=modified KernelWarning to use appropriate verbose flag and \ `tast run --extrauseflags chrome_internal $DUT platform.KernelWarning` Change-Id: I050b43b1a8578ce427ca9974c237f133115161de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082918Reviewed-by:Ian Barkley-Yeung <iby@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Auto-Submit: Miriam Zimmerman <mutexlox@chromium.org> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#747171}
-
Yutaka Hirano authored
1: [this] 2: https://crrev.com/c/2075002 3: https://crrev.com/c/2076223 This series of CLs implements https://github.com/mikewest/corpp/pull/9. We introduce network::mojom::CrossOriginEmbedderPolicyReporter and its implementation content::CrossOriginEmbedderPolicyReporter, implement the reporting logic in content::CrossOriginEmbedderPolicyReporter and the CORP check, and plumb the mojo interface. This CL introduces network::mojom::CrossOriginEmbedderPolicyReporter and its implementation content::CrossOriginEmbedderPolicyReporter. Bug: 1052764 Change-Id: I7ccce3e39c760393bf2d1b73786cf2a7ae838fde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074177Reviewed-by:
-
Adam Rice authored
http/tests/streams/chromium/get-reader-byob.html is timing out on the Fuchsia bots some times. Mark it as flaky in TestExpectations. BUG=1057020 Change-Id: I53f94f98e738682b6ede5efc649cc8e883b27370 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078380 Commit-Queue: Adam Rice <ricea@chromium.org> Auto-Submit: Adam Rice <ricea@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#747169}
-
Benjamin Beaudry authored
An issue came up with CreateAdjacentLeafTextPosition(), used to create boundaries start/end positions in ax_position.h and help with text navigation. It was caused by the UIA-only concept of embedded object replaced by the empty object character when all children of a node are ignored. One of the conditions for a node to be considered as an embedded object was to look at its child count: if it had at least one child, it could not be an "empty object". However, a corner case where a button (or any other control) contains an empty div forces us to modify this condition. Consider the following example: **************************************** <button> | <div></div> | </button> | | would result in the following AXTree: | | ++kButton | ++++kGenericContainer ignored | | **************************************** Because the button node contains one child, it is not considered as an empty object replaced by character. However, because this button has no text content and its child is ignored, nothing will be exposed to text range provider. Furthermore, CreateAdjacentLeafTextPosition() will not be able to create a position in the button even though it should. This will result in the button being either skip (thus inaccessible) or causing Narrator to get stuck on this node when in Scan Mode. This CL fixes the issue with a two steps solution: 1. If all children of a node are ignored, we might consider it to be an empty object replaced by character even though it has a child or more. Remember that this logic is only activated by UIA. 2. I introduced AXPosition::IsLeaf, which returns true when a node has no child or is an empty object replaced by character. Now, when we call CreateNextLeafTextPosition (or any other similar method) right before a button that contains an empty div, the position created will be inside the button node and not inside of its leaf ignored node. Final note: it is important from now on to call IsLeaf() instead of AnchorChildCount() in ax_position.h to determine if a node is a leaf. We shouldn't notice a perf difference, since IsEmptyObjectReplacedByCharacter is of constant complexity (+ it has a shortcut that returns false when called by something else than our UIA implementation). Bug: 928948 Change-Id: If95281745d1c8dda3e646dba00923791cc1af7e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079619 Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Reviewed-by:Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Ethan Jimenez <ethavar@microsoft.com> Cr-Commit-Position: refs/heads/master@{#747168}
-
Jose Lopes authored
This is a repeating callback because it's called from a for loop: * https://cs.chromium.org/chromium/src/media/formats/mp2t/ts_section_pat.cc?rcl=12cb56005b4e382d8ba25cec382deb04bc024369&l=105 This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 1007806 Change-Id: I3fd346d4f02ea0281a9eb716090ff76cdf6d5a73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080359 Commit-Queue: Jose Lopes <jabolopes@google.com> Reviewed-by:
-
Rushan Suleymanov authored
This patch introduces timeout error code which will be used every time when the bridge didn't get response on sent message. Bug: 1056210 Change-Id: I026769097d7eba349e90e5f292123a9ed323e489 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082923Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#747166}
-
