- 27 Feb, 2020 40 commits
-
-
Takashi Sakamoto authored
This reverts commit 7767aa96. Reason for revert: suspect causing compile failure on android-archive-rel Sample build: https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/9648 Sample log: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8887341380366474896/+/steps/compile/0/stdout?format=raw ---- ../../chrome/android/features/tab_ui/javatests/src/org/chromium/chrome/browser/tasks/tab_management/TabGroupUiTest.java:70: error: cannot find symbol CachedFeatureFlags.setGridTabSwitcherEnabledForTesting(true); ^ symbol: method setGridTabSwitcherEnabledForTesting(boolean) location: class CachedFeatureFlags ../../chrome/android/features/tab_ui/javatests/src/org/chromium/chrome/browser/tasks/tab_management/TabGroupUiTest.java:71: error: cannot find symbol CachedFeatureFlags.setTabGroupsAndroidEnabledForTesting(true); ^ symbol: method setTabGroupsAndroidEnabledForTesting(boolean) location: class CachedFeatureFlags ../../chrome/android/features/tab_ui/javatests/src/org/chromium/chrome/browser/tasks/tab_management/TabGroupUiTest.java:83: error: cannot find symbol CachedFeatureFlags.setGridTabSwitcherEnabledForTesting(null); ^ symbol: method setGridTabSwitcherEnabledForTesting(<null>) location: class CachedFeatureFlags ../../chrome/android/features/tab_ui/javatests/src/org/chromium/chrome/browser/tasks/tab_management/TabGroupUiTest.java:84: error: cannot find symbol CachedFeatureFlags.setTabGroupsAndroidEnabledForTesting(null); ^ symbol: method setTabGroupsAndroidEnabledForTesting(<null>) location: class CachedFeatureFlags 4 errors ---- Original change's description: > Make tab strip auto scroll to position of the selected tab > > Currently, when a tab in group is selected or a new tab is created > within group, the tab strip doesn't scroll to the position of the > currently selected tab. This could lead to a state where user needs to > scroll by themselves to find their selected tab in strip. This CL fixes > this issue by making following changes: > * Always scroll the strip to the last position when new tab is added > in group. > * When selected a tab in group (through tab grid dialog etc), try to > scroll to a state where the selected tab is in the middle of the > strip, if possible, > > Bug: 1054079 > Change-Id: Ic6921225d744a7b5df1853aa78e14a8f9249f2c8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068888 > Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#744892} TBR=yusufo@chromium.org,wychen@chromium.org,yuezhanggg@chromium.org Change-Id: I8db970a5e6c2338ce19c8870964b96c48e66eb44 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1054079 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076219Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#744908}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f8918f99..60a026a7 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I76ba5100a4dfd5b9eb9e47bff8e1366f9bfd9226 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076357Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744907}
-
Zhenyao Mo authored
The DevicePerfInfo is mostly collected in the info collection GPU process, but recorded in the browser process, once per UMA ping. BUG=1039792 TEST=manual R=magchen@chromium.org,isherman@chromium.org Change-Id: I1b197e14b050bd370aa7a48d0a92237d007fe42c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068867 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#744906}
-
Julie Jeongeun Kim authored
This change introduces a mechanism to enable accessibility (on auralinux) by creating the kApplication node and waiting until there is a API query to enable accessibility fully. This is done to ensure chromium will avoid performance overhead for users who don't need accessibility, by not creating ATKObjects when they are not being used. Accessibility is enabled when one of two conditions are met: 1. A client queries an ATKObject API. 2. An AXMode is set on AccessibilityNotificationWaiter (used during testing). This is implemented by using AXMode set on the AXPlatformNode, when this is set it will allow for all ATK objects to be created. This change does not remove the need to specify environmental variables and the commandline flag. The original author of this patch is Jessica Tallon<jtallon@igalia.com> Bug: 977112 Change-Id: Ie5e46347296507d214df345320d3d58c9921c84d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060359Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#744905}
-
John Lee authored
Fixed: 1056293 Change-Id: I988cd0d273bd8d5a2e771181f3da7f186b013acf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075545 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#744904}
-
Fergal Daly authored
Capture the URLs involved. Also: - fix the crash key string so that the labels match the values - add GetRenderFrameProxyHost(instance) - change the crash key string name to have no spaces in the hope that it will show up in the crash dashboard - use DEBUG_ALIAS_FOR_CSTR to capture it so that it definitely shows up in the minidump Bug: 1006814 Change-Id: I1528408203ff789436abb50bcd15f06a03a9b4ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072523 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#744903}
-
Nick Diego Yamane authored
Recent changes in LinuxInputMethodContextFactory initialization (see crrev.com/c/2062974) broke ozone/x11. After it, browser crashes at startup. This fixes it as well as adds DCHECK to make sure LinuxInputMethodContextFactory is correctly set just after LinuxUI initialization. Bug: 1055061 Change-Id: Iefe5acc48ec9047b90042b398159e9b260a753f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069229 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Maksim Sisov <msisov@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#744902}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/f0cc231dab7d..9931e7a88ec3 git log f0cc231dab7d..9931e7a88ec3 --date=short --first-parent --format='%ad %ae %s' 2020-02-27 btolsch@chromium.org Add CastPlatformClient for handling sender requests 2020-02-27 miu@chromium.org Add IPEndpoint::Parse(). Created with: gclient setdep -r src/third_party/openscreen/src@9931e7a88ec3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I3b9795f4f510655751ffc3af80f7713934f8ba76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075419Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744901}
-
Eric Willigers authored
With a flaky network connection, ExternalWebAppManager may request an app whose manifest cannot currently be retrieved. We emulate this scenario in a browser test by specifying a manifest known not to exist. Note that when the requested user display mode is 'standalone', the effective display mode will be 'minimal-ui' as the app display mode defaults to 'browser' in the absence of a manifest. Bug: 1055523 Change-Id: Ie7ebf42f95891f7e3eb65d3328d85104585f749a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076739 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#744900}
-
Rachel Carpenter authored
This means that searching for "Help" will suggest the app, even if that string is not in the app name. Bug: b/138968583 Change-Id: Iaee7168c4f6c897b62bc24cd74072b1045ae946a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071462 Commit-Queue: Rachel Carpenter <carpenterr@google.com> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#744899}
-
Jeremie Boulic authored
The objective is the keep the StorageHandler simple, getting requests from the UI side and returning the requested numbers. The logic for the calculation of the storage items is moved outside of the StorageHandler. The StorageHandler is observing storage size changes and sending the numbers back to the UI side. For each storage item, a test api is defined as a friend class, allowing access to private methods in tests. size_calcualtor_test_api.h is only linked in the unit_tests target. Bug: 1051364 Change-Id: I1eacf84f80b649fed1e63c92fca8e03b821c2f4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051785 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#744898}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b847c567e717..005269a51304 git log b847c567e717..005269a51304 --date=short --first-parent --format='%ad %ae %s' 2020-02-26 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@005269a51304 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I4c0977648b01db5b3cb9e716cadebdff84f29c18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076327Reviewed-by:
-
Fabian Sommer authored
Move strings and logic related to error messages in security token pin request dialogs (for smart cards on CrOS) from chrome/browser to chromeos/components/. This anticipates the need for these messages in ash/ for security token pin requests during user login. Bug: 1001288 Change-Id: I449ad0c0faf12fa6b7bb389267f87e51f72844fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035890Reviewed-by:
Jungshik Shin <jshin@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#744896}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/31a7b072ddf4..913a2ec17514 git log 31a7b072ddf4..913a2ec17514 --date=short --first-parent --format='%ad %ae %s' 2020-02-27 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@913a2ec17514 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jlavrova@google.com Change-Id: I93e28b956b3d2d151ae0da13b67e28246069b504 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076547Reviewed-by:
-
dpapad authored
Fixed: 1051028 Change-Id: Idbc089542c4d2adccb9e5d3bdf7eea2eaf4e0c1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076757 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#744894}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/694f0d3726a4..8f58baae1a1d Created with: gclient setdep -r src-internal@8f58baae1a1d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ib482ff0725c956fad4f5347ea38d65548d31673e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076326Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744893}
-
Yue Zhang authored
Currently, when a tab in group is selected or a new tab is created within group, the tab strip doesn't scroll to the position of the currently selected tab. This could lead to a state where user needs to scroll by themselves to find their selected tab in strip. This CL fixes this issue by making following changes: * Always scroll the strip to the last position when new tab is added in group. * When selected a tab in group (through tab grid dialog etc), try to scroll to a state where the selected tab is in the middle of the strip, if possible, Bug: 1054079 Change-Id: Ic6921225d744a7b5df1853aa78e14a8f9249f2c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068888 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#744892}
-
Chris Cunningham authored
Sudden spike in flakes. No obvious culprit. First failed build is here. https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/17265 Bug:1056429 Change-Id: I209f8e971a08ccce0b6b64ea8676db2789701efd TBR=antrim@chromium.org Change-Id: I209f8e971a08ccce0b6b64ea8676db2789701efd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076549Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#744891}
-
Mason Freed authored
The [1] CL enabled the FormControlsRefresh feature by default for Mac. (The [2] CL enabled it earlier for Windows, Linux, and ChromeOS.) In the process, many layout tests were disabled, because the form controls have a different appearance with the feature enabled. This is one of several patches rebaselining those disabled tests. [1] http://crrev.com/c/2063530 [2] http://crrev.com/c/1967608 Bug: 1053725 Change-Id: I9646f9ca58c173da884c3bcb52b39f39f3326dd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071739 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#744890}
-
John Budorick authored
Noticed this following a discussion about the possibility of gatekeeper for branches. Change-Id: I6b77691936591bd3e6ad8e9938f58e4c742df4af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076535Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#744889}
-
sczs authored
We now are sending the animated parameter into dismissViewControllerAnimated, and not YES. Everytime a Banner is finished being presented bannerIsBeingDismissed is set to NO, that way the only way to dismiss a Banner again is to present a new one. Bug: 1049088 Change-Id: Id1bc2adc0bc84a417f2bb320ca815673830b7bfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075658Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#744888}
-
Joe Mason authored
Add chrome-memory@google.com as an owner so a larger group will be notified when they expire in a year. Change-Id: I7675e59d27b4d6647fa936fb5da56a41a15e8b05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072585Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#744887}
-
Mike Wittman authored
Extends the ModuleCache API to support removing non-native modules via a function that handles adding and removing modules in bulk. This is required for the new V8 unwind API which provides a dynamically updated list of modules at each sample, rather than a static set over the lifetime of the profile collection. Changes the internal native module representation to a set to support efficient lookup. The new V8 unwind API could provide hundreds of modules rather than the few in the existing API. Bug: 1035855 Change-Id: Ib8bc854b613db6f76d55d69aa440067c456e7900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067092Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#744886}
-
dalyk authored
In cases where the secure DNS setting is forcefully overridden by Chrome (e.g. detection of parental controls), this cl replaces the setting subtitle with an explanation. In these cases as well as when the underlying prefs are managed, the setting is locked and the radio buttons are not shown. Change-Id: I27e5b580e09f43bd36a4a924ce4795c06c947c44 Bug: 1040145 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984660 Commit-Queue: Katharine Daly <dalyk@google.com> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#744885}
-
nancy authored
AppUninstallDialogView replaced the ARC uninstall dialog. https://cs.chromium.org/chromium/src/chrome/browser/ui/views/apps/app_uninstall_dialog_view.h?l=44 Remove ARC uninstall dialog to prepare for "Uninstall" dialog language consistency. Because some variables are used by ARC uninstall dialog, e.g. IDS_APP_UNINSTALL_PROMPT_TITLE, and those variable can be re-used for the AppUninstallDialogView. BUG=1010303 Change-Id: I8af8feb2dfaed62ce5a9ee3c87a490d0af1ff469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073179Reviewed-by:
-
Christopher Thompson authored
This special-cases the LEGACY_TLS status in Page Info on Desktop so that it doesn't cause the certificate to be marked as "Invalid". This also updates the identity status logic to always check and mark legacy TLS pages so that we use the more specific security summary text (which refers to outdated security configurations specifically) for sites that use legacy TLS. Bug: 1056376 Change-Id: I399b79832ba6ffd0b82f8906bc09afe0576c198b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076517Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#744883}
-
sczs authored
These were only needed for iOS10 Bug: 863606 Change-Id: Ie57563c89abc7848d9731d007624c0425205028f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058083Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Auto-Submit: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#744882}
-
Hiroki Sato authored
This is a preparation of exposing accessibility actions of type expand/collapse from Android. Currently there are 32 accessibility actions including kNone, and AXNodeData holds action information as 32 bit integer. This CL changes it to use 64 bit. This CL also changes AddState, RemoveState, AddAction not to return mojom enum because the returned value doesn't makes sense now. Bug: none Test: accessibility_unittests --gtest_filter="AXNodeDataTest*" Change-Id: I07b35f3d2c00c49a74dfdd0af041f7f7e2b4f04b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071520Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Cr-Commit-Position: refs/heads/master@{#744881}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d9a5b6e2c1d2..e7fcd7dde1d9 git log d9a5b6e2c1d2..e7fcd7dde1d9 --date=short --first-parent --format='%ad %ae %s' 2020-02-26 aerotwist@chromium.org Reland "[e2e] Add user metrics tests" 2020-02-26 tvanderlippe@chromium.org Remove tsbuildinfo files from ts_library outputs Created with: gclient setdep -r src/third_party/devtools-frontend/src@e7fcd7dde1d9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1044632,chromium:1053887 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5edb8a6a513e7ad7bc1329bd0798df872e478d02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076322Reviewed-by:
-
Chris Cunningham authored
TBR=afakhry@chromium.org Bug: 1049178 Change-Id: I82ef50ebf23e905f45c0bcdc8f3ac4b31cfd026c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075400Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#744879}
-
Yue Zhang authored
After http://crrev.com/c/2026380, TabGridIphItemTest is no longer in use. This CL removes this test class. Bug: 1002678 Change-Id: I00e7cfaca83ec42d45143ef70eef31bc837ba670 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076079 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/8aea6d5a87b8..0a450363dbdc git log 8aea6d5a87b8..0a450363dbdc --date=short --first-parent --format='%ad %ae %s' 2020-02-26 jmadill@chromium.org Fix MultipleDrawBuffers sample. 2020-02-26 tobine@google.com Vulkan:Include precision qualifier in GLSL Created with: gclient setdep -r src/third_party/angle@0a450363dbdc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: geofflang@google.com Change-Id: Icd5d5dee4f3fdafd83281f057e9223f7422e41ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076319Reviewed-by:
-
Henrique Ferreiro authored
ui::CursorType and ui::mojom::CursorType where duplicated enums. This CL extracts the mojom version into its own file to allow ui::Cursor to depend on it avoiding a dependency cycle. It also migrates the codebase to use that version and removes the then unused cursor_types.h. Bug: 1040499 Change-Id: Ic913047a283cf03d0c5fc5f61ee6853d2aa789c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052103Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#744876}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/9abfc467c79f..624dae6917b2 git log 9abfc467c79f..624dae6917b2 --date=short --first-parent --format='%ad %ae %s' 2020-02-26 dberris@chromium.org Pinpoint: Preserve parsing specific failures Created with: gclient setdep -r src/third_party/catapult@624dae6917b2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1041818 Tbr: sadrul@google.com Change-Id: I6594e7fdb7f72801cf958a0c3e24d0eee1e6868f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076323Reviewed-by:
-
James Cook authored
The file is only compiled on Chrome OS, so the #if isn't needed. Bug: none Change-Id: I6dc128fab4527e12c7d26593922d06143b567343 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073220 Auto-Submit: James Cook <jamescook@chromium.org> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#744874}
-
David Staessens authored
This CL moves the AlignedAllocator used in the video encode accelerator unittest to the video test helpers. This allows it to be reused in a subsequent CL introducing new video encoder tests. TEST=./video_encode_accelerator_unittest on nocturne BUG=1045825 Change-Id: I6a4d837d6f365d6b79878a35b69a5f3267a69c8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026513 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#744873}
-
Rakesh Soma authored
This can happen in the "AD existing user" scenario where there is no email associated for the ReauthCredential Bug: 1055719 Change-Id: Id6be3412875c9c117da7fb4f36fff20967734620 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075974Reviewed-by:
Yusuf Sengul <yusufsn@google.com> Commit-Queue: Rakesh Soma <rakeshsoma@google.com> Auto-Submit: Rakesh Soma <rakeshsoma@google.com> Cr-Commit-Position: refs/heads/master@{#744872}
-
David Staessens authored
This CL Merges the video_accelerator_unittest_helpers.h into the video_test_helpers.h file, to make the video test code cleaner. TEST=./video_encode_accelerator_unittest on nocturne BUG=1045825 Change-Id: I676906f27e5738efb6bd4601c2c715a65592b8e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026632 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Reviewed-by:
-
David Tseng authored
See go/unified-accessibility-component-extensions for details Test: browser_tests --gtest_filter=SwitchAccess*.* Change-Id: Idfaf157b4b734ce48addaf7961d26832cee960d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075880Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#744870}
-
Clark DuVall authored
Previously, ResourceMapper::MapFromChromiumId has to be called on native resource IDs, which generated an intermediate ID mapping, which then was resolved to a drawable ID when ResourceId.mapToDrawableId() was called on it. This was confusing as the intermediate ID was not a valid native or drawable ID. Now ResourceMapper::MapToJavaDrawableId() returns the drawable ID that can be used directly in java code, eliminating the intermediate mapping. This will also help when componentizing code that depends on ResourceMapper, since we will not need to use ResourceId.mapToDrawableId() on the java side anymore. Bug: 1025609 Change-Id: Ia19a8b915880d974f4d2d6fff87aac9640976656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067656 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#744869}
-
