- 28 Apr, 2014 40 commits
-
-
noel@chromium.org authored
Follow on for https://src.chromium.org/viewvc/chrome?revision=218548 which fixed various background tab issues related to visibility (see for example bugs 118269, 142061, 155365 and 272962) by introducing a WebContents initially_hidden creation-time flag. Restored tabs don't currently set that flag, and that causes various visibility issues (see bug). Fix that by ensuring that restored tabs set their initially_hidden creation-time flag. Note the delegated interface to tab restore service caused the error so add tests for that: a direct test of the delegate, and a test for a delegate user (recent tabs menu). TEST=browser_tests --gtest_filter="*TabDisposition" BUG=358517 Review URL: https://codereview.chromium.org/227043004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266466 0039d316-1c4b-4281-b951-d872f2087c98
-
kinaba@chromium.org authored
BUG=366978 Review URL: https://codereview.chromium.org/251593005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266465 0039d316-1c4b-4281-b951-d872f2087c98
-
jamiewalch@chromium.org authored
removed. We explicitly cancel full screen mode on disconnection, which was resulting in an exception in the event handler, preventing the full-screen class from being removed from the <html> node. The left the plugin container full-screen on top of the Disconnected dialog, making it unclickable. BUG=365920 NOTRY=true Review URL: https://codereview.chromium.org/258863003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266464 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
Review URL: https://codereview.chromium.org/256893002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266463 0039d316-1c4b-4281-b951-d872f2087c98
-
reveman@chromium.org authored
This field is not used by the tile manager as it only affects the resource pool and the tile manager is no longer responsible for forwarding these changes to the resource pool. Also removes inappropriate call to SetResourceUsageLimits in TileManager::SetGlobalStateForTesting. R=vmpstr BUG= Review URL: https://codereview.chromium.org/255533002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266462 0039d316-1c4b-4281-b951-d872f2087c98
-
oshima@chromium.org authored
BUG=None R=ben@chromium.org Review URL: https://codereview.chromium.org/258833002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266461 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
Review URL: https://codereview.chromium.org/255993002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266460 0039d316-1c4b-4281-b951-d872f2087c98
-
chromeos-lkgm@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266459 0039d316-1c4b-4281-b951-d872f2087c98
-
kinaba@chromium.org authored
This CL * Adds new filesystem type kFileSystemTypeDeviceMediaAsFileStorage, which is handled by chromeos::FileSystemBackend. It uses DeviceMediaAsyncFileUtil, so the implementation is shared with MTP support in mediaGalleries API (MediaFileSystemBackend). We need different types since we need different handlings. (Permission management for file handler extensions, unlimited CopyOrMoveValidator for allowing non-media files, etc.) * Adds monitoring by storage_monitor::RemovableStorageObserver in file_manager::VolumeManager so that MTP device is detected and mounted to the file manager. BUG=363960 Review URL: https://codereview.chromium.org/246293011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266458 0039d316-1c4b-4281-b951-d872f2087c98
-
tonyg@chromium.org authored
This required disabling the benchmarks that were causing it to fail. It looks like those failures were due to lack of tab support in ChromeShell. BUG=337829 Review URL: https://codereview.chromium.org/250593003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266457 0039d316-1c4b-4281-b951-d872f2087c98
-
oshima@chromium.org authored
This depends on https://codereview.chromium.org/247193002/ BUG=None Review URL: https://codereview.chromium.org/250793004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266456 0039d316-1c4b-4281-b951-d872f2087c98
-
djkurtz@chromium.org authored
One of the horrors of using Xlib is its Output buffer. When calling Xlib functions, the X command bitstream is not actually sent right away. Commands are first queued up in the Xlib output buffer, and only sent over the wire when the output buffer is flushed. X clients typically don't have to worry about this, since (a) commands that require return a response are flushed immediately, and (b) they usually have an event loop that calls XPending() (XNextEvent(), or XWindowEvent()), which does a Flush internally. Chrome, however, listens to the Xserver fd, and only enters its XPending() loop if the File Can be Read Without Blocking. The quick and dirty fix is to just send an explicit XFlush() after XUngrabServer(). Signed-off-by:
Daniel Kurtz <djkurtz@chromium.org> BUG=chromium:366125 TEST=tbd R=msw@chromium.org R=erg@chromium.org Review URL: https://codereview.chromium.org/246723006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266455 0039d316-1c4b-4281-b951-d872f2087c98
-
kbr@chromium.org authored
This appears to have introduced assertion failures on the linux_gpu_triggered_tests try server -- and would have done so on the Linux Debug (NVIDIA) bot, too, if the hardware had not failed late last week. Links to the failures have been added to crbug.com/269808. > content: Add missing IPC traits for sync_query. > > R=cdn@chromium.org, piman@chromium.org > BUG=269808 > > Review URL: https://codereview.chromium.org/250803010 TBR=reveman@chromium.org Review URL: https://codereview.chromium.org/252833003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266454 0039d316-1c4b-4281-b951-d872f2087c98
-
hamaji@chromium.org authored
Now nacl_irt_mmap with PROT_EXEC is implemented by non-EXEC mmap and mprotect thanks to https://codereview.chromium.org/239763005 BUG=359285 TEST=nacl_loader_unittests, trybots R=jln@chromium.org, mseaborn@chromium.org Review URL: https://codereview.chromium.org/247563004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266453 0039d316-1c4b-4281-b951-d872f2087c98
-
sergeyu@chromium.org authored
The live mode is indicated by presense of DateUTC element and unknown segment duration and size. BUG=338529 Review URL: https://codereview.chromium.org/231283005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266452 0039d316-1c4b-4281-b951-d872f2087c98
-
varkha@chromium.org authored
This prevents overwriting target bounds when reparenting layers during animation. In snapped scenario we snap a window (with a call to WindowState::OnWMEvent in WorkspaceWindowResizer::CompleteDrag()) which starts animation and then immediately reparent it (back to workspace in DockedWindowResizer::MaybeReparentWindowOnDragCompletion). Stopping (completing) BOUNDS animation allows the child window to honor previously set target bounds and keep them when it gets reparented. BUG=364517, 366993 TEST=aura_unittests --gtest_filter=WindowTest.RootWindowSetWhenReparenting Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266115 Review URL: https://codereview.chromium.org/241983003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266451 0039d316-1c4b-4281-b951-d872f2087c98
-
rtenneti@chromium.org authored
BUG=366594 R=glider@chromium.org Review URL: https://codereview.chromium.org/255793002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266450 0039d316-1c4b-4281-b951-d872f2087c98
-
davidyu@chromium.org authored
Expose kServiceInitializationStartupDelay in ChromeBrowserPolicyConnector. Extract DeviceManagementServiceConfiguration to its own files. Add a command line flag to override the consumer DM server address for testing. Fix a comment in policy_switches as it no longer applies. BUG=353050 TEST=manual Review URL: https://codereview.chromium.org/240903002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266449 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
They do not require any extra setup, so it is easier and they do not run on mac or ios platforms. BUG=331829 TEST=gfx_unittests --gtest_filter=XForm*:Interpolated* TBR=danakj@chromium.org,ben@chromium.org Review URL: https://codereview.chromium.org/255953005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266448 0039d316-1c4b-4281-b951-d872f2087c98
-
noms@chromium.org authored
Mocks: https://docs.google.com/a/google.com/file/d/0BxMIIGI80eU-VW16NEloUFdyaXc/edit This CL is related to its Mac cousin, https://codereview.chromium.org/235833002/. Like the related CL, this one also does not implement the "round" avatar icon, nor the top-left corner info button, but it does set up the layout for the other elements. I've also added the option to be able to center the text in a textfield. BUG=353398 Review URL: https://codereview.chromium.org/249813002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266447 0039d316-1c4b-4281-b951-d872f2087c98
-
prasadv@chromium.org authored
For Windows XP platforms, GOMA service is not supported. Moreover we don't compile chorme when gs_bucket flag is set instead use builds archives, therefore ignore GOMA service for Windows XP. NOTRY=true BUG= Review URL: https://codereview.chromium.org/255963002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266446 0039d316-1c4b-4281-b951-d872f2087c98
-
b.kelemen@samsung.com authored
Need to be in google_malloc section just like every other alloc function. R=willchan@chromium.org BUG=364380 Review URL: https://codereview.chromium.org/257453002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266445 0039d316-1c4b-4281-b951-d872f2087c98
-
tyoshino@chromium.org authored
Counts the number of successful handshake completion with permessage-deflate enabled for each negotiated context_takeover parameter value. BUG=128156,359926 Review URL: https://codereview.chromium.org/244933003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266444 0039d316-1c4b-4281-b951-d872f2087c98
-
tapted@chromium.org authored
Revert of GestureRecognizerTest tests both Aura and Unified Gesture Detectors. (https://codereview.chromium.org/258633005/) Reason for revert: Breaks compile on http://build.chromium.org/p/chromium.linux/builders/Linux%20Builder%20%28dbg%29%2832%29/builds/23390 ../../ui/aura/gestures/gesture_recognizer_unittest.cc: In constructor 'aura::test::{anonymous}::GestureEventConsumeDelegate::GestureEventConsumeDelegate()': ../../ui/aura/gestures/gesture_recognizer_unittest.cc:354:17: error: 'aura::test::{anonymous}::GestureEventConsumeDelegate::wait_until_event_' will be initialized after [-Werror=reorder] ../../ui/aura/gestures/gesture_recognizer_unittest.cc:352:7: error: 'int aura::test::{anonymous}::GestureEventConsumeDelegate::flags_' [-Werror=reorder] ../../ui/aura/gestures/gesture_recognizer_unittest.cc:70:3: error: when initialized here [-Werror=reorder] Original issue's description: > GestureRecognizerTest tests both Aura and Unified Gesture Detectors. > > This is in preparation of landing the unified GR > (see https://codereview.chromium.org/251543003/). > > There are some cases where behavior differs in minor ways. > > This is sometimes dealt with by increasing the test's margin of error > (for instance, slop handling is slightly different, so we now > exceed the slop more thoroughly). > > This is sometimes dealt with by ignoring the test if the test is > run with the unified GR. > > BUG=332418 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266440 TBR=sadrul@chromium.org,tdresser@chromium.org NOTREECHECKS=true NOTRY=true BUG=332418 Review URL: https://codereview.chromium.org/254963003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266443 0039d316-1c4b-4281-b951-d872f2087c98
-
zork@chromium.org authored
Send commands from webcamPrivate API to the webcam via V4L2 ioctls BUG=346492 TBR=tommi@chromium.org TBR=kalman@chromium.org Review URL: https://codereview.chromium.org/256833003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266442 0039d316-1c4b-4281-b951-d872f2087c98
-
asanka@chromium.org authored
The @download attribute can be used to specify a suggested filename for a download. However, this suggested name should only be used if the referring document is in the same origin as the downloaded resource. This CL clears the suggested name if the final download URL after redirects is in a different origin than the original download URL. The companion Blink CL at https://codereview.chromium.org/197033005/ ensures that the suggested name for a download initiated via a @download attribute would only be non-empty if the referring document is allowed to set a suggested name for the original download URL. BUG=346744 Review URL: https://codereview.chromium.org/246893006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266441 0039d316-1c4b-4281-b951-d872f2087c98
-
tdresser@chromium.org authored
This is in preparation of landing the unified GR (see https://codereview.chromium.org/251543003/). There are some cases where behavior differs in minor ways. This is sometimes dealt with by increasing the test's margin of error (for instance, slop handling is slightly different, so we now exceed the slop more thoroughly). This is sometimes dealt with by ignoring the test if the test is run with the unified GR. BUG=332418 Review URL: https://codereview.chromium.org/258633005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266440 0039d316-1c4b-4281-b951-d872f2087c98
-
tdresser@chromium.org authored
TEST=TouchDispositionGestureFilterTest.TestDisallowedMultiFingerSwipe Review URL: https://codereview.chromium.org/252753002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266439 0039d316-1c4b-4281-b951-d872f2087c98
-
ziran.sun@samsung.com authored
password_form_conversion_utils. There are Some old Blink code implemented in Webkit that predates the Chromium/WebKit API, specifically WebPasswordFormData and WebPasswordFormUtils. At this point the split just makes this code harder to update, as you need to wait for a Blink roll when adding a new element to autofill::PasswordForm. This patch is re-writing this code in components/autofill/content/renderer/password_form_conversion_util s to make it cleaner. BUG=None Review URL: https://codereview.chromium.org/249153002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266438 0039d316-1c4b-4281-b951-d872f2087c98
-
yoshiki@chromium.org authored
This is a reland of 260688, which is reverted due to false charge of build failure. Previously, we used FileEntry.getMetadata() to retrieve filesystem metadata and getDriveEntryProperties() to get Drive metadata, so we need 2 calls for 1 file on Drive. With this patch, getDriveEntryProperties() returns not only Drive metadata but also filesystem metadata. It's enough to call only getDriveEntryProperties() and we can reduce a number of calls by half. BUG=345196 TEST=browser_test passes. R=asargent@chromium.org, hashimoto@chromium.org, hirono@chromium.org TBR=asargent@chromium.org, hashimoto@chromium.org, hirono@chromium.org Review URL: https://codereview.chromium.org/195763004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266437 0039d316-1c4b-4281-b951-d872f2087c98
-
antrim@chromium.org authored
We need explicitly call ProfileStartup, as it is done for usual flows from startup_browser_creator.cc. This will correctly initialize per-profile input method map in InputMethodManagerImpl. R=nkostylev@chromium.org BUG=364680 Review URL: https://codereview.chromium.org/253463002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266436 0039d316-1c4b-4281-b951-d872f2087c98
-
antrim@chromium.org authored
Make it possible to tab-navigate to import page and ensure tab/arrows-navigation works there. BUG=360588 Review URL: https://codereview.chromium.org/246603004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266435 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
Review URL: https://codereview.chromium.org/255983002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266434 0039d316-1c4b-4281-b951-d872f2087c98
-
navabi@google.com authored
BUG= Review URL: https://codereview.chromium.org/257743002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266433 0039d316-1c4b-4281-b951-d872f2087c98
-
satyanarayana@google.com authored
BUG= Review URL: https://codereview.chromium.org/256783004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266432 0039d316-1c4b-4281-b951-d872f2087c98
-
michaelpg@chromium.org authored
If the time has not been set automatically via network syncing, the system clock can be changed. This dialog allows the user to change the date, time and time zone when possible. The motivation is to unbrick devices with the wrong time that need to be rolled out into time-sensitive networks. Documentation of the changes to Chrome OS and Ash for this CL is here: https://docs.google.com/a/google.com/drawings/d/1T3demthtROnXf1iE31p5aIPcQzK9SmjfE9EjnJbZ4zs System Time Manual Update UI design doc: https://docs.google.com/a/google.com/document/d/1djzhBrtbx-52Gctp3Fd5MIosARbTwQh_lMmd_qUnqgo Screenshot with timezone: https://drive.google.com/a/google.com/file/d/0B6HSBrih6pNUd3p2SFBoVktjVzQ Screenshot from settings page, no timezone: https://drive.google.com/a/google.com/file/d/0B6HSBrih6pNUXzk0TjNiT0tKMTQ BUG=232066 TEST=SetTimeWebUITest, DateTimeOptionsWebUITest R=stevenjb@chromium.org,nkostylev@chromium.org,dbeam@chromium.org,derat@chromium.org,asvitkine@chromium.org TBR=sky@chromium.org # TBR for adding resources to chrome/browser/chrome_resources.grd Please review: stevenjb@chromium.org - ash/system - chromeos/dbus derat@chromium.org: - chrome/browser/chromeos - chrome/browser/ui/ash - chromeos/dbus (optional) nkostylev@chromium.org: - chrome/app - chrome/browser/chromeos - chrome/browser/resources/chromeos - chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc - chrome/browser/ui/webui/chromeos - chrome/browser/ui/webui/options/chromeos - chrome/browser/browser_resources.grd - chrome/chrome_*.gypi - chrome/common dbeam@chromium.org: - chrome/browser/resources/options - chrome/browser/ui/webui/options/*.cc sky@chromium.org: - chrome/browser/browser_resources.grd Review URL: https://codereview.chromium.org/247663003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266431 0039d316-1c4b-4281-b951-d872f2087c98
-
dbeam@chromium.org authored
R=tbreisacher@chromium.org BUG=366972 NOTRY=true Review URL: https://codereview.chromium.org/251713002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266430 0039d316-1c4b-4281-b951-d872f2087c98
-
boliu@chromium.org authored
If executeHardwareAction fails in onDetachedFromWindow, then HardwareRenderer destructor will deadlock later when being destroyed on UI thread. In this case, run the destructor on UI without deadlock but leak GL resources instead. Achieve this by running always running release gl even on UI thread, and making the allow_gl global to be a true thread local, which can be set to true on UI thread. BUG= TBR=benm Review URL: https://codereview.chromium.org/255783007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266429 0039d316-1c4b-4281-b951-d872f2087c98
-
hirono@chromium.org authored
BUG=None TEST=None TBR=yoshiki@chromium.org Review URL: https://codereview.chromium.org/251933002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266426 0039d316-1c4b-4281-b951-d872f2087c98
-
tapted@chromium.org authored
NOTRY=true NOTREECHECKS=true BUG=367600 TBR=bartfab@chromium.org, jianli@chromium.org Review URL: https://codereview.chromium.org/251093002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266423 0039d316-1c4b-4281-b951-d872f2087c98
-