GitLab

When removing tiles, we need to remove everything outside the live
tiles rect even if it has borders inside the live tiles rect. The
DifferenceIterator includes borders when deciding if a tile is in the
included rect, so tiles that are only in the included rect with a border
were not being removed from the tiling. This lead to us having tiles
outside the rect, and to creating a tile that already existed.

When adding tiles, the same problem existed. The DifferenceIterator
includes borders when deciding which tiles are to be excluded, so a
tile that was inside the old live tiles rect with borders only would
not have existed, but it would be excluded by the DifferenceIterator.
This prevented us from making tiles that were inside the live tiles
rect.

Depends on: https://codereview.chromium.org/513903002/

R=enne@chromium.org, vmpstr@chromium.org, enne, vmpstr
BUG=405427

Review URL: https://codereview.chromium.org/505913003

Cr-Commit-Position: refs/heads/master@{#292417}

Move PepperPDFHost out of //chrome into the pdf component at //components/pdf.
With this change, the IPC messages in the component is used only by the
component itself, and nothing outside of the component uses these IPC messages
anymore.

BUG=401242
R=raymes@chromium.org, senorblanco@chromium.org, sky@chromium.org, thestig@chromium.org

Review URL: https://codereview.chromium.org/505243003

Cr-Commit-Position: refs/heads/master@{#292416}

DevTools: Restore embedded devtools manager unit test checks after switching service worker inspection on the main thread.

TBR=yurys, horo
BUG=404355

Review URL: https://codereview.chromium.org/515593004

Cr-Commit-Position: refs/heads/master@{#292415}

TBR=vogelheim@chromium.org

Review URL: https://codereview.chromium.org/512933008

Cr-Commit-Position: refs/heads/master@{#292414}

AppendSwitch was casting all directories to lower case, causing the tests
to early-out and return as always passed even before they create the test
window.

BUG=408251

Review URL: https://codereview.chromium.org/500133005

Cr-Commit-Position: refs/heads/master@{#292413}

Make these tests and settings_quota_unittest run in extensions_unittests.

Move a test that depends on sync (not available in the extensions module) to settings_sync_unittest.

Depends on previous CL: https://chromiumcodereview.appspot.com/461273003/

BUG=397164

Review URL: https://codereview.chromium.org/472343003

Cr-Commit-Position: refs/heads/master@{#292412}

Revert of NaCl: Update revision in DEPS, r13666 -> r13668 (patchset #1 of https://codereview.chromium.org/513933003/)

Reason for revert:
attempting to fix compile failures.

Original issue's description:
> NaCl: Update revision in DEPS, r13666 -> r13668
>
> This pulls in the following Native Client changes:
>
> r13667: (yyanagisawa) Re-enable use of Goma on Windows, except when using the PNaCl toolchain
> r13668: (noelallen) Force rebuild on cmd change.
>
> BUG=none
> TEST=browser_tests and nacl_integration
> CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_arm_cross_compile,linux_nacl_sdk_build
> TBR=bradnelson@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/ba2092ce9ac0792098dcca59f9a224e13825dcd5

TBR=bradnelson@chromium.org,mseaborn@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=none

Review URL: https://codereview.chromium.org/509413002

Cr-Commit-Position: refs/heads/master@{#292411}

Revert of Changes exception for gyp files to only gyp files in build/ (patchset #1 of https://codereview.chromium.org/512693004/)

Reason for revert:
I'm reverting this.
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...
should have triggered a compile.

Original issue's description:
> Changes exception for gyp files to only gyp files in build/
>
> I changed analyzer such that if a gyp file (or an included gypi file)
> changes all targets in the gyp file are marked as changed. This means
> I should no longer have to special case gyp files. I'm leaving the
> exception in place for any gyp files in build as any change to those
> really needs to recompile the world.
>
> BUG=109173
> TEST=none
> R=thakis@chromium.org
>
> Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/5110e8b

TBR=thakis@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=109173

Review URL: https://codereview.chromium.org/512303002

Cr-Commit-Position: refs/heads/master@{#292410}

BUG=None
R=oshima@chromium.org
TBR=oshima@chromium.org
TEST=compile succeeds

Review URL: https://codereview.chromium.org/508283003

Cr-Commit-Position: refs/heads/master@{#292409}

Ime should not be dismissed and Select action bar should be dismissed in
case a cut operation is performed on any input field. Add test case
to check this.

Review URL: https://codereview.chromium.org/508993002

Cr-Commit-Position: refs/heads/master@{#292408}

Renaming from 'settings' to the more informative 'user_settings'.

BUG=NONE

Review URL: https://codereview.chromium.org/513143004

Cr-Commit-Position: refs/heads/master@{#292407}

This CL adds tracing statement for the navigation functionality within Chrome and modifies some of the existing tracing already in place.

Review URL: https://codereview.chromium.org/498883002

Cr-Commit-Position: refs/heads/master@{#292406}

Changed implementation to make a single shell call, rather than
pushing files and executing several shell calls.

When running telemetry unittests on android, reduces total execution
time about 12%.

BUG=379378

Review URL: https://codereview.chromium.org/514123005

Cr-Commit-Position: refs/heads/master@{#292405}

BUG=110610

Review URL: https://codereview.chromium.org/512153002

Cr-Commit-Position: refs/heads/master@{#292404}

BUG=110610

Review URL: https://codereview.chromium.org/512063003

Cr-Commit-Position: refs/heads/master@{#292403}

This is a workaround for an Android accessibility bug - when the object with accessibility focus moves, Android doesn't update the bounds of accessibility focus on the screen, even if we send a WINDOW_CONTENT_CHANGED event.

With this change, we keep track of the bounding rect of the node with accessibility focus, and if it changes, we move focus to the document and then back to this node, which works around the issue.

No visual flicker was observed when testing on multiple devices. Refreshable braille displays flicker briefly.

BUG=407871

Review URL: https://codereview.chromium.org/505423002

Cr-Commit-Position: refs/heads/master@{#292402}

https://skia.googlesource.com/skia/+log/b2f7fce9e034c3b6749e75a129e7836df3529706..dc53701216c0e9f98eacf6c0cda769ebbd200b59

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=djsollen@google.com

Review URL: https://codereview.chromium.org/517643002

Cr-Commit-Position: refs/heads/master@{#292401}

BUG=110610

Review URL: https://codereview.chromium.org/515093002

Cr-Commit-Position: refs/heads/master@{#292400}

Adds a regression test for bug 317138. This test is interesting
because it generates exactly the same stacks that we're seeing in
crash reports on that bug. This is a good regression test, so I
suggest we land it, as well as look at it for more confidence that
our fix to bug 317138 is the right fix.

R=ttuttle@chromium.org,jkarlin@chromium.org
BUG=317138

Review URL: https://codereview.chromium.org/509973002

Cr-Commit-Position: refs/heads/master@{#292399}

Adds UMA logging to track how many batteries are reported
by the system at the start of Battery Status API.

BUG=

Review URL: https://codereview.chromium.org/480113003

Cr-Commit-Position: refs/heads/master@{#292398}

Cr-Commit-Position: refs/heads/master@{#292397}

Extracting GCMConnectionObserver from GCMAppHandler
* Updating consuming code: GCMInvalidationBridge
* Updating GCMAppHandler overrides
* Updating tests for GCMDriverDesktop

BUG=407841
R=jianli@chromium.org

Review URL: https://codereview.chromium.org/515763002

Cr-Commit-Position: refs/heads/master@{#292396}

Most hardware OEMs provides codecs to support H264 main/high profile.
The current way of declaring them as unsupported is too restrictive.

BUG=407741

Review URL: https://codereview.chromium.org/506283002

Cr-Commit-Position: refs/heads/master@{#292395}

BUG=163393

Review URL: https://codereview.chromium.org/509753002

Cr-Commit-Position: refs/heads/master@{#292394}

BUG=none
TBR=fsamuel@chromium.org

Review URL: https://codereview.chromium.org/517593002

Cr-Commit-Position: refs/heads/master@{#292393}

I changed analyzer such that if a gyp file (or an included gypi file)
changes all targets in the gyp file are marked as changed. This means
I should no longer have to special case gyp files. I'm leaving the
exception in place for any gyp files in build as any change to those
really needs to recompile the world.

BUG=109173
TEST=none
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/512693004

Cr-Commit-Position: refs/heads/master@{#292392}

BUG=293702

Review URL: https://codereview.chromium.org/469653002

Cr-Commit-Position: refs/heads/master@{#292391}

Revert of DevTools: use explicit IPC messages for enabling/disabling tracing instead of intercepting protocol… (patchset #3 of https://codereview.chromium.org/511873002/)

Reason for revert:
Creates timeout failures on a lot of inspector/ tests in Blink:
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20%28deps%29/builds/33453/steps/webkit_tests/logs/stdio

Original issue's description:
> DevTools: use explicit IPC messages for enabling/disabling tracing instead of intercepting protocol events
>
> Added IPC plumbing that allows InspectorTracingAgent to enable/disable  browser-wide tracing. It was implemented by intercepting Tracing.started/Tracing.stopped events in the browser. Tracing.stopped event in the DevTools protocol was used by the renderer to notify the browser that it should stop trace event recording and it didn't make much sense for the client as there is already Tracing.tracingComplete event in the protocol.
>
> BUG=398787
>
> Committed: https://chromium.googlesource.com/chromium/src/+/a449adae35631e4791547bd0b14403d1766f9ddf

TBR=dcheng@chromium.org,caseq@chromium.org,loislo@chromium.org,vsevik@chromium.org,yurys@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=398787

Review URL: https://codereview.chromium.org/516963003

Cr-Commit-Position: refs/heads/master@{#292390}

Changing WebMediaPlayerImpl and related media code to use task runners
instead of MessageLoopProxy to avoid presubmit errors when moving this
code to media/blink. There is no functional change here. Just making the
tools happy. :)

BUG=408338

Review URL: https://codereview.chromium.org/508293003

Cr-Commit-Position: refs/heads/master@{#292389}

brings in https://codereview.chromium.org/515263002

TBR=rnk@chromium.org

Review URL: https://codereview.chromium.org/513973004

Cr-Commit-Position: refs/heads/master@{#292388}

BUG=404355
R=yurys, pfeldman-OOO, horo

Review URL: https://codereview.chromium.org/479673004

Cr-Commit-Position: refs/heads/master@{#292387}

Consolidate the code to set accessibility focus to one place.
Fix it so we never set accessibility focus to the same id twice in a row,
as that puts things in a weird state (because we then get a "clear"
accessibility focus action on the current focused view).

In a couple of places where we want to explicitly update the focus,
set focus away and then back again so Android can't ignore it.

BUG=407871

Review URL: https://codereview.chromium.org/513483002

Cr-Commit-Position: refs/heads/master@{#292386}

BUG=407718

Review URL: https://codereview.chromium.org/510583002

Cr-Commit-Position: refs/heads/master@{#292385}

When tab focus is placed on the security warning primary button, Chrome
should outline the button. However, the outline is not shown during
button activation to prevent it from making the button border an odd
white-gray-blue.

BUG=387163
R=bauerb@chromium.org

Review URL: https://codereview.chromium.org/511073002

Cr-Commit-Position: refs/heads/master@{#292384}

This pulls in the following Native Client changes:

r13667: (yyanagisawa) Re-enable use of Goma on Windows, except when using the PNaCl toolchain
r13668: (noelallen) Force rebuild on cmd change.

BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_arm_cross_compile,linux_nacl_sdk_build
TBR=bradnelson@chromium.org

Review URL: https://codereview.chromium.org/513933003

Cr-Commit-Position: refs/heads/master@{#292383}

. Make HistoryService::Cleanup() private. Making this public can leave
  HistoryService in a bad state.
. HistoryServiceFactory would leak a HistoryService if
  HistoryService::Init() failed.

BUG=none
TEST=none
R=brettw@chromium.org

Review URL: https://codereview.chromium.org/510033004

Cr-Commit-Position: refs/heads/master@{#292382}

BUG=394287

Review URL: https://codereview.chromium.org/512683003

Cr-Commit-Position: refs/heads/master@{#292381}

BUG=408525

Review URL: https://codereview.chromium.org/513173002

Cr-Commit-Position: refs/heads/master@{#292380}

DevTools: use explicit IPC messages for enabling/disabling tracing instead of intercepting protocol events

Added IPC plumbing that allows InspectorTracingAgent to enable/disable  browser-wide tracing. It was implemented by intercepting Tracing.started/Tracing.stopped events in the browser. Tracing.stopped event in the DevTools protocol was used by the renderer to notify the browser that it should stop trace event recording and it didn't make much sense for the client as there is already Tracing.tracingComplete event in the protocol.

BUG=398787

Review URL: https://codereview.chromium.org/511873002

Cr-Commit-Position: refs/heads/master@{#292379}

Move ExtensionWarningService and ExtensionsWarningSet, which are used by webrequest api, to extensions.

This cl resolve the dependencies of ExtensionsWarningSet of chrome strings:
- move the declarations of IDS_EXTENSION_WARNINGS_XXX to extensions_strings.grd;
- replace the usage of "IDS_PRODUCT_NAME" by creating GetProductName() function in ExtensionsClient and its subclasses.

BUG=352293

Review URL: https://codereview.chromium.org/503033002

Cr-Commit-Position: refs/heads/master@{#292378}