GitLab

As written the argument ended up in the .ninja file as \\\$$ORIGIN/lib/
but we want \$$ORIGIN/lib/ to match gyp.

R=brettw@chromium.org

Review URL: https://codereview.chromium.org/409883009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284888 0039d316-1c4b-4281-b951-d872f2087c98

These functions are simplistic and doesn't depend on chrome's
feature, so there's no reason to be under chrome/browser.
Moving to components/ would help further componentization
task of autocomplete anad omnibox_field_trials.

BUG=371538
R=brettw@chromium.org, pkasting@chromium.org, blundell@chromium.org
TBR=tedchoc@chromium.org, jhawkins@chromium.org
TEST=build

Review URL: https://codereview.chromium.org/393173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284885 0039d316-1c4b-4281-b951-d872f2087c98

The example window currently doesn't activate itself properly because it
lacks an activation policy and a menubar.

This CL sets the activation policy, adds a menubar and defers window
creation until the applicationDidFinishLoading notification. Creating a
window before this can activate and receive key events, but the menubar
will not switch properly.

With this, views_examples_with_content_exe compiles and runs nicely on a
Mac build with `GYP_DEFINES=toolkit-views=1`. Note the `WebView` example
will crash for now because views::NativeViewHost is not yet implemented
for mac.

BUG=395507

Review URL: https://codereview.chromium.org/309483009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284883 0039d316-1c4b-4281-b951-d872f2087c98

This adds logic for representing page skips as values in Telemetry, in the
spirit of how failures are to be handled with regard to the linked bug. The
goal for this CL is just to add the logic, and then once it's safely in the
codebase, we can wire it up and make sure Buildbot is happy with it.

BUG=392901

Review URL: https://codereview.chromium.org/409023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284882 0039d316-1c4b-4281-b951-d872f2087c98

Icons from the webstore can be unusual sizes. Once installed,
ExtensionAppItem uses extension_misc::EXTENSION_ICON_MEDIUM (48) to load
it, so be consistent with that.

BUG=338253
TEST=(CrOS) Start installing a large app from the webstore (e.g. tank
riders). While it has a progress bar, drag it around the app launcher -
the icon should grow a little, not a lot (see bug for screenshots).

Review URL: https://codereview.chromium.org/400893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284879 0039d316-1c4b-4281-b951-d872f2087c98

UIThreadSearchTermsData is responsible to get the value instead.
Remove |start_margin| argument from GetInstantURL() as all users are passing kDisableStartMargin for it.
Add a new test TemplateURLTest.OmniboxStartmargin

BUG=388515
TEST=components_unittests

Review URL: https://codereview.chromium.org/396583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284878 0039d316-1c4b-4281-b951-d872f2087c98

Add SyncClient::WaitForUpdateTaskToComplete().
Use the new method from CoypOperation.

BUG=384213
TEST=unit_tests

Review URL: https://codereview.chromium.org/372713004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284877 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284876 0039d316-1c4b-4281-b951-d872f2087c98

Changing gesture handling in Views textfields to be more consistent with
blink's textfields. The main changes are:
 - Dragging text scrolls the text in textfield;
 - Tap on selection activates touch editing;
 - Double-tap selects a word;
 - Triple-tap selects the entire text;
 - Long-press off selection selects a word;
 - Long-press on selection starts drag-drop (if drag-drop is enabled) or
   shows context menu (if drag-drop is disabled);
 - Long-tap shows context menu, if drag-drop started on the
   corresponding long-press was not exercised.

BUG=388862

Review URL: https://codereview.chromium.org/407993003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284875 0039d316-1c4b-4281-b951-d872f2087c98

Fake entries are readonly and it is not useful for the save dialog.

BUG=396179
TEST=manually

Review URL: https://codereview.chromium.org/410843002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284874 0039d316-1c4b-4281-b951-d872f2087c98

This patch adds support for creating files via AsyncFileUtil::EnsureFileExists.
Note, that creating files from NaCL is not supported yet.

TEST=unit_tests, browser_tests: *FileSystemProvider*EnsureFile*,
     *FileSystemProvider*CreateFile*
BUG=391362

Review URL: https://codereview.chromium.org/389893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284873 0039d316-1c4b-4281-b951-d872f2087c98

This results in a significant speedup; tests run in <500ms instead of >2s because the lengthy browser_tests startup is avoided.

This clones some aspects of extension_function_test_utils into extensions/browser/api_test_utils.cc. Later CLs will clean up the redundancy.

BUG=388893

Review URL: https://codereview.chromium.org/394103004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284872 0039d316-1c4b-4281-b951-d872f2087c98

This will allow us to be able to intelligently de-apply patches,
re-run the tests, and compare the results on the bot. A follow-on
patch will also enable uploading the results to
test-results.appspot.com

R=dtu@chromium.org
BUG=323212

Review URL: https://codereview.chromium.org/407243004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284871 0039d316-1c4b-4281-b951-d872f2087c98

BUG=378924

Review URL: https://codereview.chromium.org/392293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284870 0039d316-1c4b-4281-b951-d872f2087c98

This allows some videos with incorrectly set reserved bits to play.

BUG=393304

Review URL: https://codereview.chromium.org/412693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284869 0039d316-1c4b-4281-b951-d872f2087c98

Now, CleanUpAfterPage will also do the cleanup. (This is not a great
solution, but it will unblock the other patch without re-engineering
the whole resource cleanup mechanisms.)

In my other patch, the order of GC changes somehow (not sure yet why),
which caused SmoothnessUnitTest to fail since __del__ is not called
before the next test starts.

BUG=350841,348271

Review URL: https://codereview.chromium.org/409113006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284868 0039d316-1c4b-4281-b951-d872f2087c98

Glen and Alex suggested putting all of the "detail" strings for overridable errors into the following format:

This server could not prove that it is example.com; <INSERT SHORT REASON HERE>. This may be caused by a misconfiguration or an attacker intercepting your connection.

BUG=

Review URL: https://codereview.chromium.org/404923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284867 0039d316-1c4b-4281-b951-d872f2087c98

This is no longer necessary since crbug.com/123007 was fixed.

BUG=123007

Review URL: https://codereview.chromium.org/378193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284866 0039d316-1c4b-4281-b951-d872f2087c98

BUG=394644

Review URL: https://codereview.chromium.org/409883007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284865 0039d316-1c4b-4281-b951-d872f2087c98

Otherwise the Vsync messages aren't filtered properly and hit a DCHECK.

BUG=

Review URL: https://codereview.chromium.org/394023008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284864 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284863 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178682:178708&mode=html
TBR=johnme@chromium.org,pkasting@chromium.org
BUG=

Review URL: https://codereview.chromium.org/407343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284862 0039d316-1c4b-4281-b951-d872f2087c98

The purpose of the thumbnail cache is to save resources and use 
static image instead of live pages when contents of a tab are
needed for the browser UI.

There are three forms of caching:
  - High-res
  - Low-res
  - On-disk

If a high-res thumbnail is not available, then a low-res thumbnail
is used while the on-disk version (always high-res) is being read.

Eviction from the high/low-res caches is determined by a
priority-ordered list of tab ids that is updated by the user.

Compression of the thumbnail bitmaps are supported through
third_party/android_opengl/etc1.  The raw bitmaps are discarded
once a compressed version is available.  Compressed bitmaps are
written to disk and uploaded as UIResource.  Once both of tasks
are complete, the compressed bitmap is also discarded.

depends on: https://codereview.chromium.org/287593002/

android= https://chrome-internal-review.googlesource.com/#/c/160907/

BUG=341406, 357740

Review URL: https://codereview.chromium.org/262543002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284861 0039d316-1c4b-4281-b951-d872f2087c98

BUG=338338
TEST=None
R=jam@chromium.org
TBR=jamesr@chromium.org

Review URL: https://codereview.chromium.org/394403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284860 0039d316-1c4b-4281-b951-d872f2087c98

I'll adjust the threshold in a separate CL.

BUG=391822,394941

Review URL: https://codereview.chromium.org/408353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284859 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/396173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284858 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
R=keybuk@chromium.org

Review URL: https://codereview.chromium.org/397123002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284857 0039d316-1c4b-4281-b951-d872f2087c98

The fix for this issue, namely, that we must draw contents manually and
immediately when a window is occluded because Cocoa will not draw them
for us, was not ported to the browser compositor.

Plumb this explicitly through a ShouldAckImmediately callback for
CompositingIOSurfaceLayerClient and BrowserCompositorViewMacClient.

Also check for vsync disabling in the ShouldAckImmediately instead of
running it (unnecessarily) through CompositingIOSurfaceContextMac.

BUG=393390,350410

Review URL: https://codereview.chromium.org/408103004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284856 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284761

Review URL: https://codereview.chromium.org/377553003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284855 0039d316-1c4b-4281-b951-d872f2087c98

BUG=370977

Review URL: https://codereview.chromium.org/414473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284854 0039d316-1c4b-4281-b951-d872f2087c98

Use ExtensionRegistryObserver instead of DEPRECATED extension notify from desktop_notification_service.*

BUG=354458

Review URL: https://codereview.chromium.org/409643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284853 0039d316-1c4b-4281-b951-d872f2087c98

The intention is to disable the update when the feature is
disabled on the commandline for performance testing purposes.

BUG=390799

Review URL: https://codereview.chromium.org/405253004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284852 0039d316-1c4b-4281-b951-d872f2087c98

RunTaskOnThread has been running tasks synchronously if the task runner belongs to the current thread.
This behavior was necessary when it was allowed to access drive::FileSystem from both UI and IO threads.
But now, no one needs this behavior and every user uses this method to post tasks to the specified runner.

BUG=None

Review URL: https://codereview.chromium.org/408153003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284851 0039d316-1c4b-4281-b951-d872f2087c98

With this patch, both Windows and Ozone implementations use PlatformWindow for
interacting with the native windowing system. Eventually, the X11 implementations
will also use this, and WindowTreeHost will have a single implementation on all
platforms.

BUG=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/400413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284850 0039d316-1c4b-4281-b951-d872f2087c98

EnterSlideGestureState tests in TouchExplorationTest:

Direct leak of 24 byte(s) in 1 object(s) allocated from:
    #0 0x448b2b in operator new(unsigned long) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:55
    #1 0x14703f7 in ui::GestureProviderAura::GetAndResetPendingGestures() ui/events/gestures/gesture_provider_aura.cc:112
    #2 0x9f4986 in ui::TouchExplorationController::InSlideGesture(ui::TouchEvent const&, scoped_ptr\u003Cui::Event, base::DefaultDeleter\u003Cui::Event> >*) ui/chromeos/touch_exploration_controller.cc:578
    ...

etc.

> Added side slide gestures to touch exploration controller.
> 
> The user can control settings that might be normally changed using sliders by sliding along the edge of the screen when ChromeVox is on. For example, the user can slide along the right edge of the screen and adjust the volume.
> 
> If the user enters this mode and leaves the boundaries without releasing their touch, they will stop adjusting the setting, however, they will not enter touch exploration. If they return to the given boundaries, they will be able to modify the setting again. If the user does not touch a "hot edge" of the screen, they will not enter this state if they move to the an of the screen. 
> 
> BUG=393326
> 
> Review URL: https://codereview.chromium.org/385073009

TBR=lisayin@chromium.org

Review URL: https://codereview.chromium.org/407073008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284849 0039d316-1c4b-4281-b951-d872f2087c98

  FindAllAvailableBrowsers at tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py:224
      proc.set_cpu_affinity([0])  # Older versions.
  AttributeError: 'Process' object has no attribute 'set_cpu_affinity'

> Reland: [Telemetry] Fix a flake in android browser finder.
> 
> This is the same as before, except that we now support older and newer versions
> of psutil.
> 
> BUG=395228
> 
> patch from issue 394423002
> 
> Review URL: https://codereview.chromium.org/407253002

TBR=tonyg@chromium.org

Review URL: https://codereview.chromium.org/414663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284848 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284842 0039d316-1c4b-4281-b951-d872f2087c98

This library is required to be build tui mode support into nacl gdb.

BUG=https://code.google.com/p/chromium/issues/detail?id=391170
TEST=local + bots
R=dyen@chromium.org,uekawa@chromium.org

Review URL: https://codereview.chromium.org/407663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284840 0039d316-1c4b-4281-b951-d872f2087c98

The test seems to be timing out of windows after a patch that renames
some things lands.

BUG=393733
R=danakj, jbedley

Review URL: https://codereview.chromium.org/408233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284839 0039d316-1c4b-4281-b951-d872f2087c98

This way any changes to these files trigger a full build/test run.

BUG=383609
TEST=none
R=tonyg@chromium.org

Review URL: https://codereview.chromium.org/409213003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284838 0039d316-1c4b-4281-b951-d872f2087c98