GitLab

If this causes ASAN problems with browser tests, then
I'll revert it.

Tests to watch out for (on ASAN bot) are:

IncognitoSplitMode
TwoExtensionsCrashBothAtOnce
TwoExtensionsOneByOne
AutoUpdate
CognitoNoFile
IncognitoNoFile
OnChangedNotificationsBetweenBackgroundPages
SplitModeIncognito



r=rtenneti
BUG=103830
Review URL: http://codereview.chromium.org/8540015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109721 0039d316-1c4b-4281-b951-d872f2087c98

Transition from internal used of "class Duration" (which is
kindred of base::TimeDelta) to using an integral type.
This is in preparation for handling durations that are
not time based, such as memmory allocation units.

r=rtenneti
BUG=103321
Review URL: http://codereview.chromium.org/8502001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109720 0039d316-1c4b-4281-b951-d872f2087c98

R=cbentzel
Review URL: http://codereview.chromium.org/8503040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109719 0039d316-1c4b-4281-b951-d872f2087c98

linux-release/dhtml/times/t: http://build.chromium.org/f/chromium/perf/linux-release/dhtml/report.html?history=150&rev=109709

TBR=nsylvain@chromium.org
BUG=103660

Review URL: http://codereview.chromium.org/8538023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109717 0039d316-1c4b-4281-b951-d872f2087c98

http://chromegw.corp.google.com/i/chromium/builders/Vista%20Tests%20%282%29/builds/11639

BUG=103955
TBR=viettrungluu@chromium.org

Review URL: http://codereview.chromium.org/8540020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109713 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8527011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109712 0039d316-1c4b-4281-b951-d872f2087c98

1) Add test for Bug 99970 Comment 6 & fix
2) Allow chrome.send to be mocked outside of preLoad call.
3) add chrome.originalSend to allow mocked messages to pass through to C++.

Also to address need for .cc file to be correct for clang, and prevent ugliness in js with a lot of GEN lines, allow the header and .cc to not have a suffix, and the generated file to end in -gen.cc.  While doing this, addressed crbug.com/102794 to put in <(INTERMEDIATE_DIR) preventing collisions across rules.

R=flackr@chromium.org,wyck@chromium.org
BUG=103740,99970,102794
TEST=browser_tests --gtest_filter=Mock4JS*.* AND ChromeSend*.*

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109678

Review URL: http://codereview.chromium.org/8515016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109711 0039d316-1c4b-4281-b951-d872f2087c98

This allows 4 classes to be completely devirtualized. For the moment, CHROMEGTK_CALLBACK is left as default virtual, since it's used throughout a lot of Widget code.

BUG=103827
TEST=passes all tests

Review URL: http://codereview.chromium.org/8523019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109709 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8539010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109708 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8511048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109707 0039d316-1c4b-4281-b951-d872f2087c98

BUG=103945
TEST=Heapchecker CrOS bot goes green.
Review URL: http://codereview.chromium.org/8540016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109706 0039d316-1c4b-4281-b951-d872f2087c98

This removes a NOTIMPLEMENTED() in
views::NativeWidgetPrivate::IsMouseButtonDown().

BUG=102577
TEST=added

Review URL: http://codereview.chromium.org/8526020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109703 0039d316-1c4b-4281-b951-d872f2087c98

OpenItem and ShowItemInFolder must now be called from the UI thread only - add
a comment to this effect in the header.
Dispatch the implementations to the FILE thread on chromeos/win/linux.
Fix usage of OpenItem/ShowItemInFolder in DownloadsDomHandler and 
ChromeContentBrowserClient.
Rename ShowFullTabUrl to ViewFolder and get rid of unused Profile* arg.
Use anonymous namespace for functions in file_manager_util.cc and platform_util_chromeos.cc
Replace NewRunnableFunction with Bind.
Add additional threading DCHECKs.
Fix lint errors.

BUG=chromium-os:21585
TEST=go to downloads page (ctrl-j), click on Open Downloads Folder.
Review URL: http://codereview.chromium.org/8457004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109702 0039d316-1c4b-4281-b951-d872f2087c98

BUG=101600
TEST=none


Review URL: http://codereview.chromium.org/8524016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109700 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8538015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109699 0039d316-1c4b-4281-b951-d872f2087c98

As per http://msdn.microsoft.com/en-us/library/windows/desktop/cc144148(v=vs.85).aspx#uninstall

BUG=103935
TEST=install Chrome, make it the default, then uninstall it.  make sure HKLM\Software\Classes\.htm hasn't been deleted.


Review URL: http://codereview.chromium.org/8536023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109698 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

R=csilv@chromium.org

Review URL: http://codereview.chromium.org/8515019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109696 0039d316-1c4b-4281-b951-d872f2087c98

When a path to swiftshader is specified and the current GPU is blacklisted, tell the gpu process to use swiftshader to render it. If there already is a gpu process, kill it and make a new one that uses swiftshader

BUG=
TEST=


Review URL: http://codereview.chromium.org/8480015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109695 0039d316-1c4b-4281-b951-d872f2087c98

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109594
Review URL: http://codereview.chromium.org/8341125

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109694 0039d316-1c4b-4281-b951-d872f2087c98

Otherwise we are not being consistent with the rest of the file.

TEST=ui_unittests --gtest_filter=TreeNodeModelTest.*
R=sky@chromium.org

Review URL: http://codereview.chromium.org/8511065

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109693 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8527017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109691 0039d316-1c4b-4281-b951-d872f2087c98

BUG=86483
TEST=run tests under valgrind


Review URL: http://codereview.chromium.org/8528016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109690 0039d316-1c4b-4281-b951-d872f2087c98

When there is a password error and the user clicks the wrench menu to sign in again that would work with no bug. The reason it works is we end up calling the function ShowErrorUI on PSS which enumerates the errors(password, actionable, passphrase) and then calls the sync_setup_wizard's Step function with the right parameter.

However if the user goes to the options page and click sign in we call SyncSetupHandler::HandleShowErrorUI which bypasses PSS and simply calls SyncSetupWizard's step with a generic non_fatal_error parameter which does not do the right thing always. The fix is to simply route the entire thing through one function(which is in PSS currently. Once the code it ripped apart from PSS the logic would move along with it to the new class.)

added tests as well.

BUG=103628
TEST=manual testing, unit_tests.exe and sync_integration_tests.exe


Review URL: http://codereview.chromium.org/8507026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109689 0039d316-1c4b-4281-b951-d872f2087c98

Use a View instead of a Point for anchoring the bubble.
Remove the now unused IDS_BOOKMARK_BUBBLE_ADD_BOOKMARK.
Remove the unused BubbleDelegate base class from StarView.

BUG=97248,98312,98323
TEST=Bookmark bubble has the same behavior/appearance.

Review URL: http://codereview.chromium.org/8368016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109688 0039d316-1c4b-4281-b951-d872f2087c98

BUG=103424
TEST=none


Review URL: http://codereview.chromium.org/8523003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109687 0039d316-1c4b-4281-b951-d872f2087c98

Fix WindowTest.Transform, and also make it run on Windows. Some of it (the bits that rely on window activation) needed to move to DEF's test in the shell.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8538017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109686 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8538008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109685 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:19759
TEST=run_remote_tests.sh --board=x86-generic desktopui_PyAutoFunctionalTests.control.vm

Change-Id: Ibc7caa932991cc902a4aa50c2974bb4bc87f2eea

Review URL: http://codereview.chromium.org/8526026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109684 0039d316-1c4b-4281-b951-d872f2087c98

I flipped min/max in my initial checkin, and ASAN went crazy.  This
fixes that.

BUG=103370


Review URL: http://codereview.chromium.org/8540011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109683 0039d316-1c4b-4281-b951-d872f2087c98

visible. This matches windows and aura.

Also fixes bug where we were setting incorrect name on widget.

BUG=chromium-os:22592
TEST=see bug
R=ben@chromium.org,oshima@chromium.org


Review URL: http://codereview.chromium.org/8527008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109682 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8497054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109681 0039d316-1c4b-4281-b951-d872f2087c98

1) Add test for Bug 99970 Comment 6 & fix
2) Allow chrome.send to be mocked outside of preLoad call.
3) add chrome.originalSend to allow mocked messages to pass through to C++.

Also to address need for .cc file to be correct for clang, and prevent ugliness in js with a lot of GEN lines, allow the header and .cc to not have a suffix, and the generated file to end in -gen.cc.  While doing this, addressed crbug.com/102794 to put in <(INTERMEDIATE_DIR) preventing collisions across rules.

R=flackr@chromium.org,wyck@chromium.org
BUG=103740,99970,102794
TEST=browser_tests --gtest_filter=Mock4JS*.* AND ChromeSend*.*

Review URL: http://codereview.chromium.org/8515016

TBR=scr@chromium.org
Review URL: http://codereview.chromium.org/8480027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109680 0039d316-1c4b-4281-b951-d872f2087c98

disabled code for OpenBSD:
  - AdjustRendererOOMScore()
  - SECCOMP_SANDBOX

BUG=
TEST=compile


Review URL: http://codereview.chromium.org/8341052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109679 0039d316-1c4b-4281-b951-d872f2087c98

1) Add test for Bug 99970 Comment 6 & fix
2) Allow chrome.send to be mocked outside of preLoad call.
3) add chrome.originalSend to allow mocked messages to pass through to C++.

Also to address need for .cc file to be correct for clang, and prevent ugliness in js with a lot of GEN lines, allow the header and .cc to not have a suffix, and the generated file to end in -gen.cc.  While doing this, addressed crbug.com/102794 to put in <(INTERMEDIATE_DIR) preventing collisions across rules.

R=flackr@chromium.org,wyck@chromium.org
BUG=103740,99970,102794
TEST=browser_tests --gtest_filter=Mock4JS*.* AND ChromeSend*.*

Review URL: http://codereview.chromium.org/8515016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109678 0039d316-1c4b-4281-b951-d872f2087c98

TBR=tonyg@chromium.org
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8536024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109677 0039d316-1c4b-4281-b951-d872f2087c98

Make a copy of the extension id from within ExtensionService::SetIsIncognitoEnabled, since the const ref may get wiped out when reloading the extension.

BUG=103762
TEST=no crash when toggling incognito mode for an extension

Review URL: http://codereview.chromium.org/8529001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109676 0039d316-1c4b-4281-b951-d872f2087c98

Make the crashed extension reload when the sad tab is reloaded.
('Extensions' includes packaged apps.)

BUG=71629
BUG=94177
TEST=Added ExtensionCrashRecoveryTest.ReloadTabsWithBackgroundPage. Manually: Open a packaged app with a background page. Kill it from Task Manager. Its tab should not close. Reload the tab and it should show the app (and the crash notification bubble should be gone).


Review URL: http://codereview.chromium.org/8496024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109675 0039d316-1c4b-4281-b951-d872f2087c98

So that he won't get code review requests.

TEST=none
BUG=none


Review URL: http://codereview.chromium.org/8539017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109674 0039d316-1c4b-4281-b951-d872f2087c98

CSV output format is used for integration with Google spreadsheet.

Plus several minor issue fixes and adding minor features.

Review URL: http://codereview.chromium.org/8469017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109673 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8539005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109672 0039d316-1c4b-4281-b951-d872f2087c98