- 05 Mar, 2018 10 commits
-
-
Peter Collingbourne authored
Bug: 749784 Change-Id: I8ae48e1b1080ddeef87faafc7fad8f40ddb01126 Reviewed-on: https://chromium-review.googlesource.com/947715Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#540782}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=amineer@chromium.org Change-Id: I8fdb21a1682cbb9e2937556d521db77b6b410f55 Reviewed-on: https://chromium-review.googlesource.com/947838Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#540781}
-
Hitoshi Yoshida authored
REASON OF RELAND: The issue was out of Chromium repository, and run on only Chrome official build. Hence I revert the chagne in merger.py, not to check v8_context_snapshot.bin. Original CL is https://chromium-review.googlesource.com/c/chromium/src/+/923683 This CL makes it possible to create and use V8 context snapshot files on Android, if a developer puts "use_v8_context_snapshot=true" The V8 context snapshot feature is currently supported and enabled on Windows, MacOSX, and Linux (not ChromeOS), and its Finch experiment showed 20% reduction of time to create V8 contexts. On local Android machine, this feature shows 50% time recution. Beside it, in order to enable the feature on cross-build platforms like Android, we have to build Blink twice. So this CL does not flip the flag |use_v8_context_snapshot|. FYI, some numbers with the feature are written in the next CL; https://chromium-review.googlesource.com/c/chromium/src/+/923623 TBR=caitkp,kuniko,nyquist,rockot,haraken,mkwst Bug: 764576, 817288 Change-Id: Id819aa2d4762e04bd7a9b4f700603d89ee0fe5dd Reviewed-on: https://chromium-review.googlesource.com/945248Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#540780}
-
Koji Ishii authored
Following bot results are included. 4034 4035 4036 4040 4041 4044 4045 4046 4047 4048 4049 4050 4051 4052 4053 4054 25 lines were removed and 18 lines were deflaked by consecutive results since 3993. TBR=eae@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I32758809317e7fe8a2504de939f1620775f30076 Reviewed-on: https://chromium-review.googlesource.com/945038 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#540779}
-
Tatsuhisa Yamaguchi authored
This will protect mounted zip file caches from the disk cleanup logic. Bug: 816928 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I73d36a2317d643fdbbc74c342960b027b99dddb0 Reviewed-on: https://chromium-review.googlesource.com/940645 Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#540778}
-
Matt Falkenhagen authored
CompositorImageAnimation changed some timings and the resource was not yet cached when the test was expecting it to be. I've rearranged the test and it seems to pass reliably now on Linux: it passes 100 iterations whereas it would fail within 10 iterations previously. R=nhiroki Bug: 813468 Change-Id: I5b76353f90e728981922c325486fa1700e85f73e Reviewed-on: https://chromium-review.googlesource.com/945708 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#540777}
-
Yutaka Hirano authored
It's flaky with --enable-features=NetworkService. Bug: 818445 Change-Id: I42bcd27471d03f497989ee8181208e2c043c6099 Tbr: jam@chromium.org Reviewed-on: https://chromium-review.googlesource.com/948162Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#540776}
-
Gyuyoung Kim authored
Most of the callers of ReleaseFreeMemory() have been usually invoking ClearMemory() together. So it would be good if we call ClearMemory() inside ReleaseFreeMemory(). It will help to return more free memory through ReleaseFreeMemory(). This CL makes ReleaseFreeMemory() purge more free memory through calling ClearMemory(). But this CL just calls SkGraphics::PurgeAllCaches() directly, since ClearMemory() doesn't do much stuff. And, this CL removes ClearMemory() that is no longer needed. The test case is implemented by referring to RenderThreadImplDiscardableMemoryBrowserTest.ReleaseFreeDiscardableMemory(). It calls RenderThreadImpl::ReleaseFreeMemory through a fake memory pressure notification. Besides RenderThreadImplClearMemoryBrowserTest.MAYBE_ClearMemory should be also removed because ClearMemory() is removed. Test: RenderThreadImplDiscardableMemoryBrowserTest.ReleaseFreeMemory() Bug: None Change-Id: If82e204b6d8785e8d97cd57fe7eac9f0f852a7a8 Reviewed-on: https://chromium-review.googlesource.com/945748 Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#540775}
-
Jinsuk Kim authored
The API was used to collect UMA stat on mobile-friendly pages for DOM distiller (reader mode) project. It can now be deleted. Bug: 598880 Change-Id: Ia922743fc6294bd57c7a92d71dc1678ce651c843 Reviewed-on: https://chromium-review.googlesource.com/945348Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#540774}
-
Will Harris authored
BUG=803621 Change-Id: I2a028ce864808a88f71c0b0a0e0d3f493e0f1f77 Reviewed-on: https://chromium-review.googlesource.com/940616Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#540773}
-
- 04 Mar, 2018 7 commits
-
-
Rune Lillesveen authored
Intent-to-ship thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/6UNwnk97lrE Bug: 660265 Change-Id: I459d8aacb1defdc5aa1aee9e1958fd0831f9d60a Reviewed-on: https://chromium-review.googlesource.com/946468Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#540772}
-
Thomas Tangl authored
This CL adds a tooltip text to the DiceSigninButton dropdown arrow to make it more accessible. Bug: 814986 Change-Id: I65f6fea3bf6d3466425ab7a5e19955e9db9b938c Reviewed-on: https://chromium-review.googlesource.com/946093 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#540771}
-
Tien-Ren Chen authored
Extreme clip path values can create numerical issues including integer overflow, which is undefined behavior. This CL clamps clip path bounds to some sane value early in the pipeline. BUG=813340 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ie35ea2899b7103ed36ba42f0c78711811b253e60 Reviewed-on: https://chromium-review.googlesource.com/942303Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#540770}
-
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: If741f657bc9bdc777c0e4a12b2b07a1da7d4294c Reviewed-on: https://chromium-review.googlesource.com/947845 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#540769}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: Ib547969af6403ed8fe12c68b76e0f202196cba0a Reviewed-on: https://chromium-review.googlesource.com/947766Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#540768}
-
Sadrul Habib Chowdhury authored
BUG=none Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I11a4b83406a888660dbd8a4885fcfd862b20734f Reviewed-on: https://chromium-review.googlesource.com/946126Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#540767}
-
Luke Zielinski authored
This adds the values from the experiment to the codebase, in preparation for ad sampler launch. Bug: 744869 Change-Id: I4f89b3821d7b8b480a8865adf936ab64449c7139 Reviewed-on: https://chromium-review.googlesource.com/943701Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#540766}
-
- 03 Mar, 2018 23 commits
-
-
Fan Yang authored
In QUIC, free MemSlices in stream send buffer out of order. Protected by FLAGS_quic_reloadable_flag_quic_free_mem_slice_out_of_order. Merge internal change: 187322087 R=rch@chromium.org Change-Id: Ic43ef75d6155e36934e634cce056217d4fbd1992 Reviewed-on: https://chromium-review.googlesource.com/946328Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Fan Yang <fayang@chromium.org> Cr-Commit-Position: refs/heads/master@{#540765}
-
Scott Violet authored
no code change, just moves definition to match declaration for WindowTreeClient. BUG=none TEST=none TBR=jamescook@chromium.org Change-Id: I232363402b059af48671a7002656f8515123f15e Reviewed-on: https://chromium-review.googlesource.com/947893Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#540764}
-
Michael Lippautz authored
Tbr: haraken@chromium.org Bug: chromium:757440 Change-Id: I878f3f9f59488046ec0907f198ee6cd5e7cd2d13 Reviewed-on: https://chromium-review.googlesource.com/947965Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#540763}
-
Scott Violet authored
These make construction slightly clearer in that only arguments that are needed can be supplied. BUG=none TEST=covered by tests Change-Id: Ie4029896ff24957b1f7264ef6fb64fba018625ab Reviewed-on: https://chromium-review.googlesource.com/946882 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#540762}
-
Jeremy Roman authored
A fairly direct copy of CoerceJavaScriptListToArray, including adding the "do not coerce to string" behavior for elements. CoerceJavaScriptDictionaryToArray has the same behavior, so hopefully this distinction can be left out of the Java-side code. Bug: 794320 Change-Id: Ib9decbe9cbc332ac59b1590b10ff310057ee8544 Reviewed-on: https://chromium-review.googlesource.com/946872Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#540761}
-
David Grogan authored
When a table has a specified fixed height that is more than needed by its rows chrome only distributes the extra height to the first table body, ignoring thead, tfoot, and other tbody elements. Note this only contains tests, not a fix. Bug: 708345 Change-Id: Ib477306459a2f49feffe354e2cf3fed9b27e74e1 Reviewed-on: https://chromium-review.googlesource.com/942040 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#540760}
-
Jeremy Roman authored
std::make_unique is the more usual way to do this, and Blink doesn't even have WrapArrayUnique anymore for this reason. Bug: 755727 Change-Id: I9dc78827b8ef84da7c297ebc147a3ef157d0acc1 Reviewed-on: https://chromium-review.googlesource.com/946125Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#540759}
-
Greg Thompson authored
BUG=817450 TBR=jshin@chromium.org Change-Id: Iddd24e24699f8c94e7a51e56b4beed8867a4dc20 Reviewed-on: https://chromium-review.googlesource.com/947964Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#540758}
-
Jeremy Roman authored
Hopefully this makes it easier to what the rule being tested is. Change-Id: I381d15956be4ba6d15a9b54c18bf01657228eda4 Reviewed-on: https://chromium-review.googlesource.com/946116Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Peter Mayo <petermayo@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#540757}
-
Scott Violet authored
This reverts commit 824bbddf. Reason for revert: reverting in hopes of making tree green. The linux x64 bot has been flakely failing. For example, https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium%2FLinux_x64%2F59821%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout and FAILED: obj/components/download/internal/common/internal/download_response_handler.o /b/c/goma_client/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/components/download/internal/common/internal/download_response_handler.o.d -DV8_DEPRECATION_WARNINGS -DUSE_UDEV -DUSE_AURA=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DCR_CLANG_REVISION=\"325667-1\" -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS -D_LIBCXXABI_DISABLE_VISIBILITY_ANNOTATIONS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DCOMPONENTS_DOWNLOAD_IMPLEMENTATION -DGLIB_VERSION_MAX_ALLOWED=GLIB_VERSION_2_32 -DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_26 -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DHAVE_PTHREAD -I../.. -Igen -I../../third_party/protobuf/src -Igen/protoc_out -I../../third_party/protobuf/src -I../../third_party/boringssl/src/include -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -funwind-tables -fPIC -pipe -B../../third_party/binutils/Linux_x64/Release/bin -pthread -fcolor-diagnostics -Xclang -mllvm -Xclang -instcombine-lower-dbg-declare=0 -fdebug-prefix-map=/b/c/b/linux_clobber/src/out/Release=. -no-canonical-prefixes -m64 -march=x86-64 -Wall -Werror -Wextra -Wimplicit-fallthrough -Wthread-safety -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -Wno-unused-lambda-capture -Wno-user-defined-warnings -Wno-enum-compare-switch -Wno-null-pointer-arithmetic -O2 -fno-ident -fdata-sections -ffunction-sections -fno-omit-frame-pointer -g0 -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-ipc -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -isystem/b/c/b/linux_clobber/src/build/linux/debian_sid_amd64-sysroot/usr/include/glib-2.0 -isystem/b/c/b/linux_clobber/src/build/linux/debian_sid_amd64-sysroot/usr/lib/x86_64-linux-gnu/glib-2.0/include -Wno-header-guard -isystem/b/c/b/linux_clobber/src/build/linux/debian_sid_amd64-sysroot/usr/include/nss -isystem/b/c/b/linux_clobber/src/build/linux/debian_sid_amd64-sysroot/usr/include/nspr -std=gnu++14 -fno-exceptions -fno-rtti -nostdinc++ -isystem../../buildtools/third_party/libc++/trunk/include -isystem../../buildtools/third_party/libc++abi/trunk/include --sysroot=../../build/linux/debian_sid_amd64-sysroot -fvisibility-inlines-hidden -c ../../components/download/internal/common/download_response_handler.cc -o obj/components/download/internal/common/internal/download_response_handler.o In file included from ../../components/download/internal/common/download_response_handler.cc:5: ../../components/download/public/common/download_response_handler.h:16:10: fatal error: 'services/network/public/mojom/url_loader.mojom.h' file not found #include "services/network/public/mojom/url_loader.mojom.h" ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. Original change's description: > Move downloadResponseHandler to components/download > > No major change in functionality, just moving the files > > Bug: 803135 > Change-Id: I93737ed4539c1b3ddc25212814ef9b9c903ac882 > Reviewed-on: https://chromium-review.googlesource.com/944545 > Reviewed-by: Helen Li <xunjieli@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Reviewed-by: Bo <boliu@chromium.org> > Commit-Queue: Min Qin <qinmin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#540736} TBR=boliu@chromium.org,dtrainor@chromium.org,qinmin@chromium.org,xunjieli@chromium.org Change-Id: I1863660ebd431022abe2bf919ab38925fead91af No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 803135 Reviewed-on: https://chromium-review.googlesource.com/947983Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#540756}
-
Xianzhu Wang authored
The drag image is painted from the containing frame, so the property tree state should be the containing LayoutView's tree state. Bug: 816836 Change-Id: I28c6c9913cb89645f8f1dde4a34b47fab5ca77b4 Reviewed-on: https://chromium-review.googlesource.com/947257 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#540755}
-
Vikas Soni authored
https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/a182a9a..3c1cb02 Cq-Include-Trybots: master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.angle:linux_angle_rel_ng;master.tryserver.chromium.angle:win_angle_rel_ng Change-Id: I1303a026e8c781b9acff25e9c7b73ca4ba4c9299 Reviewed-on: https://chromium-review.googlesource.com/946893 Commit-Queue: vikas soni <vikassoni@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#540754}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/222d8fe8..77e9b284 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I4e8895405ec719a4711e25998ca9ecdfd32d3c95 Reviewed-on: https://chromium-review.googlesource.com/947765Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#540753}
-
James Wallace-Lee authored
PlatformServiceBridge, instead of using reflection, should load an instance of PlatformServiceBridgeImpl that is determined by GN. A downstream cl, which should land first, provides an alternate implementation of PlatformServiceBridgeImpl. Bug: 682070 Change-Id: I642603ccb4e4dd4a602803772acd343bfe6cf0dd Reviewed-on: https://chromium-review.googlesource.com/897994 Commit-Queue: James Wallace-Lee <jamwalla@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Paul Miller <paulmiller@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#540752}
-
Daniel Bratell authored
chrome_proximity_auth_client.cc uses easy_unlock_service which was just moved to be ChromeOS only so chrome_proximity_auth_client.cc needs to be as well. If it's compiled and not completely ignored by the linker (most of the time but not in jumbo builds), it will break the build. TBR=jhawkins@chromium.org Bug: 817115 Change-Id: I606cf0958beb6a736bf0717471a6542adde4dc73 Reviewed-on: https://chromium-review.googlesource.com/947962 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#540751}
-
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I7a4c2e60da4bc7a7e6ab8efe49789c6a2e43808b Reviewed-on: https://chromium-review.googlesource.com/947888Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#540750}
-
Kouhei Ueno authored
Bug: 813452 Change-Id: I31e68cd13b258516db7eac83fc5e8758d3912f51 Reviewed-on: https://chromium-review.googlesource.com/946908Reviewed-by:
Yoav Weiss <yoav@yoav.ws> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#540749}
-
rbpotter authored
- Reduce spacing between unsupported message and "Learn More" link in preview area. - Add new "No longer supported" fragment string and use in place of the "No longer supported." string for the destination settings (but not the destination change dialog). Bug: 792093 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ida7d0a02df3fed50a3d050f919a556711a9bacec Reviewed-on: https://chromium-review.googlesource.com/945308Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#540748}
-
Istiaque Ahmed authored
This CL adds two tests to exercise scenarios where verified_contents.json fetch can fail. The tests make sure that the fetch fails and ContentHashFetcher responds correctly. FetchInvalidVerifiedContents: Fetched hash contains invalid signature content. Fetch404VerifiedContents: Hash fetch results in 404. Bug: 818315, 796395 Change-Id: I3606bf504bf1e710705d2020bdf0ac3afa84d77a Reviewed-on: https://chromium-review.googlesource.com/942182 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#540747}
-
Chris Harrelson authored
This is mostly a re-land of https://chromium-review.googlesource.com/c/chromium/src/+/923089, now that a squashing bug was fixed in https://chromium.googlesource.com/chromium/src/+/8e4234fdc272ddda5ec9c156a2397c64d7a69f60. It differs from a straight-reland in that it also does not mark the PaintLayer with SetNeedsGraphicsLayerUpdate. Bug: 770343 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: If4a29f30b42ff45eb6a456bced4ab2e837f81d3e Reviewed-on: https://chromium-review.googlesource.com/947579Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#540746}
-
Siddhartha authored
This cl adds ukm for background memory dump providers. This only adds the providers approved in the privacy review: https://docs.google.com/document/d/1mzRM7TzDHo-blauk5nfG34zX_4_amCoshPE1iptoOdQ UMA for these metrics will be added in next cl. BUG=730783 Change-Id: Ife23dd28cd443725a7b8a6d74ba532220f4bb46f Reviewed-on: https://chromium-review.googlesource.com/939904 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#540745}
-
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/23d80a8f4bd2..644d1e63d9ad $ git log 23d80a8f4..644d1e63d --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src-internal The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I29796a786d06a2adc196b72706f7e3107c4c5d00 Reviewed-on: https://chromium-review.googlesource.com/947472Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#540744}
-
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I3bff32bad8e5a5b92b5770337065ec3cacd9350a Reviewed-on: https://chromium-review.googlesource.com/947885 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#540743}
-