- 06 Jan, 2021 13 commits
-
-
Ian Struiksma authored
2 Autofill tests are failing for various reasons (see individual bugs for details), so disabling until we do some re-recording. Also disabling 1 password manager test. Bug: 1140567 Change-Id: I5de917594c5c37ff9ec4158c45defe64c8f41cc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600794 Auto-Submit: Ian Struiksma <ianstruiksma@google.com> Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#840400}
-
Tomasz Wiszkowski authored
Bug: 1158456 Change-Id: I83141e1deffceef81e0e9d1928834dfe3f0783cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596252 Commit-Queue: Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#840399}
-
Patti authored
Python2 used to support 0-prefixed integers for octals. Python3 removed that in favor of the 0o prefix syntax. Fix the syntax error in calculate_package_deps.py by switching out the 0 for a 0o. Bug: 1163342 Change-Id: I84f181eb75c4ad75077ed898768eb37a12c51d65 TBR: thomasanderson@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612244 Commit-Queue: Patti <patricialor@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Patti <patricialor@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#840398}
-
Joey Arhar authored
srcElement and returnValue were specified in [1] and have WPTs in [2]. cancelBubble is documented in [3] and has a WPT which passes in all browsers in [4]. [1] https://github.com/whatwg/dom/pull/407 [2] https://github.com/web-platform-tests/wpt/pull/10258 [3] https://developer.mozilla.org/en-US/docs/Web/API/Event/cancelBubble [4] https://wpt.fyi/results/dom/events/Event-cancelBubble.html Fixed: 692695 Change-Id: Ia7113a9996a0e272829a3e81bf751412444e9ba8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610947Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#840397}
-
spdonghao authored
Related doc: https://docs.google.com/document/d/13MZrZWXnkUhR3pdtyBbxytoAe3Jpngy5RZ-Vg4iL8yQ/edit?resourcekey=0-eSxwXfEn4bpV3w_y-b2vpQ# Bug: 1155757 Change-Id: I70c38585c2bc41ff7f094d6becbd8335a49e7004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595351Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
Fred Mello <fredmello@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Hao Dong <spdonghao@chromium.org> Cr-Commit-Position: refs/heads/master@{#840396}
-
Sky Malice authored
Change-Id: If36b7a0da82d041742c4f454381a20817a3d0a51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607572Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#840395}
-
David Tseng authored
Change-Id: I0f04c23422d0e1a897a8402b42f8d61a86690970 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603934 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#840394}
-
Yuwei Huang authored
This CL provides an experimental AudioCapturer implementation for Mac. It's only enabled in debug builds. Since Mac doesn't provide an API to capture system-wide audio, the way it works is to have the user install some kind of loopback CoreAudio plugin like BlackHole, then make it both the input and output device. The user will also need to go to the clunky "Security & Privacy" panel and give Microphone permission to our app. This setup streams audio quite well and I didn't notice any glitches, though you'll need to have everything set up correctly in order to use this experimental capturer. Bug: 1161363 Change-Id: Id79a9bc2d9a7cdc788b3f0405432b99a31d08930 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601551 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#840393}
-
Jeroen Dhollander authored
This crash was introduced in my recent refactoring. Note it only happens when VLOG is enabled. Bug: N/A Test: deployed. Change-Id: Ie7029a2cf250a93778a831af95596ce02cbf8809 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612087 Auto-Submit: Jeroen Dhollander <jeroendh@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#840392}
-
adoneria authored
Bug: 1160010 Change-Id: Ic42d2d1c99aba531c4b1a13863670b11dd475f30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597714 Commit-Queue: Anjali Doneria <adoneria@google.com> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#840391}
-
Gordon Seto authored
Create ESimManagerListenerBehavior, a behavior for observing updates to the device's eSIM manager, EUICCs and eSIM profiles. This is needed to update the network settings page whenever its eSIM profiles change state. This behavior is required to implement crrev.com/c/2605399, "Install pending eSIM profile from network settings." Bug: 1093185 Change-Id: Ia996da718e7e3b81ad3fd28ef60d69a54757f84c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611081Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Gordon Seto <gordonseto@google.com> Cr-Commit-Position: refs/heads/master@{#840390}
-
Chris Thompson authored
Bug: 1113359 Change-Id: I4640e25113cd6cd7ec0031f6a08a743ce3a6b07d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611905Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Chris Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#840389}
-
Dirk Pranke authored
This reverts commit 2084b00a. Reason for revert: breaks local win dev builds somehow (still investigating) Original change's description: > Reland "Force Python 3 to be used in build." > > This is a reland of bb97ab9b > > I believe all of the breakages we encountered on the first > go-round have been fixed. > > Original change's description: > > Force Python 3 to be used in build. > > > > This CL makes Python 3 be the default script executable used by Ninja > > to run action() and action_foreach()'s during the build. > > > > This does *not* mean that everything works with Python3; many targets > > may still use Python 2 via the python2_action() and > > python2_action_foreach() targets or via custom logic. > > > > However, it does mean that it should prevent regressions from > > creeping in. > > > > This CL should not be taken to imply that we can start to write > > Python3-specific code that can run during the build; we should > > still be trying to ensure that everything is compatible with Python2. > > > > Also, this CL does not enable the use of vpython in actions; we should > > still avoid that because vpython is slower than direct Python > > invocations. > > > > Bug: 1112471 > > Change-Id: I472b032b500715156d955b0758640a7ed0384305 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515787 > > Reviewed-by: Bruce Dawson <brucedawson@chromium.org> > > Commit-Queue: Dirk Pranke <dpranke@google.com> > > Cr-Commit-Position: refs/heads/master@{#836234} > > Bug: 1112471 > Change-Id: I075999ef45df00708fabe480d4b71fdbf25a2ba6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591588 > Commit-Queue: Dirk Pranke <dpranke@google.com> > Reviewed-by: Bruce Dawson <brucedawson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840331} TBR=dpranke@google.com,brucedawson@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I2c29cc84ea30c4672b704f34dd23db8632549279 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1112471 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611699Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#840388}
-
- 05 Jan, 2021 27 commits
-
-
Matthew Mourgos authored
This change implements the functions added to the virtual keyboard private api for interacting with the clipboard history. The functions implemented are GetClipboardHistory, PasteClipboardItem, and DeleteClipboardItem. Bug: 1099318 Change-Id: I8d19947def36359164bdd97f55a182f6fac30d73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569100Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#840387}
-
Joel Hockey authored
CROS_USER_ID_HASH is required to be set into the crosh env. Bug: 1161413 Change-Id: I07de2348f0c40db1f6443777cd2979343e9b08f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607981 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#840386}
-
Jason Lin authored
Bug: b/167491603 Change-Id: Ic934fe19f08ec4495e8134a12e51a6b19855e024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602308Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Jason Lin <lxj@google.com> Cr-Commit-Position: refs/heads/master@{#840385}
-
adoneria authored
Bug: 1163309 Change-Id: I57b05eb02299ef5abd33745f673bb85f99fc4377 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612144Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Anjali Doneria <adoneria@google.com> Cr-Commit-Position: refs/heads/master@{#840384}
-
Regan Hsu authored
When PhoneHub's feature status is enabled and connecting while a tether connection is in progress at the same time, a view will show indicating to users that the Chromebook is connecting to the tether hotspot. screenshot: http://go/tscreen/69e50ec816e45a15ae1bd0a97966ece8ca08e671 Fixed: 1159847 Bug: 1106937 Change-Id: I68d56d66b3127f7677cb0a7cb86da59488506ec1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607156 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
-
Ionel Popescu authored
Since both prefers-color-scheme: dark and forced-colors: active can evaluate to true, the dark color scheme media query should be used only when forced-colors is not active. For forced-colors: active, system colors are already used to customize the appearance. The CL also contains two small forced colors fixes for: - time icon not being 100% visible - color picker hover state having wrong style Bug: 1157182, 1157180 Change-Id: Icb16600984e6267dcacee1860ffd1da0c7644e6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592331Reviewed-by:
-
Jinsuk Kim authored
CCT toolbar theme color should be obtained from the given tab and its theme color, not the current top theme color. Bug: 1161684 Change-Id: Iec5f64163abd32d5c6984cb7cecacb9a9b38661e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606876Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#840381}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f9a1b53d2809..325d666beb8f 2021-01-05 primiano@google.com Speculative fix of NaCL build 2021-01-05 primiano@google.com Merge "Win port: Disable android_{stats,internal} at build time" 2021-01-05 primiano@google.com Merge "Windows port: LITTLE_ENDIAN, ENTRYPOINT and minor test fixes" 2021-01-05 treehugger-gerrit@google.com Merge "Rename client factory files." 2021-01-05 primiano@google.com Merge "Checkout test data directly in /test, remove symlink" 2021-01-05 primiano@google.com Merge "base: Port subprocess to Windows" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:174454879 Tbr: perfetto-bugs@google.com Change-Id: I3b4f07f671b66c670b80cd7347ed975dc9cdcc5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611887Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840380}
-
Ryan Sturm authored
This CL adds a minimum required device memory threshold required to initiate search prefetch requests. The default value is chosen based on some Canary/Dev data. Bug: 1163189 Change-Id: Ib161d9ca1f207a25711dc4d48b1812522a1e8c76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611865Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#840379}
-
David Bokan authored
This method takes a callback as an argument which is invoked to indicate completion. The only override that uses this callback is ChromeRuntimeAPIDelegate; it can invoke the callback immediately, or store it in a vector of callbacks for later invocation. In the latter case, the callbacks are all destroyed after being invoked so they can only be invoked once. Bug: 1152268 Change-Id: If54898fcffafe232e0ee47365dbccb9f117d9a94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602887Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#840378}
-
Shuran Huang authored
CookieOptions.SamePartyCookieContextType is calculated in the URLRequestHttpJob via CookieAccessDelegate. Bug: 1136102 Change-Id: Idaea7a53fae0cdfe6956723190611e7000f448e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596129 Commit-Queue: Shuran Huang <shuuran@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#840377}
-
Aaron Krajeski authored
We are still getting useful data from these. Also change IsComposited and TransferControlToOffscreen from BooleanSuccess to Boolean, which seems more appropriate. OffscreenCanvas.Transferred/NewOffscreenCanvas and ToBlob.CompleteEncodingDelay/InitiateEncodingDelay are not renewed as I need to investigate their use further. Bug: 1160787, 1160789, 1160790, 1160791, 1160792, 1160852, 1160853 Change-Id: Ieee6c95bb989ab0a835178aef455078e7e128408 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611447 Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#840376}
-
Daniel Murphy authored
This is a result of doing the following commands: $ git grep "OnWebAppUninstalled" chrome | cut -f 1 -d : | sort | uniq \ | xargs sed -i 's/OnWebAppUninstalled/OnWebAppWillBeUninstalled/g' $ git grep "NotifyWebAppUninstalled" chrome | cut -f 1 -d : | sort \ | uniq | xargs sed -i \ 's/NotifyWebAppUninstalled/NotifyWebAppWillBeUninstalled/g' $ git cl format The system needs a signal for notifying after a web app has been uninstalled, and unfortunately the name for (OnWebAppUninstalled) already exists and notifies BEFORE the uninstall, which is grammatically incorrect. In the next patch, the new method will be created & implemented. Bug: 1162339 Change-Id: I537406623cd35b8acf23ee9ea3582139c3c2729c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606025 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Phillis Tang <phillis@chromium.org> Cr-Commit-Position: refs/heads/master@{#840375}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6356cb1904b8..4f509345ab9f 2021-01-05 reed@google.com Pass sampling to drawImageSet 2021-01-05 brianosman@google.com SkSL-to-SkVM: Misc fixes around arguments 2021-01-05 rmistry@google.com [recreateskps-bot] New locations for hosted pages If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC johnstiles@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: johnstiles@google.com Change-Id: I6b4405627c67a8b3fb1e4c0099ad9317755768ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611816Reviewed-by:
-
Jeremy Roman authored
It's usual to use integral_constant for this, especially since the underlying computation already is one. It still allows function-like syntax. Change-Id: Ie04bc5e3b46b63fbc7c0da2d1ae6198f7ecbac29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606127 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Auto-Submit: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#840373}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. The errors are: * "'transfer' used after it was moved" (4 times); * "'callback' used after it was moved" (2 times). Bug: 1122844 Change-Id: I212a2fef9d33aed17e322e599a1c21a86e3eeae0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601483Reviewed-by:
-
Toby Huang authored
This CL cleans up a feature flag that has already been on stable for over three milestones. Bug: 1158494 Change-Id: I6a529e3b31e34fb5af19e6b5e5e471c475ff80e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602251Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dan S <danan@chromium.org> Commit-Queue: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#840371}
-
Scott Violet authored
Prior to this the header was always added. After this, the header is only added if an extra is supplied. This only changes whether setClientDataHeaderForNewTab() is called and does not alter the implementation of that function. BUG=1163158 TEST=covered by tests Change-Id: Ic5d222d719a81c6da3d4e0c7866e18cbcee6e817 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611340 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#840370}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/472239462122..f9a1b53d2809 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I47990ba03242fffef5708db3af9f3ec1c5058153 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611868Reviewed-by:
-
Allen Bauer authored
This reverts commit 5f44611e. Reason for revert: Potential cause of recent crashes in toolbar layouts. Original change's description: > Use class properties for Ignored and can-be-visible state in a layout for a given view. > > This will remove the need for the child_infos_ field in LayoutManagerBase. > > Somewhat related to the work of integrating fill layout behavior into views::View. > > Bug: 1159116 > Change-Id: I968aa58fb3b29f78d96cd520e61ccb731c2e9ac9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605567 > Commit-Queue: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Cr-Commit-Position: refs/heads/master@{#839620} TBR=pkasting@chromium.org,kylixrd@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1159116 Change-Id: I9672a447b3b30530c049a9f6a89a8a1d42621bf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611911Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#840368}
-
Yue Zhang authored
This CL adds a three-dot menu to single cart item. The menu button is shown when users hovering on the cart item, and the menu pops up when the button is clicked. Right now the menu is a empty menu with no action items. Screenshot: https://drive.google.com/file/d/15L6okmPeKyN2BfnOEDlKuaLDCTg9vX-h/view?usp=sharing&resourcekey=0-wdcJxKoUVofqIh396Awepg Bug: 1160968 Change-Id: Id773fc280dd1c40aa8af7b0a8cac8f24660f5793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601278 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#840367}
-
Adrienne Walker authored
This will help move cache storage to the storage service. The next step here is to add a CacheStorageControl to replace the direct use of CacheStorageContextImpl here (and in background fetch). Bug: 1147642 Change-Id: If97503f214e11c87394043c833029485a71a0aee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551662 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
Ben Kelly <wanderview@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Auto-Submit: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#840366}
-
Luciano Pacheco authored
Generate JS module for //ui/file_manager/file_manager/background/js/ * file_operation_handler.js * file_operation_handler_unittest.m.js * file_operation_manager.js * file_operation_manager_unittest.m.js * trash.js * trash_unittest.m.js Bug: 1133186 Change-Id: I01334c52540202c1b7c22d0fd14527a1ca42cf28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610412 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#840365}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/de6e3a9d85af..6c876045de14 2021-01-05 jbudorick@chromium.org devil: make devil_env_test pass under py3. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC matthewdeluca@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1007101 Tbr: matthewdeluca@google.com Change-Id: I2e0359bddda1f8287cfd881439299926ad0fc2e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611890Reviewed-by:
-
ccameron authored
This reverts commit dd424da8. Reason for revert: The original revert was because this was landed before its dependencies (a rebase does not trigger a new try job). This reverts the revert now that the dependencies have been landed. Change-Id: I7e548abdc127d06ed9c23afc72f7ad3dee50d001 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2608767Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#840363}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Ia2fad32d0b2d7a52ad1c3580d59b31c2728ef24f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611127Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840362}
-
Zach Kirschenbaum authored
This reverts commit 394a78b4. Reason for revert: this breaks something Original change's description: > [fuchsia] handle RetrySystemUpdate reboot reason > > In this change, we add support for RetrySystemUpdate. Also, we stop > mapping `RebootSource::OTA` to `StateControlRebootReason::SystemUpdate` > because reboots for system updates should only be called from > fuchsia.git -- the code we remove isn't being run anyway. > > BUG=fuchsia:64591 > TEST=cast_reboot_unittests > > Change-Id: Ic15f86d31d3985d2fa5a2a3957c5ca61066cd476 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600053 > Reviewed-by: Sergey Volk <servolk@chromium.org> > Commit-Queue: Zach Kirschenbaum <zkbaum@google.com> > Cr-Commit-Position: refs/heads/master@{#838871} TBR=spang@chromium.org,servolk@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,zkbaum@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: fuchsia:64591 Change-Id: I9a2dd0fe105b1750c733925a8320a2f4e71cded2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611448Reviewed-by:
Sergey Volk <servolk@chromium.org> Commit-Queue: Zach Kirschenbaum <zkbaum@google.com> Cr-Commit-Position: refs/heads/master@{#840361}
-
