- 29 Oct, 2018 40 commits
-
-
Yuichiro Hanada authored
|composing_text_| of InputConnectionImpl should be cleared after CommitText() is called. Otherwise, FinishComposingText() will commit the same text twice. Bug: 899736 Test: unit_tests Change-Id: Idb22d968ffe95d946789fbe62454e8e79cb0b384 Reviewed-on: https://chromium-review.googlesource.com/c/1304773 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#603518}
-
John Budorick authored
Bug: 791632 Change-Id: I2feff44cf4f875e064bc701fc7f74bf84811e3c8 Reviewed-on: https://chromium-review.googlesource.com/c/1304058Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#603517}
-
David Barker authored
Stop inheriting from it and instead use the two classes separately, with PostMessageServiceConnection abstracted out of PostMessageHandler behind the PostMessageBackend interface added in change 1299016. This means we now store a PostMessageServiceConnection in SessionParams and call to it instead of PostMessageHandler for behaviour relating to the service connection. The result of this change is that PostMessageHandler can be used without a service connection, allowing us to use it directly from CustomTabActivity in a future CL. Bug: 898840 Change-Id: Ifd06ee0a803ecd82c350d7b5466bf0a0ee35440b Reviewed-on: https://chromium-review.googlesource.com/c/1299143 Commit-Queue: David Barker <barkerd@google.com> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#603516}
-
Christian Biesinger authored
R=mstensho@chromium.org,eae@chromium.org Change-Id: Ie77e1b604828e853f8432759d1fa726ce180b00b Reviewed-on: https://chromium-review.googlesource.com/c/1303886Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#603515}
-
Scott Graham authored
in https://chromium-review.googlesource.com/c/chromium/src/+/1302854. TBR: grunell@chromium.org Change-Id: Ia08618acf4aadf8111f4acb55f6cbfdd69b0222b Reviewed-on: https://chromium-review.googlesource.com/c/1304976Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#603514}
-
Stephane Zermatten authored
Before this change, the credentials sent with the RPCs come from chrome signed in. With this change, the credentials that are sent are those specified explicitly in the Intent, regardless of chrome's sign-in state. This only works on Android. This change leaves a fallback getting credentials from chrome sign in to keep the old behavior in case where the Intent doesn't specify anything. Bug: 806868 Change-Id: Id098c33dd4fa5c10050d3c4784ced7b67ed282cf Reviewed-on: https://chromium-review.googlesource.com/c/1297974 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#603513}
-
Parastoo Geranmayeh authored
Change the address validation logic according to this doc: (Solution 6) go/autofill-validation-dilemma Bug: 899251 Change-Id: I93435025754106d5c61889097690288d812f5f0c Reviewed-on: https://chromium-review.googlesource.com/c/1301797 Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#603512}
-
Daniel Rubery authored
We had a few tests that wanted to inspect the ClientDownloadRequest, but didn't do anything with the TestURLLoaderFactory. This led to the test waiting for 7 seconds, until the timeout kicks in. This CL adds calls to PrepareResponse, to mock out the network response, so that we no longer wait for a timeout. All unit tests under DownloadProtectionServiceTest now take <1s, with the worst around 200ms. Bug: 896796 Change-Id: I1c8f24c962fbb5d13e2a86ecfda6f80c1d19d1f4 Reviewed-on: https://chromium-review.googlesource.com/c/1299502Reviewed-by:
Nathan Parker <nparker@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#603511}
-
David Jean authored
Replaces https://crrev.com/c/1280277 Bug: 845472 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Iad5a713243dab998a1a202602a90eb06df0b603d Reviewed-on: https://chromium-review.googlesource.com/c/1283131Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#603510}
-
Ian Clelland authored
This reverts commit 8df245c7. Reason for revert: This is failing on ios-simulator builders See most recent build: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ios-simulator/38802 Log: PersonalDataManagerTest.UpdateClientValidityStates_Version: ../../components/autofill/core/browser/personal_data_manager_unittest.cc:6928: Failure Expected equality of these values: AutofillProfile::INVALID Which is: 3 profiles[0]->GetValidityState(EMAIL_ADDRESS, AutofillProfile::CLIENT) Which is: 2 Stack trace: 0 components_unittests 0x00000001131889aa base::debug::StackTrace::StackTrace() + 26 1 components_unittests 0x0000000110a22c90 StackTraceGetter::CurrentStackTrace(int, int) + 64 2 components_unittests 0x0000000110a32227 testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop(int) + 71 3 components_unittests 0x0000000110a3167d testing::internal::AssertHelper::operator=(testing::Message const&) const + 125 4 components_unittests 0x000000010d0a8334 autofill::PersonalDataManagerTest_UpdateClientValidityStates_Version_Test::TestBody() + 2244 ../../components/autofill/core/browser/personal_data_manager_unittest.cc:6935: Failure Expected equality of these values: AutofillProfile::INVALID Which is: 3 profiles[1]->GetValidityState(ADDRESS_HOME_STATE, AutofillProfile::CLIENT) Which is: 2 Stack trace: 0 components_unittests 0x00000001131889aa base::debug::StackTrace::StackTrace() + 26 1 components_unittests 0x0000000110a22c90 StackTraceGetter::CurrentStackTrace(int, int) + 64 2 components_unittests 0x0000000110a32227 testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop(int) + 71 3 components_unittests 0x0000000110a3167d testing::internal::AssertHelper::operator=(testing::Message const&) const + 125 4 components_unittests 0x000000010d0a8532 autofill::PersonalDataManagerTest_UpdateClientValidityStates_Version_Test::TestBody() + 2754 Original change's description: > [AF] Validate profiles for each major version > > Update the profiles' validities for each major version to keep up with > the possible changes in the Autofill Profile Validator logic. > See: go/autofill-use-validation > > Change-Id: I59656940c3b26f56e4278819c08cbd0fb79d3b56 > Reviewed-on: https://chromium-review.googlesource.com/c/1291589 > Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> > Cr-Commit-Position: refs/heads/master@{#603488} TBR=treib@chromium.org,sebsg@chromium.org,parastoog@google.com Change-Id: I8f77fb60015d8c599fc2e538795a58c9e76722b4 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1304975Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#603509}
-
jdoerrie authored
This change simplifies and hardens base::JSONWriter::BuildJSONString(). It replaces the old base::Value API with the new one, thus implicitly replacing DCHECKs with CHECKs. Bug: 859477 Change-Id: I5aa68cbc1e5e241d7b7061da2fe7078ac2904ec8 Reviewed-on: https://chromium-review.googlesource.com/c/1304477Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#603508}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/985e130969ef..00755b36f6d2 git log 985e130969ef..00755b36f6d2 --date=short --no-merges --format='%ad %ae %s' 2018-10-29 mlippautz@chromium.org V8 GC metrics: Split of foreground, background, and total time Created with: gclient setdep -r src/third_party/catapult@00755b36f6d2 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Idc1ae2456bd785d4f777e45af78a2de7a9f8758d Reviewed-on: https://chromium-review.googlesource.com/c/1304753Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#603507}
-
Eric Willigers authored
https://drafts.csswg.org/selectors-4/#zero-matches BUG=898215 Change-Id: I262b0ea290b340b634c6c4ffe98fa425bcff2b84 Reviewed-on: https://chromium-review.googlesource.com/c/1303356Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#603506}
-
Robert Ma authored
Using wpt-import in Chromium f8071b03. With Chromium commits locally applied on WPT: f79c6fe7 "Reimplementing getDatabaseNames() as databases() for indexeddb." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hbos@chromium.org, hta@chromium.org: external/wpt/webrtc kenneth.r.christiansen@intel.com, rijubrata.bhaumik@intel.com: external/wpt/web-nfc ksakamoto@chromium.org: external/wpt/resource-timing raphael.kubo.da.costa@intel.com, rijubrata.bhaumik@intel.com, timvolodine@chromium.org: external/wpt/generic-sensor rego@igalia.com: external/wpt/css/css-ui NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I68a34e5525249308e2456f8260b90e9ddf7f8e57 Reviewed-on: https://chromium-review.googlesource.com/c/1304616Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#603505}
-
Brian White authored
The Run() method can opt to do work inline and immediately run the callback rather than schedule a background task so its necessary to set the "active" flag before that call instead of after. Bug: 899576 Change-Id: I275b49c0e236282ebb47b4758e199445ba681ce4 Reviewed-on: https://chromium-review.googlesource.com/c/1303892Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#603504}
-
Arthur Sonzogni authored
This reverts commit 4327bb89. Reason for revert: the instrumentation is not triggered. There is no bug in this class. Original change's description: > DevtoolsUrlLoaderInterceptor: Instrument for bug 882661. > > In bug 882661: one mojo::URLLoader is sending OnStartLoadingResponseBody > without sending OnReceiveResponse before. > > Add instrumentation to check this never happen with this class. > > Bug: 882661 > Change-Id: I8a157949feacfe65f0ea1aa8c32b28352d6d6f57 > Reviewed-on: https://chromium-review.googlesource.com/c/1288595 > Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Cr-Commit-Position: refs/heads/master@{#601087} TBR=caseq@chromium.org,arthursonzogni@chromium.org Bug: 882661 Change-Id: I91998fad526604eefc84d2d47c091262d319968c Reviewed-on: https://chromium-review.googlesource.com/c/1304476Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#603503}
-
David 'Digit' Turner authored
trace_event_argument.h was renamed to traced_value.h in a previous CL (see related bug for all details), so this updates many includes to use the new header name. BUG=898787 R=torne@chromium.org,nyquist@chromium.org,yfriedman@chromium.org,fdoray@chromium.org,reveman@chromium.org,oshima@chromium.org,jialiu@chromium.org,nparker@chromium.org,battre@chromium.org,primiano@chromium.org,oysteine@chromium.org,danakj@chromium.org,enne@chromium.org,dcheng@chromium.org,backer@chromium.org,ericrk@chromium.org,ben@chromium.org,agl@chromium.org,asanka@chromium.org TBR=rockot@chromium.org,boliu@chromium.org Change-Id: I26676db3fa1446a3e007643a6ef58013d0a89357 Reviewed-on: https://chromium-review.googlesource.com/c/1301466 Commit-Queue: David Turner <digit@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#603502}
-
Mike Klein authored
TBR=fmalita@chromium.org See https://skia-review.googlesource.com/c/skia/+/165404 Change-Id: I88b2d6f1ebf0c515d7f6b3c62cbab40afb967788 Reviewed-on: https://chromium-review.googlesource.com/c/1304478 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by:
Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#603501}
-
David 'Digit' Turner authored
This CL introduces the TraceArguments helper class to simplify the way TRACE_EVENTXXX macro named arguments are passed to the trace log. By using a small dedicated data structure, it is possible to generate less code at each trace call site, compared to the old way that relies on passing 5 specially crafted arguments to TraceLog methods. For example, this optimization can save about 12 kiB in libmonochrome.so for the 32-bit ARM build of Chrome on Android. For more details, see corresponding bug entry. This CL does the following: - Introduce the new class in base/trace_event/trace_arguments.h - Move the definition of TraceValue to trace_arguments.h and augment the union with templated methods to support easy initialization from a large set of C++ value types. - Add new TraceLog methods to add trace events using an optional TraceArguments parameter, instead of a bag of 5 ones (count + names + types + values + convertables). - Simplify internal templates using C++11 universal references and std::forward<> to remove special-casing convertable arguments in trace event calls. - Remove the now obsolete TraceValueUnion type from trace_event.h - Make the TraceEvent class fully C++11 movable, to simplify its usage (this removes the Initialize() and MoveFrom() methods). - Update base/trace_event/ code to use TraceArguments and the new TraceEvent move operations. - Note that this keeps a few forwarding data types, values and methods to avoid other direct callers from the Chromium tree, these will be updated in future CLs. One Blink header needs to be modified though because it specializes a template defined in trace_arguments.h, to support sending WTF::CString references as trace arguments. BUG=898794 R=oysteine@chromium.org,chiniforooshan@chromium.org,alexiln@chromium.org TBR=primiano@chromium.org,torne@chromium.org Change-Id: I8fe2225974f7044515a2f64bdc67f6d36abfe004 Reviewed-on: https://chromium-review.googlesource.com/c/1298997 Commit-Queue: David Turner <digit@chromium.org> Reviewed-by:
-
Antonio Gomes authored
BUG=889880 Change-Id: Iaaebbf43a1a6a10327260da285ad2f315c5a0ccc Reviewed-on: https://chromium-review.googlesource.com/c/1304575 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#603499}
-
Alexander Shah authored
Modifies GetActiveHitTestRegionList in hit_test_manager in order to optionally return the ActiveFrameIndex. This way we dont have to look it up again when checking for newly submitted hit-test data. Will also be used in future changes of hit_test_aggregator for similar purposes. R=riajiang@chromium.org Change-Id: Ied4b0f690184017969ed42928230a3c5977b21c2 Reviewed-on: https://chromium-review.googlesource.com/c/1296892 Commit-Queue: Alexander Shah <zandershah@google.com> Reviewed-by:
Ria Jiang <riajiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#603498}
-
Yi Gu authored
The origin patch crrev.com/c/1301563 was reverted due to flakiness on the fast path. The reason was animating accelerated properties on the compositor may require 2 frames. And getComputedStyle needs an extra frame after that to get the updated property value because it's done on main. Commit message from the origin patch: This patch is similar to crrev.com/c/1289430. Previously the test was relying on worklet console log which might be racy on main. Using computed style is better and more compatible. Bug: 887659 Change-Id: I1fb160274d4454fb6adafa4b295eebd505ad9a03 Reviewed-on: https://chromium-review.googlesource.com/c/1304693 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#603497}
-
Steven Bennetts authored
This will allow ContainerBehavior classes to be used without a KeyboardController instance (i.e. from src/chrome in Mash). Bug: 843332 Change-Id: I6f0332f3c528aff92aca8359e41e647767c537d2 Reviewed-on: https://chromium-review.googlesource.com/c/1300394 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#603496}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f3ff14c00b43..72864963fe62 git log f3ff14c00b43..72864963fe62 --date=short --no-merges --format='%ad %ae %s' 2018-10-29 yvesg@webrtc.org Download aap2 and bundletool as part of required dependencies. 2018-10-29 dkirovbroadsoft@gmail.com Modified PressEnterToContinue() to actualy check if Enter is pressed 2018-10-29 nisse@webrtc.org Replace some usage of EventWrapper with rtc::Event. 2018-10-29 Peter) Slatala Add missing assignment in RTCConfiguration.mm Created with: gclient setdep -r src/third_party/webrtc@72864963fe62 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:845405 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I97c573dd8da9fe866a4d874f2bc2f56f432a4f2e Reviewed-on: https://chromium-review.googlesource.com/c/1304378Reviewed-by:
-
Antonio Gomes authored
BUG=889880 Change-Id: I9281596226272ff8cadff1c678136750eeb5b902 Reviewed-on: https://chromium-review.googlesource.com/c/1304576Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#603494}
-
Christian Biesinger authored
Change-Id: Ia64f68252dbc8e24389799693a40a81539ad23f9 Reviewed-on: https://chromium-review.googlesource.com/c/1303888Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d289e7e7..d2036a9f Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9b1f5c4cff9bb4545fedbec61060674814e41ba6 Reviewed-on: https://chromium-review.googlesource.com/c/1304410Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#603492}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/618decb9c4f5..1de48d8040aa git log 618decb9c4f5..1de48d8040aa --date=short --no-merges --format='%ad %ae %s' 2018-10-29 halcanary@google.com infra/skqp/docker/README.md: whitespace changes for readability Created with: gclient setdep -r src/third_party/skia@1de48d8040aa The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=herb@chromium.org Change-Id: Ib8503c4935db3e434e85e7a26b6a9f63f118f9ac Reviewed-on: https://chromium-review.googlesource.com/c/1304377Reviewed-by:
-
Peter Wen authored
Actually implementing the listener avoids the need for a lambda inner class and avoids the need for a new singleton. Bug: 896276 Change-Id: I420b1348e5f896bb6b7dc4fad663f88c8c71e997 Reviewed-on: https://chromium-review.googlesource.com/c/1300096 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#603490}
-
Eric Seckler authored
Adds support for retrieving known categories and trace buffer status on the java side. Also reenables a once flaky test. Bug: 898512, 621956 Change-Id: I09522386587696a42d79a7d53ad5b5c314c49f3d Reviewed-on: https://chromium-review.googlesource.com/c/1299240 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#603489}
-
Parastoo Geranmayeh authored
Update the profiles' validities for each major version to keep up with the possible changes in the Autofill Profile Validator logic. See: go/autofill-use-validation Change-Id: I59656940c3b26f56e4278819c08cbd0fb79d3b56 Reviewed-on: https://chromium-review.googlesource.com/c/1291589Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Cr-Commit-Position: refs/heads/master@{#603488}
-
Mikel Astiz authored
We've observed some crashes during shutdown, presumably because the datatype controllers outlive the KeyedServices they depend on. Instead, let's destroy all controllers during the KeyedService's Shutdown(). Bug: 870624 Change-Id: I50aac6207871f51cfabeedc574043a9f32690c1f Reviewed-on: https://chromium-review.googlesource.com/c/1303363Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/abe2229c3928..0a47db54fa15 Created with: gclient setdep -r src-internal@0a47db54fa15 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I8d8e3dd74f8023fe72007f8bb15705c29551c5a3 Reviewed-on: https://chromium-review.googlesource.com/c/1303744Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#603486}
-
Kevin Schoedel authored
The composition sequences included the above incorrect mapping as well as the correct [circumflex][space]->[^]. Bug: 885067 Test: none Change-Id: I3144ede559dc66184ecae0ab1ef032a7ba067946 Reviewed-on: https://chromium-review.googlesource.com/c/1302497Reviewed-by:
Shu Chen <shuchen@chromium.org> Commit-Queue: Kevin Schoedel <kpschoedel@chromium.org> Cr-Commit-Position: refs/heads/master@{#603485}
-
manuk authored
This is the 3rd of 3 CL's to replace the global static helper functions which manipulate the DOM with classes. In this CL, we replace the function addResultToOutput with OutputResultsGroup, which is responsible for generating HTML for each response from C++ AutocompleteController. Multiple responses can be returned for a single query, each is handled by unique OutputResultsGroup. Bug: 891303 Change-Id: I385ee9b3b299d640f9cfb62d0b3bef5c704adbe8 Reviewed-on: https://chromium-review.googlesource.com/c/1294412 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#603484}
-
Daniel Bratell authored
openh264 sources lists referred to two non-existing headers which prevented gn check from successfully working on that code. This patch removes those headers from the sources list. One of them (utils.h) does exist but with another path, and it's already included with that path, Change-Id: Ie0a1e7e0b48295a28e9a89651e07800a70a36154 Reviewed-on: https://chromium-review.googlesource.com/c/1298956Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#603483}
-
Rijubrata Bhaumik authored
Tested using a brio-stream-4k-hd-webcam, where we could change the exposure time in manual mode. command line: v4l2-ctl -d 1 --set-ctrl exposure_auto=1 v4l2-ctl -d 1 --set-ctrl exposure_absolute=100 GUI: guvcview --device=/dev/video1 TEST= run the demo in https://codepen.io/rijuB/pen/gjapBo use slider to change exposureTime. BUG=823316 Intent to Implement and Ship discussions: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/ls3wQSoHOUY Change-Id: I2c4faaf8bd475fedefd267aaf83e6c06f55e5afd Reviewed-on: https://chromium-review.googlesource.com/c/1243288 Commit-Queue: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#603482}
-
Peter Wen authored
- Adding myself and isherman@ to: chrome/android/java/src/org/chromium/chrome/browser/crash/OWNERS Bug: None Change-Id: I955dbded0924f5a8fdea1ffeaf6d97f2d31bea0e Reviewed-on: https://chromium-review.googlesource.com/c/1294474Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
Raphael Kubo da Costa authored
IWYU. std::unique_ptr needs <memory>, which was being included indirectly and breaking the libstdc++ build after commit e806ef73 ("Snap after pressing arrow key"): In file included from ../../cc/input/snap_selection_strategy.cc:5:0: ../../cc/input/snap_selection_strategy.h:20:15: error: ‘unique_ptr’ in namespace ‘std’ does not name a template type static std::unique_ptr<SnapSelectionStrategy> CreateForEndPosition( ^~~~~~~~~~ ../../cc/input/snap_selection_strategy.h:24:15: error: ‘unique_ptr’ in namespace ‘std’ does not name a template type static std::unique_ptr<SnapSelectionStrategy> CreateForDirection( ^~~~~~~~~~ ../../cc/input/snap_selection_strategy.h:27:15: error: ‘unique_ptr’ in namespace ‘std’ does not name a template type static std::unique_ptr<SnapSelectionStrategy> CreateForEndAndDirection( ^~~~~~~~~~ ../../cc/input/snap_selection_strategy.cc:9:6: error: ‘unique_ptr’ in namespace ‘std’ does not name a template type std::unique_ptr<SnapSelectionStrategy> ^~~~~~~~~~ ../../cc/input/snap_selection_strategy.cc:18:6: error: ‘unique_ptr’ in namespace ‘std’ does not name a template type std::unique_ptr<SnapSelectionStrategy> ^~~~~~~~~~ ../../cc/input/snap_selection_strategy.cc:24:6: error: ‘unique_ptr’ in namespace ‘std’ does not name a template type std::unique_ptr<SnapSelectionStrategy> ^~~~~~~~~~ Bug: 819294 Change-Id: I83c594b1ae71a34f21e77c7c9d866e47629c7a61 Reviewed-on: https://chromium-review.googlesource.com/c/1304418Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#603480}
-
Michael Lippautz authored
These metrics are high level and do not include subscopes. Examples: - v8-gc-mark-compactor-total - v8-gc-mark-compactor-mmu - v8-gc-mark-compactor-marking-total No-try: true Tbr: nednguyen@chromium.org Change-Id: I6feafb6971f0904d1d9bd31201d1be2e63258049 Reviewed-on: https://chromium-review.googlesource.com/c/1304479Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#603479}
-
