GitLab

ScopedFileOpener::Runner is a ref counted object, and its first reference
used to be made in its constructor through base::Bind.
The reference is passed to ProvidedFileSystem::OpenFile, and released
when the callback object is destroyed.

However, if OpenFile failed, the reference is released before the
Runner construction has done. Then `new Runner` returns a stale pointer,
instead of newly created object.

This CL adds a static consntructor and moves the implicit ref count
manipulation out of the real constructor.

Bug: 866456
Change-Id: I92d68b3383d8fecd900be080cc23551cddb5f12b
Reviewed-on: https://chromium-review.googlesource.com/1156325Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579359}

https://webrtc.googlesource.com/src.git/+log/168b4977f3c2..df9e9ae9ee66


git log 168b4977f3c2..df9e9ae9ee66 --date=short --no-merges --format='%ad %ae %s'
2018-07-31 nisse@webrtc.org Delete RtpVideoStreamReceiver methods GetRtpReceiver and rtp_rtcp


Created with:
  gclient setdep -r src/third_party/webrtc@df9e9ae9ee66

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ie53eed13d23d29acec30a87b30cbb984129b3698
Reviewed-on: https://chromium-review.googlesource.com/1156244Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579358}

This CL corrects the unified search box on J devices as described in the
linked bugs.

To be more precise, the failure on J devices was coincidental: on those
devices, export was not available and therefore no overflow menu and
instead of hiding the overflow menu, the search box would be hidden.

The main changes are ensuring, that we only ever affect the overflow
menu, in case it exists and unifying the way action bar buttons change
appearance.

Bug: 868279, 868316
Change-Id: I969f5085262f4452327e445b2bb2e9286e20a956
Reviewed-on: https://chromium-review.googlesource.com/1154972Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579357}

This CL adds a unit test for the force touch gesture recognizer added
to the toolbar buttons, triggering the popup menu.

TBR=marq@chromium.org

Bug: 864430
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ia87d675b460922eb1991de4022438e0ed0b1ce4d
Reviewed-on: https://chromium-review.googlesource.com/1156304Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579356}

Ephemeral provider is added to the list of content settings sources that
are counted in site settings change counter.

Bug: 762560
Change-Id: I526f7280b61b4f777560c58a99cf5148bd9b9ff9
Reviewed-on: https://chromium-review.googlesource.com/1155603Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579355}

Replace Identification arguments of CryptohomeClient and SessionManagerClient with AccountIdentifier.
Add and use conversion functions to create AccountIdentifier from other
types.
Change the key type of SessionManagerClient::ActiveSessionMap to
std::string.

BUG=741274
TEST=build

TBR=msramek@chromium.org for changes under chrome/browser/browsing_data/

Change-Id: Iaa4518f5a6f37f6ac3b89e965ffa59412ffde5cc
Reviewed-on: https://chromium-review.googlesource.com/1144814
Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579354}

This will allow us to share this code with the Aura Linux implementation
in a future change. We also create a new abstract class to collect these
attributes while maintaining performance between the different
platforms. Currently there is only an implementation of this class for
Windows.

Bug: 866612
Change-Id: I5cb84b9f226e976ac2b199149ea897831a48d175
Reviewed-on: https://chromium-review.googlesource.com/1152977
Commit-Queue: Martin Robinson <mrobinson@igalia.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579353}

I just discovered that FakeProfileOAuth2TokenService never cancels
access token requests:
- OAuth2TokenService::FetchOAuth2Token() is virtual and overridden by
  FakePO2TS. This is the method that creates pending fetchers for
  access token requests. FakePO2TS' override results in O2TS not
  creating any pending fetchers for access token requests.
- OAuth2TokenService::CancelRequests{ForAccount}(), however, are *not*
  virtual. O2TS simply looks in its set of pending fetchers to cancel
  the relevant ones.

The combination of these facts means that requests are not cancelled
in response to CancelRequests{ForAccount}() when FakePO2TS is used.
This in turn means that production flows are not accurately reflected,
and blocks creating a unittest for a just-discovered production bug
(that itself would perhaps have not landed if this situation was not
as it is).

This CL remedies the problem by having FakePO2TS override the
now-virtual methods for cancelling access token requests to respond
appropriately. It also updates a few unittests that had previously
(either intentionally or unintentionally) worked around the lack of
cancellation by cancelling requests manually after token revocation.

Change-Id: Id935831294849a191e6034f3fe1360bea1dddc9e
Reviewed-on: https://chromium-review.googlesource.com/1154925
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579352}

Since we are now creating orderfiles by running across multiple
benchmarks, the stability computations don't make much sense as, for
example, we don't expect the startup symbols from two different
benchmarks to necessarily be similar.

Bug: 865983
Change-Id: I11f756a69bf160e9dce293e3c1cd05003264da0f
Reviewed-on: https://chromium-review.googlesource.com/1152739Reviewed-by: Benoit L <lizeb@chromium.org>
Commit-Queue: Matthew Cary <mattcary@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579351}

This reverts commit c36d213a.

Reason for revert: The bot does not have the needed audio driver to run this test.

Original change's description:
> Reland "Re-enable webrtc audio quality browsertests on windows."
> 
> This is a reland of a3ec8289
> 
> Original change's description:
> > Re-enable webrtc audio quality browsertests on windows.
> > 
> > Tests were previously disabled when they started failing (more context in linked bug). Re-enabling because tests pass locally on win7 machine.
> > 
> > Bug: 850936
> > Change-Id: Ie1ab4e82daf2c0265e932237d3edf6b3399ee803
> > Reviewed-on: https://chromium-review.googlesource.com/1139066
> > Reviewed-by: Henrik Boström <hbos@chromium.org>
> > Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#575638}
> 
> Bug: 850936
> Change-Id: I44be2227ffed90d25549669de4dd3f354a98d92a
> Reviewed-on: https://chromium-review.googlesource.com/1156224
> Reviewed-by: Henrik Boström <hbos@chromium.org>
> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#579344}

TBR=hbos@chromium.org,marinaciocea@chromium.org

Change-Id: I30ce4fe93a7787cb5cca85fcf969c254e829dd74
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 850936
Reviewed-on: https://chromium-review.googlesource.com/1156344Reviewed-by: Marina Ciocea <marinaciocea@chromium.org>
Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579350}

This CL completely rewrites MessagePopupCollection which manages popup
notifications. The requirement for the class was changed over time, and
that made the class fragile. Also, there were too many internal states.

For simplicity and full test coverage, MessagePopupCollection manages
all animation states, and only single animation runs at one time.
(This is different from ToastContentsView. The class corresponds to
MessagePopupView in this CL, and it has fewer responsibilities.)

Also this CL has new Chrome OS popup animation in mind. go/qs-proto

As a further refactoring, merging of PopupAlignmentDelegate to
MessagePopupCollection is planned.

Design doc: go/chrome-popup-refactoring

BUG=863366
TEST=MessagePopupCollectionTest

Change-Id: I77c908423c03869d4ac3fa04133f41b73877bd3b
Reviewed-on: https://chromium-review.googlesource.com/1132720Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579349}

Similarly to r568056 and 573161 this change adds skeletons required for
the implementation and testing of GATT Descriptor discovery on WinRT. No
functionality is added, this will follow in a future CL.

Bug: 821766
Change-Id: Ib6cb238c97899c94f54fcf5146a5e36ede69b909
Reviewed-on: https://chromium-review.googlesource.com/1155119Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579348}

Missing out on Attach after setting the listener reference to the
JavaScript function means that a garbage collection can collect the
Blink listener object. To avoid such errors we immediately call Attach
in SetListener.

Bug: chromium:843903
Change-Id: I2c2ec8b0942853ee7e6c29e8c4850b075a398c53
Reviewed-on: https://chromium-review.googlesource.com/1155586Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579347}

Follow-up to fc0443b1 ("Update CORS error messages"), which broke the GCC
build because GCC does not implicitly covert all array items to StringViews
when Append() is invoked:

    ../../third_party/blink/renderer/platform/loader/cors/cors_error_string.cc: In function ‘WTF::String blink::CORS::GetErrorString(const network::CORSErrorStatus&, const blink::KURL&, const blink::KURL&, const blink::SecurityOrigin&, blink::Resource::Type, const WTF::AtomicString&)’:
    ../../third_party/blink/renderer/platform/loader/cors/cors_error_string.cc:72:55: error: no matching function for call to ‘Append(WTF::StringBuilder&, <brace-enclosed initializer list>)’
                        last_request_url.GetString(), "' "});
                                                           ^
    ../../third_party/blink/renderer/platform/loader/cors/cors_error_string.cc:24:6: note: candidate: ‘template<long unsigned int N> void blink::CORS::{anonymous}::Append(WTF::StringBuilder&, const WTF::StringView (&)[N])’
      void Append(StringBuilder& builder, const StringView (&views)[N]) {
          ^~~~~~
    ../../third_party/blink/renderer/platform/loader/cors/cors_error_string.cc:24:6: note:   template argument deduction/substitution failed:
    ../../third_party/blink/renderer/platform/loader/cors/cors_error_string.cc:72:55: note:   mismatched types ‘WTF::StringView’ and ‘const char*’
                        last_request_url.GetString(), "' "});
                                                           ^

Make the local Append() function take a std::initializer_list<StringView> to
make sure all items are converted to that type on invocation.

Bug: 819294
Change-Id: I7c14773589dda16e7c882270e206d1b66dbb73b4
Reviewed-on: https://chromium-review.googlesource.com/1155113Reviewed-by: Adam Rice <ricea@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#579346}

Add instructions on how to allow running APKs from unknown sources.

BUG=none
TEST=manual

Change-Id: I61539cff081555d9255454fa3f30b986c2c5c6f6
Reviewed-on: https://chromium-review.googlesource.com/1154543Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Thiemo Nagel <tnagel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579345}

This is a reland of a3ec8289

Original change's description:
> Re-enable webrtc audio quality browsertests on windows.
> 
> Tests were previously disabled when they started failing (more context in linked bug). Re-enabling because tests pass locally on win7 machine.
> 
> Bug: 850936
> Change-Id: Ie1ab4e82daf2c0265e932237d3edf6b3399ee803
> Reviewed-on: https://chromium-review.googlesource.com/1139066
> Reviewed-by: Henrik Boström <hbos@chromium.org>
> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#575638}

Bug: 850936
Change-Id: I44be2227ffed90d25549669de4dd3f354a98d92a
Reviewed-on: https://chromium-review.googlesource.com/1156224Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579344}

Tooltip is not needed for the "sign in another user..." button because
it's same as the label itself. The default behavior of the label can add
tooltip with the label text only when the label is truncated.

Test: manual
Bug: 866439
Change-Id: I4dee9ea44b751d64f07b0458311a653bffb0a283
Reviewed-on: https://chromium-review.googlesource.com/1152644Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579343}

https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/b532d7ce708c..578bcf103a12

$ git log b532d7ce7..578bcf103 --date=short --no-merges --format='%ad %ae %s'
2018-07-30 wl [cff] Fix typo.
2018-07-29 wl * src/pcf/pcfread.c (pcf_get_encodings): Another thinko.
2018-07-28 apodtele * builds/unix/configure.raw: Minor.
2018-07-28 apodtele [smooth] Fix Harmony memory management.
2018-07-28 wl [type1] Avoid segfaults with `FT_Get_PS_Font_Value'.
2018-07-27 wl [truetype] Make `TT_Set_MM_Blend' idempotent (#54388).
2018-07-27 wl [psaux, type1]: More tracing improvements.
2018-07-26 wl Document FT_Module_Class's `module_interface' field.
2018-07-25 wl [psaux, type1] Trace PostScript dictionaries and other things.
2018-07-25 wl Fix minor ASAN run-time warnings.
2018-07-24 apodtele [build] Fortify dllexport/dllimport attributes (#53969,#54330).
2018-07-24 wl [type1] Check relationship between number of axes and designs.
2018-07-24 htl10 [truetype] Match ttdebug's naming of instruction mnemonics.
2018-07-24 wl * src/pcf/pcfread.c (pcf_get_encodings): Thinko.
2018-07-22 wl * src/pcf/pcfread.c (pcf_get_encodings): Check index of defaultChar.
2018-07-22 wl * src/pcf/pcfread.c (pcf_load_font): Fix number of glyphs.
2018-07-22 wl [cid] Sanitize `BlueShift' and `BlueFuzz'.
2018-07-22 wl Fix links.
2018-07-21 wl Minor comment improvement.
2018-07-21 wl [pcf] Fix handling of the undefined glyph.
2018-07-21 wl Improve stream extraction macro documentation.
2018-07-20 prince.cherusker Move the legacy fuzz target to the `freetype-testing' repository.
2018-07-20 wl [cff] Avoid left-shift of negative numbers (#54322).
2018-07-17 wl Allow FT_ENCODING_NONE for `FT_Select_Charmap'.
2018-07-17 wl * src/pcf/pcfread.c (pcf_get_encodings): Trace `defaultChar'.
2018-07-16 prince.cherusker * include/freetype/internal/ftcalc.h: Add macros for handling harmless over-/underflowing `FT_Int' values.
2018-07-16 wl * src/truetype/ttgxvar.c (tt_set_mm_blend): Fix off-by-one error.
2018-07-12 wl * src/base/ftoutln.c (FT_Outline_Get_Orientation): Init `cbox'.

Created with:
  roll-dep src/third_party/freetype/src
R=bungeman@chromium.org,drott@chromium.org

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng

PDFium-Issue: pdfium:1125
Change-Id: I09a0c66426dfdade532fe262d0ace7656e3d1b53
Reviewed-on: https://chromium-review.googlesource.com/1155652Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579342}

This PR accidentally made the "addTrack(0 streams)" test call addTrack()
with a stream, which broke the tests:
https://github.com/web-platform-tests/wpt/pull/12141

Test restored and all "addTrack/addTransceiver(X streams)" are made to
consistently use "new MediaStream()" the same way.

Bug: 869036
Change-Id: Ieaf0c73a1996aeb2e87e18f2f9065fa1e6fee1e7
Reviewed-on: https://chromium-review.googlesource.com/1155125Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579341}

This CL switch only imported header file to unblock WebRTC refactoring
to move sigslot target to proper location. But it is required that
all usages of sigslot will be eliminated from chromium code base. Here
is a ticket to track this effort: https://crbug.com/867820

Bug: 867820, webrtc:8366
Change-Id: I431a178048886833b8bbd8508ce5a3937997f5ab
Reviewed-on: https://chromium-review.googlesource.com/1150537Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Olga Sharonova <olka@chromium.org>
Commit-Queue: Artem Titov <titovartem@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579340}

Live bytes are computed during sweeping for regular garbage collection.
The live bytes computation was missing from the logic that makes the
heap consistent after performing marking just for taking a snapshot.
The result is that ProcessHeap counters are not usable when just
performing a garbage collection for snapshots as the counters would
always be zeroed out.

Bug: chromium:865438
Change-Id: Id0d7e7a75895a6e6bb0ae62959f3e7a36b3d26fa
Reviewed-on: https://chromium-review.googlesource.com/1155121Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579339}

This change contains a small fix to perform an explicit connection check
after receiving a BluetoothLEDevice instance. This is necessary for
paired devices, where the connection handler gets registered too late to
get notified of the initial GATT connection initiated by the OS.

Bug: 821766
Change-Id: Ic022035f101324daa9a0772940740550e948e5fb
Reviewed-on: https://chromium-review.googlesource.com/1154920Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579338}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/9093ff098254..2c3d9c837512


git log 9093ff098254..2c3d9c837512 --date=short --no-merges --format='%ad %ae %s'
2018-07-31 manojgupta@google.com cros_setup_toolchains: Enable llvm-libunwind in cross-* pkgs.


Created with:
  gclient setdep -r src/third_party/chromite@2c3d9c837512

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Idc56ac0e71b8b75ec5c6c6491e20b2b0cacb62f4
Reviewed-on: https://chromium-review.googlesource.com/1156140Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579337}

This CL adds announcements to be read with VoiceOver for the in product
helps.

Bug: 866936
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ie89fa1b2b0179a8070351c2ce926ac18158ebdef
Reviewed-on: https://chromium-review.googlesource.com/1154536Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579336}

#enable-show-autofill-signatures flag is enabled.

<form name="change_password_form" >
  <input type="text" name="username" pm_parser_annotation="username_element" >
  <input type="password" name="current-password" pm_parser_annotation="password_element" >
  <input type="password" name="new-password" pm_parser_annotation="new_password_element" >
  <input type="password" name="password-again" pm_parser_annotation="confirmation_password_element" >
</form>

Bug: 824793
Change-Id: Ie02de13798abfc0aca0dfe9c47667ff4c52b4163
Reviewed-on: https://chromium-review.googlesource.com/1151315
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579335}

@IntDef/@StringDef annotation are preferred way for declaring
set of String/int values.

1. they need less space in APK than enum, see
https://developer.android.com/topic/performance/reduce-apk-size#remove-enums
2. they give more control over allowed values than "static final" values

Main goal of patch is writing "static final" values, enum
and some classes in one common @IntDef/@StringDef form:

1. with @IntDef/@StringDef first, @Retention second
   and related @interface third
2. with values inside @interface
3. with NUM_ENTRIES declaring number of entries if necessary
4. with comment about numbering from 0 without gaps when necessary
5. with @Retention(RetentionPolicy.SOURCE)
6. without "static final" in the @interface

Change-Id: If5663352e5aaf731e8c5a166a6ac1c9c59988867
Reviewed-on: https://chromium-review.googlesource.com/1150224Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Marcin Wiącek <marcin@mwiacek.com>
Cr-Commit-Position: refs/heads/master@{#579334}

https://webrtc.googlesource.com/src.git/+log/1899c1270f0c..168b4977f3c2


git log 1899c1270f0c..168b4977f3c2 --date=short --no-merges --format='%ad %ae %s'
2018-07-31 buildbot@webrtc.org Roll chromium_revision fdf31b15..fb3a9711 (579160:579262)
2018-07-30 peah@webrtc.org AEC3: Increasing the accuracy of the detection for early reverb


Created with:
  gclient setdep -r src/third_party/webrtc@168b4977f3c2

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng

BUG=chromium:None,chromium:865397
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Id138c35b1cf30747808c3286d9b9212e2054cb84
Reviewed-on: https://chromium-review.googlesource.com/1155888Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579333}

Most callers anyway need to retrieve information from ProfileSyncService
about the selected datatypes, so let's instead make sure all paths to
DataTypeManager::Configure() are centralized in ProfileSyncService.

This will simplify extending the functions signature in follow-up
patches.

Bug: 866814,851476
Change-Id: Ied3975b9ed833d34aee1802aae36c1332b3b68e0
Reviewed-on: https://chromium-review.googlesource.com/1152812
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579332}

The pref for the Safe Sites filter, kSafeSitesFilterBehavior, should be
accessible from //components/policy, where the filter itself will check
it once implemented.

Note that this policy's pref is unused until the follow-up CL.

Bug: 819405
Change-Id: If87877488067ee008f16d2dc848f5e2ab01de25f
Reviewed-on: https://chromium-review.googlesource.com/1117877Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579331}

As far as I can tell, both of these flags just mean "respect
symbol_level when sanitizers are enabled". This change makes it so
that we always do that, removing the need for both flags. Because
the default symbol level is 1 in sanitizer builds, we still get -g1
(which is equivalent to -gline-tables-only) by default. Users can
now adjust the symbol level simply by setting symbol_level.

Change-Id: Ied9f589c268e7e5c625b4cce46d76e51452e473b
Reviewed-on: https://chromium-review.googlesource.com/1156125Reviewed-by: Oliver Chang <ochang@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579330}

Many call sites which use this function do not
bother about the clearing the typing but they use
this function which is confusing.
Rather we will use FrameSelection::SetSelection
and pass default options now.
This CL does it from the EditorCommand.

Bug: 867563
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Ie25813f1cd76b00001a0447118c9a3e8cd42cc52
Reviewed-on: https://chromium-review.googlesource.com/1154861
Commit-Queue: Tanvir Rizvi <tanvir.rizvi@samsung.com>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579329}

A primary use case for the All sites page should be to view the sites
that are using the most disk space on the user’s device. Currently
grouped sites show the number of cookies. This patch adds support for
showing the amount of local storage used for each origin.

Sorting by data usage in all sites will now sort by local storage, using
the number of cookies as a tie breaker, i.e. sites with any amount of
local storage will be ordered before sites with no local storage and
cookies.

Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I3816279f9795fbaa59d67279548a1deba097f852
Bug: 835712
Reviewed-on: https://chromium-review.googlesource.com/1148169
Commit-Queue: Patti <patricialor@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579328}

https://skia.googlesource.com/skia.git/+log/946a162a5239..0bf5408286ea


git log 946a162a5239..0bf5408286ea --date=short --no-merges --format='%ad %ae %s'
2018-07-31 brucewang@google.com Implement Subpixel mode for color format image.


Created with:
  gclient setdep -r src/third_party/skia@0bf5408286ea

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=scroggo@chromium.org

Change-Id: Iae510c7be804446d7a470a61e47206c30d61b2ca
Reviewed-on: https://chromium-review.googlesource.com/1155889Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579327}

This allows them to be opened via chrome.fileManagerPrivate.executeTask.
Otherwise, they get filtered out in apps::LaunchPlatformAppWithFileHandler(..)

Note this doesn't change the default app for opening video files from
the file manager. It just allows the files to be passed via the
executeTask API. Adds FileTasksBrowserTest.DefaultHandlerChangeDetector
to ensure default handlers do not change unless it is intended to do so
in future.

Bug: 867705
Change-Id: I758b8599b6fa1f0b60f72bf3466d796ec0aedaa3
Reviewed-on: https://chromium-review.googlesource.com/1151039Reviewed-by: Noel Gordon <noel@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579326}

SelectPopup is the only object invoked from native before Java
side initialization is performed, which led to adding a call in
|WebContentsImpl.initialize| to trigger the init operation. This
CL removes the explicit init by having native do it in a lazy
manner before invoking Java side |show|.

Bug: 868238
Change-Id: I8691607472bd8432f4ff3379b9e1452bb76ca21c
Reviewed-on: https://chromium-review.googlesource.com/1155270
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579325}

The absolute path for the mount point of Android files is long and not user
friendly. We should replace the path with the "Play files" label, which we use
in Files app UI.

Bug: 863616
Test: Manually tested on ARC-enabled device with multiple languages.
Change-Id: I96548e96489c8480736f8cfc1de53f1c838eb98b
Reviewed-on: https://chromium-review.googlesource.com/1145100Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579324}

We need to enforce exit_time_destructors compiler flag warning everywhere.

Bug: 860581
Change-Id: I7cbb2ef3ba5c71a69233bc8bd50725786b6ea0b1
Reviewed-on: https://chromium-review.googlesource.com/1155276Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579323}

Most test extensions manifest's have a descripton: the Files, Gallery,
Video Player, Audio Player test extension do not (how very odd). Let's
give them a description, for consistency with all test extensions.

Bug: 836254
Change-Id: I43dce817da53f9ae7a584f4b30907c3c0649ee85
Reviewed-on: https://chromium-review.googlesource.com/1156118
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579322}

Previously the field constructed_tree_scopes is added
to CSSStyleSheet to track addition of constructed CSSStyleSheets
in tree scopes when adding/removing them from
TreeScope.moreStyleSheets.

moreStyleSheets already was removed at blink[1].
so constructed_tree_scopes is not needed anymore.

[1]https://chromium-review.googlesource.com/1125741

Bug: 869244
Change-Id: Icc0b68393fd100d08ee826d6dbe0859468ee1e23
Reviewed-on: https://chromium-review.googlesource.com/1155286
Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579321}

A test is added to check if an extension with command key binding can
not be accessed when it is not allowed in incognito.

Bug: 862075
Change-Id: Id49fb16958a9913978f8b054740c0ef4d0977c25
Reviewed-on: https://chromium-review.googlesource.com/1141727Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579320}