GitLab

aura-mus has a different environment than mus, so WMHelperMus (in exo)
was updated accordingly.

This breaks switches::kUseMusInRenderer. I'll fix that next.

BUG=672932 663525
TEST=covered by tests
R=reveman@chromium.org, sadrul@chromium.org

Review-Url: https://codereview.chromium.org/2578893003
Cr-Commit-Position: refs/heads/master@{#439044}

This CL helps unify the way we destroy references to surfaces.
We currently have two code paths for satisfying a surface sequence.
One is through calling the satisfy callback which is given to the
reference holder, and the other one is through populating
satisfies_sequences in CompositorFrameMetadata and letting
Surface::QueueFrame do the rest of the work. Eventually they both do
the same thing: they call SurfaceManager::DidSatisfySequences. This CL
gets rid of satisfies_sequences in CompositorFrameMetadata and from now
on the only way for satisfying a sequence is through the callback. This
is a necessary change because we are phasing out SurfaceSequence and
exposing it in CompositorFrameMetadata is not a good idea.

BUG=659598
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2537943002
Cr-Commit-Position: refs/heads/master@{#439043}

This patch makes each LocalFrame own an IdleSpellCheckCallback. Future
patches will make this callback handle spell checking in the frame when
IdleTimeSpellChecking is enabled.

BUG=517298

Review-Url: https://codereview.chromium.org/2581063002
Cr-Commit-Position: refs/heads/master@{#439042}

When col/colgroup spans added up to exactly 2^32, the result would
overflow to 0, which was the divisor for a later operation.

This patch clamps col spans to 8190, matching cell colspans. This makes
the problem harder to trigger but doesn't eliminate it.

BUG=660581

Review-Url: https://codereview.chromium.org/2518163002
Cr-Commit-Position: refs/heads/master@{#439041}

BUG=none

Review-Url: https://codereview.chromium.org/2585453003
Cr-Commit-Position: refs/heads/master@{#439040}

This CL cleans up a selectedSite member and replaces it with a more
clear selectedSiteForUnitTest member.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2580653003
Cr-Commit-Position: refs/heads/master@{#439039}

There were bugs in the handling of the result coming back from an editor. We now have improved logic around:
* Receiving |null| from the editor (cancelling out of an Add flow)
* Receiving an incomplete result (cancelling out of an Edit for an incomplete item)
* Receiving a complete item.

Also updated the tests and added a few new ones.

BUG=673371
TEST=PaymentRequest* (java)

Review-Url: https://codereview.chromium.org/2571513004
Cr-Commit-Position: refs/heads/master@{#439038}

BUG=643746

Review-Url: https://codereview.chromium.org/2569143002
Cr-Commit-Position: refs/heads/master@{#439037}

This code won't actually work. There are a couple of things that need
to be fixed for it to work:

. My understanding from looking at the code is that it will create
  multiple WindowTreeClients in the same thread. That can work, but when
  you do that you have to explicitly pass a WindowPortMus to Windows
  when you create them. That's hard in this case because
  DesktopNativeWidgetAura is creating the windows for you. The fix
  isn't hard, probably set the WindowTreeClient in
  DesktopNativeWidgetAura so that it can create WindowPort correctly.

. aura::WindowTreeClientDelegate has a couple of functions that can't
  be implemented in ViewImpl. Specifically getting the capture client
  and a PropertyConverter. The capture client generally comes from
  WMState and the PropertyConverter can be a singleton. It shouldn't
  be that hard to wire these up.

. aura::Env needs to be created with Mode::MUS.

As my understanding is I can't really run this code yet I didn't
pursue the fixes. If there is a way to run this code I can try and
make these fixes, otherwise I would prefer to postpone.

BUG=674757
TEST=none
R=ben@chromium.org

Review-Url: https://codereview.chromium.org/2585593002
Cr-Commit-Position: refs/heads/master@{#439036}

Reland of [DevTools] Migrate target domain to new generator. (patchset #1 id:1 of https://codereview.chromium.org/2578303002/ )

Reason for revert:
Fixed crash reason in https://codereview.chromium.org/2579923002/

Original issue's description:
> Revert of [DevTools] Migrate target domain to new generator. (patchset #2 id:20001 of https://codereview.chromium.org/2574843003/ )
>
> Reason for revert:
> Speculative
>
> Original issue's description:
> > [DevTools] Migrate target domain to new generator.
> >
> > BUG=664683
> > TBR=pfeldman
> >
> > Committed: https://crrev.com/a1a32123e28de766b5df3c82ec9ed9f8ddadd724
> > Cr-Commit-Position: refs/heads/master@{#438733}
>
> TBR=caseq@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=664683
>
> Committed: https://crrev.com/70847052d87dab3241593b925f87b2b96c031b7e
> Cr-Commit-Position: refs/heads/master@{#438940}

TBR=caseq@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=664683

Review-Url: https://codereview.chromium.org/2581103002
Cr-Commit-Position: refs/heads/master@{#439035}

BUG=570441

Review-Url: https://codereview.chromium.org/2580903003
Cr-Commit-Position: refs/heads/master@{#439034}

The following tests now use testharness.js:
  animation-direction-alternate.html
  animation-direction-alternate-reverse.html
  animation-direction-reverse-fill-mode.html
  animation-direction-reverse-non-hardware.html
  animation-direction-reverse-timing-functions.html

BUG=674123

Review-Url: https://codereview.chromium.org/2573413002
Cr-Commit-Position: refs/heads/master@{#439033}

Once the mojo connection is broken, all subsequent calls to the CDM
should fail.

BUG=671362
TEST=new tests pass

Review-Url: https://codereview.chromium.org/2561263002
Cr-Commit-Position: refs/heads/master@{#439032}

Removing the SiteEngagement experiment as it has gone stable.

BUG=539723

Review-Url: https://codereview.chromium.org/2577503004
Cr-Commit-Position: refs/heads/master@{#439031}

Default frame colors are changed so that inactive frames are always a
blend of 80% white/20% active color to increase contrast.
* The normal/inactive frame is changed to #F6F6F6 on all platforms. (OSX
  was already at this color.)
* The incognito/inactive frame is changed to #D4D5D5 on all platforms
  except OSX.
* The tints applied to theme images are changed to match the new
  lightness ratio as well. Inactive tint is changed to 80% lightness.
  Incognito/inactive is changed to be 74% lightness, which approximates
  blending 80% white on top of the active tint's 30% black. Also
  increased saturation change of incognito/inactive to match
  incognito/active.

Windows will now pick up the user colors specified by the system and use
them when custom drawing the titlebar. It will never draw the titlebar
white unless the user explicitly specifies that color. It uses an 80%
white/20% active blend to calculate inactive frame colors if the user
has no frame color specified, just like above.

BUG=505013,645682

Review-Url: https://codereview.chromium.org/2541873004
Cr-Commit-Position: refs/heads/master@{#439030}

BUG=none
R=lushnikov@chromium.org

Review-Url: https://codereview.chromium.org/2563213002
Cr-Commit-Position: refs/heads/master@{#439029}

iOS builds can set use_xcode_clang = true and use_system_xcode = false when
chromium clang is broken.  This requires prepending DEVELOPER_DIR to clang/clang++, etc

BUG=669094

Review-Url: https://codereview.chromium.org/2578273002
Cr-Commit-Position: refs/heads/master@{#439028}

When complete, the Gtk3 theming code will look completely different
from the Gtk2 code.  This CL splits out NativeThemeGtk in preparation
of this change.

The planned change for gtk3 is to use foreign drawing (see
gtk/demos/gtk-demo/foreigndrawing.c) to provide an implementation of
NativeTheme::GetPartSize and NativeTheme::Paint*.

The Gtk2 theme will continue to use the NativeThemeBase
implementations of these functions while just supplying basic colors.

BUG=132847
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2579683002
Cr-Commit-Position: refs/heads/master@{#439027}

Landing async stylesheet update caused a regression in font-display
tests. The values "fallback" and "optional" block display for 100ms
according to the spec. The tests had a setTimeout call to trigger font
loading and a setTimeout call to trigger notifyDone() to render before
100ms has passed with the same timeout value. However, the timer for
allowing fallback display triggers before the notifyDone triggers in
Debug builds on Mac. Calling notifyDone from the same setTimeout
callback as triggering font loading.

The intention of the test is to trigger the screen dump when 0s has
passed, so this should be OK. I have not identified what exactly changed
with the async stylesheet patch and why the timeout methods are
interleaved with the timeout for enabling fallback rendering.

Removing one of the other tests or one of the font-display values from
the test array also makes the "fallback" and "optional" start passing
without this change, so there is clearly a timing issue here.

BUG=567021

Review-Url: https://codereview.chromium.org/2584473002
Cr-Commit-Position: refs/heads/master@{#439026}

Revert of Delete an unused (not even referenced) asset. (patchset #1 id:1 of https://codereview.chromium.org/2585453004/ )

Reason for revert:
Broke ChromiumOS daisy Compile Build.

https://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20daisy%20Compile/builds/29817

Original issue's description:
> Delete an unused (not even referenced) asset.
>
> BUG=522168
> TBR=oshima@chromium.org
>
> Committed: https://crrev.com/02c22847c5da0c157fdc4ef33826126d4625092f
> Cr-Commit-Position: refs/heads/master@{#439023}

TBR=oshima@chromium.org,estade@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=522168

Review-Url: https://codereview.chromium.org/2581093002
Cr-Commit-Position: refs/heads/master@{#439025}

This CL adds a tooltip for name abbreviations and no longer truncates the object
name when it is the title. Long names in previews are still truncated.

BUG=667614

Review-Url: https://codereview.chromium.org/2553293002
Cr-Commit-Position: refs/heads/master@{#439024}

BUG=522168
TBR=oshima@chromium.org

Review-Url: https://codereview.chromium.org/2585453004
Cr-Commit-Position: refs/heads/master@{#439023}

Clicking on "Send Now" should not scroll to the top.

This cl patches in the solution devised by phistuck@gmail.com. See bug 659491 for detail.

BUG=659491

Review-Url: https://codereview.chromium.org/2580543002
Cr-Commit-Position: refs/heads/master@{#439022}

Revert of Convert ClangToTiOS on chromium.fyi to do a simulator/debug build and run all tests (patchset #1 id:1 of https://codereview.chromium.org/2577323002/ )

Reason for revert:
per thakis@

Original issue's description:
> Convert ClangToTiOS on chromium.fyi to do a simulator/debug build and run all tests
>
> BUG=673621
>
> Committed: https://crrev.com/dfa33876e22dbdcb2ac21b4ba75dd626dd1bc046
> Cr-Commit-Position: refs/heads/master@{#439019}

TBR=thakis@chromium.org,smut@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=673621

Review-Url: https://codereview.chromium.org/2580733007
Cr-Commit-Position: refs/heads/master@{#439021}

- Added back/forward buttons.
- Added pushState() button.  This is necessary because if the pushState
  call is executed by injected JavaScript, then the navigation is
  registered as a client redirect.
- Display placeholder state object string when a popstate event with a
  null state object is received.

BUG=673022

Review-Url: https://codereview.chromium.org/2583733002
Cr-Commit-Position: refs/heads/master@{#439020}

BUG=673621

Review-Url: https://codereview.chromium.org/2577323002
Cr-Commit-Position: refs/heads/master@{#439019}

BUG=674542
R=foolip@chromium.org

Review-Url: https://codereview.chromium.org/2585563002
Cr-Commit-Position: refs/heads/master@{#439018}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/2c88e4c9..94faac75

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2580873003
Cr-Commit-Position: refs/heads/master@{#439017}

This target packages up all that is needed to run Cronte tests.

BUG=629299
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2551803003
Cr-Commit-Position: refs/heads/master@{#439016}

Reland of [DevTools] Migrate ServiceWorker domain to new generator. (patchset #1 id:1 of https://codereview.chromium.org/2577233002/ )

Reason for revert:
Fixed crash reason in https://codereview.chromium.org/2579923002/

Original issue's description:
> Revert of [DevTools] Migrate ServiceWorker domain to new generator. (patchset #2 id:20001 of https://codereview.chromium.org/2573993003/ )
>
> Reason for revert:
> Crashes.
> BUG=674474
>
> Original issue's description:
> > [DevTools] Migrate ServiceWorker domain to new generator.
> >
> > BUG=664683
> > TBR=pfeldman
> >
> > Committed: https://crrev.com/b41d221cb138f0f5e3824229f12bf794172e106f
> > Cr-Commit-Position: refs/heads/master@{#438676}
>
> TBR=caseq@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=664683
>
> Committed: https://crrev.com/2cbd54ce7ac7c807af2c9065a6eedd81ac97a3c5
> Cr-Commit-Position: refs/heads/master@{#438942}

TBR=caseq@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=674474

Review-Url: https://codereview.chromium.org/2580833004
Cr-Commit-Position: refs/heads/master@{#439015}

BUG=673666

Review-Url: https://codereview.chromium.org/2572963002
Cr-Commit-Position: refs/heads/master@{#439014}

https://pdfium.googlesource.com/pdfium.git/+log/72a22025ec44..47fb8c06acd0

$ git log 72a22025e..47fb8c06a --date=short --no-merges --format='%ad %ae %s'
2016-12-15 tsepez Return unique_ptr from CFX_BinaryBuf::DetachBuffer()
2016-12-15 dsinclair Move window type mask up with masked flags
2016-12-15 dsinclair Remove widget offscreen code.
2016-12-15 dsinclair Cleanup widget edge related code
2016-12-15 dsinclair Remove more unused widget styles
2016-12-15 dsinclair Remove unused widget state flags
2016-12-15 dsinclair Remove unused sysbtn code

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2577283002
Cr-Commit-Position: refs/heads/master@{#439013}

Cr-Commit-Position: refs/heads/master@{#439012}

I missed out on removing a few things in http://crrev.com/2571063002, which I've cleaned up here.

BUG=673844

Review-Url: https://codereview.chromium.org/2576753002
Cr-Commit-Position: refs/heads/master@{#439011}

This is the sub-patch (2/3) of supporting |EditCommandSource| in
|CompositeEditCommand| (https://crrev.com/2574793002).

This CL:
1. Added method |Editor::replaceSelectionForSpellChecker()| for
   |SpellChecker::replaceMisspelledRange()| to hide editor details;
2. Passed command source from |Editor::Command| to various methods in |Editor|,
   such as |performDelete()|, |removeFormattingAndStyle()|, |applyStyle()|,
   |replaceSelectionWithText()| etc.

Note:
It's OK to add extra |EditCommandSource| parameter to those methods because
they are going to be moved to "EditorCommand.cpp" (according to the editing
refactor doc), which means they should share the similar pattern as other
|static execute*()| methods.

This CL shouldn't have any behavior change.

Next CL will pass command source down to |CompositeEditCommand| and
|TypingCommand|.

Editing Refactor doc:
https://docs.google.com/a/chromium.org/document/d/1i-f5ByGHIvTcvy2UEAvOtBK14BNMFTB8ms9uedeArbw/edit?usp=sharing

BUG=673789

Review-Url: https://codereview.chromium.org/2576903002
Cr-Commit-Position: refs/heads/master@{#439010}

No longer needed.

BUG=674757
TEST=none
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2578373002
Cr-Commit-Position: refs/heads/master@{#439009}

Previously, ArcIntentHelperBridge::OnIntentFiltersUpdated() called
OnAppsUpdated() for each observer, but this was probably just confusing.
This CL renames the observer method to fix the inconsistency and to
make it easier to maintain the ArcServiceManager::Observer interface.

This is a follow-up CL for
https://codereview.chromium.org/2487623002/.

BUG=672840
TEST=try

Review-Url: https://codereview.chromium.org/2579083002
Cr-Commit-Position: refs/heads/master@{#439008}

The test runner was previously tearing down the SIGTERM handler once
it finished running tests and generating results. In some cases, though,
it's still hanging after that point. This CL keeps the SIGTERM handler
through the end of the process s.t. we can still log hangs that happen
later.

BUG=664308

Review-Url: https://codereview.chromium.org/2584453003
Cr-Commit-Position: refs/heads/master@{#439007}

In some feedback reports, users see empty Files app because resolveIsolatedEntries()
does not finish.
It timeouts in 15 minutes and then Files app should show volumes except for the
erronous volume, but waiting 15 minutes should be too long.
Shorter timeout period should mitigate the issue to some extent.

BUG=671080
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2584443002
Cr-Commit-Position: refs/heads/master@{#439006}

After checking in the CL which tries to address the Jumplisticon
performance bug, grt@ pointed out there are a few nits need to be
fixed, including inconsistent code change in different OS files,
unnecessary code and comments.

I copy and paste the comments from grt@ in line with the code in
this CL and reply direclty there.

BUG=40407
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng

Review-Url: https://codereview.chromium.org/2577163002
Cr-Commit-Position: refs/heads/master@{#439005}