- 14 Aug, 2020 40 commits
-
-
cfredric authored
Change-Id: Ife54b3e6e5ff261d55fb56ea1674c9a5702b4a8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356244 Auto-Submit: Chris Fredrickson <cfredric@google.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#798146}
-
Toni Barzic authored
When running UnlockAnimationBeforUIDestroyed, animate shelf before lock screen containers. Shelf fades out and then fades in when the unlock animation completes - i.e. in the UnlockAnimationBeforeUIDestroyed callback. If animations run immediately, the fade out and fade in animation order could get reversed if fade out animation is started after the part of unlock animation to which animation callback is passed. I'm not sure that this is actually the root cause for the linked issue, but it is a way to get to an invisible shelf (it requires zero length animation, which may happen during screen rotation). BUG=1106796 Change-Id: I8f26200666e742b249ba96b64a32ce28022634f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352905Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#798145}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/765a9826cde1..0e97afad480e 2020-08-14 alexrudenko@chromium.org Add Node change listeners to Layout pane 2020-08-14 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-08-14 petermarshall@chromium.org tests: Add an it.repeat() helper 2020-08-14 patrick.brosset@microsoft.com Layout: Display class/id-less elements just with their tagname 2020-08-14 alexrudenko@chromium.org Regenerate bridge for LayoutPane 2020-08-14 patrick.brosset@microsoft.com Force a screen reader pause between a tag name and attributes If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1101782,chromium:1109177,chromium:1115449,chromium:1116353 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I28bb348f938e281364f6df90e3beb85e41a5e999 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355517Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798144}
-
arthursonzogni authored
This make it easier to access an attribute using Javascript. This also make both the network reports and the ReportingObserver to have the same attribute names. Previously, the spec was based on CSP, which has both camelCase and hyp-hen. Today, we report thing using camelCase instead: - DocumentPolicyViolationReport, - FeaturePolicyViolationReport, - DeprecationViolationReport, - InterventionViolationReport Bug: 922191 Change-Id: Ic875163b16acf5083ed8197266fc23034f2c5005 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352926Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#798143}
-
Victor-Gabriel Savu authored
Add missing entry to kKnownSettings. Bug: chromium:1116336 Change-Id: Ib00bc2f60b1d27851d1675e32f259c767da11ad9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353261Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Victor-Gabriel Savu <vsavu@google.com> Cr-Commit-Position: refs/heads/master@{#798142}
-
Alex Chau authored
- last_task_completed_ should only signal if it's already shutdown, otherwise last_task_completed_ will be stuck in insignalled state when the first task completes Bug: 1116437 Change-Id: I8f2172a5af031c5073563b518d77adca29fa85bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352886 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#798141}
-
James Long authored
The package graph page is now blue, and the class graph page is now red. The favicons for each page type have been updated to reflect this, and links to the other page type have the corresponding icons in order to indicate a change in the page type. Hyperlinks remain blue, regardless of page type, to avoid confusion. Bug: 1102546 Change-Id: I23ef7fb7cb2a85678a4b29712716905523a89cab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354526 Commit-Queue: James Long <yjlong@google.com> Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#798140}
-
David Bokan authored
Update tests for force-load-at-top DocumentPolicy to use updated false syntax. Bug: 1047900 Change-Id: I2b02b94715b0edd8dfaaf2676ff91dab01a00702 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354954Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#798139}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c184cf36092f..c9c4e2e9efac 2020-08-14 fmalita@chromium.org Componentize SkAudioPlayer 2020-08-14 johnstiles@google.com Use a scoped block for inlined return statements. 2020-08-14 robertphillips@google.com Update iOS Skottie App for GrContext changes 2020-08-14 robertphillips@google.com Require a direct context to precompile shaders in DM 2020-08-14 johnstiles@google.com Enable ClangTidy flag modernize-use-override. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: fmalita@google.com Change-Id: I92e6793942257b113dd2ea590351c4d60b39f23a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355520Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798138}
-
Orin Jaworski authored
This CL eliminates the state invalidation that was used to cause translation prompt to show, as that did not work in all cases. The translation step is changed so the prompt always shows, which is much simpler. Bug: 893183 Change-Id: I5dca3eb30032461fc8824a36c9a80a1a82f84cdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354660Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#798137}
-
Scott Violet authored
To not do this means a NavigationObserver must be used as well. By having the FaviconFetcherDelegate notify on navigation means the ui for the favicon can be self contained. BUG=1076463 TEST=covered by tests Change-Id: Idf5d2a65b154e04e409b4596db9530bf28049603 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352267 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#798136}
-
Russ Hamilton authored
Bug: 973801 Change-Id: I5bc5154a5aecb85b5f04a70c238f3b7ef684b8df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354668 Commit-Queue: Russ Hamilton <behamilton@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#798135}
-
Rayan Kanso authored
ImageResource's type members is a mojo_base.mojom.String16? which is typemapped to WTF::String in blink. For some reason though, passing a null WTF::String to mojom is crashing the renderer. This CL explicitly sets the image resource type to the empty string if not available, and adds a web test to make sure this doesn't happen again. Change-Id: I115666b6e42011dfc398965bd0f4e795d1869979 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352878 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#798134}
-
Jan Wilken Dörrie authored
This change adds native bindings in the Password Check to be able to update a compromised credential. Bug: 1114720 Change-Id: I6a3de9a4f79b88f17c7594a181d8b7e10c9e10bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352927 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#798133}
-
Jonathan Mengedoht authored
Bug: 927473 Change-Id: I4a215037fb51d17f6882f6459a01641a08149e7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339414Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Jonathan Mengedoht <mengedoht@google.com> Cr-Commit-Position: refs/heads/master@{#798132}
-
Boris Sazonov authored
Reason: fails on builders. Builder links: https://ci.chromium.org/p/chromium/builders/ci/Marshmallow%2064%20bit%20Tester/33104 https://ci.chromium.org/p/chromium/builders/ci/Lollipop%20Phone%20Tester/26554 TBR=enne@chromium.org Bug: 1116464 Change-Id: Ia7bf9b0be040e2aaa1a1d61f922e41547332da32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355927Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#798131}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Ia396e6b0e2a86e1768b1e78c0b65510e7d954d3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354428Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798130}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1597384369-5af373c8a15e3096c063e440b85721943db04b1b.profdata to chrome-mac-master-1597405958-c5a8fe7086bb1f6a4ff7abcf1204e717b88da2c5.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I865e534137e29e3744bd56829182f4475b185a1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356264Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798129}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/4daf2c7a45b2..292d9a8341d3 2020-08-14 jleconte@google.com Add a run quest for webrtc_perf_tests. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC eseckler@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1024246 Tbr: eseckler@google.com Change-Id: I830d94396672837edcd2ba5268755238117d1351 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355516Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798128}
-
Sergey Ulanov authored
Image access in OutputPresenterImages was not synchronized because need_synchronization() was false int he images it uses. Updated OutputPresenterFuchsia to set SCANOUT image usage bit and also updated ExternalVkImageBacking::need_synchronization() to return true for SCANOUT images. This ensures that image access in OutputPresenterFuchsia properly. Also fixed semaphore ownership handling in OutputPresenterFuchsia. Bug: 1115692 Change-Id: Ibf375845eab2fbf320f777f45adcc98719ee239c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353413 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#798127}
-
Camillo Bruni authored
Add tests for upcoming microtask checkpoint fixes and top-level-await for modules. The added test cover in more detail the following items: - onload events - onerror events - queueMicrotask drive-by-fix: Check for onunhandledrejection Bug: 1022182, 1096455c, 1114034, v8:9344 Change-Id: Ieaa7691bf44e2758ed873ca53bcc6852812dd723 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346251 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#798126}
-
Lucas Furukawa Gadani authored
Bug: 1110926 Change-Id: Ib22e96d4898f08f326094bfdc030eb7a73b65e00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353016 Commit-Queue: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#798125}
-
Peter Kasting authored
Bug: 1104532 Change-Id: Icc7244ef277171fbc37f1fc3ca89837a629aa01b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354628 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Mike Pinkerton <pinkerton@chromium.org> Reviewed-by:
Mike Pinkerton <pinkerton@chromium.org> Cr-Commit-Position: refs/heads/master@{#798124}
-
Chris Hamilton authored
Similar to workers, this adds tokens to WorkletGlobalScopes so they can be uniquely identified in a renderer process. Will be used by performance.measureMemory implementation. BUG=1085129 Change-Id: Ia7f194f1864639e19d9ddb9ee2d70cc6e00ba183 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351286 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#798123}
-
Matthias Körber authored
Adds test to check getting and setting the structured address tokens. It is also tested that the tokens are reset if the unstructured information changes. Change-Id: Ia10d19bc31a11443beb31ee509b35a33b68edad6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355904Reviewed-by:
Christoph Schwering <schwering@google.com> Commit-Queue: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#798122}
-
Peter Kasting authored
Bug: 1104532 Change-Id: Icd6a1b8331d30837f0b60937dd55f23d60d334fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355009 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#798121}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/477f9ae93304..66f621ae9064 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC juanmihd@google.com,cfroussios@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1041781,chromium:1075562,chromium:897470 Tbr: juanmihd@google.com,cfroussios@google.com Change-Id: I6c21831e8a183685b6ca6be0d1f11332c40a3f80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355519Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798120}
-
Omer Katz authored
HashTable with Member had a data race that required adding an atomic ctor for Member via ConstructTraits. It was not needed for WeakMember because weak HashTables were traced only on mutator thread. Now these tables can be traced concurrently so the same data race can occur for WeakMember as well. Bug: 986235 Change-Id: Ic54167be0dbcbb025b136ee023929125b1a33c55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352922 Commit-Queue: Omer Katz <omerkatz@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#798119}
-
Omer Katz authored
Now that UntracedMember don't use atomic writes anymore, it is no longer safe to concurrently trace collections holding UntracedMember. Since UntracedMember is not traceable, this can only affect in practice HashMap where the key is an UntracedMember (such HashMaps could have been concurrently traced so far and won't anymore). According to code search, no such HashMaps currently exist, so this CL should not affect performance. Bug: 986235 Change-Id: Id4eb925cb5bd2001a8d8e845c746e6da5fd76925 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353455 Commit-Queue: Omer Katz <omerkatz@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Auto-Submit: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#798118}
-
Antonio Gomes authored
This allows lacros/chrome to auto hide/show ChromeOS shelf when it enters in fullscreen mode. It is the so called 'immersive fullscreen' mode that chromeos/chrome has. MANUAL TEST: Enter lacros/chrome in fullscreen and hover the mouse pointer over the bottom border of the screen (shelf area). The shelf should slide-up. Note that this brings lacros/chrome fullscreen behavior closer to chromeos/chrome's. In a follow up CL, the omnibox widget that slides down from the upper border of Ash will be plumbed up to lacros/chrome. BUG=1113900 R=msisov@igalia.com, nickdiego@igalia.com Change-Id: I4b7c04d18b73747a0c70bffa5a6d6741df6c4346 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353116Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Commit-Queue: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#798117}
-
Yann Dago authored
This is a reland of 70cab0ca Original change's description: > Handle "--channel" switch in chrome setup to allow channel switching > > In order to support channel switching on the main installation of > the browser, A switch flag "--channel" that specifies which channel of > the browser is about to be installed is added to the setup's command > line. This flag will be used to store the right channel value in the > registry so the browser knows which channel is running. > The supported values are {stable|dev|beta}. This new switch will be > ignored for if any of "--chrome-beta", "--chrome-dev" and "--chrome-sxs" > is found in the command line. > > Bug: 1102927 > Change-Id: Ib7bd622e906f8f4af067307c90d0caffc73afc24 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2172210 > Commit-Queue: Yann Dago <ydago@chromium.org> > Reviewed-by: Greg Thompson <grt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#797688} Bug: 1102927 Change-Id: I345e2f7c74c439e001697a10465b17cf3392e2db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354538 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#798116}
-
Reilly Grant authored
This change fixes SerialIoHandler::Close() to ensure that the callback is always executed even if there isn't a file handle to close. Failing to do so will trigger a DCHECK in the Mojo bindings layer and could cause clients of the Mojo interface to stall waiting for a response. Bug: 884928 Change-Id: I272cc1987627232dc2143380071a07b7c58fb2cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354775 Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#798115}
-
Peter Boström authored
Punts removal for now. We'd still like to have this and even though it's on our backburner we'd like the feature to not be cleaned up. Bug: 933384, 110684 Change-Id: Iadfdd3cfaa60691ad0e01c1771eac545ee36676a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354917 Auto-Submit: Peter Boström <pbos@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#798114}
-
Anastasiia N authored
AccountManagerBrowserTest wasn't included in chrome/test/data/webui/BUILD.gn Change-Id: Id8f3a4e5f8aa4b1d5f2674842a3d25dc895c9783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352925Reviewed-by:
Kush Sinha <sinhak@chromium.org> Commit-Queue: Anastasiia N <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#798113}
-
Rakina Zata Amni authored
Since unload-in-commit is not supported yet, we're adding a way to skip bfcaching pages that have unload handlers on same-site navigations to avoid exposing a web-observable behavior change (unload handlers running after a same-site navigation). Note that we're only checking for unload handlers in frames that share the same SiteInstance as the main frame, because unload handlers that exist in cross-SiteInstance subframes will be dispatched after we committed the navigation, regardless of our decision to swap BrowsingInstances or not. Bug: 977562, 1110744 Change-Id: If7b3f1ad3f6f67e13c582f8df216ebd3ef66bc9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348245 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#798112}
-
Zach Trudo authored
Bug: chromium:1078512 Change-Id: I99668ac08697ebc1205d5c840413c2de642942ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353558Reviewed-by:
Leonid Baraz <lbaraz@chromium.org> Commit-Queue: Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#798111}
-
Eric Seckler authored
Failing on the bots, see bug. Change-Id: I01427f5933b4fe7633d264e830a93b328bd0ac5f No-Try: True TBR: wenbinzhang@google.com Bug: 1116469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356344Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#798110}
-
Aaron Leventhal authored
A kMenuButton is a menuitem inside of a group. The Mac mapping is special. Everything else just maps to the platform's menu item role. Without this change, non-Mac platforms announce a menuitem in a group as a menu, when it's actually a menuitem. In the future, the special Mac mapping may change, as it is likely problematic. More info at https://github.com/w3c/core-aam/issues/78 TBR=haraken@chromium.org Bug: 1114712 Change-Id: I3c065f474e235915e5b22569dad08a0e250077f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353431 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#798109}
-
Jonathan Ross authored
This histogram has expired, and since been replaced by the Memory.GPU.PeakMemoryAllocationSource histogram. So here we are removing it. Bug: 1072665 Change-Id: I1e59305597ce028d02af3bbd9593064df908a545 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354533Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#798108}
-
Numfor Mbiziwo-Tiapo authored
This change makes putAll return an array of the inserted keys on a successful insertion Change-Id: I6157019646e78d31f1d2277942afffaec43774d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352829 Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#798107}
-