GitLab

This reverts commit 84437412.

Reason for revert: Suspected cause of browser test failures on Linux CFI. Confirmed via local bisect on TouchSelectionForCrossProcessFramesTests/TouchSelectionControllerClientAuraSiteIsolationTest.BasicSelectionIsolatedIframe/0 which consistently times out after this CL.

Original change's description:
> Break apart RenderWidgetHost::GetVisualProperties()
> 
> RenderWidgetHost::GetVisualProperties() was doing 3 separate things
>   (1) Actually calculating the VisualProperties
>   (2) Checking against the last stored VisualProperties to determine
>       if the stored copy needs updating.
>   (3) Determining if an ack should be expected if an update is eventually
>       sent with the result of this function.
> 
> This CL breaks it out into 3 new functions:
> 
> GetVisualProperties() - Generates the VisualProperties. This should be
> const but too much of the call chain underneath it did not annotate
> their getters with const that annotating would be too annoying.
> 
> DidVisualPropertiesSizeChange() - Helper function that extracts a common
> query used by DoesVisualPropertiesNeedAck() and
> StoredVisualPropertiesNeedsUpdate().
> 
> DoesVisualPropertiesNeedAck() - Returns true if sending the given
> VisualProperties update to the renderer will generate an ack.
> 
> StoredVisualPropertiesNeedsUpdate() - Returns true if the stored copy
> of the VisualProperties is different enouhg from the incoming one that
> it needs an update.
> 
> Bug: 998273
> Change-Id: Ie8fee3ddedc1ea8b492765cb5b35e7bda99234de
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773878
> Commit-Queue: Albert J. Wong <ajwong@chromium.org>
> Reviewed-by: ccameron <ccameron@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#691879}

TBR=ajwong@chromium.org,ccameron@chromium.org,erikchen@chromium.org

Change-Id: Ia0af4e2dd74bb16841464c2d2c23ed177edf0744
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 998273
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778812Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692083}

This CL also fixes a minor bug the Cellular UI to show a disabled
'Connect' button if Cellular is not connectable (since it is never
configurable).

Bug: 853953
Change-Id: I218f34268b27a4a8fde10956a055d9235d329d77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769549
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692082}

https://chromium.googlesource.com/angle/angle.git/+log/120b61d34ba8..56ba54cc03f3

git log 120b61d34ba8..56ba54cc03f3 --date=short --no-merges --format='%ad %ae %s'
2019-08-30 timvp@google.com Support separate read and draw surfaces in eglMakeCurrent

Created with:
  gclient setdep -r src/third_party/angle@56ba54cc03f3

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC cwallez@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=cwallez@chromium.org

Bug: None
Change-Id: I2822bd641778b0633975d048bda9b8fc0c88cad1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778681Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#692081}

* No longer dismiss the IPH entrance when user enters the IPH dialog
  and sees the animation. Instead, only dismiss it when user explicitly
  closes the IPH entrance, or has performed drag-and-drop behavior (this
  is not reflected in this CL).
* Make the IPH animation repeat and restart from beginning every time
  the dialog is reopen.

Bug: 997707
Change-Id: If419316c9dc406927649260575b128c650ef2120
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777108Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692080}

The BackgroundTaskScheduler is used to schedule one-off or periodic
tasks for Chromium, by delegating the actual scheduling to the
corresponding system API. GcmNetworkManager is used in L and lower
Android versions, while JobScheduler is used in the other newer versions
of Android.

Since a new data type is added in order to support scheduling of
tasks at exact times, a new API will be used to schedule this type
of tasks: AlarmManager. The reason for using this API is that it offers
more guarantees regarding the scheduling of the tasks: even if the
device is in idle mode (added in the newer versions of Android), the
task will still be scheduled at the wanted time, with a maximum delay
of 9 minutes.

This CL adds a new BackgroundTaskSchedulerDelegate implementation,
responsible for the delegation of tasks to AlarmManager. The necessary
updates in the existing classes and new tests are added with this
change.

Bug: 970160
Change-Id: I87d090c64854dab209a444a7cae65c2dcb6c2430
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755989
Commit-Queue: Ioana Stefan <ioanastefan@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Richard Knoll <knollr@chromium.org>
Reviewed-by: Mugdha Lakhani <nator@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692079}

This patch converts the grid tab switcher and groups from the
existing MVC RecyclerView infra to the SimpleRecyclerViewAdapter.
The most notable change is the removal of the view holders for
lookup by ID.

Bug: 982075
Change-Id: I0b6afe496343e430a72a80c2f940979834207f9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687926
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692078}

https://skia.googlesource.com/skia.git/+log/b30ba90aec5b..6d50818641b7

git log b30ba90aec5b..6d50818641b7 --date=short --no-merges --format='%ad %ae %s'
2019-08-30 rmistry@google.com Match CanvasStateHelpers.cpp change in Android repo

Created with:
  gclient setdep -r src/third_party/skia@6d50818641b7

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC stani@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=stani@google.com

Bug: None
Change-Id: Idbd333068c08ac02f32243e161217b476d8a3b2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778581Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#692077}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4c470eee0063..6ef4e2562a78


Created with:
  gclient setdep -r src-internal@6ef4e2562a78

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None,chromium:None,chromium:None
Change-Id: Id0d0a111a544512e7e8b90e1461f56927b0fe1bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778203Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#692076}

Previously wheel scrolling was being treated similar to touchpad.
This lead to behavior where it was very hard to escape snap points
since at the end of every wheel tick which scrolls a small amount
Blink would snap back. The only escape was to wheel continuously
to get closer to the next snap point.

This is not ideal. It is much more natural for wheel ticks which
are discrete to be treated as "direction scroll" for snapping
purpose. So single wheel tick would take user to the next snap points.

See [1] for a before/after video.

[1] https://bugs.chromium.org/p/chromium/issues/detail?id=963609#c5


Bug: 963609
Change-Id: I72d1f23ab25e3d1ce29afa47d2d591497e8f1c6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758498
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692075}

This CL adds a test checking that the suggestions displayed on the NTP
are updated when the page is reloaded.

Bug: 998537
Change-Id: I4add2ee70bf8abcfbba0122f3e67b0049818fe05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777801Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692074}

This reverts commit f98214f3.

Reason for revert: CP for unblocking chromium merge sheriff

Original change's description:
> [Chromecast] Fix thread safety issues in CastAudioJson.
>
> Bug: internal 135280530
> Change-Id: I611e61735b4537e5db330cb6c78fe05fcb193170
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706786
> Commit-Queue: Jenny Wong <jyw@chromium.org>
> Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#684198}

TBR=jyw@chromium.org,kmackay@chromium.org,mont@chromium.org

Bug: internal 135280530
Bug: b/140290037
Change-Id: I000c7e6b3e38d7a23781ed6b5480615cdd1d9a49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761698Reviewed-by: Michael Spang <spang@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692073}

Skip-to-GPay is an experimental flow that skips the payment sheet for
{basic-card, GPay} hybrid requests. Today requests for shipping and
contact information is fulfilled using autofill data, this requires the
payment sheet to be shown to the user to confirm the information. Since
the Payment Handler API does not yet support a general mechanism for
delegating shipping and contact information to payment handlers, this
patch is part of a bridge solution customized for GPay.

With this patch, the renderer process will detect {basic-card, GPay}
hybrid requests that are eligible for the skip-to-GPay flow. Then it
creates a copy of the merchant-provided GPay-specific-data, and sets
additional parameters to request shipping and contact information from
GPay based on the merchant-provided PaymentOptions. The copy is passed
to the browser process to make a final decision (based on a Feature flag)
whether to invoke the skip-to-GPay flow.

The browser process changes will be landed in a separate patch.

Design Doc: https://docs.google.com/document/d/1rCA4tk1xS3nwiRqmAk1eCAh64K55wHOE1JWYNTqm9LQ/edit#

Bug: 877284
Change-Id: I7822fe0157fa6ee77e48035a2c1c0fae41168c8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769853
Commit-Queue: Danyao Wang <danyao@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692072}

Remove deprecated media engagement fields from the
chrome://media-engagement WebUI.

BUG=998892

Change-Id: I5dadab504404602c22c5773411816eb4c7518b71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776398
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692071}

Bug: 995405
Change-Id: I3a82aed914760f2bc7076ae7710daac23e3f1bfd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776484Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692070}

Replace the subpage arrow with an external link icon for the "Report an
issue" row in chrome://settings/help and chrome://os-settings/help

Bug: 999331
Change-Id: Iaf14bc19781df1d5129e89a2c27a9bf96d29d6b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777140
Auto-Submit: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692069}

Bug: 999102, 860467
Change-Id: Ie56145c9e838f3942ac0ce04b4bb4e996e162b6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778050
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692068}

This adds implementation that displays a message to the user when
a problem occurs in the security token PIN dialog during SAML user
sign-in (a.k.a. smart card login).

The problem message consists of an icon, the error's text and the
number of left attempts.

Bug: 964069
Change-Id: Ia4014ebbbac49e59db2864ea8fe50a6b94034bde
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753002Reviewed-by: Denis Kuznetsov <antrim@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692067}

Maybe this will fix the error on O phone since I have no debug info in
those logs...

Bug: 999349
Change-Id: Ie7fc3927b2c27acf0204e9fa339e1ac7e805575c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777122Reviewed-by: Michael Crouse <mcrouse@chromium.org>
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692066}

This partially reverts commit 5fce07b7.
It might have caused flaky failures in BrowserCloseManagerBrowserTest.

Also re-enable the tests.

TBR=avi@chromium.org

Bug: 997649
Change-Id: I2c0766a0a51affc01f76c14c64e9f7ca27d8c0de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776606Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692065}

On mac the browser process gets vsync parameters and sends them over IPC
to the display compositor. We don't need to provide a callback so the
GPU can also provide vsync parameter updates. At best the GPU never uses
the callback, at worst the GPU uses the callback when it shouldn't.

Bug: none
Change-Id: Idf0a3833d620bee6393080b059fbde2bf4592510
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700462Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692064}

Bug: 999535
Change-Id: I309d06116d5432867d4dedee0606e15c5164c4b6
Tbr: tkent@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778402Reviewed-by: sebsg <sebsg@chromium.org>
Commit-Queue: sebsg <sebsg@chromium.org>
Auto-Submit: sebsg <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692063}

'printers-added' event adds destinations without capabilities.
Capabilities and policies are pulled by getPrinterCapabilities() native
call but only capabilities are applied.
This happens most often in managed guest session where there isn't last
selected printer most of the time (for which it works a bit
differently).

Bug: 998103
Change-Id: Ibcb0965a01ff06bbd503edcc57a54b142df04903
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772163Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692062}

https://webrtc.googlesource.com/src.git/+log/25eb47ccf18f..8b14b0dea605

git log 25eb47ccf18f..8b14b0dea605 --date=short --no-merges --format='%ad %ae %s'
2019-08-30 hbos@webrtc.org Revert "Refactor SCTP data channels to use DataChannelTransportInterface."
2019-08-30 sakal@webrtc.org Interface for monitoring ref counts of texture buffers created by SurfaceTextureHelper.
2019-08-30 nisse@webrtc.org Delete unused logic for audio RtcpMode::kOff
2019-08-30 ilnik@webrtc.org Revert "Add core multi-channel pipeline in AEC3"
2019-08-30 ilnik@webrtc.org Use HasOneRef to ensure safe reallocation of buffer in EncodedImage
2019-08-30 nisse@webrtc.org Delete audio methods SignalNetworkState
2019-08-30 kkinnunen@nvidia.com Fix test_support_unittests with enable_iterator_debugging=true
2019-08-30 terelius@webrtc.org Add support for unsigned parameters in FieldTrialParser
2019-08-30 peah@webrtc.org Add core multi-channel pipeline in AEC3
2019-08-30 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 71facea1..ea980c90 (691823:691937)
2019-08-29 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 3a1d849d..71facea1 (691713:691823)
2019-08-29 peah@webrtc.org Increase the maximum supported sample rate to 384000 Hz and add tests
2019-08-29 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 52323b9f..3a1d849d (691589:691713)
2019-08-29 mellem@webrtc.org Refactor SCTP data channels to use DataChannelTransportInterface.
2019-08-29 tommi@webrtc.org Remove lock for process thread pointer from PacedSender.

Created with:
  gclient setdep -r src/third_party/webrtc@8b14b0dea605

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: chromium:b/139745386,chromium:None,chromium:none,chromium:None,chromium:None,chromium:None,chromium:None,chromium:none
Change-Id: I2caca99d25229750bf3e5c408c8b67ee9fb2677d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777970Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#692061}

To get L3 behaviour before, users would have to pass a special
command-line flag, --enable-blink-features=CustomUserTiming.

This changes makes L3 the default behaviour. The intent-to-ship for L3
can be found here:
https://groups.google.com/a/chromium.org/d/topic/blink-dev/CWN34Qo8icI/discussion

Users can opt-out of L3 by passing
--disable-blink-features=CustomUserTiming.

Bug: 758385
Change-Id: I316b2a929fc0748c3b9a9c1ef3d4c551ae00eafa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758715Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Commit-Queue: Tom McKee <tommckee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692060}

This reverts commit b9e16d2b.

Reason for revert: Speculative revert for

Unexpected Failures:
* http/tests/devtools/a11y-axe-core/elements/event-listeners-a11y-test.js
* http/tests/devtools/a11y-axe-core/security/security-origin-a11y-test.js
* http/tests/devtools/a11y-axe-core/sources/sources-editor-pane-a11y-test.js

See builds
https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak/3809
to
https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak/3842

Original change's description:
> devtools: Prepare for service worker UI thread core.
> 
> The thread ServiceWorkerContextCore lives on (the "core thread") will move from
> the IO thread to the UI thread when the ServiceWorkerOnUI feature is enabled.
> 
> This CL makes DevTools aware of the core thread instead of assuming the IO
> thread. This makes https/tests/devtools web_tests pass when the feature is
> enabled.
> 
> Bug: 824858
> Change-Id: I20e38f50998f4b0cd9d8b8cc43526665d92dbf94
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775655
> Commit-Queue: Matt Falkenhagen <falken@chromium.org>
> Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#691689}

TBR=falken@chromium.org,caseq@chromium.org

Change-Id: I2d49a0fe27f033a7b8bd74e3a50fd9d78a4f1f58
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 824858
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778403Reviewed-by: sebsg <sebsg@chromium.org>
Commit-Queue: sebsg <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692059}

Before, Views menus closed when the main menu was opened; make it
so that they close when any menu opens.

BUG=985675
TEST=as in bug

Change-Id: I269a1e699def76abc79c4e496ec734936ae18f59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775735
Auto-Submit: Avi Drissman <avi@chromium.org>
Reviewed-by: Leonard Grey <lgrey@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692058}

This CL adds a new app permission view settings subpage to display
the different permission views.

Bug: 919531
Change-Id: I85896670dd3ca9d8e9514d337265cbf73b26e181
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772873
Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692057}

Using wpt-import in Chromium 39eca077.
With Chromium commits locally applied on WPT:
5546163a "Temporarily send `Sec-Fetch-*` headers via non-secure transport."
2d090a27 "[WPT/referrer-policy] Call getRequestURLs() for each subtest"
c906513f "[WPT/common/security-features] Rename source context names"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: I403312d49db5296a46fc1f30a25b9d76c2c03936
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778004Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#692056}

https://skia.googlesource.com/skia.git/+log/575699569e91..b30ba90aec5b

git log 575699569e91..b30ba90aec5b --date=short --no-merges --format='%ad %ae %s'
2019-08-30 rmistry@google.com Fix spreadsheets page set for RecreateSKPs bot

Created with:
  gclient setdep -r src/third_party/skia@b30ba90aec5b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC stani@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=stani@google.com

Bug: None
Change-Id: I645a120ac25f4df5a70f8e189ce2413626c55b40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778341Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#692055}

That way the experiment group 'Enable' will only apply to those who use the
feature.

Bug: 986298
Change-Id: I282b75c43ecfd941c032a6d3f275e46fb5d5e82d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777926
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Auto-Submit: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692054}

We have kFrameSequenceTrackerTypeNames defined in the
compositor_frame_reporter.cc and kBuiltinSequences defined in the
frame_sequence_tracker.cc, where these two essential represents the same
thing. This is problematic, that when we add an entry in one place, the
other place must be adding that entry too.

This CL defines kFrameSequenceTrackerTypeNames as static in the
CompositorFrameReporter class and then FrameSequenceTracker can just
use it.

No behavior change should be introduced.

Bug: None
Change-Id: I0dc9e40be82d147615e1aa61afb1a7d8750390e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774831
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692053}

When the device is disabled, we receive from the server
RESTORE_MODE_DISABLED mode. The client has no information if the policy
forces to re-enroll or not. In the initial implementation it was treated
as device not being forced to re-enroll. This change fixes that case, so
that the flags from VPD don't get deleted for disabled device.

Also with a test image, the install_attributes file is deleted while
the checksum remain on disk. This has yet to be investigated, but to
avoid any problems when install_attributes file is corrupted, we set
the device as being in DEVICE_MODE_ENTERPRISE if auto_enrollment
detects the device is disabled.

BUG=chromium:996059
TEST=Manual tests and unit tests

Change-Id: I8bc30028af043fdb563e6374d7e5db4b30830218
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771966Reviewed-by: Igor <igorcov@chromium.org>
Reviewed-by: Bartosz Fabianowski <bartfab@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Igor <igorcov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692052}

Largest file is 11MB in xcode_binaries cipd package, so I think copying
these files fine.

symlinks point to cipd cache do not work correctly on swarming. This
fixes that by using copy.

Bug: 988079
Change-Id: I00861c59d637d5931fbf6aa0f7b169b1e80ebe7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777846
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692051}

Follow-up to crrev.com/c/1685382; naming adjustment on cookie controls.

Bug: 967668
Change-Id: I34b65d59764d489e390d6dffbe5042a07b20a4f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777867
Commit-Queue: Huanzhong Huang <huanzhong@chromium.org>
Commit-Queue: Florian Uunk <feuunk@chromium.org>
Reviewed-by: Florian Uunk <feuunk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692050}

This is a reland of 6caf7e08. The
original patch had a nullptr crash when the Settings was null - this
version fixes that.

Original change's description:
> Hook up animations to ValidationMessageOverlayDelegate
>
> ValidationMessageOverlayDelegate hosts an internal blink::Page
> which is not properly integrated into the normal BeginMainFrame
> flow. As such, it needs to be manually prodded in various places.
> Integration already existed for layout and paint - this CL adds
> animations as well.
>
> This previously worked because blink::AnimationClock would advance
> its own time (against the spec), and so the internal Page would see
> advancing time and the animation would keep ticking. When we fixed
> blink::AnimationClock to be by the spec, we also broke this.
>
> This CL also makes sure that the animation used by
> ValidationMessageOverlayDelegate is not composited; the internal Page
> has no compositor so composited animations will not work.
>
> Bug: 990680
> Change-Id: I16aaddbfa57eaefadfb557fc9cb435d94672e637
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763162
> Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
> Reviewed-by: Robert Flack <flackr@chromium.org>
> Reviewed-by: Philip Rogers <pdr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#691673}

Bug: 990680, 999333
Change-Id: I16c9138b63eefe0b32e66ebc562ffa836181b07c

TBR=flackr@chromium.org,pdr@chromium.org

Change-Id: I16c9138b63eefe0b32e66ebc562ffa836181b07c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777109Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692049}

Bug: 998546
Change-Id: Ibad528d47add2430955af8142aa1372fee5d0648
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774792Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692048}

Implement Ansible playbook generation for APT package management
in the Crostini container. The code is not wired up with preferences
or policies at this point and accepts strings of JSON input.

This code will be used in a handler for an experimental enterprise
policy on Chrome OS.

Bug: 993321
Change-Id: Ifb07f787a1daf6b2829a8cce73e30b990e25116e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751253
Commit-Queue: Ilya Bizyaev <ilyabiz@google.com>
Reviewed-by: Olya Kalitova <okalitova@chromium.org>
Reviewed-by: Timothy Loh <timloh@chromium.org>
Reviewed-by: Nic Hollingum <hollingum@google.com>
Cr-Commit-Position: refs/heads/master@{#692047}

This CL replaces |client_binding_| with |client_receiver_|
from WebSocketHandleImpl to use new Mojo types.

Bug: 955171, 978694
Change-Id: I3a60e4c4a60b8edb769f006d92f2339ffe32101b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777341Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692046}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f24c9f2dff49..4c470eee0063


Created with:
  gclient setdep -r src-internal@4c470eee0063

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: If10fc6e3e49fbea8a52320309034dfea0a1ec010
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778263Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#692045}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/321c5840..66a74a65

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I663a4067e4b7cb5daf39459dfca0ca221e837cd0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778002Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#692044}