- 29 Jul, 2019 40 commits
-
-
Carlos Caballero authored
MessageLoopForUI will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you believe your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=sczs@chromium.org Change-Id: Icff05dbcd5ffbea9419cd257203d739e5eb226f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718026 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#681897}
-
Maksim Ivanov authored
1. Wire up the Chrome OS Lock Screen UI code with the challenge-response authentication (a.k.a. smart card login) bits from the browser process. 2. Add a UI control into the Lock Screen for starting the challenge-response authentication. (The UI control is temporarily an unstyled button, but will be replaced with the real UI in follow-ups.) Bug: 964069 Test: enroll a Chromebook, configure device policies to force-install smart card middleware onto Login Screen, log in using a SAML account that uses smart card authentication, lock the Chromebook, check that "Unlock with smart card" appears, click it, check that the user session gets unlocked Change-Id: Icf0ccc80b6778d318c115f79072fdd6595a034b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720640Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#681896}
-
Caroline Rising authored
Make MenuRunner use the MenuModelAdapter. Bug: 943702 Change-Id: Ia05b47e207b4d1d1cc73b046a7fee54432ae84b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724577Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#681895}
-
Kevin Babbitt authored
With UI Automation enabled, the top-level node for the Chrome window would show most properties as empty. This was happening because our fragment root was mapping values from an empty AXNodeData. UI Automation has a built-in provider for HWNDs. In our implementation, fragment roots do not contain any useful accessibility information beyond what the built-in provider would expose, so we simply return VT_EMPTY for most properties, so that we don't override values returned by the built-in provider. The exceptions are IsControlElement and IsContentElement. We implement these properties to exclude the legacy HWND from the control and content views, because we don't want screen readers to stop on the legacy HWND and announce "Chrome Legacy Window." Other HWNDs are allowed in the control and content views so that, for example, an assistive technology can manipulate the window using WindowPattern. R=iapres@microsoft.com Bug: 928811 Change-Id: If606f399c386109adc3bd56bf081b2e5c2362070 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716010Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ian Prest <iapres@microsoft.com> Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#681894}
-
Mei Liang authored
https://crrev.com/c/1680953 sets root id of a tab when that tab is being added to the filter. However, when resetFilterState() is called after setRootId(), the root id of that tab can be overridden if its parent tab is still around. This CL fixes the issue above and adds unit tests. Change-Id: If8332053a4255f01a4f618f1b0367f9fd6729a8f Bug: 987153 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717558 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#681893}
-
Rayan Kanso authored
According to the spec, the contact picker can only be brought up once per browsing context until the operation is complete. Subsequent navigator.contacts.select calls should throw an InvalidState DOMException. https://wicg.github.io/contact-api/spec/#dom-contactsmanager-select Bug: 985702 Change-Id: I838534bd84877079eec7740c773d18567acac3a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724514 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#681892}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/96ea8c00e70c..425d6aaa4ce2 git log 96ea8c00e70c..425d6aaa4ce2 --date=short --no-merges --format='%ad %ae %s' 2019-07-29 sprang@webrtc.org Add RtpPacketPacer interface for pacer control Created with: gclient setdep -r src/third_party/webrtc@425d6aaa4ce2 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I9257b712cea988838e9a2335793e729ccfc2de6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723576Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#681891}
-
Gabriel Charette authored
Blocks https://chromium-review.googlesource.com/c/chromium/src/+/1689339/21 R=altimin@chromium.org Bug: 984057 Change-Id: I48f93eced8391c2b8f85bd4b27ccd3891f6b429d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724689 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#681890}
-
Stephen Nusko authored
This prevents the producer from being set when a new trace gets started. Also add a TODO to refactor the data source so this can't be forgotten. Bug: 987887 Change-Id: I1a6d5efad9d635a4325c19dcce1a5cae9925bf0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722938 Commit-Queue: Stephen Nusko <nuskos@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#681889}
-
Vaclav Brozek authored
CSVPassword represents a credential stored in one CSV line. For parsing the CSV line, CSVPassword needs to understand the meaning of columns, which it does through a ColumnMap -- a map from column indices to column types. Currently, CSVPassword stores its own copy of the map. This map is the same for all lines in a single CSV blob. Sharing this single map among all CSVPassword instances avoids many copies of the map. Therefore this CL changes CSVPassword to keep a reference to the map. Bug: 934326 Change-Id: Id52e3db26fa1fd804f987103bf62e295102f2ce8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698401 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Auto-Submit: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#681888}
-
David Bokan authored
These tests were DCHECKing because the TouchlessActivity generates cursor changes on state changes like becoming hidden. This causes us to notify the renderer about the change. However, the fallback cursor mode enabled flag is set from AppHooks which don't get initialized in browser tests. This means the renderer is receiving these notifications with the flag turned off. This CL filters the notifications at the browser level. Ideally we would avoid sending them in the first place but querying the state of the feature flag is difficult because the sending code lives in ui/ while Java FeatureList code is implemented only in chrome/browser/. Bug: 987353 Change-Id: Ida01168493200ee47f598a567f1d1afdcaf0a262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721229 Commit-Queue: David Bokan <bokan@chromium.org> Auto-Submit: David Bokan <bokan@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#681887}
-
David Black authored
Setting user agent via InternalOptions is deprecated in LibAssistant 1.42s. Prior to upreving LibAssistant we need to set user agent via internal config. A follow up CL will remove the code which sets user agent via InternalOptions and we will uprev that change in tandem with upreving the 1.42s changes to avoid breaking the public build. Bug: b:138583234 Change-Id: I110a7f16ea53f38eaeac7f7065e628f7eec1ffc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724829Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#681886}
-
Jacob DeWitt authored
This hasn't been an issue since Gamepads on the navigator array should always have index >= 0. However, WebXR Gamepads that are not on the navigator array must have an index of -1. Bug: 950202 Change-Id: Ia3abd606ae491cbdc738fc7a0c8fbde9eaf57e43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721057Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Jacob DeWitt <jacde@chromium.org> Cr-Commit-Position: refs/heads/master@{#681885}
-
Dominic Battre authored
If many independent strings are appended to the LogBuffer, this used to emit a separate text node for each string to the DOM. With this CL, the strings are coalesced in the browser process, which results in less data being sent to the WebUI and less text nodes being kept in memory. Bug: 928595 Change-Id: I09e9673a06f0cae426f7e0b25ad27b98c0f43272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722791 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
-
Christopher Grant authored
This change flips on the switch for putting the VR UI's native code in the feature DFM. In doing so, it enables a partitioned Chrome library for Android, which changes how libchrome.so (and libmonochrome.so) are generated. The link stage now generates libchrome__combined.so, a special library that uses lld linker capabilities to put feature code into separate sections. The main and feature libraries are then extracted in a follow-on step, producing discrete libchrome.so and feature libs. As a result, this change has the potential to break scripts that (for example) induce re-linking of libraries by deleting libchrome.so. Bug: 874564 Change-Id: I708e990b3aa6b1abe71b28a67add51662c268276 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663486Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#681883}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/96827b125f3a..b05ca08cfab8 git log 96827b125f3a..b05ca08cfab8 --date=short --no-merges --format='%ad %ae %s' 2019-07-29 senorblanco@chromium.org Update Dawn backend to ToT Skia. 2019-07-29 benjaminwagner@google.com Omit test that sometimes causes Chromebook to die 2019-07-29 egdaniel@google.com Fix valgrind crash in TransferFrom test. Created with: gclient setdep -r src/third_party/skia@b05ca08cfab8 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@google.com Bug: None Change-Id: I6b87b9694ea7ca9bd41c183c49e4fe8d2e13178c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724572Reviewed-by:
-
Guido Urdaneta authored
This CL: 1. Moves content::MediaStreamDeviceObserver to blink/renderer/modules/mediastream, including the header. This type implements a Mojo interface, so its header cannot be on blink/public. 2. To allow existing content clients to interact with MediaStreamDeviceObserver, a thin wrapper called WebMediaStreamDeviceObserver was added to blink/public (header) and blink/renderer (implementation). 3. Blink-specific bindings for MediaStream typemaps are now generated. 4. The MediaStream typemap is updated to account for dependent media types. 5. MediaStreamDeviceObserver is updated to register with the frame's mojo interface registry instead of using its own registry. This allowed breaking the dependency on RenderFrameObserver, which was used to detect requests for interfaces made to the frame. Bug: 704136 Change-Id: Iaa191c0e990910dd2fcb512d4655abc91d56a2e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718379Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#681881}
-
Dominic Battre authored
This CL makes the logging of table rows easier to comprehend and shaves off a few characters of each line logging table rows. Bug: 928595 Change-Id: I35db6d7ddd06d184a6c14fc28847888ee3390b58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722951 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: If18912933ab3e45af55ab052654c5a3d6389e298 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700911Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#681879}
-
Becca Hughes authored
Add a color type to MediaImageBitmap. The default color type (N32) is platform specific and is an alias for either RGBA_8888 or BGRA_8888. When deserializing we will convert all images to the platform default. The color type tells us the original color type of the image which may be different if it came from ARC or Chrome. ARC only supports RGBA_8888 and images from ARC will fallback to RGBA_8888 which is the default value. BUG=987814 Change-Id: I9fed118c85e29a24c232bc3adc52cdf64988bd3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717168 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#681878}
-
Chase Phillips authored
As part of this change, also remove IDBCallbacks.SuccessValue and IDBCallbacks.SuccessCursor which are no longer used. Bug: 717812 Change-Id: I5bb3b5d77ba7248b2286dc579d8d25805b72cd5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626660 Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
-
kylechar authored
Both helper functions just wait for hit test data now so rename them appropriately. Bug: 810128 Change-Id: Ia04933ee35a526a11766a5c1fbd9f75b43985bdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721239Reviewed-by:
Paul Meyer <paulmeyer@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#681876}
-
Stepan Khapugin authored
Disable Site Info on the NTP to avoid user's confusion. Bug: 977056 Change-Id: Ia47495580d8ec7a3eee3347e22f91d7c63647026 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719009 Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#681875}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/8d269bac7c4a..b51a6f0c4638 git log 8d269bac7c4a..b51a6f0c4638 --date=short --no-merges --format='%ad %ae %s' 2019-07-29 bclayton@google.com Revert "Temporarily disable warnings-as-errors" 2019-07-29 bclayton@google.com Merge changes I10d66439,I6bd62e7b,Iec85e0df,If16c5d11,If803398e, ... 2019-07-29 bclayton@google.com LLVMReactor: Build fixes for REACTOR_EMIT_DEBUG_INFO Created with: gclient setdep -r src/third_party/swiftshader@b51a6f0c4638 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: None Change-Id: I50bb0719e5bab6d777966140d28669868ac2faa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724574Reviewed-by:
-
Natalie Chouinard authored
This reverts commit 5a08e77e. Reason for revert: Suspected cause of Android build failures with: Class "org/chromium/net/impl/JavaUrlRequestUtils$CheckedRunnable" not found on any classpath. Used by class "org/chromium/net/impl/JavaUrlRequest$10" Original change's description: > Move Java classes needed by all Java Cronet implementations to utils. > > To minimize code duplication, code that can be shared between the > JavaUrlRequest and the FakeUrlRequest should be moved to a new shared > file: JavaUrlRequestUtils. > > Context:https://chromium-review.googlesource.com/c/chromium/src/+/1703325 > > Bug: 669707 > Change-Id: Id0dda127694090504f26b083bf4c561ee902cef4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721771 > Reviewed-by: Paul Jensen <pauljensen@chromium.org> > Commit-Queue: Benjamin Kirchman <kirchman@google.com> > Cr-Commit-Position: refs/heads/master@{#681835} TBR=pauljensen@chromium.org,caraitto@chromium.org,kirchman@google.com Change-Id: Iee84334296aa6508ee2696a9f97385a00e12924e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 669707 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724576Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#681873}
-
Vladimir Levin authored
This patch adds more early outs that were missed during paint. That is we still paint the self element, but also need to skip child paint, particularly inline only children which was not done previously. R=chrishtr@chromium.org Change-Id: Ib2442ab361447940c1c0e1b4c54b1ee8273d9563 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720795 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#681872}
-
Gabriel Charette authored
In a recent refactoring we opted to switch to microseconds because that's TimeDelta's finest resolution but results are now 0 or 1 us always and it makes the dashboard useless. I think it's okay to yield results in nanoseconds because it's an effective average of 0-1 us samples. The common perf test solution to this is to measure a batch of, e.g., 1000 calls but this is tricky with WaitableEvent because we want to measure Signal/Wait() from multiple threads but not the dead time in between. R=kylechar@chromium.org, skyostil@chromium.org Bug: 905412 Change-Id: I30daf41535d36ff59b19a64523f0a558c3fa1b2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724699 Commit-Queue: Gabriel Charette <gab@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#681871}
-
Xiyuan Xia authored
This reverts commit 2b2428c1. Reason for revert: Having issues with google chrome branched build. - Missing google chrome icon files; - TranslateBubbleView::CreateViewAdvancedTabUi needs to refer to correct icon resource; Original change's description: > Google Translate branding on desktop translate bubble > > This CL adds the new UI to incorporate Google Translate branding > into the new Button_GM2 and Tab translate bubble UI. Bug 987962 is filed > to track this new feature request. > > Bug: 963148, 987962 > Change-Id: Ia648f322cea5dae55bd9e21a537775bf74c772a7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708843 > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Reviewed-by: anthonyvd <anthonyvd@chromium.org> > Commit-Queue: anthonyvd <anthonyvd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#681812} TBR=oshima@chromium.org,anthonyvd@chromium.org,frechette@chromium.org,hhw@google.com Change-Id: Ib830bc733233cbba4ddb42222e8ecc8eecea0e29 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 963148, 987962 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724575Reviewed-by:
-
Geoff Lang authored
ANGLE's libGLESv2.so and libEGL.so have started shipping on Linux but symbols were not available to help debug crashes. BUG=988444 Change-Id: I89edc315c05cfe0dad785e386c643e44b56af72d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724491Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#681869}
-
Brian Sheedy authored
Merges various parts of the GPU Gold documentation from gpu_pixel_testing_with_gold.md into the other parts of the GPU documentation. Also removes references to the legacy pixel tests and their triage process since the code for them has been removed. Bug: 985007 Change-Id: I19d5480de77f1066046ef8fe0f076264cff01ee7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721523 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#681868}
-
Nico Weber authored
Also fix the definition of CHROMIUM_BRANDING; putting a negated condition there doesn't work. Thanks to Yngve Petterson for pointing that out. No behavior change. Bug: 961769 Change-Id: I8c6ba4b6c11c8b488aa27a3cbfdd78f29079f6c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724692 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#681867}
-
Max Moroz authored
Bug: 539572 Change-Id: I4965b3acbcd92650575595942c955017f75f90fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717910 Commit-Queue: Max Moroz <mmoroz@chromium.org> Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#681866}
-
Vasilii Sukhanov authored
The dropdown should not open directly after construction. Bug: 987360 Change-Id: I15fe1a319cc00308c926e4d5adac7db1126bd822 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718328Reviewed-by:
-
Avi Drissman authored
This was broken by the new window level machinery CL. BUG=988214 TEST=as in bug Change-Id: Ifd6c132e160d6a2e29aa663ecaf87b2330322c61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723749Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#681864}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c5656169e42b..c0758331ea12 git log c5656169e42b..c0758331ea12 --date=short --no-merges --format='%ad %ae %s' 2019-07-29 ehmaldonado@chromium.org Revert "depot_tools: Make gclient_utils Python 3 compatible." Created with: gclient setdep -r src/third_party/depot_tools@c0758331ea12 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Bug: chromium:984182 Change-Id: Iea2a0dcf180612a093631c1a00c702c713959447 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723575Reviewed-by:
-
Richard Knoll authored
We need to notify the recycler view that our list content has changed when switching between search / non-search as the top item is the (hidden) select all button if we're in non-search mode. Bug: 985715,985711 Change-Id: Id1d8d18f8b71aea05f5ca1fb634ea54323ef6cfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724085Reviewed-by:
-
chrome://autofill-internalsDominic Battre authored
This CL adds logging information about autofill votes sent to the crowd sourcing server to chrome://autofill-internals. It adds a simplification of logging repeated fields to log_buffer.h. TBR=pkasting@chromium.org Bug: 928595 Change-Id: I84ca78022afa6372b77d9433351fa267694639b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722790Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#681861}
-
Bo Liu authored
Viz for webview architecture will only support calling ScheduleTask from viz thread at limited times (initialization, tear down, DrawAndSwap). In order to avoid violating this requirement, add a DCHECK for the existing ScheduleGpuTask to ensure it is only called during allowed times. Also add a ScheduleOrRetainTask method for the cases where existing code violates this requirement. In viz for webview, such tasks may be delayed indefinitely, until the next DrawAndSwap or tear down. There are only two cases, EnsureBackbuffer and ReleaseCachedResources, that violate the requirement. Convert them to ScheduleOrRetainGpuTask. Only enable the DCHECK for SkiaRenderer since that's the only case relevant for viz for webview. Bug: 805739 Change-Id: Ic9ba91d85958fbe8ff0d8e30d1bc9095fd8cf62c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713871Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#681860}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/7fc868349143..f04f1f93a70f git log 7fc868349143..f04f1f93a70f --date=short --no-merges --format='%ad %ae %s' 2019-07-29 johnkslang@users.noreply.github.com Merge pull request #1857 from Roy-AMD/automapping-opengl-location Created with: gclient setdep -r src/third_party/glslang/src@f04f1f93a70f The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com,geofflang@google.com Bug: None Change-Id: I55c5a8276edf59f0f2040d3fcbd540a583c7d075 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723841Reviewed-by:
-
Daniele Castagna authored
gl_tests can't currently be run on ChromeOS devices since is missing Ozone initialization. This patch fixes that. It can now be run on Chromebooks (with some failing tests). Change-Id: I713633ccfc4b830ad99baf3566a3502205cde172 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722972Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#681858}
-
