GitLab

Bug: 1034012
Change-Id: I9dd122eca2169955f2ccf006dc039158be232d14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965440
Commit-Queue: bttk <bttk@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Ender <ender@google.com>
Cr-Commit-Position: refs/heads/master@{#724788}

Remove org.chromium.chromecast.base.Function

Bug: 1034012
Change-Id: Ib9cc34f95f3b4d37ac5d00f3ba1229bda3656326
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966492
Commit-Queue: bttk <bttk@chromium.org>
Reviewed-by: Luke Halliwell (slow) <halliwell@chromium.org>
Reviewed-by: Ender <ender@google.com>
Cr-Commit-Position: refs/heads/master@{#724787}

Remove interface org.chromium.chrome.browser.feed.library.common.functional.Function

Bug: 1034012
Change-Id: I13a0f53753ca7cffe2dece46197e1fc663c4f009
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966422Reviewed-by: Dan H <harringtond@chromium.org>
Reviewed-by: Ender <ender@google.com>
Commit-Queue: bttk <bttk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724786}

This is a reland of 1d038c5d

Original change's description:
> Add eligibility check for Quick Answers.
>
> Bug: b/145774037
> Test: Manual
> Change-Id: I81b3d2b7d20cb600db09a1d60bad7ce8c64d9b7b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955028
> Commit-Queue: Li Lin <llin@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#724027}

Bug: b/145774037
Change-Id: If9ca0979459e3813c90c1939982bb6ddb404f440
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963496
Commit-Queue: Li Lin <llin@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724785}

When the DNS-interception-detector is disabled, Chrome no longer sends
detection packets. If the network were to change under this condition
after having learned the redirect domain, the latter would never
change. This CL clears the domain once it detects that the policy was
set to disable the feature.

Bug: 181671
Change-Id: Ie51489272dc3ee92d279e9c3623ba1682ab14330
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962132
Commit-Queue: Kevin Bailey <krb@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724784}

WMI can't be used in Chrome as it cause too many issues (hangs,
A/V injecting in the process...), this mean that the new
MemoryPressureMonitor can't work as is and there's no plan to improve
it anytime soon. Remove this code as it's not needed and causes some
crashes.

Fixed: 1032280, 956742, 939092
Change-Id: I70d41346caff8d61dffd3ffc57eb70bdd31043af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960077Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724783}

This CL adds notification about input from AwContents to RootFrameSink
to be used as part of invalidation heuristic for viz for webview.

Bug: 805739
Change-Id: Ia470bf1bad6984ef88c0646a5211cd9f0b0fd738
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967872Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724782}

This allows LocalSearchService to store per-profile content.

This cl also moves some functions into test_utils. They were previously in
local_search_service_impl_unittest.cc file, but are now needed by local_search_service_proxy_unittest.cc.

Bug: 1018613
Change-Id: Ib20dccf1cbfd4891a1961f619b712caabcc731c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953234
Commit-Queue: Jia Meng <jiameng@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724781}

This CL adds policy attribute to iframe element and implemented the
inherit logic of document policy. This CL also adds required document
policy to frame policy for replication to browser.

Bug: 993790
Change-Id: I2597bedb138dc2582be7c8ff33c0818db8c6b43b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946882
Commit-Queue: Charlie Hu <chenleihu@google.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724780}

java.util.function.Function is added in Android API level 24
Currently Chromium sets `min_sdk_version=19`

https://developer.android.com/reference/java/util/function/Function

Bug: 1034012
Change-Id: I0f8d822f4c79058de8c7faef5f4d19c48c7713bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965943
Commit-Queue: bttk <bttk@chromium.org>
Commit-Queue: Yaron Friedman <yfriedman@chromium.org>
Auto-Submit: bttk <bttk@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Ender <ender@google.com>
Cr-Commit-Position: refs/heads/master@{#724779}

It's caused by updating backdrop while window scale animation is still
in progress. This cL pauses the backdrop update during window scale
animation.

Bug: 1027269
Change-Id: I4fa357d8fbb3de35ad78ec1b5095b7c5b156d8a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967804Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724778}

Use OnceCallback where possible because the callback is only used once
and RepeatingCallback and BindRepeating otherwise.

TBR=agl@chromium.org, holte@chromium.org

Bug: 1007757, 1007722
Change-Id: Id37fd0d0705664f727c75fe6f2ff0cb1c5bb7964
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967604
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724777}

When IS_INTERNAL_CHROME_CLEANER_BUILD is enabled, the tests take a long
time since all scan locations are scanned. We know the created test UwS
are in the startup folder, so we should be able to skip scanning of
other locations.

I didn't put this in a IS_INTERNAL_CHROME_CLEANER_BUILD block to avoid
issues where someone changes where the test UwS is created, resulting
on the change passing on the Chromium bots then failing on internal
bots.

Change-Id: I74988a8635395579141f095dc4803399ce8902a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967219Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Commit-Queue: proberge <proberge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724776}

https://android.googlesource.com/platform/external/perfetto.git/+log/f94b736c58a6..64ee7cee386b

git log f94b736c58a6..64ee7cee386b --date=short --first-parent --format='%ad %ae %s'
2019-12-13 hjd@google.com Merge "Fix CI timeout on android-clang-arm-asan benchmark"
2019-12-13 hjd@google.com Merge "Ban stoX and NULL"

Created with:
  gclient setdep -r src/third_party/perfetto@64ee7cee386b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: If0fd7ae3cccbfac6cb83fe16747593eaa41708aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967802Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#724775}

The HighlightedGamesStore is now using the HighlightedGamesResponse data file
to identify the currently highlighted Web game.

Bug: 1018201
Change-Id: I65270363b6eb3cec9bced7b3bc84af0caaafee72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954151
Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724774}

Bug: 1006767
Change-Id: Ia6341b643545f00759142b787f7834afac991358
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1964830Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Auto-Submit: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724773}

BUG=1031673

Change-Id: I5286a06cb913568b50a5321ebeb92bf298566ea4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966430Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724772}

New revision: 3d1b8aed28506966cb1f084067b65d87eab683c3

Upstream review:
https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1967550

Change-Id: I844806074013f01562c053c29b4a25f6f1c7ee8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967195Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724771}

Context: currently, PaymentRequest API overzealously triggers the
Minimal UI when the WebPaymentExperimentalAPI flag is enabled.
It interferes with the development of the other experimental
features.

Old behavior: the Minimal UI feature is enabled when
the WebPaymentExperimentalAPI about-flag is enabled.

New behavior: enabling WebPaymentExperimentalAPI doesn't enable the
Minimal UI altogether. The Minimal UI has another
flag in about://flags called "Web Payment Minimal UI".

Change: move the Minimal UI feature out of the
WebPaymentExperimentalAPI flag into a separate flag.

Bug: 1000432
Change-Id: I7f77fd51ca22475123e68c652940dc8a282d748e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967564
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724770}

Gaia team already drop the support of this. See
https://g3doc.corp.google.com/gaia/g3doc/faq.md?cl=head#id-like-to-create-real-accounts-in-an-integration-test-how-do-i-do-this
Also I've tested this code doesn't work.

Change-Id: Ic65eb0ac646071f837ac43527eccb34c3a4732b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965924
Commit-Queue: Sven Zheng <svenzheng@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724769}

TBR=govind@chromium.org

Change-Id: Id276bec19e6b448e81557d0aa50b0291a1927653
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967216Reviewed-by: Ben Mason <benmason@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Commit-Queue: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724768}

Change-Id: I1e282b8849372391256d7b8c4cd876aecdbd1a8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965489
Commit-Queue: Renjie Tang <renjietang@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724767}

Using the noDialogs flags is fine for an unattended scenario, however it
there may be cases where we want to provide a notification on the
desktop that a user is connected but still allow the remote user to
connect w/o prompting or requiring periodic reapproval.

This CL splits up the 'noDialogs' flag into 2 flags which control
suppression of the user dialogs (to allow / reapprove the remote
connection) and the desktop notification that is displayed.

Change-Id: Ifd2eb4f9270fadb4ffc2267bd2b1dfbe0ec38ca4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962530Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724766}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1d76f03c247a..780d83a4fe7e


Created with:
  gclient setdep -r src-internal@780d83a4fe7e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: I6e369b9915f881cbc8c8963b5fb42cf4772ba6e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967701Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#724765}

These tests need the webview provider set correctly.

Bug: 1033855
Change-Id: I7853aa583f8b128eb8a87c5c7a386abeab6b1735
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967796
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Auto-Submit: Clark DuVall <cduvall@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724764}

Currently, when the user tabs to a Learn More link (at the end of a
sentence usually), ChromeVox only verbalizes "Learn More".

The entire sentence that the "Learn More" refers to should be
read out in addition to the "Learn More".

There are two means of how "Learn More"s are presented with preceding
sentences:
1) When the Learn More is already embedded in the settings_strings.grdp
2) When the Learn More is concatenated with preceding sentence in JS

This CL demonstrates the handling of case 1).  Case 2) will be
converted to 1) in a later CL, as there are localization issues
of concatenating "Learn More"s with preceding sentences in JS.

A generalized polymer element that accepts a localized string that
contains a link will be created.  The linked contents will be aria
described by the entire localized string rather than only the
text within the anchor tag itself.  The other parts of the localized
string will be aria-hidden.

If agreed upon, the handling of case 1) will be applied to all
similar strings with "Learn more" embedded in settings_strings.grdp,
and later extended to all cases (once cases of (2) are converted
to (1)).

Bug: 1015924d
Change-Id: I222a20b79006dcceedcf3893d5e4f0f77765fc18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941198
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724763}

This CL changes DCHECK back to NOTIMPLEMENTED() in
OnBeginFrameSourcePausedChanged in DisplayScheduler. The code was
never implemented, but it's being called on WebXR and causes test
crashes.

Bug: 1033847
Change-Id: I7357ea2437472999888a9f62b250debb18cbcad8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967607Reviewed-by: weiliangc <weiliangc@chromium.org>
Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724762}

Merge the OverlayCandidateValidatorAndroid class's functionalities into
an OverlayProcessorAndroid, which is a subclass of
OverlayProcessorUsingStrategy.

This is for Android pre-SurfaceControl code path.

This is CL 9/? of overlay processor refactor.

R=rjkroege

Bug: 963597
Change-Id: I0ee7c169489ade404b130de2ecb7f3c6891aacb4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958617
Commit-Queue: weiliangc <weiliangc@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724761}

This package seems to encounter cipd edge cases fairly often, and when
it does it invariably requires trooper intervention to repair the bots.
Save some human-time by validating and trying to repair the package
automatically first :)

Bug: 1033987
Change-Id: Iacc043320b8ea02ca0a93c9a58ea4c96e1fcd174
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967420Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724760}

Using wpt-import in Chromium 24037b7c.

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools

NOAUTOREVERT=true
TBR=smcgruer

No-Export: true
Change-Id: Ib49e423b38335e9ac5c107840ba424fcea071b28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967831Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#724759}

Increase the size of the dialog to 70% of the window width and a
proportional height, if the browser window is much larger than 1000x660.

Bug: 1033412
Change-Id: I9cf6bab3a5b38d57dba9f49d3f82aba850d61b60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967805
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724758}

These will be used in infobar tests for overlay integration, where the
tests use the |infobarType| and |hasBadge| properties of the UI
delegate, but don't require a fully functioning InfobarCoordinator.

Bug: 1030357
Change-Id: I918cbb6c04686cef7dddd89b86e03bf86b12f045
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963032
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724757}

We don't need to dump all the fields if type is kEmpty.

BUG=1026447
TEST=viz_unittests
R=sunnyps@chromium.org

Change-Id: I14b306e4db88272e67102485514ba61031168750
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966396
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724756}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: I0004831d6898482d7d1a7f2e38bea479b17e518d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967774Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#724755}

Use OnceCallback where possible because the callback is only used once
and RepeatingCallback and BindRepeating otherwise.

TBR=sky@chromium.org

Bug: 1007670
Change-Id: Ifaa4c742298e45dd0581a77ecb6566ff4bb914a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967697Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724754}

Use OnceCallback where possible because the callback is only used once
and RepeatingCallback and BindRepeating otherwise.

TBR=sky@chromium.org

Bug: 1007848, 1007847
Change-Id: I9b82f87ba1ba7c5f79f16b8215d12a11e4bd6a81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967559Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Auto-Submit: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724753}

Resets the app list contents view when the app list view visibility
changes to false - the goal is to ensure that the app list is in
the initial state when it becomes visible again. This is in
particular needed in tablet mode, where AppListPresenterImpl::Show might
not get called when app list becomes visible (so app list contents is
not reset that way).

ResetForShow was also being called when app list was getting focused
while in hidden state, but that might not catch all the transitions
where app list becomes visible (and with this change becomes unnecessary).

Additionally, change when the selected apps page is reset for app list
visibility change - instead of doing it on focus change, the selected
page is now down when the visibility change is starting (i.e. in
OnVisibilityWillChange). This will make page reset happen sooner (before
the app list UI is actually shown), and cover more visibility change
cases in tablet mode.

BUG=None

Change-Id: I6240d7401091a8d778f5a3f8774db919a4cfd6bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966374Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724752}

This removes the need for custom pause/unpause logic for
ScriptedAnimationController in Document.

Also, construct ScriptedAnimationController in the Document
constructor, rather than lazily. It will get initialized on the
first frame, so we're not saving much by deferring its initialization.
This simplifies a bunch of logic around its handling in Document, and
guarantees that its lifetime will be predictable for leak detection.

Bug: 1029822
Change-Id: I4cec7985258dd24154032b4cd1812b75cc858757
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953643
Commit-Queue: Nate Chapin <japhet@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724751}

This cl manually reverts the v8 roll out to v8.1.32 which happened
here: https://chromium.googlesource.com/chromium/src/+/e5cb6daa9a0748126627f010e373706113a36120

Reson for revert:
V8 roll out to v8.1.32 seems to have caused a lot of test failures on
debug builds in this range:
https://chromium.googlesource.com/chromium/src/+log/ad7921a033b89eae85da556c2917f6df1328f41e%5E..55d0dad728ea958b6e18ef069cb805b7d1dd0056


TBR=hablich@chromium.org
NOTRY=true

Change-Id: Ic5006fd9005a7c5fcb35bfd3b2c1f7af12ae3f34
Bug: 1034059
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967891Reviewed-by: Sahel Sharify <sahel@chromium.org>
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724750}

Prevent new calls to be added directly to SharedPreferences without
passing through SharedPreferencesManager.

Bug: 1022108
Change-Id: I1cda2df2fc47fed1182ccbfebd673d6bf8c82901
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965935
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724749}