- 26 Mar, 2019 40 commits
-
-
Michael Giuffrida authored
Renames AppListTabletModeContainer to HomeScreenContainer to reflect that it contains the home screen (either app list or kiosk next app). Hosts the KioskNextHome app window in this container when KioskNextShell is enabled. Also moves KioskNextShell tests from LoginUtilsTest to their own file. Bug: 937549 Change-Id: Icd2a878ed67a913128058e3d5fe688b65de7c5ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538688Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Auto-Submit: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#644371}
-
Daniel Bratell authored
Since mojom will put headers from ui/gfx/ipc/color into code in other targets, the dependency need to be public so that other code get the right dependency. Without the fix gn check --check-generated reports this: ERROR at //out/Default/gen/services/viz/public/interfaces/compositing/compositor_frame.mojom-test-utils.cc:51:11: Can't include this header from here. #include "ui/gfx/ipc/color/gfx_param_traits.h" ^---------------------------------- The target: //services/viz/public/interfaces:interfaces is including a file from the target: //ui/gfx/ipc/color:color It's usually best to depend directly on the destination target. In some cases, the destination target is considered a subcomponent of an intermediate target. In this case, the intermediate target should depend publicly on the destination to forward the ability to include headers. Dependency chain (there may also be others): //services/viz/public/interfaces:interfaces --> //ui/gfx/mojo:mojo --[private]--> //ui/gfx/ipc/color:color Bug: 938893 Change-Id: I5ab887bc137223c74e7b84ffc75a9fee0b3c01cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538412 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Auto-Submit: Daniel Bratell <bratell@opera.com> Reviewed-by:Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#644370}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I7c820116b0c09f65812b39723c6c7048183d1b10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539395Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644369}
-
Daniel Bratell authored
Since mojo will insert #include "media/base/ipc/media_param_traits_macros.h" in code using the media types mojo types, the dependency on media/base/ipc, where that header lives, need to be public. The error reported otherwise (by gn check --check-generated) was: ERROR at //out/Default/gen/media/mojo/interfaces/traits_test_service.mojom-test-utils.cc:30:11: Can't include this header from here. #include "media/base/ipc/media_param_traits_macros.h" ^----------------------------------------- The target: //media/mojo/interfaces:test_interfaces is including a file from the target: //media/base/ipc:ipc It's usually best to depend directly on the destination target. In some cases, the destination target is considered a subcomponent of an intermediate target. In this case, the intermediate target should depend publicly on the destination to forward the ability to include headers. Dependency chain (there may also be others): //media/mojo/interfaces:test_interfaces --> //media/mojo/interfaces:interfaces --[private]--> //media/base/ipc:ipc Bug: 938893 Change-Id: I7781ced5305ace65654da9ee4cf1a7f82ecac1a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538434 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Auto-Submit: Daniel Bratell <bratell@opera.com> Reviewed-by: -
Michael Crouse authored
HintsFetcher handles the response from the remote Optimization Guide Service and deserializes the response content into GetHintsResponse. UMA histogram logs are registered for the HTTP response code and network error codes. Previews Optimization Guide is notified via callback that the hints fetch was successful and the GetHintsResponse is returned. Previews Hints is created and handles parsing the GetHintsResponse object into a format, currently ComponentUpdateData, that the HintCacheStore can store the fetched hints in. Unit tests for HintFetcher, PreviewsOptimizationGuide, PreviewsHints have been updated to test various response cases. Bug: 932707 Change-Id: I1d004b89efdb30e2ba1443703c635b238ee37fc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522328 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Auto-Submit: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#644367}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b45f6428f884..b946b2389c43 git log b45f6428f884..b946b2389c43 --date=short --no-merges --format='%ad %ae %s' 2019-03-26 raul@tambre.ee Improve gclient Python 3 compatibility Created with: gclient setdep -r src/third_party/depot_tools@b946b2389c43 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:942522 TBR=agable@chromium.org Change-Id: I266100b8da0dc208a694a811f613ee7177acfdff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539065Reviewed-by:
-
mrefaat authored
During Tab refactoring, [tab goBack] was subtituted by the use of webState->NavigationManager.... But if tab was nil the code would have failed silently without crash (just no-op). This change modifies the existing code to match the old behavior. Bug: 943645 Change-Id: I026fccb44cf2637f22f823c6eb8375068d258d6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539117Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#644365}
-
Ken Rockot authored
Fixes a few egregious errors in the doc examples. Bug: None Change-Id: If6d3ce3c9ff292c26558f5a5bf9a02d860b001b5 TBR: oksamyt@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539861Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#644364}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/76ba7dbc4f95..8ea8dcbae6cb git log 76ba7dbc4f95..8ea8dcbae6cb --date=short --no-merges --format='%ad %ae %s' 2019-03-26 titovartem@webrtc.org Rename create_network_emulation_manager_api into create_network_emulation_manager 2019-03-26 kwiberg@webrtc.org Fix misunderstanding: OnTransportChanged is called on network thread 2019-03-26 titovartem@webrtc.org Add logging of internal stats into default video quality analyzer Created with: gclient setdep -r src/third_party/webrtc@8ea8dcbae6cb The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: If057414db3ea39f67207e2d53f729eda78d965e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539198Reviewed-by:
-
Ted Choc authored
This reverts commit dee2c037. Reason for revert: Suspect this is breaking the cronet builders: https://ci.chromium.org/buildbot/chromium.android/Android%20Cronet%20Marshmallow%2064bit%20Builder/27982 C 14.540s Main [FAILURE] org.chromium.cronet_sample_apk.CronetSampleTest#testLoadUrl: C 14.540s Main java.lang.RuntimeException: Unable to start activity ComponentInfo{org.chromium.cronet_sample_apk/org.chromium.cronet_sample_apk.CronetSampleActivity}: java.lang.ClassCastException: org.chromium.net.impl.NativeCronetProvider cannot be cast to c.a.a.d C 14.540s Main at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2416) That looks like proguard reflection issue. Original change's description: > Trichrome proguard: Implement majority of .build_config changes. > > This CL changes the way static library APK .build configs are > structured. Specifically: > * JNI sources, Proguard flags, and Proguard classpath jars are > combined from deps that use the static library > * The .build_config contains a mapping of .build_config paths -> > classpath for that target that can be used when dexsplitting > > Bug: 901465 > Change-Id: Ie83e071b3f6482cab594b3b0e735ad4ef8313bbb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536306 > Commit-Queue: Eric Stevenson <estevenson@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#644316} TBR=agrieve@chromium.org,estevenson@chromium.org Change-Id: I87a88ca5488f734dd22fef59161c0c41b4ad43fd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 901465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539918Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#644362}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/a92009000780..5ccc6eaadf1a git log a92009000780..5ccc6eaadf1a --date=short --no-merges --format='%ad %ae %s' 2019-03-26 nednguyen@google.com dependency: make sure that all directory source paths are ended with trailing '/' 2019-03-26 nednguyen@google.com Revert "cros_run_tests_unittest: temporarily disable DetermineBoardPackagesTest.testNonEmptyPackageSet test" 2019-03-26 nednguyen@google.com cros_extract_deps: manually filter out packages that are obsolete in the portage tree 2019-03-26 nednguyen@google.com dependency: include the board overlays directories in the source_paths for each board's package 2019-03-26 saklein@chromium.org Build API: Delete local copy of the proto. 2019-03-26 saklein@chromium.org Build API: Update imports to new generated proto 2019-03-26 saklein@chromium.org Build API: Generated proto from the infra repo. 2019-03-26 saklein@chromium.org Build API: Generate proto from the infra repo. Created with: gclient setdep -r src/third_party/chromite@5ccc6eaadf1a The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I9e94f896f716749642bfe7cf378ac3c0cdd962d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539063Reviewed-by:
-
Rayan Kanso authored
Most of these minor changes were supposed to go in another CL which I abandoned, so I included them here (+ a few more). Change-Id: I1477df109e8b5c2cd3b4c36fa4f559c87b1981ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539047 Auto-Submit: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#644360}
-
Daniel Bratell authored
proto targets use net_export.h without depending on the target where that header lives. That made gn check --check-generated report errors like this one: ___________________ ERROR at //out/Default/gen/net/nqe/proto/network_id_proto.pb.h:33:11: Include not allowed. #include "net/base/net_export.h" ^-------------------- It is not in any dependency of //net:net_nqe_proto The include file is in the target(s): //net:net which should somehow be reachable. ___________________ This fixes that problem by moving net_export.h to a separate build target that other targets can depend on. Bug: 655123 Change-Id: If7953e007f500adae4fe10b78e86f1a4afaecf17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538506 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#644359}
-
Daniel Bratell authored
The mojo type ResourceType used the public resource_type.h header without depending on the build target where that header was declared. Depending directly on that target would create a dependency cycle so a new "resource_type_header" target was created. The dependency cycle would have been: //content/public/common:resource_type_bindings -> //content/public/common:common -> //content:content //content/public/app:both_sources -> //content/public/common:common_sources -> //content/public/common:interfaces -> //content/public/common:resource_type_bindings -> The exact error this fixes is: ERROR at //out/Default/gen/content/public/common/resource_type.mojom-forward.h:35:11: Include not allowed. ^------------------------------------ It is not in any dependency of //content/public/common:resource_type_bindings The include file is in the target(s): //content/public/common:common_sources which should somehow be reachable. ___________________ Bug 938893 Change-Id: I350bff6a53a5be72f992e1226f7a3adce46f709d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535856Reviewed-by:Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#644358}
-
Eric Stevenson authored
Release notes: https://github.com/google/bundletool/releases/tag/0.9.0. Primary motivation is to better support locale specific system APKs for http://crbug.com/945418. Note: Flag --universal is no longer supported. Bug: 945418 Change-Id: I93c367dcd593d05ce8132e4dfb1223fa16a68d20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539781Reviewed-by:
David Turner <digit@chromium.org> Commit-Queue: David Turner <digit@chromium.org> Auto-Submit: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#644357}
-
Chris Lu authored
Modifies title and description of kUmaCellular flag to better convey purpose of feature to snd UMA data over wifi or cellular instead of just cellular by default. Bug: 931289 Change-Id: I9e37899e989327359b3abd0d1f8795acfe79fa7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538715 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
-
Nektarios Paisios authored
The AXPosition representing the anchor of the selection should get the same affinity as the AXPosition representing its focus in the case when the selection is collapsed: 1. Say a user presses the "end" key to move to the end of a line with a soft line break. 2. The focus of the selection would get an affinity of upstream. 3. The anchor should also get an upstream affinity because it has the same position as the focus. This should behave the same both in textareas as well as in content editables. R=dmazzoni@chromium.org, yosin@chromium.org Change-Id: I9564be9f1013afd560505643761d1a9da8a76ada Bug: 639340 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534928 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Auto-Submit: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#644355}
-
Mikel Astiz authored
This is the most reliable way to make sure session-related information is not tracked for syncing purposes while sync is paused (DICe signout). It also means chrome://history and possibly other features will stop exposing foreign tabs are soon as the user signs out. Bug: 914747 Change-Id: I97e0922632e51fd2b25cc9cca686e4db8d7b7794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535889 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#644354}
-
Vladimir Levin authored
This patch ensures that we correctly propagate effective whitelisted touch action flags whether they happen inside or outside of locked subtrees. R=pdr@chromium.org, wangxianzhu@chromium.org Change-Id: I7efd1cab4ecd1339fa6b252cb5bcd62f360e69f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521631Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#644353}
-
gogerald authored
Make the focus element action as the click action to wait for the page to become interactive, This potentially fix the issue, http://b/119665284 May add a browser test to simulate non-interactive situation Change-Id: I88f4f033ffeeadcdd585839956f3c4861fbc29da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538981 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Auto-Submit: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#644352}
-
Jonathan Ross authored
Currently Mac generates a new LocalSurfaceId whenever the current ID is polled, but not valid. This differed from how other platforms only generate the new ID once it was ready to display. When fixing hidden navigation issues a new test was added to verify that the id was invalid after navigation. However this failed as we just instantly created a new id. This patch brings the id allocation in line with other platforms, with BrowserCompositorMac::TransitionToState now allocating when the id is invalid. This will allow the test to give coverage on Mac, and fix the UMA stats associated with allocation. TEST=NoCompositingRenderWidgetHostViewBrowserTest.ValidLocalSurfaceIdAllocationAfterHiddenNavigation Bug: 935364 Change-Id: I7785a6ebc4b0bc99fc4813e023dd6fbb8b49aa01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1537749Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#644351}
-
Scott Violet authored
The test does the following: . creates two browser windows. . enters tablet mode. . snaps one to the left, one to the right. . drags the resizer a bunch of times. BUG=942623 TEST=test only change Change-Id: I2b0e880d4f0ce85267821614d85e3596cadc6960 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538574Reviewed-by:
-
Abhijeet Kandalkar authored
Bug: 891908 Change-Id: I79c199ee38d9369f4ca87d578dcbc8565fa0ef11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538157 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#644349}
-
khmel@chromium.org authored
Tracing was changed and no longer deliver events in right order. Parent event is closed after children event and this is the order tracing event appear. This CL pre-sorts events based on timestamp and duration to make sure parent event goes first. This additionally fixes crashes in error logging and removes bottleneck in building common tracing model. TEST=Manually + unit test. Observed that common model is built in less than second, compared with ~ min (debug unit test) with old approach. BUG=b:122555793 Change-Id: Ieeb158bb54495a55bf3fa2ddf9d5e18075794091 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539013Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1483e9f714b7..d8a240a71a0c Created with: gclient setdep -r src-internal@d8a240a71a0c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=sahel@chromium.org,horo@chromium.org,pkasting@chromium.org,andruud@chromium.org Change-Id: I917f9f4c26c9ab5d692a81a642c10ea68d253a53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539394Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644347}
-
Henrik Grunell authored
They are no longer used. Bug: 938028 Change-Id: Ic8cf5f417d42aced693cf7b9b0b3a55e134778bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539046 Commit-Queue: Henrik Grunell <grunell@chromium.org> Reviewed-by:
Henrik Andreasson <henrika@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#644346}
-
manuk authored
Before, the omnibox accessibility text was set when OnTemporaryTextMaybeChanged was called, which was not called when the omnibox was reverted. This was fine, as screen readers were only triggered when traversing the omnibox with the arrow/page up/down keys, and not when reverting the omnibox. crrev.com/c/1419257 changed traversing the selection to the first suggestion to be consistent with reverting the omnibox. Consequently, the accessibility text was no longer set when arrowing/paging up to the first suggestion, and the incorrect text (corresponding to the previously selected match) was read. This CL sets the accessibility text on revert as well. Bug: 943105 Change-Id: I22df51b3a17a34d5a7c35f494a365391d1c67236 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534138Reviewed-by:
Orin Jaworski <orinj@chromium.org> Reviewed-by:
Kevin Bailey <krb@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#644345}
-
Mikel Astiz authored
This change affects the case where the feature toggle kDeferRecyclingOfSyncTabNodesIfUnsynced is enabled, which we expect to do by default soon. Keeping an unsyncyed tab around after the tab has been closed is problematic for the case where history is deleted meanwhile. Because we can't reliably detect history events, let's be more aggressive on the time-based cleanup. Bug: 882489 Change-Id: Ia6396103cd8f0c7738838d9e8d461f4b5f512ab5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538089Reviewed-by:
-
Lukasz Anforowicz authored
Bug: 944661 Bug: 944775 Bug: 944770 Bug: 944820 Bug: 944891 Bug: 945158 Bug: 945164 Bug: 945391 Change-Id: Ie64081057d939fa79c2b2d0d15a882c768314e56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536548 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#644343}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c7c267a33ae0..b66b4e0b328b git log c7c267a33ae0..b66b4e0b328b --date=short --no-merges --format='%ad %ae %s' 2019-03-26 taylori@google.com Merge "perfetto-ui: Thread states" Created with: gclient setdep -r src/third_party/perfetto@b66b4e0b328b The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ic22cc4dc3b1eb5bdf36a4a09e79f76616a88d397 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539199Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/e7ea071aeed4..b53068f358da git log e7ea071aeed4..b53068f358da --date=short --no-merges --format='%ad %ae %s' 2019-03-26 simonhatch@chromium.org Pinpoint - Merge bugs with same root cause. Created with: gclient setdep -r src/third_party/catapult@b53068f358da The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:840872 TBR=sadrul@chromium.org Change-Id: Ia3246abb97bde0d27709a0469df922676e9451da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539197Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644341}
-
Leonard Grey authored
Bug: 924505, 935593 Change-Id: Ibb2f747b7a9a9e0516e4a8e18e9c55b712d77f86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504255 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#644340}
-
Henrique Ferreiro authored
CSSValueID was changed to an scoped enum in https://crrev.com/c/1530916, and equivalent int variables were introduced while the remaining uses were ported. This CL ports all the remaining keyword values and removes the compatibility variables. Bug: 936371 Change-Id: I9cd966fb79a57401379f6b11d6912f4b53b1960f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538180Reviewed-by:
-
Raul Tambre authored
The former non-overloaded variants are deprecated. This is a mechanical change; there is no intended behavior change. Bug: 929827 Change-Id: I4b6652984778dbf97418c7bc6103114077b83662 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539590 Auto-Submit: Raul Tambre <raul@tambre.ee> Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#644338}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e17d1ed64f9a..b45f6428f884 git log e17d1ed64f9a..b45f6428f884 --date=short --no-merges --format='%ad %ae %s' 2019-03-26 raphael.kubo.da.costa@intel.com fake_repos: Create a new socket for every connection attempt while waiting for a port Created with: gclient setdep -r src/third_party/depot_tools@b45f6428f884 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Id2bd8b98de54bbb2198303b246b44face81bea1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539291Reviewed-by:
-
Mounir Lamouri authored
Intent to Ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/0TJyePKiegs/24w8YsCQCAAJ Bug: 943877 Change-Id: I41aba4c93559c97fdbba9149aad379b2134fd859 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538494Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#644336}
-
Gyuyoung Kim authored
As advised in [1], this CL removes unnecessary Foo::Create() factory functions which return an instance using MakeGarbageCollected<Foo> in //third_party/blink/renderer/core/css, then this CL makes the callers use MakeGarbageCollected<Foo> instead of Foo::Create() factory functions. This CL is the sixth clean up in core/css. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: I3e056ef869813e2e613efd695139af43560f93cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539626Reviewed-by:
-
Raul Tambre authored
The former non-overloaded variants are deprecated. This is a mechanical change; there is no intended behavior change. Bug: 929827 Change-Id: I2316c7e6ae1f7a73deda1b8e9b817a7ee7154441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538086 Auto-Submit: Raul Tambre <raul@tambre.ee> Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#644334}
-
Yutaka Hirano authored
We decided to rely on Network Service. From services/network/cors viewpoint, Network Service is always enabled. Bug: 943931 Change-Id: Id4ccf8661759965735a3111c7a563f21ad1cc23f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531891Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
-
Miguel Casas-Sanchez authored
This CL extend the WPTest for Canvas getContextAttributes to include the |desynchronized|. This CL covers the flag WPT test extension mentioned in https://github.com/whatwg/html/pull/4360 (which addressed https://github.com/whatwg/html/issues/4087). Bug: 944199, 945835 Change-Id: Ibb339c66014d7579023f75c7f2cef99e3f03d351 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538491Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#644332}
-
