- 03 Dec, 2018 40 commits
-
-
gogerald authored
This CL also removed the unnecessary checks since destroy the Controller won't change the raw pointer value in UiControllerAndroid. Bug: 806868 Change-Id: Id23c0f73f2db236462e380e47b5836affefb5ef7 Reviewed-on: https://chromium-review.googlesource.com/c/1356121Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#613096}
-
Marc Treib authored
...and into sync_ui_util, where it belongs. This means that some ProfileSyncService unit tests can't verify it anymore because it now lives in chrome/browser, but that seems okay (it's still tested in sync_ui_util_unittest.cc). Also use this chance to rename it to ShouldShowSyncConfirmation, which better describes what it means. Bug: 884159 Change-Id: I14149544d353491ace0590a530e65d0d7687d09f Reviewed-on: https://chromium-review.googlesource.com/c/1356705Reviewed-by:
Florian Uunk <feuunk@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#613095}
-
Friedrich Horschig authored
This CL reenables the first set of integrations tests whose flakiness should be resolved since the FakeKeyboard replaces the flaky, emulated soft keyboard. Bug: 911056 Change-Id: I096fb08df3b76f7c07bdd819f7c66f2eee099417 Reviewed-on: https://chromium-review.googlesource.com/c/1358433Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#613094}
-
Kristi Park authored
Previously, the favicons were not resized at all. Add functionality to resize the favicons to the proper pixel width/height. Bug: 908051 Change-Id: Ie81f1675575d5d8f66be686db2d78e40124412e8 Reviewed-on: https://chromium-review.googlesource.com/c/1357570 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#613093}
-
Joshua Pawlicki authored
Bug: 740715 Change-Id: I8fa7f98c1303d7ab0901d77df7cc3f73c9fda18a Reviewed-on: https://chromium-review.googlesource.com/c/1342763Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#613092}
-
jonross authored
This test had been disabled due to flakiness. My change to frame eviction was the likely cause. This was fixed by https://chromium-review.googlesource.com/c/chromium/src/+/1355845 I also separately ran an experiment which confirmed that the suspected mode of failure occurs frequently during testing. Where currently visible surfaces are being evicted. My change invalidated the current id, with the goal of allocating new ids closer to usage. Unfortunately on Android the eviction process itself can be the signal of needing a new id. Now we simply allocate if visible. TBR=peconn@chromium.org Bug: 906840 Change-Id: I917a2e230ee472a48858b56feca2c96dc7bd7761 Reviewed-on: https://chromium-review.googlesource.com/c/1358652Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#613091}
-
Carlos Caballero authored
MessageLoop will go away, eventually. BUG=891670 Change-Id: I95af02ea3f68b674dd66097c0b9b46538fbc4ad7 Reviewed-on: https://chromium-review.googlesource.com/c/1352778Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#613090}
-
Miguel Casas authored
This CL removes the debug variable |num_frames_at_client_| since it's always equal to the difference between pictures_.size() and available_picture_buffers_.size(). Test: Checked in crosvideo and v_d_a_unittests that the values are ==. Bug: 721674 Change-Id: I946192bde8368210c4b65cf0084c34ee86ea3e62 Reviewed-on: https://chromium-review.googlesource.com/c/1357554Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#613089}
-
Philip Rogers authored
This patch fixes a typo in https://crrev.com/612683 where the wrong directory name was used (enable-features=... instead of enable-blink-features=...). This typo slipped in because the property bot is failing for infra reasons (https://crbug.com/910859). NOTRY=true Bug: 836884 Change-Id: I88d38247fc0501d21af058852e2694b2ee432722 Reviewed-on: https://chromium-review.googlesource.com/c/1356964 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#613088}
-
Gauthier Ambard authored
This CL adds a scroll view containing the text displayed when the table view is empty. It allows the user to scroll the text if the font size used is big. As the safe area insets aren't propagated to the empty view, this is using dummy view to fake the safe area insets in the scroll view. Bug: 893535 Change-Id: I63b658c1bc9d5cacdb4e86d201a2bb2ca7621a96 Reviewed-on: https://chromium-review.googlesource.com/c/1353941 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#613087}
-
Guido Urdaneta authored
Bug: 910846 Change-Id: Ic3e11dd60d1c580a5619ce4a2cbcba3b28a60212 TBR: leszeks@chromium.org No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/1358445 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#613086}
-
Noel Gordon authored
If we can use ...args @constructor, use strict as well. Bug: 910991 Change-Id: I6181423d7df7ab1a376650c657bdb3d8b0636f3c Reviewed-on: https://chromium-review.googlesource.com/c/1358323Reviewed-by:
-
Keishi Hattori authored
Remove unnecessary casts from TraceWrapperV8Reference tracing in preparation for https://chromium-review.googlesource.com/c/chromium/src/+/1356442 because blink_gc_plugin will not be able to recognize cast TraceWrapperV8References as traced. Bug: 910023 Change-Id: Icc68c8eac74d5a7c320e6fd575cceba71951c57a Reviewed-on: https://chromium-review.googlesource.com/c/1358318 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#613084}
-
Brian White authored
Current enumeration support ignores pages that don't emit any of the desired metric so technically this will be proportion of pages that use Blink instead of the proportion of all pages. However, since it seems likely that the number of pages that don't use any Blink features is incredibly small (if not outright zero), this is acceptable for now. Note: A recent CL will make a huge difference with the per-page proportions so avoid looking at M72 Canary/Dev aggregations. M73 or M72 Beta/Stable (once released) will be fine. https://chromium-review.googlesource.com/c/chromium/src/+/1343060 Change-Id: I46b3092caa0a21e1c5e6baac9977b0efc8ae39e4 Reviewed-on: https://chromium-review.googlesource.com/c/1355486Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Luna Lu <loonybear@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#613083}
-
Guido Urdaneta authored
Bug: 910846 Change-Id: Id761ea19b03af52c25983626e00d28d601cbfef0 TBR: leszeks@chromium.org No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/1358458Reviewed-by:
-
Guido Urdaneta authored
Bug: 910868 Change-Id: Ib509c2b325855dd88758dee8a91203f12c640b97 TBR: tedchoc@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1358455Reviewed-by:
-
Lutz Justen authored
Fixes a bug where the wrong registry value names where used, so that setting policy didn't have effect. It used a hierarchical value name cat1_cat2_cat3_policy This isn't necessary since the corresponding registry key already contains the categories: Software\Policies\Google\Chrome\3rdparty\extensions\<extension_id>\Policy\cat1\cat2\cat3 so that the policy is guaranteed to be unique within the key. What's worse is that the code isn't looking for 'cat1_cat2_cat3_policy', but just for 'policy'. Hence, the policy settings were not taken. Bug: 900517 Test: manual Change-Id: I2e1b83fe2ff6b0997ab22e47c986a92dcb19559e Reviewed-on: https://chromium-review.googlesource.com/c/1356699Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#613080}
-
Mugdha Lakhani authored
This had been introduced to simplify access to active fetches, but has the following issues: 1. It makes match() and matchAll() inconsistent with Cache API's match() and matchAll(), which return new independently-consumable response(s) every time they're called. 2. It breaks retries for responses, when downloading from a server that doesn't support resuming of downloads. For details, see https://docs.google.com/document/d/1CrbWrnnshhyp_SfiAeuODpnQX36GK3Bsi19rXQGez6Q/edit?usp=sharing The CL also updates the WPT test accordingly. Bug: 875201 Change-Id: I2c33717cbee36f0d707e814506c0bae9b5a4f31f Reviewed-on: https://chromium-review.googlesource.com/c/1355121 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#613079}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a0f4430b3aae..9cf6ce3e1bb3 git log a0f4430b3aae..9cf6ce3e1bb3 --date=short --no-merges --format='%ad %ae %s' 2018-12-03 oprypin@webrtc.org Finish renaming another tryjob that was forgotten 2018-12-03 oprypin@webrtc.org Rename most tryjobs to avoid implied defaults 2018-12-03 kron@webrtc.org Remove color space enum value kInvalid 2018-12-03 nisse@webrtc.org Delete workaround for CreateEvent Created with: gclient setdep -r src/third_party/webrtc@9cf6ce3e1bb3 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia15551d40692f7a1b4e6393ad60247b63742e3dd Reviewed-on: https://chromium-review.googlesource.com/c/1358213Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#613078}
-
Guido Urdaneta authored
Bug: 910870 Change-Id: Ic79310338050d10199e49104d188219cbe46d498 TBR: xingliu@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1358495Reviewed-by:
-
Rune Lillesveen authored
Under certain combinations of whitespace-reattachment after removing nodes, parent element being display:contents triggering anonymous inline boxes for such parents, and ::first-letter being marked for re- attachment, we can end up with a calculated first-letter text node changing from non-null to null between style recalc and layout tree rebuild. Make sure we check that the first-letter text node is still non-null early in UpdateFirstLetterPseudoElement during the kRebuildLayoutTree so that we nuke the first-letter pseudo instead of re-attaching without first-letter text. Bug: 908253 Change-Id: Ifaac75b34edce21467581b5a9e78f5287a842fe5 Reviewed-on: https://chromium-review.googlesource.com/c/1356714 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#613076}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f385a96af6b5..7b257ce8b3eb Created with: gclient setdep -r src-internal@7b257ce8b3eb The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I97e8899b477bdc1bdea692f16d52f6596003b65a Reviewed-on: https://chromium-review.googlesource.com/c/1358214Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#613075}
-
Makoto Shimazu authored
This is a prerequisite step for using FetchAPIRequest instead of ServiceWorkerFetchRequest. ServiceWorkerFetchRequest has a member |headers| with CaseInsensitiveCompare, but FetchAPIRequest has a member |headers| with the default Compare function, so that this will cause behavior changes. This CL is to change FetchAPIRequest::headers to use CaseInsensitiveCompare. Bug: 908344, 789854 Change-Id: I8e1736d5c5ab2d291ff7c126afa0f4025983b84d Reviewed-on: https://chromium-review.googlesource.com/c/1356463 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#613074}
-
Guido Urdaneta authored
This reverts commit aa21b3f5. Reason for revert: Suspect of introducing consistent failure on Mac ASAN 64 tests. First failed run: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac%20ASan%2064%20Tests%20%281%29/46988 Sample logs: unit_tests Run on OS: 'Mac-10.13' Shard duration: 0:07:56.378119 failures: FileAnalyzerTest.ArchivedArchiveSetForZipNoArchive FileAnalyzerTest.ArchivedExecutableFalseForZipNoExecutable DownloadProtectionServiceTest.CheckClientDownloadZip SandboxedZipAnalyzerTest.ZippedAppWithUnsignedAndSignedExecutable SandboxedZipAnalyzerTest.NoBinaries FileAnalyzerTest.ArchivedBinariesSkipsSafeFiles ==34531==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x700015467c14 at pc 0x00013e99c44d bp 0x700015467950 sp 0x7000154670f8 READ of size 5 at 0x700015467c14 thread T16 #0 0x13e99c44c in __asan_after_dynamic_init ??:0:0 #1 0x10e3ac931 in safe_browsing::UpdateArchiveAnalyzerResultsWithFile(base::FilePath, base::File*, bool, safe_browsing::ArchiveAnalyzerResults*) ??:0:0 #2 0x10e3a6707 in safe_browsing::zip_analyzer::AnalyzeZipFile(base::File, base::File, safe_browsing::ArchiveAnalyzerResults*) ??:0:0 #3 0x115236586 in SafeArchiveAnalyzer::AnalyzeZipFile(base::File, base::File, base::OnceCallback<void (safe_browsing::ArchiveAnalyzerResults const&)>) ??:0:0 #4 0x10bc0b332 in chrome::mojom::SafeArchiveAnalyzerStubDispatch::AcceptWithResponder(chrome::mojom::SafeArchiveAnalyzer*, mojo::Message*, std::__1::unique_ptr<mojo::MessageReceiverWithStatus, std::__1::default_delete<mojo::MessageReceiverWithStatus> >) ??:0:0 #5 0x115234a40 in chrome::mojom::SafeArchiveAnalyzerStub<mojo::RawPtrImplRefTraits<chrome::mojom::SafeArchiveAnalyzer> >::AcceptWithResponder(mojo::Message*, std::__1::unique_ptr<mojo::MessageReceiverWithStatus, std::__1::default_delete<mojo::MessageReceiverWithStatus> >) ??:0:0 #6 0x1165eeb32 in mojo::InterfaceEndpointClient::HandleValidatedMessage(mojo::Message*) ??:0:0 #7 0x1165ed1e0 in mojo::FilterChain::Accept(mojo::Message*) ??:0:0 #8 0x1165f278b in mojo::InterfaceEndpointClient::HandleIncomingMessage(mojo::Message*) ??:0:0 #9 0x116605686 in mojo::internal::MultiplexRouter::ProcessIncomingMessage(mojo::internal::MultiplexRouter::MessageWrapper*, mojo::internal::MultiplexRouter::ClientCallBehavior, base::SequencedTaskRunner*) ??:0:0 #10 0x11660372b in mojo::internal::MultiplexRouter::Accept(mojo::Message*) ??:0:0 #11 0x1165ed1e0 in mojo::FilterChain::Accept(mojo::Message*) ??:0:0 #12 0x1165dcea8 in mojo::Connector::ReadSingleMessage(unsigned int*) ??:0:0 #13 0x1165df32a in mojo::Connector::ReadAllAvailableMessages() ??:0:0 #14 0x1165deda1 in mojo::Connector::OnHandleReadyInternal(unsigned int) ??:0:0 #15 0x10d429d44 in mojo::SimpleWatcher::DiscardReadyState(base::RepeatingCallback<void (unsigned int)> const&, unsigned int, mojo::HandleSignalsState const&) ??:0:0 #16 0x11a802cf5 in mojo::SimpleWatcher::OnHandleReady(int, unsigned int, mojo::HandleSignalsState const&) ??:0:0 #17 0x11a803cbd in void base::internal::Invoker<base::internal::BindState<void (mojo::SimpleWatcher::*)(int, unsigned int, mojo::HandleSignalsState const&), base::WeakPtr<mojo::SimpleWatcher>, int, unsigned int, mojo::HandleSignalsState>, void ()>::RunImpl<void (mojo::SimpleWatcher::* const&)(int, unsigned int, mojo::HandleSignalsState const&), std::__1::tuple<base::WeakPtr<mojo::SimpleWatcher>, int, unsigned int, mojo::HandleSignalsState> const&, 0ul, 1ul, 2ul, 3ul>(void (mojo::SimpleWatcher::* const&)(int, unsigned int, mojo::HandleSignalsState const&), std::__1::tuple<base::WeakPtr<mojo::SimpleWatcher>, int, unsigned int, mojo::HandleSignalsState> const&, std::__1::integer_sequence<unsigned long, 0ul, 1ul, 2ul, 3ul>) ??:0:0 #18 0x11890131c in base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) ??:0:0 #19 0x118995271 in base::MessageLoopImpl::RunTask(base::PendingTask*) ??:0:0 #20 0x11899691f in base::MessageLoopImpl::DoWork() ??:0:0 #21 0x118999eb3 in base::MessagePumpDefault::Run(base::MessagePump::Delegate*) ??:0:0 #22 0x118994259 in base::MessageLoopImpl::Run(bool) ??:0:0 #23 0x118a49a1c in base::RunLoop::Run() ??:0:0 #24 0x118b962e2 in base::Thread::Run(base::RunLoop*) ??:0:0 #25 0x118b96e9d in base::Thread::ThreadMain() ??:0:0 #26 0x118c72a0d in base::(anonymous namespace)::ThreadFunc(void*) ??:0:0 #27 0x7fff74564660 in _pthread_body ??:0:0 #28 0x7fff7456450c in _pthread_start ??:0:0 Original change's description: > Add util method to update ArchiveAnalyzerResults for a single file > > This CL breaks out the code that inspects an individual file within a > ZIP archive. This will be shared between the ZIP and RAR inspection, > when RAR files begin doing content inspection. > > Bug: 909778 > Change-Id: I7acf1cabd472f112f2ed7c31735688cae7a6d122 > Reviewed-on: https://chromium-review.googlesource.com/c/1354103 > Commit-Queue: Daniel Rubery <drubery@chromium.org> > Reviewed-by: Brian White <bcwhite@chromium.org> > Reviewed-by: Jay Civelli <jcivelli@chromium.org> > Reviewed-by: Varun Khaneja <vakh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612799} TBR=jcivelli@chromium.org,bcwhite@chromium.org,vakh@chromium.org,drubery@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 909778 Change-Id: I92e193707da4a28cee94aa1277a6ca567650760f Reviewed-on: https://chromium-review.googlesource.com/c/1358491Reviewed-by:
-
Carlos Caballero authored
MessageLoop will go away, eventually. BUG=891670 Change-Id: I4e776d210c338961a5225b33a858d3376fb94fb8 Reviewed-on: https://chromium-review.googlesource.com/c/1353920Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#613072}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c0d45675..5a42884b Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If22002bb471b60e049567c949f57efc5a1d43e42 Reviewed-on: https://chromium-review.googlesource.com/c/1357842Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#613071}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/96fdf7cbe6ed..a21a7c53d9b2 git log 96fdf7cbe6ed..a21a7c53d9b2 --date=short --no-merges --format='%ad %ae %s' 2018-12-03 tikuta@chromium.org [ninja] update ninja repository url Created with: gclient setdep -r src/third_party/depot_tools@a21a7c53d9b2 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ic80a07d3fcbc13d82f4061e71ae28aef6975636c Reviewed-on: https://chromium-review.googlesource.com/c/1358212Reviewed-by:
-
Carlos Caballero authored
MessageLoop will go away, eventually. BUG=891670 Change-Id: If3946be6ba9614c070e5790e6430ac91538f4311 Reviewed-on: https://chromium-review.googlesource.com/c/1353885Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#613069}
-
Mikel Astiz authored
When a foreign session is detected to be old enough, garbage collection should kick in and all sync entities deleted. This includes orphan tabs as well (i.e. tabs not referenced from the header entity because the tab was closed). Bug: 882489 Change-Id: I9f6e0e4505cc798466294f1fa1a247818cf004b9 Reviewed-on: https://chromium-review.googlesource.com/c/1356717 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#613068}
-
Christian Dullweber authored
Followup for https://crrev.com/c/1335939 Bug: 795872 Change-Id: I50aef1c108eb2afa09ff18361b77b1110a02df0b Reviewed-on: https://chromium-review.googlesource.com/c/1356539Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#613067}
-
Javier Ernesto Flores Robles authored
Bug: 845472 Change-Id: I30ae4dd0811b60aa5509c8d3a276a62626bb454c Reviewed-on: https://chromium-review.googlesource.com/c/1355133 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#613066}
-
Benoît Lizé authored
Better CSV output. Bug: 907489 Change-Id: Ibe6be70beffacdabc570c4bdc2a8868c0e9ab41c Reviewed-on: https://chromium-review.googlesource.com/c/1358432 Commit-Queue: Egor Pasko <pasko@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#613065}
-
Guido Urdaneta authored
This reverts commit 07670151. Reason for revert: Suspect of introducing consistent failure on Mac12.12 Tests bot. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests First failure: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/17211 Sample logs [ RUN ] NativeAppWindowCocoaBrowserTest.HideShowWithAppWithShim [12598:61443:1201/114417.410054:WARNING:notification_platform_bridge_mac.mm(521)] AlertNotificationService: XPC connection invalidated. ../../chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm:198: Failure Actual function call count doesn't match EXPECT_CALL(*mock_host, OnAppUnhideWithoutActivation())... Expected: to be called once Actual: never called - unsatisfied and active Stack trace: 0 browser_tests 0x000000010ca5edbb testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop(int) + 91 1 browser_tests 0x000000010ca5e779 testing::internal::AssertHelper::operator=(testing::Message const&) const + 89 2 browser_tests 0x000000010ca4dd61 testing::internal::GoogleTestFailureReporter::ReportFailure(testing::internal::FailureReporterInterface::FailureType, char const*, int, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) + 97 3 browser_tests 0x000000010ca52a28 testing::internal::UntypedFunctionMockerBase::VerifyAndClearExpectationsLocked() + 584 4 browser_tests 0x000000010ca53399 testing::Mock::VerifyAndClearExpectationsLocked(void*) + 393 5 browser_tests 0x000000010ca531f1 testing::Mock::VerifyAndClearExpectations(void*) + 33 6 browser_tests 0x000000010c75e4cd NativeAppWindowCocoaBrowserTest_HideShowWithAppWithShim_Test::RunTestOnMainThread() + 3117 7 browser_tests 0x000000010ff002bb content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() + 491 8 browser_tests 0x000000010f944014 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() + 4372 9 browser_tests 0x000000010f942e3d ChromeBrowserMainParts::PreMainMessageLoopRun() + 45 10 browser_tests 0x000000010daaedc2 content::BrowserMainLoop::PreMainMessageLoopRun() + 50 11 browser_tests 0x000000010df0f397 content::StartupTaskRunner::RunAllTasksNow() + 39 12 browser_tests 0x000000010daad9fb content::BrowserMainLoop::CreateStartupTasks() + 683 13 browser_tests 0x000000010dab1065 content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) + 85 14 browser_tests 0x000000010daabde2 content::BrowserMain(content::MainFunctionParams const&) + 178 15 browser_tests 0x000000010f3cc601 content::ContentMainRunnerImpl::RunServiceManager(content::MainFunctionParams&, bool) + 241 16 browser_tests 0x000000010f3cc4e4 content::ContentMainRunnerImpl::Run(bool) + 292 17 browser_tests 0x00000001127318cb service_manager::Main(service_manager::MainParams const&) + 3051 18 browser_tests 0x000000010f3cb684 content::ContentMain(content::ContentMainParams const&) + 68 19 browser_tests 0x000000010fefff0d content::BrowserTestBase::SetUp() + 2829 20 browser_tests 0x000000010f8b75f1 InProcessBrowserTest::SetUp() + 529 Original change's description: > Remove AppShimHandler::Host interface and access AppShimHost directly > > This has been a longstanding TODO. Pending work will require adding > more methods to route to AppShimHost, so just delete this rather than > adding more methods to it. > > TBR=mgiuca > > Bug: 896917 > Change-Id: Idd8f55c7b6f549354441e28832e292ce693b9363 > Reviewed-on: https://chromium-review.googlesource.com/c/1357574 > Reviewed-by: ccameron <ccameron@chromium.org> > Commit-Queue: ccameron <ccameron@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612938} TBR=ccameron@chromium.org,mgiuca@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 896917 Change-Id: I0e4314f3a0d9b1241ecdde333a4d02b327a06917 Reviewed-on: https://chromium-review.googlesource.com/c/1358431Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bfdfca78e079..f385a96af6b5 Created with: gclient setdep -r src-internal@f385a96af6b5 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I7d3320dff5c3ee895986e8018e9e5fafa06a1786 Reviewed-on: https://chromium-review.googlesource.com/c/1358211Reviewed-by:
-
Peter E Conn authored
This reverts commit aa1f1cca. Relanded CL: https://chromium-review.googlesource.com/c/chromium/src/+/1341998 Changes from original: Initialize has_maskable_primary_icon_ Bug: 904354 Change-Id: I10cbd7bcfea94ea4a1b20236b4e619be9ce415e7 TBR: mgiuca@chromium.org, peter@chromium.org, yfriedman@chromium.org, dominickn@chromium.org Change-Id: I10cbd7bcfea94ea4a1b20236b4e619be9ce415e7 Reviewed-on: https://chromium-review.googlesource.com/c/1358062Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#613062}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/21d8b181f663..a0f4430b3aae git log 21d8b181f663..a0f4430b3aae --date=short --no-merges --format='%ad %ae %s' 2018-12-03 nisse@webrtc.org Replace RegisterExternalDecoder with decoder factory in NetEqImplTest120ms Created with: gclient setdep -r src/third_party/webrtc@a0f4430b3aae The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I73b83c98e0984ba7ef5506c0715d548461de99e9 Reviewed-on: https://chromium-review.googlesource.com/c/1358208Reviewed-by:
-
Adam Rice authored
Add a minimal test for whether transferable streams are functioning or not. This can be used to determine whether they have been shipped or not. The test is in its own directory so that it can be added to the virtual/stable test suite without any other tests. This will ensure we don't accidentally ship transferable streams. BUG=894838 Change-Id: I2de66a55fc1c72ddd742f1d192a152a9264064df Reviewed-on: https://chromium-review.googlesource.com/c/1356723 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#613060}
-
Marc Treib authored
- Reorder all overrides to be grouped by interface, and match the interface's ordering. - Remove a second ctor that isn't necessary anymore. - Remove some unnecessary includes. Bug: 910518 Change-Id: I4123e4ce9cd8eeac4fd2cef051e094cccc8c7d14 Reviewed-on: https://chromium-review.googlesource.com/c/1356702 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#613059}
-
Noel Gordon authored
- add Closure @type annotations to unittest JS types - add setUp(), add setDriveFsEnabled() helpers - prefix test cases with a descriptive comment No change in test behavior, no new tests. Bug: 911024 Change-Id: Iaa1bcf5b4ab00d7e2c89875361ff14b1dee03a00 Reviewed-on: https://chromium-review.googlesource.com/c/1358316 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#613058}
-
Boris Sazonov authored
This CL reverts half of https://crrev.com/c/1329161 by enabling testModalNativeAppBannerCanBeTriggeredMultipleTimesCustomTab that was disabled by the CL. The issue that was causing the failures should've been fixed by https://crrev.com/c/1345069. testAppInstalledModalNativeAppBannerCustomTab, the second test disabled by https://crrev.com/c/1329161 is not enabled by this CL, as it fails with TimeoutException (doesn't seem to be connected to the failure fixed by https://crrev.com/c/1345069). Bug: 903657 Change-Id: I4ef52c1bfe9d560fecbcfa4e389baffef758fe15 Reviewed-on: https://chromium-review.googlesource.com/c/1350187Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#613057}
-
