GitLab

BUG=485381

Review URL: https://codereview.chromium.org/1138893003

Cr-Commit-Position: refs/heads/master@{#329530}

The new histograms measure the performance of session cookie deletion.

BUG=485694

Review URL: https://codereview.chromium.org/1131413004

Cr-Commit-Position: refs/heads/master@{#329529}

Previously SSLServerSocketOpenSSL was ignoring disabled_cipher_suites
list and require_forward_secrecy flag from SSLConfig. Fixed
SSLServerSocketOpenSSL to trim the list of cipher suites used in BoringSSL.

BUG=481163

Review URL: https://codereview.chromium.org/1138813003

Cr-Commit-Position: refs/heads/master@{#329528}

BUG=457566

Review URL: https://codereview.chromium.org/1133303003

Cr-Commit-Position: refs/heads/master@{#329527}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/80f95a7..f0a5894

TBR=dpranke@chromium.org,alancutter@chromium.org

Review URL: https://codereview.chromium.org/1141573004

Cr-Commit-Position: refs/heads/master@{#329526}

The software compositor's canvas is only used between BeginPaint and EndPaint. Those happen consecutively for a compositor, so we can share a single buffer to back multiple canvases, one per compositor. This cuts down on memory used to that necessary to contain just the largest window of the process.

Review URL: https://codereview.chromium.org/1132133004

Cr-Commit-Position: refs/heads/master@{#329525}

This removes the TEXTURE_2D target and normalized coordinates
assumption from the YUVVideoQuad code. This is a prerequisite
to using IOSurface/SurfaceTexture backed GpuMemoryBuffers for
zero-copy transfer of software decoded video frames to the
graphics hardware.

BUG=485859
TEST=cc_unittests --gtest_filter=VideoGLRendererPixelTest.*

Review URL: https://codereview.chromium.org/1131253003

Cr-Commit-Position: refs/heads/master@{#329524}

BUG=483212

Review URL: https://codereview.chromium.org/1140823004

Cr-Commit-Position: refs/heads/master@{#329523}

This has likely been failing for a while, just noticed on my latest
try job.

BUG=none
TEST=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/1132233003

Cr-Commit-Position: refs/heads/master@{#329522}

This should have been part of https://codereview.chromium.org/1094103003

TBR=ncbray
BUG=479262

Review URL: https://codereview.chromium.org/1116223005

Cr-Commit-Position: refs/heads/master@{#329521}

Follow-on CL for https://codereview.chromium.org/1130793006/

BUG=

Review URL: https://codereview.chromium.org/1128213003

Cr-Commit-Position: refs/heads/master@{#329520}

BUG=

Review URL: https://codereview.chromium.org/1137513004

Cr-Commit-Position: refs/heads/master@{#329519}

The rv == 1 case was getting a little unwieldy. This should hopefully be
simpler. DoHandshake converts the error to a net error code and decides which
state to transition to. DoHandshakeComplete handles the result of the
handshake.

BUG=none

Review URL: https://codereview.chromium.org/1126113004

Cr-Commit-Position: refs/heads/master@{#329518}

Due to sandbox restrictions and for the sake of code simplicity, we have
to specify the directory in two environment variables:
SANITIZER_COVERAGE_DIR=XXX
and
ASAN_OPTIONS=coverage=1:coverage_dir="XXX"

This CL supercedes https://codereview.chromium.org/1113013003/

R=timurrrr@chromium.org,cpu@chromium.org
BUG=430156

Review URL: https://codereview.chromium.org/1140653002

Cr-Commit-Position: refs/heads/master@{#329517}

Idea here is to try and protect our scoped handles so that any third party close/accidental close could be some what restricted.

Besides adding flag following changes are in this CL.
1. While launching test process (Python executable), we pass it a pipe handle which we add it to ScopedHandle before passing, this marked handle as protected, now when we let python process inherit that handle, python process cannot close it and throws exception. We now duplicate handle without protection and then pass it onto python process and let host process continue with protected scoped handle.
2. Other change is related to disabling of active verifier dynamically. If ActiveVerifier gets invoked before disabling it (because someone used scoped handle before instruction pointer reached to UseHooks/InstallCloseHandleHooks) then it protects handle from closing. If now we disable ActiveVerifier when scoped handle goes out of scope, it tries to stop tracking handle, but in this case as active verifier got disabled later, that particular handle remains protected. Now we don't disable active verifier dynamically, but just decide on setting up of CloseHandleHook based on certain parameters.

BUG=475872
R=cpu@chromium.org,rvargas@chromium.org

Review URL: https://codereview.chromium.org/1113063004

Cr-Commit-Position: refs/heads/master@{#329516}

BUG=

NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/1140823005

Cr-Commit-Position: refs/heads/master@{#329515}

As ResourceBundle uses the scale factor we gate loading until we know
the scale factor.

I also made it so ViewportMetrics::device_scale_factor is 0 until we have a real value. This way ViewManager clients have a way to know when the real value is available.

BUG=none
TEST=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/1136743003

Cr-Commit-Position: refs/heads/master@{#329514}

This is https://codereview.chromium.org/1082973004 ported to chrome.

BUG=none
TEST=none
R=viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/1139973002

Cr-Commit-Position: refs/heads/master@{#329513}

Return the NetworkError if the connectGATT fails.

This is the second of two patches to implement NetworkError:
  [1] https://codereview.chromium.org/1124973003
  [2] This patch.

BUG=484779

Review URL: https://codereview.chromium.org/1118053003

Cr-Commit-Position: refs/heads/master@{#329512}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/d995009..dd4e568

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/1132993005

Cr-Commit-Position: refs/heads/master@{#329511}

This restricts the test apk's resources to just be those not already
included in the tested apk. Because GN apk targets typically don't
include java of their own, this requires supporting javac+jar for the
case where there is no java files.

Fixes deps so that chrome_shell_test_apk actually builds.

TBR=nyquist,dalecurtis,cbentzel

BUG=359249

Review URL: https://codereview.chromium.org/1127233005

Cr-Commit-Position: refs/heads/master@{#329510}

Serve the build dir when origin is 'localhost'.
(so runners can access those output dir .mojos)
Build apptests and runner apk for mandoline:all.

BUG=486220
TEST=For Android: clobber, build mandoline:all; apptests can run.
R=sky@chromium.org

Review URL: https://codereview.chromium.org/1138933004

Cr-Commit-Position: refs/heads/master@{#329509}

Revert of Have Notifications appear over docked windows (patchset #4 id:60001 of https://codereview.chromium.org/1121893004/)

Reason for revert:
varkha@ noticed that this change will cause the virtual keyboard to obscure the notifications. Which I confirmed on my local branch.

Reverting before the regression is released.

I'll work on a followup change that also accounts for the keyboard region.

Original issue's description:
> Have Notifications appear over docked windows
>
> Update AshPopupAlignmentDelegate calculations of its work area.
>
> When windows are docked this reduces the work area for windows.
> AshPopupAlignmentDelegate uses the work area to determine the positioning of
> notifications. Update this calculation to include the docked region.
>
> TEST=AshPopupAlignmentDelegateTest.DockedWindow
> BUG=284574
>
> Committed: https://crrev.com/5b4e72c6ad0924d64d5eb9a10e063bc9334e95b2
> Cr-Commit-Position: refs/heads/master@{#329486}

TBR=oshima@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=284574

Review URL: https://codereview.chromium.org/1135323002

Cr-Commit-Position: refs/heads/master@{#329508}

The delay to start updating the wallpaper after rotating the screen used
to be 2 seconds which was also accompanied by unnecessary clearing of
the wallpaper cache resulting in an ugly visual effect.

Now we reduced the delay to only 100 ms and we only clear the cache when
we add another display.

BUG=359654
TEST=manual

Review URL: https://codereview.chromium.org/1131243006

Cr-Commit-Position: refs/heads/master@{#329507}

This creates an android_hooks.cc file, which we could currently share,
but probably won't want to long term, as every time we add something to
core_services, we'll have to merge their implementation in.

BUG=477435

Review URL: https://codereview.chromium.org/1133543005

Cr-Commit-Position: refs/heads/master@{#329506}

BUG=

Review URL: https://codereview.chromium.org/1128723004

Cr-Commit-Position: refs/heads/master@{#329505}

Revert of Roll src/third_party/boringssl/src 68de407:de12d6c (patchset #3 id:40001 of https://codereview.chromium.org/1132443004/)

Reason for revert:
http://build.chromium.org/p/chromium.linux/builders/Android%20Arm64%20Builder%20%28dbg%29/builds/17339

Decent chance this will need to be re-uploaded manually, but let's see...

Original issue's description:
> Roll src/third_party/boringssl/src 68de407:de12d6c
>
> Summary of changes available at:
> https://boringssl.googlesource.com/boringssl/+log/68de407..de12d6c
>
> This also removes update_gypi_and_asm.py in favor of the script inside
> BoringSSL proper.
>
> BUG=none
>
> Committed: https://crrev.com/45248985036de1238c29d195b583797319a7020f
> Cr-Commit-Position: refs/heads/master@{#329500}

TBR=agl@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=none

Review URL: https://codereview.chromium.org/1128293004

Cr-Commit-Position: refs/heads/master@{#329504}

After this patch, "./tools/perf/run_benchmark smoothness_key_silk_cases" will
list out "smoothness.key_silk_cases" as the top matched benchmark.

BUG=482090

Review URL: https://codereview.chromium.org/1138933003

Cr-Commit-Position: refs/heads/master@{#329503}

In those cases |node| should not be NULL.

R=sky@chromium.org

Review URL: https://codereview.chromium.org/1124103005

Cr-Commit-Position: refs/heads/master@{#329502}

Also removes some outdated histograms that weren't supposed to be in the
public histogram list.  See bug 18595525.

BUG=20493841

Review URL: https://codereview.chromium.org/1131673008

Cr-Commit-Position: refs/heads/master@{#329501}

Summary of changes available at:
https://boringssl.googlesource.com/boringssl/+log/68de407..de12d6c

This also removes update_gypi_and_asm.py in favor of the script inside
BoringSSL proper.

BUG=none

Review URL: https://codereview.chromium.org/1132443004

Cr-Commit-Position: refs/heads/master@{#329500}

BUG=486575

Review URL: https://codereview.chromium.org/1132333003

Cr-Commit-Position: refs/heads/master@{#329499}

Follow-up to https://codereview.chromium.org/1128153003/. Rather than query all
keys and checking the slot afterwards, just look up keys in the slot directly.

BUG=478777

Review URL: https://codereview.chromium.org/1139533002

Cr-Commit-Position: refs/heads/master@{#329498}

BUG=369661
TEST=No whammies!

Review URL: https://codereview.chromium.org/1136663004

Cr-Commit-Position: refs/heads/master@{#329497}

Chrome Apps cannot switch UI language, so we need to initialize apps after
app_locale is set correctly.

This CL splits ProfileImpl::OnPrefsLoaded into two steps
(the former and OnLocaleReady), adding intermediate call
to switch to correct locale. Also Profile is added as
parameter to InputMethodChanged() observers.
chromeos::locale_util::SwitchLanguage() now updates default
input methods for user profile, not currently active set.

TBR=dmazzoni@chromium.org

BUG=469268
TEST=manual

Review URL: https://codereview.chromium.org/1055863002

Cr-Commit-Position: refs/heads/master@{#329496}

BUG=177163

Review URL: https://codereview.chromium.org/1128253005

Cr-Commit-Position: refs/heads/master@{#329495}

supported in cronet to fix a crash bug in cronet.

BUG=487355
R=mef@chromium.org, rch@chromium.org

Review URL: https://codereview.chromium.org/1138943002

Cr-Commit-Position: refs/heads/master@{#329494}

SPDY's multiplexing is incompatible with the renego + client auth hack. The old
implementation also assumed that the SpdyStream was still alive which isn't
true. We could attempt save a copy of it, but that doesn't resolve the
fundamental incompatibility of the hack. Instead
https://codereview.chromium.org/1131763002/ disables renegotiation, so this
codepath should be impossible.

BUG=462283

Review URL: https://codereview.chromium.org/1128873008

Cr-Commit-Position: refs/heads/master@{#329493}

I think this regressed due to:
https://codereview.chromium.org/1119923002

BUG=486851

Review URL: https://codereview.chromium.org/1141573003

Cr-Commit-Position: refs/heads/master@{#329492}

That state isn't needed. When an operation fails in OpenSSL, SSL_get_error
tells you exactly what event it was waiting for.

BUG=none

Review URL: https://codereview.chromium.org/1136813002

Cr-Commit-Position: refs/heads/master@{#329491}