- 29 May, 2019 40 commits
-
-
Sylvain Defresne authored
Bump expiration date of Signin.AccountTracker.CountOfLoadedAccounts and Signin.AccountTracker.GaiaIdMigrationState by four releases (or about six month). Bug: 960028 Change-Id: Ie168fb5cc5b972555a92e41073c34679900037bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634741 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#664268}
-
Alexei Svitkine authored
The parameters were not really being used. VariationsService has been using its own separate expiry logic. This should also speed up start up, as we no longer have to do any time function calls when a field trial gets created by VariationsService. With this change, FieldTrialList no longer calls some time functions as part of start up, which was being relied on by libc time function interception in sandboxed child processes. This change makes the interception an explicit part of child process start time rather than something that gets triggered by the first use of libc time functions. This is needed as otherwise the first time function call would be too late and would crash due to sandbox restrictions. TBR=rohitrao@chromium.org,spang@chromium.org,hansberry@chromium.org,mathp@chromium.org,jorgelo@chromium.org Bug: 957743 Change-Id: I1ff94df1ffade2b46bc19d984300b2b26dc0a06f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618025 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#664267}
-
jonross authored
conformance/textures/image_bitmap_from_video/tex-2d-rgba-rgba-unsigned_short_5_5_5_1.html has begun to demonstrate the same error as in crbug.com/891456 I'm marking it as RetryOnFailure. TBR=ynovikov@chromium.org Bug: 891456 Change-Id: I557903f2abb983323603c1849e3ff6ed014cfd6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635289Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#664266}
-
Huanzhong Huang authored
Change of strings related to the new Clear Browsing Data dialog. The change is to make these strings aligned with their Desktop/Android counterparts (with the iOS capitalization rules applied). Bug: 642334 Change-Id: I9186a305efe2be1c01d38b8f22f0d078f96a5a44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631649Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> Cr-Commit-Position: refs/heads/master@{#664265}
-
Martin Robinson authored
AtkText messages should only be sent when something actually changes. Bug: 961736 Change-Id: I2c53956de0e69ee2caff9b520f8b489158d9a24e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634857Reviewed-by:
Joanmarie Diggs <jdiggs@igalia.com> Commit-Queue: Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#664264}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1ad4771e88a5..262e28248477 git log 1ad4771e88a5..262e28248477 --date=short --no-merges --format='%ad %ae %s' 2019-05-29 aleino@nvidia.com Use D3D11 GetDimensions driver workaround for 3D textures Created with: gclient setdep -r src/third_party/angle@262e28248477 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@google.com Change-Id: I171e7a61addbd7998612eec98aeb557a0c097fa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634955Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664263}
-
arthursonzogni authored
Check what process is used when a subframe is being navigated to about:blank. The current behavior is to make the new document live in the process of the navigation's initiator. Bug: None. Change-Id: Iaa6184c11975f708a807fd877da05a8625121a41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619804 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#664262}
-
Michael Hablich authored
This is a roll-back to 7.6.303. This is the most stable candidate out of the latest Canaries. If this commit results in failures in Blink please contact the Blink sheriff. They may need to make changes to Blink because of the roll-back. When in doubt please try to contact the committer and reviewers of this CL before reverting it. TBR=machenbach@chromium.org Change-Id: I8e35e4b5d9793db31fb1001d26ec78f9b915e0e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634836Reviewed-by:
Michael Hablich <hablich@chromium.org> Commit-Queue: Michael Hablich <hablich@chromium.org> Cr-Commit-Position: refs/heads/master@{#664261}
-
Ben Kelly authored
In order to support moving CacheStorage off the IO thread this CL removes the assumption that all CacheStorageContextImpl::Observer objects are added on the IO thread. This is achieved by using the base::ObserverListThreadSafe class. This CL also refactors the code to store observers in the context even if the manager is still responsible for notifying them. This will allow us to keep all cross-sequence activity in the context and make the manager simpler. Bug: 960012 Change-Id: I7b9c03ac1378d4cdacf77e108d98f815aa6418b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626492Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#664260}
-
Mark Cogan authored
This CL consolidates the use of the existing webui/ directory in //ios/web/public. - All of the files in this directory get their own BUILD file, which is not transitively exposed from //ios/web/public:public. - All necessary BUILD files have their deps updated; in many cases these files were also relying on transitive public deps for //net (!). - .cc files in ios/web/public/webui/ are moved into /ios/web/webui/ - a couple of files in //ios/web/public/ are moved into webui/. Bug: 942244 Change-Id: I3d4be502c4808440d552f9e87e79a4f9f548fa7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634858 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Yi Su <mrsuyi@chromium.org> Auto-Submit: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#664259}
-
Nico Weber authored
Ship (and build) fewer archs on mac: - Stop shipping 32-bit intel for maOS, we've only been shipping 64-bit chrome for years. - Stop shipping armv7k, which I think is only used on Apple Watch (?) Build fewer things we don't ship or need: - Don't need to build CRT or XRAY anywhere - Don't need to build builtins lib for linux, win, android - Don't need to build libfuzzer for android, fuchsia - Don't need to build libprofile, sanitizers for fuchsia - Don't need to build ARM and Aarch64 targets for bootstrap compiler on non-mac (This also means we stop shipping the xray headers. Since we don't ship the xray runtime lib, that shouldn't be a problem.) The intention is that this is a non-event. If this disturbs some build configuration I don't know about, please let me know and we can roll parts of this back. On macOS, the main build goes from 7868 to 7200 build steps, package size from 26.54MB to 26.21MB. Stage 1 is unmodified. On Linux, the stage 1 build goes from 2745 to 2586 build steps and stage 1 number of tests go from 38502 to 33398. The main build goes from 4253 build steps to 3924. The numbers on Windows are comparable to Linux (2726 -> 2567, 36495 -> 31633, 3600 -> 3455). Despite the reduction in build steps, builds on the bots don't seem to get noticeably faster. Bug: 959966 Change-Id: I177e06f4d97d811a651acad8af2163589f1c9d86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629950 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#664258}
-
Carlos Caballero authored
BEST_EFFORT tasks will not run until after startup and only if there is no critical work pending. This patch should not change the current behaviour. Please double check whether the task being posted via BrowserThread::PostAfterStartupTask really cares about being run after startup or just wants to run after any critical work was completed. If you are fine with it just running after critical work has completed LGTM and keep on with your life. If that is not the case let me know and please explain your reasoning in a comment. More details: https://docs.google.com/document/d/1P8PV1qX2cOR2WRFD6v9CjygJkE_mftCtJ7BoqQHCKZI This CL was uploaded by git cl split. R=gab@chromium.org Bug: 887407 Change-Id: I53590207fdc1ac8e47bce40a2da0f42674c4966e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632223 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Auto-Submit: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#664257}
-
Mohammad Refaat authored
The last observer method in BrowserViewWrangler was didChangeTab. To remove it we need to keep track of current visible url of the active tab for the device share manager (used for handoff feature.). 2 things need to be tracked to achieve that: 1- Switching between the active webState. -> Already done by didChangeActiveWebState of WebStateListObserver 2- Navigations done on the active WebState. (This CL) -> BrowserViewWrangler will implement didFinishNavigation of CRWWebStateObserver to update the device share manager (using CRWWebStateObserverBridge). And attach the observer to the active WebState using the ActiveWebStateObservationForwarder. Bug: 911350 Change-Id: I0c9b52b84978f717a34a186ef7ac531eb4434f45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628007 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/633db4db7672..bfa8767bb25c git log 633db4db7672..bfa8767bb25c --date=short --no-merges --format='%ad %ae %s' 2019-05-29 herb@google.com Move source space fallback strike calculations to SkStrikeSpecStorage Created with: gclient setdep -r src/third_party/skia@bfa8767bb25c The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Change-Id: I77762a89a23e499b7d0b50a50e192c50390c6e86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634953Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/24c961c98efd..f59507fccef1 Created with: gclient setdep -r src-internal@f59507fccef1 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=ricea@google.com,jeffreycohen@google.com,seblalancette@google.com,mkwst@google.com Change-Id: I84296aa75ea906c424bf6bac6521ad809a3c8336 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635210Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664254}
-
Qingsi Wang authored
Bug: None Change-Id: I6df50a94ba15c12652aba3556bd2030d2fe6307b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632668 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#664253}
-
Mason Freed authored
This patch adds a field trial testing config for FastBorderRadius. Bug: 947715 Change-Id: Iff94fdce62a195ead91bf338b40df0380a9aab5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632829 Commit-Queue: Robert Kaplow (slow) <rkaplow@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/98266a4af182..e8e7d7b0bc10 git log 98266a4af182..e8e7d7b0bc10 --date=short --no-merges --format='%ad %ae %s' 2019-05-29 jonaso@webrtc.org Move Connection into it's own .h/.cc file. 2019-05-29 mirtad@webrtc.org Move H.264 SPS VUI rewriting to FrameEncodeMetadataWriter. 2019-05-29 kwiberg@webrtc.org WebRTC Opus C interface: Add support for non-48 kHz decode sample rate 2019-05-29 titovartem@webrtc.org Propagate screenshare info into video track and it's source. Created with: gclient setdep -r src/third_party/webrtc@e8e7d7b0bc10 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I0de0c441d9c79569782813412a4f5f7c7490275e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634952Reviewed-by:
-
Polina Bondarenko authored
Log a netwrok error if PerformWebRequest fails. BUG=b:133770869 TEST=build Change-Id: Iaa3f7dadc916fa184370b8dea769030f56aedb0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634693Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Polina Bondarenko <pbond@chromium.org> Auto-Submit: Polina Bondarenko <pbond@chromium.org> Cr-Commit-Position: refs/heads/master@{#664250}
-
Kevin Ellis authored
The patch addresses cases where timeline-dependent code was being called without first checking for an active timeline. Bug: 967507, 967509 Change-Id: I4383bf5cdbcc8dd92e52c4e281d89d3efd36bd83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632615 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#664249}
-
Yi Su authored
This CL removes the temporary source file items in //ios/web/public/BUILD.gn that were kept to avoid brekaing ios_internal. Since the dependency chain in ios_internal has been updated, these items can be removed now. Bug: 942244,956511 Change-Id: I76153ec5e2f5407299e2c14ec51de9a429619e5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634859Reviewed-by:
-
Roman Sorokin authored
* Also extracted oobe_screens_utils * Also extracted ExitHandler for enrollment screen Bug: 966887 Change-Id: Ic07357323012944c5c6ec017f4bae129219a91ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628726Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#664247}
-
jdragonbae authored
OnAddressListChanged, OnCreditCardsChanged Instead it should have a single OnPersonalDataChanged call Bug: 923868 Change-Id: Ie6bc51cf71f82228df32db551489bf66168a54e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631451 Commit-Queue: sebsg <sebsg@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Auto-Submit: Jaeyong Bae <jdragon.bae@gmail.com> Cr-Commit-Position: refs/heads/master@{#664246}
-
Dominic Battre authored
Bug: 967588 Change-Id: I92bea6a15e96ee09e129467938e0bbc2b45b8de7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631662 Commit-Queue: Dominic Battré <battre@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Auto-Submit: Dominic Battré <battre@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#664245}
-
Roman Aleksandrov authored
Update text about data handling. Bug: 959262 Change-Id: I2d25037d87d33c1eb8f964f23da6b0fcae0bc9c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613254Reviewed-by:
Thiemo Nagel <tnagel@chromium.org> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#664244}
-
Michael van Ouwerkerk authored
Also clean up some redundant code and use lambdas. Bug: 931198 Change-Id: I8a30a6ead0e573fb0ed2f7bd0e46a5376cc5720a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632229 Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#664243}
-
Balazs Engedy authored
This is a reland of 19c977cb. The original CL incorrectly assumed that Blink has a built-in mechanism such that marking `ondevicemotion` as [SecureContext] would implicitly result in calls to `window.addEventHandler('devicemotion', ...)` being ignored when made from non-secure browsing contexts. However, in reality there is no coupling between the event handler IDLs and event types accepted by `addEventListener()`, in fact, there is no validation of event types at all, EventListenerObserver::DidAddEventListener will be dispatched to all observers, even for made up event type names. This CL updates DeviceMotionController and friends to expect this and simply return early if an event listener was added in a non-secure context. Web tests have also been added to verify this behavior and that there are no crashes. Original change's description: > Mark Device Orientation API event handlers as [SecureContext]. > > This CL concludes the work to restrict the API to secure browsing contexts. > It removes the `RestrictDeviceSensorEventsToSecureContexts` flag that could > previously be disabled manually to re-enable the API in non-secure contexts, > tests that verified the behavior with this flag disabled, as well as all > deprecation warnings. > > Bug: 932078 > Change-Id: I742ab162e97017e47b44dfe72e99ef9c24178b36 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632329 > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Balazs Engedy <engedy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#664180} Bug: 932078 Change-Id: I40f1e1b6e1deac2bd4387366ace10dc7e8f69e2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634877Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#664242}
-
Julie Jeongeun Kim authored
This CL is a part of onion-souping web_application_cache_host_impl. It moves web_application_cache_host_impl.cc/h, renderer_webapplicationcachehost_impl.cc/h and application_cache_host_for_shared_worker.cc/h to third_party/blink/renderer/core/exported/. For moving them, it adds some interfaces, 1) WebLocalFrameClient::UpdateSubresourceFactory 2) Platform::IsSchemeSupportedForAppCache 3) WebApplicationCacheHost::CreateWebApplicationCacheHostFor{Frame, SharedWorker} Once onion-souping web_application_cache_host_impl is finished, CreateWebApplicationCacheHostFor{Frame, SharedWorker} will be removed. Bug: 950159 Change-Id: I9660fc00f9e15cfbbfc263cb828afdfd5b3ee03e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575057 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by:Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/673784153395..98266a4af182 git log 673784153395..98266a4af182 --date=short --no-merges --format='%ad %ae %s' 2019-05-29 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 99181c0b..d4906ebd (664078:664184) Created with: gclient setdep -r src/third_party/webrtc@98266a4af182 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I187247b7eae1a4035a289a56ba701dc142ea2970 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634550Reviewed-by:
-
Friedrich Horschig authored
This CL wires the AddressAccessoryController implementation to the UI component which effectively displays Addresses in a bottom sheet. To retrieve the data, the ManualFilling controller will poll the data when another event triggers a UI update. This definitely overtriggers since the password manager updates data for every field while address data may remain stable for the whole lifetime of a tab. Bug: 962548 Change-Id: I52900abd82b0e8773b25f906231c7db7dd9ec31c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614202 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#664239}
-
Alex Chau authored
- Added a skeleton of SharingService with 3 APIs, implementation is empty for now - Added a proto for SharingMessage - Added definition of handler for SharingMessage - SharingService is initialized with a profile - Added OWNERS file Bug: 966028 Change-Id: I8beb1d001b8186b7259c7421f6d6d906bcf4a2f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627367 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Auto-Submit: Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#664238}
-
Chromium WPT Sync authored
Using wpt-import in Chromium fedd9a22. With Chromium commits locally applied on WPT: e90c6ef0 "NG/DL: Implement size containment (and display lock) for NG fieldset algo" be76d09e "[ServiceWorker] Reject update() from within installing workers" abf2ac5e "webrtc wpt: avoid race conditions" d9a6ec05 "[MediaStreamTrack] Remove tests and existing support for the 'volume' property." 0882bebe "Change ICE connection state on transceiver changes" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I115f1808854c75850386291d4932cfcbbf4efdf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634711Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664237}
-
arthursonzogni authored
On Android. TBR=kinuko@chromium.org CC=rsorokin@chromium.org Bug: 966820 Change-Id: If3ce3ecb3f65a370a630f8fc0a1d641f51278e1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634698Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#664236}
-
Dominic Battré authored
This reverts commit 5750ecde. Reason for revert: Test faked again in https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/91959 but did not produce usable screenshots. Original change's description: > Enable screenshotting for AutofillInteractiveTests > > A bunch of interactive_ui_tests from AutofillInteractiveTests.* are flakily > timing out on the win7 builders. This CL enables pixel outputs. Hopefully that > reveals why the tests time out. > > Bug: 967588 > Change-Id: Icc6296fbb324fe0e2920807afa6a6ceea121b691 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632330 > Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> > Auto-Submit: Dominic Battré <battre@chromium.org> > Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#663822} TBR=battre@chromium.org,ftirelo@chromium.org Change-Id: Ib98f0fd43cd1c5dd0784b6b342589109e2521e47 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 967588 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634835Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#664235}
-
Arthur Hemery authored
When navigating back to a frame that has subframes, we should try to restore the subframes to their latest history item. This is currently done by OpenURL and should be done by BeginNavigation instead. Design doc: https://docs.google.com/document/d/13Rqdg1HBmtfnYMUXvg7SpUl3bJisTElfyMc1Ze8hLdE/edit# This is patch 2/2. This patch only modifies the behavior for IsPerNavigationMojoInterface on. See https://chromium-review.googlesource.com/c/chromium/src/+/1596448 for trybots run with the flag on. Bug: 962518 Change-Id: If153cbcb8e1d11bd75be519839c7f36c3907b1dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594576 Commit-Queue: Arthur Hemery <ahemery@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#664234}
-
Vadym Doroshenko authored
For HttpAuth NewPasswordFormManager needs only FormDigest, let's make it accept FormDigest instead of whole form. Bug: 831123 Change-Id: I3ba1abe0db5516fa9ff671d77b97099e0330d49a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634696 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
-
A Olsen authored
The RecheckTask, which only had one ability - it could be cancelled by InvalidateWeakPtrs - is expanded into the Rechecker class, which now contains much of the logic of the saml_password_expiration_notification.cc It still works on much the same lines as previously - only one ever exists at a time (for the primary user), weak pointer invalidation ensures that not too many tasks are posted, and each time it wakes up, it checks to see what has changed and shows a notification / posts a new task for the future. However, it now also listens to lock screen events for the primary user. This will allow us to pop up the notification again immediately after screen unlock, which is a good time for the user to update their password if required. This will be done in a follow up CL. Bug: 930109 Change-Id: Id3d3c238251e4e59ee986fc944b461d966eefa5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631699Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: A Olsen <olsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#664232}
-
Maksim Ivanov authored
Embed all screen_gaia_signin's contents (which is responsible for Gaia/SAML/offline/SAML interstitial/AD authentication) into a Polymer module. This is a first step in the refactoring of screen_gaia_signin from the old-style login.createScreen-based implementation onto the new Polymer-based approach. Bug: 964069 Test: manual Change-Id: I69e079d1d8e6c3c9ecbe08dfb59f397168cbf187 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615744 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
-
Eric Willigers authored
The following shorthand properties now allow any 1 or 2 of the 3 values (width, style, color) to be omitted: - border-block - border-block-start - border-block-end - border-inline - border-inline-start - border-inline-end https://drafts.csswg.org/css-logical-1/#border-shorthands Value: <'...-width'> || <'...-style'> || <color> Bug: 968057 Change-Id: I571ccf0e8bea38d985a96cf3cccf49d7adfe4d76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635169 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#664230}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/82c5fe1de06e..24c961c98efd Created with: gclient setdep -r src-internal@24c961c98efd The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=ricea@google.com,jeffreycohen@google.com,seblalancette@google.com,mkwst@google.com Change-Id: Ice27c73408614377953589b7afcc84fc2c2b7624 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635190Reviewed-by:
-
