GitLab

BUG=596760

Review-Url: https://codereview.chromium.org/2623143006
Cr-Commit-Position: refs/heads/master@{#443377}

Review-Url: https://codereview.chromium.org/2625913002
Cr-Commit-Position: refs/heads/master@{#443376}

BUG=none

Review-Url: https://codereview.chromium.org/2625873003
Cr-Commit-Position: refs/heads/master@{#443375}

BUG=646864
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2627793003
Cr-Commit-Position: refs/heads/master@{#443374}

This is needed for to correctly enabled variations seed
fetching after backup & restore in conjunction with this
CL: https://codereview.chromium.org/2614183002

BUG=669543

Review-Url: https://codereview.chromium.org/2621413008
Cr-Commit-Position: refs/heads/master@{#443373}

Revert of Enable viewing render tests results on buildbot on Android FYI bot. (patchset #1 id:1 of https://codereview.chromium.org/2625673003/ )

Reason for revert:
Reverting since the FYI bot seems to be having trouble running chrome_public_test_apk (seems like device or adb issue). Enabled this on another bot (M tester on chromium.android).

Original issue's description:
> Enable viewing render tests results on buildbot on Android FYI bot.
>
> Adding example test with render tests to FYI bot. If everything
> works as intended, will enable this on all bots. Will also switch
> implementation from needing to be configured by manually setting
> render_results_dir to detecting the render_results_dir automatically.

TBR=dpranke@chromium.org,mikecase@google.com
# Not skipping CQ checks because original CL landed more than 1 days ago.

Review-Url: https://codereview.chromium.org/2629523005
Cr-Commit-Position: refs/heads/master@{#443372}

This is a no-op for our bindings but it keeps us in sync with the spec.

BUG=None
R=zqzhang@chromium.org

Review-Url: https://codereview.chromium.org/2627283002
Cr-Commit-Position: refs/heads/master@{#443371}

<base> has cropped up in some recent attacks, and maybe it's possible to
tweak things a little bit to make it play better with the platform at
large. Let's find out, shall we?

BUG=679318

Review-Url: https://codereview.chromium.org/2626243002
Cr-Commit-Position: refs/heads/master@{#443370}

Support for position:relative was added back in early 2011, in
23fab7d4, but the comment was never
updated to reflect the new code.

BUG=679759

Review-Url: https://codereview.chromium.org/2625723002
Cr-Commit-Position: refs/heads/master@{#443369}

HpackDecoderState listens to HpackWholeEntryBuffer, resolves indices
into the HPACK static and dynamic tables, updates the dynamic table as
appropriate, and reports fully decoded header entries to an
HpackDecoderListener instance.

This CL lands server change 130407086 by jamessynge.

BUG=488484

Review-Url: https://codereview.chromium.org/2619043003
Cr-Commit-Position: refs/heads/master@{#443368}

Change the LayoutUnit implementation to use base::saturated_cast instead of WTF
::clampTo as the former is much more efficient. Also removes clampToLayoutUnit.

R=pdr@chromium.org

Review-Url: https://codereview.chromium.org/2615713007
Cr-Commit-Position: refs/heads/master@{#443367}

When switching from pending to activated state, there is no need to do
more animations as the final state of animations for these states are
the same. Otherwise, janks on slow devices might create some unwanted
effects like double ripples.

BUG=670831
TEST=manual

Review-Url: https://codereview.chromium.org/2615613003
Cr-Commit-Position: refs/heads/master@{#443366}

This is a new mechanism, replacing the previous technique of subclassing
SkDevice.

BUG=675977

Review-Url: https://codereview.chromium.org/2629523004
Cr-Commit-Position: refs/heads/master@{#443365}

Previously, they were only shown when the corresponding datatype was
checked. This led to uneven spacing between checkboxes and arguably
strange visual behavior where text was appearing and disappearing.

See the linked bug for screenshots.

BUG=654812
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2623033003
Cr-Commit-Position: refs/heads/master@{#443364}

https://skia.googlesource.com/skia.git/+log/90ee03b0d177..b621a35b436b

$ git log 90ee03b0d..b621a35b4 --date=short --no-merges --format='%ad %ae %s'
2017-01-12 mtklein drop depot_tools dependency in bin/fetch-gn
2017-01-12 halcanary rm -r {include,src}/animator
2017-01-12 halcanary cleanup after 95e3c05
2017-01-12 msarett Fix tool with swapped fC, fE (SkColorSpaceTransferFn)
2017-01-12 msarett Use RasterPipeline to support full precision on 16-bit RGBA pngs

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=kjlubick@google.com

Review-Url: https://codereview.chromium.org/2633523002
Cr-Commit-Position: refs/heads/master@{#443363}

The various programs stored in GLRenderer are 5-dimensional arrays,
and adding color conversion to them would require adding a 6th
dimension.

Create a ProgramKey structure that uniquely identifies a program, and
create a single unordered_map to cache programs.

Gut all off the GLRenderer::Get*Program* functions, to just call a
common GLRenderer::GetProgram function, which takes this key.

Adding color conversion will now just consist of adding a new field to
the ProgramKey structure. Before we do that, we'll remove all of the
(now-stub) GLRenderer::Get*Program* functions, and have the callers
all call GLRenderer::GetProgram.

BUG=667966
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2613903002
Cr-Commit-Position: refs/heads/master@{#443362}

Make sure the active URL is correctly set for crash reports.

BUG=643746, 630895

Review-Url: https://codereview.chromium.org/2622073005
Cr-Commit-Position: refs/heads/master@{#443361}

This will make it easier to land an upcoming ResourceHandler refactor,
and also gives us some more ASSERTs shared with other tests. Also add
checking of the error code the request is canceled with.

Also prevent next ResourceHandler in the chain from being called
re-entrantly

BUG=659317

Review-Url: https://codereview.chromium.org/2626663002
Cr-Commit-Position: refs/heads/master@{#443360}

The following traits are used:

Priority: Inherited (default)
  The priority is inherited from the calling context (i.e. TaskTraits
  are initialized with the priority of the current task).

Shutdown behavior: SKIP_ON_SHUTDOWN (default)
  Tasks posted with this mode that have not started executing at
  shutdown will never run. However, any task that has already begun
  executing when shutdown is invoked will be allowed to continue and
  will block shutdown until completion.

  Note: Previously, the task was posted to the blocking pool with
  BLOCK_SHUTDOWN (default in SequencedWorkerPool).

May Block:
  Tasks posted with MayBlock() may block. This includes but is not
  limited to tasks that wait on synchronous file I/O operations:
  read or write a file from disk, interact with a pipe or a socket,
  rename or delete a file, enumerate files in a directory, etc. This
  trait isn't required for the mere use of locks.

BUG=667892

Review-Url: https://codereview.chromium.org/2629003002
Cr-Commit-Position: refs/heads/master@{#443359}

CastContentWindowImpl is the implementation of CastContentWindow
now. Add a CastContentWindowAndroid specific for Android platform.

BUG=NONE
TEST=cast_shell_apk

Change-Id: I6092f733b54638256bd3028ac3d889f6b52a02fe
Review-Url: https://codereview.chromium.org/2570623003
Cr-Commit-Position: refs/heads/master@{#443358}

BUG=679905

Review-Url: https://codereview.chromium.org/2627093006
Cr-Commit-Position: refs/heads/master@{#443357}

And use it for SessionController interface.

BUG=648964

Review-Url: https://codereview.chromium.org/2617763003
Cr-Commit-Position: refs/heads/master@{#443356}

SkPaint now has refFoo() helpers which return sk_sp<> values.  We can
simplify some call sites.

BUG=skia:5077
R=reed@google.com
TBR=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2625403002
Cr-Commit-Position: refs/heads/master@{#443355}

BUG=none

Review-Url: https://codereview.chromium.org/2616403005
Cr-Commit-Position: refs/heads/master@{#443354}

base::Time::FromString() and base::Time::FromUTCString() might fail
at runtime on bad input. This adds a WARN_UNUSED_RESULT to their
declarations to ensure that all callers properly handle the result.

Apart from unit-tests, this changes two things:

- DataUseTracker::RemoveExpiredEntriesForPref() will also
  remove any entries with an invalid date string.

  This doesn't change the runtime behaviour though, because
  a failure in base::Time::FromUTCString() would keep the
  local |key_date| variable to 0, which would have been
  considered too old anyway.

- VariationsSeedStore::ImportFirstRunJavaSeed() has
  a new failure mode triggered by an invalid response
  date |FIRST_RUN_SEED_IMPORT_FAIL_INVALID_RESPONSE_DATE|

  It looks like the FirstRunResult enum values are only
  used on Android to report UMA metrics, so ensure that
  the new constant is added at the end of the list to
  avoid generating confusing histograms.

- PexeDownloader::didReceiveResponse() still ignores
  invalid HTTP response 'last-modified' header dates.
  As with RemoveExpiredEntriesForPref() this doesn't
  change the runtime behaviour, but it is hard to see
  whether this is desirable or dangerous.

- ConvertRequestValueToFileInfo() still ignores
  invalid date strings, as mentioned by the comment
  above the base::Time::FromString() line.

BUG=669625

Review-Url: https://codereview.chromium.org/2605293002
Cr-Commit-Position: refs/heads/master@{#443353}

For clients in a Precache trial group who've started a precache in the last 15
days, registers them in a matching group in the PrecacheSynthetic15D trial. For
those who've started a precache in the last 1 day, registers in them in the
PrecacheSynthetic1D trial also.

BUG=663987

Review-Url: https://codereview.chromium.org/2596093002
Cr-Commit-Position: refs/heads/master@{#443352}

https://chromium.googlesource.com/angle/angle.git/+log/008450b..417df92

BUG=

TBR=geofflang@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2625083005
Cr-Commit-Position: refs/heads/master@{#443351}

We can only generate 6 points for even non-convex quads.
It falls from the w component crossing 0 implies we have to remove
at least one corner for each 2 we add. We can only do that twice.
4 -> 3+2 -> 2+4 -> 1+2.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2627213002
Cr-Commit-Position: refs/heads/master@{#443350}

Currently, |updateAccounts()| is sometimes called multiple times in
AccountSigninView which results in multiple "update GMS" dialogs being
generated, and the user must click back three times for the dialogs to
disappear.

This CL changes signin to re-use existing dialogs where possible and
always remove old dialogs before creating a new one.

BUG=679851

Review-Url: https://codereview.chromium.org/2626083004
Cr-Commit-Position: refs/heads/master@{#443349}

Essentially a scroll node specific version of
http://crrev.com/2612093002 which was only omitted there
in the interest of incrementality.

BUG=674258
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2623313003
Cr-Commit-Position: refs/heads/master@{#443348}

This cleans up the async read pixel code a bit by using weak ptrs
instead of cancelable callbacks.

BUG=678234
TEST=cc_unittests
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2628883004
Cr-Commit-Position: refs/heads/master@{#443347}

BUG=634434

Review-Url: https://codereview.chromium.org/2622383002
Cr-Commit-Position: refs/heads/master@{#443346}

This was reverted due to crbug.com/679174 which is fixed by using the
browser action container view's |animationEndFrame| instead of its
frame when calculating the size of the location bar.

Browser actions will be reordered in a future change.

BUG=648558, 648563, 673362

Review-Url: https://codereview.chromium.org/2607533004
Cr-Commit-Position: refs/heads/master@{#441925}
Committed: https://chromium.googlesource.com/chromium/src/+/8b0fd02afc2107ba123774e0a464a43407a108cf

patch from issue 2607533004 at patchset 80001 (http://crrev.com/2607533004#ps80001)

Review-Url: https://codereview.chromium.org/2631463004
Cr-Commit-Position: refs/heads/master@{#443345}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/ed0540fbc6ef..290f611623b2

$ git log ed0540fbc..290f61162 --date=short --no-merges --format='%ad %ae %s'
2017-01-12 hjd [dashboard] Add addEventListener shim

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2631513005
Cr-Commit-Position: refs/heads/master@{#443344}

Use was removed in https://codereview.chromium.org/2462753002/

BUG=557406
TEST=Compiles
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2622423002
Cr-Commit-Position: refs/heads/master@{#443343}

Replaces a tdefault textured layer used for a shield with a solid color
layer.

BUG=537050
TEST=NONE - no visible change

Review-Url: https://codereview.chromium.org/2627153006
Cr-Commit-Position: refs/heads/master@{#443342}

This patch adds an ability to request an image decode from
the compositor. The caller should specify which image
(SkImage) to decode and a callback. In return, it gets an
id. When the image is decoded, the callback is issued with
this id. The decode is then kept alive for 2 compositor
frames.

Right now, only unittests are using this functionality.

R=enne@chromium.org, ericrk@chromium.org, danakj@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2537683002
Cr-Original-Commit-Position: refs/heads/master@{#443085}
Committed: https://chromium.googlesource.com/chromium/src/+/bb991d41668aa0f37aa6d6712e3bf9b52a5480ae
Review-Url: https://codereview.chromium.org/2537683002
Cr-Commit-Position: refs/heads/master@{#443341}

BUG=553459

Review-Url: https://codereview.chromium.org/2628893005
Cr-Commit-Position: refs/heads/master@{#443340}

This CL adds an ios_clean_chrome_unittests target and tests for the
public and internal APIs of BrowserCoordinator.

BUG=

Review-Url: https://codereview.chromium.org/2626033002
Cr-Commit-Position: refs/heads/master@{#443339}

BUG=677716
TEST=See bug for repro steps.

Review-Url: https://codereview.chromium.org/2624373002
Cr-Commit-Position: refs/heads/master@{#443338}