- 10 Nov, 2017 40 commits
- 
- 
Christian Dullweber authoredMove code from CBDTabCheckbox to CBDCheckbox. Replace View.OnTouchListener with lambda. Fully remove ClearBrowsingDataPreferencesTab.java. Bug: 777842 Change-Id: I57c668b5a82de74605d57b01647c6b7376cabe21 Reviewed-on: https://chromium-review.googlesource.com/758678 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#515534} 
- 
v8-autoroll authoredSummary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c8bfcb14..d117437e Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I872e49e728c0cd3699d11b0c54abbf47c9a288fa Reviewed-on: https://chromium-review.googlesource.com/763131Reviewed-by: v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#515533} 
- 
Anita Woodruff authored- Previously when users on O pressed the 'Clear and Reset' button to clear notification settings for a site, the permission could remain granted if it was granted on an older version of the browser, due to a bug in the migration of settings to notification channels. - This was because settings were never deleted from the PrefProvider either during the migration process or on clearing notification permission for a site. - Now we return false from NCPA::SetWebsiteSetting when clearing permission. - This means the HostContentSettingsMap continues to iterate through the content setting providers and clears the permission from the PrefProvider too if present. Bug: 781524 Change-Id: I883ee6ab0b70873c4157b545aeac3691bfb8a23f Reviewed-on: https://chromium-review.googlesource.com/758687Reviewed-by: Raymes Khoury <raymes@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Commit-Queue: Anita Woodruff <awdf@chromium.org> Cr-Commit-Position: refs/heads/master@{#515532} 
- 
Sheng-Hao Tsao authoredVaapiJpegEncodeAccelerator implements JpegEncodeAccelerator. It calls VaapiJpegEncoder to populate necessary VA buffers and submit them via VaapiWrapper. BUG=b:67488323 TEST=Tested on caroline that a YUV image can be successfully encoded. Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I532b06aa0a430fb14f891e8412282ec7dfaef0e3 Reviewed-on: https://chromium-review.googlesource.com/712134 Commit-Queue: Sheng-hao Tsao <shenghao@google.com> Reviewed-by: Pawel Osciak <posciak@chromium.org> Reviewed-by: Ricky Liang <jcliang@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#515531} 
- 
Takuto Ikuta authoredTo fix https://luci-milo.appspot.com/buildbot/tryserver.chromium.win/win7_chromium_rel_loc_exp/266 Bug: 779440 Change-Id: I234789b93011b9b959dfe71fda10e4ad1ab04dac Reviewed-on: https://chromium-review.googlesource.com/757839Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@google.com> Cr-Commit-Position: refs/heads/master@{#515530} 
- 
Per Kjellander authoredThis reverts commit a58c8bd6. Reason for revert: Tentative rollback to see if this caused problems with WebRtcAudioDebugRecordingsBrowserTest.CallWithAudioDebugRecordings on Windows 8 and 10. https://build.chromium.org/p/chromium.webrtc/builders/Win10%20Tester/builds/21971 Original change's description: > Serialize MediaStreamTrack.stop() with getUserMedia() > > When multiple getUserMedia and stop() requests are active concurrently, > getUserMedia() sometimes fails with TrackStartError. > The reason is that the underlying video capture subsystem does not keep > a count of how many sources have opened a video device. > It can happen that a stop request stops video capture while a > getUserMedia() request is being processed, with the result being that > the video device is closed before getUserMedia() starts the new video > track, resulting in an error. > > One solution to this problem is to make sure that stop requests and > getUserMedia() requests cannot run concurrently, which is the approach > followed by this CL. > > This CL basically moves handling of MediaStramTrack.stop() from > MediaStreamCenter to UserMediaClient, and puts stop() requests in the > same queue used for getUserMedia() and applyConstraints() requests. > > > Bug: 778039 > Change-Id: Id7e0ee38e40265fd599dc6dd0712f0b667d2e1a5 > Reviewed-on: https://chromium-review.googlesource.com/751981 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Henrik Boström <hbos@chromium.org> > Commit-Queue: Guido Urdaneta <guidou@chromium.org> > Cr-Commit-Position: refs/heads/master@{#515494} TBR=haraken@chromium.org,hbos@chromium.org,guidou@chromium.org Change-Id: I93abb79d9cd3abfe08d9c0473e8bcf0207db7b3a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 778039 Reviewed-on: https://chromium-review.googlesource.com/763487Reviewed-by: Per Kjellander <perkj@chromium.org> Commit-Queue: Per Kjellander <perkj@chromium.org> Cr-Commit-Position: refs/heads/master@{#515529} 
- 
Peter E Conn authoredThe blinking cursor in EditTexts should never be enabled for render tests. It doesn't add anything to the appearance and makes the tests flaky (as the appearance changes over time). This CL creates a sanitize method on RenderTestRule that can be used to strip such features from a View before it is rendered. Bug: 782311 Change-Id: I9d862c99814b30e78ce00f0ba254fefa0f586030 Reviewed-on: https://chromium-review.googlesource.com/758780 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#515528} 
- 
Henrik Boström authoredAdded to RTCPeerConnection-setRemoteDescription-tracks.https.html: - stream.onremovetrack should fire and the track removed from stream. Added RTCPeerConnection-setRemoteDescription-remove-tracks.https.html: - track.onmute should fire and the track be muted. This is placed in a separate time for now due to being unable to "-expected.txt"-expect a TIMEOUT in Chromium, see discussion in https://crbug.com/777526. Left a TODO to merge the files when Chromium supports this. Bug: 774303, 777526 Change-Id: I1ee56e99d7abbea25d11dccfef54d8fb89b78039 Reviewed-on: https://chromium-review.googlesource.com/729149 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by: Robert Ma <robertma@chromium.org> Reviewed-by: Taylor Brandstetter <deadbeef@chromium.org> Cr-Commit-Position: refs/heads/master@{#515527} 
- 
Gauthier Ambard authoredThis CL changes the constraints of the NTP header to allow them to work with a nil logoVendor. This happens during tests. Bug: 764720 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ieba12be198bfdcb6cffc8640d5f0793b6059d966 Reviewed-on: https://chromium-review.googlesource.com/758839 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#515526} 
- 
Gauthier Ambard authoredThis CL adds a 0.5s delay on the ContentSuggestions tests to allow the New Tab Opened animation to complete. This is needed as the animation is a CAAnimations, EG has trouble synchronizing on it. Using a loop to check if the first tab has came back does not work as the steps inside the loop is too short for the animation to have time to continue. Using it froze the animation. Bug: 783169 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I71e247d9e373df96f601e613eb0bec83704ac09a Reviewed-on: https://chromium-review.googlesource.com/763408Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#515525} 
- 
Koji Ishii authoredThis patch fixes the coordinate system of VisualOverflowRect and OverflowClipRect to be relative to the object itself. VisualRect() is relative to the object that owns the GraphicsLayer (in SPv1) or to the parent transform node (in SPv2), and that returning VisualRect() caused objects at lower half of the screen being not painted. Bug: 714962 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I2abd948598232b9dd660848f67006b5fb71a594c Reviewed-on: https://chromium-review.googlesource.com/760716 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#515524} 
- 
Jérôme Lebel authoredThe profile chooser menu on macOS is implemented with cocoa, with ProfileChooserController. On Linux and Windows, ProfileChooserView is used (based on toolkit-views). This patch adds a feature flag (enabled by default) to use ProfileChooserView on macOS. The benefit is to have only one implementation on all 3 platforms. Bug: 728141 Change-Id: Idf3099ac698dfa1e286ce23e6852390e8500b4b2 Reviewed-on: https://chromium-review.googlesource.com/750901 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#515523} 
- 
Christos Froussios authoredWe currently do not seem to be properly deleting SecretItems. The destruction of SecretItems is undocumented, but g_object_unref appears to have been used in other codebases for this purpose. Bug: 393395 Change-Id: I046911136bac266c0e1a42b09a8a0cb79b678f4a Reviewed-on: https://chromium-review.googlesource.com/758851Reviewed-by: Vaclav Brozek <vabr@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#515522} 
- 
Adam Rice authoredAdd an implementation of TransformStream using v8 extras. It will be enabled when --enable-experimental-web-platform-features is enabled. Implementation is conformant to the standard: https://streams.spec.whatwg.org/#ts Tests are not included in this CL, as they are due to move from the whatwg/streams repository to the w3c/web-platform-tests repository very soon. All transform stream tests pass. Some changes have been made to the existing ReadableStream and WritableStream extensions to enable the implementation. ReadableStream: - ReadableStreamDefaultControllerHasBackpressure and ReadableStreamDefaultControllerCanCloseOrEnqueue abstract operations have been implemented. These were already in the standard. - getReadableStreamEnqueueError has been factored out so that enqueue() for ReadableStreamDefaultController and TransformStreamDefaultController can share common error messages. - Internal accessors getReadableStreamController and getReadableStreamStoredError have been added for TransformStream to use. WritableStream: - New accessors isWritableStreamWritable, isWritableStreamErroring and getWritableStreamController have been added. - WritableStreamDefaultControllerErrorIfNeeded is newly exported on the binding object. Bug: 780689 TBR=brettw@chromium.org R=domenic@chromium.org Change-Id: I3d0d5442f2ccad8350ab52caad2961374446656d Reviewed-on: https://chromium-review.googlesource.com/750502 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org> Reviewed-by: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#515521} 
- 
Gauthier Ambard authoredThis CL makes sure that the AppState unit tests can run with ContentSuggestions enabled. Bug: 764720 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I0773b29330f1a0b139b0f25a707e9d58c1f87cd8 Reviewed-on: https://chromium-review.googlesource.com/758838 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#515520} 
- 
Ricky Liang authoredThe buffer vector may contain null buffers in case of error. BUG=None Change-Id: If13de598df06a69833921b6b2608cc6adb35904a Reviewed-on: https://chromium-review.googlesource.com/763189Reviewed-by: Wu-Cheng Li <wuchengli@chromium.org> Commit-Queue: Ricky Liang <jcliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#515519} 
- 
Elodie Banel authoredThis value was assumed received on the histogram side but not sent, resulting in an empty histogram. Bug: None Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I58b4e97eca73f987db6380485d34ffe594329e1e Reviewed-on: https://chromium-review.googlesource.com/758855Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Elodie Banel <lod@chromium.org> Cr-Commit-Position: refs/heads/master@{#515518} 
- 
Olivier Robin authoredThis is the same logic as the getFormIdentifier. This fixes filling the CC form in nordstrom.com Bug: Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic1ee55a4c9a0ea92e0826579db0e0dca9473541d Reviewed-on: https://chromium-review.googlesource.com/751241 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by: Peter Lee <pkl@chromium.org> Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#515517} 
- 
catapult-deps-roller@chromium.org authoredhttps://chromium.googlesource.com/catapult.git/+log/f83c79a6db05..2671b653f331 $ git log f83c79a6d..2671b653f --date=short --no-merges --format='%ad %ae %s' 2017-11-09 dtu [pinpoint] AsDict() results_values fixes. 2017-11-08 nednguyen Reland "Fix reinit after failure"" 2017-11-07 crouleau Don't use grouping_keys for cache and traffic. 2017-11-08 dtu [pinpoint] Separate exception comparisons for each Quest. 2017-11-08 nednguyen Disable TestBrowserOperationDoNotLeakTempFiles.testBrowserNotLeakingTempFiles 2017-11-08 dtu [pinpoint] Compress Job.state. 2017-11-08 perezju [Telemetry] Log Telemetry's memory usage after collecting all results 2017-11-07 sadrul Reland "viz: Fix collecting rendering stats with viz." 2017-11-08 benjhayden Save memory with __slots__ in python Histogram library. 2017-11-06 benjhayden Fix default bin boundaries in python Histogram. 2017-11-07 benjhayden Fix a bug with results.html deep-linking sortDescending. 2017-11-03 sergiyb Add VPython checks to Catapult presubmit 2017-11-02 benjhayden Syntax updates for Polymer 2.0. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I612caf7be5d43f0caed353b8da3d33b7b416327c Reviewed-on: https://chromium-review.googlesource.com/762528 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#515516} 
- 
Daniel Bratell authoredThere are two NSString* const NSAccessibilitySelectedTextMarkerRangeAttribute = @"AXSelectedTextMarkerRange"; and in jumbo builds they will end up in the same translation unit and trigger compilation errors. This patch moves one of them to where its used which will prevent the clash and let the compilation proceed. Bug: 746953 Change-Id: Iaf440412f7780141f8d22f648dfef59358ef610c Reviewed-on: https://chromium-review.googlesource.com/758845Reviewed-by:Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#515515} 
- 
Martijn Croonen authoredBug: 778047 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ib879c1e7dfd9f664ed733dcc51a1f80e24fdc806 Reviewed-on: https://chromium-review.googlesource.com/751664Reviewed-by: Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Martijn Croonen <martijnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#515514} 
- 
Hitoshi Yoshida authoredIn the original way, origin trial features are installed in V8PerContextData::ConstructorForTypeSlowCase on each context. However, if V8 objects are created from snapshot, those features were not installed. This CL make them installed again even when Blink uses the snapshot. Bug: None Change-Id: Iebf387afab27c2de2ec9c7f74312914269a43ece Reviewed-on: https://chromium-review.googlesource.com/762970Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#515513} 
- 
Mirko Bonadei authoredWebRTC unprefixed LOG macros will be deprecated on 10/11/2017. In order to remove backwards compatible macros from webrtc_overrides libjingle_xmpp needs to switch to RTC_ prefixed LOG macros. Bug: webrtc:8452 Change-Id: I8c8dbf36e0208e22f7f20c17a8b041ef3429f273 Reviewed-on: https://chromium-review.googlesource.com/762317Reviewed-by: Henrik Andreasson <henrika@webrtc.org> Reviewed-by: Henrik Andreasson <henrika@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#515512} 
- 
Vaclav Brozek authoredThis adds a straightforward fuzzer for components/password_manager/core/browser/import/password_csv_reader.* and also some seeed corpus and dictionary. Bug: 783111 Change-Id: Ic5193d4baa1c730db185059997c1a9fad1b2eef5 Reviewed-on: https://chromium-review.googlesource.com/758773Reviewed-by: Christos Froussios <cfroussios@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#515511} 
- 
Shuhei Takahashi authoredBUG=chromium:783535 TEST=None Change-Id: Ib9c41ae593ebe5f04832bb1c92d6fd16baf69558 Reviewed-on: https://chromium-review.googlesource.com/762727Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Commit-Queue: Shuhei Takahashi <nya@chromium.org> Cr-Commit-Position: refs/heads/master@{#515510} 
- 
Darren Shen authoredA stray LOG was accidentally left in the code. Change-Id: I39ba40d5459b1061579785c1ed11f28e8a381069 Reviewed-on: https://chromium-review.googlesource.com/762832 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by: meade_UTC10 <meade@chromium.org> Cr-Commit-Position: refs/heads/master@{#515509} 
- 
Mikhail Pozdnyakov authoredThis patch moves source sensors fetching logic to the newly created private PlatformSensorFusion::Factory class. 1) PlatformSensorFusion stops exposing a constructor which does not initialize it fully. 2) PlatformSensorFusion does not need to check it state internally as source sensors are initialized at construction time. Rationals: Change-Id: I24416e770d60c1d7f0c8ac2cc8cc1758038bca49 Reviewed-on: https://chromium-review.googlesource.com/760420 Commit-Queue: Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#515508} 
- 
Marti Wong authoredFix the issue that when bookmarks exceeds screen height, the auto adjusted inset of tableView will cause the bookmarks to be shown under the navigation bar at the first appearance. An egtest is added to make sure this issue won't happen again. Bug: 772383 Change-Id: Id3f9b33b3b882d3b8a680d7ef8f9053565161541 Reviewed-on: https://chromium-review.googlesource.com/754661Reviewed-by: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Marti Wong <martiw@chromium.org> Cr-Commit-Position: refs/heads/master@{#515507} 
- 
Colin Blundell authoredThis CL is a precursor to converting the callers of sync_ui_util::ConstructAboutInfo() to supply the information of the signed-in user via the Identity Service. Analysis of this caller shows that it's actually dead code. Bug: 783144 Change-Id: Ia7060fe0e0af6ec54858bab800f8481281871cab Reviewed-on: https://chromium-review.googlesource.com/758586Reviewed-by: Nicolas Zea <zea@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#515506} 
- 
Colin Blundell authoredsync_ui_util::ConstructAboutInformation() currently only initializes the username field if SyncService::signin() is non-null. In an upcoming refactoring to change this function to use the Identity Service instead, it will no longer be possible for the client to differentiate the situation where SyncService::signin() is null from the situation where the user simply isn't signed in. To avoid coupling a behavioral change with a refactoring, this CL first explicitly makes the behavioral change to initialize the username field in all cases, setting it to the empty string if SyncService::signin() is null. The only user-visible effect that this will have is that if there are any situations wher SyncService::signin() is null in production, the user will see the username field being empty in chrome://sync-internals rather than having a value of "Uninitialized." Bug: 783144 Change-Id: Ie090a2635549072f86d15b86fb98891396abdb08 Reviewed-on: https://chromium-review.googlesource.com/758685Reviewed-by: Nicolas Zea <zea@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#515505} 
- 
Shubhie Panicker authoredBug: 764104 Change-Id: I45cd6ae2d0d4911e0f156e53333080c7e2bf53ba Reviewed-on: https://chromium-review.googlesource.com/762118 Commit-Queue: Shubhie Panicker <panicker@chromium.org> Reviewed-by: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#515504} 
- 
Yoshifumi Inoue authoredThis patch gets rid of null |LocalFrame| checks from |SelectionModifier| since it is always non-null |LocalFrame| initialized from |LocalFrame&| to simplify source code for improving code health. Change-Id: I183aa2eb588d0f3d67c4255acc68f4b05f2771bf Reviewed-on: https://chromium-review.googlesource.com/762831Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#515503} 
- 
Alexandr Ilin authoredThe predictors::kSpeculativePreconnectFeature is explicitly disabled in net::Predictor browser tests because the LoadingPredictor if enabled intercepts all prefetch and preconnect coming from a renderer. WarmupManagerTest.testPreconnect() was expecting two connections to be opened but it's not the case for the LoadingPredictor, it opens only one connection. Bug: 699080 Change-Id: I73537c3a59818793e41c5741762fe675a4efa97f Reviewed-on: https://chromium-review.googlesource.com/754837Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Helen Li <xunjieli@chromium.org> Reviewed-by: Jesse Doherty <jwd@chromium.org> Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#515502} 
- 
Yutaka Hirano authoredThey now pass. Bug: 441781 Change-Id: I98dad704808c2ed810ff9d03e0e49200b8e90209 Reviewed-on: https://chromium-review.googlesource.com/762930Reviewed-by: Adam Rice <ricea@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#515501} 
- 
Wei-Yin Chen (陳威尹) authoredThere are lots of occurrences of canUseGooglePlayServices() and canUseFirstPartyGooglePlayServices() using application context and silent error handler. These are refactored to static functions. Bug: 782496 Change-Id: Ifd554cb3ce62784db333f97f6a1bcb4a98999d28 Reviewed-on: https://chromium-review.googlesource.com/760697 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#515500} 
- 
Nodir Turakulov authoredHooks tend to have implicit dependencies //.vpython covers or should cover all of them, so run all hooks via vpython Also add missing catapult's dependencies to .vpython. Bug: 781430 Change-Id: I5ec7a760f44bcb806c654ad8da303f78d3dbee3f Reviewed-on: https://chromium-review.googlesource.com/762037 Commit-Queue: Nodir Turakulov <nodir@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Cr-Commit-Position: refs/heads/master@{#515499} 
- 
Dan Elphick authoredAdd a new GetRegistrationTask to be used by BackgroundFetchDataManager when the persistent storage flag is enabled. Adds the origin to the proto stored in the database and check it matches when retrieving a registration, otherwise trigger a storage error. Make BackgroundFetchDataManagerTest parameterized by persistence, which turns on the command line flag. Now all tests run (and pass) with or without persistence although the Cleanup test doesn't test much yet since there's no way yet to interact with a non-active fetch. Bug: 757760 Change-Id: I3aa29e17f9112f282f5672366e52522e549f32d0 Reviewed-on: https://chromium-review.googlesource.com/758762Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#515498} 
- 
Renee Wright authoredHere is the diff of the generated files https://gist.github.com/rjwright/61829820d0cbb6d304eebc345a29ab76/revisions Bug: 779927 Change-Id: Ia13f9a0c6f788fc7b7030f1248a8ecd44ec6ba7b Reviewed-on: https://chromium-review.googlesource.com/760018 Commit-Queue: Renée Wright <rjwright@chromium.org> Reviewed-by: Bugs Nash <bugsnash@chromium.org> Reviewed-by: meade_UTC10 <meade@chromium.org> Cr-Commit-Position: refs/heads/master@{#515497} 
- 
depot-tools-roller@chromium.org authoredhttps://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7af1dc56fc10..0ffcc877a624 $ git log 7af1dc56f..0ffcc877a --date=short --no-merges --format='%ad %ae %s' 2017-11-09 nodir [gclient hooks] add .bat to vpython on windows Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=phajdan.jr@chromium.org Change-Id: I4186dae198699abdb543b860c8db91eb3d9baa6b Reviewed-on: https://chromium-review.googlesource.com/762947Reviewed-by: depot-tools-roller . <depot-tools-roller@chromium.org> Commit-Queue: depot-tools-roller . <depot-tools-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#515496} 
- 
Rakina Zata Amni authoredCurrently, EventTarget cannot be constructed or be subclassed (in JavaScript). The spec for EventTarget was updated to allow constructing and subclassing EventTarget. A new class, EventTargetImpl, is created as the user-constructable version of EventTarget. Even though the name is EventTargetImpl, it will be exposed as EventTarget to JavaScript. We are using a hacky approach by making EventTarget::Create return an instance of EventTargetImpl, which means an instance of EventTargetImpl will be returned when the EventTarget object is constructed in JavaScript. Spec: https://dom.spec.whatwg.org/#dom-eventtarget-eventtarget Design doc: https://docs.google.com/a/google.com/document/d/1TXMAkLeaNpbbETeqTyJZ57YnmqzgchyhFsANVZ2Ow3Y/edit?usp=sharing Bug: 740576 Change-Id: Ia0569ee99c4d856120c387ca6aceed5fbe1491b5 Reviewed-on: https://chromium-review.googlesource.com/754248Reviewed-by: Hayato Ito <hayato@chromium.org> Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#515495} 
 
-