- 07 Oct, 2018 2 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4ce1c120..f7f89bcb Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1241856b1918aad4368e59aa41de9c88e22384bf Reviewed-on: https://chromium-review.googlesource.com/c/1266718Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597449}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/698a46a872a3..92a8be869eb0 Created with: gclient setdep -r src-internal@92a8be869eb0 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I999ebdf776fe2a76834e74314c91b5ee5f5c799e Reviewed-on: https://chromium-review.googlesource.com/c/1267197Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597448}
-
- 06 Oct, 2018 38 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9f1ed2ca5c8c..698a46a872a3 Created with: gclient setdep -r src-internal@698a46a872a3 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I5a62b7db414dacc0fcd43aa6d7833b34cd96ae3b Reviewed-on: https://chromium-review.googlesource.com/c/1267195Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/37d64e536cb8..8c949fc3ffa5 git log 37d64e536cb8..8c949fc3ffa5 --date=short --no-merges --format='%ad %ae %s' 2018-10-06 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@8c949fc3ffa5 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I876567153591d0a78e84b418c7bd775e6b27fd55 Reviewed-on: https://chromium-review.googlesource.com/c/1267196Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597446}
-
Krishna Govind authored
R=abdulsyed@chromium.org Change-Id: I76c4aa4b8fa31bb163d14316f392806d8bb51529 Reviewed-on: https://chromium-review.googlesource.com/c/1267120Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#597445}
-
Kush Sinha authored
Design doc and sequence diagrams are linked in the bug id. Add new Mojo APIs: - RequestPrimaryAccountInfo : For provisioning flow - RequestAccountInfo : For post-provisioning flow Which use the standard Mojo request - response semantics. Deprecate the old |RequestAccountInfo| API, which did not use the standard Mojo request - response semantics. Add implementation in ArcAuthService. Manual Testing: - 'kill'ed the container while auth code fetch was in progress. Opt in was able to continue successfully after the supervisor process restarted the container. - Added a hack to opt out and reset prefs when auth code fetch was in progress. Recovery was successful after a re-login. Bug: 871690 Test: browser_tests --gtest_filter="*Arc*AuthService*Test*" Test: browser_tests --gtest_filter="*ArcRobotAuthCodeFetcherBrowserTest*" Change-Id: Id46b9dc04e1cb8a62fdb54e9e34ac1c0685e0397 Reviewed-on: https://chromium-review.googlesource.com/c/1206333Reviewed-by:Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#597444}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I3f493c179c475f58033a2c6ad5b97f90f288e616 Reviewed-on: https://chromium-review.googlesource.com/c/1266754Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/125162c8162d..9f1ed2ca5c8c Created with: gclient setdep -r src-internal@9f1ed2ca5c8c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie8d75f21fced45a1a9fc157e98ea372b8a644a37 Reviewed-on: https://chromium-review.googlesource.com/c/1266753Reviewed-by:
-
Xianzhu Wang authored
This reverts commit 530ad69b. Reason for revert: Caused clusterfuzz bugs Bug: 892881,892882 Original change's description: > [CI] Group HasLayer conditions together in NeedsEffect > > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I10953860800adba8ee8aba894f3e2e099895589c > Reviewed-on: https://chromium-review.googlesource.com/c/1265635 > Reviewed-by: Philip Rogers <pdr@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#597365} TBR=wangxianzhu@chromium.org,pdr@chromium.org Change-Id: Ia5cc35d637d5d1dad8a0930c53256a4017e0a8e9 No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/c/1267118Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#597441}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3c5d491a..4ce1c120 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I46433da306ca0251dac61270d139b984847813ca Reviewed-on: https://chromium-review.googlesource.com/c/1266892Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e53341c1dc6e..343f4144bee5 git log e53341c1dc6e..343f4144bee5 --date=short --no-merges --format='%ad %ae %s' 2018-10-06 srte@webrtc.org Allows copy and assignment of field trial parameters. Created with: gclient setdep -r src/third_party/webrtc@343f4144bee5 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I7e79d004288bccae479719a63b626fa1880646c6 Reviewed-on: https://chromium-review.googlesource.com/c/1266752Reviewed-by:
-
Philip Rogers authored
LayoutObject::IsTransparent actually means Style.HasOpacity but this was not clear (ba dum tsss!). It could be confused with PaintLayer::IsTransparent which is subtly different. This patch switches all callsites to use Style.HasOpacity instead. this function has been folded into the callsite. LayoutObject: :Opacity only had a single callsite which had style code so Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I9795bb009943cacfbcceea57fd31fd9858f293ef Reviewed-on: https://chromium-review.googlesource.com/c/1266697Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#597438}
-
Justin Cohen authored
This should remove the remaining few calls to StatusBarHeight in >=iOS11 and with -kBrowserContainerFullscreen and kOutOfWebFullscreen enabled. StatusBarHeight() will now DCHECK if called on >=iOS11 with those features enabled. Bug: 883770 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Icd933faa6e223122da46d0e856600df86fd2e5e1 Reviewed-on: https://chromium-review.googlesource.com/c/1259344 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#597437}
-
Nikita Podguzov authored
Bug: 877424 Change-Id: Ic55f4396247a60181bc7e007b2c2b50830ac9ffc Reviewed-on: https://chromium-review.googlesource.com/c/1261701Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> Cr-Commit-Position: refs/heads/master@{#597436}
-
sczs authored
Bug: None Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I1c9e898338be6de2712b5baaca4e69dfd4fcf4ae Reviewed-on: https://chromium-review.googlesource.com/c/1266115 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#597435}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/10b1043e4cf5..125162c8162d Created with: gclient setdep -r src-internal@125162c8162d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I247ed0a7d3990e9b071e0a99d3dca1b3e54f9796 Reviewed-on: https://chromium-review.googlesource.com/c/1266751Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7f1084457fe6..10b1043e4cf5 Created with: gclient setdep -r src-internal@10b1043e4cf5 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I3548fce6b3d3db7465ebedcbe259028c9799dba7 Reviewed-on: https://chromium-review.googlesource.com/c/1266750Reviewed-by:
-
Philip Rogers authored
This patch refactors ImageObserver's "ChangedInRect" to just "Changed" because the partial invalidation rect is never used. This likely dates to back when rect-based paint invalidation was used, but we now do object-based paint invalidation. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I572ea239e3f25a6ac1f50265c0aa18b6ff0367e8 Reviewed-on: https://chromium-review.googlesource.com/c/1266056Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4ba1e0a6f623..7f1084457fe6 Created with: gclient setdep -r src-internal@7f1084457fe6 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Idcc1d9cf42eab269166ab661377c419d1c1fa739 Reviewed-on: https://chromium-review.googlesource.com/c/1266749Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/21250057..3c5d491a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6308c0f64be6cba0fd1617ef4dd8823200de98d0 Reviewed-on: https://chromium-review.googlesource.com/c/1266886Reviewed-by:
-
Ned Nguyen authored
TBR=kouhei@chromium.org, ksakamoto@chromium.org NOTRY=true Bug: 892191 Change-Id: Ia164f2364d68118ee4538377c6f4e193034f9452 Reviewed-on: https://chromium-review.googlesource.com/c/1266890Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#597429}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9049b3685b22..4ba1e0a6f623 Created with: gclient setdep -r src-internal@4ba1e0a6f623 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I4147833412db8d27d3bd91becb671c35e8e096f0 Reviewed-on: https://chromium-review.googlesource.com/c/1266748Reviewed-by:
-
Julian Pastarmov authored
SigninAllowed has been deprecated since Chrome 40 and slated for removal. In the light of Dice we need a policy to mirror the user setting to allow browser signin in which the new policy provides. ForceBrowserSignin had the potential to conflict with disabling signin and cause the browser to be unusable so folding it into a single enum policy avoids this issue. BUG=890396 TEST=policy_test_cases.json Change-Id: I0b5025fa4024c817b7e9ce45a9b26b53303db2d9 Reviewed-on: https://chromium-review.googlesource.com/c/1264495 Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Drew Wilson <atwilson@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#597427}
-
Jan Krcal authored
This reverts commit 03148944. Reason for revert: This was a speculative fix for a crash that _stopped_ appearing a couple releases earlier. Thus, this fix should not be needed on trunk. I kept it on trunk for so long to verify that it does not cause any further problems if merge to M70 is needed. Original change's description: > [Sync] Patch a crash in AutofillWalletSyncableService > > This is a speculative patch for a bug causing a crash in > AutofillWalletSyncableService. This CL stops the generic change > processor from talking to the syncable service when the service gets > stopped. > > GenericChangeProcessor only talks to the service because it gets pinged > by SyncBackendRegistrar. The registrar should not talk to the > GenericChangeProcessor after a data type gets deactivated. Normally, a > data type should get deactivated before it gets stopped. However, we > see crashes in Canary that seem to contradict this expected behavior. > > Bug: 880029 > Change-Id: I64b9ea1c3521a347983a530bc16c1f8e266769b6 > Reviewed-on: https://chromium-review.googlesource.com/1230714 > Commit-Queue: Jan Krcal <jkrcal@chromium.org> > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#592485} TBR=jkrcal@chromium.org,mastiz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 880029 Change-Id: Ia91d005e67cce4d01fe1bb4c0bb66e952b7811aa Reviewed-on: https://chromium-review.googlesource.com/c/1267076Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#597426}
-
Rakina Zata Amni authored
After developer feedback on ergonomics, having a way to add multiple stylesheets as the default style for a custom element seems to be preferred. This CL changes custom element default style to handle multiple stylesheets. Bug: 824684 Change-Id: Ie0a130db42425396132ed48237e4b24c34243031 Reviewed-on: https://chromium-review.googlesource.com/c/1257468Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#597425}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bbea84018b9a..9049b3685b22 Created with: gclient setdep -r src-internal@9049b3685b22 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I410f62e014fcc1b33a85ece47c713d52b6b51d09 Reviewed-on: https://chromium-review.googlesource.com/c/1266747Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/17831e7c077d..bbea84018b9a Created with: gclient setdep -r src-internal@bbea84018b9a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ibba44aa51eb3aa07cce98a448d44d00be6fe4569 Reviewed-on: https://chromium-review.googlesource.com/c/1266745Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/28995e606991..33b1cebbc5e0 git log 28995e606991..33b1cebbc5e0 --date=short --no-merges --format='%ad %ae %s' 2018-10-06 thestig@chromium.org Roll tools/clang/ 9bd40b25b..7792d28b0 (10 commits) 2018-10-06 thestig@chromium.org Roll third_party/depot_tools/ 02d534031..71e3be7a5 (141 commits; 44 trivial rolls) 2018-10-06 thestig@chromium.org Roll tools/code_coverage/ 64186cbaf..4191ea067 (6 commits) 2018-10-06 thestig@chromium.org Roll build/ dfca77bb0..eb7ca761a (27 commits) 2018-10-06 thestig@chromium.org Simplify CFX_FloatRect::Inflate() and Deflate(). Created with: gclient setdep -r src/third_party/pdfium@33b1cebbc5e0 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I19aedbc7b941522ca3e1c2951cc2f6306337129f Reviewed-on: https://chromium-review.googlesource.com/c/1266746Reviewed-by:
-
David Roger authored
Clearing cookies now also pause Sync by default. This is probably not expected behavior for the browsingData.remove API, because this would prevent the data from being cleared on the Sync server. This CL now keeps the Sync account so that the deletions can go through. As a side effect the Gaia cookie for the Sync account will be rebuilt, because Sync requires a valid Gaia cookie. The Gaia cookie can still be cleared through other APIs, such as browsingData.removeCookies (and will cause Sync to stop working). TBR=mkearney Bug: 890353 Change-Id: Ic78709befd17b43c031d1aa1cbffa133ee41ea91 Reviewed-on: https://chromium-review.googlesource.com/c/1256964 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#597421}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/86aed05a6d90..37d64e536cb8 git log 86aed05a6d90..37d64e536cb8 --date=short --no-merges --format='%ad %ae %s' 2018-10-06 benchan@chromium.org deploy_chrome: fix typo: 'roots' -> 'rootfs' Created with: gclient setdep -r src/third_party/chromite@37d64e536cb8 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I4111f8e90fc7fad4f79045bdf62c6b57fd00af26 Reviewed-on: https://chromium-review.googlesource.com/c/1266742Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/d9826495fe0e..28995e606991 git log d9826495fe0e..28995e606991 --date=short --no-merges --format='%ad %ae %s' 2018-10-06 thestig@chromium.org Move CFX_FloatRect method impls out of the header. Created with: gclient setdep -r src/third_party/pdfium@28995e606991 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ia84552e7e79aa11e8dd6d3ce7ecffb1b7f86ffde Reviewed-on: https://chromium-review.googlesource.com/c/1266741Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1a8a6e9412c0..17831e7c077d Created with: gclient setdep -r src-internal@17831e7c077d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I8a2e90b5da58a2344c4cb7db7c1402c0d81f80d9 Reviewed-on: https://chromium-review.googlesource.com/c/1266743Reviewed-by:
-
Dong-hee Na authored
There is a bug with handling an empty bookmark folder. This bug is reproduced when a bookmark bar has 2 folders and at least one folder is an empty folder. 1. Click one of them, see the "Empty" placeholder 2. Move the cursor to the folder on the side 3. Move the cursor back to the previous folder, you'll see 2 placeholders 4. Keep moving the cursor between the folders and the placeholders count keeps growing. To fix this bug, I 've added the new member method 'HasEmptyMenuItemView()' to check whether SubmenuView has at least one empty menu item. So if submenu does not have visible children but also there is no empty menu item then create an empty menu item. This CL also maintain the functionality which was fixed in crbug/852915. Also, the unit test is also updated to cover this situation. Bug: 880852, 852915 Change-Id: I61d683f74f6283ba7337c6724b1e267ca91230fb Reviewed-on: https://chromium-review.googlesource.com/c/1254601 Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#597417}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dbde842154d2..1a8a6e9412c0 Created with: gclient setdep -r src-internal@1a8a6e9412c0 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Iaba27967ce75e756c9d5c8512e5955be95167113 Reviewed-on: https://chromium-review.googlesource.com/c/1266739Reviewed-by:
-
Mike Dougherty authored
TBR=eugenebut@chromium.org Bug: 892883 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Idd01581265d46e17f2812c1456ebe93f0d521389 Reviewed-on: https://chromium-review.googlesource.com/c/1266879Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#597415}
-
Mugdha Lakhani authored
Until we figure out a way to start downloads in a paused state. Bug: 886896 Change-Id: I7357d8baa97f50828f4070e60e60df6d886b2338 Reviewed-on: https://chromium-review.googlesource.com/c/1264517 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#597414}
-
Scott Violet authored
GetParentRenderWidgetHostView() may return null. BUG=890429 TEST=none Change-Id: I7e868c165c047f4e855380109da37feda42a704c Reviewed-on: https://chromium-review.googlesource.com/c/1265557Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#597413}
-
Lukasz Anforowicz authored
This CL adds test coverage for URLLoaderFactoryManager::DoContentScriptsMatchNavigatingFrame. To enable navigating in extensions_browsertests, this CL: - Adds an overload of content::NavigateToURL that takes WebContents* (rather than Shell*) as an argument and exposes it through the public content/public/test/browser_test_utils.h - Tweaks constructor of extensions::AppShellTest so that it sets up the |embedded_test_server| to serve files from the //extensions/test/data directory. Bug: 846346 Change-Id: I4bba6bee18beb5d5e8855a4b3b91fda6a04ca587 Reviewed-on: https://chromium-review.googlesource.com/c/1252009 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#597412}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b2fd1994d77f..dbde842154d2 Created with: gclient setdep -r src-internal@dbde842154d2 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ic0b0d5fb47326186e8e7db8f4213c49610e2c8a5 Reviewed-on: https://chromium-review.googlesource.com/c/1266738Reviewed-by:
-
Ella Ge authored
Bug: 888440 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I601941bc56657d5c715c8cb5c09e57c672046276 Reviewed-on: https://chromium-review.googlesource.com/c/1265132Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#597410}
-
