- 15 Feb, 2019 31 commits
-
-
Miyoung Shin authored
[s13n] Migrate SigninManagerAndroid's usage of O2TSDelegateAndroid::ValidateAccounts to IdentityManager This CL uses IdentityManager::LegacyReloadAccountsFromSystem that calls O2TSDelegateAndroid::ValidateAccounts internally. Bug: 905340 Change-Id: I7fc6f18ef59a88373a68ba0dee292e344a3af65e Reviewed-on: https://chromium-review.googlesource.com/c/1469813Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@chromium.org> Cr-Commit-Position: refs/heads/master@{#632437}
-
Hector Carmona authored
Screenshot in bug. Bug: 932045 Change-Id: I135f3e63f5a62b4cbac30f5936678d5c8c764171 Reviewed-on: https://chromium-review.googlesource.com/c/1474830Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#632436}
-
Robbie McElrath authored
Bug: 911287 Change-Id: I2ff79eba3c4089d71eddc5602bf3f91e06efe4aa Reviewed-on: https://chromium-review.googlesource.com/c/1469367Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#632435}
-
Piotr Bialecki authored
Flag that controls inclusion of manifest entries related to ARCore is not set correctly on stable/beta channels. This is due to the fact that by default it's set to the value of `package_arcore`, which is ignored by other build rules when compiling bundles. The fix is to override the value of `include_arcore_manifest_flag` when building manifests for bundles. This will align the behaviors of those 2 flags when compiling bundles. Bug: 932193 Change-Id: I290664775c4349075a22b538f47a526a3d695693 Reviewed-on: https://chromium-review.googlesource.com/c/1473814 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#632434}
-
Maggie Cai authored
Currently the origins under etld+1 entries are rendered on initial loading, however it is not necessary and can reduce the rendering performance. This CL makes the origin entries lazy rendered. BUG=835712 Change-Id: Id41ffc6eeafe6802d51f617cb1671d3d857144f2 Reviewed-on: https://chromium-review.googlesource.com/c/1469803Reviewed-by:
Patti <patricialor@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#632433}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 603722e4. With Chromium commits locally applied on WPT: 14c11107 "Implement `Sec-CH-Lang`" af3b056c "[WPT] [wasm] Add JS-API tests for wasm threads" df760ab0 "Don't skip past auto-height flexboxes in quirks mode." 6cf9dcc6 "Use testdriver Action API in WPT pointerevent touch tests" 5c3da78e "Revert "Use testdriver Action API in WPT pointerevent touch tests"" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=kyleju No-Export: true Change-Id: I1a04b28b2eb68ce529ced11b12fe5f4ab5c38ca0 Reviewed-on: https://chromium-review.googlesource.com/c/1474676Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632432}
-
Bence Béky authored
In current Google QUIC, HEADERS are sent on a dedicated headers frame that is owned by QuicSpdySession. So QuicSpdyStream::WriteHeaders() calls QuicSpdySession::WriteHeaders(), which is virtual and is mocked in tests. However, in IETF QUIC, HEADERS will be sent on the request/response stream, so writing headers is more naturally done within QuicSpdyStream instead of QuicSpdySession. This CL does not move HEADERS to the request/response streams yet, but prepares tests for it by: * introducing virtual QuicSpdyStream::WriteHeadersImpl(), * mocking it for tests instead of mocking QuicSpdySession::WriteHeaders(), * renaming QuicSpdySession::WriteHeaders() to WriteHeadersOnHeadersStream(), * introducing QuicSpdySession::WriteHeadersOnHeadersStreamImpl(). In QuicSimpleServerSessionTests a test implementation of QuicSpdySession is used with regular QuicSpdyStreams. MockQuicSpdySession::WriteHeaders() used to prevent actual writes, but QuicSpdyStream::WriteHeadersImpl() is not overriden and writes do happen on the headers stream. gMock expectations are added accordingly. Testing for the stream id is lost in the process, but stream id is tested by QuicConnection::SendStreamData() expectations anyway. In other tests expectations are changed from the session object to the stream object. This CL lands server side changes 232878862 and 233946983 by bnc. Patch Set 1: server change 232878862. Patch Set 2: server change 233946983. Patch Set 3: Chromium changes. Change-Id: Id12c9691abc9a69d99c1dad854fcd929db8a6c3f Reviewed-on: https://chromium-review.googlesource.com/c/1473132Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#632431}
-
Jarryd authored
Change-Id: I40db96e2558bacf3a000245ba8f29d27f0e36c91 Reviewed-on: https://chromium-review.googlesource.com/c/1460429 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#632430}
-
Gyuyoung Kim authored
The OnionSoup effort has a goal of allocating all garbage-collectable Blink objects with Oilpan or PartitionAlloc. However, some of //blink/renderer/core/dom/ class have not yet been allocated with them so far. After some analyzes, they were concluded that for the case of PostponeTransitionScope, NamesMap, and Data, they make sense to use USING_FAST_MALLOC because they are used by other classes as a member variable with a smart pointer type. In the other classes case, it makes sense to use STATIC_ONLY because they only define static member functions. Bug: 919389 Change-Id: I2d827b3b4cef21a6e24ad92499d855af5fe2b79d Reviewed-on: https://chromium-review.googlesource.com/c/1473093Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#632429}
-
Eric Foo authored
Bug: 861346 Change-Id: Icb700387cbf429b35199fe734bb2cd1caf8fae78 Reviewed-on: https://chromium-review.googlesource.com/c/1474777Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Commit-Queue: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#632428}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4976b9f5f855..ee4db4b3e9e3 git log 4976b9f5f855..ee4db4b3e9e3 --date=short --no-merges --format='%ad %ae %s' 2019-02-14 rsavitski@google.com Merge "pow2 fixup" Created with: gclient setdep -r src/third_party/perfetto@ee4db4b3e9e3 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I31f424dc92e2a0eea1162c31d2aec601ef027fb5 Reviewed-on: https://chromium-review.googlesource.com/c/1474431Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632427}
-
Clark DuVall authored
It looks like the network_loader_ gets reset in CommitCompleted(), but the binding may still send messages after that since this was bound with mojo::MakeStrongBinding. The class will only be deleted after the remote endpoint sees the connection closed, so it can send messages before that. Bug: 916098 Change-Id: I772ca9f03e4f9d5354278b8d36e73dff92195cda Reviewed-on: https://chromium-review.googlesource.com/c/1473402 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#632426}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I14e417469fe7b49073f60895b0a18898632402e0 Reviewed-on: https://chromium-review.googlesource.com/c/1474434Reviewed-by:
-
Stuart Langley authored
Obsoletes the following histograms: - Drive.DownloadFromDriveFileSize - Drive.TransferBlockedOnJobs - Drive.UploadToDriveFileSize Removes the code that was emitting the values. Bug: 931519 Change-Id: I32739944c3cfe5ef6dd0117fb2673ca3ddec5128 Reviewed-on: https://chromium-review.googlesource.com/c/1471971Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#632424}
-
Anastasia Helfinstein authored
Bug: None Change-Id: I4465415fcf5b378aa0598684cf1ee84058483d44 Reviewed-on: https://chromium-review.googlesource.com/c/1474533 Auto-Submit: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#632423}
-
Yann Dago authored
Bug: 924632 Change-Id: I9ba550c5ccb54d06a41f7dfbef28b5a1ed3eecf4 Reviewed-on: https://chromium-review.googlesource.com/c/1440068 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#632422}
-
Darwin Huang authored
- no logic changes, just cleaning up code Change-Id: I3bb1943d3160a3e2007c86b9c6d0b1b5b05fc586 Reviewed-on: https://chromium-review.googlesource.com/c/1474290 Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Xianzhu Wang authored
This is to avoid full layer raster invalidation when the layer known to be composited changes paint offset. Bug: 921729 Change-Id: I3340c2104ac6a6187f082ce23c0ceff411eb8eda Reviewed-on: https://chromium-review.googlesource.com/c/1410165Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#632420}
-
Matt Mueller authored
Add crypto::EnsureNSSInit to ClientCertStoreNSSTestDelegate, due to the use_byte_certs changes NSS will not have been initialized already. Bug: 716594,733922 Change-Id: I07f79cba8b482866ee9e2ea3e74355361393e5f8 Reviewed-on: https://chromium-review.googlesource.com/c/1474132Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#632419}
-
Alexander Timin authored
This will allow us to connect a place which send the mojo message and the place which received it. R=rockot@google.com CC=dmurph@chromium.org BUG=932167 Change-Id: Iea1bb6f1645279d21ad329f983f4112469c138e0 Reviewed-on: https://chromium-review.googlesource.com/c/1473233Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#632418}
-
Yao Xiao authored
It should be okay to support the flag without enabling the intervention feature (i.e. when a website adapts by adding the "allow-downloads-" token, we should no longer give deprecation warnings & should not give console errors "...invalid sandbox flag". Both would happen if we don't support the token.). Supporting the token will also change the result of IsSandboxed(kSandboxDownloads): previously it was always True; now it will be False if the "allow-downloads-" token is set. It will make the UseCounter DownloadInSandbox keep decreasing as more and more websites are adapting to the change. This also looks positive as it gives an idea of ongoing compatibility risk rather than the maximum risk. Bug: 539938 Change-Id: I002f1a556205344953dabf094849af7e1222dd9f Reviewed-on: https://chromium-review.googlesource.com/c/1471002Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/master@{#632417}
-
Lloyd Pique authored
This reverts commit ad28299e. Reason: This causes a crash deep in the Wayland code on startup, trying to deserialize the message. Reproduced on a Reef (Nougat) device. Bug: 932185, b:122704772 TBR=oshima@chromium.org, tetsui@chromium.org, yhanada@chromium.org Test: Reef Chromebook boots ARC after revert Change-Id: I68b7dce136496afedc285b7fcd5fc48b1dcb43bb Reviewed-on: https://chromium-review.googlesource.com/c/1474684Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Auto-Submit: Lloyd Pique <lpique@chromium.org> Cr-Commit-Position: refs/heads/master@{#632416}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/77874e2ca341..366df2b26dd1 git log 77874e2ca341..366df2b26dd1 --date=short --no-merges --format='%ad %ae %s' 2019-02-14 geofflang@chromium.org Vulkan: Support external texture binding points. Created with: gclient setdep -r src/third_party/angle@366df2b26dd1 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: Ib5f05a6e28180ec782ed6135892d7d6a493f1040 Reviewed-on: https://chromium-review.googlesource.com/c/1474555Reviewed-by:
-
Sergey Ulanov authored
Some blink unittests depend on common fonts which may not be available on all platforms. This problem is solved in blink layout tests by using custom font configuration with fonts from //third_party/test_fonts . Previously the corresponding code was part of content_shell. Moved it to //skia to make it possible to reuse it for blink_platform_unittests and skia_unittests. Bug: 928459 Change-Id: Ic7ea1e53c29ca9aea9014ed6c778ad0f8a2de6fb Reviewed-on: https://chromium-review.googlesource.com/c/1469287Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#632414}
-
Adam Langley authored
This change adds a number of new operations to |FidoAuthenticator| to support PIN operations. Change-Id: I84b93879efb79a9bdb49482545d8e0ea68d277bf Reviewed-on: https://chromium-review.googlesource.com/c/1460411Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#632413}
-
Devlin authored
This reverts commit a94eef13. Reason for revert: Cast tests are failing on ChromiumOS MSAN: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ChromiumOS%20MSan%20Tests/11290 Original change's description: > Move tab mirroring performance tests into browser_tests. > > This moves TabCapturePerformanceTest and CastV2PerformanceTest into > browser_tests. By default, they have been changed to run in a quick- > check mode. When run for performance testing on the perf bots, the > additional --full-performance-run command line switch will be required. > > The performance_browser_tests isolate config has been changed to run > browser_tests with the --full-performance-run switch, gtest filters, > and timeout overrides. Also, the old performance_browser_tests GN test > target has been turned into a simple group target that groups the > necessary data dependencies for running on the perf bots. > > This change also includes some changes to allow the tests to complete > in the absence of tracing data when in quick-check mode. While most > bots do collect a reasonable amount of tracing data in a few short > seconds, one or two don't always do so. Unfortunately, we can't justify > making the CQ run longer to force data collection in all cases. > > Bug: 804191 > Change-Id: I2de6c0b94453981fb0d9015f6b3f0e42f57cc2a6 > Reviewed-on: https://chromium-review.googlesource.com/c/1428399 > Commit-Queue: Yuri Wiitala <miu@chromium.org> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Reviewed-by: Caleb Rouleau <crouleau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#632366} TBR=miu@chromium.org,crouleau@chromium.org,jochen@chromium.org Change-Id: I4c12b48c4ec82877c06ebb460a08a9944a6f5504 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 804191 Reviewed-on: https://chromium-review.googlesource.com/c/1474282Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#632412}
-
Scott Violet authored
During a window move loop events should not be sent to the client. There are some cases that might trigger generating an event during the loop, that could target the window. These should be ignored. BUG=931878 TEST=none Change-Id: I64fc6ac7212f3db4f8d64a8a9dc96d6f6355b26c Reviewed-on: https://chromium-review.googlesource.com/c/1474797Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#632411}
-
Nico Weber authored
Bug: 926235 Change-Id: I3a65db96b88035f4953a169e79a718ac3252e339 Reviewed-on: https://chromium-review.googlesource.com/c/1463160 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#632410}
-
Dale Curtis authored
Simply moves the win7 expectation to win since they both use the same one. Formats the HTML and adds a title too. --------------[ Original Description Below ]-------------- Apparently we don't have any vpx-alpha layout tests, hence macOS has had broken support here for some time. BUG=919015 TEST=fails without the macOS alpha fix. TBR=dcastagna Change-Id: I9defe5b3750faeedd63ef0b62aaddb067a7fbc3f Reviewed-on: https://chromium-review.googlesource.com/c/1471355Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#632409}
-
Toni Barzic authored
The test was timing out waiting for a message from the test app. The problem was that in CrashRestore test, the app launch is expected to happen early on, during chrome session set up - before the test main part is run, and when the TestExtensionMessageListener is registered. This CL moves extension message listener registration earlier in the browser test setup (note that SetUpOnMainThread might be too late, while SetUp is too early as message loop is not yet initialized). BUG=930345 TEST=Ran the test with gtest_repeat=20, with no failures Change-Id: I12c8d40fc52270492723a14b764a9cc7e3a619a6 Reviewed-on: https://chromium-review.googlesource.com/c/1474794Reviewed-by:
-
Caleb Rouleau authored
This reverts commit 76044ee0. Reason for revert: speculative: https://bugs.chromium.org/p/chromium/issues/detail?id=932301 BUG=932301 Original change's description: > Reland "Cleanup run_performance_tests.py's output files handling" > > Relanding https://chromium-review.googlesource.com/c/1449151 with fixes. > > Patchset 1 is https://chromium-review.googlesource.com/c/1449151 > > Patchset 2 is https://chromium-review.googlesource.com/c/1464228 > > Patchset 3 is the new fix. When you run a telemetry benchmark as a > reference, you are supposed to do > `run_benchmark benchmark_name --browser=reference` > but I thought that you were supposed to do > `run_benchmark benchmark_name.reference --browser=reference` > because I read the earlier code wrong. > I also added a end to end test for this behavior, which also > covers sharding code as well. > > Patchset 5 is a unittest for > https://chromium-review.googlesource.com/c/1464228 > > Bug: 930879, 928928, 927507, 923628, 920002, 744736 > Change-Id: If73d929b8e1b32c33d2bed7d2298b64d205658c1 > Reviewed-on: https://chromium-review.googlesource.com/c/1467907 > Reviewed-by: Emily Hanley <eyaich@chromium.org> > Reviewed-by: John Chen <johnchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#632333} TBR=crouleau@chromium.org,eyaich@chromium.org,johnchen@chromium.org Change-Id: I84729563d3fa708edb9329f41c3bf2f0666f1818 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 930879, 928928, 927507, 923628, 920002, 744736 Reviewed-on: https://chromium-review.googlesource.com/c/1474971Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#632407}
-
- 14 Feb, 2019 9 commits
-
-
Jinsuk Kim authored
Now that https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/813849 landed, the methods left unused in Tab can be cleaned up. Bug: 925242 Change-Id: I64e0d8a6868644ce1843fbc965b6a3fa920d8e11 Reviewed-on: https://chromium-review.googlesource.com/c/1470285Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#632406}
-
Takumi Fujimoto authored
Enable the feature to replace the WebUI Cast dialog with a Views dialog by default. Bug: 754101 Change-Id: I80fff11bf849c44a49de2f93a95ede08986f6a78 Reviewed-on: https://chromium-review.googlesource.com/c/1464925 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#632405}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3ab00a7d068b..2b14855de938 git log 3ab00a7d068b..2b14855de938 --date=short --no-merges --format='%ad %ae %s' 2019-02-14 vadimsh@chromium.org [cipd] Update CIPD 2.2.15 -> 2.2.16. 2019-02-14 tikuta@chromium.org Support --enable-auto-submit in `git cl split` Created with: gclient setdep -r src/third_party/depot_tools@2b14855de938 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:931755,chromium:927178 TBR=agable@chromium.org Change-Id: I894fc0fd7072fa193745cce27e17ad0754e9c271 Reviewed-on: https://chromium-review.googlesource.com/c/1474294Reviewed-by:
-
Marcin Wiącek authored
@IntDef/@StringDef annotation are preferred way for declaring set of String/int values 1. they need less space in APK than enum, see https://developer.android.com/topic/performance/reduce-apk-size#remove-enums 2. they give more control over allowed values than "static final" values Patch is migrating SafeBrowsingResult to @IntDef with form common with other Chrome @IntDef: 1. with @IntDef first, @Retention second and related @interface third 2. with values inside @interface 3. with @Retention(RetentionPolicy.SOURCE) 4. without "static final" in the @interface BUG=919666 Change-Id: I385d880a50373481ea84a5ec82ee73347f01ff49 Reviewed-on: https://chromium-review.googlesource.com/c/1450267Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Cr-Commit-Position: refs/heads/master@{#632403}
-
Nico Weber authored
This CL was uploaded by git cl split. R=posciak@chromium.org Bug: 926235 Change-Id: I1dd8c021766144563372dc1b8cf495ba15862433 Reviewed-on: https://chromium-review.googlesource.com/c/1464343 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#632402}
-
Hao Zhang authored
Bug: 931382 Change-Id: I0422682825f6cd930a95931c55972e78336100a4 Reviewed-on: https://chromium-review.googlesource.com/c/1457666Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Hao Zhang <hozhng@google.com> Cr-Commit-Position: refs/heads/master@{#632401}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/754352edf2d9..c79285cb0afd git log 754352edf2d9..c79285cb0afd --date=short --no-merges --format='%ad %ae %s' 2019-02-14 tbarzic@chromium.org Disable RepeatableScrollActionNoRepeats on chromeos Created with: gclient setdep -r src/third_party/catapult@c79285cb0afd The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:932104 TBR=sullivan@chromium.org Change-Id: Ia9a0484c44c537b88504a5745efc7c5f18b53fc6 Reviewed-on: https://chromium-review.googlesource.com/c/1474550Reviewed-by:
-
Jay Harris authored
The BoxLayout doesn't seem to deal with label eliding properly (the origin of the text moves around). This moves to the new FlexLayout, which handles the resizing correctly. Bug: 929944 Change-Id: Ie66f399cc85e500b5318d987d4759954e972c1b8 Reviewed-on: https://chromium-review.googlesource.com/c/1460197 Auto-Submit: Jay Harris <harrisjay@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Jay Harris <harrisjay@chromium.org> Cr-Commit-Position: refs/heads/master@{#632399}
-
Dave Tapuska authored
The interface was only used for tests. Move the tests into blink and remove the interface. BUG=591921 Change-Id: I738449a5acd01adf1cf24ed48d84a2dbc447c5fa Reviewed-on: https://chromium-review.googlesource.com/c/1472853 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#632398}
-
