GitLab

Local change slipped in to commit

BUG=163653
TBR=frankf@chromium.org

Review URL: https://codereview.chromium.org/11412277

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170509 0039d316-1c4b-4281-b951-d872f2087c98

This is so it can be run optionally on the trybots.


Review URL: https://chromiumcodereview.appspot.com/11299263

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170508 0039d316-1c4b-4281-b951-d872f2087c98

This CL extends the UserManager to handle public accounts defined through
policy. User pods are dynamically added and removed when the list of
public accounts in policy changes. Any data belonging to obsolete accounts
is also removed, taking care not to remove it prematurely if a user is
currently logged into the account.

The CL also makes the user list handling more robust by checking for
duplicate entries in the user list prefs and logging these as errors.

The pods added for public accounts are not functional yet. The login flow
for public accounts will be the topic of another CL.

BUG=158509


Review URL: https://chromiumcodereview.appspot.com/11419184

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170507 0039d316-1c4b-4281-b951-d872f2087c98

BUG=161603
TEST=bubbles have shadows


Review URL: https://chromiumcodereview.appspot.com/11418244

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170506 0039d316-1c4b-4281-b951-d872f2087c98

This fixes the use after free problem that can occur if the Seek
or Read request on the worker thread runs after the job has been
deleted.

TEST=AndroidWebViewTests,android_webview_unittests
BUG=None
R=mnaganov@chromium.org


Review URL: https://chromiumcodereview.appspot.com/11428052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170505 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sky@chromium.org
BUG=145623
TEST=none

Review URL: https://codereview.chromium.org/11418263

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170503 0039d316-1c4b-4281-b951-d872f2087c98

* New argument --bundle-version, can be passed multiple times. The updater will
use the version passed in.
* The updater won't upload a manifest if it hasn't changed.
* The updater won't rollback a bundle (i.e. if the automatically determined
  revision is older, it will keep the current bundle).
* Switch --dryrun to use difflib instead of system diff.
* Add equality testing for manifest_util.SDKManifest. It already existed for
  Bundles.

BUG=none
R=sbc@chromium.org
TBR=noelallen@chromium.org
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/11421138

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170500 0039d316-1c4b-4281-b951-d872f2087c98

This patch sets a missing accessible name for the buttons.

BUG=152089


Review URL: https://chromiumcodereview.appspot.com/11421167

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170499 0039d316-1c4b-4281-b951-d872f2087c98

BUG=


Review URL: https://chromiumcodereview.appspot.com/11413065

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170498 0039d316-1c4b-4281-b951-d872f2087c98

Remove GetExtensionService calls and replace with PKSF calls through the ExtensionSystem. Extension services were made into ProfileKeyedServices a while ago; this replaces the deprecated calls that ran directly through the Profile object.

This is about half of the total GetExtensionService calls in the codebase, but this CL is already ridiculously large.

BUG= http://code.google.com/p/chromium/issues/detail?id=104095


Review URL: https://chromiumcodereview.appspot.com/11365181

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170497 0039d316-1c4b-4281-b951-d872f2087c98

There is no usage of selection_item_id and radio grouping logic is in engine.
So it is safe to remove selection_item_id from Chrome.

I checked property behaviors and there is no regression on Japanese/Simplified Chinese/Traditional Chinese/Hangul.
(including radio handling, property order, activation handling etc...)

I also checked any properties in all m17n engines, but there is no property.

BUG=None
TEST=Manually done on lumpy


Review URL: https://chromiumcodereview.appspot.com/11416261

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170496 0039d316-1c4b-4281-b951-d872f2087c98

In Chrome ASH on Windows 8 the ASH process could be closed with open browser windows. Make sure that we close them before
uninitializing ASH as that causes DCHECKs/crashes.

Added a local helper function CloseOpenAshBrowsers which runs through the list of open ASH browsers and closes them.

BUG=151718
R=sky
Review URL: https://codereview.chromium.org/11434013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170493 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
Android only whitelist change. WebView license check step passes
NOTRY=true
TBR=torne@chromium.org

Review URL: https://chromiumcodereview.appspot.com/11414263

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170492 0039d316-1c4b-4281-b951-d872f2087c98

BUG=163111
TEST=ran chromeos_unittests

Review URL: https://chromiumcodereview.appspot.com/11416243

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170490 0039d316-1c4b-4281-b951-d872f2087c98

BUG=157918
TEST=Manually on device

Review URL: https://chromiumcodereview.appspot.com/11316214

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170489 0039d316-1c4b-4281-b951-d872f2087c98

That patch speeds up Google Maps use-case smoke test by a factor of 10x.
It also reduces memory pressure on the GPU. See the related bugs for more info.


BUG=161434,160871


Review URL: https://chromiumcodereview.appspot.com/11316171

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170487 0039d316-1c4b-4281-b951-d872f2087c98

This will hide the popup when the browser changes size or location. Also add some tests for the WidgetObserver for the function we are observing with.


BUG=


Review URL: https://chromiumcodereview.appspot.com/11308124

TBR=csharp@chromium.org
Review URL: https://codereview.chromium.org/11416286

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170486 0039d316-1c4b-4281-b951-d872f2087c98

This should be a good speedup once checking for if a matrix is identity is faster  (i.e. https://codereview.appspot.com/6854113/)- otherwise it's a bit of a wash.

BUG=

Review URL: https://chromiumcodereview.appspot.com/11434027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170485 0039d316-1c4b-4281-b951-d872f2087c98

* View system calls onDetachedFromWindow after HTMLViewer already
calle destroy so need a check in onDetachedFromWindow.
* PageID in restored entries needs to be reset (0-indexed).
* Need to call NavigationController::LoadIfNecessary after calling
Restore to actually load the restored page.
* Need to call onTitleUpdated callback since title is restored and
the callback is optimized out inside chromium.

BUG=
TBR=joth@chromium.org
Android only change. Ran through android trybots.
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11428070

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170484 0039d316-1c4b-4281-b951-d872f2087c98

TBR=ben@chromium.org
BUG=155525


Review URL: https://chromiumcodereview.appspot.com/11280115

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170483 0039d316-1c4b-4281-b951-d872f2087c98

Add focus rules for Ash. They are empty for now. I will begin migrating code over from ActivationController once I have a flag to turn this on.

http://crbug.com/162100
R=sky@chromium.org
Review URL: https://codereview.chromium.org/11414252

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170479 0039d316-1c4b-4281-b951-d872f2087c98

This uncovered an old bug in Window - if the removal results in a restack, the iterator is invalid. Fortunately we can just defer the iterator creation until after the notification.

With the restacking one activation test expecation also changes.

http://crbug.com/162100
R=sky@chromium.org
Review URL: https://codereview.chromium.org/11348314

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170478 0039d316-1c4b-4281-b951-d872f2087c98

It is mostly unused, except for one place in RenderWidgetHostViewAura, where depending on the event type etc it will have a consequence. I think it's bad for a method with a const-sounding name like "ShouldActivate" to have side-effects.

Instead, I made the RWHVA store the data that would indicate a pointer activate and check that state during OnActivated(). It'd be a little cleaner if OnActivated had some way of knowing what the currently processed input event was, hence the TODO.

http://crbug.com/162100
R=sadrul@chromium.org
Review URL: https://codereview.chromium.org/11419251

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170477 0039d316-1c4b-4281-b951-d872f2087c98

BUG=161992


Review URL: https://chromiumcodereview.appspot.com/11412248

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170476 0039d316-1c4b-4281-b951-d872f2087c98

After r 170256, the suppression should be updated:
http://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Tests%20%28tsan%29/builds/13286/steps/memory%20test%3A%20media/logs/stdio

BUG=157076
TEST=none
TBR=glider@chromium.org

Review URL: https://codereview.chromium.org/11412269

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170475 0039d316-1c4b-4281-b951-d872f2087c98

With this patch, we won't have to keep modifying gpu_benchmarking_extension when
we add new fields to RenderStats.

BUG=163073


Review URL: https://chromiumcodereview.appspot.com/11280210

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170474 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170473 0039d316-1c4b-4281-b951-d872f2087c98

Revert 170460 - Revert 170448 - Roll Skia DEPS to r6630

Getting FATAL:image_skia.cc(388)] Check failed: CanRead() in EnableAppModeTest

control: https://codereview.chromium.org/11419241/
Review URL: https://codereview.chromium.org/11416276

TBR=robertphillips@google.com
Review URL: https://codereview.chromium.org/11416284

TBR=robertphillips@google.com
Review URL: https://codereview.chromium.org/11418258

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170472 0039d316-1c4b-4281-b951-d872f2087c98

BUG=160657
For chrome/browser/ui/views/notifications/
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/11414215

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170471 0039d316-1c4b-4281-b951-d872f2087c98

The implementation is done as a subclass of MessagePumpNSRunLoop. It is conceptually quite similar to the libevent implementation (message_pump_libevent*), on which it is based.


Review URL: https://chromiumcodereview.appspot.com/11412101

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170470 0039d316-1c4b-4281-b951-d872f2087c98

Avoid posting tasks from a constructor of a ref-counted object because doing so might cause premature deletion of the object.

BUG=163559


Review URL: https://chromiumcodereview.appspot.com/11316267

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170468 0039d316-1c4b-4281-b951-d872f2087c98

BUG=149937

Review URL: https://codereview.chromium.org/11411244

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170467 0039d316-1c4b-4281-b951-d872f2087c98

- Add and fix comments
- Make some members private
- Make some members const
- Give better names to parameters
  (in particular document_url -> content_url/edit_url)

BUG=163544,163558
TEST=none



Review URL: https://chromiumcodereview.appspot.com/11419253

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170466 0039d316-1c4b-4281-b951-d872f2087c98

- Changes the background color lighter
- Adds 'shadow' at the bottom of each card. Boder is no longer used.
See the issue for the current screenshot.

BUG=161052
TEST=manually check on goobuntu


Review URL: https://chromiumcodereview.appspot.com/11412240

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170465 0039d316-1c4b-4281-b951-d872f2087c98

RunAllPending() is deprecated and we should switch to RunUntilIdle().

BUG=131220
TBR=ajwong@chromium.org


Review URL: https://chromiumcodereview.appspot.com/11421172

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170464 0039d316-1c4b-4281-b951-d872f2087c98

BUG=161958


Review URL: https://chromiumcodereview.appspot.com/11348254

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170463 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/11299275

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170462 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170461 0039d316-1c4b-4281-b951-d872f2087c98

Getting FATAL:image_skia.cc(388)] Check failed: CanRead() in EnableAppModeTest

control: https://codereview.chromium.org/11419241/
Review URL: https://codereview.chromium.org/11416276

TBR=robertphillips@google.com
Review URL: https://codereview.chromium.org/11416284

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170460 0039d316-1c4b-4281-b951-d872f2087c98

Revert 170451 - [content shell] add support for testRunner.canOpenWindows and disallow opening windows per default for layout tests

BUG=111316
R=marja@chromium.org

Review URL: https://codereview.chromium.org/11411282

TBR=jochen@chromium.org
Review URL: https://codereview.chromium.org/11414260

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170459 0039d316-1c4b-4281-b951-d872f2087c98