GitLab

Platform expectations are that the stack is aligned to 8 bytes on
32-bit platforms and 16 bytes on 64-bit platforms. Having the stack
buffer aligned will facilitate alignment-correct implementation within
the stack copying itself.

Bug: 956626
Change-Id: I217c1948d271839e22283f884adbaa6a14f1c4a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593803
Commit-Queue: Mike Wittman <wittman@chromium.org>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657550}

We already have a use counter for decodingInfo(), but suppling the key
system configuration implies EME usage, which is the recent foucs for
investments and upcoming experiments.

Bug: 953500
Change-Id: I22b07b1c579d7e7bb0427ec85c765ebec1629bd2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592696
Commit-Queue: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Auto-Submit: Chrome Cunningham <chcunningham@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657549}

This is only used in tests. Instead provide a test only function to test
equality.

BUG=696822

Change-Id: I97ec7787aaea8ac0c73c662baa7fea05109e1364
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595424
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657548}

This is a reland of 12b30300

It adds mojom_platform to 'interfaces' from //content/public/common/BUILD.gn
to fix compilation error from mac_rel.

Original change's description:
> Reland "OnionSoup: Move web_bluetooth.mojom to public/mojom/bluetooth"
>
> This is a reland of d5b00821
>
> It updates //BUILD.gn and //content/public/common/BUILD.gn
> in addition to the previous change to fix the dependency
> problem.
>
> Original change's description:
> > OnionSoup: Move web_bluetooth.mojom to public/mojom/bluetooth
> >
> > This CL moves bluetooth folder from public/platform/modules to
> > public/mojom/ to gather mojom files to mojom folder with
> > creating web_bluetooth_mojo_bindings.
> >
> > Bug: 919393
> > Change-Id: I42037e1c9738b03969e927dd00f6b24c2873b364
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530369
> > Reviewed-by: Kentaro Hara <haraken@chromium.org>
> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> > Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
> > Reviewed-by: John Budorick <jbudorick@chromium.org>
> > Reviewed-by: Doug Turner <dougt@chromium.org>
> > Reviewed-by: Colin Blundell <blundell@chromium.org>
> > Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com>
> > Cr-Commit-Position: refs/heads/master@{#649061}
>
> Bug: 919393
> Change-Id: I61de3e625205e54959ad8d36c84eefa95f861035
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559368
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Colin Blundell <blundell@chromium.org>
> Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com>
> Cr-Commit-Position: refs/heads/master@{#652487}

Bug: 919393
Change-Id: Iae407fa213a9f9335b7bbc695c87369d124c745e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575560
Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657547}

No longer used.

Bug: 960564
Change-Id: I07220d3d1d60cdc013fad1909e96636f2c56ac4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600603
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657546}

Bug: 944061
Change-Id: Ie6f376c3571fa5942ad14a1f642fbf9102f8b7d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600558Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657545}

FeatureList::IsFeatureEnabled and FeatureList::GetAssociatedFieldTrial
call std::map<std::string, _>::find() with a const char* argument. By
default, this results in a conversion to an std::string, hence
incurring a memory allocation.

C++14 adds a new std::map::find() override to support map lookups by
types other than the key when a transparent comparator is specified.
This allows, for example, performing lookups in an
std::map<std::string, _> using a const char*. This CL changes the
declartion of FeatureList::overrides_ to support these allocation-free
lookups.

Bug: 960618

Change-Id: I59c8d2c16e86a3a6ca458b4047c445b1373df05d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600083
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657544}

Roll src/third_party/cros_system_api/ d6ec70dbe..70f65b7ac (7 commits)

https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/d6ec70dbe6b7..70f65b7ac09d

$ git log d6ec70dbe..70f65b7ac --date=short --no-merges --format='%ad %ae %s'
2019-05-05 derat system_api, power: Allow slow brightness transitions.
2019-05-03 menghuan attestation: Remove CreateGoogleAttestedKey API
2019-05-06 pbond system_api: remove diagnosticsd constants
2019-05-03 benchan system_api: shill: remove unused kWifiAuthMode constant
2019-04-30 benchan system_api: drop wimax_manager constants
2019-04-10 menghuan attestation: Make the attestation daemon decide the EK key type
2019-03-08 ljusten kerberos: Add ListAccounts method

Created with:
  roll-dep src/third_party/cros_system_api

Change-Id: I29f582ee2e8110068afff48d3f185a1a8973bfa1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600460Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Jia Meng <jiameng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657543}

Since the media code marks candidates opaque based on the video format,
it is common to have video quads be marked not opaque. If we use any
strategy other than an underlay in this case, the damage rect for the
overlay is not subtracted from the damage rect for the OutputSurface
plane which causes us to unnecessarily redraw the main plane.

R=liberato@chromium.org, piman@chromium.org

Bug: 889328
Change-Id: I3e5436b051b1becc39b5b5396ec3f676afc203b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600492Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657542}

This reverts commit 88b589af.

Reason for revert: causes issue 960436

This seems worse than the original issue, so reverting now while chrishtr is out.

Original change's description:
> Adjust rounded corner bounds when aggregating quads into a new target state.
> 
> The rounded_corner_bounds field of SharedQuadState needs to be in the
> space of the target render surface. When changing that target, therefore,
> rounded_corner_bounds needs to be updated accordingly.
> 
> Bug: 947715
> 
> Change-Id: I83b3f773d960e82d75060326c197ef12ae1755fc
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590900
> Reviewed-by: enne <enne@chromium.org>
> Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#656424}

TBR=chrishtr@chromium.org,enne@chromium.org,sammiequon@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 947715,960436
Change-Id: I68dbe7679ce90d0de6be4ef1a3958d3ec8f94a89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600435Reviewed-by: enne <enne@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657541}

On some devices this occasionally crashes, so catch the exception and
gracefully fail.

BUG=946906
TEST=manual playback with Shaka

Change-Id: Iee94afeedfc88b034225ce7c7795dcce2b50a347
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597657
Commit-Queue: John Rummell <jrummell@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657540}

Implementation of moving by TextUnit_Format. This relies on existing
text attributes stored on AXNodeData as a "format". A new class
was introduced for quickly comparing two different text formats,
named "AXNodeTextStyles". New methods were added to AXPosition to
navigate by format, either to the start or end of a format boundary,
which AXPlatformNodeTextRangeProvider relies on for format navigation.

Tests were added for the new class, AXPosition navigation, and
AXNodeData functionality.

Bug: 928948
Change-Id: I91ad34cc67ea8996bb18b4d2c4c4597738bc7854
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584596
Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#657539}

This reverts commit 0af2a61e.

Reason for revert: Need another round of crash capturing.

Original change's description:
> Revert "Reland "[LayoutNG] Turn AssertLaidOut into a CHECK for LayoutNG" round 3"
> 
> This reverts commit cbdaf211.
> 
> Reason for revert: Crash data already collected in 3763 and 3764
> 
> Original change's description:
> > Reland "[LayoutNG] Turn AssertLaidOut into a CHECK for LayoutNG" round 3
> > 
> > This reverts commit 33b5c673.
> > 
> > Reason for revert: Adding production CHECKs to collect LayoutNG failures
> > for the 3rd time.
> > 
> > Original change's description:
> > > Revert "Reland "[LayoutNG] Turn AssertLaidOut into a CHECK for LayoutNG""
> > > 
> > > This reverts commit 26ca019a.
> > > 
> > > Reason for revert: Crash data already collected
> > > 
> > > Original change's description:
> > > > Reland "[LayoutNG] Turn AssertLaidOut into a CHECK for LayoutNG"
> > > > 
> > > > This reverts commit ec11fe81.
> > > > 
> > > > Reason for revert: Try to catch more crashes in the wild after
> > > > a fix (crrev.com/c/1546713) has been landed.
> > > > 
> > > > Original change's description:
> > > > > Revert "[LayoutNG] Turn AssertLaidOut into a CHECK for LayoutNG"
> > > > > 
> > > > > This reverts commit bade42c5.
> > > > > 
> > > > > Reason for revert: New crashes already caught. Reverting CHECKs
> > > > > back into DCHECKs to reduce noises.
> > > > > 
> > > > > Original change's description:
> > > > > > [LayoutNG] Turn AssertLaidOut into a CHECK for LayoutNG
> > > > > > 
> > > > > > Bug: 946004
> > > > > > Change-Id: I9e2aa69a32f7a0373196d57e629256dbc7d78d2a
> > > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540305
> > > > > > Reviewed-by: Koji Ishii <kojii@chromium.org>
> > > > > > Reviewed-by: Emil A Eklund <eae@chromium.org>
> > > > > > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
> > > > > > Cr-Commit-Position: refs/heads/master@{#644907}
> > > > > 
> > > > > TBR=eae@chromium.org,kojii@chromium.org,xiaochengh@chromium.org
> > > > > 
> > > > > Change-Id: I15fb43370f58757e09e7b7abc7c40d4af4a6101a
> > > > > No-Presubmit: true
> > > > > No-Tree-Checks: true
> > > > > No-Try: true
> > > > > Bug: 946004
> > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1544156
> > > > > Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
> > > > > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
> > > > > Cr-Commit-Position: refs/heads/master@{#645407}
> > > > 
> > > > TBR=eae@chromium.org,kojii@chromium.org,xiaochengh@chromium.org
> > > > 
> > > > # Not skipping CQ checks because original CL landed > 1 day ago.
> > > > 
> > > > Bug: 946004
> > > > Change-Id: Iccb8c2b998d28f659381c3f89a1686614600860c
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548248
> > > > Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
> > > > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
> > > > Cr-Commit-Position: refs/heads/master@{#646516}
> > > 
> > > TBR=eae@chromium.org,kojii@chromium.org,xiaochengh@chromium.org
> > > 
> > > # Not skipping CQ checks because original CL landed > 1 day ago.
> > > 
> > > Bug: 946004
> > > Change-Id: I9794539b39bc6a0053a7229b03bce7db402ecb5b
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551440
> > > Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
> > > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#647418}
> > 
> > TBR=eae@chromium.org,kojii@chromium.org,xiaochengh@chromium.org
> > 
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> > 
> > Bug: 946004
> > Change-Id: I973ccf65be78d4632f67b945614f1a4ee091134d
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562500
> > Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
> > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#649773}
> 
> TBR=eae@chromium.org,kojii@chromium.org,xiaochengh@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 946004
> Change-Id: If61d1cbfaeb6a445b8ceee193dba198978d2719c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1567130
> Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#650624}

TBR=eae@chromium.org,kojii@chromium.org,xiaochengh@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 946004
Change-Id: I43e61cc397ebbb44fb15f9a5bc0448077c281f60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600400Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657538}

This CL moves three of the current browser tests to run with and without
MimeHandlerViewInCrossProcessFrame.

TBR=wjmaclean@chromium.org

Bug: 659750
Change-Id: I13f10b15a0d173f17faf41d19a7e2e650f072ea3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600313
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Reviewed-by: Ehsan Karamad <ekaramad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657537}

The class is not being referred on the file touched.

This is part of bigger the effort to confine WebCallbacks and
ScopedWebCallbacks classes within Blink.

R=jbroman@chromium.org

BUG=945851

Change-Id: Ia414c9e9d596de65ade4ff0255c5df0e0bd2ed01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599192
Auto-Submit: Antonio Gomes <tonikitoo@igalia.com>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657536}

Tail suggestions are launched, so remove flags that refer to it.

Bug: 726769
Change-Id: If15ff4406c6e897c745ff9c625bdf7a7419d3f08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599904Reviewed-by: Orin Jaworski <orinj@chromium.org>
Commit-Queue: Kevin Bailey <krb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657535}

Now that we're no longer shipping mash, this code can be removed. Also, I'm
removing AshServiceTest as it triggers hitting a DCHECK because of this
change. AshService will go away shortly anyway.

BUG=958203
TEST=this removes dead code

Change-Id: I606d72737eb88c0cdda12269af8da4b2908cbfdd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600637
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657534}

- Exit overview mode normally if mini_view of already active desk
  is selected.
- Minimized windows on inactive desks should not be considered
  activatable.
- Minimized windows should not be activated on switching back to
  their desk.

BUG=866622
TEST=Manually and added new tests

Change-Id: Icd846e408a0e26c696ade1d86361e782362f64da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600252
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657533}

Create histograms to track the state transition from the Connected
state to the Redirect Found state. Implemented in CL:1548770.

Bug: 903645
Change-Id: I8b906f96d72ec98abd8d09ce4f4f20631014136a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549682
Commit-Queue: Matthew Wang <matthewmwang@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657532}

If the opt-in window already exists while showing, focus it.

Bug: b/131250731, b/130374617
Change-Id: I53936eed349602d19771b94177367223b56d2ce9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590877
Commit-Queue: Yue Li <updowndota@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657531}

Part 2 of 2.

Add drag-and-drop reorder functionality to the new grid. While
reordering, the held tile will track the cursor but will not go beyond
the edges of the grid. When the tile is dropped, the EmbeddedSearchAPI
is notified of the new index and the tiles are swapped when we receive
the new tile set.

Only supported for mouse.

Screencast: https://drive.google.com/open?id=1pK8hihCU8HZr4Hb2nDhU3KXc_8BqGcTV

Bug: 851335
Change-Id: I7ae4531141ca662414a9f8730fd536508a757d39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592402
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657530}

Part 1 of 2.

Convert shortcuts from flexbox to absolute positioning. This allows us
to add animations to the shortcuts using transform.

This change adds the framework for future custom link animations and
adds animations for layout changes on window resize/zoom.

The old reorder logic is removed as well, and will be re-added in part
2.

Screencasts
LTR: https://drive.google.com/open?id=1mSpq__cnrmuJv0DDa3KhFv2iBCaFyguY
RTL: https://drive.google.com/open?id=1STJ5JZ7XV_k1g8AfbJm35GRTHmSsa-h7

Bug: 851335
Change-Id: Id63836e747a7c7dff4e25beaa1f082e7dc1f52e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591954
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657529}

This is a follow up CL to https://chromium-review.googlesource.com/c/chromium/src/+/1592977
to address some minor coding nits.

Bug: 891172
Change-Id: Ie2368ce9a06224f0c03609d6c54d1a2d2e0f1286
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597518
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657528}

https://swiftshader.googlesource.com/SwiftShader.git/+log/52a3bba8914f..1300ba188eee


git log 52a3bba8914f..1300ba188eee --date=short --no-merges --format='%ad %ae %s'
2019-05-07 sugoi@google.com Extension check in vkCreateDescriptorSetLayout
2019-05-07 sugoi@google.com vkBindImageMemory2 implementation
2019-05-07 chrisforbes@google.com Groundwork for quadlayout support in blit & copy ops


Created with:
  gclient setdep -r src/third_party/swiftshader@1300ba188eee

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:b/132156862
TBR=swiftshader-team+autoroll@chromium.org

Change-Id: I8ec29e2e473276ffe2e0b0cbaaf6566d7b39b51b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600572Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#657527}

This CL introduces the NotificationStore which glues the application
logic layer of notification scheduler and the database that persists
notifications to disk.

Bug: 930968
Change-Id: I7cc207df8c6208d95f8d9c6156e429659c77cf0f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597453
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657526}

PoliCheck violations include usages of potentially insensitive or
profane terms. Some are simple typos.

Change-Id: I73a331c1fc55e892d371c077f07024ee004ff8af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577694Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: James Hawkins <jhawkins@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Matt Siembor <msiembor@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#657525}

This comment about ownership was valid for about six weeks when this code
was written six years ago, but then ownership of FileSystemOperationRunner
was changed to no longer always be owned by FileSystemContext. This CL
updates the comment to reflect that.

Using raw pointers here is still mostly safe, as (since recently) all
places that own a FileSystemOperationRunner, also keep FileSystemContext
alive via a scoped_refptr.

Bug: none
Change-Id: Ica49f7062c78ce0f99f7268bebe59750544ae50a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600354
Auto-Submit: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657524}

Bug: 910739
Change-Id: I25bf423759ac715279954cc4a24023ae808404fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600455
Commit-Queue: Caroline Rising <corising@chromium.org>
Reviewed-by: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657523}

This reverts commit dc931ca8.

Reason for revert: this caused issues with iron-list focusing on rows in crbug/957940 and crbug/949931. Reverting with https://chromium-review.googlesource.com/c/chromium/src/+/1598845.

Original change's description:
> WebUI: FocusRowBehavior, focus on equivalent control only if up/down was pressed
> 
> Bug: 901771
> Change-Id: Iea4fa9e711024f7f78ac363ed652b350e953e17a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1544978
> Reviewed-by: Scott Chen <scottchen@chromium.org>
> Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#646951}

TBR=scottchen@chromium.org,aee@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 901771
Change-Id: I7de6a9e355434fd1c3a4a54a6d99c12fae5db5f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599684Reviewed-by: Esmael El-Moslimany <aee@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657522}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/83679a3cd6a7..a41b430df52b


git log 83679a3cd6a7..a41b430df52b --date=short --no-merges --format='%ad %ae %s'
2019-05-07 nednguyen@google.com cbuildbot: update ExtractBuildDepsGraph to no longer reference output_path in build depgraph proto


Created with:
  gclient setdep -r src/third_party/chromite@a41b430df52b

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@chromium.org

Change-Id: Iefef0f2f613f523b6366c9be1c674b0bf679646f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600412Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#657521}

This reverts commit 67f4c2f3.

Reason for revert: Revert while investigating new TSan warnings

Original change's description:
> Background tracing: Use the new Perfetto Consumer mojo endpoint
> rather than the TracingController.
> 
> This is in preparation for being able to handle proto traces
> in addition to JSON.
> 
> R=​ssid@chromium.org
> BUG=925151
> 
> Change-Id: I91ed3c9648587fb19a5102b869a5d5ab688e0187
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546146
> Commit-Queue: oysteine <oysteine@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: ssid <ssid@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#657413}

TBR=avi@chromium.org,oysteine@chromium.org,ssid@chromium.org

Change-Id: I92db1fa46353cfb960071f44d110a5faa0c25421
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 925151
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600305Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657520}

Mock implementation of ReportingCache::PersistentReportingStore that
stashes away commands to be checked by tests. Simulates pre-existing
stored endpoints and endpoint groups.

This also parametrizes ReportingCacheTest such that the ReportingCache
is constructed with or without a PersistentReportingStore. This doesn't
yet change anything because the ReportingCacheImpl doesn't yet do
anything with its store.

Bug: 895821
Change-Id: I03005cbbfca959b75d77997648a75b4052b90db8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594252
Commit-Queue: Lily Chen <chlily@chromium.org>
Reviewed-by: Eric Orth <ericorth@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657519}

For browser tests that use download service, content::DownloadManager needs to be
created so that DownloadDriverImpl has the SimpleDownloadManager object to carry
out the download task. However, some browser tests didn't explicitly create the
DownloadManager after profile creation, as this is done automatically in
DownloadServiceFactory.
This CL makes the download service creation to proceed without the
DownloadManager. But will set it whenever profile is created. It also works with
reduced mode as inprogressDownloadManager will be created to handle the download

BUG=942770

Change-Id: Idc2a1d996dd65c742dea0263e80a3e422c8d9b1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597948
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657518}

Bug: 941690
Change-Id: I45e8c531f63a7634ed77946032a3dd0fb10680be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595977Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657517}

Task IDs are metadata for tracking navigations and relationships between
navigations. They are stored on a NavigationEntry and the bookkeeping
happens via reading signals via NavigationEntryCommitted.

Bug: 958463
Change-Id: If97ae09ac7743ca37ce81bbe401a95e6eeaff5a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592516Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: David Maunder <davidjm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657516}

This relands commit 65046b8f,
plus an additional change:

Older versions of Bionic seems to use vfork() in their system()
implementations, so just EPERM it instead of crashing with SIGSYS.

Bug: 956644
Change-Id: Ibd84ca0a9c49cad3ba797a2632960f3978111c65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585108
Commit-Queue: Matthew Denton <mpdenton@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657515}

OobeScreenExitWaiter is intended to handle the case where the target
screen is the last screen, and oobe UI goes away when the target screen
exits.
To trully support this, the waiter should handle the case where the oobe
UI has already gone away when the waiter is started.

Change-Id: I9e8a56cc7a53560fa6a89748fbe9806d1a6b53d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598480Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657514}

This CL does several positive things:
 - allows us to have changes include non-basic types by removing the
   use of a C union in the Delta class
 - in lieu of std::variant, makes access to each type of change runtime
   type-safe via DCHECK()
 - make all changes single items rather than lists of (implicitly)
   homogeneous deltas

Each delta may affect multiple tabs, but only (currently) in the case
of multiple insert and multiple remove; we also make the fact that
there can be more than one page inserted or removed explicit.

Bug: 958103
Change-Id: If6b4291ab05857830b94d596d664653f128d1368
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576276Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657513}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b58501a3b11b..7978f9cb6d33


Created with:
  gclient setdep -r src-internal@7978f9cb6d33

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=nhiroki@chromium.org,iclelland@chromium.org,dullweber@chromium.org,jrummell@chromium.org

Change-Id: I8ca3b52a67fcc1f1a62dd678126efc08c8641d74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598501Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#657512}

This is part 1 of n for cleaning up shared_ptr. The first set of patches
is to remove all functionality from RemoteDeviceRef, so it can
eventually be removed.

The log truncation helper remains for now; that will be solved by the
second CL.

R=khorimoto@chromium.org

Bug: 960538
Change-Id: I7dd5f5137411c2cfaeed8492d03fea06fba5a648
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600495Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657511}