- 21 Aug, 2020 40 commits
-
-
Dana Fried authored
It feels weird to be able to drag the toolbar down in order to open the tabstrip tray in tablet mode but not drag up to close. This makes it possible to start a drag or fling with either the tray open or closed as long as the initial direction of the motion is correct (otherwise, the event is processed as normal). So for example, dragging or flinging down when the tray is closed, or dragging or flinging upwards when the tray is open will cause the tray to move, but not vice-versa. Bug: 1116651 Change-Id: I815d1ff189c28feb7fd6c81181e85ae37767a7ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361122Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#800412}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/cbfd396756c6..44e1791f100c 2020-08-20 srisser@google.com Add getPhysicalDeviceFeatures2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Id99ecc711a7e5904d1e57a8605d92c11aefba234 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367782 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800411}
-
Yuke Liao authored
This CL disables retrying invalid shards in coverage build. Bug: 1119972 Change-Id: If0679948a745f5897835ebd823d3201fcfcb661e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368235Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#800410}
-
Jan Wilken Dörrie authored
This change adds a CreateChangePasswordUrl utility for creating a change password URL depending on the state of the kWellKnownChangePassword feature flag. Furthermore, it updates the Password Check callsites for all platforms to use this method. Bug: 927473 Change-Id: I1019c92e15ee8357751fd0a166df8a830759e3f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367060 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#800409}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2d664c1b3323..b583133590a5 2020-08-20 cjamcl@chromium.org [Lighthouse] Use friendlyMessage for error display. 2020-08-20 jalyn@microsoft.com Sources: Fix "Add property path to watch" bug 2020-08-20 bingler@chromium.org Add link for Schemeful Same-Site issues If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1054036,chromium:977291 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5f359230656d859e307efd0a701cdddee605af9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368432Reviewed-by:
-
Nasko Oskov authored
This CL adds some traces that make understanding the flow of navigation events in the renderer process easier. These traces were very helpful in investigating https://crbug.com/1112815. Bug: 1043616 Change-Id: I97cd807b1c9fa3a35d26ecb33c7d200bba81f3e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353561 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#800407}
-
Dan Sanders authored
This reverts commit 51b274e8. Bug: 1045247 Change-Id: I4f22c1e340d6c2224eaccb29e41b2605efe0d47a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368493 Commit-Queue: Dan Sanders <sandersd@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Auto-Submit: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#800406}
-
Varun Khaneja authored
Fixed: 1119987 Change-Id: I0a6ed16da25a0ae09ad188d21fa1223dc063c007 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368413 Commit-Queue: Varun Khaneja <vakh@chromium.org> Auto-Submit: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#800405}
-
Claudio M authored
We have found this code as part of Cros-Borders project. Thanks to myy@ for discovering it. Bug: 1097287, b:163002438 Change-Id: I10643a0934677c0dcb43e59b7387155ca2792722 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366534 Commit-Queue: Claudio M <claudiomagni@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#800404}
-
chromium-internal-autoroll authored
Release_Notes:http://go/media_app-x20/relnotes/Nightly/media_app_202008200800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/dn-tZC1K2hB8pa-D8uCBdQh4U9xdeiQvV7QEmNoyTZQC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/153407132,b/159083441 Tbr: media-app@grotations.appspotmail.com Change-Id: I23699cd4b753bf3a0e8c010e6f20e4e91734c620 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367992Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800403}
-
Eric Orth authored
Bug: 1093361 Change-Id: I54f3d2642c41ffebcb584d816eeca36ae0dca702 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364082 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#800402}
-
Xinghui Lu authored
Metric added in this CL: SafeBrowsing.RT.AllStoresAvailable Bug: 1096294 Change-Id: I03cc4ea2f884e28e81e9c400a406a25707f8a132 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360924 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#800401}
-
Rouslan Solomakhin authored
Before this patch, the secure payment confirmation parameters to PaymentRequest API from Blink would not be passed to the browser process. This patch adds Mojo IPC for secure payment confirmation parameters and new type of payment app for the Web Payment that is based on these parameters. After this patch, Blink passes the secure payment confirmation parameters to the browser over mojo IPC and the browser uses these parameters to construct a payment app (when "SecurePaymentConfirmation" Blink runtime flag is enabled). Design: https://bit.ly/secure-payment-confirmation Explainer: https://github.com/rsolomakhin/secure-payment-confirmation Bug: 1110320 Change-Id: I7b9329d8d6c9724dd05b8d30492677baf2677186 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359733 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#800400}
-
Yuheng Huang authored
The TabUpdated() API will be called from from TabStripModelObserver.TabChangedAt() It will send out UpdateTabInfo for the updated tab so no more additional API calls are needed. Related CL: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3217588 Bug: 1099917 Change-Id: Id46b18827a8ef4f3c02d5a992ef4a3cc8ae2f6f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357958Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#800399}
-
Owen Min authored
The following policies can't be finished before M86 branch point. Move them to unreleased state so that they can be done in the upcoming milestone. DevicePrintersBlocklist => DeviceNativePrintersBlacklist DevicePrintersAllowlist => DeviceNativePrintersWhitelist DevicePrintersAccessMode => DeviceNativePrintersAccessMode DevicePrinters => DeviceNativePrinters UsbDetachableAllowlist => UsbDetachableWhitelist DeviceUserAllowlist => DeviceUserWhitelist Also update the references to those policies. Bug: 1098051, 1098048,1105183, 1105185, 1103813, 1103816, 1119961 Tbr: pastarmovj@chromium.org Change-Id: I953cd170423753af7d1064dcdac6e99c59e2732d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367873 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#800398}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/56d9df4fa53f..77419b0f04e8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I3727e0bd75ff58d10f59f28cbf12ef12ade55891 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367447Reviewed-by:
-
John Delaney authored
What: Add a feaature param to selectively disable the network or CPU limits. Why: We may want to run the intervention in different modes to determine impact. How: Add a check after an ad has determined to be heavy that filters based on the feature param. This change also cleans up some logic by returning an enum instead of bool in MaybeTriggerHeavyAdIntervention(), and using the new HeavyAdAction value to control triggering of interventions. This also removes a mode where the intervention could be enabled without reporting, which never needs to be used. Change-Id: Ie7aefdd77edfee5b2d4463aab3e1d1790a0931b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363190 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Eric Robinson <ericrobinson@chromium.org> Cr-Commit-Position: refs/heads/master@{#800396}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/77419b0f04e8..9869f187b5ea 2020-08-20 lalitm@google.com Merge "tp: add noop parsing for cgroup dumps in systrace" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I0350e2d2ccbbc83d95f2d6df303287ef319d5ba8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366477Reviewed-by:
-
François Degros authored
When opening an encrypted archive and the provided password was wrong, ask for the password again. BUG=chromium:912236 Cq-Depend: chromium:2327352 Change-Id: I06af54ab0abe6960ffc266c622bd95d985d41e2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354372 Commit-Queue: François Degros <fdegros@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#800394}
-
Jenny Zhang authored
The function will be used by Lacros system log source. Bug:1109387 TEST: Send feedback reports and verify nothing is changed. Change-Id: Id1bf276a10d1389b3ea1872d03a561c97490eea7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368153Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Miriam Zimmerman <mutexlox@chromium.org> Commit-Queue: Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#800393}
-
Ben Wagner authored
When building Chromium for Chromium OS for Linux (linux-chromeos) there is a choice of cros_boards, the local system and the Chromium sysroot. At the moment linux-chromeos builds with the Chromium sysroot won't run browser_tests on modern Debian systems due to an old version of libffi. Since developer testing builds don't need to be protable anyway, the Chromium sysroot is unnecessary. Document how to use the local system as a solution to this. Bug: chromium:1119849 Change-Id: Id5f7a41051367ae1f98cf48b1258680f6e11c9e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367736Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#800392}
-
Ian Kilpatrick authored
LayoutTheme::ShouldUseFallbackTheme should always be returning false, as LayoutThemeMobile was the only place returning true - presumably for an iOS configuration at some point. Removes all FallbackTheme related methods, and classes. There should be no behaviour change. Change-Id: I1d336016a1823a53a977ad764706d68fd19ff9bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363846Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#800391}
-
Joe DeBlasio authored
This CL adds an enterprise policy that allows selective allowlisting of domains from lookalike warnings. Bug: 1116279 Change-Id: I4f670ba43f7ce4f9da37798cbaf64a9f41c40724 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363861 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#800390}
-
Dana Fried authored
Because we now show the caption bar and caption buttons in Windows in tablet mode in order to provide a dedicated grab handle for moving to/ from split-screen mode (and protect user gestures to open the tabstrip) there is now empty space above the toolbar. Filling this empty space with the window title: - makes us consistent with PWA windows - provides access to the page title without opening the tabstrip Currently, this change only affects Windows and not ChromeOS. Screenshot (Google only): https://photos.google.com/share/AF1QipP8IFSTPydtpfbRM5vXfqQEfVDPVwq1kJDBMtCwes8AqxEqUdjIwsi5i2v1hUpmFg?key=WFkxdDVZR2ktU3c2dWNPU1lCRFRJSk55TGUtTDFR Bug: 1116651 Change-Id: Ib90149c6d46bf740505d1a06be824b85d3e5dee1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364958Reviewed-by:
-
Eric Orth authored
Better reflects the modern purpose of the class since it hasn't actually done any pooling since the "default" pool was disabled years ago in crrev.com/14225015 (and deleted recently in crrev.com/c/2357615). Bug: 1116579 Change-Id: I8822065709e423a50404a178a8ee942cd7d24f49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363849 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
-
Varun Khaneja authored
See go/protego-versioned-proto for more details about the motivation. TODOs: 1. Add UMA metrics. Will do that seprately to keep this CL small and the reviewer list short. 3. Add the response_provider field in the proto Bug: 1119928 Change-Id: Ie15d59b7f4e0b4c0fd236d9c665ad82f02ae2cdd Fixed: 1119928 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367443Reviewed-by:
-
Daniel Rubery authored
This CL prepares the CertificateReportingServiceFactory for the launch of Safe Browsing per-profile NetworkContexts. Since it does not need cookies, we will be using the profile-wide SharedURLLoaderFactory, and setting the credentials_mode to omit credentials. Bug: 1049833 Change-Id: If479c178501f93523697248bc484e28ab515aa0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357465 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
-
Alfonso Garza authored
Fix issue when deleting from a textfield and an emoji is present, where the last character would get deleted. Also moves card holder name down in the list of items as requested by UX. The main issue, which also has other unintended side effects, is that |reconfigureCellsForItems| is called while the text is being edited. This causes the cell to be redrawn and the cursor to change. By doing this call in TableViewTextEditItemDelegate as opposed to before the text changes we resolve the issue of the last character being deleted instead of the correct one. There is a smaller issue that remains and is not trivial to fix: after deletion the cursor is moved to the end of the text. This also exists in other textfields. Bug: 1114718 Change-Id: Id035e5b3c066801a3e156360f010380104564931 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360514 Commit-Queue: Alfonso Garza <alfonsogarza@google.com> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Iab5fa05bc49bec9e9d9dc234cb8a78f97dec40f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368273Reviewed-by:
-
Shengfa Lin authored
Chrome changed its install path in 85 to C:\Program Files We are only searching for C:\Program Files (x86) This is to check C:\Program Files as well Bug: chromedriver:3577 Change-Id: I5ad423197017b96a801517b0787873dda5a67b88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368163Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Shengfa Lin <shengfa@google.com> Cr-Commit-Position: refs/heads/master@{#800383}
-
sczs authored
Bug: 1085419 Change-Id: Ie4c211b2b725f8ae5b82bb8a7e2c545fbd162d03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367737 Commit-Queue: Sergio Collazos <sczs@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Auto-Submit: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#800382}
-
Nick Burris authored
Set the separator color to the themed color rather than explicitly. This also ensures the separator is displayed properly in dark mode. Bug: 1110322 Change-Id: If5118967106eccdced837fcad8a45757a68d2315 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368177Reviewed-by:
-
Hidehiko Abe authored
The current code hits static initializer check. Moved to a function so that it will be initialized on demand. Bug: 1119650 Test: Ran linux-rel tryjob. Change-Id: Id77428a3754892c6f17fab48030d9f44673e37ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364155Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7fe82b28. With Chromium commits locally applied on WPT: 3b705a74 "WPT: Service Worker: Add unexpected state check to wait_for_state()" 9f52c7e4 "COOP: add reporting to redirects" f3b221b0 "[COOP] access reporting: Extend report.body.type values." d25ea9f6 "Copy and destroy frames on encode()" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: Ib1b324f89a42a438ce34c7a7871e4a0fd407da3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368252Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800379}
-
Weilun Shi authored
Upon presubmit, will perform the following checks if histograms.xml, obsolete_histograms.xml or enums.xml is changed. - Validate prefix and pretty-print if histograms.xml is changed. - Pretty-print if enums.xml is changed. - Validate histograms contained are all obsolete if obsolete_histograms.xml is changed. Amended relevant files to take in relative path to a distributed histograms directory as system argument. Bug: 692201 Change-Id: I1797c0b65b53462cbb73820d8416a28651d1c65e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359714 Commit-Queue: Weilun Shi <sweilun@chromium.org> Auto-Submit: Weilun Shi <sweilun@chromium.org> Reviewed-by:
-
Michael Crouse authored
This change reworks the decision and hint logic to prepare for integrating with the optimization guide. The observer functions with an asynchronous callback so that hints can come either from the optimization guide or the current hint mechanism via Finch. The next change will start the integration with the optimization guide behind a flag. Bug: 1117064 Change-Id: I320635e795aafa2db2b2d413f766f94a4077cb9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367024Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#800377}
-
Brandon Wylie authored
Bug: 1106862 Change-Id: Icfa00b176f54701caf7e6eadb4c6f4f749d40c5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348016 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#800376}
-
Sebastien Lalancette authored
Recent Tabs should not have any overlap with Incognito. Bug: 1119377 Change-Id: Ic28d1c8ad7309e09e94478913956c8534bebe061 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367973 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Auto-Submit: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
-
Yue Zhang authored
This CL updates the content description of cards in grid tab switcher so that when focus on a group card, it should announce "expand [name] tab group with X tabs". Note that if there is no customized title, the [name] field should be empty. Bug: 1111942 Change-Id: I4630deeb5a0f0fe60707722af2b34e6dd4eff002 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367028 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#800374}
-
Lucía Cantú-Miller authored
ChromeDriver's list of emulated mobile devices that are supported should be re-generated for it to be up to date. Bug: chromedriver:3474 Change-Id: I11f9ca5598199bb80e13720ade0ba0d1e6c9b326 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368157Reviewed-by:
-
