GitLab

Plus a few other small clang-format fixes.

BUG=None
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/1131683003

Cr-Commit-Position: refs/heads/master@{#330003}

- Refactor GYP and GN files to share source lists.
- Extract a proper test_support target.
- Fix upstream files with new target structure.

BUG=461815,464199,464205

Review URL: https://codereview.chromium.org/1136623003

Cr-Commit-Position: refs/heads/master@{#330002}

This includes:
* Creating CmaRenderer and its dependencies (most of the renderer-side),
  stubbing out at the IPC level.
* Moving FakeDemuxerStream to media/base/ to allow use outside of //media

R=servolk@chromium.org,xhwang@chromium.org

Review URL: https://codereview.chromium.org/1137263002

Cr-Commit-Position: refs/heads/master@{#330001}

TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/1130163005

Cr-Commit-Position: refs/heads/master@{#330000}

This works the same way as NativeAppWindowCocoa by inserting a colored
NSView into the window's contentView's superview.

This also adds a test that checks for correct frame colors when active and
inactive.

BUG=459877

Review URL: https://codereview.chromium.org/1053303003

Cr-Commit-Position: refs/heads/master@{#329999}

MessageLoopProxy is deprecated.
This basically does a search and replace of:

MessageLoopProxy::current() -> ThreadTaskRunnerHandle::Get().

MessageLoopProxy -> SingleThreadTaskRunner

BUG=391045

Review URL: https://codereview.chromium.org/1124153005

Cr-Commit-Position: refs/heads/master@{#329998}

Treat a delay of under 1 millisecond in MessagePumpDefault as a signal that the corresponding delayed task needs to execute

On Windows for e.g. the lowest resolution we can get on the system clock is 1 ms or 4 ms depending on whether the machine
is powered by AC or battery. The OS default is 15ms. So that effectively means that if a delayed task is waiting to execute
for a delay of under 1 ms would cause the underlying OS WaitForSingleObject call to return immediately effectively spinning
a tight loop with a kernel mode context switch.

Fix is to treat a delay of under 1 ms as a signal that the task is ready to execute for all platforms.

BUG=487724

Review URL: https://codereview.chromium.org/1137453006

Cr-Commit-Position: refs/heads/master@{#329997}

There are two ways of accessing IsReadyToDraw and NeedsRaster. One is
via tile->IsReadyToDraw(), the other is via
tile->draw_info().IsReadyToDraw(). The first one is actually does the
same thing as the second one. This patch removes the shortcut and
makes all uses of this functionality consistent.

R=enne

Review URL: https://codereview.chromium.org/1139673008

Cr-Commit-Position: refs/heads/master@{#329996}

For a full list of changes, see
https://github.com/chromium/web-page-replay/compare/0e5c45a...e53550b.

BUG=484833

Review URL: https://codereview.chromium.org/1128743004

Cr-Commit-Position: refs/heads/master@{#329995}

Revert of vea_unittest: Calculate per-frame encode latency (patchset #16 id:300001 of https://codereview.chromium.org/1117853002/)

Reason for revert:
https://uberchromegw.corp.google.com/i/chromiumos.chromium/builders/X86%20%28chromium%29/builds/4667

chromium-os builders went red. Looks like there's a signed/unsigned comparison.

Original issue's description:
> vea_unittest: Calculate per-frame encode latency
>
> Calculates per-frame encode latency, which is basically the time delay from
> input of each VideoFrame (VEA::Encode()) to output of the corresponding
> BitstreamBuffer (VEA::Client::BitstreamBufferReady()).
>
> It calculates encode latency values at the 50th(median), 75th, and 95th percentiles.
>
> Also fix a wrong comment.
>
> BUG=345181
> TEST=Check "Encode latency for the 50%/75%/95%" in output logs.
>
> Committed: https://crrev.com/b21ffeee2aff4da8edb9808b2227165c37e5ce86
> Cr-Commit-Position: refs/heads/master@{#329819}
>
> Committed: https://crrev.com/738487a69f150975376c36e214c64a77b1ff0cc6
> Cr-Commit-Position: refs/heads/master@{#329838}

TBR=owenlin@chromium.org,posciak@chromium.org,wuchengli@chromium.org,jchuang@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=345181

Review URL: https://codereview.chromium.org/1145543002

Cr-Commit-Position: refs/heads/master@{#329994}

Diff since last roll:
https://github.com/chromium/dom-distiller/compare/e3ef0c4c8e...aa79b394e7

Picked up changes:
aa79b39 Strip bgcolor attribute from all table elements
ec27418 Show distilled page in Chrome Extension
1f211a4 Simplify testImageWithSrcset
b9e2b72 Update doc about Developing on Mac OS X
270058c Shuffle tests in continuous integration
f5070fd Properly restore test environment between tests
7a0544c Support running jstests repeatedly
fa4d011 Support running tests in random order
a03cbd2 Disregard "comment" appearing in className when too many classes
0650d41 Never regard HTML elements as comments
31359c2 Allow test.filter to begin with a dash
d4854eb Catch errors in continuous integration script
8a6e619 Skip tests using URL() in continuous integration
af015b9 Update document about filter syntax in jstest
b27ab2b Replace create_standalone_js.py with a custom GWT linker
10bc28c implement validations of pagination URLs
1ec32c2 Strip color attributes from font tags
772dbda Add script for landing CLs on behalf of external authors.
c0edaeb Find Python using 'env' in protoc plugin
9ae05a4 Fix regression in srcset handling

BUG=382993,436226,437113,464123,483036,483149,483172

Review URL: https://codereview.chromium.org/1130823004

Cr-Commit-Position: refs/heads/master@{#329993}

Do not run list these tests to run on Android for now.

BUG=486220
TBR=sky@chromium.org
TEST=mojo/tools/apptest_runner.py mojo/tools/data/apptests out/android_Debug passes.

Review URL: https://codereview.chromium.org/1122373003

Cr-Commit-Position: refs/heads/master@{#329992}

Three basic tests added:
1) DamageTriggersSwapBuffers
2) NoDamageDoesNotTriggerSwapBuffers
3) LockingResourcesDoesIndirectlyCauseDamage

The last test is a regression test to make sure we
don't accidentally damage the root surface every frame.
It fails with the following patch applied, which
got reverted:
https://codereview.chromium.org/1073323002

BUG=476544

Review URL: https://codereview.chromium.org/1124273004

Cr-Commit-Position: refs/heads/master@{#329991}

TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/1141153002

Cr-Commit-Position: refs/heads/master@{#329990}

When Chrome's ETW tracing is enabled it can consume more than half
of the total CPU time in the process, which means it is distorting
the results it is trying to measure. It also puts a lot of data into
the trace which cannot be viewed.

The biggest consumer of CPU time, by far, is AppendAsTraceFormat, which
consumes over 95% of the CPU time in TraceEventETWExport::AddEvent. Because
all categories are enabled this ends up creating many large buffers. The
cc::LayerTreeHostImpl events have been seen up to 22,500 bytes and
cc::Picture payloads have been seen up to 3,200,000 bytes! Ironically
the WPA trace viewer can't view payloads larger than 4094 bytes so all we
see for this effort and overhead is "Unable to parse data".

Truncating the payloads would let us see the partial data but would still
leave the distortion of execution time. The long-term solution is to
specify what categories are enabled in order to manage the volume of data.
Until then the prudent thing to do is to disable calls to AppendAsTraceFormat.

In addition, there is no reason for phase_string to be a std::string. This
overhead is relatively minor but measurable. It's worth fixing because the
fix is clean and simple.

The net effect is to drop the CPU overhead from 33-50% down to 1-7%.

This change makes Chrome's ETW tracing much more usable.

R=primiano@chromium.org
BUG=488257

Review URL: https://codereview.chromium.org/1140843003

Cr-Commit-Position: refs/heads/master@{#329989}

BUG=478250
R=mkwst@chromium.org

Review URL: https://codereview.chromium.org/1125213007

Cr-Commit-Position: refs/heads/master@{#329988}

When a cadence based rendering sequence exceeds drift, we should not
count the over-rendered frame against the next in sequence.  Doing
so causes an accumulation of errors.

Also extends the moving average for durations to 32 values and the
allowable drift to 16.66ms to stabilize the Catzilla 60fps and
Elite: Dangerous 60fps clips, which were hitting hysteresis very
frequently.

BUG=439548
TEST=new unittest.

Review URL: https://codereview.chromium.org/1139973003

Cr-Commit-Position: refs/heads/master@{#329987}

This allows manual override of the AppListMixer field trial.

BUG=487494
TEST=On ChromeOS, turn on flag enable-new-app-list-mixer. Search for
"goog" should return more than 6 total results.

Review URL: https://codereview.chromium.org/1139083002

Cr-Commit-Position: refs/heads/master@{#329986}

- Removes drop-down-button custom polymer element.
- Removes Media Router drop-down icons.
- Replace drop-down-button with core-icon-button.

Review URL: https://codereview.chromium.org/1128023003

Cr-Commit-Position: refs/heads/master@{#329985}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/842d065..dc02170

TBR=jsbell@chromium.org,timvolodine@chromium.org

Review URL: https://codereview.chromium.org/1142563002

Cr-Commit-Position: refs/heads/master@{#329984}

On at least one machine Chrome hits a problem where DwmGetCompositionTimingInfo
says that qpcRefreshPeriod is 60. This implies a refresh rate of ~34,000 fps.
Chrome dutifully tries to hit this frame rate leading to excessive CPU usage.

This change adds a couple of checks to detect bad values and fix them. In
parallel this bug is being reported.

R=piman@chromium.org
BUG=486226

Review URL: https://codereview.chromium.org/1141013004

Cr-Commit-Position: refs/heads/master@{#329983}

BUG=487866

Review URL: https://codereview.chromium.org/1132933004

Cr-Commit-Position: refs/heads/master@{#329982}

This CL adds functionality to check whether
http://clients4.google.com/generate_204 URL can be reached and returns
status code HTTP 204. The cache is bypassed and no redirects are allowed.

The functionality this provides will be used by the feedback system to
provide additional data in the report akin to a "Is this thing on?" type
test.

BUG=386395

Review URL: https://codereview.chromium.org/1127983002

Cr-Commit-Position: refs/heads/master@{#329981}

SetHighPerfMode needs root, but it currently only checks to see if
we already have root rather than trying to enable it.

BUG=478104

Review URL: https://codereview.chromium.org/1135393005

Cr-Commit-Position: refs/heads/master@{#329980}

This enables VoiceOver in OS X 10.10 to use the rotor and other
keyboard shortcuts that move by element type.

BUG=471119

Review URL: https://codereview.chromium.org/1134653003

Cr-Commit-Position: refs/heads/master@{#329979}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/87a773c..9d21429

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/1128363007

Cr-Commit-Position: refs/heads/master@{#329978}

What was WindowManagerInternal* is now ViewManagerRoot*.

The initial bootstrap is:
. App connects to view_manager and asks for ViewManagerService.
. ViewManager asks this connection for ViewManagerClient, and calls
  OnEmbed.
. The ViewManager exposes the services ViewManagerRoot to the initial
  connection.

All of this is handled for you if you use ViewManagerInit.

As WindowManager is no more, Embed with just a url is lost. I'm
assuming you'll add that back.

BUG=487870
TEST=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/1138073007

Cr-Commit-Position: refs/heads/master@{#329977}

GN will now compute the list of files required for targets to run based on dependencies and data files listed on the targets.

This is exposed via the "gn desc ... runtime_deps" command, and via a new switch that will write runtime deps files for specific targets at generation time.

Review URL: https://codereview.chromium.org/1130183007

Cr-Commit-Position: refs/heads/master@{#329976}

This enables ownership of content shell support for testing
Web Bluetooth. An example of early support being added in
https://codereview.chromium.org/1132943002
content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h/cc

This change corrects https://codereview.chromium.org/1142523003
which incorrectly used the per-file directive. per-file only applies
to files in the same directory as the OWNERS file.

BUG=420275

Review URL: https://codereview.chromium.org/1128423004

Cr-Commit-Position: refs/heads/master@{#329975}

BUG=487486

Review URL: https://codereview.chromium.org/1135183002

Cr-Commit-Position: refs/heads/master@{#329974}

isKeyboardShowing calls getWindowVisibleDisplayFrame which may be very
expensive sine it involves ipc to other processes. Also layout happens a
lot more often in webview than chrome, so this disproportionately
affects webview.

BUG=487487

Review URL: https://codereview.chromium.org/1140163004

Cr-Commit-Position: refs/heads/master@{#329973}

This fixes another cause of crashing without a valid parent proxy in
RenderFrameProxy::CreateFrameProxy.  This occurred when a renderer
crashed, and another renderer added a child frame, which triggered a
new proxy for that frame to be created for the crashed process.  The
crashed process was recreated just to create the proxy, and the proxy
creation crashed because its parent proxy didn't exist.

This CL fixes InitRenderFrameProxy to not recreate a process just to
create proxies.  The process should only come back if it ever needs to
host a RenderFrame, and all the proxies should already be created
then.

BUG=476846

Review URL: https://codereview.chromium.org/1138413002

Cr-Commit-Position: refs/heads/master@{#329972}

Clang's static analyzer emits the warning "-Wobjc-designated-initializers" for
CustomFrameView, because CustomFrameView overrides two designated initializers,
but the methods don't call super. The methods throw exceptions, which Clang's
static analyzer isn't smart enough to catch. Declaring the methods with
NS_UNAVAILABLE suppresses the clang warning.

BUG=

Review URL: https://codereview.chromium.org/1101923002

Cr-Commit-Position: refs/heads/master@{#329971}

Make Mandoline always run the mojo:window_manager.
(afaik we don't want to specify other command line apps)
Make Mojo Runner run the command line app (fallback on WM).
(The Android impl wasn't respecting the command line app)
Consolidate on Context::RunCommandLineApplication helper.

BUG=486220
TEST=Android mojo shell and apptest runner can run non-WM apps (eg. apptests).
R=sky@chromium.org

Review URL: https://codereview.chromium.org/1134713003

Cr-Commit-Position: refs/heads/master@{#329970}

Don't open the Collected Cookies dialog if the related web contents is null because the tab was already closed.

BUG=434569

Review URL: https://codereview.chromium.org/1017683003

Cr-Commit-Position: refs/heads/master@{#329969}

Review URL: https://codereview.chromium.org/1138313003

Cr-Commit-Position: refs/heads/master@{#329968}

BUG=465453

Review URL: https://codereview.chromium.org/1128823008

Cr-Commit-Position: refs/heads/master@{#329967}

SchemeIsCryptographic more appropriately reflects
the intent (that a cryptographically secure
transport was used - e.g. https:// and wss:// schemes),
whereas SchemeIsSecure also considers situations where
the scheme is locally trusted (e.g. filesystem URLs)

BUG=362214

Review URL: https://codereview.chromium.org/1131963003

Cr-Commit-Position: refs/heads/master@{#329966}

Per in-person discussions, as long as we have a fork of mojo shell we'll fork the interfaces.

I'll do third_party/mojo/src/mojo/public/java/application in a followup.

TBR=tsepez

Review URL: https://codereview.chromium.org/1139123006

Cr-Commit-Position: refs/heads/master@{#329965}

Previously, if a group target like 'mandoline:all' was specified as
an additional_compile_target that we wanted to build, the gn implementation
of 'analyze' would not handle it correctly (it could only handle dependencies
on files that existed in the build directory, like executables).

This patch modifies the MB implementation to also handle label-like targets
(the ninja mandoline:all target is the equivalent of the GN //mandonline:all
target); we do this by calling 'gn refs' twice, once looking for a list
of output paths to match against the compile targets and once looking for
a list of phony labels to match against the compile targets.

We also will match against just the target_name, so 'chrome_shell_apk' will
also match "//chrome/android:chrome_shell_apk'. This may result in
too many targets being rebuilt, but we can adjust that if need be.

This is somewhat inefficient, but the alternatives would be to either
1) force the user to specify the stamp files for a group, which would be
   ugly, or
2) force the user to specify all the compile targets in terms of GN labels,
   which would be different from how the recipes work w/ GYP and possibly
   require us to map binary names to targets outside of GN, which would
   be a maintenance headache.

R=scottmg@chromium.org,brettw@chromium.org
BUG=487035
CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_rel;tryserver.chromium.win:win8_chromium_gn_rel

Review URL: https://codereview.chromium.org/1135743005

Cr-Commit-Position: refs/heads/master@{#329964}