- 02 Sep, 2016 40 commits
-
-
fs authored
Turn the <svg> into a block to avoid having to compensate for the baseline of an inline. BUG=397255 Review-Url: https://codereview.chromium.org/2303043003 Cr-Commit-Position: refs/heads/master@{#416271}
-
picksi authored
BUG=636405 NOTRY=true CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq Review-Url: https://codereview.chromium.org/2304113002 Cr-Commit-Position: refs/heads/master@{#416270}
-
mtrofin authored
Wasm modules may be large (megs) and their compilation is time- and resources consuming (many seconds on desktops, more on mobile). With structured cloning support, developers may save/restore compilation results in IndexedDB, or decide to compile on worker threads. This first CL introduces basic support and a basic test. Intent to implement: https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/Dogpn1hpnhw BUG=v8:5072 Review-Url: https://codereview.chromium.org/2255673003 Cr-Commit-Position: refs/heads/master@{#416269}
-
treib authored
Revert of Add test of MakeUniqueID() and friends. (patchset #3 id:40001 of https://codereview.chromium.org/2306043002/ ) Reason for revert: Fails on several bots: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQAsSCVdmQ3VscHJpdCIxY2hyb21pdW0vY2MyZjYxMjA0YzBlZGU1YzNjNTY5OWJjMDc5NmJiMmJiZmFiNzI1OQw Original issue's description: > Add test of MakeUniqueID() and friends. > > Committed: https://crrev.com/cc2f61204c0ede5c3c5699bc0796bb2bbfab7259 > Cr-Commit-Position: refs/heads/master@{#416259} TBR=sfiera@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2302363002 Cr-Commit-Position: refs/heads/master@{#416268}
-
foolip authored
BUG=631245 Review-Url: https://codereview.chromium.org/2287353002 Cr-Commit-Position: refs/heads/master@{#416267}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/324d39a894c0..6256ea38cc13 $ git log 324d39a89..6256ea38c --date=short --no-merges --format='%ad %ae %s' 2016-09-02 jbudorick [devil] Add a markdown help text formatter. TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2307043002 Cr-Commit-Position: refs/heads/master@{#416266}
-
jbroman authored
BUG=494719 Review-Url: https://codereview.chromium.org/2307613002 Cr-Commit-Position: refs/heads/master@{#416265}
-
fs authored
For inline boxes, the reference box should be computed per-fragment, and be subject to box-decoration-break. We're not quite there yet though, so go for "local compat" for now and align with Gecko. This way we're slightly closer to "correct" (the "single line" case ought to be fairly correct for instance), and hopefully avoid getting sucked into a compat "sinkhole". Adjust css3/masking/clip-path-reference-box-inline.html to match. BUG=641907 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2303773002 Cr-Commit-Position: refs/heads/master@{#416264}
-
fukino authored
third_party/closure_compiler/run_compiler was failing due to missing compile_js*.gypi under ui/file_manager. BUG=none TEST=third_party/closue_compiler/run_compiler TBR=dbeam@chromium.org Review-Url: https://codereview.chromium.org/2296953008 Cr-Commit-Position: refs/heads/master@{#416263}
-
ricea authored
The implementations of content::AsyncResourceHandler and content::ResourceDispatcher contained redundant assignments of encoded_data_length. Fixed. BUG= Review-Url: https://codereview.chromium.org/2301893002 Cr-Commit-Position: refs/heads/master@{#416262}
-
mkwst authored
https://github.com/w3c/webappsec-csp/issues/112 notes that '<meta>' has some script-like capabilities that aren't currently covered by CSP. This patch adds metrics for usage of 'Set-Cookie' and 'Refresh' in documents that block inline script. If it turns out that the intersection is low, perhaps we can make this backwards-incompatible change. R=jochen@chromium.org Review-Url: https://codereview.chromium.org/2308513002 Cr-Commit-Position: refs/heads/master@{#416261}
-
harkness authored
This adds the BudgetDatabase as a member of the manager, paving the way for the switch from using the prefs to store budget to using the proto database. This also adds Reserve and Consume entrypoints on the BudgetManager. Reserve is the entrypoint for the Mojo service to enable Javascript to purchase reservations with budget. Consume is the entrypoint for clients of the Manager to determine if an origin should be allowed an action, either because it has a reservation or because it has enough budget to cover the cost. BUG=617971 Review-Url: https://codereview.chromium.org/2272563005 Cr-Commit-Position: refs/heads/master@{#416260}
-
sfiera authored
Review-Url: https://codereview.chromium.org/2306043002 Cr-Commit-Position: refs/heads/master@{#416259}
-
davidben authored
Instead, implement ThreadedSSLPrivateKey::Delegate directly using the JNI functions. This removes all of Chromium's uses of RSA_METHOD and ECDSA_METHOD. Rather than a function from jobject to EVP_PKEY exposed by keystore_openssl.h, have SSLPlatformKeyAndroid expose a function from jobject to SSLPrivateKey. That then gets routed through whereever the EVP_PKEY used to be routed. In particular, OpenSSLClientKeyStore now acts on a scoped_refptr<SSLPrivateKey> rather than a crypto::ScopedEVP_PKEY. OpenSSLClientKeyStore is also rewritten to be much simpler, but all its problems (like not being thread-safe) still remain. That will be resolved by finishing the SSLPrivateKey refactor and routing it up through //content so we can do away with the inherently global FetchClientCertPrivateKey. Port the old keystore_unittests.cc tests to test the new wrapper. Trim it down a little so it tests just the wrapper object, but test all hashes. BUG=394131 Review-Url: https://codereview.chromium.org/2291213002 Cr-Commit-Position: refs/heads/master@{#416258}
-
yukishiino authored
As same as a Window object, we do not need to support a constructor for WindowProperties object. BUG=643357 Review-Url: https://codereview.chromium.org/2306023002 Cr-Commit-Position: refs/heads/master@{#416257}
-
jochen authored
Revert of Temporarily decrease min-idle time for todomvc pagesets (patchset #1 id:1 of https://codereview.chromium.org/2276313002/ ) Reason for revert: no longer needed Original issue's description: > Temporarily decrease min-idle time for todomvc pagesets > > Also record all the events > > BUG=636405 > R=skyostil@chromium.org > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq > > Committed: https://crrev.com/0f5391d7b30ce4536222f46aa5804f13f65da25d > Cr-Commit-Position: refs/heads/master@{#414521} TBR=skyostil@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=636405 Review-Url: https://codereview.chromium.org/2308593002 Cr-Commit-Position: refs/heads/master@{#416256}
-
eyaich authored
Dependencies are correct, successful triggered task on 4 core laptop: https://chromium-swarm.appspot.com/user/task/30f4a1312196bc10 BUG=chromium:633253 Review-Url: https://codereview.chromium.org/2290373002 Cr-Commit-Position: refs/heads/master@{#416255}
-
cylee authored
The following two methods defined in process.mojom are not needed anymore because oom_adj setting and lowmemorykiller are disabled by default on Android side. - DisableBuiltinOomAdjustment() - DisableLowMemoryKiller() BUG=b:30971151 TEST=minnie Review-Url: https://codereview.chromium.org/2282053005 Cr-Commit-Position: refs/heads/master@{#416254}
-
nednguyen authored
Review-Url: https://codereview.chromium.org/2300233003 Cr-Commit-Position: refs/heads/master@{#416253}
-
andra.paraschiv authored
Enhance the chrome.app.window API for shelf integration with the possibility of pinning the showInShelf=true windows. Based on https://codereview.chromium.org/1914993002 Co-Authored-By: Valentin Ilie <valentin.ilie@intel.com>; BUG=610299 TEST=interactive_ui_tests Implement a simple extension that creates windows with showInShelf property set to true. Pin a newly created window that has its own icon in the shelf, then close it and open it again by clicking the pinned icon. TEST= https://codereview.chromium.org/2297633002 Review-Url: https://codereview.chromium.org/2290603002 Cr-Commit-Position: refs/heads/master@{#416252}
-
noyau authored
Reland of [ios] Implemented LoadHtml w/o using data:// URLs. (patchset #1 id:1 of https://codereview.chromium.org/2306053002/ ) Reason for revert: False alert. This was not the root cause. Relanding. Sorry for the noise. Original issue's description: > Revert of [ios] Implemented LoadHtml w/o using data:// URLs. (patchset #4 id:60001 of https://codereview.chromium.org/2295053003/ ) > > Reason for revert: > Breaking iOS build. > > Original issue's description: > > [ios] Implemented LoadHtml w/o using data:// URLs. > > > > This allows loading HTML and setting a specific URL (last part is needed > > by suggestions tests, which currently use private API to set the URL). > > > > BUG=619687 > > > > Committed: https://crrev.com/7d93683d73e6bb131651275c752a0792f2733410 > > Cr-Commit-Position: refs/heads/master@{#416151} > > TBR=jyquinn@chromium.org,eugenebut@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=619687 > > Committed: https://crrev.com/e04917c2cced1a397c9f959f6f27a1b44e245899 > Cr-Commit-Position: refs/heads/master@{#416246} TBR=jyquinn@chromium.org,eugenebut@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=619687 Review-Url: https://codereview.chromium.org/2309433002 Cr-Commit-Position: refs/heads/master@{#416251}
-
gab authored
And change a few checks from != NONE_ACTIVE to == WORKER_CREATED where it's guaranteed (i.e. in code that can only run after a Worker is created). BUG=639812 Review-Url: https://codereview.chromium.org/2295323004 Cr-Commit-Position: refs/heads/master@{#416250}
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). Please review the expectation changes, and LGTM as normal. The recipe roller will *NOT* CQ the change itself, so you must commit the change manually. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/f06e6138edadc92d4cab98507a3b874979da5a61 Revert "Avoid to use environment." (shinyak@chromium.org) R=shinyak@chromium.org BUG= Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2300343003 Cr-Commit-Position: refs/heads/master@{#416249}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9c99a304..d9e7b3b2 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2302913004 Cr-Commit-Position: refs/heads/master@{#416248}
-
fwang authored
CL includes the header defining base::Bind in order to fix the following build error for Ozone/Wayland: ui/ozone/platform/wayland/wayland_window.cc:156:27: error: no member named 'Bind' in namespace 'base' native_event, base::Bind(&PlatformWindowDelegate::DispatchEvent, ~~~~~~^ ui/ozone/platform/wayland/wayland_window.cc:157:38: error: no member named 'Unretained' in namespace 'base' base::Unretained(delegate_))); BUG=578890 R=spang@chromium.org Review-Url: https://codereview.chromium.org/2297743003 Cr-Commit-Position: refs/heads/master@{#416247}
-
noyau authored
Revert of [ios] Implemented LoadHtml w/o using data:// URLs. (patchset #4 id:60001 of https://codereview.chromium.org/2295053003/ ) Reason for revert: Breaking iOS build. Original issue's description: > [ios] Implemented LoadHtml w/o using data:// URLs. > > This allows loading HTML and setting a specific URL (last part is needed > by suggestions tests, which currently use private API to set the URL). > > BUG=619687 > > Committed: https://crrev.com/7d93683d73e6bb131651275c752a0792f2733410 > Cr-Commit-Position: refs/heads/master@{#416151} TBR=jyquinn@chromium.org,eugenebut@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=619687 Review-Url: https://codereview.chromium.org/2306053002 Cr-Commit-Position: refs/heads/master@{#416246}
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/a74f612ef99de4de59320e5f390e16bf6934cf88 Add step to show goma stat in goma module (tikuta@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG=544330 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2302723004 Cr-Commit-Position: refs/heads/master@{#416245}
-
Prashant.Patil authored
Added first MSA optimized function of WebGL image conversion module. More functions to follow. BUG=642653 Review-Url: https://codereview.chromium.org/2289693002 Cr-Commit-Position: refs/heads/master@{#416244}
-
perkj authored
This test pass locally and we want to run it on the webrtc build bots. This reverts commit f472eb57. BUG=626556 NOTRY=true TBR=phoglund@chromium.org Review-Url: https://codereview.chromium.org/2302763003 Cr-Commit-Position: refs/heads/master@{#416243}
-
hiroshige authored
Now that we have memory-infra, I expect we can remove debug code under MEMORY_CACHE_STATS. This CL removes printf() debug code that cause presubmit warnings (follow-up of a comment in https://codereview.chromium.org/2254593003/). BUG=603791 Review-Url: https://codereview.chromium.org/2299603002 Cr-Commit-Position: refs/heads/master@{#416242}
-
dvadym authored
BUG=564674 Review-Url: https://codereview.chromium.org/2298733003 Cr-Commit-Position: refs/heads/master@{#416241}
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). Please review the expectation changes, and LGTM as normal. The recipe roller will *NOT* CQ the change itself, so you must commit the change manually. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/e86f94ed0b0ccb94fee3d6f27c1b45932d904c6b Avoid to use environment. (yyanagisawa@chromium.org) R=yyanagisawa@chromium.org BUG= Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2307723002 Cr-Commit-Position: refs/heads/master@{#416240}
-
pasko authored
Addressing my own nits expressed in review of: https://codereview.chromium.org/2293153002/ (Remove stl_util's STLDeleteContainerPairFirstPointers.) BUG=555865 Review-Url: https://codereview.chromium.org/2301403002 Cr-Commit-Position: refs/heads/master@{#416239}
-
davve authored
We're selecting between two rectangles given by the intrinsic aspect ratio: (defaultWidth / aspect ratio, defaultHeight) or (defaultWidth, defaultHeight x aspect ratio). One rectangle is 'contained' and the other one 'covers'. Select the 'contained' rectangle by trying out the first to see if its width fit, and if so we're done. Otherwise compute and select the other rectangle. Due to how floating point math works, it's possible that both computed rectangles, or neither computed rectangle, will fit the case when the two ratios are equal. See https://bugs.chromium.org/p/chromium/issues/detail?id=641221 for one example. However, in this case it doesn't matter much which rectangle we choose, the contained and and cover rectangle would be the same rectangle and the floating point discrepancy has no known practical implication. BUG=641221 Review-Url: https://codereview.chromium.org/2294683002 Cr-Commit-Position: refs/heads/master@{#416238}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/05e534a6043b..324d39a894c0 $ git log 05e534a60..324d39a89 --date=short --no-merges --format='%ad %ae %s' 2016-09-02 achuith Increase timeout for launching guest browser. BUG=631640 TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2304903002 Cr-Commit-Position: refs/heads/master@{#416237}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7c1ee6be..9c99a304 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2303253002 Cr-Commit-Position: refs/heads/master@{#416236}
-
mkwst authored
Currently, `<script src="whatever"></script>` will execute the resource at `whatever` as long as it returns a non-`image/*` MIME-type (and doesn't opt-in to additional protection by sending an `X-Content-Type-Options: nosniff` header). This patch tightens that to exclude `text/csv` as well as `audio/*` and `video/*` by default. Spec: https://fetch.spec.whatwg.org/#should-response-to-request-be-blocked-due-to-mime-type? Intent: https://groups.google.com/a/chromium.org/d/msg/blink-dev/AHsFvhHzh1o/GHj6QCdMAAAJ Discussion: https://github.com/whatwg/fetch/issues/337 BUG=433049 Review-Url: https://codereview.chromium.org/2294283002 Cr-Commit-Position: refs/heads/master@{#416235}
-
torne authored
Update code in android_webview to use JavaRef when calling Java methods via JNI, instead of passing bare jobject. Various function parameter types are converted from jobject to JavaRef to enable calls to obj() higher up the call chain to be removed. BUG=506850 Review-Url: https://codereview.chromium.org/2295693004 Cr-Commit-Position: refs/heads/master@{#416234}
-
treib authored
Follow-up to https://codereview.chromium.org/2256613002/ BUG=627747,447810 Review-Url: https://codereview.chromium.org/2242213008 Cr-Commit-Position: refs/heads/master@{#416233}
-
lizeb authored
These histograms will no longer be accurate and prevent code refactoring and improvements. Also fixes the presubmit check: cannot assume that the first element of sys.path is '.', and tools/python doesn't contain __init__.py. BUG=631966 Review-Url: https://codereview.chromium.org/2301093002 Cr-Commit-Position: refs/heads/master@{#416232}
-