GitLab

Revert of Stub for web-base client for DevTools bridge and tests (patchset #5 id:100001 of https://codereview.chromium.org/736363002/)

Reason for revert:
Reverting since now DevToolsBridgeClient (https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/devtools/device/webrtc/devtools_bridge_client.h) is that WebClient supposed to be. All further code will be placed there.

Original issue's description:
> Stub for web-base client for DevTools bridge and tests
>
> This patch mostly consists of testing environment for web WebClient. While
> WebClient intended to be base for a new DeviceProvider in DevTools frontend
> (https://codereview.chromium.org/720133002/) it is convinient to run
> tests on android. It lets to test the client directly against server
> counterpart avoiding flakiness of network and cloud services.
>
> TBR=jochen@chromium.org
> BUG=383418
>
> Committed: https://crrev.com/ff7a801dfddaa22643accaf3e0df192470fb7a7b
> Cr-Commit-Position: refs/heads/master@{#305131}

TBR=mnaganov@chromium.org,dgozman@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=383418

Review URL: https://codereview.chromium.org/802293002

Cr-Commit-Position: refs/heads/master@{#308329}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/6556aea..7ca8eaa

TBR=lushnikov@chromium.org,vsevik@chromium.org,dglazkov@chromium.org,beverloo@chromium.org

Review URL: https://codereview.chromium.org/802273002

Cr-Commit-Position: refs/heads/master@{#308328}

A document will associate a new matched registration if it is not controlled,
but it doesn't equal to "using" the registration. We should omit documents
that are not using the registration when skipWaiting happens.

BUG=370742
TEST=http/tests/serviceworker/skip-waiting.html

Review URL: https://codereview.chromium.org/798833002

Cr-Commit-Position: refs/heads/master@{#308327}

BUG=437829

Committed: https://crrev.com/0593c1690aeb6ac4869504b91d8172546aea1da6
Cr-Commit-Position: refs/heads/master@{#306389}

Review URL: https://codereview.chromium.org/772533002

Cr-Commit-Position: refs/heads/master@{#308326}

BUG=None

Review URL: https://codereview.chromium.org/799073007

Cr-Commit-Position: refs/heads/master@{#308325}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/9561fd6..6556aea

TBR=

Review URL: https://codereview.chromium.org/801293002

Cr-Commit-Position: refs/heads/master@{#308324}

Cr-Commit-Position: refs/heads/master@{#308323}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/3d81dfe..9561fd6

TBR=

Review URL: https://codereview.chromium.org/806703002

Cr-Commit-Position: refs/heads/master@{#308322}

As part of easy sign-in protocol, a nonce has to be signed by TPM
private key. To be able to do this, we need to allow system token to be
loaded before a user is logged in. This cl starts system token
initialization (which is done by TPMTokenLoader) before LoginState is
LOGGED_IN if there is a user with easy sign-in enabled.

BUG=409027

Review URL: https://codereview.chromium.org/741593002

Cr-Commit-Position: refs/heads/master@{#308321}

BUG=433728
TEST=GYP_GENERATORS=ninja tools/gyp/gyp --depth . ui/file_manager/gallery/js/compiled_resources.gyp && ninja -C out/Default | grep "gallery/js/mosaic_mode.js"

Review URL: https://codereview.chromium.org/805723003

Cr-Commit-Position: refs/heads/master@{#308320}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/54355486..3d81dfe

TBR=

Review URL: https://codereview.chromium.org/802083003

Cr-Commit-Position: refs/heads/master@{#308319}

BUG=397019

Review URL: https://codereview.chromium.org/804853002

Cr-Commit-Position: refs/heads/master@{#308318}

Provides better contrast with the downloads bar while remaining
contrasted with the background.

BUG=424067

Review URL: https://codereview.chromium.org/791273002

Cr-Commit-Position: refs/heads/master@{#308317}

This CL makes the app list recommendations their own
SearchResult::DisplayType. This prevents recommendations from flashing up
for an instant when the search query is deleted.

BUG=440051

Review URL: https://codereview.chromium.org/796793002

Cr-Commit-Position: refs/heads/master@{#308316}

This reverts commit 4eb0fd47.

HistogramManagerBucketFields times out on Win7 Tests.
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/33548

TBR=rtenneti@chromium.org,asvitkine@chromium.org,mef@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=441466

Review URL: https://codereview.chromium.org/800363002

Cr-Commit-Position: refs/heads/master@{#308315}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/0c64792..54355486

TBR=

Review URL: https://codereview.chromium.org/801243002

Cr-Commit-Position: refs/heads/master@{#308314}

Revert of Fix file naming issue causing page_run_end_to_end tests to never run (at least when run locally usi… (patchset #2 id:20001 of https://codereview.chromium.org/805593002/)

Reason for revert:
Some of the newly enabled tests fail on the bots.
For example, https://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20%281%29/builds/51555

Original issue's description:
> Fix file naming issue causing page_run_end_to_end tests to never run (at least when run locally using run_tests script).
> Fix a failing test from this file.
>
> Found this while fixing unit test for max_failures patch
> (https://codereview.chromium.org/790673005/).
>
> BUG=440101
>
> Committed: https://crrev.com/c484a63e356fb1011b553b94612586d2084325d3
> Cr-Commit-Position: refs/heads/master@{#308264}

TBR=nednguyen@google.com,chrishenry@google.com
NOTREECHECKS=true
NOTRY=true
BUG=440101

Review URL: https://codereview.chromium.org/802243002

Cr-Commit-Position: refs/heads/master@{#308313}

Presently when we selects bookmark icon then it checks weather Ctrl+D has been set as overridden command for any extension if yes, then it executes extension popup for that extension.

Changes done so that when bookmarking a page is done via bookmark icon by mouse click then bookmark overridden commands should not be considered as overriding happened for keyboard shortcuts.
As user have overridden shortcut key for bookmark to launch extension pop up, not the bookmarking via selection of bookmark icon by mouse event.

TBR=sky@chromium.org

BUG=426791

Review URL: https://codereview.chromium.org/765043002

Cr-Commit-Position: refs/heads/master@{#308312}

_behavior_features.json. Arbitrarily use it to implement the allow-in-incognito
whitelist.

BUG=440194
R=rockot@chromium.org

Review URL: https://codereview.chromium.org/789383002

Cr-Commit-Position: refs/heads/master@{#308311}

This CL implements an experimental scheme for navigating the tile results
in the experimental app list. The left and right arrow keys now navigate
the tile list if the search box cursor is at the end of the text.

BUG=436327

Review URL: https://codereview.chromium.org/793633002

Cr-Commit-Position: refs/heads/master@{#308310}

This CL fixes issues with the app list where the search box widget would
render above the app list overlay while accepting input.

This has been fixed by appropriately animating the search box widget
when the app list overlay is shown and disabling the search box.

BUG=439350

Review URL: https://codereview.chromium.org/781423002

Cr-Commit-Position: refs/heads/master@{#308309}

This CL fixes an issue where Shift+Tab would lock up the whole chrome
browser process when in the app list. This has been fixed by explicitly
capturing the Shift+Tab event since there are no other focus targets
anyway.

BUG=438425

Review URL: https://codereview.chromium.org/791403004

Cr-Commit-Position: refs/heads/master@{#308308}

BUG=433728
TEST=GYP_GENERATORS=ninja tools/gyp/gyp --depth . ui/file_manager/gallery/js/compiled_resources.gyp && ninja -C out/Default | grep "gallery.js"

Review URL: https://codereview.chromium.org/801533006

Cr-Commit-Position: refs/heads/master@{#308307}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/33cbe26..0c64792

TBR=

Review URL: https://codereview.chromium.org/802783004

Cr-Commit-Position: refs/heads/master@{#308306}

Blink side: https://codereview.chromium.org/799893004

BUG=428790

Review URL: https://codereview.chromium.org/798073003

Cr-Commit-Position: refs/heads/master@{#308305}

This affects the speech recognition with V2 hotwording enabled.

Review URL: https://codereview.chromium.org/797493002

Cr-Commit-Position: refs/heads/master@{#308304}

Previously if the PDF plugin is disabled or click-to-play, the loading
indicator appeared over the click-to-play overlay. This hides the
loading indicator until a message is received from the plugin.

BUG=441132

Review URL: https://codereview.chromium.org/796223002

Cr-Commit-Position: refs/heads/master@{#308303}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/451e822..912ed6e

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=bensong@google.com

Review URL: https://codereview.chromium.org/804833003

Cr-Commit-Position: refs/heads/master@{#308302}

BUG=417532

Review URL: https://codereview.chromium.org/783523004

Cr-Commit-Position: refs/heads/master@{#308301}

Currently, constrained web dialogs cannot autoresize. This change gives an option to pass in a minimum and maximum size, which enables the autoresizing functionality.

OSX has not yet been implemented.

BUG=217034

Review URL: https://codereview.chromium.org/754953002

Cr-Commit-Position: refs/heads/master@{#308300}

Add a null check instead of DCHECK() for web contents since it can be NULL
and cause a crash on debug builds, if the tab is closed while the plugin
settings bubble is visible and the setting was changed to Allow plugins.

BUG=440410

Review URL: https://codereview.chromium.org/791633003

Cr-Commit-Position: refs/heads/master@{#308299}

Remove dependency on the default constructor of StatsReport. This is in preparation of a WebRTC roll where this constructor has been removed.

TBR=perkj@chromium.org

Review URL: https://codereview.chromium.org/803853002

Cr-Commit-Position: refs/heads/master@{#308298}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/ef1eaab..33cbe26

TBR=

Review URL: https://codereview.chromium.org/791243003

Cr-Commit-Position: refs/heads/master@{#308297}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/797423002

Cr-Commit-Position: refs/heads/master@{#308296}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/23bf4d4..ef1eaab

TBR=

Review URL: https://codereview.chromium.org/806583003

Cr-Commit-Position: refs/heads/master@{#308295}

Cr-Commit-Position: refs/heads/master@{#308294}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/2df2b3e..23bf4d4

TBR=

Review URL: https://codereview.chromium.org/787253007

Cr-Commit-Position: refs/heads/master@{#308293}

It makes the ownership clear and it is a good pratice when transfering
ownership from caller to callee. Passing a scoped_ptr makes it harder to
misuse.

Discussion in chromium-dev mailing-list:
https://groups.google.com/a/chromium.org/d/topic/chromium-dev/9rTsfEI1Ux0/discussion

BUG=None
TEST=unit_tests --gtest_filter=ConfirmBubble*
R=pkasting@chromium.org,avi@chromium.org

Review URL: https://codereview.chromium.org/801043003

Cr-Commit-Position: refs/heads/master@{#308292}

Do not use an action when naming an event that will be fired to the
delegate. Instead of saying what the delegate should do or will do, just
say what event happened. So in this case, say to the delegate that the
instructions import link on the Bookmarks Bar was clicked.

BUG=None
TEST=have zero bookmarks in your Bookmarks Bar, so you can see the link there,
click on it to show the import dialog. No regressions should be observed.
R=sky@chromium.org

Review URL: https://codereview.chromium.org/789653004

Cr-Commit-Position: refs/heads/master@{#308291}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/c517219..2df2b3e

TBR=

Review URL: https://codereview.chromium.org/787253006

Cr-Commit-Position: refs/heads/master@{#308290}