GitLab

RendererAccessibility::PostAccessibilityNotification function while processing the WebAccessibilityNotificationLayoutComplete 
notification from webkit. This function recursively calls itself with the WebAccessibilityNotificationLayoutComplete
notification leading to infinite recursion.

Fix is to check whether the incoming notification is WebAccessibilityNotificationLayoutComplete before the recursive
call.

BUG=none
TEST=chrome frame tests should pass on the IE6 builder.
Review URL: http://codereview.chromium.org/8952005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114573 0039d316-1c4b-4281-b951-d872f2087c98

This is primarily used by the sync typed URL performance tests.  This
method helps stabilize the perf numbers since there's only a single
notification that is emitted (instead of one per URL).

BUG=107040
TEST=


Review URL: http://codereview.chromium.org/8910024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114572 0039d316-1c4b-4281-b951-d872f2087c98

This time, we allow the StackingClient to be optional. If not specified, unparented windows will just be added to the RootWindow.

BUG=none
TEST=existing automation

Review URL: http://codereview.chromium.org/8916020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114571 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
R=csilv

Review URL: http://codereview.chromium.org/8898036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114562 0039d316-1c4b-4281-b951-d872f2087c98

Set aura window focus in NativeWidgetAura::ClearNativeFocus only if the focus is owned by child window.

 This was causing a focus to be stolen when non active window calls ClearNativeFocus.

BUG=114477
TEST=OmniboxViewTest.PopupAccelerators passes with this change


Review URL: http://codereview.chromium.org/8931022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114561 0039d316-1c4b-4281-b951-d872f2087c98

1. Get rid of the dummy AtlModule registration in the chrome frame net test suite. This is no longer needed
   as there is an Atlmodule instance instantiated by the content code.

2. The TestSuite and NetTestSuite classes now provide special protected constructors which allow
   test instances to control whether an AtExitManager instance is created for the duration of the
   test. The ChromeFrame net test suite reuses the AtExitManager instance created in BrowserMain.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=105435

BUG=105435
TEST=ChromeFrame net tests should now run on the builders.
Review URL: http://codereview.chromium.org/8907054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114559 0039d316-1c4b-4281-b951-d872f2087c98

Resubmitting reverted CL with fix
BUG=chromium-os:23757
TEST=manual
Review URL: http://codereview.chromium.org/8883046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114558 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8909012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114557 0039d316-1c4b-4281-b951-d872f2087c98

Requiring developers to update their extensions to manifest_version 2 when
loading them as unpacked extensions was more disruptive than we anticipated.
We want to make sure our documentation is in better shape and that folks have a
chance to move to manifest_version 2 on their own schedule before flipping this
switch.

Review URL: http://codereview.chromium.org/8907056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114556 0039d316-1c4b-4281-b951-d872f2087c98

Copy the url onto the stack.

BUG=99242
TEST=none


Review URL: http://codereview.chromium.org/8907055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114555 0039d316-1c4b-4281-b951-d872f2087c98

linux_redux does not have safe_browsing enabled in the GYP variables,
which causes all of chrome/browser/safe_browsing to be excluded from
the chrome_browser target - including safe_browsing_tab_observer.[cc,h]

This enables a stub SafeBrowsingTabObserver to be compiled when
safe_browsing==0, fixing the linker errors from TabContentsWrapper having
a SafeBrowsingTabObserver member.

BUG=none

Review URL: http://codereview.chromium.org/8909017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114553 0039d316-1c4b-4281-b951-d872f2087c98

This will fix vista boxes with legacy XP drivers and make ANGLE work if D3D9Ex is disabled.
Review URL: http://codereview.chromium.org/8913015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114551 0039d316-1c4b-4281-b951-d872f2087c98

BUG=107222
TEST=see bug

Review URL: http://codereview.chromium.org/8918022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114550 0039d316-1c4b-4281-b951-d872f2087c98

Eventually it would be great to have something more user friendly like 
chrome:net-internals, but this is at least a start.

BUG=30812
TEST=Run chrome with --vmodule=extension_updater=2, then try doing an 
extension update check (eg from chrome://extensions page, turn on development
mode and then hit the update now button). You should see some debugging output
on the console.


Review URL: http://codereview.chromium.org/8929019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114549 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8915016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114548 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8949003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114547 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114546 0039d316-1c4b-4281-b951-d872f2087c98

This is a checkpoint commit. It does the following:

- if Write() blocks, calls onEvent() when the underlying socket finishes its work.
- Demonstrates a working framework for sending events back to JS.

It does NOT do any of the following:

- Prove that the above statements are true.

In order to cause a UDP socket to block, we pretty much have to mock it, and I determined that I'd have to refactor my Socket class to let me put in a ClientSocketFactory for testing, which will then let me work DelayedSocketData in net/socket/socket_test_util.h into the mix and simulate Write blockage. After discussion with Antony, we agreed to break up this work into this CL and then a refactor/mock CL, which I'm working on now.

BUG=106802
TEST=none (see above).

Review URL: http://codereview.chromium.org/8896013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114544 0039d316-1c4b-4281-b951-d872f2087c98

- Add IPv6 support to talk_base::SocketAddress 
- Refactored PeerConnectionFactory interface 
- Bug fixes

BUG=none
TEST=trybots

Review URL: http://codereview.chromium.org/8914025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114543 0039d316-1c4b-4281-b951-d872f2087c98

The nacl_helper program uses content::MakeSharedMemorySegmentViaIPC but
none of the other proxy functions in the same source file.  Some of those
functions refer to symbols that bring in a great deal of other code, e.g.
most of v8.  We don't want all that code linked into nacl_helper--it bloats
the binary by a factor of ten or so.

Moving the function out to its own file prevents the other dependencies
coming in unnecessarily.

BUG= http://code.google.com/p/chromium/issues/detail?id=106986
TEST= still builds and nacl_helper binary is much smaller

R=jam@chromium.org,bradchen@google.com

Review URL: http://codereview.chromium.org/8893009

TBR=mcgrathr@chromium.org
Review URL: http://codereview.chromium.org/8914026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114542 0039d316-1c4b-4281-b951-d872f2087c98

Avoid creating a temporary |gfx::Font| just to get its
name and size to pass it to Skia.

Note: There's room for further optimizations here, such
as caching, which I plan to look at in a future CL.

BUG=107394
TEST=Run aura and check that omnibox still looks fine. Run about:tracing and check that time used by this code is significantly decreased.

Review URL: http://codereview.chromium.org/8910004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114541 0039d316-1c4b-4281-b951-d872f2087c98

Change-Id: I43866084657d7d9c9ebcdd466684ac6f3e993f1e

BUG=chromium-os:23912
TEST=Log in, lock the screen, and unlock it. Ensure that the network menu ends with 'Network settings...' + IP, not 'More...'

Review URL: http://codereview.chromium.org/8913017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114540 0039d316-1c4b-4281-b951-d872f2087c98

The nacl_helper program uses content::MakeSharedMemorySegmentViaIPC but
none of the other proxy functions in the same source file.  Some of those
functions refer to symbols that bring in a great deal of other code, e.g.
most of v8.  We don't want all that code linked into nacl_helper--it bloats
the binary by a factor of ten or so.

Moving the function out to its own file prevents the other dependencies
coming in unnecessarily.

BUG= http://code.google.com/p/chromium/issues/detail?id=106986
TEST= still builds and nacl_helper binary is much smaller

R=jam@chromium.org,bradchen@google.com

Review URL: http://codereview.chromium.org/8893009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114539 0039d316-1c4b-4281-b951-d872f2087c98

Showing the avatar menu crashes after crrev.com/114330.
SizeToContents was called before BubbleFrameView init.

This workaround checks GetBubbleFrameView before calling SizeToContents.
Also, run OnAvatarMenuModelChanged on Init, not ctor.

BUG=106989,107574
TEST=No crash and doesn't regress crbug.com/106989.

Review URL: http://codereview.chromium.org/8909013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114538 0039d316-1c4b-4281-b951-d872f2087c98

Upcoming test infrastructure requires access to this meember.

TEST=try bots.
BUG=none.


Review URL: http://codereview.chromium.org/8917020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114537 0039d316-1c4b-4281-b951-d872f2087c98

R=maruel@chromium.org
BUG=
TEST=Verified that this produces verbose debug spew in VS2008 official builds.


Review URL: http://codereview.chromium.org/8910022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114536 0039d316-1c4b-4281-b951-d872f2087c98

BUG=107470
TEST=Check output log, and compare CPU usage with the non-XDamage case.


Review URL: http://codereview.chromium.org/8937019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114535 0039d316-1c4b-4281-b951-d872f2087c98

This adds support for IDL in the private directory. Some of the interfaces there don't actually work, they were a work in progress and this breaks everything, so I moved the broken files to a new subdirectory. Everything left in the api/private directory can be autogenerated now.

BUG=
TEST=

Review URL: http://codereview.chromium.org/8930023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114534 0039d316-1c4b-4281-b951-d872f2087c98

BUG=107548
TEST=


Review URL: http://codereview.chromium.org/8942001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114533 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8907048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114532 0039d316-1c4b-4281-b951-d872f2087c98

BUG=98591
TEST=

Review URL: http://codereview.chromium.org/8916013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114531 0039d316-1c4b-4281-b951-d872f2087c98

R=mmoss@chromium.org


Review URL: http://codereview.chromium.org/8909011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114530 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromeOS/builds/2495/steps/unit_tests/logs/stdio

Show parse errors in the UI when loading ONC files.
BUG=chromium-os:23757
TEST=manual
Review URL: http://codereview.chromium.org/8883046

TBR=chocobo@chromium.org
Review URL: http://codereview.chromium.org/8947002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114528 0039d316-1c4b-4281-b951-d872f2087c98

This is the first of several CLs to add a "laptop mode" to Aura that works like the traditional ChromeOS browser view.  In particular:
* Keep the browser maximized.
* Hide window caption buttons.
* Suppress the launcher and related shelf items.
* Suppress background image.
* Add the switch to about:flags.

These things don't work yet:
* Status area is wedged in upper-left corner.
* Popup browser windows are maximized and they shouldn't be.

BUG=106898
TEST=manual, run ChromeOS Aura build and turn the flag on and off

Review URL: http://codereview.chromium.org/8895003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114527 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8911011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114526 0039d316-1c4b-4281-b951-d872f2087c98

BUG=107047
TEST=none


Review URL: http://codereview.chromium.org/8890074

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114525 0039d316-1c4b-4281-b951-d872f2087c98

BUG=107047
TEST=crypto_unittests


Review URL: http://codereview.chromium.org/8894023

TBR=mattm@chromium.org
Review URL: http://codereview.chromium.org/8913018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114524 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114522 0039d316-1c4b-4281-b951-d872f2087c98

There was a problem on one of the canaries yesterday that prevented a roll.
On current TOT WebKit there have been some build problems, but this
revision looks OK on the canaries.

BUG=none
TEST=canaries
TBR=morrita
Review URL: http://codereview.chromium.org/8930025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114521 0039d316-1c4b-4281-b951-d872f2087c98

The tests should all succeed but on bots where audio hardware is missing, we should get a printout that no devices were detected.

Notably the mac bots do have the necessary equipment which is how I ran into the bug.

TEST=This runs more tests in media_unittests on the bots.
Review URL: http://codereview.chromium.org/8941001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114520 0039d316-1c4b-4281-b951-d872f2087c98