- 13 Jan, 2021 40 commits
-
-
Karandeep Bhatia authored
This is an unused manifest key which hasn't been used for years. It seems this was used for signature verification: https://codereview.chromium.org/118328/patch/1205/130 but at some point it's use was removed. TODO: Also remove this key from https://developer.chrome.com/docs/extensions/mv2/manifest/ and https://developer.chrome.com/docs/extensions/mv3/manifest/. BUG=None Change-Id: I4ed42510e169c2fca569362820ebb210a1082845 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622572Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#843235}
-
Jeffrey Kardatzke authored
This sets HW secure codecs and and identifier as required if we are configured for the L1 ChromeOS Factory Daemon CDM. It then selects that CDM if the configuration specifies HW secure codecs and allows a distinct identifier. BUG=b:153111783 TEST=HW_SECURE_* use L1 CDM, otherwise L3 Change-Id: Ia2b4cfeace38755f1b823a8f15ff0cf325fde29b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625817Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#843234}
-
Prabir Pradhan authored
This reverts commit b89a947a. Reason for revert: The CTS failures caused by landing this change for P are being addressed in ag/13257099. For changes required for R, see b/176433665. Original change's description: > Revert "exo: Allow Pointer Capture when window is active" > > This reverts commit 43be36f0. > > Reason for revert: Multiple CTS failures > > Bug: b:175379280 > Bug: b:175514308 > Bug: b:175829322 > > Original change's description: > > exo: Allow Pointer Capture when window is active > > > > Pointer Capture was being rejected by chrome when an app came into > > focus using keyboard shortcuts (Alt-Tab), but was working as intended > > when an app came into focus using the mouse or touchscreen. It was being > > rejected because the capture_surface was the sub-surface of the current > > focused surface. > > > > Since the client is responsible for providing the capture surface > > through the wayland pointer constraints protocol, it is possible > > for the client to request capture on a sub-surface of the current > > active surface. Requesting capture on a sub-surface is a valid request > > for capture. Rather than ensuring that the capture surface is focused > > (used for directing key events), we verify that the active window > > contains the window of the capture surface in its hierarchy before we > > allow the pointer to be constrained to the surface. > > > > This also allows the client to change the cursor while the client has > > capture, even when the mouse cursor is not currently over a client > > window. > > > > BUG=b:153973515 > > TEST=manual: request pointer capture, leave app, return to app using > > Alt+Tab, verify app has pointer capture. > > TEST=exo_unittests > > > > Change-Id: I56e76469f35ea43100748ebe27966464e32805fc > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559255 > > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > > Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> > > Commit-Queue: Prabir Pradhan <prabirmsp@chromium.org> > > Auto-Submit: Prabir Pradhan <prabirmsp@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#832613} > > TBR=oshima@chromium.org,tetsui@chromium.org,prabirmsp@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: b:153973515 > Change-Id: I582f775f37c34149fb7f0c2a6b9162b5e72cbf78 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596065 > Commit-Queue: Prabir Pradhan <prabirmsp@chromium.org> > Commit-Queue: Mitsuru Oshima <oshima@chromium.org> > Auto-Submit: Prabir Pradhan <prabirmsp@chromium.org> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Cr-Commit-Position: refs/heads/master@{#837908} TBR=oshima@chromium.org,tetsui@chromium.org,prabirmsp@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b:175379280 Bug: b:175514308 Bug: b:175829322 Bug: b:153973515 Change-Id: I967663e2936a7d117ee2dce9edb8967ce922dd91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605465Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Prabir Pradhan <prabirmsp@chromium.org> Cr-Commit-Position: refs/heads/master@{#843233}
-
Karandeep Bhatia authored
Queue updateDynamicRules and updateSessionRules API calls to ensure: 1. They only execute once the initial rulesets are loaded from disk. 2. Successive API calls for the same extension execute in a FIFO order. 3. Only one of these calls for an extension executes at a time. Requirement #3 is needed to implement a shared rules limit for session and dynamic rules. The first requirement is needed for only dynamic rules to ensure the initial state for dynamic rules is first loaded up. This replaces the existing base::OneShot mechanism for fulfilling requirement #1. To ensure consistency, we also do the same for updateEnabledRulesets API calls. Doc=https://docs.google.com/document/d/1FZuuQkG8Tl4ee_K3Ls37iFhjynqStfDjApPvB1N8qsw/edit?usp=sharing&resourcekey=0-kZHQzo1D3pIDAFgYoTSV5g BUG=1043200 Change-Id: I4efef10c6d917c600f90f985c105164aa141610b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579716 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by: -
Domenic Denicola authored
This was missed in 7dbd3d17. Bug: 751996, 1158853 Change-Id: Ia4c7a56eb397c2c3a40ce69e87f7d1a945940552 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627091Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#843231}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610538373-fd44620c77870a58d7cfe6c95cdad1d7eb2cbcb8.profdata to chrome-win32-master-1610560659-4ba340836b4bfcb3a336687b253f7e1b1055ef00.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I91e3366c29083d9cbd8ce2d68e7fa615b59027a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627812Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843230}
-
Philip Rogers authored
This metric continues to be useful for ongoing projects and we will be using it for CompositeAfterPaint. Bug: 1165025 Change-Id: Id95574f1736bbaa4be3f2402a20a49e629b5b26f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623419 Auto-Submit: Philip Rogers <pdr@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#843229}
-
Jeroen Dhollander authored
Bug: b/176851446 Test: chromeos_unittests and deployed Change-Id: I1463132c4e545a1ca8aa7b62880b6c6c4125b00f Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615504 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Auto-Submit: Jeroen Dhollander <jeroendh@chromium.org> Cr-Commit-Position: refs/heads/master@{#843228}
-
Fabrice de Gans-Riberi authored
Previously, the Cast Streaming Session would be ended after either the audio or video stream received no data for 15s. However, some Cast Streaming Senders sometimes do not send video data for longer than that when there is no video update to send, resulting in the session being prematurely ended. This changes the Cast Streaming Receiver behavior to only end the session if no audio and no video data is received for 15 seconds. As a result, the frame duration has been changed to 10 minutes to prevent a demuxer underflow in the Chrome media pipeline, resulting in delayed playback. Bug: 1166371, b/172139177 Change-Id: I2f66ca009bdedb00ae79ac8e9dda8cc2ebcd16af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617363 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#843227}
-
Caroline Rising authored
Bug: 1109316 Change-Id: I67d5b3d69dedab79580370d7d5df9b6173a5a7d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627693 Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#843226}
-
Victor Costan authored
Bug: 1016065 Change-Id: Ibfdf962f7cba595e47d557556369b3868d9b69e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627430 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#843225}
-
Austin Sullivan authored
Currently uses raw pointers. Bug: N/A Change-Id: Ib1cfc799e349e54b3f931a27545c042a9f6137a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626096Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Austin Sullivan <asully@chromium.org> Cr-Commit-Position: refs/heads/master@{#843224}
-
Jiewei Qian authored
This test was disabled due to https://crrev.com/c/2602041 triggering a DCHECK in blink. https://crrev.com/c/2612357 fixed the CSS file triggering the DCHECK, thus re-enable the test. Fixed: 1162044 Change-Id: I83f3feea04c6092820f15160fc063a7566e4e701 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623607Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Jiewei Qian <qjw@chromium.org> Auto-Submit: Jiewei Qian <qjw@chromium.org> Cr-Commit-Position: refs/heads/master@{#843223}
-
Hidehiko Abe authored
chromeos::ReadStartupData() can be called in the process at most once, and later calls will fail. That caused initialization error. This CL fixes it by removing the call from PolicyLoaderLacros. Instead, LacrosChromeServiceImpl is instantiated at earlier timing (the same timing as D-Bus for ash-chrome), so it should be available on PolicyLoaderLacros use. Bug: None Test: Ran locally on DUT. Made sure no error logs. Change-Id: I606348c2b1db72d237d05d5a485dfa4f0ae4492b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626670 Auto-Submit: Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Igor <igorcov@chromium.org> Cr-Commit-Position: refs/heads/master@{#843222}
-
Rachel Wong authored
The suggested content toggle is launched and enabled by default, so we can remove its flag. Bug: 1166057 Change-Id: I4bbbbf903ddb954a084b1c8e639888a3970c31e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626812Reviewed-by:
Tony Yeoman <tby@chromium.org> Commit-Queue: Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/master@{#843221}
-
Mark Pearson authored
This reverts commit 3bd04812. Reason for revert: causes failures on Win 7 Tests x64 (1) Win7 Tests (dbg)(1) Win7 (32) Tests Example bot that failed: https://ci.chromium.org/ui/p/chromium/builders/ci/Win%207%20Tests%20x64%20(1)/76517/overview Top of failure message (it's long so I didn't paste the whole thing here): [ RUN ] PredictionManagerModelDownloadingBrowserTest.TestSuccessfulModelFileFlow ../../content/public/test/browser_test_base.cc(756): error: Failed RunLoop::Run() timed out. Stack trace: Backtrace: base::internal::Invoker<base::internal::BindState<`lambda at ../../base/test/scoped_run_loop_timeout.cc:49:9',base::Location,base::RepeatingCallback<std::basic_string<char> ()> >,void ()>::Run [0x0000000143A46C1D+157] (o:\base\bind_internal.h:692) base::`anonymous namespace'::OnRunLoopTimeout [0x00000001439B533E+46] (o:\base\run_loop.cc:44) base::internal::Invoker<base::internal::BindState<void (*)(base::RunLoop *, base::OnceCallback<void ()>),base::internal::UnretainedWrapper<base::RunLoop>,base::RepeatingCallback<void ()> >,void ()>::RunOnce [0x00000001439B6726+86] (o:\base\bind_internal.h:679) base::internal::CancelableCallbackImpl<base::OnceCallback<void ()> >::ForwardOnce<> [0x0000000141157DE6+54] (o:\base\cancelable_callback.h:128) base::TaskAnnotator::RunTask [0x00000001439CD3DD+365] (o:\base\task\common\task_annotator.cc:163) base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl [0x0000000144EE8481+433] (o:\base\task\sequence_manager\thread_controller_with_message_pump_impl.cc:352) base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork [0x0000000144EE814C+204] (o:\base\task\sequence_manager\thread_controller_with_message_pump_impl.cc:266) base::MessagePumpForUI::DoRunLoop [0x0000000143A011BA+122] (o:\base\message_loop\message_pump_win.cc:225) base::MessagePumpWin::Run [0x0000000143A008DA+90] (o:\base\message_loop\message_pump_win.cc:82) base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run [0x0000000144EE8DF1+273] (o:\base\task\sequence_manager\thread_controller_with_message_pump_impl.cc:463) base::RunLoop::Run [0x00000001439B4DE1+433] (o:\base\run_loop.cc:133) optimization_guide::PredictionManagerModelDownloadingBrowserTest_TestSuccessfulModelFileFlow_Test::RunTestOnMainThread [0x000000013FDFF540+288] (o:\chrome\browser\optimization_guide\prediction\prediction_manager_browsertest.cc:1045) content::BrowserTestBase::ProxyRunTestOnMainThreadLoop [0x0000000143C2BCB3+419] (o:\content\public\test\browser_test_base.cc:807) ChromeBrowserMainParts::PreMainMessageLoopRunImpl [0x0000000143A784EE+4582] (o:\chrome\browser\chrome_browser_main.cc:1688) ChromeBrowserMainParts::PreMainMessageLoopRun [0x0000000143A77241+65] (o:\chrome\browser\chrome_browser_main.cc:1044) content::BrowserMainLoop::PreMainMessageLoopRun [0x0000000141F3DFB9+73] (o:\content\browser\browser_main_loop.cc:946) content::StartupTaskRunner::RunAllTasksNow [0x00000001422F62C7+61] (o:\content\browser\startup_task_runner.cc:41) content::BrowserMainLoop::CreateStartupTasks [0x0000000141F3CD05+621] (o:\content\browser\browser_main_loop.cc:860) content::BrowserMainRunnerImpl::Initialize [0x0000000141F3FA1E+126] (o:\content\browser\browser_main_runner_impl.cc:130) content::BrowserMain [0x0000000141F3B579+161] (o:\content\browser\browser_main.cc:43) content::RunBrowserProcessMain [0x00000001428DCA39+169] (o:\content\app\content_main_runner_impl.cc:555) content::ContentMainRunnerImpl::RunBrowser [0x00000001428DD7F2+854] (o:\content\app\content_main_runner_impl.cc:1059) content::ContentMainRunnerImpl::Run [0x00000001428DD46F+335] (o:\content\app\content_main_runner_impl.cc:929) content::RunContentProcess [0x00000001428DC2D1+805] (o:\content\app\content_main.cc:372) content::ContentMain [0x00000001428DC64E+61] (o:\content\app\content_main.cc:398) content::BrowserTestBase::SetUp [0x0000000143C2B516+1894] (o:\content\public\test\browser_test_base.cc:683) InProcessBrowserTest::SetUp [0x00000001439630CE+398] (o:\chrome\test\base\in_process_browser_test.cc:351) optimization_guide::PredictionManagerBrowserTestBase::SetUp [0x000000013FDFF76A+266] (o:\chrome\browser\optimization_guide\prediction\prediction_manager_browsertest.cc:256) ../../base/test/metrics/histogram_tester.cc(43): error: Expected equality of these values: 0 expected_count Which is: 1 Zero samples found for Histogram "OptimizationGuide.PredictionModelDownloadManager.DownloadStatus". Original change's description: > Reenable PredictionManager and HintsFetcher browser tests that were > disabled on desktop platforms > > Change-Id: I173ac1025760f908042e64c7c8839fb90e41fc78 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626918 > Reviewed-by: Michael Crouse <mcrouse@chromium.org> > Commit-Queue: Sophie Chang <sophiechang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#843180} TBR=sophiechang@chromium.org,mcrouse@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Ia5e026dcfd3a0b0ccfb68c2baad18209222a02b4 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628258Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#843220}
-
Andre Le authored
In Nearby Share, we encounter a problem of an image notification not showing entirely. This happens because of this use case: - The popup notification A is showing and we hover over that notification. - Notification A is then removed automatically to show notification B with image. - Notification B with image is cut off because we accidentally enter hot mode. This CL added a check so that we only start hot mode when necessary (when a notification is closed by an actual user). Fixed: 1154741 Change-Id: I306e66e92d2e28ba11cb1526089789ad1eb9331b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591267 Commit-Queue: Andre Le <leandre@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#843219}
-
Jesse Schettler authored
Bug: 1059779 Change-Id: I71852964a000718a4d2db8ee3bd2c988ab0356ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628030 Commit-Queue: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#843218}
-
Richard Chui authored
Extend the expiry date of the Tabs.ScrubDuration histogram to a year later. Fixed: 1165198 Change-Id: I3073b92cf3b778c57c5a2ad8901a2537405e9a91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625155Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Richard Chui <richui@chromium.org> Cr-Commit-Position: refs/heads/master@{#843217}
-
David Black authored
It is possible to open a context menu via two finger gesture tap. We previously didn't handle this gesture so selection state was empty. Bug: 1166274 Change-Id: I259082d7c41391a23ccabd99573343e77c68bc78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627440Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#843216}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610549866-1e248feef781fb0cfb48b77513413e45541eeb72.profdata to chrome-win64-master-1610560659-e96e8917fec116ef2a139db8416bd66f9188db27.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I51ad308ffbeb0501d1e4cd80dd8fb0b08d4e6d00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627906Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/fdd89469d681..4e0ef215f6da 2021-01-13 ddoman@chromium.org [resultdb] move the cipd pin of infra/tools/rdb in depot_tools If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1141153,chromium:1155298 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ieebe70ae1c149993a906f6d4dc35ff80d252076e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626106Reviewed-by:
-
David Black authored
Previously in RTL the ink drop was drawn outside of view bounds. Bug: 1166271 Change-Id: I454871125239d40b65ee2b2606ae0953562e51c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627438Reviewed-by:
-
Josiah K authored
Don't include focus following result "Magnifier follows keyboard focus" in Chrome OS Settings search results when screen magnifier is disabled. Before: https://screenshot.googleplex.com/7k4npcGDnBznceP After: https://screenshot.googleplex.com/5Gmmstz22u7Dcfi AX-Relnotes: N/A. Fixed: 1165652 Change-Id: Ibb7dd1c7b7e301c0322d09615765484205958d3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623429 Commit-Queue: Josiah Krutz <josiahk@google.com> Auto-Submit: Josiah Krutz <josiahk@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#843212}
-
minch authored
See demo at the crbug. Bug: 1158583 Change-Id: I7ee3ff75c2126543a2fe215817281c11540d080a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2604683Reviewed-by:
-
Morten Stenshorne authored
The block-size of the column fragment in the initial column balancing pass isn't used for anything (at least currently), but setting it to kIndefiniteSize is pretty bogus. Don't do that. https://chromium-review.googlesource.com/c/chromium/src/+/2611570 is about to introduce DCHECKs for such situations. Change-Id: Ib6c7342ecc2f29a9d4d29c64bbaee8e2bde1243f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626431Reviewed-by:
David Grogan <dgrogan@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#843210}
-
Joel Riley authored
For consistency with autoclick panel, feedback from UX review. Bug: 1140216 Change-Id: I324ce723bc9e5c69be8f3fe39a7aba4ce2ed27db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626924Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Joel Riley <joelriley@google.com> Cr-Commit-Position: refs/heads/master@{#843209}
-
Nicholas Hollingum authored
Previously we manually calculated the rootfs/kernel path using the mount point of the DLC. This is actually done by concierge now, and we should use it instead of re-doing the work ourselves. Bug: b/177367054 Change-Id: Ic3137f9c0b5b3c186e84795ff64329e8b5e2a819 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626607Reviewed-by:
Daniel Ng <danielng@google.com> Commit-Queue: Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#843208}
-
Reilly Grant authored
This change enables the throbber and status message that are used for the Web Bluetooth device chooser prompt on all of the other APIs which use this UI. This improves the user experience for users on slower devices where it can take some time for the set of available options to be available. Bug: 1160147 Change-Id: I59a03c1a94f58fdb38bf7c8d2d713680cb21c5aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597903Reviewed-by:
Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
-
Erik Chen authored
This CL adds stubs to finish flushing out the platform keys extension APIs. This CL has no intended behavior change on ash -- it just renames some files. Bug: 1164523 Change-Id: I2d201f7f648f86c26c97c5612280b52706b80a06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625750Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Michael Ershov <miersh@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#843206}
-
Edman Anjos authored
Inform arc-keymasterd of Chaps keys that will be installed in ARC. Needed so arc-keymasterd can associate placeholders to the original Chaps keys appropriately. out_/Default/unit_tests --gtest_filter="ArcCertInstaller*" && \ out_/Default/browser_tests --gtest_filter="CertStoreServiceTest*" Bug: b:172907736 Test: autoninja -C out_/Default unit_tests browser_tests && \ Change-Id: I85b2d234c5f12706093428228bcf690de45ddd9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613965 Commit-Queue: Edman Anjos <edman@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Polina Bondarenko <pbond@chromium.org> Cr-Commit-Position: refs/heads/master@{#843205}
-
Jiawei Li authored
Those interfaces are used for organizing Cast native windows to work with an external window manager via the interface CastWindowEmbedder primarily through pre-defined events and requests. The unittest is not exhaustive and more test cases will be added in follow-up CLs. Bug: Internal b/173251340 Test: cast_content_window_embedded_unittest Change-Id: I9385cfb0bd2af64cc364f74f5c1b86b88d4432ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539668Reviewed-by:
Shawn Gallea <sagallea@google.com> Reviewed-by:
Sean Topping <seantopping@chromium.org> Commit-Queue: Jiawei Li <lijiawei@chromium.org> Cr-Commit-Position: refs/heads/master@{#843204}
-
Austin Sullivan authored
This fixes a leak in a obfuscated_file_util_unittest, allowing us to enable LSAN on this test. Bug: 961068 Change-Id: I798bc4e0e2c5b344d29d3588102eb9a598801381 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627359 Auto-Submit: Austin Sullivan <asully@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#843203}
-
Jun Kokatsu authored
While there are many online resources about general CSP, it's hard to find similar resources for Trusted Types, especially on how to convert existing JS code. This change adds explanation of Trusted Types as well as tips for how to convert existing JS code to be compatible with Trusted Types mitigation on WebUI. Bug: 41905 Change-Id: Ia8382c8a7542bcd45be9a1b8434e23388a93b483 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616966 Commit-Queue: Jun Kokatsu <Jun.Kokatsu@microsoft.com> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
-
Austin Sullivan authored
In ObfuscatedFileUtil::InitOriginDatabase method Bug: N/A Change-Id: I630c0e40a56db336c12f80c7869fd48a6fe6f451 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627136 Auto-Submit: Austin Sullivan <asully@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8fccd82e4e02..704a1aa4c802 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I60e6cdbf43c4a3889a860a68e3ce6d3465ee1334 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627968Reviewed-by:
-
Clark DuVall authored
WebView compatibility is on by default, so this is no longer needed. Bug: 1051358 Change-Id: I88740862ad035d91271974417512bcd4da42c3d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628231 Commit-Queue: Clark DuVall <cduvall@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#843199}
-
Javier Ernesto Flores Robles authored
Expose APIs to replace the input view and input accessory view in web view. Bug: 1163967 Change-Id: I98c5dce1cc1f06bbebaf97c881a8520280567b8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611903 Commit-Queue: Javier Flores <javierrobles@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#843198}
-
sczs authored
- If the Discover Feed is OFF then the non refactored version (which uses ContentSuggestionsVC as the main NTP VC) will be used, for this container VC is created on NTPCoordinator which is returned to BVC. The contained VC will change (between NTPVC and ContentSuggestionsVC) depending on the Feed being ON or OFF. - Adds an extra check on most IsRefactoredNTP calls, so the refactored NTP is only used when the Discover Feed is on. - Moves the NTPHomeMediator creation to NTPCoordinator. Bug: 1114792 Change-Id: I64b82462825da7bd66f1004e89f55c64313f1dbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625508 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Adam Trudeau-Arcaro <adamta@google.com> Cr-Commit-Position: refs/heads/master@{#843197}
-
Weblayer Skew Tests Version Updates authored
This CL will add skew tests for version 88.0.4324.89. R=rmhasan@google.com Bug: 1041619 Change-Id: I4960c11db72692f4bd1518311e8c3efac84f6dd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626779 Commit-Queue: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#843196}
-
