GitLab

- Encapsulates a data point in a diagnostics card.

Bug: 1125150
Test: browser_tests --gtest_filter=DiagnosticsApp*
Change-Id: I0cb465fdd62ac2fafa5d17436e6486f5f0a2bf5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427075
Commit-Queue: Michael Checo <michaelcheco@google.com>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810836}

First in a series factoring the ThreadProfiler platform specific
configuration state from the code that takes action on the
state. Defines an IsSupported function that is true if the profiler
is supported on the chrome branding and channel for the platform.

The end goal is to reduce the configuration complexity, to support
enabling per-thread on Android.

Bug: 1129939
Change-Id: Ibbd6f4725804b40ac77e15aaa3bd15ad76a0e7b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425165Reviewed-by: ssid <ssid@chromium.org>
Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Commit-Queue: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810835}

On x86 as well as on ARM. It breaks Java test
`JavaBridgeCoercionTest.testPassNull`.

There is probably an underlying bug that we need to fix.

Bug: 1131993, 977230
Change-Id: Ie579516a06d13577fcb4a61fa515a2d873bfcd15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429233Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Chris Palmer <palmer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810834}

This should not change deep scanning behaviour with Connectors.

Bug: 1103390
Change-Id: I8f45972d7649eae31d7c3e9024f925c059ad68d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427427Reviewed-by: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810833}

Rsync was failling with permission denied (13) when trying to
send_file for some tests. The belief is that it's happening
because the file that was trying to be sent is lacking read
permissions for all.

Bug: 1126533
Change-Id: Iaf02d8bb71c8a571230cab6fc5f873d8227d7f8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431781
Commit-Queue: Michael Chang <donchan@microsoft.com>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810832}

Bug: 1024586
Change-Id: I1b3e2e7adce8d36a818e9619b4f28eb4b0fcd88c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427134Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810831}

This CL moves the existing |PhoneStatusView| out of the |PhoneHubView|
and adds it as a separate child view of the bubble, so that it can always
show on top of UIs and display available phone information and the
settings icon.

Misc: remove unnecessary header files.

Screenshot: https://screenshot.googleplex.com/6DXqin6MZPcTVVj.png

BUG=1106937,1126208

Change-Id: I321d0511874cfa95dcbb8276fedf41b14e0f684b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429390Reviewed-by: Tim Song <tengs@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Meilin Wang <meilinw@chromium.org>
Commit-Queue: Meilin Wang <meilinw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810830}

pthread_getattr_np implementation in bionic throws sigabrt on failure to
read proc/ file. Implement this function to avoid crashes.

BUG=1129941

Change-Id: I54b94a609201a998924aaa8c8e77051f85acf377
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425744
Commit-Queue: ssid <ssid@chromium.org>
Reviewed-by: Mike Wittman <wittman@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810829}

This patch invalidates ink overflow cache for text when
|NeedsRecomputeVisualOverflow|.

Computing text ink overflow is expensive, especially for
i18n fonts on Windows.

Bug: 1130856
Change-Id: I73e14af84e1c261fd95acf5ceb1bade1c46d0095
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424365Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810828}

When creating symbol diffs, mismatches in alias counts and summing
fractional padding PSS values can lead to DiffSymbols with non-integer
padding values. However, numeric values in .sizediff files should be
integers. This CL implements a simple fix: Round paddings to integer
when creating DiffSymbols. The resulting inaccuracy would be in the
order of bytes, and therefore negligible.

Bug: 1132394
Change-Id: Iba9acb0a94de6890aec01ac6c9ee450fb9d69dd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432668
Commit-Queue: Samuel Huang <huangs@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810827}

https://android.googlesource.com/platform/external/perfetto.git/+log/fe40be6924e2..df3ae5e6f975

2020-09-25 treehugger-gerrit@google.com Merge "flamegraph: Compress text if it almost fits"
2020-09-25 hjd@google.com Merge "flamegraph: Reduce font size and improve rollover rendering"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: Id218baa5862af6d7010a0bb7bfe3ae4073434078
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432273Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#810826}

Speculative fix. We now observe a folders item list on
creation, but it seems we forgot to stop observing in
one case. When the scoped observer list destructs, it tries
to stop observing things that no longer exist.

This should fix the crash we are seeing in M-86.

Bug: 1130901
Change-Id: I078e570a9beb67fda7efd48ba40ec52bda47aab7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429524Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810825}

- Remove ampersand symbol (&) from IDS_EDIT string before adding to the
  PDF viewer UI.
- Don't toggle annotation mode if dialog is not confirmed
- Strings - remove ending '.' per UX feedback

Bug: 1048876
Change-Id: Ie8afacd21b10595e6c1ef8878ca5091027042224
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429976
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810824}

Webkit indirectly forces a user gesture on the final restore
navigations because _crFinishSessionRestoration is called from native
code via ExecuteJavaScript. This has unintended consequences (such as
triggering universal app links). Instead, use setInterval() to discard
the gesture after the first interval callback.

NOTRY=True
# The chromium_presubmit bot seems to not be running atm, skipping.
NOPRESUBMIT=True

Bug: 1129875, 1132099
Change-Id: I4ee26947ac383d35b7c2175c8cc60ee48dd11cf9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432053
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Ali Juma <ajuma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810823}

This adds metrics for the SCT auditing cache and SCT auditing reports:
- Whether a new report is deduplicated against an existing report in
  the cache, to track efficiency gains of deduplication and for
  tweaking the cache size.
- Whether a report is sampled for sending or not, to track how many
  reports we discard due to sampling.
- The size of a report before it is sent (in bytes), to track how
  much bandwidth is consumed by reports.
- Whether sending a report to the reporting URI succeeded or not, to
  track error rates.
- The high-water mark of the cache size over each browser session (in
  # of reports stored), used to track if max cache size is reasonable.

This also adds unit tests covering these histograms.

Bug: 1107897
Change-Id: If8aa73848fcf5ef7aceca27b4e1ce3e04d75851a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421870
Commit-Queue: Emily Stark <estark@chromium.org>
Reviewed-by: Robbie McElrath <rmcelrath@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810822}

This reverts commit 63eccefc.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 810784 as the
culprit for failures in the build cycles as shown on:
https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzYzZWNjZWZjNzk5YmNjNTI0NDRjNzgxMjdkYWQzZGI0ZGU2NjdjMTQM

Sample Failed Build: https://ci.chromium.org/b/8868150038637383760

Sample Failed Step: compile

Original change's description:
> Dynamically load libwayland-client and libwayland-egl on Linux
> 
> This is needed since some distros do not have libwayland-client
> available.  If systems don't have libwayland-client, they definitely
> won't have a wayland server either, so it doesn't make sense to
> statically link libwayland-client, which won't make wayland work and
> will only waste binary size.  Instead, this CL dynamically loads
> libwayland-client if available.
> 
> Also, this CL includes some misc fixes to fix the 'ninja all' build
> for Linux/ozone.
> 
> R=msisov
> 
> Bug: 1126894
> Change-Id: Ice0fd0b113f5d804cd05089bfad54168d94c53e4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416941
> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Reviewed-by: Maksim Sisov (GMT+3) <msisov@igalia.com>
> Cr-Commit-Position: refs/heads/master@{#810784}


Change-Id: Ib8d9f5bdb0091800595af28d15f9d0dc529dc8d8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1126894
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432924
Cr-Commit-Position: refs/heads/master@{#810821}

To improve user experience, this sorts the Bluetooth device list in
settings page so that the connected devices are shown on top followed by
non-connected devices.

BUG=b:168257187

Change-Id: I60fcb820d6a6409460970273aefb1824c7354ebf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419379
Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810820}

Add chip view to downloads/bookmarks menu items.

This CL introduces ChipViewMenuItemViewBinder as a new CustomViewBinder,
it will have a chip view at the end if the feature is enabled.
This CL also moved AppMenuAdapter#OnClickHandler out of AppMenuAdapter,
and renamed to AppMenuClickHandler, because ChipViewMenuItemViewBinder is
the first CustomViewBinder has two items to be clicked, and the click
handler needs to handle clicking items individually.

Bug:1130663

Change-Id: Ia9c0a0350c6e912ee6519d30a07cba2f74a1f72a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2420256Reviewed-by: Sinan Sahin <sinansahin@google.com>
Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Gang Wu <gangwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810819}

https://skia.googlesource.com/skia.git/+log/1748c6a3b8c8..aeae3a58e3da

2020-09-25 johnstiles@google.com Add golden outputs for the Metal backend.
2020-09-25 robertphillips@google.com Fix creation of gpu resources in GrThreadSafeViewCache tests
2020-09-25 johnstiles@google.com Migrate most SkSL tests currently in /glsl/ to /shared/.
2020-09-25 csmartdalton@google.com Add a "_volatile" suffix to AllPathsVolatile configs
2020-09-25 johnstiles@google.com Clean up SkSL test compilation in preparation for Metal support.
2020-09-25 egdaniel@google.com Fix checks of GR_TEST_UTILS.
2020-09-25 johnstiles@google.com Traverse FieldAccess' base expression in visitExpression.
2020-09-25 jsimmons@google.com Handle surrogates in SkUTF::UTF16ToUTF8

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC csmartdalton@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: chromium:1108408
Tbr: csmartdalton@google.com
Change-Id: I349a6ac1af18390c911dcde5a957fb8ed201a20e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432585Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#810818}

Bug: 1130440
Change-Id: Ia34251245d22c444cacd767fb0d0c0165d1f0221
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432274Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810817}

Using wpt-import in Chromium 17915b1a.
With Chromium commits locally applied on WPT:
8f02a380 "Use allow attribute for delegation in web serial WPT"
c1a7d15a "[LayoutNG] Multicol baseline propagation support."
f30daabb "[COOP] access reporting: test with redirects."
74e4b2fc "[COOP] access reporting: Use infinite timeout for receive."


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
drott@chromium.org:
  external/wpt/css/css-text-decor

NOAUTOREVERT=true
TBR=foolip@google.com

No-Export: true
Change-Id: If6ec54879c69e8abe466f21785d259dc9f2e248b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431588Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#810816}

This CL
* Adds ShoppingTasksHandler mojo interface that provides the current
  shopping tasks and is exposed to the NTP.
* Adds JS boilerplate that will later become the shopping tasks module.
  As a first step this JS code queries the current shopping task from
  the new mojo interface above.
* Removes ShoppingTasksData and uses the new ShoppingTask mojo struct
  instead.

# For //chrome/browser/resources/BUILD.gn deps change.
TBR=aee@chromium.org

Bug: 1130855
Change-Id: Id2103d9418c09787de5f8c98f5949b6c7b1eb4ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429968Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810815}

WKWebView was returning a blank PDF when requesting a PDF to get
generated for a loaded PDF (during full page screenshot scenario).

Fix: Disable PDF generation on non-HTML Web states.

Bug: 1131566
Change-Id: Ia5ac045b8ec1335266e98ef8cf7eb00a8c62f0d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431553
Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810814}

A change fixes/improves the behavior of SkPictureImageFilter, that will
require some adjustments/updates to test results.

Change: https://skia-review.googlesource.com/c/skia/+/319616

Bug: skia:10744
Change-Id: Id5f9376edd3c74360c1a915a624752a98554c742
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431432
Auto-Submit: Fredrik Söderquist <fs@opera.com>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810813}

In guest mode print jobs did not appear in print management app. This
prevented users being able to cancel in-progress jobs.

Overriding GetBrowserContextToUse allows using an OTR profile so that
jobs appear in the app.

Added function BuildInstanceFor for creating PrintManagement service in
tests.

Bug: 1128690
Change-Id: I837afd57711505e7bf8ab93f9aa38ed16dc5d3d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412222
Commit-Queue: Gavin Williams <gavinwill@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810812}

to AutofillAgent.

This fixes a bug when no longer required suggestions are returned
asynchronously and are propagated to AutofillAgent latest instead of
actually requested suggestions.

Bug: 1097015
Change-Id: I263bcf619b1a4898a68837890abe3e5a7a483f8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421460Reviewed-by: John Wu <jzw@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Vadym Doroshenko  <dvadym@chromium.org>
Commit-Queue: Maria Kazinova <kazinova@google.com>
Cr-Commit-Position: refs/heads/master@{#810811}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: I6c607fc6831ff6287e405190af6011264277795f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432272Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#810810}

TBR=govind@chromium.org

Change-Id: I3c58fa8f5e80eae0ce78a5693ca5d3addbd76aa2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432129Reviewed-by: Ben Mason <benmason@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Commit-Queue: Ben Mason <benmason@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810809}

Aligning holding space strings with latest spec.

Bug: 1128731
Change-Id: Ib99e74abea9898f600b6b752ac8c8018e8f85a67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432364Reviewed-by: Ahmed Mehfooz <amehfooz@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#810808}

Followup to crrev.com/c/2429243. Chrome Java code for reading feature
params is done is such a way that it sets its own defaults instead of
the ones centrally defined with the feature params in chrome_features.cc

Bug: 878582,1098039
Change-Id: Ifef32ee702334e5d422b30490c472b165f3b48cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431790
Auto-Submit: Eric Orth <ericorth@chromium.org>
Commit-Queue: Dan McArdle <dmcardle@chromium.org>
Reviewed-by: Dan McArdle <dmcardle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810807}

Bug: 1131353
Change-Id: I637327b094a6b4421ac5565edcfb9a44a7cfbb08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425749
Commit-Queue: Yusuf Sengul <yusufsn@google.com>
Reviewed-by: Rakesh Soma <rakeshsoma@google.com>
Cr-Commit-Position: refs/heads/master@{#810806}

Bug: 1132230
Change-Id: Ief82359c2541d387cb2464c4ae7903075fb32275
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432026
Auto-Submit: Maxim Kolosovskiy  <kolos@chromium.org>
Commit-Queue: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810805}

Previously we check if the accessibilityHint is set in accessibilityHint method, which blocks the EG test when printing out the UI hierarchy by calling self.accessibilityHint infinitely. Refactor it to customizedAccessibilityHint and expose it in TableViewInfoButtonCell resolve this and make the logic clear. Because for now only settings UI are using TableViewInfoButtonCell and the accessibilityHint for it is customized.

This CL is followed by EG test for settings UI.

Change-Id: Ic56eb1fdd235bca9da06d076b31ee8c9537c805f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431725Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Tina Wang <tinazwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810804}

This change merges the enums chrome.automation.EventType and
chrome.automation.GeneratedEventType into one enum.

In the native C++ handlers, the two sources of these events is stringified and
assumed to be camel-cased which is what automation expects in js.

This change also shifts enforcement of the relationshipbetween automation and ax
enums from a presubmit to a compilation time warning. At the warning site, a
message is left for the change author to consider the change being made and
actions to take. This applies to both ax events and ax generated events.

Change-Id: I61152f66b2ccf00ba635b2c28caa71fc0caafe5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424854
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810803}

This is a reland of 2e94ca8d that just
disables the failing assertion on Mac until the root cause is figured
out.

Original change's description:
> Add accessibility alert event when DeepScanningDialogViews changes
>
> This allows a screen reader to read the updated text of the dialog.
>
> Bug: 1131565
> Change-Id: I73a2df8067ffc96148ebf5d50a9412cf34b67feb
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424841
> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
> Reviewed-by: Roger Tawa <rogerta@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#810290}

TBR=rogerta@chromium.org,dmazzoni@chromium.org

Bug: 1131565
Change-Id: If8ba41e1490e9cfa0013fc4de145bbdebebc1c45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431785Reviewed-by: Dominique Fauteux-Chapleau <domfc@chromium.org>
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810802}

This reverts commit 74826cab.

Reason for revert: testing whether this is responsible for rendering.mobile perf regression

Original change's description:
> [Sampling profiler] Move ENABLE_ARM_CFI_TABLE to profiler header
>
> ENABLE_ARM_CFI_TABLE is in service of the sampling profiler on Android,
> and is unrelated to any debugging functionality, so move it to a
> buildflag header under base/profiler.
>
> Also add the required includes to the files that use it.
>
> Bug: 1129939
> Change-Id: I884b2128fc2ab2f6f1bec2343c59134448328529
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421443
> Commit-Queue: Mike Wittman <wittman@chromium.org>
> Commit-Queue: Lei Zhang <thestig@chromium.org>
> Auto-Submit: Mike Wittman <wittman@chromium.org>
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#809167}

TBR=thestig@chromium.org,wittman@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1130974, 1129939
Change-Id: I00050d0bf8cd7988d0ad8969f0b8a29e8accf669
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432308Reviewed-by: Mike Wittman <wittman@chromium.org>
Commit-Queue: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810801}

TBR=achuith@chromium.org
R=achuith@chromium.org

Bug: 1132417
Change-Id: I5c1203d7e365efad46aec23fcccbedca14b9af26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432188Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810800}

In a bunch of places, an event is created and then cloned using
WebInputEvent::Clone() function without the original event being used
anymore. The only purpose of cloning seems to be to create a unique_ptr
of the event. Instead, the event can be created on the heap from the
beginning to avoid unnecessary cloning. This CL also replaces some
emplace_back's with push_back's per https://abseil.io/tips/112.

Bug: 1079116
Change-Id: Ib0da3873cc81c4f259f581e4aea08d4a23dab521
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429589Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810799}

PDFiumEngine is sent a request for a thumbnail from the client. If the
page is available for rendering, the request is immediately scheduled.
Otherwise, the request is scheduled when the page becomes available.

Bug: 652400
Change-Id: I9377619a5f71dce5daa727630a9003f2dc9aac5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415588
Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
Reviewed-by: Kahmy Moon <kmoon@google.com>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: K. Moon <kmoon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810798}

Now they are defined the same. Use `is_linux` everywhere to avoid
confusion.

Bug: 1132395
Change-Id: Ib6288cefb2b3447b7ead54632f31dd34d778dd6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431777Reviewed-by: Ted Meyer <tmathmeyer@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810797}