GitLab

Bug: None
Change-Id: I69959f2549294ea6c45edc93595925ceaaebcb28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917531Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Elad Alon <eladalon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716928}

The TerminalSystemApp feature flag will still control
whether the new terminal app is shown, but we will always
allow chrome://terminal to serve content since it is now
used for crosh.

Bug: 1022250
Change-Id: I5feae6e4d6cfe5bf7fd830d27f55a343d390fb6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924330
Auto-Submit: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716927}

This change directly apply opacity in the disabled state instead of using
different background-color/color.

Tests are also added to verify the color of the empty space (below the options)
with white and black background.


Bug: 1021228
Change-Id: I942323bc04444b04ba14506aece95adf5de5b506
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920474
Commit-Queue: Alex Keng <shihken@microsoft.com>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716926}

HKCU\Software\Google\Chrome key should be deleted during uninstall if it
has no subkeys that must persist (i.e., Extensions and
NativeMessagingHosts).

BUG=931268
R=etiennep@chromium.org

Change-Id: I1f2c7f97a48bc9861efba941123f529a38bda07a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924511
Commit-Queue: Greg Thompson <grt@chromium.org>
Auto-Submit: Greg Thompson <grt@chromium.org>
Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716925}

This was originally introduced in
https://chromium-review.googlesource.com/c/chromium/src/+/1781442.

It's being removed now as the implementation of this service will rely
on a different transport.

Change-Id: Idc493fd59c8ef44d7867cc45c91af2ad9b9217a0
Bug: 1020579
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924191Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Joao da Silva <joaodasilva@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Joao da Silva <joaodasilva@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716924}

This CL componentizes the //chrome/browser/ssl dependencies of
//chrome/browser/ssl's SSLBlockingPage(Base). A followup CL will
componentize those classes themselves. The goal is to dedupe
WebLayer's SSLBlockingPage implementation by sharing //chrome's.

This CL does not put any of the moved files in the
security_interstitials namespace to avoid churn on files that will
subsequently move.

Bug: 1025059
Change-Id: I1f5cb6f9cfb6468089a259bf135d1db6970c9441
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924428Reviewed-by: Carlos IL <carlosil@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716923}

This patch is a part of FetchEvent WorkerTiming patches. This feature enables a
service worker to attach PerformanceMark/PerformanceMeasure timings to a
request during the fetch event handler. The timings will then be exposed to the
page using blink::PerformanceResourceTiming.

This just adds TODO comment about FetchEvent WorkerTiming for navigation. This
patch doesn't change any behavior.

Explainer : https://github.com/wanderview/fetchevent-worker-timing/blob/master/explainer.md
Design doc: https://docs.google.com/document/d/1-ebnv7OFiVd3k2-jbtQGO5s3BKHIp7lRx3ujhgNKvB0

Change-Id: I9f999ef458fbcbef9189f5d6cf3d10c6ba63c1c1
Bug: 900700
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924172
Commit-Queue: Yuta Kasai <yutakasai@google.com>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716922}

It doesn't seem to be useful any longer. It's only set by SearchBoxView
when the search box text input changes, and it's only read by
SearchBoxView to update the search box text input when the model value
is changed (which seems a bit redundant). Additionally, SearchBoxView
stops observing the model while it's updating the selection, which means
that SearchBoxView::SelectionModelChanged  (the only code that actually
accesses the search model's selection model) doesn't ever get called.

Change-Id: I7e9489ea703942f7759162e5e3527f438c143e8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925287Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716921}

This CL moves the network::ResourceRequest referrer serialization
logic out-of-line, allowing us to extract debugging information from
the associated DumpWithoutCrash().

R=dcheng@chromium.org

Bug: 1021908
Change-Id: I7df6c8744c70ef94928db79042b650a8a612f4e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925121Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716920}

Suspected change reverted:
https://chromium-review.googlesource.com/c/chromium/src/+/1913610

TBR=dtseng@chromium.org

Bug: 1026473
Change-Id: I71347783dd8264aa459c9c6236bed65b6780282e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925889Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716919}

base::Bind is deprecated in favor of base::BindOnce or
base::BindRepeating depending on whether the callback is invoked once
or multiple times.

Bug: 1007777
Change-Id: Ia24167c85acd53947f53f26b77e2264ac95131d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923985
Auto-Submit: Yuzu Saijo <yuzus@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Yuzu Saijo <yuzus@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716918}

This imports feed code into chromium/src/third_party.
third_party/feed_library is now a copy of what used to be
DEPS imported into third_party/feed.

References to third_party/feed have been replaced with
third_party/feed_library.

Note that the directory name was changed to satisfy a presubmit
failure.

third_party/PRESUBMIT.py was updated to fix a bug encountered in this CL.
The cause was that it identified the removal of third_party/feed's README,
and thought that files in third_party/feed_library/ were in the same
directory.

Why move the feed into chromium?
This library is no longer used in other projects, and we will in the
future be making simplifications to the code for its future use in chrome,
longer term migrating parts to c++. Having the code in the Chromium repo
lowers friction to changes. See the bug and doc for more information (sorry
but those are view-restricted).


Bug: 1024945
Change-Id: I7871f7ede706b9f9b4fe23111a1113b339562dd0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917083
Commit-Queue: Dan H <harringtond@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716917}

Bug: 981740
Change-Id: Icd020d557eee5e0aa680119ade6022015f88f615
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905296
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716916}

Enables DataSaverPreview and PreviewsOmniboxUI IPH by default using the
same parameters as are currently configured on the server.

Note: IPH_DataSaverMilestonePromo is country-specific and is not yet
supported to be enabled in source by the feature_engagement service.

Bug: 1025793
Change-Id: Idea41e657c8c68a2538cf01cc78b7771f1ae9636
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921701Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716915}

Bug: 1010709
Change-Id: Id16378ce81661b1b94e46e49dc169982ed5d74c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925221
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Auto-Submit: Manu Cornet <manucornet@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716914}

This CL cleans up old Mojo types from proxy_resolver_factory_mojo_unittest.cc
which has InterfaceRequest and Binding. InterfaceRequest is replaced
with PendingReceiver and Binding is replaced with Receiver.

Bug: 955171
Change-Id: I242baf4a0e3e4ef0c630aa3b5aaf327b64d764f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923783
Commit-Queue: Julie Kim <jkim@igalia.com>
Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#716913}

'Date' should be 'object' with [CallWith=ScriptState], and corresponding
C++ implementations should be:
  void setFoo(ScriptState*, const ScritValue&, ExceptionState&) and
  ScriptValue foo(ScriptState*).

This CL adds base::Time::ToJsTimeIgnoringNull() in order to make
|input.value = '1960-01-01'; ... = input.valueAsDate;| workable
with base::Time.

This CL should have no user-visible behavior changes.

Bug: 988353
Change-Id: I145f9f423a66b642d04371bb5686a4287f4586f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916529
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716912}

Bug: 1018108
Change-Id: I7ed543d4411fa7f7e1962e69de791c582324548f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1908532Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716911}

TBR=alexclarke@chromium.org

Bug: 1026523
Change-Id: I36bf6c1bda9160c7df88e647c53d46894f168b89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924342Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716910}

This CL fixes an issue with Mac scrollbars which caused scrollbar
track clicks to not get animated.

Bug: 1025147
Change-Id: I7304cb8e9a6c02439ee7c4a6e7f6c1d3dbfeebf2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917956
Commit-Queue: Rahul Arakeri <arakeri@microsoft.com>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716909}

GtkUi is currently already used in Ozone X11. Ozone platform
initialization code calls XInitThreads() function to init Xlib in
threaded mode under certain conditions**, which according to the docs
should be called before any other Xlib call [1].  However, GTK is
initialized before Ozone platform, which makes Gtk to create/init X11
connection object before calling XInitThreads(), that's wrong and causes
crashes when Gtk file dialogs are instantiated/shown (among other
potential issues not observed so far).

Present CL simplifies GtkUi initialization, moving it entirely to
ToolkitInitialized() override, which happens just after aura::Env's
initialization (which actually init OzonePlatform global object) and
before initializing Views framework, so that code previously in
PreCreateThreads() could be moved and unified under in a single method.

As follow-up, crrev.com/c/1863940 fixes the remaining issues that were
preventing file dialogs to work in Ozone X11.

** Actually current Ozone X11 calls it always, but that must be changed
soon to do so only in some cases. E.g: in-process-gpu, single-process,
etc. Issue tracked under https://crbug.com/1024477.

[1] https://www.x.org/releases/X11R7.5/doc/man/man3/XInitThreads.3.html

Bug: 1008755
Change-Id: Idc81e94dc236257bd7693bfe13833239bbb0fa87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899796
Commit-Queue: Nick Yamane <nickdiego@igalia.com>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Michael Spang <spang@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716908}

Bug: 635619
Change-Id: I6f7b1e16098a773aab2ac395b3b23e8b2af2b99e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920200Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716907}

The colored text is not breaking text runs. This is required to support
correctly the arabic script.

The characters are combining together to form a word. They are grouped
together by ligatures. Applying a color to a part of a word should not
break the ligature.

This CL is adding a unittest to ensure this behavior is working.

Bug: 1025561
Change-Id: I71211cb90fe6064a6d3be5a7de37e071675763fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923109
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716906}

Before this patch, setting more than one value in the set form field
value action proto could cause a hard crash of Chrome.

The existing code would run multiple "set value" runs at the same time,
causing them to interfere and eventually crash the process.

This patch adds a unit test that reproduced said crash and a fix for the
underlying issue.

R=arbesser@google.com

Bug: b/144152314
Change-Id: Icefa6f25cac56c034a296d1298a99a071bb9248d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924518Reviewed-by: Clemens Arbesser <arbesser@google.com>
Commit-Queue: Mathias Carlen <mcarlen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716905}

Previously NDEFReader#scan() returns void and an NDEFErrorEvent will be
dispatched in case that the scan operation cannot be started
successfully.

This is not a well accepted pattern, and also to align with
NDEFWriter#push(), this CL makes NDEFReader#scan() return a Promise
instead.

Note that now NDEFErrorEvent is only used to notify Mojo disconnection,
a follow-up CL will remove it completely by using ErrorEvent instead.

The spec change:
https://github.com/w3c/web-nfc/pull/398
https://github.com/w3c/web-nfc/pull/432

BUG=520391

Change-Id: I1477258ab70f7e40da31ea8795d63125b6a13af0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899586
Commit-Queue: Leon Han <leon.han@intel.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716904}

This reverts commit 19c93a8b.

Reason for revert: crrev.com/c/1913588 should have resolved the original flaky problem.

Original change's description:
> Disable flaky NFC web platform test
> 
> Bug: 1019663
> TBR: fbeaufort@chromium.org
> Change-Id: If58fd2c071cab7e77db76c96b78d6a25c46a7ccd
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890532
> Reviewed-by: anthonyvd <anthonyvd@chromium.org>
> Commit-Queue: anthonyvd <anthonyvd@chromium.org>
> Auto-Submit: anthonyvd <anthonyvd@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#710781}

TBR=anthonyvd@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1019663
Change-Id: I6f679cc86502a5a2b69e07fec751881e1fff8a47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925492Reviewed-by: Leon Han <leon.han@intel.com>
Commit-Queue: Leon Han <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#716903}

They are handled the same as the integral type ones.

R=haraken@chromium.org

Bug: chromium:1008840
Change-Id: I7d6ee4bd3939e8458f7a10b6697f1204c911345a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924515
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716902}

Missed giving ime/OWNERS access to input_ime.json.

Updated to include that file.

crrev/c/1918783

Change-Id: I2b09e1d3149e140f0c1c3fdf53e54e89975e3fd3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923221Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Keith Lee <keithlee@chromium.org>
Commit-Queue: Keith Lee <keithlee@chromium.org>
Auto-Submit: Keith Lee <keithlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716901}

This reverts commit 00f512ce.

Reason for revert: <INSERT REASONING HERE>
Speculative fix for crbug.com/1026473
Tests are unable to find any message strings.
Bug: 1026473
Original change's description:
> Support compressed .json grit files and compress chromevox messages
>
> This provides support for --gzip-output in grit/build.py, which:
> 1. Compresses individual output files.
> 2. Appends .gz to the compressed output files
>    (e.g. messages.json -> messages.json.gz).
>
> This makes it fairly simple to convert an extension (e.g. chromevox)
> to use compressed l10n files. Other than setting gzip_output = true
> in the .gn file, the only other required change is updating any
> test dependencies.
>
> Bug: 1023568
> Change-Id: I8318b1d87b828b512f890c6f2cf6d4d22462ed7d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913610
> Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
> Reviewed-by: David Tseng <dtseng@chromium.org>
> Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#716284}

TBR=stevenjb@chromium.org,dtseng@chromium.org,agrieve@chromium.org

NOTRY=true

Bug: 1023568
Change-Id: I4b506ef6d574a1e300383359aa2fbdc81b332252
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925888Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716900}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I5991b6c4ac8472c83f8ade8e66bfeed57a789072
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924276Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#716899}

UI Automation APIs ExpandToEnclosingUnit() and Move() for TextUnit
Paragraph is giving wrong output for PDF. It is not able to
correctly identify paragraph boundary because kIsLineBreakingObject
attribute is not set for Paragraph nodes in PDF. The fix is to set
kIsLineBreakingObject as true for Paragraph nodes.

Bug: 1025170
Change-Id: Ife69fc0646f1709d21c7a9fcc392524912a1988d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921929Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Commit-Queue: Mansi Awasthi <maawas@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#716898}

Previously, chromiumos_builder() ignored the **kwargs argument.

This was a problem in http://crrev.com/c/1923225, when the goma_backend
arg was not being passed to builder(). This resulted in some builders
not actually getting the arg to use Goma RBE backend:
- linux-chromeos-dbg
- linux-chromeos-rel

With this CL, these builders will get the correct goma_backend setting,
and start building using the Goma RBE backend.

Bug: 950413
Change-Id: Ie389646206ec96e39f1ad436db341ef213b539c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924182
Commit-Queue: Simon Que <sque@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716897}

Adding myself to owner of fonts and render-text.

Change-Id: Ie4dabac0423821487055bf2ab79abc5f7c8f8c3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924550Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716896}

Extension::VersionString(), Extension::DifferentialFingerprint(), and
Extension::GetVersionForDisplay() returned a `const std::string`;
there's no reason to do this, since it's a new string (and not a
reference to a member). Additionally, this could potentially result in
invocations of these methods creating a copy, if the caller did
something like:

std::string version_string = extension.VersionString();

Since the result would be a `const std::string`, a copy might be made to
fit into the non-const std::string required by the caller. Hopefully,
the compiler is smart enough to optimize this out, but it's better to
just un-const the result altogether.

Bug: None
Change-Id: Ic586e8e7f907431ddf5ee3efb7b111b9704c4144
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919731Reviewed-by: Kelvin Jiang <kelvinjiang@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716895}

Continuing along with the attempt to rebalance test suites, up to
the 75th percentile, telemetry_perf_unittests still has nearly 3x
to 4x more overhead than chrome_public_test_apk and
content_browsertests. It also runs a lot faster. Looking at the numbers
in https://bugs.chromium.org/p/chromium/issues/detail?id=1021686#c12
and fudging it a little, we can reduce 3 shards of
telemetry_perf_unittest to slow down runs by about 23% without
making it into the long pole. We might be able to pull it down further
but variance in data makes it hard to fully reason about this.

These extra 3 shards can translate to 6-12 more shards of
chrome_public_test_apk of content_browsertests depending which
percentile you look at.

Making a guess, this will let us pick up 5 more content_browsertest
shards (this has lower overhead) and 3 more chrome_public_test_apks
shards.

Bug: 1021686
Change-Id: I7acf9db5d9ee2b2b33b366da0702b1658444d4f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922975
Auto-Submit: Albert J. Wong <ajwong@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716894}

Run clang-format on the JS files in:
chrome/browser/resources/bookmarks
chrome/test/data/webui/bookmarks

and remove extra indentation from HTML files in
chrome/browser/resources/bookmarks.

Bug: 1022213
Change-Id: I574e1c768247dbf5b437d5db9cf31bfe3f4cc738
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922593
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716893}

Bug: 1009686
Change-Id: I63a4ff8b18ff7c7ec53586d10441b9e53cdb136c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925241
Auto-Submit: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Christopher Thompson <cthomp@chromium.org>
Commit-Queue: Christopher Thompson <cthomp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716892}

The type-specific typed-array files like int16-array.h were unnecessary
and did not add functionality. I replaced them now with a templated
version of the original base class.

R=haraken@chromium.org

Bug: chromium:1008840
Change-Id: I04b2c392af8737162b4251249d7af6ff50eee7bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919354Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716891}

Previously, we only store phished saved password bit
in compomised_credentials only when it's reused on a
phishing site. However, when a saved password is reused
on a low reputation site, it should also be persisted.

Bug: 1026006
Change-Id: Ie4dd0431690a1e91521e493225375ae4221f167f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922948
Commit-Queue: Bettina Dea <bdea@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716890}

Switches the win10_intel_hd_630_experimental mixin back to triggering
tests on the stable driver version, as the experimental version has some
issues that will prevent us from promoting it to stable.

TBR=ynovikov@chromium.org

Bug: 1016459
Change-Id: I32ca010c0a90b893eb69b8c9a1f624b4f6de2827
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925422Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716889}