GitLab

Bug: 900941, 902904
Change-Id: I1b374fe1efd9c0612fc6f42a84eefd8bc3b1e320
Reviewed-on: https://chromium-review.googlesource.com/c/1370189
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: Jonathan Backer <backer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616083}

This fixes the GCC build after eebbd7f6 ("Introduce
base::trace_event::TraceArguments helper class"):

    ../../base/trace_event/trace_event_impl.cc:61:1: error: function ‘base::trace_event::TraceEvent::TraceEvent(base::trace_event::TraceEvent&&)’ defaulted on its redeclaration with an exception-specification that differs from the implicit exception-specification ‘’
     TraceEvent::TraceEvent(TraceEvent&& other) noexcept = default;
     ^~~~~~~~~~
    ../../base/trace_event/trace_event_impl.cc:62:13: error: function ‘base::trace_event::TraceEvent& base::trace_event::TraceEvent::operator=(base::trace_event::TraceEvent&&)’ defaulted on its redeclaration with an exception-specification that differs from the implicit exception-specification ‘’
     TraceEvent& TraceEvent::operator=(TraceEvent&& other) noexcept = default;
                 ^~~~~~~~~~

With GCC, having that noexcept marker requires all members to be marked
with noexcept themselves, and StringStorage was missing it.

clang is fine because we pass -fno-exceptions and it disables the same error
there, while GCC continues to raise it (bug 843143 and its corresponding CL
have a longer discussion on this issue).

Bug: 819294
Change-Id: Ie2eba30dcb6d4a5f9cc1b4b7c961af96d9f55f10
Reviewed-on: https://chromium-review.googlesource.com/c/1374230Reviewed-by: David Turner <digit@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#616082}

Change-Id: I26447006b81184d805527dc3c41bffd1ccf72a59
Bug: 850624
Reviewed-on: https://chromium-review.googlesource.com/c/1374518
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616081}

This animation was removed unintentionally, this CL brings it back.
Also added better comments so the animation's importance is more
obvious.

Bug: 910496
Change-Id: If505bea1683d7ae456dcedbdb0a9e97ea58e02de
Reviewed-on: https://chromium-review.googlesource.com/c/1368604Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Reviewed-by: Mitsuru Oshima (gardener - slow) <oshima@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616080}

For ChromeOS with single-process-mash. I ran this test 100 times and saw
no flake.

BUG=905789
TEST=test only change
TBR=msw@chromium.org

Change-Id: I9fa491da4a20bfdbca8385295b1a9c20359df8f4
Reviewed-on: https://chromium-review.googlesource.com/c/1374693Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616079}

Bug: 914479
Change-Id: I874361216d1ae45fe0b0a7ef51d730ef895649b9
Reviewed-on: https://chromium-review.googlesource.com/c/1374519Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616078}

This reverts commit b8d90223.

Reason for revert: crbug.com/914246, crbug.com/912739

Original change's description:
> Reland "Enable Crashpad for Android"
>
> This is a reland of 66b2e0f1
>
> Original change's description:
> > Enable Crashpad for Android
> >
> > Overview:
> > This CL disables Breakpad for Chrome, Content Shell, WebView, and
> > Chromecast on Android and replaces it with Crashpad. When a crash
> > signal is received, the browser forks+execs a Crashpad handler process
> > either for itself or on behalf of a crashing child to create a crash
> > dump.
> >
> > components/crash/
> >   - Remove CrashDumpManager. Minidump creation is handled entirely by
> >     Crashpad.
> >   - Remove OnChildStart from ChildExitObserver as it is no longer
> >     necessary.
> >   - ChildExitObserver observers CrashHandlerHost to be notified when
> >     child processes receive crash signals.
> >   - De-duplicate calls to ChildExitObserver::Client::OnChildExit when
> >     NOTIFICATION_RENDER_PROCESS_{CLOSED, TERMINATED} are both sent.
> >
> > components/minidump_uploader/
> >   - Uploaders expect crash reports to already be MIME encoded since
> >     Breakpad was doing that in a signal handler call-back.
> >     CrashFileManager now automatically calls into native code to do
> >     the encoding and write to a directory of crash reports whenever it
> >     checks for reports without logcats.
> >
> > chrome/app/*.{cc,h}
> > chrome/browser/*.cc
> > content/shell/app/*.{cc,h}
> > content/shell/browser/*.cc
> >   - Initialize Crashpad instead of Breakpad, with minor cleanup and
> >     adjustment for changes to CrashDumpObserver.
> >
> > chrome/browser/metrics/oom/out_of_memory_reporter_unittest.cc
> >   - Simulate crashes/exits with NOTIFICATION_RENDER_PROCESS_{CREATED,
> >     CLOSED} and signals sent to ChildExitObserver instead of a crash
> >     dump.
> >
> > android_webview/
> >   - AwBrowserTerminator now observes child process crashes via
> >     ChildExitObserver rather than its own pipe.
> >   - Crashpad always produces minidumps, and not microdumps.
> >   - Disabling Crashpad is not yet supported.
> >
> > chromecast/
> >   - There are now two directories that crash report uploaders should
> >     be aware of: "Crashpad" contains a database of raw minidumps
> >     produced by Crashpad, and "Crash Reports" contains MIME encoded
> >     minidumps. MIME encoding is performed by a CrashReportMimeWriter
> >     in CastCrashUploader.java:checkForCrashDumps().
> >
> > Bug: crashpad:30
> > Cq-Include-Trybots: master.tryserver.chromium.android:android_compile_x64_dbg;master.tryserver.chromium.android:android_compile_x86_dbg
> > Change-Id: I0efa451585f60287853c47f860f09ced581c8958
> > Reviewed-on: https://chromium-review.googlesource.com/c/989401
> > Commit-Queue: Joshua Peraza <jperaza@chromium.org>
> > Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
> > Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> > Reviewed-by: Peter Wen <wnwen@chromium.org>
> > Reviewed-by: Luke Halliwell <halliwell@chromium.org>
> > Reviewed-by: Simeon Anfinrud <sanfin@chromium.org>
> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
> > Reviewed-by: Mark Mentovai <mark@chromium.org>
> > Reviewed-by: Peter Beverloo <peter@chromium.org>
> > Reviewed-by: Ilya Sherman <isherman@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#612987}
>
> TBR=tobiasjs@chromium.org,jam@chromium.org,wnwen@chromium.org,halliwell@chromium.org,sanfin@chromium.org,yfriedman@chromium.org,peter@chromium.org,isherman@chromium.org
>
> Bug: crashpad:30
> Change-Id: Ia1654bc4fbe59005513f30364753309ae232052d
> Cq-Include-Trybots: master.tryserver.chromium.android:android_compile_x64_dbg;master.tryserver.chromium.android:android_compile_x86_dbg
> Reviewed-on: https://chromium-review.googlesource.com/c/1357941
> Commit-Queue: Joshua Peraza <jperaza@chromium.org>
> Reviewed-by: Mark Mentovai <mark@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#613333}

TBR=yfriedman@chromium.org,peter@chromium.org,isherman@chromium.org,jam@chromium.org,wnwen@chromium.org,torne@chromium.org,halliwell@chromium.org,tobiasjs@chromium.org,rsesek@chromium.org,sanfin@chromium.org,jperaza@chromium.org,mark@chromium.org

Change-Id: I7c539a6f48bb22c55031c1a344b16e07ba9bb660
Bug: crashpad:30
Cq-Include-Trybots: master.tryserver.chromium.android:android_compile_x64_dbg;master.tryserver.chromium.android:android_compile_x86_dbg
Reviewed-on: https://chromium-review.googlesource.com/c/1361286
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616077}

Notifications for displaying data promotions are no longer supported.

Class is now in charge of displaying mobile data warnings and prompts
user to install data saver extension.

BUG=910767

Change-Id: I74c45001158194788fb335be83e040b95e3271be
Reviewed-on: https://chromium-review.googlesource.com/c/1362211
Commit-Queue: Tony De Luna <tonydeluna@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616076}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/3338f216..da1d51ff

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: If0afa97e6f35a64409c6d6310c9180d5f6467e10
Reviewed-on: https://chromium-review.googlesource.com/c/1374455Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616075}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/572100bbdaa1..6f13ebdc542b


git log 572100bbdaa1..6f13ebdc542b --date=short --no-merges --format='%ad %ae %s'
2018-12-12 xixuan@google.com chromeos_config: Mark nyan_blaze-release back to important.


Created with:
  gclient setdep -r src/third_party/chromite@6f13ebdc542b

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I402d7b29853f53b68636daaea9d4a95a2de2c670
Reviewed-on: https://chromium-review.googlesource.com/c/1374141Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616074}

https://chromium.googlesource.com/angle/angle.git/+log/64f62f4a179f..b08457df2325


git log 64f62f4a179f..b08457df2325 --date=short --no-merges --format='%ad %ae %s'
2018-12-12 syoussefi@chromium.org Vulkan: Make flushAfterVertexConversion workaround Nexus5X-specific


Created with:
  gclient setdep -r src/third_party/angle@b08457df2325

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jmadill@chromium.org

Change-Id: I4b41a0ddaef3f92321ceda5f26db89e7c155aa03
Reviewed-on: https://chromium-review.googlesource.com/c/1374529Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616073}

Introduces the concept of pending client initializations so that we
don't fail in odd ways if multiple initializations are in flight.

Also fixes some of the initialization PostTasks to ensure we're always
dereferencing our WeakPtrs on the same task runnerand ensuring that we
actually post our callbacks on the calling task runner.

Removes the WeakPtrFactory from ProtoLevelDBWrapper as well, which
involves a substantial refactoring to get DB init status back. A new
InitStatusCallback has been created so the 2 param Init and
InitWithDatabase calls give me an InitStatus. IsCorrupt was removed,
since setting the corruption state was the only thing that required
using a WeakPtr in the first place. This gives us the freedom to make
calls to the wrapper from any sequence regardless of what it was
created on, and not have the WeakPtrFactory cause problems when it's
destructed.

Bug: 912117,870813
Change-Id: Ic7931a543b4d3d09714184dfb335311130bc7667
Reviewed-on: https://chromium-review.googlesource.com/c/1364074
Commit-Queue: Troy Hildebrandt <thildebr@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616072}

This CL makes TouchEventAckQueue responsible for calling
ProcessAckedTouchEvents() on the root view. Several main changes:

1) The TEAQ now stores the full TouchEvent, not just the event's
touch ID. This is required by ProcessAckedTouchEvents().

2) With the assumed invariant that now all touch events are
acked, and in-order, we don't need to explicitly mark emulated
touch events as such, since we can use the TouchEmulator to keep
track for us.

3) The TEAQ now holds a pointer to its owning RWHIER, since it
needs access to both (i) the TouchEmulator, and (ii) the function
IsViewInMap(). The latter means having to make IsViewInMap() a
public function on RWHIER.

Bug: 848050
Change-Id: I822424ff1d04b8ba0c67a88956b1517c38a877ec
Reviewed-on: https://chromium-review.googlesource.com/c/1355243
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616071}

This patch
 * extracts ScopeLockRange and ScopeLock classes into separate files,
 * implements a multi-level lock acquisition algorithm to acquire a
   collection of locks together
 * clarifies the invariants of DisjointRangeLockManager

Bug: 862456
Change-Id: I2702237dfa7e5213e7cd395d3c8fcfeeaf86898e
Reviewed-on: https://chromium-review.googlesource.com/c/1258218
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Chase Phillips <cmp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616070}

Bug: 913973
Change-Id: I3081b3392135774f54745c7da60089328e64393b
Reviewed-on: https://chromium-review.googlesource.com/c/1371929
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616069}

This reverts commit 6205ad09.

Reason for revert: Not needed now that https://chromium-review.googlesource.com/c/1371244 landed.

Original change's description:
> [Feed] Stop obfuscation of FeedRefreshTask class name.
> 
> Bug: 913696
> Change-Id: I29fe62f4022c464330385c9e6e4d3253f2f3273c
> Reviewed-on: https://chromium-review.googlesource.com/c/1370555
> Reviewed-by: Filip Gorski <fgorski@chromium.org>
> Commit-Queue: Sky Malice <skym@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#615356}

TBR=fgorski@chromium.org,skym@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 913696
Change-Id: I99720fe10cc3f292e44e0da72387585f685326bd
Reviewed-on: https://chromium-review.googlesource.com/c/1374451Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616068}

srt_chrome_prompt_impl.cc is code that is only used in Windows
but was compiled for all operating systems. Since it uses constants
that only exist in Windows it's kind of lucky that it doesn't
cause any problems, except in some jumbo build experiments where
there was linker errors.

(TBR for name change in BUILD.gn)
TBR=nparker@chromium.org

Bug: 904958
Change-Id: If1e3f76c7bc913d4041d0cb38b4891d898d24506
Reviewed-on: https://chromium-review.googlesource.com/c/1350870Reviewed-by: Daniel Bratell <bratell@opera.com>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Joe Mason <joenotcharles@google.com>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#616067}

https://dawn.googlesource.com/dawn.git/+log/b59d04f79ee3..8d08d23a6642


git log b59d04f79ee3..8d08d23a6642 --date=short --no-merges --format='%ad %ae %s'
2018-12-12 cwallez@chromium.org README.md: Add a link to the mailing list.


Created with:
  gclient setdep -r src/third_party/dawn@8d08d23a6642

The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=cwallez@chromium.org

Change-Id: I7f8d4b75e4de7f62a8fd59b8250da8eda40d8d86
Reviewed-on: https://chromium-review.googlesource.com/c/1374530Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616066}

ios-wpr-simulator is currently timing out due to a lack of filtering.
Each site tested by autofill automation is reported as its own suite,
i.e.
ios_costco.test.AutofillAutomationTestCase/testActions
ios_ebay.test.AutofillAutomationTestCase/testActions
ios_westelm.test.AutofillAutomationTestCase/testActions
And the test_runner will automatically rerun any suite that fails,
filtering for just that suite.

However, filters were not implemented for WprProxySimulatorTestRunner,
meaning that if ios_ebay failed, every site would be retested,
resulting in an polynomial amount of test rerunning and a time out.

This change implements filtering properly as well as tests for
filtering, which should reduce the bot runtime to a reasonable level.

Change-Id: Ib614a5902be3ffd9d41720173bdf51d140705f83
Reviewed-on: https://chromium-review.googlesource.com/c/1374453Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Commit-Queue: ericale <ericale@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616065}

Rather than including a fake alert object within the client accessibility tree, make the views tree include it with an explicit aura::Window.

TBR=servolk@chromium.org

Bug: 888152
Change-Id: I9e190a8e437a78c7e27ebfaab70ec20980dff32d
Reviewed-on: https://chromium-review.googlesource.com/c/1368828
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616064}

Android's MediaCodec API uses various low level video decoder API. On
Nexus5 tablet on Android Kitkat, the MediaCodec may not generate valid
result and doesn't have any response.

This CL adds a timeout to mitigate this issue.

Bug: 907577
Change-Id: If616cae1e784fbbadd07752f5ff898662be1875e
Reviewed-on: https://chromium-review.googlesource.com/c/1368279
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616063}

This patch implements snapping after pressing PgUp/PgDn and Home/End
keys. The logic is implemented in ScrollManager::LogicalScroll().
These keys are different from arrow keys. Pressing the arrow key is
considered as scrolling with intended direction only. Pressing the
PgUp/PgDn is considered as scrolling with intended direction and end
position. Pressing the Home/End key is considered as scrolling with
intended end position only. So we need to use different strategies to
snap for these keys.

Bug: 821928
Change-Id: If4d04ff58214a3304d09838f321e65c6e68f7d1d
Reviewed-on: https://chromium-review.googlesource.com/c/1361648Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616062}

This CL tracks SystemWebDialogDelegate instances so that derived
classes can check for an existing instance and focus that instead
of opening a new instance.

Bug: 855344
Change-Id: I688f2e09bd280a511d4ab53463beccfdd10f5371
Reviewed-on: https://chromium-review.googlesource.com/c/1366793Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616061}

And also to manage c/b/ui/webui/policy*

Change-Id: I1e54608ea4fafe5efc1d1ec6a7b2719cabaaeeec
Reviewed-on: https://chromium-review.googlesource.com/c/1373787Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: A Olsen <olsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616060}

https://pdfium.googlesource.com/pdfium.git/+log/88f396963bc7..e79ad68b2984


git log 88f396963bc7..e79ad68b2984 --date=short --no-merges --format='%ad %ae %s'
2018-12-12 tsepez@chromium.org Combine ElementTable, parent array, and names.
2018-12-12 tsepez@chromium.org Remove ELEM_HIDDEN____() macro.


Created with:
  gclient setdep -r src/third_party/pdfium@e79ad68b2984

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Ib680cdb5bfdaece2878ecb507093a5ca458baf46
Reviewed-on: https://chromium-review.googlesource.com/c/1374048Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616059}

When https://chromium-review.googlesource.com/c/chromium/src/+/1347784
landed we changed non-BGPT to also use all animation reasons as
compositing reasons for each of transform, filter and opacity but this
is only needed for BGPT.

The additional time to compute animation compositing reasons caused a
regression of about 7.5% on thread_total_all_cpu_time_per_frame which
should be resolved with this change. A followup will be landed to fix
it for BGPT.

Bug: 909054
Change-Id: I7d7a23e758bdb3fcb93ab1ca265d53b658d8218f
Reviewed-on: https://chromium-review.googlesource.com/c/1374055
Commit-Queue: Robert Flack <flackr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616058}

A recent Skia roll made changes to rectangle anti-aliasing. Rebaselining
per Skia owners recommendation. Will reenable test in followup CL.

TBR=kbr@chromium.org

Bug: 914206
Change-Id: I22d1982b6a73c79a3f198370c2f25b47e11ed2bc
Reviewed-on: https://chromium-review.googlesource.com/c/1374512
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616057}

This is part of the ongoing effort to clean up the directory structure
of multi-device code. The files moved are only relevant to the
DeviceSync service, so they belong within the service implementation.

See go/multidevice-directory-structure-cleanup for details.

Bug: 912743
Change-Id: Icce398a4aa93110fbd790c364bba29bf461a83e4
Reviewed-on: https://chromium-review.googlesource.com/c/1372648Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616056}

Bug: 906201
Change-Id: I3a75ee136390ce0f3d5ff0840cbb8eee005d5bd9
Reviewed-on: https://chromium-review.googlesource.com/c/1372716
Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616055}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d80da25f9a45..17b5749fc223


Created with:
  gclient setdep -r src-internal@17b5749fc223

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Ie06d8b6a54bf07369190a2c19559380d9b9c8cdf
Reviewed-on: https://chromium-review.googlesource.com/c/1374142Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616054}

Using wpt-import in Chromium 59d0480b.
With Chromium commits locally applied on WPT:
a7cca762 "Revert "Fix SVG-As-Background sizing""
6e2a70e4 "Reland "Fix SVG-As-Background sizing""
8bb5e943 "Add WPT to verify that 1XX responses are used to provide responseStart timing"
618e62b5 "Align resource timing buffer full processing to spec PR 168 (take 3)"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=markdittmer

No-Export: true
Change-Id: Ib40c87b63f698b075708070a7c00e8195c6780e1
Reviewed-on: https://chromium-review.googlesource.com/c/1373879Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616053}

Previuously net-test-server-config was written to /data/shared,
which is then mapped to /test-shared in the test launcher. The problem
was that this approach breaks when test launcher is not used (i.e. with
--single-process-tests flag). Updated runner scripts to copy the file to
/tmp. This approach is more consistent with other platforms and doesn't
require any special logic in the test launcher.

Change-Id: I5377eda57a0524b02e7ce419a5930ff16087a2e6
Reviewed-on: https://chromium-review.googlesource.com/c/1374456Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616052}

This metric measures completion rate of background downloads
when started through DownloadBroadcastManager.

The events are:
- Started
- Completed
- Cancelled
- Failed

A trend of process killed rate can be inferred from the formula:
1 - ((Completed + Cancel + Failed) / Started)

Bug: 864625
Change-Id: If9fc28f25a72a9010055b995f8ab53b11c1b2563
Reviewed-on: https://chromium-review.googlesource.com/c/1363679Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616051}

This CL creates a story which consists of a JS animation in which a
group of red squares rotates in the background while three
semi-transparent foregrounds move on top (with some rotation,
translation, and resizing going on). The foregrounds apply a blur
filter.

The motivation is that in Chrome OS, we were having problems with the
launcher animation having a low frame rate. As the launcher is swiped
upwards, it applies a blur on the background. dcastagna@ landed a fix to
improve this significantly (see https://crbug.com/900046). The code used
by the launcher to do the blurring is not unique to Chrome OS, so the
new story should be able to measure regressions in that animation.

For due credit: the story is based on tbuckley@'s example which
reproduced the issue on the web (see
https://codepen.io/anon/pen/MPXYMQ).

Chromebook after reverting bf7c3813 (dcastagna@'s fix) from 96c5b055.

Test: percentage_smooth goes from 90.805% to 36.158% on an eve
Bug: 682082
Change-Id: Ifc4a725a2ba430e7698fccde703d2de4a12db687
Reviewed-on: https://chromium-review.googlesource.com/c/1324240
Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org>
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Reviewed-by: Victor Miura <vmiura@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616050}

@IntDef annotations are preferred way for declaring set of int values:

1. they need less space in APK than enum, see
https://developer.android.com/topic/performance/reduce-apk-size#remove-enums
2. they give more control over allowed values than "static final" values

Main goal of patch is writing InternalState enum in common @IntDef form:

1. with @IntDef first, @Retention second and related @interface third
2. with values inside @interface
3. with @Retention(RetentionPolicy.SOURCE)
4. without "static final" in the @interface

Change-Id: I8ca8f808060f31e60c07cfc9bcdc6f3b2a8dc8a4
Reviewed-on: https://chromium-review.googlesource.com/c/1135539Reviewed-by: Donn Denman <donnd@chromium.org>
Commit-Queue: Marcin Wiącek <marcin@mwiacek.com>
Cr-Commit-Position: refs/heads/master@{#616049}

The rebaseline diffs are a little trickier to follow because many specific
expectations have been moved into a more generic family, either from
Mac and Windows versions to just Mac/Windows generic, or all the way to
a platform independent expectation image.

Bug: 913948
Change-Id: Ifa1cfa5191587a0ece36c2ce06dc111db5f699fa
Reviewed-on: https://chromium-review.googlesource.com/c/1372221
Commit-Queue: Florin Malita <fmalita@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616048}

All information on this page is duplicate of information from other
sources.
The Flash plugin version and path can be found on chrome://version.
GPU information is present of chrome://gpu and crashes on chrome://crashes.

BUG=615739

Change-Id: Ic0dce75db63099715145a63cac82316494a87b12
Reviewed-on: https://chromium-review.googlesource.com/c/1373841Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616047}

The V2 sandbox is now default for all but the network and GPU processes
on macOS. This CL deletes the feature flag. A new experiment will be
introduced for the GPU process. The default case for the sandbox profile
switch is removed, because previous CHECK() failures were confusing to
diagnose. All profiles must now be handled explicitly, so Chrome won't
build if a new profile type isn't handled.

Bug: 749839
Tbr: asvitkine@chromium.org
Change-Id: I3924a27efcc34091258e9c6076d062c35abef186
Reviewed-on: https://chromium-review.googlesource.com/c/1371024
Commit-Queue: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616046}

HTMLMediaElementRemotePlayback (whith is HTMLMediaElement.remote) is
currently the supplement. Making RemotePlayback the supplement will
allow core/ to get the object and use it via an interface.

Bug: 913668
Change-Id: I8f2c1fb0039098d829d11b166191f6d4745eb96b
Reviewed-on: https://chromium-review.googlesource.com/c/1371215Reviewed-by: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616045}

Histograms which records if the user attempted to unlock and signin their
device via SL (tapped their user photo) or other auth method (e.g.,
password, PIN, or fingerprint tba).

Bug: 905438
Change-Id: I1cd840c67ad717102b4008be7e92aafcad5f95c6
Reviewed-on: https://chromium-review.googlesource.com/c/1355846
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616044}