- 29 Jan, 2020 40 commits
-
-
Dominique Fauteux-Chapleau authored
This reverts commit 5bd704b2. Reason for revert: The fix is applied in crrev.com/c/2024497 Original change's description: > Revert "Update Deep Scanning upload UI text" > > This reverts commit 75458c57. > > Reason for revert: to unblock reverting https://chromium-review.googlesource.com/c/chromium/src/+/2020891 (crbug.com/1046693) > > Original change's description: > > Update Deep Scanning upload UI text > > > > Add code to use the appropriate drag-data, drag-file and paste strings > > instead of just defaulting to the upload strings. Removes the optional > > part of the access point since it's used to determine the appropriate > > string now. > > > > Bug: 999145 > > Change-Id: I115cd567f94d9c4ca7a4befdff386ba76163ae20 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016965 > > Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> > > Reviewed-by: Daniel Rubery <drubery@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#735943} > > TBR=drubery@chromium.org,domfc@chromium.org > > Change-Id: I78b6b5c3c3fe10cdd731d84233d20c31cb1a9e00 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 999145,1046693 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027547 > Reviewed-by: vitaliii <vitaliii@chromium.org> > Commit-Queue: vitaliii <vitaliii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#736301} TBR=vitaliii@chromium.org,drubery@chromium.org,domfc@chromium.org Change-Id: I717f12ae775142aa6337d7aefc70c426b19d22f3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 999145, 1046693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026652Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#736428}
-
Dominique Fauteux-Chapleau authored
This reverts commit 86c4251e. Reason for revert: The fix is applied in crrev.com/c/2024497 Original change's description: > Revert "Cleanup base::Optional use in Deep Scanning dialog code" > > This reverts commit 0f668c37. > > Reason for revert: Fails Linux MSan Tests crbug.com/1046693. > > Original change's description: > > Cleanup base::Optional use in Deep Scanning dialog code > > > > 2 instances of optional can be removed from DeepScanningDialog* code to > > make it more readable: > > - The access point no longer needs to be optional since all the access > > points have been added to Chrome. A default value is still included > > in order to simplify tests calling ShowForWebContents. > > > > - The state variable in DeepScanningDialogViews is better as an enum > > than an optional bool indicanting pending/success/failure, especially > > since a timeout state is very likely in the future. > > > > Change-Id: I767db78e428a607a7cc2dfe39d1d63c0f85c30d7 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020891 > > Reviewed-by: Daniel Rubery <drubery@chromium.org> > > Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#735857} > > TBR=drubery@chromium.org,domfc@chromium.org > > Change-Id: Id4814d523935f867ab8fb69942281a6fc8fcf3b0 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1046693 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026970 > Reviewed-by: vitaliii <vitaliii@chromium.org> > Commit-Queue: vitaliii <vitaliii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#736302} TBR=vitaliii@chromium.org,drubery@chromium.org,domfc@chromium.org Change-Id: I9a094d5d1d3105dd5b5712b0c77e9b0d58788420 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1046693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026355Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bf682ef3..4bf20c76 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Idf1b205a19f5489f19349615979c7280c6545c0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027871Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736426}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/26b4cb3fc56c..99d6d8115b37 git log 26b4cb3fc56c..99d6d8115b37 --date=short --first-parent --format='%ad %ae %s' 2020-01-29 minyue@webrtc.org Adding absolute capture timestamp to AudioTrackSinkInterface. Created with: gclient setdep -r src/third_party/webrtc@99d6d8115b37 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I26bf20559350b612e50f5eeb3f6bcacec542dea5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028014Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736425}
-
Sebastien Marchand authored
The current convention is to not send notification when the system exit memory pressure, this isn't ideal as it doesn't let stateful listeners know that they should stop their intervention. This CL was uploaded by git cl split. R=vmiura@chromium.org Change-Id: I2c4a53b537d6bfa8391fadd8def543ba525558f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017047 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
Geoff Lang <geofflang@chromium.org> Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#736424}
-
David Tseng authored
This change is the result of several discussions related to lazy background pages in the context of web assembly and slow load times. This approach: - keeps alive tts engines while ChromeVox is enabled - specifically for Google text-to-speech engine only at this time - reverts back to event/lazy background page behavior when ChromeVox is disabled Bug: 1044209 Change-Id: Ic4e6e36e7a0405e2546c5a8ce48e59117041a59f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001108 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#736423}
-
Manuel Rego Casasnovas authored
In r727590 there was introduced a regression regarding visual overflow of inline elements in legacy layout. The problem is that inline elements in legacy layout don't recompute the visual overflow, so we still need to mark the element for layout in that case. The fix is basically bringing back the code in LayoutObject::SetStyle() to mark inline elements for layout, including an extra condition for doing it only for legacy layout objects. BUG=1043927 TEST=ParameterizedLayoutInlineTest.VisualOverflowRecalcLegacyLayout Change-Id: I4c5dff4c75c3a9484a52f51fbd85f2b65672de1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025389Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#736422}
-
Toni Barzic authored
When animating app list to closed state, use the current target shelf y coordinate at target animation bounds. Before this cl, app list was using ideal shelf bounds, so the animation ends at the visible shelf bounds, assuming that shelf will remain in visible state, which is the case when the app list is hidden by clicking home button, but may not always be true - for example, shelf gets hidden if app list is closed using esc key. BUG=1046198 Change-Id: Idb343482432fe9315082b45caff6679177c7d94f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027172Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#736421}
-
Julian Pastarmov authored
Fixing comments on the already submitted https://chromium-review.googlesource.com/c/chromium/src/+/1952324. BUG=none Change-Id: Ic8037c6e3d8b51944ba39d2782f78a9d068c9c20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027414 Auto-Submit: Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#736420}
-
Sebastien Marchand authored
Also add this to the slow report to get a better understanding of the pressure level when looking at a report. Change-Id: I73bc8804cb06f5c481b7f8bdc14c79bbcdd28d2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025951Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#736419}
-
Alison Maher authored
This change adds the default color and fill forced colors for SVG elements (WindowText). Before this change, SVG fill and color would default to black in forced colors mode, making certain elements un-readable. Bug: 970285 Change-Id: I68ecb4769a502fbb1c4ceb27ba0b3d21205aeb45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026147Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#736418}
-
Maks Orlovich authored
For ComputeSiteForCookies, we care about the parent when the frame was created (parent_) rather than the root of the current tree hierarchy in FrameTreeNode land, as if our parent is being navigated, the latter will get updated to the destination, which isn't relevant here. Bug: 1013733, 1032668 Change-Id: If78b77a082812b3feee8befde7cf537607938039 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023249 Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#736417}
-
Anqing Zhao authored
This policy is used for desktop browsers only when cloud reporting is enabled. Now, the mapping should be extended to CrOS since the similar functionality is supported on it. Bug: 1010213 Change-Id: I78c98edbc172d5fd2ad2e9d610a1adfdb5d5ca63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027336Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Anqing Zhao <anqing@google.com> Cr-Commit-Position: refs/heads/master@{#736416}
-
Chan Li authored
This reverts commit a54e29af. Reason for revert: This change breaks ash_unittests on Linux Chromium OS ASan LSan Tests (1) builder: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/36800 Findit analysis: https://findit-for-me.appspot.com/waterfall/failure?url=https://luci-milo.appspot.com/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(1)/36800 Original change's description: > Use timeout to wait until there is no presentation callback. > > R=yigu@chromium.org > > Bug: 1043465 > Test: run 100 times and no flaky > Change-Id: I64aef46f8f61a5bde32d678a91301f9ea9304b74 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026508 > Reviewed-by: Jun Mukai <mukai@chromium.org> > Commit-Queue: Mitsuru Oshima (slow in TOK) <oshima@chromium.org> > Cr-Commit-Position: refs/heads/master@{#736206} TBR=mukai@chromium.org,oshima@chromium.org,yigu@chromium.org Change-Id: I5294b8fcb958f02af01ab1e8bfb00358bf3b36e1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1043465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027897Reviewed-by:
Chan Li <chanli@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#736415}
-
Denis Kuznetsov authored
Bug: 955194 Change-Id: I1f08087a0ce9675c43a6879ed14c53790c8f06b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025548Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#736414}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/45c948791441..d960cc31b658 git log 45c948791441..d960cc31b658 --date=short --first-parent --format='%ad %ae %s' 2020-01-29 fmalita@chromium.org [skottie] Cleanup: remove unused header 2020-01-29 robertphillips@google.com Update wacky_yuv_formats GM to demonstrate YUV resizing on the GPU Created with: gclient setdep -r src/third_party/skia@d960cc31b658 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: reed@google.com Change-Id: If35ed000890178ec5609ce393c81d060cb1f4da1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028008Reviewed-by:
-
Mohamed Heikal authored
This reverts commit 9876c905. Reason for revert: breaks official builders crbug.com/1046654 Original change's description: > [android] do not filter locales in resource packing > > This CL makes it so that all locales are used during resource_packaging > > It looks like previously resource_packaging was only called for apk > builds. But now that it is also used for bundle builds the locales > for Android bundles should be included as well. > > Before this change all language splits for the 27 + 9 new languages > recently added to Clank were about half the size as older languages in > monochrome_public_bundle.apks > > After this change the new languages and old languages are about the same > size in monochrome_public_bundle.apks. > > Example Before (af,as, az, be, bn, and bs are new languages): > > 158921 2001-01-01 00:00 splits/base-af.apk > 424765 2001-01-01 00:00 splits/base-am.apk > 432527 2001-01-01 00:00 splits/base-ar.apk > 226815 2001-01-01 00:00 splits/base-as.apk > 165763 2001-01-01 00:00 splits/base-az.apk > 203683 2001-01-01 00:00 splits/base-be.apk > 473236 2001-01-01 00:00 splits/base-bg.apk > 234710 2001-01-01 00:00 splits/base-bn.apk > 163986 2001-01-01 00:00 splits/base-bs.apk > > Example After: > > 305787 2001-01-01 00:00 splits/base-af.apk > 424765 2001-01-01 00:00 splits/base-am.apk > 432527 2001-01-01 00:00 splits/base-ar.apk > 569512 2001-01-01 00:00 splits/base-as.apk > 325961 2001-01-01 00:00 splits/base-az.apk > 468522 2001-01-01 00:00 splits/base-be.apk > 473236 2001-01-01 00:00 splits/base-bg.apk > 577862 2001-01-01 00:00 splits/base-bn.apk > 324504 2001-01-01 00:00 splits/base-bs.apk > > > > Bug: 1035665 > Change-Id: I31d3bddba38148931212e6bccb63155376b82bda > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024159 > Reviewed-by: Megan Jablonski <megjablon@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Trevor Perrier <perrier@chromium.org> > Cr-Commit-Position: refs/heads/master@{#736004} TBR=agrieve@chromium.org,megjablon@chromium.org,perrier@chromium.org Change-Id: I893b0c956826db5bf20dffa580ce8ba77181dfff No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1035665, 1046654 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028112Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#736412}
-
Patrick Monette authored
The WorkerWatcher observes dedicated workers through the DedicatedWorkerService interface. Change-Id: If62d911e500def7ebb905311485a8d89eeaca8df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992208Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#736411}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/9769628aa1d8..76a9d840b0f0 git log 9769628aa1d8..76a9d840b0f0 --date=short --first-parent --format='%ad %ae %s' 2020-01-29 yigu@chromium.org Disable ActualPageRunEndToEndTests.testTrafficSettings on Linux and Mac Created with: gclient setdep -r src/third_party/catapult@76a9d840b0f0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1042080 Tbr: skyostil@google.com Change-Id: I920f85ad52630ba872814591b680a9c954f206b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028010Reviewed-by:
-
Allen Bauer authored
Bug: 1042718 Change-Id: I20f3c3b31235b6c10958122ba4d10e9b4696db2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024926Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#736409}
-
Henrique Nakashima authored
The map contains the equivalence between a feature flag from ChromeFeatureList and the constant in ChromePreferenceKeys with the SharedPrefs key that caches that flag. Use the equivalence to replace: - #cacheFlag() with #cacheFeature() and inline - #isFlagEnabled() with #isEnabled() - #sFlags.put() with #setForTesting() This way, the features are references by the ChromeFeatureList constant rather than by its SharedPrefs key, which is an implementation detail. Note there are tons of special cases in FeatureUtilities. This CL addresses only the regular cases. The special cases will be handled in future CLs. Bug: 1012975 Change-Id: I0e02a52cbb841b551cf5920a13cb007c8aacecd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023199Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#736408}
-
Wez authored
This reverts commit 6ec27fc3. Reason for revert: Remove unused keymapping arguments. Original change's description: > Add plumbing for keymap > > > Change-Id: I5b68fd4345e9331c7de5f6947a4cc17cf5d5992a > Bug: 920824 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495594 > Reviewed-by: Gary Kacmarcik <garykac@chromium.org> > Reviewed-by: Greg Kerr <kerrnel@chromium.org> > Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#640047} # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 920824, 1045960 Change-Id: I302d95c9d0dcd6fab7d4f123ecdb4ca7d49ae3e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022710Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#736407}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ab04f241b080..717f1ef10178 git log ab04f241b080..717f1ef10178 --date=short --first-parent --format='%ad %ae %s' 2020-01-29 liviurau@chromium.org [build] Add build override argument Created with: gclient setdep -r src/third_party/devtools-frontend/src@717f1ef10178 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1046668 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4797d0c0b573046c58492150779e1bdb42b3a78d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028009Reviewed-by:
-
John Chen authored
Rebaseline wpt directory. TBR=wangxianzhu@chromium.org Bug: 1028242 Change-Id: If7ea039ab552b6ac25cc33b515300b0c9b344180 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026376Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#736405}
-
Elly Fong-Jones authored
This change migrates all of //cbuiv/autofill/payments to the "new" dialog closure methods - instead of overriding Accept/Cancel/Close, they now register callbacks and rely on the new default behavior of Close. Bug: 1011446 Change-Id: I7ca87f9ab7091368e0d077232bb7156ceff5845d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025993 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#736404}
-
Roger Tawa authored
Bug: 1045491 Change-Id: I369f302f95aa7177a54188851897b92de2530e86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019584 Commit-Queue: Roger Tawa <rogerta@chromium.org> Reviewed-by:
Thiemo Nagel <tnagel@chromium.org> Reviewed-by:
Robert Shield <robertshield@chromium.org> Cr-Commit-Position: refs/heads/master@{#736403}
-
Benjamin Beaudry authored
When using Narrator's heading navigation, there's an issue when the next heading we want to read is followed by an empty <div> element. It hangs for 30 to 45 seconds (on a debug build) trying to get to that heading. This CL fixes the issue. It was caused by the replacement character exposed to the text pattern provider to represent an empty object, introduced in one of my previous change, CL:1937858. I had to modify AbortMoveAtFormatBoundary in ax_position.h. The issue was caused by the wrong AXBoundaryType returned by GetFormatStartBoundaryType and GetFormatEndBoundaryType when in presence of an empty object. When we are navigating by headings and we encounter an empty object, the AXBoundaryType returned should be a AXBoundaryType::kUnitBoundary and not a AXBoundaryType::kNone. In other words, we want to break when the anchor is an empty object, since the format is necessarily different. Bug: 1046112 Change-Id: Ia83e31df5a242908186c03a2ea110a36bccb365b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023392 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#736402}
-
Brian Salomon authored
Bug: 1041451 Change-Id: I395a29b45c16f99da9461c3dbe4d900be5177e12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026474 Commit-Queue: Robert Phillips <robertphillips@google.com> Auto-Submit: Brian Salomon <bsalomon@google.com> Reviewed-by:
Robert Phillips <robertphillips@google.com> Cr-Commit-Position: refs/heads/master@{#736401}
-
Alexander Dunaev authored
This CL continues the refactor of the Linux drag'n'drop. We are going to enable drag'n'drop on Ozone/X11, and as Aura/X11 already has the implementation, we are making it available for Ozone, trying to minimise possible duplication of the logic. As the overall changes are going to be huge, I am doing it in small steps to ease review and rebases, and to feel the progress better. Here I do two things: 1) Extract parts of OSExchangeDataProviderAuraX11 and some related code so that it could be used in Ozone. 2) Move ui::FileInfo into a sub-component of of //ui/base so it could be used in //ui/base/x (otherwise a circular dependency happens). This CL is not the final one, subsequent changes will come. Bug: 1014860 Change-Id: Idbba2485303e1018eb84f733b0b35b058a5431bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013050 Commit-Queue: Alexander Dunaev <adunaev@igalia.com> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#736400}
-
Sergey Silkin authored
This reverts commit 4e979a0d. Reason for revert: This CL changed fallback requirements for all platforms whilst only android was in the initial consideration. Reverting this to reduce a chance of negative consequences. The fallback requirements will be changed exclusively for android in a follow-up CL. Original change's description: > blink/webrtc: enable H264 encoding even if no sw-fallback available > > crrev.com/c/1863153 introduced a regression when it started looking > at the kWebRtcHWH264Encoding flag, which was enabled by default. > This was caused by the convoluted logic around h264 sw/hw encoding > support. This CL removes that check entirely since the flag was > fully enabled anyway [1] so the original check: > > if (webrtc_h264_sw_enabled || base::FeatureList::IsEnabled(blink::features::kWebRtcHWH264Encoding)) > > was always true (bc of the second member). > This CL thus removes all the code related to that flag, allowing > for h264 to be accepted even if there's no sw fallback, hence restoring > the original behaviour pre-deprecation. > > [1] https://chromium-review.googlesource.com/c/chromium/src/+/1863153/4/third_party/blink/common/features.cc > > Bug: webrtc:11244 > Change-Id: Id9132181fdca08ede12e22a1cc66590f1062269d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022929 > Commit-Queue: Harald Alvestrand <hta@chromium.org> > Reviewed-by: Harald Alvestrand <hta@chromium.org> > Cr-Commit-Position: refs/heads/master@{#735541} TBR=hta@chromium.org,mcasas@chromium.org,tommi@webrtc.org,ssilkin@chromium.org,ssilkin@webrtc.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: webrtc:11244 Change-Id: I61ce4858469630638cc70ddd7635fb681cbcaa55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028048Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#736399}
-
Gauthier Ambard authored
The test was failing because it was swiping too much on iPad. Fixed: 1046290 Change-Id: I4b41c6df9559f7af1dcc07097749ced62efdcc7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026972Reviewed-by:
David Jean <djean@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#736398}
-
Marc Treib authored
It has been deprecated and unused for a while. The specifics proto itself can't be removed yet because it's still used on the server. Bug: 1009361 Change-Id: Ic183a6e244435cfce60ccdda34bff3e22a032ff3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022670 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#736397}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5a6ee40f. With Chromium commits locally applied on WPT: 1029b7e9 "SharedWorker: Add WPT for upgrade-insecure-requests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ib9bc8dd5e37ff3108b8f264cdcdaf9e827c6f5a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027596Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736396}
-
Kazuhiro Inaba authored
This reverts commit 7edc6542. Reason for revert: broke ARC++ graphics/video b/148349017 Bug: b/148349017 Original change's description: > Ozone/DRM: Eliminate tracking of owned planes in HardwareDisplayController > > Don't keep track of owned planes directly in HardwareDisplayController. > We already know the set of owned CRTCs and we can ask the plane manager > to find the planes corresponding to those CRTCs. By removing > |owned_hardware_planes_| from HardwareDisplayController, we reduce > the amount of state that has to be protected by a lock if we wish to > perform pageflip testing on another thread (see the bug for more > context). > > TEST=Built and ran on eve and chell. Connected and disconnected an > external monitor. There is also plenty of existing unit tests that cover > this code. > > Bug: 1034559 > Change-Id: I16fccc549c272c8659d392996a163877ac7bd7ba > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003561 > Commit-Queue: Saman Sami <samans@chromium.org> > Reviewed-by: Daniel Nicoara <dnicoara@chromium.org> > Cr-Commit-Position: refs/heads/master@{#733746} TBR=spang@chromium.org,achaulk@chromium.org,dnicoara@chromium.org,samans@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1034559 Change-Id: I9b746ae555e875d6648ea68cac9ee642ac3fc3b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028307Reviewed-by:
Kazuhiro Inaba <kinaba@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: Kazuhiro Inaba <kinaba@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Auto-Submit: Kazuhiro Inaba <kinaba@chromium.org> Cr-Commit-Position: refs/heads/master@{#736395}
-
Abhijeet Kandalkar authored
This CL has goal to use To<SVGInlineTextBox> and DynamicTo<SVGInlineTextBox> as new downcast helper. Bug: 891908 Change-Id: I56fcdaf41d98eec44e91f73f20542d513bed1f5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020002Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#736394}
-
Mike Dougherty authored
TBR=rohitrao@chromium.org Bug: 1046787 Change-Id: Ia36a5eeeffb6775e16b45b9d0db89670c1dd0767 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028248 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#736393}
-
Sylvain Defresne authored
The metric has been obsolete for over a year, and is not logged on any other platform. Remove the code to log it and all support code. Bug: 1046680 Change-Id: I2c795cf41d223c788214b2a4153050f57416a413 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027409Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#736392}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/13c44dfeb014..05e08edf70d5 git log 13c44dfeb014..05e08edf70d5 --date=short --first-parent --format='%ad %ae %s' 2020-01-29 jgilbert@mozilla.com Disable skipValidation when context is lost. Created with: gclient setdep -r src/third_party/angle@05e08edf70d5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: tobine@google.com Change-Id: I40965ab58448ef4a6214a7534daec26e0e96597e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027581Reviewed-by:
-
Owen Min authored
set_extension_request_enabled is not used by any ProfileReportGenerator caller. Let the ProfileReportGenerator read the policy value for each profile. Bug: 1006899 Change-Id: I968656200a214e80e9a1f0502b0e63dddf98c916 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024696Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#736390}
-
Owen Min authored
Don't show any notification when the policy is disable and close any exist notification. Re-show the notification once the policy is enabled again. Bug: 1006899 Change-Id: I4fa530890d1be26ef17bfd56d81216444b381a76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025828Reviewed-by:
-
