- 18 Dec, 2017 23 commits
-
-
Yuichiro Hanada authored
The definitions of these functions were already removed in crrev.com/1392713002. Bug: N/A Test: Build. Change-Id: Ic1ee7288776f5d6fb472057f69378303ba10ec21 Reviewed-on: https://chromium-review.googlesource.com/821973 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#524655}
-
Hiroki Nakagawa authored
This test is failing on the Linux bot. See the issue for details. Bug: 795631 Change-Id: I7fff23380fff9c4627fe88c42907ff746ec30d0c TBR: shuchen@chromium.org Reviewed-on: https://chromium-review.googlesource.com/831380Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#524654}
-
Tsuyoshi Horo authored
After this cl https://chromium-review.googlesource.com/c/v8/v8/+/806741, printTimelineRecordsWithDetails() outputs the file name of v8-cache-script.js without the port number and the directory path. So this test is continuously failing. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=service-worker-v8-cache This CL doesn't completely fix the issue. But I want to update the expectation first to monitor the flakiness dashboard. Bug: 789111 Change-Id: I936f260c2bc73271cc76f67a99d691415f615103 Reviewed-on: https://chromium-review.googlesource.com/831374 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#524653}
-
Ke He authored
Add the GeolocationControl mojo interface via which the chrome can inform the geolocation-core that user opted in to location tracking. Note that both the GeolocationServiceImpl from content and the GeolocationPermissionContext from chrome have their own mojo connections to Device Service. However, races are not an issue, as the Geolocation implementation is already equipped to handle the case where requests for geolocation come in prior to permission being granted by queuing those requests and then unblocking them on granting of permission. BUG=725044 Change-Id: I7e53f9cfd5698d09e4860ed7c869bcbd6991857a Reviewed-on: https://chromium-review.googlesource.com/760239 Commit-Queue: Ke He <ke.he@intel.com> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#524652}
-
Kunihiko Sakamoto authored
https://crrev.com/c/826706 moved these constants to histogram_suffixes.h in, but forgot to remove them from data_reduction_proxy_metrics_observer.h. Change-Id: I52bce11ac6ba1186a3a08fc71cda3bf22b431a34 Reviewed-on: https://chromium-review.googlesource.com/831376Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#524651}
-
Hiroki Nakagawa authored
These tests are crashing on the chromium.linux/Cast Audio Linux bot. Bug: 795627 Change-Id: Ifefee9f86a15a80d5fc6a455b37482dbad264bc2 TBR: haraken@chromium.org Reviewed-on: https://chromium-review.googlesource.com/831313Reviewed-by:
-
chrome-release-bot authored
TBR=mmoss@chromium.org Change-Id: I753faefd9b1816b8d5c068639c5a5c561c61ccdf Reviewed-on: https://chromium-review.googlesource.com/830751Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#524649}
-
Han Leon authored
This CL: - merges web_service_worker_installed_scripts_manager_impl.{cc,h} out of //content/renderer into Blink modules/serviceworkers/ServiceWorkerInstalledScriptsManager.{cc,h}. - removes the unnecessary abstract layer for Blink public/platform/modules/serviceworker/WebServiceWorkerInstalledScriptsManager.h. - merges thread_safe_script_container.{cc,h} out of //content/renderer into Blink modules/serviceworkers/ServiceWorkerInstalledScriptsManager.{cc,h}. - revises related test codes. BUG=792778 Change-Id: Ie1c669ae58af3a9b23494eec7e3c0e5541430a9b Reviewed-on: https://chromium-review.googlesource.com/816085 Commit-Queue: Han Leon <leon.han@intel.com> Reviewed-by:Kentaro Hara <haraken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
-
Hiroki Nakagawa authored
Bug: 795626 Change-Id: If0016e86ca495cee54bf4b7a845f5adda8e6b65b TBR: dpapad@chromium.org Reviewed-on: https://chromium-review.googlesource.com/830993Reviewed-by:
-
Hiroki Nakagawa authored
Before this CL, classic script evaluation is tied with worker thread initialization. This is cumbersome for module scripts because module scripts are fetched after a global scope is created and not ready during the initialization. As a quickfix, it's bypassed for WorkletGlobalScope that is only the client of module scripts on the worker thread for now (See the end of WorkerThread::InitializeOnWorkerThread()). For cleanup, this CL separates classic script evaluation from worker thread initialization. If you want to evaluate classic scripts, you need to explictly post a task after the worker thread initialization. This makes it easier to switch classic script loading and module script loading in following CLs: if you want to evaluate module scripts, you can just post a task for module script evaluation. Rough design doc of module scripts for Dedicated Worker: https://docs.google.com/a/chromium.org/document/d/1IMGWAK7Wq37mLehwkbysNRBBnhQBo3z2MbYyMkViEnY/edit?usp=sharing Bug: 680046 Change-Id: I7bf32051a8e423de65bb6b0d76164cb1540d3aa4 Reviewed-on: https://chromium-review.googlesource.com/822320Reviewed-by:
-
Kunihiko Sakamoto authored
Bug: 740886 Change-Id: I7cdfd6099a24bd36ccb1f962317f83b5e5299f20 Reviewed-on: https://chromium-review.googlesource.com/828342Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#524645}
-
Darren Shen authored
This patch updates tests for CSSMatrixComponent. We also update the implementation: If a component options is passed in, the component.is2D attribute uses the options, regardless of whether the matrix is 2D. Spec: https://drafts.css-houdini.org/css-typed-om-1/#cssmatrixcomponent Bug: 545318 Change-Id: I880c6eb17282e5d2dd3946da5458aa9db7417be1 Reviewed-on: https://chromium-review.googlesource.com/823802 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
meade_UTC10 <meade@chromium.org> Cr-Commit-Position: refs/heads/master@{#524644}
-
Rohit Rao authored
testRotationsWhileSwitcherIsNotActive sometimes fails because EarlGrey finds multiple objects that match the given tab title. The test output implies that tabs from previous tests are remaining visible somehow, possibly in the "Recently Closed Tabs" section. Giving each tab a unique title works around this issue. BUG=789975 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I908b5362e4b669d1914bbfff2e2e691db8e2d0f2 Reviewed-on: https://chromium-review.googlesource.com/830900Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#524643}
-
Daniel Cheng authored
Just calling the callback on early return is good enough. Cq-Include-Trybots: master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng Change-Id: Ie0a4ca353f294237d54c4fe101559aa82d711ba0 Reviewed-on: https://chromium-review.googlesource.com/752481 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#524642}
-
Hiroki Nakagawa authored
This CL moves implementation of the "fetch a module worker script graph" algorithm from WorkletGlobalScope to WorkerOrWorkletGlobalScope so that it can be reused for module workers. There is no behavioral change. Bug: 680046 Change-Id: I7eba8ec1e1dc65396ec2aea8486b22fd1d829fa2 Reviewed-on: https://chromium-review.googlesource.com/826206Reviewed-by:
-
Wez authored
Bug: 795617 TBR: dtapuska@chromium.org Change-Id: I9bb71a8556ee6fab4734a29e9525f1cb680d0738 Reviewed-on: https://chromium-review.googlesource.com/831402 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#524640}
-
Wez authored
This test times-out on Fuchsia bots, seemingly due to an extremely long delay in getting around to scheduling the sub-process to execute, some of the time. Other similar ProcessUtilTests succeed because they wait indefinitely for the sub-process to do its work; raising the timeout to action_timeout() provides enough head-room that this test passes. This also has the advantage that the test's timeouts are now configurable. Bug: 793412 Change-Id: I8b43e3cadfe302cf8afd9e835ee4ed1fbcda3c9e Reviewed-on: https://chromium-review.googlesource.com/828383Reviewed-by:
Scott Graham <scottmg@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#524639}
-
Renee Wright authored
The old versions of these methods are in CSSPropertyNames.h/.cpp Moved methods are - getPropertyName -> CSSProperty::GetPropertyName - getPropertyNameAtomicString -> CSSProperty::GetPropertyNameAtomicString - getPropertyNameString -> CSSProperty::GetPropertyNameString - getJSPropertyName -> CSSProperty::GetJSPropertyName Adds GetPropertyName & GetPropertyNameAtomicString methods to CSSProperty. For properties that are in group CSSProperty classes, these methods call through to the legacy CSSPropertyNames versions (passing the result of PropertyID). For the properties that have unique CSSProperty classes, these methods are overridden, with the returned string hard-coded in the override. Moves getPropertyNameString and getJSPropertyName to CSSProperty. Updates all the callers of these 4 methods to use the CSSProperty versions. Removes the CSSProperty subclass "Inherited" and adds unique subclasses for its members. GetPropertyName also needs to support aliases, so I have added generated CSSProperty classes for aliases. These derive from a new base class called CSSUnresolvedProperty, which CSSProperty also derives from. I'm not sure if casting from CSSUnresolvedProperty to CSSProperty upon CSSProperty::Get incurs a runtime cost. This support is added in patch set 9 & up. gist for gen diff here: https://gist.github.com/rjwright/78980ce0a9c5c589bab98fcec1e74a13/revisions Part 2 of this effort is here: https://chromium-review.googlesource.com/c/chromium/src/+/804645 Bug: 788554 Change-Id: I245e7a807e696addc44cebc55c92b3b463861bdb Reviewed-on: https://chromium-review.googlesource.com/793650Reviewed-by:
dstockwell <dstockwell@chromium.org> Reviewed-by:
-
Blake O'Hare authored
OnKeyboardWorkspaceDisplacingBoundsChanging gets fired only if the bounds change in a way that affect workspace layout (i.e. when the locked full width keyboard does something). This simplifies the logic here so that the check to end early if the keyboard is not locked can be removed entirely. Bug: 786290 Change-Id: I9710049271bcbf0e5f662f0d4959cbc817ca569a Reviewed-on: https://chromium-review.googlesource.com/828480Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Blake O'Hare <blakeo@chromium.org> Cr-Commit-Position: refs/heads/master@{#524637}
-
Weidong Guo authored
This is a reland of fa8dfaa6 Original change's description: > Display mirroring persistency changes > > Changes: > 1. Change mirroring persistency rule to: > If previous mirror mode is not set (e.g. no external display in previous > configuration), turn on mirror mode if at least one of the external > displays was in mirror mode before and turn off mirror mode otherwise. > If previous mirror mode is set, mirror mode remains its previous value > as long as there are more than 1 displays. > For example: > Case 1: Connect display A; Turn on mirror mode; Connect display B. B > should be in mirror mode as well. > Case 2: Connect display A; Turn on mirror mode; Remove A; Reconnect A; A > should be in mirror mode. > Case 3: Connect display A; Turn on mirror mode; Remove A; Connect > display B. B should not be in mirror mode. > Case 4: Connect display A; Turn on mirror mode; Connect display B; > Remove B; Remove A; Reconnect B; B should be in mirror mode. > > 2. Fix a bug in MirrorWindowController: mirroring source display may be > changed in mirror mode (e.g. Connect two external displays; Turn on > mirror mode; Close internal display lid; Then the internal display will > be replaced with one external display as the mirroring source.), > reflector and mirror windows should be updated in this case. > > 3. Fix broken test. > > Bug: 785416,792207 > Test: MultiMirroringTest.* > Change-Id: Ia1da9f25df2bcc04f98ab087478a14685fff7708 > Reviewed-on: https://chromium-review.googlesource.com/804647 > Commit-Queue: Weidong Guo <weidongg@chromium.org> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Cr-Commit-Position: refs/heads/master@{#524627} TBR=afakhry@chromium.org, oshima@chromium.org Bug: 785416, 792207 Change-Id: I6f0c7b4169f5a0e0ab8a8f97a073cd165d21622d Reviewed-on: https://chromium-review.googlesource.com/831666Reviewed-by:
Weidong Guo <weidongg@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#524636}
-
Robert Liao authored
MessageLoop and the Blink scheduler pass/store tasks by value. This avoids having a heap allocation for every task. With this CL, TaskScheduler also passes/stores tasks by value. This is a prerequisite to make the TaskScheduler and the Blink scheduler work together. ScopedTaskEnvironment refactor and previous review at https://chromium-review.googlesource.com/c/chromium/src/+/764531 Bug: 783309, 795024 TBR: gab@chromium.org Change-Id: I2ae01bed216f7d4e9c6a2615689df1817a2507d0 Reviewed-on: https://chromium-review.googlesource.com/826569 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#524635}
-
Hwanseung Lee authored
there is using undefined variable in iterable.html. it is cause to fail layout test. Bug: 774887 Change-Id: Ibe516bcd8a24cc21ed604a1a9cf85e392a1c40c5 Reviewed-on: https://chromium-review.googlesource.com/828562Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#524634}
-
Eric Willigers authored
This reverts commit 951544c9. Reason for revert: Suspected performance regression. Original change's description: > Separate out the four classes contained in CSSPropertyValueSet.h into four different files > > Bug: 752745 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Change-Id: I43c650c37c33cb92d500e5e82d437f24faf6287a > Reviewed-on: https://chromium-review.googlesource.com/795515 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Eric Willigers <ericwilligers@chromium.org> > Reviewed-by: Bugs Nash <bugsnash@chromium.org> > Commit-Queue: meade_UTC10 <meade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#522385} TBR=ericwilligers@chromium.org,haraken@chromium.org,senorblanco@chromium.org,meade@chromium.org,bugsnash@chromium.org BUG=794983,752745 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I2a5cd1bde00080ad50c963f09627dcbeab5c6ba8 Reviewed-on: https://chromium-review.googlesource.com/831372 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#524633}
-
- 17 Dec, 2017 17 commits
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium ba99d192. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/8068 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: drott@chromium.org, kojii@chromium.org: external/wpt/css/css-fonts TBR=foolip No-Export: true Change-Id: Iac278f92a962d13def4e8b8c00e2fb0bf1265c8b Reviewed-on: https://chromium-review.googlesource.com/831268 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#524632}
-
Piotr Swigon authored
Change-Id: Ib0a76cc5919b1e4242b75180c749a13cf81346a4 Reviewed-on: https://chromium-review.googlesource.com/831371Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Reviewed-by:
Piotr Swigon <piotrs@chromium.org> Commit-Queue: Piotr Swigon <piotrs@chromium.org> Cr-Commit-Position: refs/heads/master@{#524631}
-
Roman Sorokin authored
It is an effort to make changing API easier. BUG=chromium:785956 Change-Id: If65bb11804a6ff84ea960bda4178c5a48ddae98c Reviewed-on: https://chromium-review.googlesource.com/829813Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#524630}
-
Findit authored
This reverts commit fa8dfaa6. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 524627 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2ZhOGRmYWE2MjFjMTcwMWRjZTg0MWY3NmVmZmVjZDA2NGZmMzc1M2UM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/3252 Original change's description: > Display mirroring persistency changes > > Changes: > 1. Change mirroring persistency rule to: > If previous mirror mode is not set (e.g. no external display in previous > configuration), turn on mirror mode if at least one of the external > displays was in mirror mode before and turn off mirror mode otherwise. > If previous mirror mode is set, mirror mode remains its previous value > as long as there are more than 1 displays. > For example: > Case 1: Connect display A; Turn on mirror mode; Connect display B. B > should be in mirror mode as well. > Case 2: Connect display A; Turn on mirror mode; Remove A; Reconnect A; A > should be in mirror mode. > Case 3: Connect display A; Turn on mirror mode; Remove A; Connect > display B. B should not be in mirror mode. > Case 4: Connect display A; Turn on mirror mode; Connect display B; > Remove B; Remove A; Reconnect B; B should be in mirror mode. > > 2. Fix a bug in MirrorWindowController: mirroring source display may be > changed in mirror mode (e.g. Connect two external displays; Turn on > mirror mode; Close internal display lid; Then the internal display will > be replaced with one external display as the mirroring source.), > reflector and mirror windows should be updated in this case. > > 3. Fix broken test. > > Bug: 785416,792207 > Test: MultiMirroringTest.* > Change-Id: Ia1da9f25df2bcc04f98ab087478a14685fff7708 > Reviewed-on: https://chromium-review.googlesource.com/804647 > Commit-Queue: Weidong Guo <weidongg@chromium.org> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Cr-Commit-Position: refs/heads/master@{#524627} Change-Id: Ie18b8dc47d031984590ed98af331fdb659b17941 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 785416,792207 Reviewed-on: https://chromium-review.googlesource.com/831290 Cr-Commit-Position: refs/heads/master@{#524629}
-
Morten Stenshorne authored
Constraint spaces for inline nodes also need to support block fragmentation, due to floats. We need to allow a (0,0) inline break token if we break before the first line. If there's no break token for the inline layout context, it means that we have finished all lines. Which is quite the opposite of being at the very beginning. There are some new test failures. One source is that we don't yet support column-span:all, and now that we break between lines, what used to pass by accident may no longer pass. Making floats in an inline formatting context play along was tricky, and I'm pretty sure that the solution I came up with needs to be improved. For now, skip floats associated with the line when we resume layout at. Floats that got broken inside will create break token children of the token created for the containing block node, and will be break token siblings of the inline break token to resume at (although they are not siblings, node-wise). The legacy layout write-back code doesn't work too great, especially with LayoutNGPaintFragments enabled (but there are problems if that flag is disabled too). Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I01634daf75a7d80a663ec24991eec8b4094aeeda Reviewed-on: https://chromium-review.googlesource.com/829376 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#524628}
-
Weidong Guo authored
Changes: 1. Change mirroring persistency rule to: If previous mirror mode is not set (e.g. no external display in previous configuration), turn on mirror mode if at least one of the external displays was in mirror mode before and turn off mirror mode otherwise. If previous mirror mode is set, mirror mode remains its previous value as long as there are more than 1 displays. For example: Case 1: Connect display A; Turn on mirror mode; Connect display B. B should be in mirror mode as well. Case 2: Connect display A; Turn on mirror mode; Remove A; Reconnect A; A should be in mirror mode. Case 3: Connect display A; Turn on mirror mode; Remove A; Connect display B. B should not be in mirror mode. Case 4: Connect display A; Turn on mirror mode; Connect display B; Remove B; Remove A; Reconnect B; B should be in mirror mode. 2. Fix a bug in MirrorWindowController: mirroring source display may be changed in mirror mode (e.g. Connect two external displays; Turn on mirror mode; Close internal display lid; Then the internal display will be replaced with one external display as the mirroring source.), reflector and mirror windows should be updated in this case. 3. Fix broken test. Bug: 785416,792207 Test: MultiMirroringTest.* Change-Id: Ia1da9f25df2bcc04f98ab087478a14685fff7708 Reviewed-on: https://chromium-review.googlesource.com/804647 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#524627}
-
Rohit Rao authored
When the BVC presentation experiment is enabled and the last incognito tab is closed, transition animations continue to run even after the incognito BrowserState is destroyed. Variables that are cleared in |browserStateDestroyed| must be tested for nullptr before use. BUG=787821 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ic5443690337d311e1ce3e347e563d3111cc06f5e Reviewed-on: https://chromium-review.googlesource.com/831095 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
-
Luke Sorenson authored
Bug: 794273 Change-Id: I340114ad83e2dcdd5fd2b8d0dea721d0705e53b3 Reviewed-on: https://chromium-review.googlesource.com/822820Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Commit-Queue: Luke Sorenson <lasoren@chromium.org> Cr-Commit-Position: refs/heads/master@{#524625}
-
Jungshik Shin authored
Bug: 789905 Test: CrOS OOBE language menu does not have ar-001 and en-150. Change-Id: I5f9489edf5819e789558bf53ddb4ecbb389e6a45 Reviewed-on: https://chromium-review.googlesource.com/828070Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#524624}
-
Koji Ishii authored
Following bot results are included. 2493 2495 2496 2498 2499 2500 2502 2505 2508 2511 2512 2513 2524 2526 16 lines were removed by consecutive passes since 2485. TBR=eae@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I1c0ecfac97903ff168d97597290ebf7f17037de9 Reviewed-on: https://chromium-review.googlesource.com/831309 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Oystein Eftevaag authored
TBR=nednguyen@chromium.org BUG=795585 Change-Id: Idbe16201235a53ad7669478d58611708e607d5bc Reviewed-on: https://chromium-review.googlesource.com/831508Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#524622}
-
Mikel Astiz authored
We would like to sync this data in order to make sync-ed history entries corresponding to history.replaceState() and similar Javascript events distinguishable from user-initiated events (typed URLs or clicks on bookmarks). Most notably, this solves the problem of duplicates in the NTP for server-side suggestions, which otherwise may count the URL after replaceState() as being typed by the user and hence worth suggesting. Design Doc (accessible to Google employees only): https://docs.google.com/document/d/1g8w7VkLjI1V1f5N_Hkn3Lb66C3iUbV91SufFu2vEBSk/ Bug: 751023 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I7616d5f1782c0ee9af779d2c102a29b042ce44a1 Reviewed-on: https://chromium-review.googlesource.com/738095Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Reviewed-by:
Nicolas Zea <zea@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#524621}
-
George Burgess IV authored
This patch adds support for clang-based AFDO to Chromium. AFDO stands for Automatic Feedback Directed Optimization. In short, it allows you to use the postprocessed output of a special `perf` command to inform the compiler of hot/cold code, among other things. This allows users to easily specify a profile to use, and allows for platforms to specify default profiles. It turns none of this on on its own. At the moment, this is very sharp and pointy, since the sample profile isn't a dependency for anything. Ideally, anything built with AFDO should depend on the profile. I have a CL to make this easily possible (CL:827560), but think this is useful enough (given care) to get in now. (and with clang_use_default_sample_profile set to true). We built with profiles and failed to `gn gen`, respectively. Patch seemed to be a nop running on an otherwise "regular" build. Bug: 794750 Test: Ran the build with and without clang_default_afdo_profile defined Change-Id: I7b2730d52875f108681232f4d8ce7e82e7570a74 Reviewed-on: https://chromium-review.googlesource.com/828277Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#524620}
-
Yafei Duan authored
Adding UMA for saving and deleting pages: - Refactored DeletePageTask for metric collection. - Added new histogram names and made old ones obsolete. - Updated related tests with histogram tester. This CL also contains: - Renamed test_util to test_utils for consistency. - Added offline_pages::model_utils for utility methods used across all tasks and model itself. - Updated OfflinePageItemGenerator for testing support Bug: 772204 Change-Id: I894da05d510addbf01f3dd9b7ccda29b27404752 Reviewed-on: https://chromium-review.googlesource.com/811829Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Dmitry Titov <dimich@chromium.org> Commit-Queue: Yafei Duan <romax@chromium.org> Cr-Commit-Position: refs/heads/master@{#524619}
-
chromeos-commit-bot@chromium.org authored
TBR=chrome-os-gardeners@google.com Change-Id: I118b5e3c5799130dc23cde5ee601d50b7f331631 Reviewed-on: https://chromium-review.googlesource.com/831566Reviewed-by:
ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#524618}
-
chrome-release-bot authored
TBR=govind@chromium.org Change-Id: I98fdf9497b8e9ac33ff1554c02898296e590a16c Reviewed-on: https://chromium-review.googlesource.com/830791Reviewed-by:
-
Xiaohui Chen authored
Previously VoiceInteractionControllerClient has the same life cycle as ArcVoiceInteractionFrameworkService, which is only alive when primary profile running and has ARC++ enabled. This life cycle isn't a good fit for VoiceInteractionControllerClient since it is used to update Ash states, which has a global life time. It caused bugs like in multi- profile, and restricted profile, Ash UI wasn't properly rendered. BUG=b:68664196 TEST=unit tests and locally build and manually test multi-profile Change-Id: I8495e2c41274db385741b86d778c96e15a25b977 Reviewed-on: https://chromium-review.googlesource.com/827540 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
-
