- 16 Jul, 2020 40 commits
-
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ia4f6eeaba314a0ebee6dba887ca3cb41d7417d92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302914Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789192}
-
Evan Stade authored
Bug: none Change-Id: I7ef47e17d4c534161abab20cc8fe0718af442465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295809Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#789191}
-
Xianzhu Wang authored
TBR=wangxianzhu@chromium.org Change-Id: I23d0dce539e573e373009a85c715268e74b83872 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303048Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#789190}
-
behdad authored
Use cpu_wall_time_ratio in representative perf tests logic to invalidate failures which had lower than usual cpu_wall_time_ratio in order to reduce flaky failures. As a result only stories which have higher frame_times than the limit and acceptable cpu_wall_time_ratio would be failing. Bug: chromium:1052361 Change-Id: I294361375f91096a32e226f57dc61450926fab0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292811 Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#789189}
-
Ken Rockot authored
Service manifests are not particularly useful in production anymore. Content uses a subset of the manifests (and their overlays) to filter interface requests coming from renderers. This filtering is redundant given the completion of BrowserInterfaceBroker migration and the fact that *_receiver_bindings.cc files have SECURITY_OWNERS coverage too. Hence the redundant filtering is removed here. Minimal infrastructure supporting manifests is left in place for now, as cast_shell still internally depends on the Service Manager and manifest overlays. Bug: 977637 Change-Id: I360aadeecaeed859996b3671ed6646babd831a87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296482Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#789188}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/e28cc55cac22..c15c6eb9d8c3 2020-07-16 cwallez@chromium.org dawn_wire/server: Use MapAsync to do Map[Read/Write]Async 2020-07-16 cwallez@chromium.org DawnTest: Use MapAsync for expectations. 2020-07-16 cwallez@chromium.org Roll third_party/swiftshader/ ad65826a2..e8dd233c7 (10 commits) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I920cff96b98bffd9c8d794a653f037556c3ce5b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303096Reviewed-by:
-
Sophie Chang authored
Bug: 1092329 Change-Id: I65f6cc0f5534859a4b55cf86c916015030e01af0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295780Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#789186}
-
Hesen Zhang authored
- Add full unit test for the service. - Add SetClockForTesting for the service, and use clock object inside. - Using scheduler to check throttle(tooManyNotifications). Bug: 1047037 Change-Id: I3354e5190c70e1e7eeb64437fb293c1d342eb7d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293579Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#789185}
-
Adam Langley authored
Fido2CredentialRequestTest in chrome_public_test_apk is failing. Commit f55cd37e was reverted[1] but I suspect that the cause might actually be the Mojo change in c296f39e. Trying to run the tests fails for me because the tests timeout trying to do setup as I'm remote, but I think this is worth a shot at greening the bots. TBR=martinkr [1] https://chromium-review.googlesource.com/c/chromium/src/+/2303030 Change-Id: Ida3e66df0c5bd9e98ffc2b84032d857236aaf6e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303354Reviewed-by:
Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#789184}
-
Robert Sesek authored
This target was missed in 2585915c. The CL also adds additional locking annotations to MachPortRendezvousServer. Bug: 1106353, 1013082 Change-Id: Id2fe4f707dc90efd79c0354de73e5066b8715713 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302942Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#789183}
-
Garrett Beaty authored
There was some confusion about file naming where someone thought they could run lucicfg generate against //subprojects/findit/main.star. Only the top-level files main.star and dev.star can be passed to lucicfg generate, so this change should hopefully make such confusion less likely. The main.star in the subproject subdirectories have been renamed to subproject.star so that the subprojects have a consistent entry-point. //dev/main.star and //subprojects/chromium/master-only/main.star are both one-offs that have been renamed to match the containing directory. Change-Id: I99d8f7887d087070bd89f14e74c225447ebe1805 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303451 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#789182}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 09f7f50d. With Chromium commits locally applied on WPT: 1adfdd4d "[COOP] Fix typo in test name" f19f3404 "[Sheriff] Revert "Deflake preservesPitch tests"" f90faeee "Remove old comments from web platform tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org: external/wpt/fullscreen foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools ksakamoto@chromium.org, npm@chromium.org, yoavweiss@chromium.org: external/wpt/resource-timing mek@chromium.org: external/wpt/webmessaging mlamouri@chromium.org: external/wpt/screen-orientation NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: Ie4af4bb93871fe71efa273f2eb3ba02d27524571 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303011Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789181}
-
Kent Tamura authored
This CL has no behavior changes. Bug: 1040826 Change-Id: Id9bd44baa60ff39650f924eec0d39236e3d5765a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301559 Auto-Submit: Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#789180}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Id1d6aa93d0b49e8ca068b64f76a8f21a4864a230 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302719Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#789179}
-
Peter Wen authored
Remove //{chromecast,content,mojo,services,testing}* from allowlist. Bug: 1082904 Change-Id: Ia47b46e70edb64962279c3b8619f37278e15da7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303171 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:Andrew Grieve <agrieve@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#789178}
-
Alison Maher authored
fast/css/css2-system-color.html was marked as flaky in TestExpectations in the following change: https://chromium-review.googlesource.com/c/chromium/src/+/2295405 It appears that the following change fixes the flakiness issue for fast/css/css2-system-color.html on Windows: https://chromium-review.googlesource.com/c/chromium/src/+/2295695 There were also failures for this test on Mac due to existing expectation files. Removing these did the trick, allowing us to remove fast/css/css2-system-color.html from TestExpectations altogether. Bug: 1104697 Change-Id: I1cb843ada8023f9ab4f803b69469a662b35ab588 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300347Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#789177}
-
Dominic Farolino authored
R=sclittle@chromium.org Bug: 1047909 Change-Id: I71ca1728a4cc148587e12fce98841488591e869a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299475 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c139b630a30b..b15083559691 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC hesen@google.com,sahel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1106045 Tbr: hesen@google.com,sahel@google.com Change-Id: I9c12f2bdb629de94965cd3a16a2d08fbc024cbfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303094Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789175}
-
Torne (Richard Coles) authored
Implement an alternative option for the handling of extra headers in loadUrl, which only allows them to be sent to redirects to the same domain (eTLD+1). This is less restrictive than the existing feature flag requiring that they be the same origin (and if that flag is enabled, this one has no effect). Implement a new histogram that just records whether redirects are same-origin, same-domain, or cross-domain, and obsolete the current one, which doesn't make sense with the new option. Bug: 1038002 Change-Id: I121de069d7a87fb4718ad9131ca427a5c017a7d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264609 Auto-Submit: Richard Coles <torne@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#789174}
-
Ilia Samsonov authored
Baselines were generated in the following build: https://ci.chromium.org/p/chromium/builders/try/linux-blink-optional-highdpi-rel/5 Bug: 1068400 Change-Id: If06e8db5a31067f53e5dfb770dadf8f30f97681a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293374Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#789173}
-
Tina Wang authored
Test the conditions for showing the enterprise info in the menu. Change-Id: I8c2dd7ec18c76c7f58c434a9cea88890225e2cc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297721 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#789172}
-
Sahel Sharify authored
The test has been flaky on Mac: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyXgsSBUZsYWtlIlNjaHJvbWl1bUBibGlua193ZWJfdGVzdHNAc2Nyb2xsYmFycy9jdXN0b20tc2Nyb2xsYmFyLWFkanVzdC1vbi1pbmFjdGl2ZS1wc2V1ZG8uaHRtbAw TBR=tkent@chromium.org Bug: 1105271 Change-Id: Ia94cbbb1cc84f27846bedc42f50b7b5c46c066ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303091Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#789171}
-
Sahel Sharify authored
flake portal: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyTwsSBUZsYWtlIkRjaHJvbWl1bUBibGlua193ZWJfdGVzdHNAZWRpdGluZy9zZWxlY3Rpb24vc2VsZWN0aW9uLWJhY2tncm91bmQuaHRtbAw TBR=wangxianzhu@chromium.org Bug: 1104910 Change-Id: I017a9e76b54725bafa403c55927efc5e00e41ee5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303113 Commit-Queue: Sahel Sharify <sahel@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1594899981-52deb7a5a818691ecf42e5c040aa970329d9defe.profdata to chrome-mac-master-1594922139-2e74d5a60ec66c9d9f020f69b34f84d613c708fd.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com Change-Id: I40878e1041f74072faf30be183a8d91bd0b3bdca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303119Reviewed-by:
-
Corentin Wallez authored
Bug: chromium:1101491 Change-Id: I8028ffbe7031d38ae392239d17f51c6983ec29cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302194 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#789168}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f224f744249c..cab02df7a5c5 2020-07-16 lalitm@google.com Merge "Revert "tp: move thread state implementation to trace processor"" 2020-07-16 lalitm@google.com Merge "ci: more fixes form fallout of redone CI" 2020-07-16 lalitm@google.com Merge "ci: update worker to Python3" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I06879b6dfd154d8c39a52e5757e84553813acba6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302679Reviewed-by:
-
Garrett Beaty authored
Bug: 1106029 Change-Id: Ice3f5575963ba0f31faf3cd45411c2b6c89589ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302740 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Commit-Queue: Michael Moss <mmoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#789166}
-
Alex Newcomer authored
Problem Background: Some applications take considerable time before finishing a paste. Also, some applications read the clipboard multiple times per paste. When the user selects an item from CBHistory that is not the first item, we need to take the selected item and put it on the clipboard. Then we create a synthetic paste event. With no delay, we were then replacing the old top of the clipboard. Paste is async and can take some time. This means that we may replace the top of the clipboard before the paste is completed. To avoid this, add a 100ms wait before returning the original item to the top of the clipboard. Bug: 11055737 Change-Id: I2f229ebccc00b8241d22bd0341a8c67eeb0b57ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303450Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Auto-Submit: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#789165}
-
Brian Sheedy authored
Changes the experimental GPU Windows 10 NVIDIA Quadro P400 builder to target machines in the chromium.tests.gpu.experimental pool running Windows 10 1909, which is the version we are planning to upgrade to. Bug: 1085489, 1106076, 1106078 Change-Id: I92e43bb0baff75e1061e57a0336f3658c769d825 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276658 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#789164}
-
Toby Huang authored
We will create a new PolicyData field to distinguish K-12 EDU from Enterprise accounts in ChromeOS for the initial version of metrics. This flag should only be used for metrics as the Enterprise team does not want any differential treatment of EDU and Enterprise users in ChromeOS beyond this particular use case. This method of distinguishing EDU and Enterprise accounts only works for the primary account, as user policy doesn't apply for secondary accounts. Bug: 1103077 Change-Id: I1f27cd1b0b4ffe62bcb85459e070627dfdd509fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292703Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Bartosz Fabianowski <bartfab@chromium.org> Commit-Queue: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#789163}
-
Tommy C. Li authored
We currently classify ZeroSuggest search results against the current omnibox text. This was a holdover from the Query in Omnibox experiment, when we only did ZeroSuggest against the displayed query on SERP. Now that Query in Omnibox is completely dead, and we are doing ZeroSuggest against arbitrary page URLs, we want to change the behavior to never classify ZeroSuggest search results, and leave them all unbolded. This patch is minimal and designed to be mergeable back to M85. Bug: 1095837, 1106096 Change-Id: Icceec38d9d8697b69999115af4db9ae3dabd32d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300990 Commit-Queue: Tommy Li <tommycli@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#789162}
-
Aaron Leventhal authored
Users need to be informed when pressing down arrow would allow perusing options for filling in a textfield. This does not work in JAWS for autocomplete, but does for autofill. The difference is whether we expose STATE_SYSTEM_HASPOPUP. This CL exposes the haspopup state across all platforms, for both autofill and autocomplete. From the user's point of view they are choosing options from a list either way. R=akihiroota@chromium.org,dmazzoni@chromium.org AX-Relnotes: more consistent announcements for autocomplete textfields Bug: 1106044 Change-Id: I4f0b291c3d3478a3980f73e83474d022f541df7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299851Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#789161}
-
Etienne Bergeron authored
This CL is making the class ScopedHandleVerifierInfo movable to reduce the cost of putting this class into C++ map. The field StackTrace is expensive to copy. It should be lightweight to move into stl containers. This is done by adding a level indirection (i.e. std::unique_ptr; which has a fast move operation) to the field StackTrace. Bug: 1104342 Change-Id: I4ec0df3e5d57310ea75d5d604a2318c73121b011 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287812Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#789160}
-
Robert Ma authored
--additional-expectations takes a path relative to the CWD. Previously, disable-site-isolation-trials had a wrong path to the expectation file which caused a warning: additional_expectations path 'src/third_party/blink/web_tests/FlagExpectations/disable-site-isolation-trials' does not exist (https://chromium-swarm.appspot.com/task?id=4d6fcee1081fa710) Fortunately, run_web_tests.py automatically loads flag expectations based on the flag names, so nothing breaks. This change only removes the warning. Though unnecessary, --additional-expectations is kept in consistency with other variants of web tests. Change-Id: I098ec61272c362f82354c7d2ea42203e898b43af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303350 Commit-Queue: Robert Ma <robertma@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Robert Ma <robertma@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#789159}
-
Miriam Zimmerman authored
These metrics are emitted solely on Chrome OS and are needed to establish a more firm value of a timeout for invocations of crash_sender. BUG=chromium:1104269 TEST=Clicked upload on chrome://crashes; checked chrome://histograms Change-Id: I864d9a6bf36ee3c71fe2c6e642be615e84061a2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297965Reviewed-by:
Ian Barkley-Yeung <iby@chromium.org> Commit-Queue: Miriam Zimmerman <mutexlox@chromium.org> Cr-Commit-Position: refs/heads/master@{#789158}
-
David Van Cleve authored
There are some cases (e.g. arbitrary UA overrides from Android WebView) where clients can set UA header values that are not valid header values in the sense of containing no newlines and no carriage returns. This is causing a CHECK failure in net::HttpRequestHeaders (previously, the requirement was implicitly specified by a DCHECK; the DCHECK was upgraded to a CHECK in crrev.com/c/22703544 because allowing setting invalid headers can be a security vulnerability if input is untrusted). This CL changes WebContents to - document the precondition (previously implicit) that UA string overrides must, if nonempty, be valid header values - enforce this with a CHECK (since it is security-relevant: if we permit invalid header values, callers can add arbitrary protected headers). Bug: 1105745 Change-Id: I349baef33d1f010d5850c7d91453003d4e113fc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299528Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#789157}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ced0044c7c5c..832dab01db1d 2020-07-16 alexrudenko@chromium.org Quote font family names in single quotes 2020-07-16 tvanderlippe@chromium.org Remove checks for generated files from devtools_entrypoint 2020-07-16 tvanderlippe@chromium.org Cleanup usages of resources_out_dir 2020-07-16 bmeurer@chromium.org [bindings] Fix useless use of `Promise.resolve()`. 2020-07-16 aerotwist@chromium.org Asserts that all devtools_module files are listed in all_typescript_modules 2020-07-16 aerotwist@chromium.org Asserts that each entrypoint is listed in devtools_module_entrypoints If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1105861,chromium:1106221 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id3df2cff6728e7193265395f33f076f5634ff335 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302678Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I9674de2630535a6e3538c7b2a99f7b3318c78613 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302935Reviewed-by:
-
Alex Newcomer authored
Clipboard history did not previously read bitmaps in the initial CL. Bitmaps are read async, just needed some basic refactoring to handle it. Bug: 1102906 Change-Id: I488a0ad239f07c08dec5f93b8d2f03b5cc256e59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293464 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#789154}
-
Wan-Teh Chang authored
"Displayable frame" is the term used in libgav1 to refer to an AV1 video frame that can be output and is in the selected operating point. "Displayable buffer" is less clear. Change-Id: I1cfe176d6595e0cea37a2abf7f11e017d85e7eb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302738Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/master@{#789153}
-
