GitLab

This change is a no-op. It puts into place the needed support in the
net/quic, net/http, and net/spdy directories for disabling DoH. A follow-
up cl will add a similar field to URLRequest.

Change-Id: I598cc5da88061e04bd234fa70e7f4c306817fd5d
Bug: 1012268
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842220Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Katharine Daly <dalyk@google.com>
Cr-Commit-Position: refs/heads/master@{#705610}

On devices, since iOS 13.1, the page needs time to stabalize. Without
this wait, getting the location of the element will be incorrect.

Bug: 1012326
Change-Id: Iae60e2db1e2a6c438c3ab5541f9d8fa7c2b0199c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852024
Auto-Submit: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705609}

- Change based on accessibility review

Bug: 1012450,952425
Change-Id: I0eb9deef8e5d731a59a421ffbc42b40e2fc938c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857600
Commit-Queue: David Trainor <dtrainor@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705608}

This reverts commit 5d17f9ea.

Reason for revert: breaks builds when looking for ../../chrome/app/theme/google_chrome/BRANDING

Original change's description:
> Add is_chrome_branded to kythe codesearch builds
>
> Bug: b/140589523
> Change-Id: I01e015551729dc440187735fd689486eaabd6cf8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838053
> Reviewed-by: Aaron Gable <agable@chromium.org>
> Commit-Queue: Anthony Polito <apolito@google.com>
> Cr-Commit-Position: refs/heads/master@{#704808}


# Not skipping CQ checks because original CL landed > 1 day ago.

TBR=agable@chromium.org

Bug: b/140589523
Change-Id: Iba284db236c97c0400adb8d0371182135227b947
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857518Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705607}

This feature flag is still being used.

Bug: 959883
Change-Id: I7d1595454a271c6beba854f3a0565e40c1bc7928
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857862Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Ionel Popescu <iopopesc@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#705606}

When a permission prompt is shown, the user should have the URL bar
visible so that they can make an informed decision before accepting or
denying the request. This change exits fullscreen mode, which would hide
the URL bar, when a permission prompt is shown.

BUG=1007038

Change-Id: I6d2b600390b0297d0711de48b76fa492f16a71b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854789Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Olivier Yiptong <oyiptong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705605}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5abb9b7c5d0c..033004652faf

git log 5abb9b7c5d0c..033004652faf --date=short --no-merges --format='%ad %ae %s'
2019-10-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).

Created with:
  gclient setdep -r src/third_party/depot_tools@033004652faf

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=agable@chromium.org

Bug: None
Change-Id: I515a23dcecbce587b996c1b4482fdfe7baf7be54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860495Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#705604}

I can't remember why I originally moved this to NeverFixTests, but I
don't think it's necessary anymore.

Bug: 984818
Change-Id: Id28508ca3e034bfb06c0f671ababc6abfb691ca9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1858344
Commit-Queue: Austin Eng <enga@chromium.org>
Auto-Submit: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705603}

Bug: chromium:992979, chromium:1009074
Change-Id: I7c0a1e5a3bfcea05314db3ab57de518b7acaf5f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855628
Auto-Submit: Kuang-che Wu <kcwu@chromium.org>
Reviewed-by: Leon Scroggins <scroggo@chromium.org>
Commit-Queue: Kuang-che Wu <kcwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705602}

'Manage accessibility features' system settings.

This CL replaces the 'Captions' link in ChromeOS browser settings with a deep link
to the 'Manage accessibility features' system settings page, which already contains
a link to the caption settings page.

Bug: 971264
Change-Id: I426e69af92176ba8b11fa937014b36a6482654f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850800Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Commit-Queue: Evan Liu <evliu@google.com>
Cr-Commit-Position: refs/heads/master@{#705601}

As of 10.15, the system seems to try to activate every app shortly
after the app starts up. This causes windows the app creates early
in its lifecycle to be given key status by appkit, even if they were
created without being given key status. In order to avoid that, tests
that depend on this behavior need to wait for the system activation
to happen before creating their windows. This change adds a mechanism
for those tests to do so, and adds appropriate uses of it.

Bug: 988868
Change-Id: I219c926a8f716ad938e0f5279c04b9f94dba1c24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853107Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705600}

Bug: chromium:1012202
Change-Id: I47f1a5a8f49f685264a6f963d9043aff6d1cd42c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1858426Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Rakib Hasan <rmhasan@google.com>
Cr-Commit-Position: refs/heads/master@{#705599}

It's been fixed by CL:1849452.

Bug: 985032
Change-Id: I0496e4fd0eb7ab523510d102b09612a82be9ff54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859634
Auto-Submit: Jiajie Hu <jiajie.hu@intel.com>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705598}

Bug: 1013545
Change-Id: I3780efe1bdddcf02bf0c9cfa880a36b4cf67b067
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856802Reviewed-by: Abhishek Arya <inferno@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Dan McArdle <dmcardle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705597}

As of CL 1838592, -webkit-mask-image now uses CORS-enabled loading,
blocking chrome:// pages from using chrome://theme resources as mask
images. This only applies to OOBE and the WebUI tab strip currently.

Change-Id: I10f8a0e68ff2de4603a7bbb816c1f1c4a42b76e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855182Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705596}

FuchsiaVideoDecoder::ReleaseInputBuffers() was clearing
in_flight_input_packets_ before destroying input packets, which was
resulting in DCHECK failure. This change updates ReleaseInputBuffers()
to destroy input buffers before dropping the packets.

Bug: 1013919
Change-Id: I7288c1c47ab400877e5e4ec629083963b8e90a26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857712
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Auto-Submit: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705595}

HasEntry and GetUrlForEntry were already removed from the native
DomDistillerService, and only had stub impls in ..Android.

Bug: 1007942
Change-Id: I6793ae036671c7e648c19300181d574944363938
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857320
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Auto-Submit: Marc Treib <treib@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705594}

This reverts commit 575c09b1.

Reason for revert: Broke the tree, see:

https://ci.chromium.org/p/chromium/builders/ci/Linux%20Builder%20%28dbg%29%2832%29/123424

Original change's description:
> Roll sysroots
> 
> Also needed is [1] in webrtc, which fixes some build warnings. Could
> land in parallel.
> 
> [1] https://webrtc-review.googlesource.com/c/src/+/156980
> 
> BUG=1012850
> 
> Change-Id: Ia24e490db5e71cf1add0e10f4c1264aefb69143c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859935
> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#705589}

TBR=dpranke@chromium.org,thomasanderson@chromium.org

Change-Id: Ie1db662441a263452dfe433169b5aa900500744a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1012850
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860141Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705593}

In Python 3 keys() returns an iterable instead of a list. It's necessary to explicitly convert when you want to use as a list.
Still works with Python 2.

Fixed errors:
Traceback (most recent call last):
  File "../../components/certificate_transparency/tools/make_ct_known_logs_list.py", line 204, in <module>
    sys.exit(main())
  File "../../components/certificate_transparency/tools/make_ct_known_logs_list.py", line 199, in main
    generate_cpp_file(infile, outfile)
  File "../../components/certificate_transparency/tools/make_ct_known_logs_list.py", line 174, in generate_cpp_file
    if _is_log_once_or_currently_qualified(log):
  File "../../components/certificate_transparency/tools/make_ct_known_logs_list.py", line 161, in _is_log_once_or_currently_qualified
    return log.get("state").keys()[0] not in ("pending", "rejected")
TypeError: 'dict_keys' object is not subscriptable

Traceback (most recent call last):
  File "C:\Google\chromium\src\components\certificate_transparency\tools\make_ct_known_logs_list_unittest.py", line 238, in testSortingAndFilteringDisqualifiedLogs
    disqualified_logs = make_ct_known_logs_list._sorted_disqualified_logs(logs)
  File "C:\Google\chromium\src\components\certificate_transparency\tools\make_ct_known_logs_list.py", line 147, in _sorted_disqualified_logs
    return sorted(
  File "C:\Google\chromium\src\components\certificate_transparency\tools\make_ct_known_logs_list.py", line 87, in _is_log_disqualified
    log_state = log.get("state").keys()[0]
TypeError: 'dict_keys' object is not subscriptable

Bug: 941669
Change-Id: Iff905a290c3dc2581e1a0ff7ad8a8282ce9c050e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857121Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Commit-Queue: Raul Tambre <raul@tambre.ee>
Auto-Submit: Raul Tambre <raul@tambre.ee>
Cr-Commit-Position: refs/heads/master@{#705592}

[sheriff] This is a reland of bf1742a3
to disable a flaky test until adithyas@ can take another look.


Original change's description:
> Portals: Disable TouchInputTransferAcrossReactivation
>
> Test fails flakily on all aura platforms.
>
> Bug: 1010675
> Change-Id: Ic1906b0421dab41ddc14f36462aff459867afc33
> Tbr: lfg@chromium.org
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836007
> Reviewed-by: Adithya Srinivasan <adithyas@chromium.org>
> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#702230}

Bug: 1010675
Tbr: lfg@chromium.org
Change-Id: Icbddd9cb318b1bf25678b4e812a62382e953a937
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860297Reviewed-by: Sidney San Martín <sdy@chromium.org>
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705591}

https://boringssl.googlesource.com/boringssl/+log/6a2609dae219e4300dfc62b2a37f10b5c845547b..bc4c09df6416a3a0d0cf321c6c13023c77e2fec4

The following commits have Chromium bugs associated:
  bc4c09df6 Add a function to derive an EC key from some input secret.

Bug: 1010968
Change-Id: I84d0b5bac83df17a747f64f94c24d1368f36c7b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857519
Auto-Submit: David Benjamin <davidben@chromium.org>
Commit-Queue: Alex Chau <alexchau@chromium.org>
Reviewed-by: Alex Chau <alexchau@chromium.org>
Reviewed-by: Steven Valdez <svaldez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705590}

Also needed is [1] in webrtc, which fixes some build warnings. Could
land in parallel.

[1] https://webrtc-review.googlesource.com/c/src/+/156980

BUG=1012850

Change-Id: Ia24e490db5e71cf1add0e10f4c1264aefb69143c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859935
Auto-Submit: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705589}

This was a workaround for a toolchain problem we no longer have --
lld-link has thin static libraries and this is a no-op for it for that
reason already.

Bug: 857060
Change-Id: I98002cf0dbf70e9cfffb880d9c24984bed2ff51d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860034
Auto-Submit: Nico Weber <thakis@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705588}

This patch ensures the open and close events are only called a single
time for the tests in BottomSheetObserver.

Change-Id: I98b1dce25be5aa7e55cdcbead90518954b8747d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857543
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705587}

The SysInfo class will provide Chrome OS version from parsing the
LSB_RELEASE file, so call it on Chrome OS too.

Bug: chromium:1012048
Test: Manual
Change-Id: Iba0e3a6d85005a1429f96c0a2d56eea11f8c465f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848503Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Yves Arrouye <drcrash@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705586}

To avoid too long filenames on Windows.

TBR=johnchen@chromium.org

Bug: 1014132
Change-Id: I062d56c0e75a34f6ce65ae4dffd84a7531e6716e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860499Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705585}

Bug: 1005568
Change-Id: Ibc875c0628e355a06c2e334c9f97c5f4f6715322
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853131
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705584}

The test is making a 3rd-party accessible cookie; we're going to require
those to be secure.

Also fix a bug in the test --- it was trying to append http:// twice.

Bug: 1006816
Change-Id: I0d2cda25892b6633b0bc9c362d735540cde456b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860099
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705583}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I39f8c0d2e1e5052036822ec3804958496a31f2fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860139Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#705582}

It's setting a 3rd-party-accessible cookie, so it must be secure

Bug: 1006816
Change-Id: I1a2511f9f682ddf103beba987d76e013d0b2750a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860102Reviewed-by: Lily Chen <chlily@chromium.org>
Commit-Queue: Maksim Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705581}

Bug: 268984
Change-Id: I6a460108f1cce3c4fd45c243dd254d8877327eb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851928Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705580}

Adds single web state closing test to WebStateList unittests.

Change-Id: If129d6465d3e89047a044eaf8d3e25c8f450b1b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860124
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Auto-Submit: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705579}

These were disabled because they were flaky on 32-bit kernels and some
Linux environments (like Chromecast). Rather than setting up the complex
process hierarchy to have a real ptracer/tracee relationship, just issue
the ptrace calls and test for the right error and/or death.

Bug: 934930
Change-Id: Ib2d97ab25e7931d2b5ba8bd607f9db36184eb4d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856798
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705578}

In order to remove the dependency, the web_fullscreen_options.h file was moved
to third_party/blink/public/common/fullscreen. Since the file is no longer in
the public/web/ directory we are also renaming it to fullscreen_options.h (and
the struct defined in it to FullscreeOptions).

Bug: 1008303
Change-Id: If96a8263b3bb696931ce9af4846f3d6dcbc40698
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852288Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Sergio Villar <svillar@igalia.com>
Cr-Commit-Position: refs/heads/master@{#705577}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/71bbf632..f98ffad2

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I0de18aadff439c3f2d3e9146fc72df8761a52272
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859838Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#705576}

One override of this method was a replacement with an
identical implementation in BubbleDialogDelegateView. The other was
BaseDialogContainer, which is part of the app info dialog.

BaseDialogContainer originally moved *from* using a DialogClientView *to* using
its own ClientView to fix https://crbug.com/445695, which was about the dialog
having a strange default button. Since that time, DialogClientView became
perfectly happy to have no default button, so I think that fix is now obsolete.
That allows BaseDialogContainer to use DialogClientView again, which means most
of the reimplementation of DialogClientView there can be removed.

Unfortunately there is one remaining override of this method, in
AssistantContainerView, so it can't yet be marked final.

Bug: 1011446
Change-Id: I9331e847ec2572b4d6dc5e5e2909882ececd9da8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856538Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705575}

The interval timer could end up racing with the animation update timer,
meaning that the new animation values had not yet been applied when
the |retries| counter reached zero and the assertions were made.
Refactor the test to trigger the next "action" (new pair of clicks or
checking the result) when one of the timed elements listening on the
"b.click" event has begun. Also change |retries| into counting how many
clicks are remaining (rather than how many interval timer firings).

Bug: 1013736
Change-Id: I374cb9c499ca18a791f76dabcb1db8bcd6f38461
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859955Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#705574}

Uses the InfobarDelegate Icon to populate the Banner's icon.

Screenshot:
https://drive.google.com/open?id=1ig7tT72B6mFsqHtrAmDO5ANww6HKEGpj

Bug: 961343
Change-Id: If9b8cddfd41b3cef7bc45e7165234f543b3a681d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857048Reviewed-by: Chris Lu <thegreenfrog@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705573}

https://chromium-review.googlesource.com/c/chromium/src/+/1658231 is't
enough for arm64, because __NR_membarrier (which code is 283) is greater
than MAX_PUBLIC_SYSCALL (which is 279) -> rules was not applied.
Increase MAX_PUBLIC_SYSCALL && add test.

Bug: 966433.
Change-Id: I99ed038dea7b2a332dd70fb75b97d908f5d2ca9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856160
Commit-Queue: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705572}

This CL adds |-willCloseAllWebStates()| and |-didCloseAllWebStates()|
to the WebStateListObserver. This allows observers to know when CloseAll
has been called. This gives observers ability to batch process operations
instead of processing each close individually.

This CL will be quickly followed up with the first use case -- RecentTabs.
In RecentTabs, the close all operation should be batched instead of being
processed one at a time, which causes a UI freeze.

Bug: 994229
Change-Id: I9dd47786c508409690e4a753593505d5da71d11b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854463
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705571}