- 06 Jan, 2021 40 commits
-
-
Dave Tapuska authored
FrameMsg_SetPepperVolume is converted to a message on the PepperPluginInstance channel. BUG=1157519 Change-Id: I507b25b951d1a231e99741ea996ff6ec2f186441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611944 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#840809}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1609945018-70431859900ba317039e4e8fedf6f4732373dd6e.profdata to chrome-win64-master-1609955739-bf9ad8193fca8e166eb0096fb68a4e9db5e69d48.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I553e85c8dfb7b4918389c51b1ec44697a1101793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611215Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840808}
-
David Maunder authored
To reduce QPS to our server which serves shopping metadata, we estimate if the website is a shopping website or not and do not call the server if we do not believe the site is a shopping website (based on the bloom filter). Bug: 1158883 Change-Id: Idc4df439bdfe00d113b2411c364024cfb3bbe383 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594175 Commit-Queue: David Maunder <davidjm@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#840807}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2ca6ad8ed38e..8e3bef4f079d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC collinbaker@google.com,tinazwang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1117773,chromium:1145728 Tbr: collinbaker@google.com,tinazwang@google.com Change-Id: Ic32b7730382bf8e9ecdfd50f08c9b24fbfbfb009 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612479Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840806}
-
Scott Violet authored
HistoryObserverImpl was adding an observer, but never removing it. This leads to a use-after-free when the class is deleted and historyservice notifies observers. BUG=1158388 TEST=none Change-Id: I596fb10791dd9a40743fae86f9e24a60a10d8aa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610991Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#840805}
-
Daniel Hosseinian authored
Add a skeleton document properties dialog element containing the fields when the document properties will get populated. Bug: 93619 Change-Id: Ied7ad9d8301c263cc64e902aa390d86438ac3eeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605971 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#840804}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/cee13faaf357..1bd38fed1b9e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I3c9e32847f3f5fa44ca806d5661c16a6afe74275 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613585Reviewed-by:
-
Jeremy Roman authored
This saves a copy. Bug: None Change-Id: Id48a8cd618527f640af44dc3f7807877213f5fa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597001Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#840802}
-
Mattias Nissler authored
The existing code had a user_id_ check, but that is not sufficient for owner settings writes to go through, the private key must be present as well. Replace the check with a proper IsOwner() check. This misbehavior is only observed in DeviceSettingsServiceTest.Observer, getting exposed by a DCHECK added in [1]. It's hopefully not hit in production (otherwise tentative owner settings might get lost), but better to fix the root cause than avoiding the offending edge case in the test. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2287290/11/chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc#800 BUG=chromium:1073940 TEST=unit tests pass Change-Id: I6d5a5f17e8aeaa28600d57c7f0fcfad661434e33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611720Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Mattias Nissler <mnissler@chromium.org> Cr-Commit-Position: refs/heads/master@{#840801}
-
Daniel Murphy authored
This patch creates the new OnWebAppUninstalled event. Follow up patches will migrate systems that rely on this behavior from OnWebAppWillBeUninstalled to OnWebAppUninstalled. Patch also does a little cleanup in the sync integration tests. Bug: 1162339, 1097050, 1126404, 1111533, 1159651, 1159482 Change-Id: I5081f25f0ad0d4aa9e4245023e8b00845d43d817 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606668Reviewed-by:
Phillis Tang <phillis@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#840800}
-
Wenbin Zhang authored
Clean up on the settings when removing reference build. Bug: chromium:1108663 Change-Id: Ie0a4211b9e3895f1dd84fb4a97cbe3ec1f230666 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612566 Commit-Queue: John Chen <johnchen@chromium.org> Auto-Submit: Wenbin Zhang <wenbinzhang@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#840799}
-
Sky Malice authored
Bug: 1162103 Change-Id: I0d7d17dbbedc52dead61fa79c08c32266bdaf464 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605393Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#840798}
-
Ana Salazar authored
We introduce a new option in the chrome context menu. To draw attention to this feature, we will add a new nudge next to the option. This addition will be controlled by a flag which will be initially activated in 89 stable. Bug: 1156270 Change-Id: I774fec96960eca04299f3afcde69df51b8569d8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613526Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Ana Salazar <anasalazar@chromium.org> Cr-Commit-Position: refs/heads/master@{#840797}
-
Peter Kasting authored
Bug: 1121788, 1122880 Change-Id: Icbaf40c1f58531b929d3670899c3b9e840652608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613546 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#840796}
-
Thomas Lukaszewicz authored
Bug: 1162474 Change-Id: I5a53f3c330ea7a022339cc14d54e3dde967a2a4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606672 Auto-Submit: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#840795}
-
David Black authored
In order to gauge the impact/effectiveness of the holding space welcome banner, record the interval from the time the banner is first shown to the time of the first pin to holding space from the Files app. If the first pin to holding space from the Files app occurs prior to having seen the welcome banner, record zero. Note that this CL also fixes the `metrics.recordValue()` API which was previously unused but was not correctly mapped to the private metrics API's expectations. Bug: 1163237 Change-Id: I416a3f6349163b96aead469b01ef58cc46aaa363 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610939 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#840794}
-
Collin Baker authored
This reverts commit 2d4506ca. Reason for revert: build failure https://ci.chromium.org/p/chromium/builders/ci/win-archive-rel/20860? Original change's description: > Build the BoringSSL command-line tool > > It contains a benchmarking command that should help confirm the > impact of https://chromium-review.googlesource.com/c/chromium/src/+/2595350. > > Change-Id: Id69232190a3b29538162c46568cf12558606fd44 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595253 > Commit-Queue: David Benjamin <davidben@chromium.org> > Commit-Queue: Adam Langley <agl@chromium.org> > Auto-Submit: David Benjamin <davidben@chromium.org> > Reviewed-by: Adam Langley <agl@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840764} TBR=davidben@chromium.org,agl@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I7385f137a68b92becbbe4765b1c67b797211f2b3 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613519Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#840793}
-
cfredric authored
writes and reads. Change-Id: Ib071d8444d8fa67409d69cdaaafd75998db2d35a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611965Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Chris Fredrickson <cfredric@chromium.org> Cr-Commit-Position: refs/heads/master@{#840792}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4dde23fea599..1bd38fed1b9e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I77194ebc1469fcddf66ff88af32f7e1e801054a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612478Reviewed-by:
-
Dominic Mazzoni authored
Note that we have our own dashboards outside of uma.googleplex.com so some automatic rollovers of histograms are not happening. This change also moves the TextToSpeech histograms to the accessibility/ subdirectory from other/, as we're the same team that owns those. Bug: 1153776, 1153775, 1153725, 1153724, 1153722, 1153717, 1153719 Change-Id: I24c2d313a63457060f5513a365eda41c5ef27240 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605566 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
-
Chait Pinnamaneni authored
Request headers will show empty decoded data https://i.imgur.com/dwRxcMK.png Bug: 1160346 Change-Id: Idd7fef49f8f3ead4736f253c9dead61c5ff2d1ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605396 Commit-Queue: Chait Pinnamaneni <cpinnamaneni@microsoft.com> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Reviewed-by:
-
Bo Liu authored
This is generating a significant number of crash reports that it's affecting ability to evaluate other crashes. There are reports from beta already, so going to remove the DumpWithoutCrashing and merge it before hitting stable. Bug: 1142569, 1037760 Change-Id: Id91b95a385ee91e0e065ec46e5f25a779f6e0c35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612525Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#840788}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/a84acc4fcca8..f1fa60b91230 2021-01-06 senorblanco@chromium.org Use Jamie's 7-layer burrito of Vulkan DEPS. 2021-01-06 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from e6e704145b31 to 40b4928a73b7 (11 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC enga@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: enga@google.com Change-Id: I3fc54132192f7765a63e045db83300eb900d9252 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612841Reviewed-by:
-
Wei Li authored
When a signin dialog is created with modal type MODAL_TYPE_CHILD, it uses a web modal dialog paenting to its browser window. For this dialog, the shadow would be the standard bubble shadow. Specifying SMALL_SHADOW or BIG_SHADOW has no difference. So change to use the more standard SMALL_SHADOW, and will eventually remove all BIG_SHADOW usages. Bug: 940027 Change-Id: Ic23e533f502b764a0b857ddec01a90289ed2ba68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611639Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#840786}
-
David Bokan authored
Overlay scrollbars are enabled based on platform, though without a user option (in Chrome UI), so the runtime feature enabling/disabling them must remain. However, the about:flag has been expired since M76 and can be removed. Change-Id: Id9269637369e393556937cb2b231646eed202e16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602895 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#840785}
-
Jeffrey Young authored
Previously an ambient mode settings update was issued as soon as the settings page was loaded. This is due to a change listener on temperature unit activating after fetching initial settings. New behavior only issues update settings request if temperature unit setting has changed. BUG=b:165098195 TEST=unit_tests --gtest_filter=AmbientModeHandlerTest.*Temperature* Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Change-Id: I63683bd6e150db4e235ca92287f7f8e0e3233d30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602433 Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#840784}
-
Yuke Liao authored
This CL supports --tast-vars in build/chromeos/test_runner.py to allow specify runtime variables to invoke Tast tests, and the immediate use case is to support running Lacros tast tests on Chromium CI. Bug: 1158590 Change-Id: I231e0960fb9e7737b97f5be6041d295f9f5b1b18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2604299Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#840783}
-
Mathias Bynens authored
Previously, we created a wrapper <div>, added an `id` attribute to the <input type=checkbox>, and added the corresponding `for` attribute to the <label>. This patch simplifies the implementation as follows: - We get rid of both the `id` and `for` attributes by wrapping the checkbox and the text label inside of the <label>. - We then also get rid of the wrapper <div>. This simplifies the code and reduces the resulting DOM size. This patch also improves the UI: now, the entire horizontal bar can be clicked to toggle the checkbox, as opposed to just the checkbox itself + the text label (whose length is variable, based on the user’s locale + font sizing/zoom preferences). Tests: autoninja -C out/Release blink_unittests out/Release/blink_unittests --gtest_filter=HTMLViewSourceDocumentTest.* Bug: chromium:920571 Change-Id: I42873f62d94b264a1b7edf3567e539301be07ed1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598907 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#840782}
-
Alex Newcomer authored
Add some metrics which will allow us to understand performance and possible issues on different devices. Change-Id: I12077149d56303b0241add20e4613ff3eb62a1e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587656Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Auto-Submit: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#840781}
-
Findit authored
This reverts commit cd5cde24. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 840681 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vY2Q1Y2RlMjRjMzVlMWM5MmY5YjQxYTUyODdkY2Q0YjZlODZkNzY2Ygw Sample Failed Build: https://ci.chromium.org/b/8858820663595122608 Sample Failed Step: weblayer_browsertests Sample Flaky Test: SubresourceFilterBrowserTest.ContentSettingsAllowlist_DoNotActivate Original change's description: > [Subresource Filter] Add content settings-based adjustment to WebLayer > > This CL incorporates Chrome's adjustment of subresource filter page > activation decisions based on content settings within WebLayer. To do > so, we have the shared SubresourceFilterSafeBrowsingActivationThrottle > directly invoke the logic in question rather than having > ChromeSubresourceFilterClient do so. That change necessitates some > others, also made in this CL: > - WebLayer brings up ProfileInteractionManager. > - SubresourceFilterClient provides an accessor for > ProfileInteractionManager. > - SubresourceFilterSafeBrowsingActivationThrottle calls the adjustment > logic via a new Delegate interface rather than doing so via > SubresourceFilterClient. This interface is implemented by > ProfileInteractionManager in production while allowing for porting of > tests that provide custom (or nil) stub logic. > > We also add browsertests of this interaction in //weblayer. > > Note that this CL does not do any incorporation of the relevant *UI* > for content/site settings of ad blocking in WebLayer; that will be > followup work. > > Bug: 1116095 > Change-Id: I394e62f12d5209a4302ffa57de9095c861b59613 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603574 > Commit-Queue: Colin Blundell <blundell@chromium.org> > Reviewed-by: Charlie Harrison <csharrison@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840681} Change-Id: Ifda417fda7229cd6c7eca17174b65cdf6d314193 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1116095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611616 Cr-Commit-Position: refs/heads/master@{#840780}
-
Xing Liu authored
We should expect ReadingListManager::Add to return nullptr when the title can't be parsed as UTF strings, or the URL scheme is not http or https. Bug: 1157808,1163225 Change-Id: I1d4e9ceb74f2821bda19907936d43919c8cc9dbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611628Reviewed-by:
-
Cattalyya Nuengsigkapian authored
- save a workspace in window's property. - trigger saving to browser session when property is updated, but need force saving in `WindowOpened()` for newly created window. - restore each window to the right desk by assigning to the right parent desk container in `GetDefaultParentForWindow()`. - resolve desk activation conflict between browser session and an active desk restore by checking `IsSessionRestoreInProgress()` in ash to avoid every single window activation during restore. - resolve the parent desk conflict between the first restored window and a blank window by stop reusing the blank window for restore and always create a new window during restoration. - resolve clobbering tab restore by passing null browser when using desks restore feature. - add browser tests checking that each window restore to the parent desk if DesksRestore enabled, otherwise to the first desk, which is a default active desk after a crash. `browser_tests --gtest_filter=*SessionRestoreTestChromeOS*` Bug: 996999 Test: Manual test (a video in crbug comment 27) and browser tests Change-Id: I0f9202e10a7b861a676725e7390b15fd71a00933 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572316 Commit-Queue: Cattalyya Nuengsigkapian <cattalyya@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#840778}
-
David Van Cleve authored
When executing "platform-provided" trust token issuance requests (https://bit.ly/platform-provided-trust-tokens), TrustTokenRequestIssuanceHelper makes a delegate call that eventually gets ferried to the content embedder and comes back with a FulfillTrustTokenIssuanceAnswer::Status, which is (currently) a tri-state representing "success," "operation not supported," or "error". Logging this in TrustTokenRequestIssuanceHelper will let us evaluate the proportion of attempts at executing platform-provided trust token issuance that have sufficient embedder support, which, as the linked design doc describes, is a useful liveness metric to monitor during the feature's preliminary experiment launch. This CL adds a new metric recording this status; to test that the metric is logged correctly, the CL modifies existing platform-provided issuance unit tests in trust_token_request_issuance_helper_unittest and adds HistogramTester assertions. Fixed: 1162976 Change-Id: I492b5e9b95d19d51206cd85bb87351df5a76f74a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610285Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org> Auto-Submit: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#840777}
-
Collin Baker authored
ConvertJPEGDataToImageSkiaAndNotifyObservers() copies ThumbnailImage::data_ (which is a scoped_refptr) and posts a task referring to it to another thread. ThumbnailImage::ClearData() cleared the data behind the pointer before resetting the pointer. This led to a race condition where the data was being cleared on the UI thread and read on a background thread without synchronization. This CL simply resets the pointer in ThumbnailImage::ClearData() without modifying the wrapped data. As long as the data inside is treated as immutable, this is safe: updating ThumbnailImage::data_ does not change data that outstanding tasks see. Fixed: 1160146 Change-Id: I5ef9e1712cc5935f85d1b8d9226588cc43921b67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611174Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#840776}
-
Mei Liang authored
This reverts commit c5868cd1. Reason for revert: root cause for crbug.com/1163561 Original change's description: > [Android] Test account management view for child account > > This CL adds two render tests for account management view in child > account mode when the sign-out option should be hidden. > > Bug: 1045525 > Change-Id: I9e53396fe642c78eaa37dd04457cfcf72730109e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597553 > Reviewed-by: Tanmoy Mollik <triploblastic@chromium.org> > Reviewed-by: Victor Vianna (OOO 21/12-05/01) <victorvianna@google.com> > Commit-Queue: Alice Wang <aliceywang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840107} TBR=triploblastic@chromium.org,victorvianna@google.com,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,aliceywang@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1045525 Change-Id: Id37caf103ae1e4122d580b99a19556466972a086 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612373Reviewed-by:
Mei Liang <meiliang@chromium.org> Commit-Queue: Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#840775}
-
John Lee authored
This CL updates each card in the Settings page such that rows that may appear at the very top of the card to not have top borders to prevent double borders caused by a top border and the card's shadow. Bug: 997034 Change-Id: Ie6337d9f08c094c712aaac8e73b3c3ab6c8f84c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601332Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#840774}
-
Joshua Pawlicki authored
Bug: 1163625 Change-Id: Icc09ec86b33393670cce2aa39265f2fc1b473a77 Fixed: 1163625 TBR: sorin@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611292Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#840773}
-
Joe DeBlasio authored
This CL is a small change to announce the arrival of a MIX-DL alert to accessibility devices. We don't have testing infrastructure for accessibility in the downloads shelf right now, and this is a trivial change, so it's submitted without tests. I manually verified that this works as expected on Mac OS. Fixed: 1131084 Change-Id: Ie68a4f6ed5f71a25553deb2a776a7dcd3adf30a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606669Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#840772}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/32d68537a88c..b746b1f59851 2021-01-06 reed@google.com Pass sampling to surface.draw 2021-01-06 kjlubick@google.com [canvaskit] Fix examples with makeShaderCubic 2021-01-06 johnstiles@google.com Avoid emitting duplicate constant values in SPIR-V. 2021-01-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from 069b8f699b59 to 8247d3c2481b (1 revision) 2021-01-06 robertphillips@google.com Add GrDDLTask::dump method 2021-01-06 ethannicholas@google.com Refactor some IRGenerator functions 2021-01-06 egdaniel@google.com Track resources on GrVkCommandBuffer as sk_sps. 2021-01-06 egdaniel@google.com Move GrcommandBufferRef.h to more generic GrRefCnt.h 2021-01-06 robertphillips@google.com Fix DefaultGeoProc member variable names 2021-01-06 egdaniel@google.com Add workaround to use full screen loads for vk discardable msaa. 2021-01-06 nifong@google.com Accept a callback used in MultiPictureDocument::endPage 2021-01-06 jcgregorio@google.com Include svg module in Doxygen generated output. 2021-01-06 johnstiles@google.com Clean up constructors for SkSL Literal types. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC johnstiles@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: johnstiles@google.com Change-Id: Ib4e60971a4b6f69ee2dc8830e27e3d7a80b35209 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611415Reviewed-by:
-
Guillaume Jenkins authored
Adds logic to the Sync & Google Services view mediator to disable the sign-in button when browser sign-in is disabled by policy. The info button's popover menu explains that sign-in is disable by the managed browser's organization, and provides a link to the chrome://management page for more information. No special handling is needed for the mobile identity consistency experiment because when it is enabled, the sign-in entry point in Google Services is removed from the UI. Screenshots of the new UI when sign-in is disabled: https://screenshot.googleplex.com/38iQWPYitD7hKCo https://screenshot.googleplex.com/4ozvEWnJLqdnzsY Bug: 1155745 Change-Id: I9348e6ae724d40ab8b38c39f45726bac0c8f5fa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594011 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#840770}
-
