- 26 Jun, 2020 40 commits
-
-
Javier Ernesto Flores Robles authored
Log `localizedDescription` instead of `description`. Log the code of the error. Bug: 1091927 Change-Id: Iea21882a5847741fbe19196549c2deeda4f24234 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270440 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#783050}
-
Mario Sanchez Prada authored
Following up on the steps of crrev.com/c/2254025, we can also remove the code in BlinkAXTreeSource that sets the |routing_id| field of the AXContentTreeData that will be sent to the browser process as part of an AXContentTreeUpdate structure, since we can easily get the same information in RFHI when the message arrives in the other side. Since this |routing_id| field was the only part of AXContentTreeData that was not included in ui::AXTreeData already, this change allows us to completely drop AXContentTreeData from the codebase along with all the related .mojom and *_traits.{h,cc} files, which gets us one step closer to the objective of crbug.com/1094150. Bug: 1094150 Change-Id: Icc3161ed9e13a8215d99d29cf6d05c66f33418e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260776Reviewed-by:Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#783049}
-
Xiaohui Chen authored
Bug: None Change-Id: I906c85c64f30e3bce4782225cf52c5a25cf470eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268458Reviewed-by:
David Black <dmblack@google.com> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#783048}
-
Alan Screen authored
Out of process handling of metafile composition can have artifacts due to mismatch selection of font typeface of default system fonts. Avoid this by serializing typefaces with the other picture display lists of the metafiles so that the exact same font is used in composition. Bug: 1044996 Change-Id: I0dc9e8e03bc7d39c36381d125a3b2b612b191f5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123108 Commit-Queue: Alan Screen <awscreen@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#783047}
-
Hirokazu Honda authored
This fixes a wrong DCHECK condition due to the typo. Bug: None Test: video_decode_accelerator_tests for vp9 k-SVC built with --dcheck_always_on=true Change-Id: I00a682f4d3e642064ca8f00bff69dc799c062722 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269602 Auto-Submit: Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#783046}
-
Nate Chapin authored
While in the neigbhorhood, simplify DOMWindow::DoPostMessage and don't use Document where the window suffices. Bug: 1029822 Change-Id: I31ad50e6f758b3f706d90da60d3df53ccd3c3838 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268258Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#783045}
-
Alan Screen authored
When adding typeface serialization for out of process metafile composition the renderer processes will try to cache the typefaces so that they are transmitted only once instead of on every page they are used. This will create a new dependency for internal processing within the print compositor service. If a page to be composited requires subframes and is delayed until they complete, then subsequent pages will also need to wait since they could be dependent upon typefaces included in this earlier page's metafile stream. This change is part of the needed support to eliminate imaging artifacts from mismatched fonts which can happen when typefaces do not get serialized with the pictures. Bug: 1044996 Change-Id: I2730b6130be7fe74da7c2b93f0f52f3995f97dba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2266030Reviewed-by:
-
Nico Weber authored
This reverts commit aae3a263. Reason for revert: breaks fuchsia_x64 on cq, crbug.com/1099786 Original change's description: > Sync: Delete ModelTypeHelper.java > > It was part of the old invalidations implementation, and not used > anymore. > This was the last reference from sync to third_party/cacheinvalidation, > so all references to that are also removed from BUILD.gn and DEPS > files. > > Bug: 1099672 > Change-Id: I3491fa1cea04d0deebe68988cd3af5a5a4da1afb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270182 > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > Auto-Submit: Marc Treib <treib@chromium.org> > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#783025} TBR=treib@chromium.org,mastiz@chromium.org Change-Id: I463dd6d98c8b2c93734628557c01c376b231b62f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1099672 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269746Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#783043}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e6c33eabe079..e922953cabe4 2020-06-26 robertphillips@google.com Adjust how GM::gpuSetup is handled in the tools 2020-06-26 bsalomon@google.com Add async rescale and read APIs to SkImage. 2020-06-26 michaelludwig@google.com Use GrMatrixEffect in gradients instead of GrCoordTransform 2020-06-26 fmalita@chromium.org [skrive] Rectangle support 2020-06-26 reed@google.com Revert "Revert "clean up after big refactor of SkColorFilter --> ...Base"" 2020-06-26 adlai@google.com Reland "Consolidate GrDrawingManager <-> GrRenderTask lifecycle" 2020-06-26 robertphillips@google.com More *ooprddl GM changes 2020-06-26 robertphillips@google.com Make gpuSetup draw a error message on failure If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: I198ab6564c03e44ed881a9ddf02edaf136a55f6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269998Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#783042}
-
Charlie Reis authored
This CL updates the description of SiteInstance and the various process models now that Site Isolation has launched. It also separates the notions of the ideal abstraction (agent cluster represented by principal and browsing context group) from the practical implementation (where the definition of "site" varies by process model). BUG=1015882 Change-Id: I93a8d495ea3ab8dc69a5446d83dd841ee9fae64c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256605 Commit-Queue: Charlie Reis <creis@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#783041}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/cba0d2713ec8..397cece951f6 2020-06-26 chrome-bot@chromium.org Update config settings by config-updater. 2020-06-26 chrome-bot@chromium.org Update config settings by config-updater. 2020-06-26 kimjae@chromium.org OWNER: Add AU Owners for build_dlc* 2020-06-26 chrome-bot@chromium.org Update config settings by config-updater. 2020-06-25 mmortensen@google.com query_build_logs: support case-insensitive queries. 2020-06-25 bpastene@chromium.org chrome_chromeos_lkgm: Run LKGM updates on normal CrOS bots. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I6829d0778e22c84421caa986e4cdb6c5f840c3ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270526Reviewed-by:
-
chrome://nearby-internalsJuliet Levesque authored
Add a tab that will eventually display Nearby-related logging. See the following screenshot for display: https://screenshot.googleplex.com/rWNCYHoapn3. Bug: 1093634 Change-Id: I61b291c20e3563c88a64e398b4320403496f7e18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246557 Commit-Queue: Juliet Levesque <julietlevesque@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#783039}
-
Ryo Hashimoto authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/bd15beb76e99..1609e471b69a $ git log bd15beb76..1609e471b --date=short --no-merges --format='%ad %ae %s' 2020-06-22 hashimoto arc: Add a new D-Bus service arc-sensor-service Created with: roll-dep src/third_party/cros_system_api Bug: b:148764483 Test: build Change-Id: I4a18e48884418289d3dc13f31dcb3860834f7198 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2266193 Auto-Submit: Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#783038}
-
Hitoshi Yoshida authored
CookieListItem is an IDL dictionary which is used as an output parameter. It has two nullable members, but their values were not set if they were null. This CL explicitly sets null values if it is expected. Bug: 839389 Change-Id: I29b4bf81a3db72835617c16f7b3120c1d2be9409 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269381 Auto-Submit: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Reviewed-by:
Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#783037}
-
Sophie Chang authored
Bug: 1099371 Change-Id: I0edd393a1841ef06d98443bdb90fa1a621d7deb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2266919Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#783036}
-
Manoj Gupta authored
Enable '-fsplit-lto-unit' flag for Chrome OS since CrOS clang supports this option. Bug: 924362 Change-Id: Ic1724ed2c1a4d43d55a217c9e1bc2dc998c2dde2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268840Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Manoj Gupta <manojgupta@chromium.org> Cr-Commit-Position: refs/heads/master@{#783035}
-
Fabian Sommer authored
This CL adds a new API function that enables extensions to proactively update the list of certificates provided by them. Browsertests test three different extension configurations: - An extension that does not use the new function. - An extension that is providing certificates both with the old onCertificatesRequested interface and with the new function. - An extension that is only using the new function. Fixed: 1067683 Change-Id: If2cb537f11ae00788af470fbaecab368e5307310 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2190753 Commit-Queue: Fabian Sommer <fabiansommer@chromium.org> Reviewed-by:Polina Bondarenko <pbond@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#783034}
-
Yaron Friedman authored
GoogleUpdate.InfoBar.InternalStorageSizeAvailable was redundant and removed. Extended ChromeBrowserProvider by another year (until L is gone). BUG=1088813,1084078,1036910 Change-Id: I51e85bc381e1e894142346f6a0f4445ec970085b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267926Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#783033}
-
Gavin Williams authored
Bug: 1059607 Change-Id: Ic739122265f8ba6b67b72decd705ef287dc72120 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270111Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#783032}
-
Francois Beaufort authored
This CL moves pan_tilt_zoom_allowed from MediaStream to MediaStreamTrack for consistency with existing pan, tilt, zoom MediaStreamTrack values. Bug: 934063 Change-Id: Iaa107290100393c51d7309e140adacd24c9e5dfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270301 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#783031}
-
Milica Selakovic authored
Form digest was not aware of real url, that led that matched forms were not proceed correctly. This CL fix issue and add test. Test for other WebsiteLoginManager methods will be added in separate CL. Bug: 1090286 Change-Id: I910b02d4ddd82e213eb3baaceb5f055a1d9b36f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267078 Commit-Queue: Milica Selakovic <selakovic@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#783030}
-
Esmael El-Moslimany authored
The most-visited are populated by history segments which are created for URLs typed in the omnibox (ui::PAGE_TRANSITION_TYPED) and URLs that are loaded from top Chrome bookmarks (ui::PAGE_TRANSITION_AUTO_BOOKMARK). https://source.chromium.org/chromium/chromium/src/+/master:components/history/core/browser/history_backend.cc;l=423;drc=b5056af54caa3a56c0d748bd39d0803ae0312a9b The segments keep a |visit_count|. The segment entries are used to query the top sites from the last 90 days. https://source.chromium.org/chromium/chromium/src/+/master:components/history/core/browser/top_sites_impl.cc;l=241;drc=df87046cb8ae4dbd62cda6e56d317016a6fa02c7 https://source.chromium.org/chromium/chromium/src/+/master:components/history/core/browser/history_backend.cc;l=464;drc=b5056af54caa3a56c0d748bd39d0803ae0312a9b https://source.chromium.org/chromium/chromium/src/+/master:components/history/core/browser/visitsegment_database.cc;l=168;drc=df87046cb8ae4dbd62cda6e56d317016a6fa02c7 The visits to the most-visited on the Android NTP use ui::PAGE_TRANSITION_AUTO_BOOKMARK which means if a user taps on a most-visited tile, the segment's |visit_count| will be incremented. crbug.com/620296 was created so the remote and local NTP would work the same as the Android NTP (most-visited tile clicks will increment the associated segment's |visit_count|. The way this was accomplished was by altering the link navigations when the current site URL has the origins chrome-search://local-ntp or chrome-search://remote-ntp. The transition was changed from ui::PAGE_TRANSITION_LINK to ui::PAGE_TRANSITION_AUTO_BOOKMARK so the navigation would be considered as starting a segment. https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/chrome_content_browser_client.cc;l=1828;drc=c3de1340119b5e6e76cc34248f3310ea05dfaf6f chrome://new-tab-page is replacing chrome-search://local-ntp/local-ntp.html. If adding the transition override for link navigations from the local NTP is still justified, this CL does the same for chrome://new-tab-page. Bug: 1089877 Change-Id: Ib6bea5d04ff95a4c20aaf5d8e90dd857719d83a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247101Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#783029}
-
Maksim Sisov authored
This patch adds for usage of ozone platform in //gpu. And changes the following patterns: #ifdef(USE_X11) DoXxx(); #endif to #ifdef(USE_X11) if (!IsUsingOzonePlatform()) DoXxx(); #endif and #ifdef(USE_OZONE) DoXxx(); #endif to #ifdef(USE_OZONE) if (IsUsingOzonePlatform()) DoXxx(); #endif ----- Please note that this ugliness is added temporarily and will be removed as soon as use_x11 is removed (hopefully by Q1 2021 depending on how the finch trial goes). Please also note that it's impossible to build use_x11 && use_ozone without some hacks in PlatformCursor code. The changes to that are on their way to upstream. ---- Bug: 1085700 Change-Id: Ic947aae6d6f78d9ae037ee610ab9c0605a28ff8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250204Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#783028}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4b4651dbc255..f0a989ef6bd6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC domfc@google.com,droger@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1085419 Tbr: domfc@google.com,droger@google.com Change-Id: I38870a06edd3a2965be049534a1e4f855010a4ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270524Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#783027}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I7db6b00af3af74e2d9155a124870c5aaa58b6ca8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270115Reviewed-by:
-
Marc Treib authored
It was part of the old invalidations implementation, and not used anymore. This was the last reference from sync to third_party/cacheinvalidation, so all references to that are also removed from BUILD.gn and DEPS files. Bug: 1099672 Change-Id: I3491fa1cea04d0deebe68988cd3af5a5a4da1afb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270182 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#783025}
-
Avi Drissman authored
For the Mac, it's clear what program the task manager window belongs to. Therefore, don't put the name of the app in there. Bug: 1098314 Change-Id: I6049c97e3336c6a47055dc7ee3ba352315f725e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261032 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#783024}
-
Lukasz Anforowicz authored
This CL removes callers of blink::Platform::CreateDefaultURLLoaderFactory to help with eventual removal of this virtual method from blink::Platform. This CL relies on an earlier https://crrev.com/c/2261419, which provides a way to get the singleton WebURLLoaderMockFactory. This CL uses the singleton mock factory to construct WebURLLoaderFactoryWithMock (instead of going via blink::Platform::CreateDefaultURLLoaderFactory) in the following places: - TestWebFrameClient::CreateURLLoaderFactory - DummyLocalFrameClient::CreateURLLoaderFactory - TestLoaderFactory's constructor Additionally, this CL further tweaks PingLoaderTest, so that it doesn't go through TestingPlatformSupport::CreateDefaultURLLoaderFactory, but instead also directly constructs a WebURLLoaderFactoryWithMock. Also, this CL has to tweak ResourceLoaderDefersLoadingTest which before this CL depended on TestLoaderFactory going via Platform::CreateDefaultURLLoaderFactory and ending up in ResourceLoaderDefersLoadingTest::TestWebURLLoaderFactory::CreateDefault... After this CL, the ResourceLoaderDefersLoadingTest::CreateFetcher method directly constructs a ResourceLoader that wraps the test data (e.g. |bool web_url_loader_defers_| and ProcessCodeCacheRequestCallback). After this CL, ResourceLoaderDefersLoadingTest no longer needs to override Platform methods. Similar changes are needed in ModuleScriptLoaderTest, WorkletModuleResponsesMapTest and ResourceFetcherTest. After this CL and after https://crrev.com/c/2250081, there should be no more callers of blink::Platform::CreateDefaultURLLoaderFactory - this method can be removed altogether in a follow-up CL: https://crrev.com/c/2264503 Bug: 751425, 891872 Change-Id: I9190d4012ad8d1eb2ce554239265d46c2de52cf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260778 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
-
Steven Bingler authored
https://crrev.com/c/2252280 missed updating a couple histograms. This CL fixes that. Bug: 1085168 Change-Id: I0dc05cc73840fe80b220e0c809ad23992dd34b00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269791Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Steven Bingler <bingler@chromium.org> Cr-Commit-Position: refs/heads/master@{#783022}
-
Luke Zielinski authored
fails TBR=robertma@chromium.org Change-Id: I61ed9aaf3fc0eb8163014a710ed1f750b07fd8c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270597Reviewed-by:
Luke Z <lpz@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#783021}
-
Xiyuan Xia authored
Bug: 1021774 Change-Id: Ie782cf0c74e51f04fab379983ecffe9e21ae4750 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268499Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#783020}
-
Lindsay Pasricha authored
This reverts commit 3293e946. Reason for revert: AddAccountSigninManagerTests are failing again Original change's description: > Reland "[iOS] Remove unused ChromeIdentityInteractionManager APIs." > > This reverts commit 11f8ce83. > > Reason for revert: Landed the fix to SigninCoordinator EarlGrey tests > in patch 2264057. > > Original change's description: > > Revert "[iOS] Remove unused ChromeIdentityInteractionManager APIs." > > > > This reverts commit 053f6124. > > > > Reason for revert: > > AddAccountSigninManagerTest fail on iOS 12: > > https://ci.chromium.org/p/chrome/builders/ci/iphone-device/9356 > > Bug: 1078815 > Change-Id: Iba786bb1caa7dbbb1b8aa3c4d2feeb5e24674922 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270085 > Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> > Reviewed-by: Jérôme Lebel <jlebel@chromium.org> > Reviewed-by: Nohemi Fernandez <fernandex@chromium.org> > Cr-Commit-Position: refs/heads/master@{#783001} TBR=jlebel@chromium.org,fernandex@chromium.org Change-Id: Ic3884c804f6ce91240a3d15e4c8134ae255fc498 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1078815 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270617Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Cr-Commit-Position: refs/heads/master@{#783019}
-
Bruce Dawson authored
As the chrome_exe_manifest gains new uses the comment should be maintained. This change acknowledges the addition of the segment heap tag. Bug: 1014701 Change-Id: I2dc3fbf1b3678ee21fa3695b75c4ad5ba13e7a1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268225Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#783018}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4b744d80038c..711a56c023b5 2020-06-26 hjd@google.com Merge "ui: Escape search queries" 2020-06-26 hjd@google.com Merge "ui: Make deploy script print usage on bad arg" 2020-06-26 khokhlov@google.com Merge "android_proxy_power: Choose power profile based on device name" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ib453de31e5adcc1f901d6ccf68b4ce0cb4acd168 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270527Reviewed-by:
-
Jesse McKenna authored
This change removes a confusing portion of the Clangd documentation that recommended using a prerelease version "further down on the Releases page". This was the case when written, but is no longer true (newer prereleases are further up on the page). Change-Id: Ib9d7ff1a6bcacf9f8f2afebd10b260afd0f5b72a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267723Reviewed-by:
-
Antonio Gomes authored
... instead of WebMediaStreamTrack. This is part of the effort to reduce the needless use of public Blink APIs (wrappers) within renderer/modules. BUG=704136 R=guidou@chromium.org Change-Id: Id5035c4c21f66198127d7c975583e40a82e51ba2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256774 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
Sylvain Defresne authored
When working in the Xcode project generator part of gn, it is useful to run setup-gn.py to check that the changes do not break the Chrome on iOS developers' workflow. Add a parameter to the script since by default gn comes from depot_tools as a script that uses //buildtools/mac/gn which is maintained by cipd (and readonly). Bug: 619921 Change-Id: Iecd221893966e435cb538463fa48b94a8a6aa774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270204 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#783014}
-
Avi Drissman authored
Switch to more inclusive terminology in browsing_data. In fact, the way the terminology was used was confusing, as it was backward from the usual use. Therefore switch to "delete" or "preserve" as those are consistent no matter what perspective the deletion is considered from. Bug: 1097355 Change-Id: If4f45c5f816b091611cfe32780aa330ff98a0d6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265403 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#783013}
-
Andrew Grieve authored
There is an upcoming migration that will move component information OWNERS -> METADATA.chromium See: https://chromium-review.googlesource.com/c/chromium/src/+/2248340 For the interim, support both. Bug: None Change-Id: Icb03b8b7b69a509f760c3b15a69f2d16eec3801d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269698 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#783012}
-
Andrew Grieve authored
E.g. I use out-gn/, and for me this change makes licenses.py run in 1.5 seconds rather than 3 seconds. Our .gitignore ignores all top-level out* directories, so this script should do the same. Bug: None Change-Id: I78cd1fea4c23d4990d52d2d521a41fe2267a2be6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269317Reviewed-by:
-
