GitLab

From histogram data, they are 100% renderable on all Mac.

Avoid runtime check, where CheckFramebufferStatus() hangs
from time to time.

Also, limit this to AMD/Intel/Nvidia GPUs.

BUG=1127387
TEST=bots
R=kbr@chromium.org

Change-Id: If7567f3410090241c2ab861b93bd45c117051c6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436386Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811863}

This CL makes FakeSafeBrowsingService::ClearCookies call
the callback it is given, fixing BrowsingDataRemoverImplTests
when Safe Browsing is enabled by default.

Bug: 1028755
Change-Id: Id586113c49a62133de4568b3dce35b9cdf17cae3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438733
Commit-Queue: Ali Juma <ajuma@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Auto-Submit: Ali Juma <ajuma@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811862}

The shaders were originally copied from VR Browser, and AR
mode doesn't need support for a border region. Remove that
to simplify it.

Change-Id: I5ac59e32e4b029e6f94d54a64a1638a7df92f758
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438610
Commit-Queue: Klaus Weidner <klausw@chromium.org>
Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
Auto-Submit: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Piotr Bialecki <bialpio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811861}

I'm doing a series of cleanups on ChromeActivityTestRule.
1. ActivityTestRules are supposed to take in the exact class to be
launched - we hack around this in ChromeActivityTestRule, but we really
don't need to and it's confusing for those familiar with
ActivityTestRule. To this end I plan to prevent directly using
ChromeActivityTestRule in favor of derived classes specific to the
Activity you actually want to launch.
2. (Almost) All existing usage of ChromeActivityTestRule is actually
using ChromeTabbedActivity, and so should be using
ChromeTabbedActivityTestRule.
3. A bunch of functions on ChromeActivityTestRule only apply to
ChromeTabbedActivity, so I'll be moving the functions to
ChromeTabbedActivityTestRule instead.
4. Right now some types of ActivityTestRule will finish the Activity
between tests, and some won't (for batched tests). I intend to make this
behavior consistent for all ActivityTestRules.

This change kicks this off by deprecating the public
ChromeActivityTestRule constructor and migrating some of the usages.
A few followups will get the remainder of the usages as there are many.

Bug: 989569
Change-Id: Ia16a252f0d77a053dc9e1733d52d8ea290574a48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435724Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811860}

This reverts commit b2925a91.

Reason for revert:  The re-enabled test is failing on several android builders

Original change's description:
> Wait for GPU initialization completion
>
> In RTC video decoder factory, wait until initialization of GPU is
> finished before querying supported formats and creating a decoder.
> Timeout is configurable via RtcDecoderSupportTimeout field trial.
> The feature is enabled by default. The default timeout is 10 seconds.
>
> Bug: 1047994
> Change-Id: I9d827507664228f903e4ce46e2949785b13192ba
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411935
> Reviewed-by: Guido Urdaneta <guidou@chromium.org>
> Reviewed-by: Dan Sanders <sandersd@chromium.org>
> Commit-Queue: Sergey Silkin <ssilkin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#811143}

TBR=fdoray@chromium.org,sandersd@chromium.org,guidou@chromium.org,chromium-reviews@chromium.org,etiennep@chromium.org,ssilkin@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1047994
Change-Id: I19aec959a1542425d747b58acafdcaab3721b6aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438570Reviewed-by: Patrick Noland <pnoland@chromium.org>
Commit-Queue: Patrick Noland <pnoland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811859}

Bug: 646113
Change-Id: Ie687bd9a3930d2cf5edbf39a019df717d93263a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436384Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811858}

Extends Signin.AndroidGetAccountIdsTime, Signin.AndroidGetAccountsTime,
Signin.AndroidGetAccountsTimeUiThread to M89.

Bug: 1089513
Change-Id: Ib1de4de350bdce417727ea11ff04d3893402c44a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435231Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811857}

base::LazyInstance is deprecated.

Change-Id: Ic8b37b335004ae0c5cd3cad1c82cb06f25551499
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438575Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811856}

The target is running on following bots and I've checked the tests are
stable.
Lollipop Tablet Tester
Lollipop Phone Tester
Marshmallow 64 bit Tester  
Marshmallow Tablet Tester
android-arm64-proguard-rel
android-marshmallow-x86-rel-non-cq
android-pie-x86-rel 

Bug: 1117345
Change-Id: Ide487d7b48454d5779f03ff95106aeb66891deb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437229Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Sven Zheng <svenzheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811855}

The test has been flaky since it was introduced. See bug for details.

TBR=ssid@chromium.org

Bug: 1133434
Change-Id: I7ecb38170912745d7b86fc3128b1601c8e6537e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438969Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811854}

This is an attempt to reland
https://chromium-review.googlesource.com/c/chromium/src/+/2414847
after a couple of changes:
* obviously, remove the dependency on WinRT, which is not available
on Windows 7.
* refactoring how the WRL module is configured at build time.
* cleaning up headers a bit.

The issue with the crashing code is that on the RPC client side
of the updater, both update and control services must be instantiated.
They both called WRL::Module::Create, which caused WRL code to assert.

The server side of RPC also initializes the module, in a slightly
different way. Therefore, module initialization in the App base
class is not practical. It has to be done in a way specific to
the client, or the server, or the mode App is instantiated as.

Using a leaky singleton is not great. However, there is singleton
already in the WRL::Module, so a leaking singleton in the updater
just shows that fact.

Bug: 1128748
Change-Id: Ib198161e2dda81d780658e7ee51157f7f13f0f98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432131
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811853}

Make sure surrounding whitespace, like a trailing newline, doesn't
fail the probe.

Bug: 1115731
Change-Id: I0acc753c7dd04dfa519b7a773870f5f2fdeb1d5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432210Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811852}

This CL is merging the TtsControllerTestHelper class into a
base testing::Test class.

Tests are converted to use that pattern:
  TEST_F(TtsControllerTest,...)

The goal of that cleanup is to simplify the next refactoring
where a content::BrowserTaskEnvironment is required for each
test.

Change-Id: Id3757b58fc05a93ac6ebacdf3ba11ec8b234e9a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432751Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811851}

The test has been flaky on several bots:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=blink_web_tests&tests=media%2Fcontrols-styling-strict.html

TBR=mlamouri@google.com
NOTRY=TRUE

Bug: 1083605
Change-Id: Ia0736180fc02f8e258f88d2566a03fe0dc293cdb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437915Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811850}

Update languages' dialogs to have 24px padding.
UX is fine with these dialogs's paddings deviate from others.
Change device language: http://screen/xQa4J5bcswqWrJj
Add languages: http://screen/5BFTcGwzKfxE9hg
Add input methods: http://screen/37GF8UyM3z8THcM

Bug: 1113439
Change-Id: Id3d7ed561120d519aae66dc65a22004ecceb7b07
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437074
Commit-Queue: My Nguyen <myy@chromium.org>
Reviewed-by: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811849}

Bug: 1102382
Change-Id: I6ef96d347ac4864a1eb2e6fc547b77858baf54a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432143Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Auto-Submit: Gayane Petrosyan <gayane@chromium.org>
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811848}

Change:
* Add an ability for Android browser test to click the close button
on the opened payment handler UI.
* Test launching payment handler twice to prevent crbug.com/1131874 from
happening again.

Bug: 1131874

Change-Id: Id43def5f2d2be4a40e34eda1219942dabd70485e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434769
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811847}

URLs dragged from bookmarks are wrapped in URLInfo,
so drops onto the tab grid must unwrap URLInfo.

Change-Id: I8c1eb8b4e3c8b9b8222473313919066fb659e7e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436521
Commit-Queue: edchin <edchin@chromium.org>
Auto-Submit: edchin <edchin@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811846}

https://crrev.com/c/2421989 added Sanskrit, but it was misspelt.

Bug: 889763
Change-Id: Ia8f94a969e444a4df0d105c6999cb774127f01c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437676Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: My Nguyen <myy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811845}

This is a reland of 57b51303

In this reland the features browser tests are disabled on Android.
The API is not currently enabled on Android (and there are no plans to
change that in the near future), so we don't need to run these tests
on Android.

Original change's description:
> [FS] Remove Native File System base::Feature.
>
> The base::Feature has been enabled by default for many many milestones
> now, so it seems unlikely we'd ever want to turn it off again. Remove it
> to make code simpler to maintain.
>
> Embedders can still turn off the API using the blink runtime feature.
>
> Change-Id: Ifad92d39adac1e656cf75a02918f33409aea44ea
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427287
> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
> Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Victor Costan <pwnall@chromium.org>
> Reviewed-by: Trent Apted <tapted@chromium.org>
> Auto-Submit: Marijn Kruisselbrink <mek@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#810742}

Tbr: michaelpg@chromium.org
Change-Id: I6973c9100aeef471f7ce476d7054854fc986bf47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436756
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811844}

Overlays need to ensure they propagate the correct background
information up the tree. In this case the bottom toolbar wasn't
doing this which would cause screen flashing in some cases.

Bug: 951115
Change-Id: I9c7af7844345c95ed07215802137c2bf67bcf77b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437022Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811843}

Updates the name to be consistent with the source and tests in
//chrome/common/profiler.

Change-Id: Ic181aa3a67435a2af3e3e4592d06f5492ebb1f37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437603
Commit-Queue: Mike Wittman <wittman@chromium.org>
Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811842}

`string::operator=(int)` turns into `string::operator=(char)` by casting
the RHS of the assignment, so this code turns into `env = "\x01"`; `env
= "1"` was probably what was intended.

Bug: 1130867
Change-Id: I8a1a1e268c65246c35d864314502fb4aab62e6b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425333Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: George Burgess <gbiv@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811841}

Taking supported profiles into account when choosing when to use
an accelerated video encoder.

Bug: 1119636, 1127073
Change-Id: I8dd52bf6270342f48ba7ec734c91dc4b24e1196c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437783Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Eugene Zemtsov <eugene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811840}

Bug: 1129670, 1120093
Change-Id: I8b48d2c3ff9fda7fc347219f40deed60b9dd206d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426481
Commit-Queue: Sophey Dong <sophey@chromium.org>
Reviewed-by: Tanya Gupta <tgupta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811839}

A previous CL at r809271 accidentally uploaded incorrect screenshots
causing some confusion to translators.

Bug: None
Change-Id: I5fb8a60a0c2511f563252f87b03a7b720805b5ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438519
Commit-Queue: John Lee <johntlee@chromium.org>
Auto-Submit: dpapad <dpapad@chromium.org>
Reviewed-by: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811838}

Roll Chrome Linux PGO profile from chrome-linux-master-1601380366-03c4c1b9f0c0034a1b47d4510e955a5823e9948c.profdata to chrome-linux-master-1601402113-7fdca9625e1fa7a11789090d4f40670ef10ac97f.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com
Change-Id: Ia8ccc7ddb17613e74f3a12ba73c2598aaa8ef5af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438291Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#811837}

I didn't mean to commit that.

Bug: 1015315
Change-Id: I5f69aa5160219e63d4334976888e39c25b2bfe34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437381
Auto-Submit: Hans Wennborg <hans@chromium.org>
Commit-Queue: Reid Kleckner <rnk@chromium.org>
Reviewed-by: Reid Kleckner <rnk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811836}

There are a couple of Polymer Behaviors currently defined in the
ui/webui/resources/html/* and ui/webui/resources/js/* folders. Since
Polymer Behaviors can only be used in Polymer elements, makes more
sense to define them in cr_elements/ along with other such behaviors.

Moreover this simplifies the testing code by being able to leverage
cr_elements_browsertest.js.

Bug: 1133385
Change-Id: I66eb64812ae4c502452971da003b7a84f5f9d3fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435820Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Commit-Queue: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811835}

As pointed out by mek@, currently BlobDataItem::ShrinkBytes only resizes
the number of elements in the backing std::vector.  The backing capacity
of the vector remains the same.  For any blob less than 512KB this will
result in wasted memory usage.

Bug: 1133110
Change-Id: I71de9ce6cf75afbc7029d86841c8e5a754b69b52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436868Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811834}

Roll Chrome Mac PGO profile from chrome-mac-master-1601380366-c2cef07ee462371a6daba327da84ce5730b353c6.profdata to chrome-mac-master-1601402113-90af030cdb9e3c62fe724fde5c9a9eda66c16b0e.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com
Change-Id: Ide1f8862dd0488007fb22e5bcb70abfbbcd676da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438820Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#811833}

Bug: 1096586
Change-Id: Ied4e1b49ee7e6f154395762a1054924abe6a85a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438730Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811832}

The WGL path hasn't been used in the last many years and
shouldn't be used in the future since ANGLE provides an EGL
implementation on top of D3D or GL depending on what's available.

Remove all WGL support code since it isn't needed anymore.

Bug: chromium:1133372
Change-Id: I1c23f3b17682082e43d7c6072c085a94735e4cf8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434341
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811831}

EG1 code isn't built and run anymore. Remove the code from codebase by
making `#if defined(CHROME_EARL_GREY_2)` default and removing what's in
'#if defined(CHROME_EARL_GREY_1)'.

Command:
`find . -name '*.mm' -exec unifdef -DCHROME_EARL_GREY_2 -o {} {} \;`
`find . -name '*.mm' -exec unifdef -UCHROME_EARL_GREY_1 -o {} {} \;`

Plus manual handling for .h files, comments and unwrapping Maybe_test*.

Bug: 1102995, 922813, 1035764, 1033726, 1036221, 1036078, 1036071, 1036094, 972681
Change-Id: I06da0e04b8081c74cd32cb2412f9db9bfdb3a774
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433584Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811830}

This function is nearly identical to media::GetImageBufferColorSpace,
but instead operates on a CMFormatDescriptionRef.

Add DCHECKs that the behavior of the two functions be the same, that is,
the kCVImageBuffer-prefixed and  kCMFormatDescription-prefixed
constants be equal.

Use base::mac::CFCast instead of reinterpret_casts.

The next patch in this sequence will move these two functions over
to media/base/mac, because it will be accessed in capture.

Bug: 959962
Change-Id: I8a4d8468abc866a13cb6181cbd49d9ee04288124
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436513
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811829}

This CL bumps M87 histogram expirations to M90 for both MIX-DL and
Safety Tips.

Fixed: 1125668
Fixed: 1125752
Fixed: 1125753
Fixed: 1125754
Fixed: 1125755
Fixed: 1125756
Fixed: 1125757
Fixed: 1125758
Fixed: 1125759
Fixed: 1125760
Fixed: 1125761
Fixed: 1125762
Fixed: 1125763
Fixed: 1125808
Fixed: 1125809
Change-Id: I2a0c92d663772618d71bf27b7535d6b928c3dbc6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435648
Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org>
Commit-Queue: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811828}

Why: Before this patch we'd ignore any recompute event coming during
an in-progress computation. That assumes the history query callback is
the last task to run before the computation completes. However, since
we are going to add SortingLSH based computation after the history
callback, and the check (i.e. file read) is async, the original
assumption no longer holds. And there could be races.

What: This CL handles of recompute that comes during an in-progress
computation. We'll use a member variable to keep track of the last
recompute event (trigger) that we weren't able to handle. After the
current one completes, we'll ignore its result, and we'll recompute
again using that pending trigger.


Bug: 1062736
Change-Id: I3e30d26d47352480faa39494b0f6b4171f361456
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437782Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Commit-Queue: Yao Xiao <yaoxia@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811827}

The root layer is always a scroll container, so checking for
root-layer in addition to scroll container is unnecessary.

BUG=1087667

Change-Id: I179f9f5aaa9e65481e753067db46c98a756d8a67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432412
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811826}

This CL brings up RulesetService in WebLayer as a first step to enabling
the subresource filter component. To facilitate this bringup, this CL
refactors much of the //chrome-level creation of RulesetService into a
static RulesetService::Create() method that is shared between //weblayer
and //chrome.

Bug: 1116095
Change-Id: I285bc68fd59164826696cc700a3fbe7b934e582a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434342
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811825}

This CL adds clarifying comments to
PendingAppManagerImplBrowserTest.AlreadyRegistered.

In addition to comments this also adds
WebAppRegistrationWaiter::AwaitNextNonFailedRegistration() to avoid
having to use /web_apps/no_service_worker.html for the sake of asserting
on a particular RegistrationResultCode. The normal install flow with
/web_apps/basic.html is flakily either kSuccess or kAlreadyInstalled as
the service worker may asynchronously register during the first install
pass.

Change-Id: I6e6aa14882424c3ccc2affa90afd2798cfaed897
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437549Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Auto-Submit: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811824}