GitLab

OfflinePageRequestJob and OfflinePageURLLoader (will be added in next
patch to support network servicification) will create and hold
OfflinePageRequestHandler. The specific behaviors for url request job
and url loader are encapsulated in OfflinePageRequestHandler::Delegate
which will be implemented accordingly.

OfflinePageRequestHandlerTest is also to pull out common testing code.
For now, only one type OfflinePageRequestJobBuilder is added to test
OfflinePageRequestJob. I will add a new type to test new URLLoader in
next patch.


Bug: 841617
Change-Id: I1cd9b8e03358bc18d6d08e2d038be579de10dc42
Reviewed-on: https://chromium-review.googlesource.com/1058449
Commit-Queue: Jian Li <jianli@chromium.org>
Reviewed-by: Dmitry Titov <dimich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560715}

Adds message_center_unittests to the linux memory bots, and gn_unittests
to Mac Asan 64 on the memory waterfall.

Also adds both tests to many clang tot bots.

This is part of an effort to reduce the number of test configurations.
Originally reviewed as part of https://chromium-review.googlesource.com/1061795,
which I'm now landing in smaller pieces.

TBR=kbr

Bug: 843511
Change-Id: I245a4bad219239007126dbfd99a9b4d6efbdf8fd
Reviewed-on: https://chromium-review.googlesource.com/1069190Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560714}

This is the lowest priority when chosing a TTS voice in tts_controller_impl.

Tested using the TTS settings page with default English voice set to
Chrome OS Indian English, then running:
chrome.tts.speak('hi there i\'m a voice');  // Indian English
chrome.tts.speak('hi there i\'m a voice', {lang: "en-US"});  // US English

Bug: 823359
Change-Id: Ifdbbc3a19e1e2911f3624404555cc13ed271a9c5
Reviewed-on: https://chromium-review.googlesource.com/1064560Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560713}

Default:
- Remove hover borders
- Use light gray color for hover
Dark/Image:
- Use white/light gray for text and blacklist icon
- Use light transparent color for hover

Bug: 837798
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I461dc366a5e82457a6366ae31624f42ad8101a7d
Reviewed-on: https://chromium-review.googlesource.com/1065588
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560712}

ash_util.cc DEPS are non Mash only so are allowed.
Includes some other minor DEPS cleanup.

Bug: 843315
Change-Id: I3b637f041774b36b9b14c654cf15b222e9a8742e
Reviewed-on: https://chromium-review.googlesource.com/1069290Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560711}

This fixes the comment. The function was renamed here:
https://chromium-review.googlesource.com/675443

Bug: 695189
Change-Id: I58854785604b549d741c1a6287f66a767f749c12
Reviewed-on: https://chromium-review.googlesource.com/1067848Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560710}

Looks like this was forgotten in bug 842732. Perfbot sheriff disabling
to green up tree.

Bug: 842732
Change-Id: I5affabbb0a1454dc16614efb8a70a8fd019f49e0
TBR: charliea@chromium.org
NOTRY: true
Reviewed-on: https://chromium-review.googlesource.com/1069332Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Commit-Queue: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560709}

This CL replaces std::move()s whose result is not used, as clang starts
warning that on C++17 mode.

Bug: 752720
Change-Id: I843ba7d9356fdb14fe5cc0c258018fae201a32c6
Reviewed-on: https://chromium-review.googlesource.com/1068639Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560708}

Bug: 845213
Change-Id: Iafa7dde32fc952bc5ab70fef7e348008449fc22b
Reviewed-on: https://chromium-review.googlesource.com/1067852Reviewed-by: enne <enne@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560707}

This reverts commit 4753267b.

Reason for revert: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ios-simulator/33343 started to fail at PopupMenuMediatorTest.TestElementsTabGrid*

Original change's description:
> Reland "Add blink effect to the PopupMenu"
> 
> This reverts commit 33c637fd.
> 
> Original change's description:
> > Revert "Add blink effect to the PopupMenu"
> >
> > This reverts commit 20a94e7f.
> >
> > Reason for revert:
> > https://bugs.chromium.org/p/chromium/issues/detail?id=844753
> >
> > Bug: 844753
> >
> > Original change's description:
> > > Add blink effect to the PopupMenu
> > >
> > > This CL adds an effect to make the "New Incognito Tab" row of the tools
> > > menu blink a selected state when the in product help requires it.
> > >
> > > Bug: 829344
> > > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
> > > Change-Id: Ib2345a98f8ec284369b342d111cadf7f6a55adef
> > > Reviewed-on: https://chromium-review.googlesource.com/1057708
> > > Commit-Queue: Gauthier Ambard <gambard@chromium.org>
> > > Reviewed-by: edchin <edchin@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#559481}
> >
> > TBR=edchin@chromium.org,gambard@chromium.org
> >
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> >
> > Bug: 829344
> > Change-Id: I7135501ca78396a46d23ec53a538352d77e5c29d
> > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
> > Reviewed-on: https://chromium-review.googlesource.com/1066334
> > Commit-Queue: Eugene But <eugenebut@chromium.org>
> > Reviewed-by: edchin <edchin@chromium.org>
> > Reviewed-by: Eugene But <eugenebut@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#560106}
> 
> Bug: 844753, 829344
> Change-Id: Ibaf0e5cb3938a58021105d14b8d9d60e08372e06
> Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
> Reviewed-on: https://chromium-review.googlesource.com/1068727
> Reviewed-by: edchin <edchin@chromium.org>
> Commit-Queue: Gauthier Ambard <gambard@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#560632}

TBR=edchin@chromium.org,gambard@chromium.org

Change-Id: If2d2bea1069e682ec4e747d6790f68a9e289d7cf
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 844753, 829344
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/1067644Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560706}

Bug: 772928
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I3bab99696087bb61e33bc75a4168a84bceee9ba1
Reviewed-on: https://chromium-review.googlesource.com/1062202
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560705}

Migrated two metrics to use new APIs and flagged other identified
histograms' descriptions to highlight issue on dashboards (I will
email relevant owners after this lands).
Relevant metrics list extracted from https://crbug.com/807615#c19

R=asvitkine@chromium.org, fdoray@chromium.org

Bug: 807615
Change-Id: I84f0f8fb5ca7fd3c5b43ba7209693b89928ade07
Reviewed-on: https://chromium-review.googlesource.com/1062830
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560704}

Bug: 845555
Change-Id: I029cf1f8e916b41febc69824d637a459c0d38921
TBR: charliea@chromium.org
NOTRY: true
Reviewed-on: https://chromium-review.googlesource.com/1069313Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Commit-Queue: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560703}

These metrics are incorrect because they detect MAIN vs non-MAIN behaviour wrong
since the intent gets updated in onNewIntent(), but we set the intent in
onStart(). These are also incorrect because they get recorded every time
we call onStart(), which means that when we go to settings and come back
we would record the metric again.

Bug: 838388
Change-Id: Id8bb7b3401c8103029d5b397a57bb1f07dc56b26
Reviewed-on: https://chromium-review.googlesource.com/1062937Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Maria Khomenko <mariakhomenko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560702}

Have VideoResourceUpdater delete recycled video plane resources if
they're the wrong size. This is mainly an issue for software compositing
where VideoResourceUpdater always has to allocate plane resources
itself, but if the video size changes then we'd have extra plane
resources that aren't freed until the user navigates away from the
video.

Bug: none
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I09e39eec246c1304ae72cf9aad1486abedbcd7c1
Reviewed-on: https://chromium-review.googlesource.com/1003215
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560701}

fido_constants.h device::to_string was declared as constexpr,
but NOTREACHED expands in non-official builds to calls that cannot
be used inside a constexpr in GCC.

We take the opportunity to rename the method to CredentialTypeToString
to avoid namespace polution (and match style guide).

Change-Id: I9b166ce9a3d7a2213fd81fb045e4a0709f62e426
Reviewed-on: https://chromium-review.googlesource.com/1065895Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: José Dapena Paz <jose.dapena@lge.com>
Cr-Commit-Position: refs/heads/master@{#560700}

From crrev.com/c/923174, we set up resources on a background thread in
an attempt to reduce the start up time.

Calling resource rewriter's onResourcesLoaded() on a background thread
seems safe, and now we're calling it even earlier to reduce startup time.

Bug: 817644
Change-Id: I684b2c1c0cfb9fa2b1e1b7a3bfe35659ba836720
Reviewed-on: https://chromium-review.googlesource.com/1069219Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Tao Bai <michaelbai@chromium.org>
Commit-Queue: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560699}

LoadIfNecessary was no-op if _containerView already exists. This is
incorrect, because WebState::GetView() creates _containerView, but
LoadIfNecessary should still work after WebState::GetView() call.

This CL introduces _currentURLLoadWasTrigerred variable which is used
inside LoadIfNecessary to prevent extra subsequent loads.

Bug: 820484
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Id199789094a25fe414015dd586bf1411f2e81bea
Reviewed-on: https://chromium-review.googlesource.com/1067440
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560698}

We have several concepts of focus/active/etc for VR headsets. One of
these represents menu mode, where the browser temporarily unfocuses a
VR experience.  This is not hooked up currently, so we have stale code.

This dead code would otherwise need to be converted when VRDevice is
mojoified, so removing for now.  If we want to add back a similar  way
to pause experiences, we can easily add it back.

BUG=795510

Change-Id: Ifba2d7d6f23ba668c5f259a9326acb4983f13836
Reviewed-on: https://chromium-review.googlesource.com/1068097Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560697}

Migrate the browserAction API to use UIThreadExtensionFunction instead of
ChromeAsyncExtensionFunction.

Bug: 634140
Change-Id: Ic6af918ee5a3c968ad5afb6ec0d3700d450be0b9
Reviewed-on: https://chromium-review.googlesource.com/1067484
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560696}

This is effectively a revert of r521228 while keeping the improvements
of r524097.

This was intended to be used to allow ScopedTaskEnvironment::MOCK_TIME
on top of MessageLoopForUI/ForIO but this turned out harder than
expected and we're now going with a different approach.

R=danakj@chromium.org

Bug: 708584
Change-Id: I6951ac7fc1bf6b6eac0f269e0dec9f677ea29543
Reviewed-on: https://chromium-review.googlesource.com/1066456Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560695}

Turning off the review firehose.

Change-Id: Ib1447f7e9c3f93dcb401235748de71f949e17eef
Reviewed-on: https://chromium-review.googlesource.com/1069288
Commit-Queue: Adam Parker <amp@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560694}

Following comments on review
https://chromium-review.googlesource.com/c/chromium/src/+/1065131 this CL
refactors a set of duplicated expectations to instead use a common, new,
MATCHER.

BUG=840751

Change-Id: Ie2f0e9080478fab37d2c632f9c5d26244dbabd29
Reviewed-on: https://chromium-review.googlesource.com/1067739Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560693}

When a menu is open due to being dropped over, we should show it as
highlighted to make the drop target clearer. This CL enables
showing the highlight for such case, and when the menu is closed the
menu should return to normal state.

Highlighting the menu was implemented in Cocoa browser on Mac before,
but not done for Views or other platforms. This CL will enable this
feature for all Views based browser across platforms.

BUG=838598

Change-Id: I11ac21d03110598b122e1345e36cc2e16f47519b
Reviewed-on: https://chromium-review.googlesource.com/1057964Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560692}

Bug: 841532
Change-Id: I313a4efc4aaaa04cf75556db5b705284f3cc66ef
Reviewed-on: https://chromium-review.googlesource.com/1067439
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560691}

Migrate the permissions API to use UIThreadExtensionFunction instead of
ChromeAsyncExtensionFunction.

Note: there is a small behavior difference here where the API will no
longer return `false` if there is an error (and runtime.lastError will be
set). Functions should not return both a result and an error.

Bug: 634140
Change-Id: I7dbdc3a9c99f0f51ef96189667abc65528c407fa
Reviewed-on: https://chromium-review.googlesource.com/1067510Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560690}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/8cd0986e..994a66b3

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I1ed0919cfcaecf57754c7ef58ef4b4b100350225
Reviewed-on: https://chromium-review.googlesource.com/1069029Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560689}

There is some gap at the beginning of
WebViewChromiumFactoryProvider#initialize().

Also, the title 'loadPlatSupportLibrary' is somewhat misleading, so
splitting it up and renaming/refactoring them.

Finally, adding some comment about startup investigation.

Bug: 817644
Change-Id: Id0fa91a46f81c4a4bd43e9dbd8ecbcb70a658608
Reviewed-on: https://chromium-review.googlesource.com/1069248Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560688}

BUG=792308

Change-Id: Iac85f6f2cf2db684b8cddb7926d4a032e154ee41
Reviewed-on: https://chromium-review.googlesource.com/1056472Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560687}

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I4945d9fec94da964eb19191868d0ea94a5b857ed
Reviewed-on: https://chromium-review.googlesource.com/1067600Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560686}

The EventHandler used to forward events to the right client maintains
state that needs to be reset in certain cases, as otherwise it won't
properly clean up the state. In particular if capture or visibility
changes then EventHandler no longer gets the events.

BUG=837692
TEST=covered by test

Change-Id: I560960ea93462f68c2e252dbd1b5dc9c581ff886
Reviewed-on: https://chromium-review.googlesource.com/1067883
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560685}

Bug: 773295
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I556353286e4ec97544aa9e51d77e102bf78d59ae
Reviewed-on: https://chromium-review.googlesource.com/1054478
Commit-Queue: Mark Pilgrim <pilgrim@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560684}

This cl renames the stub LogoView class to StubLogoView in order to add
the real LogoView class.

Bug: b/79999539
Test: manual.
Change-Id: Ie606143eb73e20f4c44e67f43b5cd132a055f39b
Reviewed-on: https://chromium-review.googlesource.com/1067879Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560683}

The test consistently times out since ToTMacASan build 1089 and
needs investigation.

Bug: 844402
Change-Id: I30c6348f888b5c466fe693831530ec37cdee953c
Reviewed-on: https://chromium-review.googlesource.com/1069122Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560682}

This change:
1) Moves the logic for showing accelerator text into MenuConfig
2) Adds a MenuConfig variable for whether to show accelerator text in
   context menus

Bug: 843703
Change-Id: Iedcef2ba4cdfc2a5390ddc0c9889af339625938d
Reviewed-on: https://chromium-review.googlesource.com/1069035
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560681}

Add a private NSView method, setParentUILayer. Any NSView that can be
drawn using a ui::Compositor (e.g, the WebContentsView) may implement
this method to be informed of the parent ui::Layer that it may draw to
(instead of drawing into its NSView's CALayers).

Prior to this change, BrowserCompositorMac will always allocate its
own ui::Compositor (via RecyclableCompositorMac) for drawing. With
this change, the -[NSView setParentUILayer] method propagates to the
BrowserCompositorMac to allow the BrowserCompositorMac to use the
parent ui::Layer's ui::Compositor.

Add this as a new entry in BrowserCompositorMac::State, and add the
ability to transition between this state and all other states.

Of note is that the previous states are still necessary for two use
cases.
  * When a tab is background but is doing tab capture, the current
    implementation requires that a ui::Compositor be available to
    draw the content for capture. Allow allocating for this use case.
  * Popup windows (e.g, date and time picker) are not embedded in a
    distinct ui::Compositor (they don't even have a parent
    WebContentsViewCocoa), so they must display through their own
    allocated ui::Compositor. Use the existing mechanism in this
    case.

Bug: 840173
Change-Id: I68bbf5da8419c7b1b3ad0edd99faec05bbdc5473
Reviewed-on: https://chromium-review.googlesource.com/1063119
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Sidney San Martín <sdy@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560680}

This will allow us to evaluate the performance of lifecycles,
determine how often and to which sites they occur, and allow analysis
of the reasons for which they fail most often

BUG=753486

Change-Id: I64884a3314f2170c5e14e5c13dd5a95e5d258a3e
Reviewed-on: https://chromium-review.googlesource.com/1062491
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560679}

This is a follow up of https://crrev.com/c/1043285, which completed the rest of
the migration from 'fetcher' to 'loader' terminology in
c/b/search/one_google_bar.

Bug: 773295
Change-Id: I77b875ffc64f7ce16ea4dfb265bbd73cd92cea0c
Reviewed-on: https://chromium-review.googlesource.com/1068023
Commit-Queue: Ramya Nagarajan <ramyan@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560678}

Controlled by existing origin trial.

Bug: 845187
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I43e4e0d9f303086b50e9dd57ae547bfdcd79f204
Reviewed-on: https://chromium-review.googlesource.com/1065918
Commit-Queue: Henrik Grunell <grunell@chromium.org>
Reviewed-by: Tommi <tommi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560677}

Set use_lld = false in nacl toolchains and reland "Let lld emit colored diagnostics when invoked from ninja."

This reverts commit 18da5f23.

Reason for revert: The original commit broke the CFI bot with errors like:

  src/native_client/toolchain/linux_x86/pnacl_newlib/bin/../x86_64-nacl/bin/ld:
      unrecognized option '--color-diagnostics'

I do not know why this only happened on the CFI bot (XXX), but since we only add
-fuse-ld=lld if !is_nacl, we should set use_lld to false in the nacl toolchains,
which fixes this, and probably many future issues like it.

Original change's description:
> Revert "Let lld emit colored diagnostics when invoked from ninja."
>
> This reverts commit 00db3ddc.
>
> Reason for revert: Breaks Linux CFI build here: https://ci.chromium.org/buildbot/chromium.memory/Linux%20CFI/8024
>
> Original change's description:
> > Let lld emit colored diagnostics when invoked from ninja.
> >
> > Bug: 841221
> > Change-Id: I72d13c78a2c623865a4f29542d25f6b3488b350b
> > Reviewed-on: https://chromium-review.googlesource.com/1067460
> > Reviewed-by: Reid Kleckner <rnk@chromium.org>
> > Commit-Queue: Nico Weber <thakis@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#560343}
>
> TBR=thakis@chromium.org,rnk@chromium.org
>
> Change-Id: I3811083daa622dca605ca32be5cc4c7098b60b4a
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 841221
> Reviewed-on: https://chromium-review.googlesource.com/1067949
> Reviewed-by: Tommy Li <tommycli@chromium.org>
> Commit-Queue: Tommy Li <tommycli@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#560345}

TBR=thakis@chromium.org,rnk@chromium.org,tommycli@chromium.org

Change-Id: I5d4c9298e3613ab84650f081a59715880d780805
Bug: 841221
Reviewed-on: https://chromium-review.googlesource.com/1068218
Commit-Queue: Reid Kleckner <rnk@chromium.org>
Reviewed-by: Reid Kleckner <rnk@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560676}