- 13 Jun, 2019 40 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ef787f79e54e..9715559684cd git log ef787f79e54e..9715559684cd --date=short --no-merges --format='%ad %ae %s' 2019-06-13 csmartdalton@google.com Skip addInterval for stencil proxies ignored by resource allocator 2019-06-13 herb@google.com Make fPathData private and add API for paths 2019-06-13 bsalomon@google.com Revert "Make GrBicubicEffect also support centripetal Catmull-Rom kernel." 2019-06-13 mtklein@google.com rm unused fields 2019-06-13 egdaniel@google.com Add asserts to make sure we always have valid GrBackendFormats before creating proxies. 2019-06-13 mtklein@google.com i16x2 sub/shr 2019-06-13 bsalomon@google.com Make GrBicubicEffect also support centripetal Catmull-Rom kernel. 2019-06-13 mtklein@google.com baby steps into 16-bit ops 2019-06-13 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-06-13 mtklein@google.com remove mul_unorm8/mad_unorm8 2019-06-13 herb@google.com Revert "[skottie] Use metrics for Shaper vertical alignment" 2019-06-13 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@9715559684cd The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=herb@google.com Change-Id: Ifdf1bb1bc2d433d5039f2d9573c2fefd7daa4178 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659135Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#669015}
-
Jonathan Backer authored
Change-Id: Ic76a8f1f3b53a04d396e35e368d70b566611ef2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1651916Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#669014}
-
Kyle Milka authored
Bug: None Change-Id: I15812f742ace9a4870cba112fc34e95aaae96c15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658953 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#669013}
-
Devlin Cronin authored
Add core_api_provider and test_support targets to //.gn, and add a couple missing DEPS. Bug: None Change-Id: I6da68f4be815fe4641dba8034a4b067e4115fea7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658847 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#669012}
-
Sven Zheng authored
The test currently fails on bot. Error: [11192:6800:0613/132632.669:ERROR:resource_bundle.cc(803)] Failed to load C:\b\s\w\ir\out\Default\chrome_100_percent.pak Some features may not be available. [11192:6800:0613/132632.684:WARNING:resource_bundle.cc(357)] locale_file_path.empty() for locale The added data deps is the same as browser_tests: https://cs.chromium.org/chromium/src/chrome/test/BUILD.gn?l=1362&rcl=21629cfe06f703203dbfcebad89f86685a95f821 Bug: chromium:958242 Change-Id: If3e3fbae08affa4885bc21ebd488f150cb71883e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658766Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#669011}
-
Sunny Sachanandani authored
With site isolation, sites can have many OOPIFs whose main threads contend with important GPU/compositor threads for CPU. This is particularly bad on devices like Surface Go with low-end CPUs where it causes considerable jank during scroll/fling gestures. This change adds two finch flags: 1) GpuUseDisplayThreadPriority which makes GPU and viz threads use ThreadPriority::DISPLAY, and 2) BlinkCompositorUseDisplayThreadPriority which does the same for blink compositor thread. Change-Id: I3a240e3fbbe0cbc62344e267e55075c8b2c92ef9 Bug: 965778 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623553 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#669010}
-
Marc Treib authored
This reverts commit 8c872e02. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=973770 Note: This CL does not revert the changes the the test files as instructed by treib@ who is the author of the original CL. Original change's description: > Make IsSyncRequested false by default > > Before this CL, the value of IsSyncRequested was essentially undefined > while Sync was disabled: It was true by default, but false if the user > had previously enabled Sync and then disabled it again. > This CL resolves the inconsistency by making it false by default. > > Bug: 906034 > Change-Id: I2ce92f5df5ebb38a34ebde43d471839ad1184961 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508453 > Reviewed-by: Jan Krcal <jkrcal@chromium.org> > Commit-Queue: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#642447} TBR=treib@chromium.org,jkrcal@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 906034, 973770 Change-Id: I501f563cae8ff63de21cd66d933281e0af9542ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658468 Commit-Queue: Marc Treib <treib@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#669009}
-
Ella Ge authored
WebMouseEvent and PointerEvent coalescing need to check modifiers too. This CL adds the missing checks and tests. Bug: 973959 Change-Id: I68255000db9d5f7fe4df52189d4f5a7263810d43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659197Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#669008}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/d050b35a14af..ce4e27f24632 git log d050b35a14af..ce4e27f24632 --date=short --no-merges --format='%ad %ae %s' 2019-06-13 asweintraub@google.com Fix ClangTidy - Naming findings 2019-06-13 thestig@chromium.org Fix accidental deletion from commit 60cd033a. 2019-06-13 thestig@chromium.org Make some FPDFPage APIs locale independent. 2019-06-13 thestig@chromium.org Simplify writing out CFX_PointF to content streams. 2019-06-13 thestig@chromium.org Remove fx_bmp.cpp. 2019-06-13 thestig@chromium.org Add BmpModule::Status enum class. 2019-06-13 asweintraub@google.com Automatic clang-tidy fixes. 2019-06-13 thestig@chromium.org Do IWYU for <ostream> 2019-06-13 thestig@chromium.org Roll third_party/libjpeg_turbo/ 2de84a43e..2a34770be (3 commits) Created with: gclient setdep -r src/third_party/pdfium@ce4e27f24632 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:970047,chromium:922430 TBR=pdfium-deps-rolls@chromium.org Change-Id: I03f8cb34d62beaad1e73da1084334ac4c4e2705b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659129Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#669007}
-
Mason Freed authored
Previous to this CL, if an element was styled with both filter and backdrop-filter, the filter effect was not properly applied to the filtered backdrop contents, because a separate filter property node gets created for the filter, and the backdrop-filter effect node does not contain the filters. With this CL, paint_layer appends the filters to the backdrop-filters list, so that Viz has access to those. Bug: 973907 Change-Id: I255b73433d75e0551d817134fa50d5e0e35b87df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658654 Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#669006}
-
Ella Ge authored
This CL renames the movementX/Y blink flag to kConsolidatedMovementXY, and also adds a content flag to control the blink flag. The content feature flag is going to be used in the following CL to guard the moving movementX/Y calculation to blink in locked states. Bug: 802067 Change-Id: I0de3dd6a23ac8d2615981e9c1c4a2f2458a31cfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618305 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#669005}
-
kylechar authored
Display::Resize() was using ShallowFinishCHROMIUM() to ensure that all pending swap buffer calls at the current size were issued before returning. This is because D3D will scale swapped output if it doesn't match the window size. Unfortunately there isn't an equivalent to ShallowFinishCHROMIUM() for SkiaRenderer. RootCompositorFrameSinkImpl::DisableSwapUntilResize() would run a callback after calling Display::Resize() with size (0, 0). Resize() would only return after all swap buffers calls were issued since ShallowFinishCHROMIUM() would block until then. Add Display::DisableSwapUntilResize() that take a callback and runs it after all pending swaps have completed. This works with both GLRenderer and SkiaRenderer plus it doesn't block the display compositor thread while waiting for swaps to complete. Finally remove RendererSettings::finish_rendering_on_resize. This setting was only true on Windows and only did anything when Resize() was called with size (0, 0) for DisableSwapUntilResize(). Since DisableSwapUntilResize() is also only used on Windows, just assume we want to finish rendering if DisableSwapUntilResize() is called. Bug: 809722 Change-Id: Ia6117dd03d8da9dbfcb1dc97d197d85c8634d647 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652685Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#669004}
-
Natalie Chouinard authored
Migrate the Privacy Settings page from deprecated Framework preferences to the Preferences Support Library. Bug: 968592 Change-Id: I5d6b2875120c1d20b667792e65f1c1c8e678493b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647145 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#669003}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/df99659bac9c..38c7d9e30add git log df99659bac9c..38c7d9e30add --date=short --no-merges --format='%ad %ae %s' 2019-06-13 saklein@chromium.org Build API: TestService/BuildTargetUnitTest method cleanup. 2019-06-13 manojgupta@google.com chromeos_config: Remove poppy from parallel CQ. 2019-06-13 saklein@chromium.org binhost service: Fix package index path parsing. Created with: gclient setdep -r src/third_party/chromite@38c7d9e30add The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I1ef18ce3bf294442ce4f4923b7b8e6f630c4049d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658716Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#669002}
-
David Bertoni authored
Bug: 973540 Change-Id: Idfe4997e53121ec843c2fa09bbbe390023363167 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658836Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#669001}
-
Tim Song authored
This feature is now enabled by default, so clean up this flag and corresponding code paths and tests. BUG=921250 Change-Id: If6e84bad818aac6c551e3db07bfc4b1409d98e86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656710Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#669000}
-
Raymond Toy authored
If the filter state of a BiquadFilterNode or IIRFIlterNode gets in a bad state, print a console warning about it. Bad state here means that the state of the filter contains non-finite values. These are usually indicative of unstable filters, but can also happen if the input does not have finite values or if the input causes overflow during the filter computation. Bug: 717727 Change-Id: Id014c4d71631d794355375540d9e6979ff260201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585063 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#668999}
-
Matthew Webb authored
Expand bio enrollment support for CTAP2.1 §5.7.7, renaming enrollments. According to the standard, if an enrollment doesn't exist the operation will return INVALID_OPTION like enumeration. This CL also switches from BioEnrollmentHandler's OnceClosure to OnceCallback<CtapDeviceResponseCode> since the status from enumerating and renaming must be checked. Change-Id: I38fc7f063edd28538d8414ff7a4bb6054c779796 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654882Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Matthew Webb <noviv@google.com> Cr-Commit-Position: refs/heads/master@{#668998}
-
Patrick Monette authored
This CL ensures that a FrameNavigationEntry is always wrapped in a scoped_refptr. Change-Id: I730c0f40d4d1a5c70d188683e5f98ebe15a8a2bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647437 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#668997}
-
Jinsuk Kim authored
ChromeFullscreenManager listens for ContentView of the foreground tab and updates offset/margin/system ui visibility directly. The intermediate steps to propagate the events are not necessary. The 2 TabObserver methods added in https://crrev.com/c/1567565 are deleted. Bug: 966272 Change-Id: Ide633dc1bb703dbf79b760004db8f8c42cf7c226 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621794 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#668996}
-
Sergey Ulanov authored
Previously, when tearing down an output audio stream, Pause and DiscardAllPackets messages were sent twice, which is not necessary. Bug: 974029 Change-Id: I75b2695db5f0d62cc3c243c10608c21db318f1ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658774 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#668995}
-
Danan S authored
This is needed in order to allow the Add Supervision flow to open "Learn More" links to the help documentation. Change-Id: Ica37a7ebb3ec1d5ec251cea8394aac165719c865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648282 Commit-Queue: Danan S <danan@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#668994}
-
Renjie authored
https://quiche.googlesource.com/quiche.git/+log/3a1bb80f575f..88e3e05c3411 $ git log 3a1bb80f5..88e3e05c3 --date=short --no-merges --format='%ad %ae %s' 2019-06-13 danzh Internal QUICHE change 2019-06-13 danzh gfe-relnote: n/a(clean up) Switch existing directly access of FLAGS to use GetQuicFlag. 2019-06-12 quiche-dev Internal QUICHE change 2019-06-12 danzh gfe-relnote: n/a(code clean up) Fix quiche compile errors in envoy. 2019-06-12 wub gfe-relnote: (n/a) Add quic platform api to create BBRv2 sender, currently the implementation just creates a BBRv1 sender. No behavior change, not protected. 2019-06-12 fayang gfe-relnote: Roll forward the deprecation of gfe2_reloadable_flag_quic_enable_version_46 as this does not cause b3m prober failure anymore. 2019-06-12 fkastenholz Additional functional version tests. 2019-06-12 bnc Remove unused QuicSpdySessionTestBase::headers_ member. 2019-06-12 renjietang gfe-relnote: Clean up unnecessary includes for control streams. Not protected. 2019-06-12 danzh gfe-relnote: n/a(code cleanup) Replace direct usage of FLAGS_some_flag_name in quiche. 2019-06-12 wub Remove references to stateless reject from various comments and tests. 2019-06-12 fayang gfe-relnote: Deprecate gfe2_reloadable_flag_quic_enable_version_44. 2019-06-11 wub In QUIC simulator: 1) Allow the bandwidth of OneWayLink/SymmetricLink to change after construction. 2) Change QuicEndpointMultiplexer's constructor from taking a std::initializer_list to a std::vector. 2019-06-11 bnc Internal QUICHE change Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I00171c4c2719292db5f611e82731a17fdada8dbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658758 Commit-Queue: Renjie Tang <renjietang@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#668993}
-
Becca Hughes authored
Expose the favicon/touch icons as the source icons for a media session. This will be used by the CrOS lock screen media controls. BUG=973993 Change-Id: I056b03c4fa97aab8edb11aa817abef5011ab5e24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659508Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#668992}
-
Carlos IL authored
Committed SSL interstitials have launched, this CL cleans up its flag. Bug: 966184 Change-Id: Idea3767f3d4616f7c25d143c49e9186096ac87aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644231 Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#668991}
-
Vlad Tsyrklevich authored
Delete an outdated TODO (the memory routines are not likely to be mergable as they are now, and will especially not be so if we choose to use shared memory) and add a TODO. Change-Id: I180f48d14d21dbbc80461fae23eb4d52de8efadd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658713 Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#668990}
-
James Cook authored
* Remove separate "Google Accounts" line. (The account manager will ship before SplitSettings, so we can rely on it being there.) * Change the label to "foo@bar.com, +N more accounts" using correctly localized plural nouns. Rely on localization to handle the 0 more accounts case so there's only one string to localize. * Add optimization to JS/C++ getAccounts() call to avoid shipping all the avatar icon images. The label above is in the critical path for opening settings, so we don't want to ship 10s of KB of image data across the IPC boundary just to get the number of accounts. * Port the browser people_page_test.js suite to OS tests. Most tests are not ported because they are tied to DICE or Unified Consent, neither of which exists on Chrome OS. https://screenshot.googleplex.com/TkYKrmhgiTz.png As a temporary hack, the profile icon still routes to the change picture subpage. This will be removed with later changes to the picture page, see bug. Bug: 972152 Test: added to browser_tests Change-Id: I80c3a89cb94df2b9a284f96ac2eb7529b037830d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659201Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#668989}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 06026d80. With Chromium commits locally applied on WPT: 9e3affdd "Ship `referer` header length limitation." 723f9a78 "Prevent leaking Sec-CH-/Sec-Fetch- Request Headers on HTTPS Downgrade Redirects." 8bbed8ff "Reland tests from "Change ICE connection state on transceiver changes"" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I59a687a69799983ccb4f7c0b7fbe1163dbe1d970 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659196Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#668988}
-
Vlad Tsyrklevich authored
This reverts commit 3266c8c4. Reason for revert: The timeouts should be fixed by https://crrev.com/667828. Original change's description: > Disable CrashHandlerTest.UnrelatedException on Mac > > TBR=gayane@chromium.org > NOTRY=true > > Bug: 971247 > Change-Id: If2170d68287e5021e25986cc4dd875ca864c53fe > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645812 > Reviewed-by: Xida Chen <xidachen@chromium.org> > Commit-Queue: Xida Chen <xidachen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#666275} Bug: 971247 Change-Id: Ib0096478fd9cf2fcd80eb5a5c161dee6f4ab46d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653490 Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#668987}
-
Yue Zhang authored
Tab info is not correctly updated in GTS when close happens in TabGridDialog. This CL fixes this issue. Bug: 973918 Change-Id: I16edadd757a19956aff2274f0d88000264c895b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659049 Commit-Queue: Yue Zhang <yuezhanggg@google.com> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#668986}
-
Khushal authored
This change addresses the texture params synchronization with skia and enables shared images for all accelerated canvas2d uses except single buffered canvas. Change-Id: Ibbc1dedce21e3b365e7f715f8fdd338753721d95 Bug: 900706 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639184 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#668985}
-
Robbie McElrath authored
This replaces LocalHostTestURLRequestInterceptor with URLLoaderInterceptor, which works with the Network Service enabled. Bug: 966633 Change-Id: I5462ebbb9afc7192554de6cdef9539c606244e32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653318Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#668984}
-
Koji Ishii authored
When LayoutNG tries to extend the selection rect to the line height, the height is set to the line height instead of being united. It made the selection rect smaller when the line has smaller height than the text. This patch fixes to unite. Bug: 973302 Change-Id: I6a2ef38b0f682cc7d3f91858ecbcaf4a88ec819c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657879 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#668983}
-
Mandy Chen authored
Localize strings that show up in the debugger pane and remote debugging window. Before vs after (they should look the same): https://imgur.com/a/qkGngVT Bug: 941561 Change-Id: Id4530b016812c15502fcdb3f71d454038edc2f34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656708Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Mandy Chen <mandy.chen@microsoft.com> Cr-Commit-Position: refs/heads/master@{#668982}
-
Saman Sami authored
We used to need OnFirstSurfaceActivation notifications because background extensions would create so many surfaces that never actually had a frame but used up the quota in FrameEvictionManager. This problem has been fixed at crrev.com/c/1651613, so don't request OnFirstSurfaceActivation anymore. Bug: 938947 Change-Id: I19bf093fec1cd40de064c1c4e6dedcb71b5545c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652225 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Auto-Submit: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#668981}
-
Jeff Fisher authored
In Edge we needed to have a way to server-enable DevTools experiments, so this change allows experiments to be enabled via a new query parameter. Change-Id: I449bae840759a695e69c95c7bde675a9da228e4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642989 Commit-Queue: Jeff Fisher <jeffish@microsoft.com> Reviewed-by:
Erik Luo <luoe@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#668980}
-
John Delaney authored
https://crrev.com/926cfe2795767 introduced undefined behavior when deleting a frame from storage by not null checking the render frame host that is being deleted. There is no guarantee that OnFrameDeleted provides a RFH. There was more undefined behavior caused by accessing an iterator value that may be equal to the end of the list. This is likely the cause of flakiness found in https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vOTI2Y2ZlMjc5NTc2NzlkZTFhZTU0MDNmNzJmNzk1ZDVjMDAzMTljNww Change-Id: I572bc9da628745435e4980fa61a5e4cd263ac948 Bug: 973954 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658588 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#668979}
-
Oksana Zhuravlova authored
TBR=ochang@chromium.org Bug: 973947 Change-Id: Ic6e401936d5b23db48025d65344d79077dc6a4fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659030Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#668978}
-
Ken Rockot authored
This ensures the Service Manager is always initialized by ContentMainRunnerImpl early in process startup, rather than potentially deferring until BrowserMainLoop runs. The main motivation here is to have only one place in browser code where the Service Manager is initialized. This also begins peeling away at some of the unnecessary dependencies on ServiceManagerConnection and ServiceManagerContext, since both are slated for deletion. Finally, this adds a public content::GetSystemConnector API to content/public/browser as a drop-in replacement for ServiceManagerConnection::GetForProcess()->GetConnector(). Moving forward, this is the API that new browser code should use when connecting to services. The API is available very early in browser startup, even before BrowserMainLoop is instantiated. Bug: 904240, 968147 Change-Id: I933dc8a4bf268cec92eaa4cbdc452c1fc2a08898 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650155 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#668977}
-
Brian Sheedy authored
Adds Markdown documentation on the GPU team's Skia Gold-enabled pixel tests, such as how to triage images, how they work, and how to modify Gold if necessary. Bug: 965234 Change-Id: Ie77c9679e458d7196af1457edbf2b06f45799f8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638739 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#668976}
-