GitLab

R=kalman@chromium.org
BUG=455196
TEST=visual

Review URL: https://codereview.chromium.org/900993002

Cr-Commit-Position: refs/heads/master@{#314658}

After having transitioned all the tracing headers from base/debug/ to
base/trace_event, this CL addresses the namespace move.
In principle, this CL should only change the namespace of the
base/trace_event files but the namespace used by the tracing clients.
In order to achieve this, namespace aliases are appended to the
trace_event headers, to make it so that clients can still refer to
base::debug::TraceFoo, with that being aliased to
base::trace_event::TraceFoo.
The upcoming CLs will gradually migrate the clients to use the
base::trace_event namespace and will remove the ns aliases.
Unfortunately, this CL has also to update few tracing clients,
in particular the ones having forward declarations. Forward
declarations, in fact, cannot be aliased as the compiler sees them
before the alias itself.

See crrev.com/837303004 and the related bug for motivations and design doc.

BUG=451032
TBR=skyostil@chromium.org,jam@chromium.org

Review URL: https://codereview.chromium.org/882673002

Cr-Commit-Position: refs/heads/master@{#314657}

The existing comment references the old name of finalize_apk_action.gypi, this
updates it to its current name.

This also reorders the input list to be alphabetized.

Review URL: https://codereview.chromium.org/899063002

Cr-Commit-Position: refs/heads/master@{#314656}

BUG=454967
NOTRY=true
TBR=aboxhall@chromium.org

Review URL: https://codereview.chromium.org/904523003

Cr-Commit-Position: refs/heads/master@{#314655}

BUG=453188

Review URL: https://codereview.chromium.org/898483006

Cr-Commit-Position: refs/heads/master@{#314654}

BUG=370433
TEST=unit_tests, components_unittests
R=sky@chromium.org
TBR=joaodasilva@chromium.org (for policy)

Review URL: https://codereview.chromium.org/865163003

Cr-Commit-Position: refs/heads/master@{#314653}

This has confused more than one person using the shell for the first
time.

BUG=

Review URL: https://codereview.chromium.org/882063004

Cr-Commit-Position: refs/heads/master@{#314652}

An It2Me connection requires an email for domain policy check.
We should use the email of the helpee instead of the helper.

Summary of changes:
1. Modifies it2meHelpeeChannel to fetch its token and the user's credentials
   using remoting.identity.
2. Implement the background page as an object to initialize remoting.identity
   appropriately.
3. Makes the consentDialog argument optional in remoting.identity as user
   consent is suggested as opposed to required in the chrome identity API.

BUG=454897

Review URL: https://codereview.chromium.org/896003002

Cr-Commit-Position: refs/heads/master@{#314651}

Close icon switched approved in crbug.com/455002

BUG=455002

Review URL: https://codereview.chromium.org/894453004

Cr-Commit-Position: refs/heads/master@{#314650}

Transitions are disabled while loading, so animations should be as well.

This happens when chrome://extensions/?options=<id> is navigated to,
which shows the dialog immediately.

R=kalman@chromium.org
BUG=none
TEST=load chrome://extensions/?options=<extension_id> and look for
     needless animation

Review URL: https://codereview.chromium.org/896283003

Cr-Commit-Position: refs/heads/master@{#314649}

BUG=304341

Review URL: https://codereview.chromium.org/902683002

Cr-Commit-Position: refs/heads/master@{#314648}

The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual and
final implies both virtual and override.

This patch was automatically generated with an OS=android build using a
variation of https://codereview.chromium.org/598073004.

BUG=417463
R=creis@chromium.org

Review URL: https://codereview.chromium.org/893333004

Cr-Commit-Position: refs/heads/master@{#314647}

BUG=

Review URL: https://codereview.chromium.org/897123002

Cr-Commit-Position: refs/heads/master@{#314646}

Since this bumps the milestone definition in pp_macros.h
NOPRESUBMIT=true

BUG=417589

Review URL: https://codereview.chromium.org/842293003

Cr-Commit-Position: refs/heads/master@{#314645}

BUG=446578

Review URL: https://codereview.chromium.org/893003004

Cr-Commit-Position: refs/heads/master@{#314644}

R=arv@chromium.org
TBR=sky@chromium.org
BUG=454776

Review URL: https://codereview.chromium.org/893403004

Cr-Commit-Position: refs/heads/master@{#314643}

This cL contains some micro optimizations as well as cleaning up some
variables that are left over from old refactors.

One variable in particular that was deleted is the "compiler_options_"
member within the Shader class. This member was used to hold extra
compiler options such as extensions for cache key purposes. However,
at some point this mechanism has been replaced by querying the angle
compiler directly for a string which represents the resources.

BUG=453543
TEST=trybots

Review URL: https://codereview.chromium.org/900543004

Cr-Commit-Position: refs/heads/master@{#314642}

For the reasons described within the code itself, OS X can be a bit tetchy
when it comes to PKI path building. Rather than blow up in users' face with
an error, or warn them about weak signatures when strong signatures exist,
take a performance hit and do something similar to Safari, which is to
assume the OS APIs are broken/won't do the right thing, and try to fix up
the inputs prior to giving to the Security.framework.

In this case, it means trying to verify the cert as supplied (the existing
behaviour), and if that fails / gives something undesirable, begin cutting
off certs given to the OS and retrying until it gives something better or
there are no more certs to amputate.

This causes an (unmeasured) perf hit, but only for situations that would
fail for users today, or would yell at them tomorrow, so overall, it's
a worthy tradeoff.

BUG=438653, 434914, 440267
TEST= https://github.com works. https://cacert.omniroot.com works. Unit tests are happy.

Review URL: https://codereview.chromium.org/886223002

Cr-Commit-Position: refs/heads/master@{#314641}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/f162012..d2a6f4e

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/899083002

Cr-Commit-Position: refs/heads/master@{#314640}

BUG=196658

Review URL: https://codereview.chromium.org/885673004

Cr-Commit-Position: refs/heads/master@{#314639}

The new leveldb manifest reuse feature was disabled because the CrOS dev channel
daily error % by channel values increased after this landed in that channel (by
about 3x). Reverting this change did not return the dev channel rates back to
normal. Furthermore the beta channel (with this feature enabled) did not
experience an increase in errors.

Commit details: Returns manifest reuse back to the state introduced in
crrev.com/803603004 (de701abe) which was disabled in two subsequent reverts:
crrev.com/841753003 (ca6c8754) and crrev.com/852073002 (617e94e4).

BUG=402980

Review URL: https://codereview.chromium.org/899933002

Cr-Commit-Position: refs/heads/master@{#314638}

Accelerated canvas and GPU raster both use the same Skia codepaths and
have generally displayed the same bugs.  It doesn't make sense to
blacklist one but not the other.  Since GPU raster sees more usage than
canvas nowadays, and I researched GPU raster compatibility as part of
https://codereview.chromium.org/760053003, it makes sense to fold canvas
into the same blacklist.

This immediately fixes an Adreno 225 canvas bug which slipped through a
driver-reported-version based blacklist, which is apparently unreliable
and which I deleted in this patch.  More generally it also should avoid
this kind of issue in the future.

This patch is similar to the previous version, but also makes the
Mali-T604 blacklist entry specific to Android, since it was
inadvertently affecting ChromeOS.

BUG=453283,454547

Review URL: https://codereview.chromium.org/899743002

Cr-Commit-Position: refs/heads/master@{#314637}

This is also adding some logic about empty and invalid
ServiceWorkerClientInfo.

BUG=450634

Committed: https://crrev.com/5d6924925a291a7cf394a685772251c83a63f99f
Cr-Commit-Position: refs/heads/master@{#313982}

Review URL: https://codereview.chromium.org/871013003

Cr-Commit-Position: refs/heads/master@{#314636}

BUG=452643

Review URL: https://codereview.chromium.org/886583005

Cr-Commit-Position: refs/heads/master@{#314635}

UploadFileElementReader relies on checking the modified time of files
being uploaded to determine if a sliced file was modified during upload.
Clients of the net stack (in particular Blink) currently pass around the
expected modified time in a manner which cause the timestamp to lose
precision (E.g. converting to and from a double time_t).

As a result the expected timestamp and the current timestamp as returned
by GetFileInfo() will not match exactly. Current code attempted to
compensate for this by converting both timestamps to (integer) time_t.
However, since the conversion rounds down, this check would only succeed
if the loss of precision of the expected timestamp also caused it to
round down. This is not always the case. (E.g. (epoch + 10.999999) will
become 10 when converted to time_t, but the expected timestamp may have
rounded up to (epoch + 11.0) in the meantime.)

This patch compares the timestamps by checking if the magnitude of the
difference is less than one second.

BUG=426465
CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg,mac_blink_rel,win_blink_rel
R=mmenke

Committed: https://crrev.com/b77c8ffae588001875fb50ead987a147ca882bdb
Cr-Commit-Position: refs/heads/master@{#314397}

Reverted: https://crrev.com/7ccf4fab5d4473e431f1a289056033eea0b3dd43
Cr-Commit-Position: refs/heads/master@{#314451}

Review URL: https://codereview.chromium.org/868253012

Cr-Commit-Position: refs/heads/master@{#314634}

This removes another source of raw process handles.

BUG=417532

Review URL: https://codereview.chromium.org/868543002

Cr-Commit-Position: refs/heads/master@{#314633}

Do not re-set the root layer for the ui::Compositor when suspending the
browser compositor view. Prior to moving the ui::Compositor to use the
scheduler, this would prevent frames from appearing. Now it causes blank
flashes.

There are still blue (debug) flashes when returning from fullscreen and
when the GPU process is killed. These still need to be fixed.

BUG=454682

Review URL: https://codereview.chromium.org/903543002

Cr-Commit-Position: refs/heads/master@{#314632}

Revert of Introduce HostID and de-couple Extensions from "script injection System" [browser side] (patchset #20 id:760001 of https://codereview.chromium.org/822453002/)

Reason for revert:
It might cause the crash https://code.google.com/p/chromium/issues/detail?id=454917.

Original issue's description:
> Introduce HostID and de-couple Extensions from "script injection System" [browser side]
>
> The major refactor includes:
> - Introduce HostID (a pair of |id, type|) to replace extension_id in browser
>   side.
> - Abstract UserScriptLoader to be a base class, and introduces
>   a derived class ExtensionUserScriptLoader which is
>   responsible for loading user scripts for extensions.
> - In DeclarativeUserScriptManager, a master is created per
>   extension/webUI.
> - DeclarativeUserScriptManager becomes an
>   ExtensionRegistryObserver and is responsible for clearing scripts
>   for master objects when receive OnExensionUnloaded event.
>
> BUG=437566
>
> Committed: https://crrev.com/b88fe3dc1072501bdd105fd95a8b3bc453fd2aa7
> Cr-Commit-Position: refs/heads/master@{#313402}

TBR=fsamuel@chromium.org,rdevlin.cronin@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=437566

Review URL: https://codereview.chromium.org/899983002

Cr-Commit-Position: refs/heads/master@{#314631}

Revert of Reland Ensure WebView notifies desktop automation on creation, destruction, and change (patchset #5 id:80001 of https://codereview.chromium.org/895623003/)

Reason for revert:
Seeing intermittent failures on vox tests after this patch

https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/55807

BackgroundTest.InitialFeedback
BackgroundTest.ContinuousRead
BackgroundTest.CaretNavigation

Original issue's description:
> Reland Ensure WebView notifies desktop automation on creation, destruction, and change
>
> Original issue https://codereview.chromium.org/880063002
>
> TBR=dtseng@chromium.org
>
> Committed: https://crrev.com/4a61275d7b2708d4aca1e1c4975739424a379fc3
> Cr-Commit-Position: refs/heads/master@{#314378}

TBR=dtseng@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/897103002

Cr-Commit-Position: refs/heads/master@{#314630}

This matches other webui dialogs' (settings) behavior by setting initial
focus when a dialog is shown.

To fully match we need to also restore focus when the dialog is closed,
which we'll do when it's easier (i.e. when the page isn't totally
rebuilt all the time).

BUG=438301
R=kalman@chromium.org

Review URL: https://codereview.chromium.org/900623003

Cr-Commit-Position: refs/heads/master@{#314629}

Review URL: https://codereview.chromium.org/892403003

Cr-Commit-Position: refs/heads/master@{#314628}

There is no callers for this anymore. Remove it and all the
unnecessary code.

BUG=

Review URL: https://codereview.chromium.org/898543002

Cr-Commit-Position: refs/heads/master@{#314627}

Now that fractional scroll offset can pass through cc main
thread and Blink, we can remove the scroll_delta flooring hack
and send the full fractional scroll_delta from impl to main.

Note that this will break the old pinch viewport code path (
which is to be removed soon) since it still only expects integer
scroll offset.

BUG=414283

Review URL: https://codereview.chromium.org/870363005

Cr-Commit-Position: refs/heads/master@{#314626}

This change adds the selectClientCertificates() and subtleCrypto() functions and is missing the getKeyPair() function.
It is also missing the certificate permissions per extension and any UI changes.

BUG=450167

Review URL: https://codereview.chromium.org/875373002

Cr-Commit-Position: refs/heads/master@{#314625}

da0df3f  Fix gyp failure on linux asan trybots.

BUG=428057
TBR=glider

Review URL: https://codereview.chromium.org/904473003

Cr-Commit-Position: refs/heads/master@{#314624}

The default is to support all toolchains. Do this
for several core libraries. This mostly affects
mac for which these libraries were previously not
being built.

This change allows for the addition of nacl-clang
or other toolchain without needing to change all
the core dsc files.

BUG=454962

Review URL: https://codereview.chromium.org/886583004

Cr-Commit-Position: refs/heads/master@{#314623}

Revert of Device Orientation API on Chrome OS (patchset #8 id:200001 of https://codereview.chromium.org/856123002/)

Reason for revert:
Compilation failure on CQ:

http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Linux%20ChromeOS%20MSan%20Builder/builds/1666/steps/compile/logs/stdio

Original issue's description:
> Device Orientation API on Chrome OS
>
> Implement DataFetcherSharedMemory on Chrome OS to provide Device Orientation support. Create SensorManagerChromeOS to observe accelerometer events, and to generate updates to the Device Orientation API.
>
> This is a follow up to: https://codereview.chromium.org/680383007/
>
> With the accelerometer on Chrome OS now exposed to content/ from chromeos/accelerometer, no ash/ implementation is required. No public api in content/public/browser is needed either.
>
> TEST=SensorManagerTest.OrientationBuffer, SensorManagerTest.NeutralOrientation, SensorManagerTest.UpsideDown, SensorManagerTest.BeforeUpsideDownBoundary, SensorManagerTest.LeftEdge, SensorManagerTest.RightEdge, SensorManagerTest.BeforeRightEdgeBoundary
> BUG=342908
>
> Committed: https://crrev.com/e717460964dd27a7239abec31462441eb971edbe
> Cr-Commit-Position: refs/heads/master@{#314605}

TBR=timvolodine@chromium.org,jam@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=342908

Review URL: https://codereview.chromium.org/899973002

Cr-Commit-Position: refs/heads/master@{#314622}

The CL adds support for print destinations managed by extensions (using
chrome.printerProvider API) to print preview.
These destinations are added to local printers list with the icon set to
the extension icon, but that will probably be changed before the API
goes to stable.

Also, this does not implement print requests for these destinations, so
the 'Print' button is disabled for them.

BUG=408772

Review URL: https://codereview.chromium.org/900503002

Cr-Commit-Position: refs/heads/master@{#314621}

Thank you for your contributions!

TBR=vrk@chromium.org,bemasc@chromium.org

Review URL: https://codereview.chromium.org/895143002

Cr-Commit-Position: refs/heads/master@{#314620}

BUG=455002

Review URL: https://codereview.chromium.org/897933002

Cr-Commit-Position: refs/heads/master@{#314619}