- 08 May, 2019 40 commits
-
-
Reilly Grant authored
Script can transfer the ArrayBuffer created by an instance of ImageData. In this case the data is no longer available and the ImageData should be rejected by the detect() API. Bug: 957522 Change-Id: I2601aa9661303ce1a5fd67044178e2ef83347281 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600458Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#657738}
-
Lukasz Anforowicz authored
After this CL the policies that map into prefs::kUnsafelyTreatInsecureOriginAsSecure are pushed at runtime into the SecureOriginAllowlist singleton class in the //services/network layer. This helps in the following ways: - After this CL, content::IsOriginSecure takes the policy into account (it didn't before) - Since SecureOriginAllowlist (unlike prefs) can be accessed from any browser-side thread, after this CL we are able to propagate the policy into the NetworkService process (see the changes in //chrome/browser/chrome_content_browser_client.cc) - This CL allows to delete //chrome-layer IsOriginSecure (which was asking content::IsOriginSecure *and* also checking the policy/pref) and instead just always call content::IsOriginSecure which already looks at the switch value. This means that //content-layer calls to content::IsOriginSecure now correctly start to take the policy/pref value into account. In addition to testing via automated regression tests, I've also manually launched chrome with --unsafely-treat-insecure-origin-as-secure switch and with UnsafelyTreatInsecureOriginAsSecure policy configured via /etc/chromium/policies/managed/trustworthy-origins.json and verified (via ps -fwwp) that the renderer process and the NetworkService process have the right cmdline switch (combining the policy and cmdline values from the browser process). Bug: 937451, 917107 Change-Id: I3ff24d57ec89971e7657ca0d612b291d7bbfb2b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1513098Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#657737}
-
Scott Violet authored
Removes the Classic part, which is no longer appropriate. BUG=958135 TEST=covered by tests TBR=mukai@chromium.org Change-Id: I1ed6c902713f7db1a9d640577676f1fe51cc012d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601319Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#657736}
-
Rayan Kanso authored
Use the ukm service for recording background events instead of manually querying the history service. Bug: 952870 Change-Id: I5d77954bb48f0197c5f3861888e499d328a2e694 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593355 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#657735}
-
Becky Zhou authored
Bug: 958986 Change-Id: I276bc5a6afd806e9814be6a3031db80f2c11a459 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600639Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#657734}
-
Rayan Kanso authored
Move IsRecording/LogEvent functions to a content/public/browser base class so that content implementers can easily log events to DevTools. Steps taken: - Create an abstract DevToolsBackgroundServicesContext class in public with IsRecording/LogEvent virtual methods. - Create a public enum for the background service and map it to the internal enum. - Rename the existing DevToolsBackgroundServicesContext to DevToolsBackgroundServicesContextImpl and have it implement the public class. Bug: 927726 Change-Id: I1da98efb4b26b5f3de4b6899b696d9153aeda95b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593528 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c562f4de..6fb8bc0e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I057f57dd48b00aaed5cf2a76a080c17626190bac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601317Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#657732}
-
Lucas Furukawa Gadani authored
Bug: 908139 Change-Id: I202059461f21fe87eee3d89ea8af45b8f0d009fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595978Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#657731}
-
Scott Violet authored
This is rename step 1. Step 2 will actually rename class. BUG=958135 TEST=covered by tests TBR=mukai@chromium.org Change-Id: I82839b1fe8bd7cc1c1449164b56fe3604983c1e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601318Reviewed-by:
-
Xiaocheng Hu authored
This reverts commit ddcafd19. Reason for revert: Breaks Mac builders: https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Mac10.13%20%28retina%29/13886 mac-rel somehow didn't run webkit_layout_tests... Original change's description: > [Editing] Change left/right caret movement from visual to logical > > As the visual left/right caret movement has become un-maintainable, > this patch removes them and replaces them by logical movement. > > This patch: > - Exposes line direction utilities from inline_box_traversal.cc to be > reused by SelectionModifier. These utilities will be moved/refactored > later for better code structure. > - Changes SelectionModifier to use logical left/right movements for > character and word granularities. > > All other changes are removal of dead code and test expectations > changes. > > Bug: 958831 > Change-Id: Ic4cf83290beb2521c620167be32b4fa4d716a3c0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593632 > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > Reviewed-by: Koji Ishii <kojii@chromium.org> > Reviewed-by: Emil A Eklund <eae@chromium.org> > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#657694} TBR=yosin@chromium.org,eae@chromium.org,kojii@chromium.org,xiaochengh@chromium.org Change-Id: Ib730622f7918d7ec7c77fdade8fabd83da962d87 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 958831 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600878Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#657729}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/746bb12c4652..1ddf2968fb2a Created with: gclient setdep -r src-internal@1ddf2968fb2a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=dvadym@chromium.org,noel@chromium.org,jbroman@chromium.org,xialinyan@chromium.org Change-Id: I42cffab36b43c98e583c94a19e35fa39e41e4507 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601121Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#657728}
-
Katie D authored
It uses the same animation settings as the PIP. Bug: 894907 Change-Id: I57a4a8d58dbd8907c5c8289db13a0439869258bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598841Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#657727}
-
Moe Ahmadi authored
Many static file hosting services do not allow setting the appropriate content-type when serving files. This CL relaxes the requirement to display USDZ 3D models with ARQuickLook by checking the file extension in addition to the content type. Bug: 958938 Change-Id: I1f1a216d3e4f8bbe660242f5acb2eadef0c57509 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597121 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#657726}
-
Liquan(Max) Gu authored
Image Element Timing requires FCP++ to report ImageResourceContent* as a property of ImageRecord. Originally, FCP++ reports url as part of it. If we add ImageResourceContent*, url wouldn't need to be be in ImageRecord any more because ImageResourceContent already contains it. This CL got reverted in https://chromium-review.googlesource.com/c/chromium/src/+/1597896. It was due to accessing into a released pointer. This CL has fixed this issue. Bug: 957448 Change-Id: I730f44984693e2850e873dc32c439905f7688682 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599354 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#657725}
-
Dan Sinclair authored
This Cl rolls the SPIRV-Tools and SPIRV-Headers dependencies together to fixup the intertwining of the SPIR-V 1.4 release. Change-Id: I48962487869882a51ed542a9f4f857759cbad997 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601053 Auto-Submit: dsinclair <dsinclair@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#657724}
-
Tobias Sargeant authored
Change-Id: Ifeb7b6e4c5cb71c118d8fd005fac20894ff9ba9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594715 Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#657723}
-
Dan Harrington authored
There are two problems addressed here: 1. Synchronization was missing in TestOfflinePageService.sendPushMessage 2. Recent changes relating to prefetch GCM defer the call to GetGCMToken, which in turn results in an exception when calling FakeInstanceIDWithSubtype.getSubtypeAndAuthorizedEntityOfOnlyToken. With these fixed, we (crosses fingers) can un-disable the test. Bug: 959733 Change-Id: Ibfd29de884813606ab73a6520c627a4214d52432 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600353Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#657722}
-
Ehsan Karamad authored
In order to print pages navigated to a PDF document, a message should be sent to the extension process. This is routed internally through PostMessageSupport. This implements the required bits for frame-based MimeHandlerView. Bug: 659750 Change-Id: I23fdae54bcdba90cf5f145fbd999be0016f397d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594745Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#657721}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c9c5c497678b..de991d4fe26a git log c9c5c497678b..de991d4fe26a --date=short --no-merges --format='%ad %ae %s' 2019-05-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/glslang/src c0640dabfddd..f88e5824d2cf (1 commits) Created with: gclient setdep -r src/third_party/angle@de991d4fe26a The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@chromium.org Change-Id: I7a4aa76611ebd2a51a141ce41a21576ed3d0d9fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601177Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#657720}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/254a80307c6e..d2baff227833 git log 254a80307c6e..d2baff227833 --date=short --no-merges --format='%ad %ae %s' 2019-05-08 khokhlov@google.com Merge "TraceProcessor: Add EXPORT_JSON SQL function" Created with: gclient setdep -r src/third_party/perfetto@d2baff227833 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I3e790fafb3beba4085f610c645a13b352f483c8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601120Reviewed-by:
-
Peng Huang authored
Bug: 956177 Change-Id: Icd47f45c63503a11d84bc40867eb2a0746b6b17c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1589908 Commit-Queue: Peng Huang <penghuang@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#657718}
-
Lily Chen authored
New histograms to record DB initialization outcome, update outcome, number of entries loaded, etc. Bug: 895821 Change-Id: Icc4af7ddfe194731b30ee41c10c358694676b523 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592279 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#657717}
-
Ella Ge authored
Extend resampling-input-events and resampling-scroll-events flags to M80 as the work is still in progress. Extend touch-drag-n-drap flags to M82 since it's not going to be fully enabled in all platform yet. (Currently default enabled on ChromeOS and Android, need work on windows) Change-Id: I6c4db759f0313511d96b82aba74ed023b8b29894 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594821Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#657716}
-
Yue Zhang authored
This CL changes TabGridDialogMediator so that dialog only triggers resets of GTS when the dialog is showing. Bug: 960140 Change-Id: I3ab8bef8f961a3feae0782b8b898c4458b899a3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598333 Commit-Queue: Yue Zhang <yuezhanggg@google.com> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#657715}
-
Alexander Timin authored
Move the WebScopedVirtualTimePauser class from public/platform/ to public/platform/scheduler. R=haraken@chromium.org Change-Id: I45eaa78d252f808ff1c34ec0c77499280caaacd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601034Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#657714}
-
Sean Gilhuly authored
Parameterize the readback and synchronous cc pixel tests, and add SkiaRenderer as an option. These tests are currently all passing except for texture readback in SkiaRenderer, so enable them. Refactor LayerTreeHostSynchronousPixelTest by combining some common code. Bug: 948128 Change-Id: Idc238534f0d1311812a71749a31db320b0fe2dda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598215Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#657713}
-
Harald Alvestrand authored
This CL also rearranges some WPT code, in particular it moves the "coupleIceCandidates" helper into RTCPeerConnection-helpers.js, and changes the order of SDP application in doSignalingHandshake. Note: This is not a complete fix to the state bug, since it turns out that including a datachannel in the test will still cause the state to not reach "connected". Bug: 959128 Change-Id: Ic542c4ff99b2e3f2d2dbc171cca1be11b2b0fde5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601139Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#657712}
-
Florent Castelli authored
Intent thread: https://groups.google.com/a/chromium.org/d/msg/blink-dev/DRz-uHqPCLw/ZNDiwL0ZAwAJ Bug: 891556 Change-Id: I3a851ca721f6ec29971e9a9ca76df1966a6b1ad1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593615 Commit-Queue: Florent Castelli <orphis@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#657711}
-
Xiaocheng Hu authored
This reverts commit 696fd3af. Reason for revert: Crashes are already captured Original change's description: > [LayoutNG] Turn AssertLaidOut into a CHECK for LayoutNG round 4 > > This reverts commit 0af2a61e. > > Reason for revert: Need another round of crash capturing. > > Original change's description: > > Revert "Reland "[LayoutNG] Turn AssertLaidOut into a CHECK for LayoutNG" round 3" > > > > This reverts commit cbdaf211. > > > > Reason for revert: Crash data already collected in 3763 and 3764 > > > > Original change's description: > > > Reland "[LayoutNG] Turn AssertLaidOut into a CHECK for LayoutNG" round 3 > > > > > > This reverts commit 33b5c673. > > > > > > Reason for revert: Adding production CHECKs to collect LayoutNG failures > > > for the 3rd time. > > > > > > Original change's description: > > > > Revert "Reland "[LayoutNG] Turn AssertLaidOut into a CHECK for LayoutNG"" > > > > > > > > This reverts commit 26ca019a. > > > > > > > > Reason for revert: Crash data already collected > > > > > > > > Original change's description: > > > > > Reland "[LayoutNG] Turn AssertLaidOut into a CHECK for LayoutNG" > > > > > > > > > > This reverts commit ec11fe81. > > > > > > > > > > Reason for revert: Try to catch more crashes in the wild after > > > > > a fix (crrev.com/c/1546713) has been landed. > > > > > > > > > > Original change's description: > > > > > > Revert "[LayoutNG] Turn AssertLaidOut into a CHECK for LayoutNG" > > > > > > > > > > > > This reverts commit bade42c5. > > > > > > > > > > > > Reason for revert: New crashes already caught. Reverting CHECKs > > > > > > back into DCHECKs to reduce noises. > > > > > > > > > > > > Original change's description: > > > > > > > [LayoutNG] Turn AssertLaidOut into a CHECK for LayoutNG > > > > > > > > > > > > > > Bug: 946004 > > > > > > > Change-Id: I9e2aa69a32f7a0373196d57e629256dbc7d78d2a > > > > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540305 > > > > > > > Reviewed-by: Koji Ishii <kojii@chromium.org> > > > > > > > Reviewed-by: Emil A Eklund <eae@chromium.org> > > > > > > > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > > > > > > > Cr-Commit-Position: refs/heads/master@{#644907} > > > > > > > > > > > > TBR=eae@chromium.org,kojii@chromium.org,xiaochengh@chromium.org > > > > > > > > > > > > Change-Id: I15fb43370f58757e09e7b7abc7c40d4af4a6101a > > > > > > No-Presubmit: true > > > > > > No-Tree-Checks: true > > > > > > No-Try: true > > > > > > Bug: 946004 > > > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1544156 > > > > > > Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> > > > > > > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > > > > > > Cr-Commit-Position: refs/heads/master@{#645407} > > > > > > > > > > TBR=eae@chromium.org,kojii@chromium.org,xiaochengh@chromium.org > > > > > > > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > > > > > > > Bug: 946004 > > > > > Change-Id: Iccb8c2b998d28f659381c3f89a1686614600860c > > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548248 > > > > > Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> > > > > > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > > > > > Cr-Commit-Position: refs/heads/master@{#646516} > > > > > > > > TBR=eae@chromium.org,kojii@chromium.org,xiaochengh@chromium.org > > > > > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > > > > > Bug: 946004 > > > > Change-Id: I9794539b39bc6a0053a7229b03bce7db402ecb5b > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551440 > > > > Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> > > > > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#647418} > > > > > > TBR=eae@chromium.org,kojii@chromium.org,xiaochengh@chromium.org > > > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > > > Bug: 946004 > > > Change-Id: I973ccf65be78d4632f67b945614f1a4ee091134d > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562500 > > > Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> > > > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#649773} > > > > TBR=eae@chromium.org,kojii@chromium.org,xiaochengh@chromium.org > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Bug: 946004 > > Change-Id: If61d1cbfaeb6a445b8ceee193dba198978d2719c > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1567130 > > Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> > > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#650624} > > TBR=eae@chromium.org,kojii@chromium.org,xiaochengh@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 946004 > Change-Id: I43e61cc397ebbb44fb15f9a5bc0448077c281f60 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600400 > Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> > Reviewed-by: Emil A Eklund <eae@chromium.org> > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#657538} TBR=eae@chromium.org,kojii@chromium.org,xiaochengh@chromium.org Change-Id: I542cc5aeaabdcbbf046a1c3b69fc5c539645e9e5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 946004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600536Reviewed-by:
-
Jack Steinberg authored
Rename layered_api .js files to .mjs to fit with Google's advice here: https://developers.google.com/web/fundamentals/primers/modules - for kv-storage, virtual-scroller, and blank. Change resource and tests files to reflect. Bug: 938963 Change-Id: I5d08c24cbc055d3623101ba8019d84343f90c458 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599191Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Jack Steinberg <jacksteinberg@chromium.org> Cr-Commit-Position: refs/heads/master@{#657709}
-
Scott Violet authored
Now that we aren't shipping mash, this code is no longer necessary. BUG=958135 TEST=this is purely dead code removal TBR=tsepez@chromium.org Change-Id: I68be857d43df73ecf67f2bb40e97b91cfc3b5ce5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600600 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#657708}
-
Xi Han authored
We use feature SERVICE_MANAGER_FOR_BACKGROUND_PREFETCH to setup the experiment for both PrefetchBackgroundTask and DownloadBackgroundTask running in the reduced mode. Also caches the features in FeatureUtilities. Bug: 933358 Change-Id: I5b4b01a010d9ee75e1b453a75044f1688d0b660d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590510Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#657707}
-
Robert Sesek authored
Bug: 958163 Change-Id: I403d10452daf01dc3ac3b4b8f26bce25cc721533 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599677Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#657706}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/15c91422339a..5785e4a16530 git log 15c91422339a..5785e4a16530 --date=short --no-merges --format='%ad %ae %s' 2019-05-08 bungeman@google.com Use SkFontHinting instead of macros. Created with: gclient setdep -r src/third_party/skia@5785e4a16530 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=robertphillips@chromium.org Change-Id: Ice3c197511cda8832a901ef851d5dd82f8b72ce2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601224Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4fb12b0caec9..d8b9ed77cf52 git log 4fb12b0caec9..d8b9ed77cf52 --date=short --no-merges --format='%ad %ae %s' 2019-05-08 nisse@webrtc.org Promote RtcEventLogOutputFile to api/ 2019-05-08 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision db92e075..8939017d (656805:657653) 2019-05-08 mbonadei@webrtc.org Do not use absl::flat_hash_map in DefaultVideoQualityAnalyzer. 2019-05-08 eladalon@webrtc.org Fix typo in SupportsEncoderFrameDropping's documentation 2019-05-08 jakobi@webrtc.org Add lifetime concealment stats to NetEqStatsPlotter. 2019-05-08 eladalon@webrtc.org Rename "average_freeze_duration" metric to "freeze_duration_average" 2019-05-08 eladalon@webrtc.org Add missing overrides to QualityTestVideoEncoder 2019-05-08 eladalon@webrtc.org Fix comment over Vp8FrameBufferController::SupportsEncoderFrameDropping 2019-05-08 jsphchn@google.com Add support for ignoring errors encountered while configuring preferred attributes of an audio session. 2019-05-08 nisse@webrtc.org Move some RTP-related observers from common_types.h 2019-05-07 eladalon@webrtc.org Add metrics related to video freezes to VideoAnalyzer 2019-05-07 sprang@webrtc.org Remove packets from RtpPacketHistory if acked via TransportFeedback 2019-05-07 mbonadei@webrtc.org Do not run CheckNoStreamUsageIsAdded on tests. 2019-05-07 mbonadei@webrtc.org DefaultAudioQualityAnalyzer: use bytes_recv instead of packets_recv. 2019-05-07 nisse@webrtc.org Log transport feedback max interval 2019-05-07 titovartem@webrtc.org Add support of specifying concrete codec for video stream 2019-05-07 nisse@webrtc.org Move RtcpPacketTypeCounter and observer to rtcp_statistics.h 2019-05-06 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 2345bf12..db92e075 (656700:656805) 2019-05-06 andersc@webrtc.org Remove bitratePriority from the Obj-C RTCRtpEncodingParameters wrapper. 2019-05-06 asapersson@webrtc.org Add ability to configure quality scaler settings through field trial. 2019-05-06 ilnik@webrtc.org Don't invalidate whole update_rect if buffer conversion didn't change any pixels 2019-05-06 nisse@webrtc.org Add FILE* constructors to RtcEventLogOutputFile 2019-05-06 nisse@webrtc.org Delete windows-specific stop flag in PlatformThread 2019-05-06 mbonadei@webrtc.org Reland "Add Video Bwe stats collection to DefaultVideoQualityAnalyzer." 2019-05-05 hta@webrtc.org Revert "Version 2 "Refactoring DataContentDescription class"" 2019-05-05 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision ba5acd25..2345bf12 (656600:656700) 2019-05-05 hta@webrtc.org Version 2 "Refactoring DataContentDescription class" 2019-05-04 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 0225b2f9..ba5acd25 (656458:656600) 2019-05-03 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision b9ad721a..0225b2f9 (656347:656458) 2019-05-03 sprang@webrtc.org RtpPacketHistory: StoreAndCull default on, support ack removals 2019-05-03 peah@webrtc.org Remove deprecated call to UpdateHistogramsOnCallEnd 2019-05-03 peah@webrtc.org Remove the enable flag from AEC2 and AECM 2019-05-03 dklee@google.com Ensure that we always set values for min and max audio bitrate. 2019-05-03 srte@webrtc.org Don't require call to ValidateFieldTrialsStringOrDie for ScopedFieldTrials. 2019-05-03 andersc@webrtc.org Add priority to RTCRtpEncodingParameters. 2019-05-03 perkj@webrtc.org Provide AlrDetector with event log in GoogCC. 2019-05-03 srte@webrtc.org Allows injection of network controller factory in test fixture. 2019-05-03 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision e821123c..b9ad721a (656244:656347) 2019-05-03 ilnik@webrtc.org Remove deprecated interface in I420BufferInterface::GetI420 2019-05-03 henrik.lundin@webrtc.org NetEq: Minor change to print-out format for interruption stats 2019-05-03 ivoc@webrtc.org Expose new audio stats on the API 2019-05-03 srte@webrtc.org Adds debug printing of network estimate. 2019-05-03 srte@webrtc.org Avoids mismatching packets on wraparound in log parser. 2019-05-03 eladalon@webrtc.org Rename configurations_ to vpx_configs_ in LibvpxVp8Encoder 2019-05-03 eladalon@webrtc.org Refactor handling of configuration overrides from Vp8FrameBufferController 2019-05-03 peah@webrtc.org Remove the reporting of histogram data for AEC2 2019-05-03 nisse@webrtc.org Delete deprecated PlatformThread looping 2019-05-03 julien.isorce@chromium.org Check nullity of CGColorSpaceCopyICCProfile's return value 2019-05-03 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision ea179c51..e821123c (656127:656244) 2019-05-02 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision b510663a..ea179c51 (655963:656127) 2019-05-02 srte@webrtc.org Reland "Reland "Improving robustness of feedback matching code in event log parser."" Created with: gclient setdep -r src/third_party/webrtc@d8b9ed77cf52 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:none,chromium:930186,chromium:None,chromium:None,chromium:None,chromium:None,chromium:none,chromium:None,chromium:945468,chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ica294935dc913db249608b61b0c6f4e04b5b0cbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601223Reviewed-by:
-
Michael Thiessen authored
Bug: 941690 Change-Id: Ic05861d2d813a4104957e0bd355c9e8dcd20f7ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596322Reviewed-by:
Pavel Shmakov <pshmakov@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#657703}
-
Matt Menke authored
UnescapeBinaryURLComponent() unconditionally escapes all escaped characters. It was using UnescapeURLComponent(), which leaves "%00" though "%1F" escaped, as well as certain UTF-8 characters that aren't safe to display in the omnibox. Since a GURL is constructed with the result, it will re-escape all these characters, anyways, with the exception of when these characters appear at the end of a URL, in which case GURL will truncate them. Since GURL does this for spaces, too, and this wasn't a problem before, presumably it's fine for these more obscure characters, too. The UTF-8 characters that aren't safe to unescape for display in the omnibox are still valid UTF-8 characters, and it doesn't make sense to keep them escaped when they're not for display to the user. This CL is part of a project to clean up uses of UnescapeURLComponent(), as it's been used for wildly disparate purposes, and much of its logic is only suitable for cases where we want to format a URL for safe display to the user. We want to make it leave additional weird characters escaped, but need to eliminate usage of it in other contexts before we can do that. UnescapeBinaryURLComponent() should be used instead in most cases, particularly where URL_SPECIAL_CHARS_EXCEPT_PATH_SEPARATORS is in use, as all consumers of that option seem to either be slightly buggy, or don't actually need to leave any characters unescaped. The primary cases where switching to UnescapeBinaryURLComponent() may cause problems (without additional checks), are cases where unescaping path separators or funky characters (like %01) is a problem. In those places, we should generally fail instead of partially unescaping a URL. Bug: 849998 Change-Id: I6c086765c77d68cb4f164ba7891737fb08925462 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592807 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#657702}
-
Jeremy Roman authored
Lack thereof caused a compile failure: https://ci.chromium.org/p/chromium/builders/ci/win-rel/15603 Bug: 960460 Tbr: rdevlin.cronin@chromium.org No-Tree-Checks: true No-Try: true Change-Id: I122bbabdc2590c4a06b0330ca1aa080e75a295f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600837Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#657701}
-
Ross McIlroy authored
This reverts commit 255dca91. Reason for revert: Still breaks pixel2 bots, now due to aapt2 error loading libc++.so. Original change's description: > Reland "[Perf] Update Pixel2 FYI perf bot to MonoChrome6432.aab." > > This is a reland of e3d9c6d3 > > Original change's description: > > [Perf] Update Pixel2 FYI perf bot to MonoChrome6432.aab. > > > > This will update the Pixel2 bots to use the MonoChrome6432.aab which is a 64bit > > browser. In making this change a new 'exact_browser' option is added to > > tester_config in perf_data_generator to allow specifying a particular binary to > > be run rather than guessing. > > > > Reland of: https://chromium-review.googlesource.com/c/chromium/src/+/1511455 > > > > TBR=crouleau@chromium.org,perezju@chromium.org > > BUG=934251 > > > > Change-Id: I21bf7ae8e42f0e4c127748eeecc58a8af34334a1 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1587563 > > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > > Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> > > Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> > > Auto-Submit: Ross McIlroy <rmcilroy@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#654862} > > TBR=crouleau@chromium.org > TBR=perezju@chromium.org > > Bug: 934251 > Change-Id: I18a8dcb554f52ddff6e1b39d02566faff67c68a3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599614 > Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#657640} TBR=rmcilroy@chromium.org,perezju@chromium.org,crouleau@chromium.org Change-Id: Idfef7d330bb25e965c5c834b5d4b58ed68eba238 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 934251 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601040Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#657700}
-
Matt Menke authored
It has been using UnescapeURLComponent() instead to unescape file names. UnescapeURLComponent() leaves various UTF-8 characters that are unsafe to display in the omnibox, but valid in other contexts escaped, as well as "%00" through "%1F". In addition, it was being told to keep path separators escaped. The UTF-8 logic was unnecessary here, and it's better to fail on unexpected input rather than to partially unescape it. Switching to UnescapeBinaryURLComponentSafe() gets us both of these behaviors. This CL is part of a project to clean up uses of UnescapeURLComponent(), as it's been used for wildly disparate purposes, and much of its logic is only suitable for cases where we want to format a URL for safe display to the user. We want to make it leave more weird characters escaped, but need to eliminate usage of it in other contexts before we can do that. UnescapeBinaryURLComponent() should be used instead in most cases, particularly where URL_SPECIAL_CHARS_EXCEPT_PATH_SEPARATORS is in use, as all consumers of that option seem to either be slightly buggy, or don't actually need to leave any characters unescaped. The primary cases where switching to UnescapeBinaryURLComponent() may cause problems (without additional checks), are cases where unescaping path separators or funky characters (like %01) is a problem. In those places, we should generally fail instead of partially unescaping a URL. Bug: 849998 Change-Id: I009667ec4ccf92e49810ece56d5e2f8e9604a096 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598321 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
-
