GitLab

I changed analyzer such that if a gyp file (or an included gypi file)
changes all targets in the gyp file are marked as changed. This means
I should no longer have to special case gyp files. I'm leaving the
exception in place for any gyp files in build as any change to those
really needs to recompile the world.

BUG=109173
TEST=none
R=thakis@chromium.org

Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/5110e8b

Review URL: https://codereview.chromium.org/512693004

Cr-Commit-Position: refs/heads/master@{#293139}

disable browser_tests RequestContentScriptAPITest.PermissionMatcherAgreementInjection on Dr.Memory bots

TBR=bruening@chromium.org
BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/528353002

Cr-Commit-Position: refs/heads/master@{#293138}

BUG=382367

Review URL: https://codereview.chromium.org/466983004

Cr-Commit-Position: refs/heads/master@{#293137}

Revert of Recorded additional tough_energy_cases. (patchset #1 id:1 of https://codereview.chromium.org/506063002/)

Reason for revert:
Errors: "WARNING:root:The page set archives for some pages are missing. Someone forgot to check them in, or they were deleted. Skipping those pages. To fix this, record those pages using record_wpr. To ignore this warning and run against live sites, pass the flag --use-live-sites."

Example: http://chromegw/i/chromium.perf/builders/Win%208%20Perf%20%282%29/builds/3086/steps/tab_switching.tough_energy_cases/logs/stdio

Original issue's description:
> PERF SHERIFF: This CL changes the tough_energy_cases test.
>
> Recorded additional tough_energy_cases.
> Moved all test cases to codepen, so they're easy to edit and all http.
>
> BUG= 386152
>
> Committed: https://chromium.googlesource.com/chromium/src/+/f4919a56f8dde79db10d158940bab9b5a95688f0

TBR=tonyg@chromium.org,jeremy@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG= 386152

Review URL: https://codereview.chromium.org/535153003

Cr-Commit-Position: refs/heads/master@{#293136}

The declared output was incorrect, forcing a systematic rebuild.

R=dzhioev@chromium.org

Review URL: https://codereview.chromium.org/534263002

Cr-Commit-Position: refs/heads/master@{#293135}

Original description from commit 63e36e6b:

ui: Move ui_unittests.gyp into ui/base.

ui_unittests.gyp -> ui_base_tests.gyp (follow gfx_tests.gyp pattern).
ui_unittests_bundle.gypi -> ui/base/ui_base_tests_bundle.gypi
ui_unittests.isolate -> ui_base_tests.isolate

Add a TODO assigned to me to rename ui_unittests target to
ui_base_unittests when buildbot is updated.

It was reverted in commit 6297a2f1,
because a test from ui_unittests in ios_dbg_simulator started to
failing.

BUG=331829,373148,299841,103304
TEST=ui_unittests
R=sky@chromium.org,rohitrao@chromium.org

Review URL: https://codereview.chromium.org/518423002

Cr-Commit-Position: refs/heads/master@{#293134}

The unit test framework brings up blink, so we have an initialized
isolate we can just use.

BUG=none
R=andrewhayden@chromium.org,dmichael@chromium.org

Review URL: https://codereview.chromium.org/537543002

Cr-Commit-Position: refs/heads/master@{#293133}

UserMediaClientImpl's purpose is to implement blink::WebUserMediaClient and does not implement a MediaStream. Thus the class is renamed to reflect this.

BUG=409560

Review URL: https://codereview.chromium.org/524363003

Cr-Commit-Position: refs/heads/master@{#293132}

Review URL: https://codereview.chromium.org/538443003

Cr-Commit-Position: refs/heads/master@{#293131}

https://chromium.googlesource.com/chromium/blink/+log/19b54260b70e697c0dc31e29206cc564d1fbf114..104ecc5a02c328914490c6c17ccc8a17d8e40fca
TBR=tkent@chromium.org,arv@chromium.org

Review URL: https://codereview.chromium.org/529363004

Cr-Commit-Position: refs/heads/master@{#293130}

Cr-Commit-Position: refs/heads/master@{#293129}

Revert of Enable forced extension updates on NaCl arch mismatch (patchset #5 id:100001 of https://codereview.chromium.org/516293007/)

Reason for revert:
Chrome OS build with DCHECKs enabled fails on start. This CL breaks assumption, that GAIA extension can be loaded without performing IO-operations.

Log and stack trace:
[16275:16275:0903/161435:WARNING:renderer_freezer.cc(55)] Cgroup freezer does not exist or is not writable. Processes will not be frozen during suspend.
[16275:16275:0903/161435:WARNING:configuration_policy_pref_store.cc(30)] Policy RemoteAccessClientFirewallTraversal: This policy has been deprecated.
[16275:16275:0903/161437:FATAL:thread_restrictions.cc(38)] Function marked as IO-only was called from a thread that disallows IO!  If this thread really should be allowed to make IO calls, adjust the call to base::ThreadRestrictions::SetIOAllowed() in this thread's startup.
#0 0x7fe3122e555e base::debug::StackTrace::StackTrace()
#1 0x7fe31237c462 logging::LogMessage::~LogMessage()
#2 0x7fe3124824af base::ThreadRestrictions::AssertIOAllowed()
#3 0x7fe3123630a1 base::PathExists()
#4 0x7fe321cfd5f3 extensions::(anonymous namespace)::CollectPlatformSpecificResourceArchs()
#5 0x7fe321cfad22 extensions::Extension::InitFromValue()
#6 0x7fe321cfa490 extensions::Extension::Create()
#7 0x7fe321cfa114 extensions::Extension::Create()
#8 0x7fe3233ebe1b extensions::ComponentLoader::Load()
#9 0x7fe3233ec3cf extensions::ComponentLoader::Add()
#10 0x7fe3233ec32a extensions::ComponentLoader::Add()
#11 0x7fe3233ec2b0 extensions::ComponentLoader::Add()
#12 0x7fe32437505f (anonymous namespace)::LoadGaiaAuthExtension()
#13 0x7fe324374d5e extensions::GaiaAuthExtensionLoader::LoadIfNeeded()
#14 0x7fe324237f7e ScopedGaiaAuthExtension::ScopedGaiaAuthExtension()
#15 0x7fe322f68bb2 chromeos::WebUILoginView::Init()
#16 0x7fe322f556ef chromeos::LoginDisplayHostImpl::InitLoginWindowAndView()
#17 0x7fe322f52640 chromeos::LoginDisplayHostImpl::LoadURL()
#18 0x7fe322f5226a chromeos::LoginDisplayHostImpl::StartWizard()
#19 0x7fe322f54acd chromeos::LoginDisplayHostImpl::StartPostponedWebUI()
#20 0x7fe322f541f8 chromeos::LoginDisplayHostImpl::Observe()
#21 0x7fe322f54bfd chromeos::LoginDisplayHostImpl::Observe()
#22 0x7fe31b222377 content::NotificationServiceImpl::Notify()
#23 0x7fe322d51a24 chromeos::(anonymous namespace)::UserWallpaperDelegate::OnWallpaperAnimationFinished()
#24 0x7fe31188692f ash::RootWindowController::OnWallpaperAnimationFinished()
#25 0x7fe3117c633a ash::(anonymous namespace)::ShowWallpaperAnimationObserver::OnImplicitAnimationsCompleted()
#26 0x7fe311f72d30 ui::ImplicitAnimationObserver::CheckCompleted()
#27 0x7fe311f72cd5 ui::ImplicitAnimationObserver::SetActive()
#28 0x7fe311f965d5 ui::ScopedLayerAnimationSettings::~ScopedLayerAnimationSettings()
#29 0x7fe3117c5ec7 ash::DesktopBackgroundWidgetController::StartAnimating()
#30 0x7fe3117bbb0c ash::DesktopBackgroundController::InstallDesktopController()
#31 0x7fe3117bbc03 ash::DesktopBackgroundController::InstallDesktopControllerForAllWindows()
#32 0x7fe3117bb3cc ash::DesktopBackgroundController::SetDesktopBackgroundImageMode()
#33 0x7fe3117bb096 ash::DesktopBackgroundController::SetWallpaperImage()
#34 0x7fe322f9a6b9 chromeos::WallpaperManager::DoSetDefaultWallpaper()
#35 0x7fe322f99b73 chromeos::WallpaperManager::PendingWallpaper::ProcessRequest()
#36 0x7fe322fbac72 base::internal::RunnableAdapter<>::Run()
#37 0x7fe322fbabe9 base::internal::InvokeHelper<>::MakeItSo()
#38 0x7fe322fbaba5 base::internal::Invoker<>::Run()
#39 0x7fe3122cc9ce base::Callback<>::Run()
#40 0x7fe312488f86 base::Timer::RunScheduledTask()
#41 0x7fe3124890bc base::BaseTimerTaskInternal::Run()
#42 0x7fe312489382 base::internal::RunnableAdapter<>::Run()
#43 0x7fe3124892ec base::internal::InvokeHelper<>::MakeItSo()
#44 0x7fe312489295 base::internal::Invoker<>::Run()
#45 0x7fe3122cc9ce base::Callback<>::Run()
#46 0x7fe3122eb9b3 base::debug::TaskAnnotator::RunTask()
#47 0x7fe3123a1c57 base::MessageLoop::RunTask()
#48 0x7fe3123a1d9b base::MessageLoop::DeferOrRunPendingTask()
#49 0x7fe3123a228d base::MessageLoop::DoDelayedWork()
#50 0x7fe3122a1f25 base::MessagePumpGlib::Run()
#51 0x7fe3123a17f0 base::MessageLoop::RunHandler()
#52 0x7fe3124093b2 base::RunLoop::Run()
#53 0x7fe324217e4d ChromeBrowserMainParts::MainMessageLoopRun()
#54 0x7fe31ad2a8bf content::BrowserMainLoop::RunMainMessageLoopParts()
#55 0x7fe31ad344c7 content::BrowserMainRunnerImpl::Run()
#56 0x7fe31ad251b1 content::BrowserMain()
#57 0x7fe31abb997f content::RunNamedProcessTypeMain()
#58 0x7fe31abbcce8 content::ContentMainRunnerImpl::Run()
#59 0x7fe31abb8ee5 content::ContentMain()
#60 0x7fe3206d3505 ChromeMain
#61 0x7fe3206d34b2 main

Cannot upload crash dump: cannot exec /sbin/crash_reporter

Crash_reporter failed to process crash report

Original issue's description:
> Enable forced extension updates on NaCl arch mismatch
>
> This makes extensions aware of the platforms for which
> they have platform-specific resources installed, if any.
>
> This also hooks up the extension update code with some
> additional logic to place an extension in forced-update
> mode if it has platform-specific resources which don't
> match the current NaCl architecture.
>
> BUG=409948
> TEST=install an extension which uses NaCl (QuickOffice for example). Rename the _platform-specific/<your-nacl-arch> directory some something else and force an update (e.g. via chrome://extensions button). Observe that a new CRX is downloaded and installed.
>
> Committed: https://chromium.googlesource.com/chromium/src/+/4a92281fa5d331860d65a59ba45dc882a5c71df4

TBR=sorin@chromium.org,yoz@chromium.org,shuchen@chromium.org,rockot@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=409948

Review URL: https://codereview.chromium.org/532183003

Cr-Commit-Position: refs/heads/master@{#293128}

BUG=402684

Review URL: https://codereview.chromium.org/517273004

Cr-Commit-Position: refs/heads/master@{#293127}

Summary of changes available at:
https://chromium.googlesource.com/chromium/deps/icu52/+log/ff8353094b0b..89831135d5f7

BUG=409851
TBR=jshin@chromium.org

Review URL: https://codereview.chromium.org/539463002

Cr-Commit-Position: refs/heads/master@{#293126}

This CL fixes an issue where the NativeViewHostAura clipping window would
not be hidden correctly and steal mouse events from the experimental app
list. This CL simply hides the clipping window when the NativeViewHost
is hidden.

BUG=408877

Review URL: https://codereview.chromium.org/517143003

Cr-Commit-Position: refs/heads/master@{#293125}

Original patch can be found at https://codereview.chromium.org/534533002

TBR=tommi
BUG=NONE

Review URL: https://codereview.chromium.org/535033003

Cr-Commit-Position: refs/heads/master@{#293124}

The new avatar menu has multiple views, and on any view, the avatar menu
change event may occur and trigger refresh. Thus instead of always refreshing
with the profile chooser view mode, we should refresh with the current view mode.

BUG=

Review URL: https://codereview.chromium.org/530113002

Cr-Commit-Position: refs/heads/master@{#293123}

BUG=231331
R=ygorshenin@chromium.org

Review URL: https://codereview.chromium.org/494473003

Cr-Commit-Position: refs/heads/master@{#293122}

This CL adds descriptions to dictionaries.

TEST=Tested manually with a test server.
BUG=248427

Review URL: https://codereview.chromium.org/527723002

Cr-Commit-Position: refs/heads/master@{#293121}

This patch adds nullability validation of handles and
pointers upon struct serialization in the Java bindings.

BUG=324170

Review URL: https://codereview.chromium.org/524703004

Cr-Commit-Position: refs/heads/master@{#293120}

This is a modified due to the regression caused by
https://codereview.chromium.org/415343003/. The test case now checks the
number of items in the menu list to not include items with "display: none"

[1] https://codereview.chromium.org/475723002/ patch that fixes the regression.

BUG=398051,403299
R=tkent

Review URL: https://codereview.chromium.org/475733002

Cr-Commit-Position: refs/heads/master@{#293119}

Thanks to vabr@ for reproducing.

BUG=409589
TBR=rohitrao

Review URL: https://codereview.chromium.org/528213004

Cr-Commit-Position: refs/heads/master@{#293118}

BUG=370929
TBR=skuhne@chromium.org

Review URL: https://codereview.chromium.org/471973002

Cr-Commit-Position: refs/heads/master@{#293117}

This fixes RedirectToUserSpacePolicyWrapper to
handle ERRNO ErrorCodes that are behind Conditional
ErrorCodes.

BUG=408953
TEST=sandbox_linux_unittests: Added new test

Review URL: https://codereview.chromium.org/524603002

Cr-Commit-Position: refs/heads/master@{#293116}

To support unbundled updates we need to stop depending on system
libraries. Disable using the system version of libexpat and instead link
Chromium's copy, and stop removing the expat sources from the checkout.

This increases binary size by ~64KB.

Also remove an obsolete comment about using the system version of
sqlite; this was never implemented and now will not be.

BUG=409851

Review URL: https://codereview.chromium.org/534603002

Cr-Commit-Position: refs/heads/master@{#293115}

TBR=jarin@chromium.org

Review URL: https://codereview.chromium.org/537523002

Cr-Commit-Position: refs/heads/master@{#293114}

Also, remove the deprecated base::MessageLoop::Run() calls
everywhere in dbus unittests.

BUG=365669
R=armansito@chromium.org

Review URL: https://codereview.chromium.org/523623003

Cr-Commit-Position: refs/heads/master@{#293113}

On windows depending on system/keyboard setting right alt (alt gr) can be
seen as alt+ctrl. This is also true for sending VKEY_MENU via SendInput,
probably because it is treated as any alt key. To avoid intorducing
unwanted ctrl key in sequence use VKEY_LMENU which will only add alt key
without a risk of adding ctrl key regardless of system setup.
The change fixes CommandsApiTest.DontOverwriteSystemShortcuts test timout.
Test expected alt+shift+f, but what was received was ctrl+alt+shift+f.

BUG=409567

Review URL: https://codereview.chromium.org/526063002

Cr-Commit-Position: refs/heads/master@{#293112}

This essentially reverts http://crrev.com/531583002. The super
call is necessary for measuring children, however the super call
should also happen before the call th mAwContents.onMeasure to
make sure the right set of measuredDimensions are used.

BUG=None
TEST=AndroidWebViewTest
TBR=boliu@chromium.org

Review URL: https://codereview.chromium.org/536873002

Cr-Commit-Position: refs/heads/master@{#293111}

Add mips64 atomicops to protobuf.

BUG=400684

Review URL: https://codereview.chromium.org/517273003

Cr-Commit-Position: refs/heads/master@{#293110}

Hold __FUNCTION__ in DoDelete stack to identify for which class DoDelete() is called on the core dump.

BUG=393634

Review URL: https://codereview.chromium.org/522643003

Cr-Commit-Position: refs/heads/master@{#293109}

BUG=none
R=machenbach@chromium.org

Review URL: https://codereview.chromium.org/531003002

Cr-Commit-Position: refs/heads/master@{#293108}

My changes are mostly in these CLs:
https://codereview.chromium.org/131003006
https://codereview.chromium.org/139443004
https://codereview.chromium.org/183223003
https://codereview.chromium.org/246253014
https://codereview.chromium.org/226523003

Review URL: https://codereview.chromium.org/403323004

Cr-Commit-Position: refs/heads/master@{#293107}

We need, for example, to test that ServiceWorkers can't be registered on
unauthenticated origins[1]. This patch allows '*.test' as a valid URL
for tests, and teaches content shell how to resolve them if (and only
if) the '--dump-render-tree' flag is set.

'.test' is a reserved gTLD[3], and is also used by the W3C's Web Platform
Tests[3]; it seems like the best choice of suffix for layout tests.

[1]: http://w3c.github.io/webappsec/specs/mixedcontent/#authenticated-origin
[2]: http://newgtlds.icann.org/applicants/agb
[3]: https://github.com/w3c/web-platform-tests#running-the-tests

BUG=410190

Review URL: https://codereview.chromium.org/529403002

Cr-Commit-Position: refs/heads/master@{#293106}

This generates constants for the python bindings.

R=pkl@chromium.org,cmasone@chromium.org

Review URL: https://codereview.chromium.org/517353002

Cr-Commit-Position: refs/heads/master@{#293105}

BUG=110610

Review URL: https://codereview.chromium.org/509423002

Cr-Commit-Position: refs/heads/master@{#293104}

It isn't necessary to mess around with sharing CGLContextObjs anymore,
they were necessary only to share data between the frame subscriber
and the RenderWidgetHostViewMac. Just give each IOSurfaceLayer its
own CGLContextObj, and draw using immediate mode (using shaders
resulted in an increase in startup time).

BUG=314190
TBR=pfeldman@chromium.org
R=kbr@chromium.org

Review URL: https://codereview.chromium.org/490393002

Cr-Commit-Position: refs/heads/master@{#293103}

This reverts commit 03573630 for
breaking Android build.

TBR=henrika@chromium.org

Review URL: https://codereview.chromium.org/538443002

Cr-Commit-Position: refs/heads/master@{#293102}

The test assumes the "Google Chrome.app" bundle is in the same directory
as the browser_tests binary. It probably isn't on the official builders.

Disable these until we have a workaround.

TBR=tapted@chromium.org, rsesek@chromium.org

BUG=409615

Review URL: https://codereview.chromium.org/532173002

Cr-Commit-Position: refs/heads/master@{#293101}

Previously, only apps were allowed to use this api, however most clients will
be actually written as extensions.

TEST=browser_tests: *FileSystemProvider*Extension*
BUG=409487

Review URL: https://codereview.chromium.org/527663002

Cr-Commit-Position: refs/heads/master@{#293100}