- 06 Feb, 2018 40 commits
-
-
yiyix authored
In the current implementation, the copy request is handled by DelegatedFrameHost::RequestCopyOfOutput, which add copy request to the compositor frame of the browser. After this patch, the copy request will be handled by the CompositorFrameSinkSupport:RequestCopyOfSurface which adds the copy request to the surface where the copy request needs to be make. TEST: exiting test cases on copy requests should cover all the usage Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I5c0b4572a7b8ed5fce0f5ee10f5d4dd982912e0a Reviewed-on: https://chromium-review.googlesource.com/881548Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#534838}
-
Ted Choc authored
BUG= Change-Id: I5372417f961594c3907ebde5f38a1512c83f189d Reviewed-on: https://chromium-review.googlesource.com/903182Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Commit-Queue: Maria Khomenko <mariakhomenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#534837}
-
Jacob Dufault authored
- keep_alive ensures we do not exit/shutdown. - drag'n'drop disables drag and drop. Bug: 784495 Change-Id: I65525cf5065db48bc14db93af3f3b6e86bc715c7 Reviewed-on: https://chromium-review.googlesource.com/871835 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#534836}
-
Jinsuk Kim authored
Reporte crash can happen if |ContentViewCore.onRotationChanged| is called after CVC is destroyed, therefore mWebContents is set to null. Added null check against the variable to prevent crash. Bug: 808971 Change-Id: I7719d2d0c26b36b94eeff406d655512111e58c2d Reviewed-on: https://chromium-review.googlesource.com/903342Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#534835}
-
Allen Vicencio authored
Implements WriteFile in SmbFileSystem using TempFileManager. Bug: chromium:757625 Change-Id: I176079aca1bb752f628c86942f2ee89b46c19729 Reviewed-on: https://chromium-review.googlesource.com/894983Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Allen Vicencio <allenvic@chromium.org> Cr-Commit-Position: refs/heads/master@{#534834}
-
https://chromium.googlesource.com/catapult.git/+log/e6e84629dbe5..874bc7c4eabb $ git log e6e84629d..874bc7c4e --date=short --no-merges --format='%ad %ae %s' 2018-02-06 charliea Disable all CPU tracing agent integration tests on Windows Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I8468b18bb72c450df3d79595fa2788204d52d857 Reviewed-on: https://chromium-review.googlesource.com/905460Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#534833}
-
Dirk Pranke authored
This bumps the experimental builder to 50% and also marks it as "compile_only", which means that we don't include any debug symbols (this speeds up the build). R=jbudorick@chromium.org BUG=694033 Change-Id: I73713462395bcc360172883aa898af72c8a8ecd7 Reviewed-on: https://chromium-review.googlesource.com/898366Reviewed-by:
John Budorick <jbudorick@google.com> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#534832}
-
Nico Weber authored
Fixes a bug where memory-infra tracing would count private_dirty memory also as shared_dirty memory in a certain detail view (but not in aggregates). Record a memory-infra trace as described on https://chromium.googlesource.com/chromium/src/+/lkcr/docs/memory-infra/ then click a memory dump, click e.g. "Browser" in the Analysis view, scroll down, and click the triangle toggle next to Total and then Native heap. Before this change, entries with "Private dirty" != 0 would always have the same value in the "Shared dirty" column (but not the other way round). After this change, at most one of the two columns is != 0. Actually turning on the warning is blocked on an issue in protobuf (see crbug.com/809157), so this will happen in a future CL. TBR=sky Bug: 177475 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I663f225f817accd5ee7319e33e2779aafd9c85c6 Reviewed-on: https://chromium-review.googlesource.com/902065 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#534831}
-
Nektarios Paisios authored
Paper-button-light doesn't support the alt property, so aria-label should be used instead. R=dmazzoni@chromium.org, fukumi@chromium.org Tested: Manually using Jaws Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8db2a1c399f41fafc577634062df37972a80a816 Reviewed-on: https://chromium-review.googlesource.com/890778Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#534830}
-
Jinsuk Kim authored
This CL replaces |getSelectPopupForTesting| with the one that simply returns its visibility (showing or hidden), which is enough for testing purposes. It helps CVC not return/expose non-public class when moved to content_public https://crrev.com/c/900884 Bug: 807155 Change-Id: I8dbdace17ace9068ee7807dfa1abf7ac85f4c357 Reviewed-on: https://chromium-review.googlesource.com/902982Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#534829}
-
https://skia.googlesource.com/skia.git/+log/2fb7c8aef57e..744160486520 $ git log 2fb7c8aef..744160486 --date=short --no-merges --format='%ad %ae %s' 2018-02-06 angle-skia-autoroll Roll skia/third_party/externals/angle2/ bfeed4ddf..ca5c10598 (1 commit) 2018-02-06 reed Can't correctly call computeFastBounds on maskfilter w/ device geo 2018-02-05 halcanary SkQP: download_model complains when files.checksum is missing 2018-02-06 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 2d1c0a2b8..bfeed4ddf (1 commit) 2018-02-06 stephana Remove ConstraintLayout from skqp app 2018-02-06 bsalomon Revert "move GrColor.h to private, IWYU" 2018-02-06 skcms-skia-autoroll Roll skia/third_party/externals/skcms/ 6fd3bac65..2908ce856 (1 commit) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=bsalomon@chromium.org Change-Id: I58a89fe497e14f31153acb5f223423d8a4f9bd02 Reviewed-on: https://chromium-review.googlesource.com/905446 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#534828}
-
Tibor Goldschwendt authored
Bug: 799074 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I06c20525b10187804949ed9bed7485e483802d15 Reviewed-on: https://chromium-review.googlesource.com/903047Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#534827}
-
Elad Alon authored
WebRtcRemoteEventLogManager is a member of WebRtcEventLogManager, in charge of managing remote-bound WebRTC event logs: * Store remote-bound log files locally, persisting them between session of Chrome. * Uploading them when permissible (when no active peer connections are present, with which the upload's increased bandwidth utilization might interfere). * Purge remote-bound log files from local disk once an upload attempt was made, regardless of whether it was successful. (Otherwise, we might end up attempting multiple times, wasting bandwidth on an upload that always fails after a non-trivial amount of data was pushed upstream. More refined retry behavior is to be added at a later stage.) Upcoming related work: * Actual implementation of the uploader (this CL deals with managing the files to be uploaded, and the timing of the upload). * Implementation of the JS hooks. Bug: 775415 Change-Id: Ib5ee6081ca13d85cb8a3f38d6462bbd61a99dcae Reviewed-on: https://chromium-review.googlesource.com/891219 Commit-Queue: Elad Alon <eladalon@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#534826}
-
Ehsan Chiniforooshan authored
Since most tracing agents only care about receiving start/stop tracing signals, a default implementation is provided for other methods to reduce boilerplate code. Bug: 808839 Change-Id: I4645add6e7e81a25d0e923c8afcdf8f5dc3a7a13 Reviewed-on: https://chromium-review.googlesource.com/868575 Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#534825}
-
dpapad authored
It was missed in r533917. Bug: 809381,808182 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I4b7d574e2a1f6b3522547def1b2c6615e974143a Reviewed-on: https://chromium-review.googlesource.com/904851 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
-
Bence Béky authored
Use GetPromisedUrlFromHeaderBlock() instead of GetUrlFromHeaderBlock() for pushed HTTP/2 headers. Remove dangerous GetDefaultUrlWithPath() and inline pushed URLs instead in SpdyNetworkTransactionTests. Pass URL from SpdySession to SpdyStream so that GetUrlFromHeaderBlock() does not need to be called once more. Change-Id: Ibc51015d20d0f5a3cf1431ad668feff1662a178a Reviewed-on: https://chromium-review.googlesource.com/896808 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#534823}
-
Lakshmi Kumar Dabbiru authored
Refer Sashi CL - https://codereview.chromium.org/2855943002/ Bug: 717665 Change-Id: If7a5214d05786f5959a5619dc727b68e6c462ec Tried to start local demo, but sign-in is not working. Change-Id: If7a5214d05786f5959a5619dc727b68e6c462ec8 Reviewed-on: https://chromium-review.googlesource.com/903057 Commit-Queue: Lakshmi Kumar Dabbiru <dlkumar@google.com> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#534822}
-
Dirk Pranke authored
This increases the bot from 25->50% of the load, and since the bots are compile only, turns symbols completely off, which should speed things up. R=jbudorick@chromium.org BUG=777642 Change-Id: I43505426e665f7ade473db9ed46f172be94c1e5c Reviewed-on: https://chromium-review.googlesource.com/898350Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
-
Xida Chen authored
I had this CL that implements animation specific UMA: https://chromium-review.googlesource.com/c/chromium/src/+/636305 In particular, we record frame rate when there is main thread / compositor / main thread compositable animations in this frame. However, the main thread compositable animations is not calculated correctly in the above CL. The result of that is a crash which is tracked in crbug.com/781305. In order to solve the crash, we temporary disabled the main thread compositable animation UMA in here: https://chromium-review.googlesource.com/c/chromium/src/+/753405 Now it is time to re-enable that UMA. This is how we check whether an animation is main thread compositable or not: we first check whether the effects can start on compositor or not. For example, a transform animation will be able to start on compositor. Then we check whether the target element can start on compositor or not. If the target element is not paint into its own backing, we know that this is due to a running experiment. The problem with the above logic is SVG element. For example, if we have a transform animation on an SVG element, the effect can be started on compositor but the SVG element cannot start on compositor. In order to tell whether this is a main thread compositable, we have to exclude the SVG element. This CL fixed the problem. It re-enables a unit test and added another test for SVG element. Bug: 781305 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I030f2e7d2061589ccb0a62f12744b1097855f2f7 Reviewed-on: https://chromium-review.googlesource.com/895409Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#534820}
-
Sergey Ulanov authored
Previously third_party/content_shell_fonts were used on Linux, but not Android. Updated the scripts to use it instead of the the files provided by Linux distro. Bug: 787020 Change-Id: Idf71c65a45466682f25a23474dcc67925af59466 Reviewed-on: https://chromium-review.googlesource.com/903240Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#534819}
-
Danyao Wang authored
This is a reland of 295cd31f. Original change's description: > [Nav Experiment] Update NavigationItem URL for location.replace. > > location.replace changes the URL of WKBackForwardListItem. Update the > URL of NavigationItem to that of the host WKBackForwardListItem upon > access. It's done this way because location.replace cannot be reliably > distinguished from normal navigations in either WKNavigationDelegate > callback or URL KVO. > > This fixes NavigationTestCase/testWindowLocationReplaceAndChangeHash. > > Bug: 807428 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Change-Id: Iaef4ed5efd788283050b43a3b4e988311ec9cf76 > Reviewed-on: https://chromium-review.googlesource.com/894490 > Commit-Queue: Danyao Wang <danyao@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#533315} Bug: 807428 Change-Id: I2f237fe6a03b38592eccf1adedcf8c5679552201 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/900103 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#534818}
-
Alexei Svitkine authored
https://chromium-review.googlesource.com/c/chromium/src/+/902769 Adds missing <algorithm> include for std::min. BUG=none Change-Id: I1e4dd1ef72f9c28f5aa6836b8ac1a7fb1f532f47 Reviewed-on: https://chromium-review.googlesource.com/905204Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#534817}
-
Andrey Kosyakov authored
TBR=anthonyvd Bug: 809609 Change-Id: I5ed542e233feae2bc6c5faa34805837c7f0ee555 Reviewed-on: https://chromium-review.googlesource.com/905096Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#534816}
-
https://chromium.googlesource.com/angle/angle.git/+log/44dcb911c00e..bfeed4ddfcd6 $ git log 44dcb911c..bfeed4ddf --date=short --no-merges --format='%ad %ae %s' 2018-02-06 oetuaho Add a compiler perf test shader to stress traversers 2018-02-02 jie.a.chen Vulkan: Fix gcc compile error Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Idb785881123594bea526ff1339a20ba97d01ef10 Reviewed-on: https://chromium-review.googlesource.com/905402 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#534815}
-
rbpotter authored
Enable the print button in the new print preview UI. Bug: 773928 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I27a8b99e3ce23ebe718214c4eee0ab92e6b48713 Reviewed-on: https://chromium-review.googlesource.com/892399Reviewed-by:
-
Carlos Knippschild authored
This CL includes a group of minor fixes and improvements that will ease the testing of Prefetching with limitless mode enabled: * Fixes comments in PrefetchBackgroundTaskScheduler. * Improves handling of invalid URLs and text output from OfflineInternalsUIMessageHandler. * Improve debug logging in MetricsFinalizationTask. * Use larger bundle size limit for GeneratePageBundleRequest in PrefetchNetworkRequestFactoryImpl when limitless mode is enabled. * Complete TODO to make method private in SuggestedArticlesObserver. Bug: 793109 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic4c1931e6c8ab8f5bf2fdd8cfec8075f30a9b6cd Reviewed-on: https://chromium-review.googlesource.com/869373 Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Dmitry Titov <dimich@chromium.org> Cr-Commit-Position: refs/heads/master@{#534813}
-
Weidong Guo authored
Change: Replace kOlderFolders with kFullscreenAppListFolders. BUG=809324 Change-Id: Ib2f779fcd5e71a8e7a826c53b21ddaaf74126a22 Reviewed-on: https://chromium-review.googlesource.com/903412Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#534812}
-
Allen Vicencio authored
Bug: chromium:757625 Change-Id: I0f68e43c7f9700d3d02d640d36c2d9a4523b4495 Reviewed-on: https://chromium-review.googlesource.com/894167Reviewed-by:
-
Mostyn Bramley-Moore authored
content/browser/loader/loader_io_thread_notifier.cc has the following include chain: content/browser/frame_host/render_frame_host_impl.h -> content/public/browser/content_browser_client.h -> device/usb/public/mojom/chooser_service.mojom.h (generated header) And so //content/browser needs a //device/usb/public/mojom dep. This was previously only added in //content/public/browser and could therefore cause build flakiness. Bug: 806965 Change-Id: I6d5254cd427fc6a6b1cfaefb26a2eb4056f62638 Reviewed-on: https://chromium-review.googlesource.com/903165Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
-
Dmitry Gozman authored
It does timeout sometimes on Win. Bug: 667560 Change-Id: I2047340ce939414ce19b1ddc61d4423d35e12e2d Reviewed-on: https://chromium-review.googlesource.com/904771Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#534809}
-
Theresa authored
* "Modernizes" ntp - change bg color, tweak values for fake search box to real omnibox transition, change fake search box bg, update tablet style * Increases modern toolbar background height to 40dp * Fixes an omnibox suggestions alignment issue in RTL to better align with omibox actions container * Updates toolbar shadow for NTP scroll * Moves toolbar primary color initialization to ToolbarModelImpl constructor BUG=803087,803088 Change-Id: Ic656b5de656296c3fe592e5a0a3e106472fa0419 Reviewed-on: https://chromium-review.googlesource.com/902966Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#534808}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a24f6910..a462f872 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I45ba3fe78139547c4627dd56cb136c60c3368c6b Reviewed-on: https://chromium-review.googlesource.com/905102Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#534807}
-
Lei Zhang authored
The feature has lived on for too long in a broken state, and just makes the code more complicated than necessary. Remove the rendering code that deals with generating draft pages. There still exists browser side code to be removed later. This CL makes a PrintPreviewFailureType enum value obsolete. While marking it as deprecated, also fix another issue with PrintPreviewFailureType where the wrong enum got marked as deprecated. BUG=746768 Change-Id: I5a61770d034ff33add6f4070984e46fa0a02b221 Reviewed-on: https://chromium-review.googlesource.com/899855 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#534806}
-
Daniel Erat authored
Update DriveMetricsProvider::HasSeekPenalty() to not compare base::SysInfo::GetStrippedReleaseBoard() against "parrot" to determine if the device has a rotating disk. parrot stopped receiving updates in October 2017 (see https://support.google.com/chrome/a/answer/6220366), and code that wants to know if a rotating disk is present should either read the "rotational" sysfs node or use the "has_hdd" USE flag. Hardcoding device names in Chrome is fragile: if someone brings up a new device with a rotating disk, they're not going to know about miscellaneous Chrome code that needs to be updated (and they're likely not even a Chrome developer). Bug: none Change-Id: I2a8d3dce3a51546ba96e3f4cb7c5c2d4d9d8b2a9 Reviewed-on: https://chromium-review.googlesource.com/905464 Commit-Queue: Dan Erat <derat@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#534805}
-
Stephen McGruer authored
As pointed out by jbroman@ during a review, null offsets will violate the requirements of std::sort. Luckily CompareOffsets is only ever used where offsets will be non-null, so enforce that in the code. Also since it is used exactly once, just inline it. Bug: 791086 Change-Id: I9df7f1201fdc3024a727c62bfd7e917791de12b6 Reviewed-on: https://chromium-review.googlesource.com/905100 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#534804}
-
Chris Nardi authored
According to the CSSOM spec [1], all strings should be serialized with double-quotes. The axis name in font-variation-settings was previously serialized with single-quotes; change this to double-quotes to match the spec and non-WebKit browsers. [1]: https://drafts.csswg.org/cssom/#common-serializing-idioms Bug: 806412 Change-Id: Ib0da551c2799a9dc4e273ac150972a7bd5c7a34f Reviewed-on: https://chromium-review.googlesource.com/900843Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Chris Nardi <cnardi@chromium.org> Cr-Commit-Position: refs/heads/master@{#534803}
-
Patrick Hulce authored
* Adds FirstContentfulPaint to timeline markers * Adjusts colors of paint markers to different shades of green BUG=749814 Change-Id: I4ccbcae4c6906d9fbacc8a81eb55b6059f55f472 Reviewed-on: https://chromium-review.googlesource.com/619500Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Patrick Hulce <phulce@chromium.org> Cr-Commit-Position: refs/heads/master@{#534802}
-
Katie D authored
This increases test coverage in select-to-speak by creating a class to be responsible for JS extension end-to-end tests for search+mouse. Bug: 800524 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I81cbe9eee1965e5bb5c58dea8deee8eecffeda45 Reviewed-on: https://chromium-review.googlesource.com/898251 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#534801}
-
Jonathan Backer authored
QueryTracker was tightly coupled to GLES2Implementation. This CL adds a new QueryTrackerClient interface that GLES2Implementation implements. This will allow reuse by a RasterImplementation. Bug: 789238 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I752663df76a29d026391190bdfb62e70e732d2e9 Reviewed-on: https://chromium-review.googlesource.com/902201 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
Victor Miura <vmiura@chromium.org> Cr-Commit-Position: refs/heads/master@{#534800}
-
Weidong Guo authored
Changes: Since new style folder is paged horizontally, Up and down key should move focus only within a single page. Thus, hitting up key when focus is on the first row in current page moves the focus onto the search box and hitting down key when focus is on the last row in current page moves the focus onto the folder title. Specs: See "Focus change" section in go/applist-focus BUG=809316 Change-Id: Ic21e76ad176e117a4789fdba5b6428796ed99064 Reviewed-on: https://chromium-review.googlesource.com/903374 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
-
