GitLab

The profile chooser should not be shown when off the record. The button
still shows but cannot be selected.

Bug: chromium:822070
Change-Id: I40d9cf451444d8f16053282c638ee46abcca2af3
Reviewed-on: https://chromium-review.googlesource.com/984398Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547067}

This subpage and link to it are hidden when the
--enable_experimental_accessibility_features flag is on.

Currently the subpage has no functionality, but what exists does match
the UI mock, except that I've also added a description to the link to
the subpage that lets users know they can manage TTS engines from that
page.

Bug: 823359
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ia3e049cb0c9b64e861a7981d29a6642061029275
Reviewed-on: https://chromium-review.googlesource.com/969322Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547066}

Reading blobs that are loaded from IDB seem to be flaky. Large value
wrapping is a big customer of IDB blobs, so disable this for now while
the problem is investigated.

Bug: 756447
Change-Id: I64e46803d7433cbf6c701457c8e96028a015d74f
Reviewed-on: https://chromium-review.googlesource.com/987207
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547065}

BUG=827365

Change-Id: I494e7d01245cd91864cb49ab9a64990f1be93752
Reviewed-on: https://chromium-review.googlesource.com/987240Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547064}

This CL adds two classes for the suggestion and keyword views within an
OmniboxResultView. The intent is to move many of the members of
OmniboxResultView to one of the new classes. This CL doesn't move the
code yet. This Cl is boilerplate for the new classes. This is done to
better focus following CLs that will move code.

Bug: None
Change-Id: I0e9c766afef9c8cb13ff3b2a9b01a85c2041c51e
Reviewed-on: https://chromium-review.googlesource.com/980798
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547063}

Add animation for the Android toolbar view to slide in when JavaScript
tab modal dialog is showing and the renderer is blocked on input events.

Bug: 817461
Change-Id: I3ed69ffabe736100ac209be59f34eeedd4189cee
Reviewed-on: https://chromium-review.googlesource.com/942378
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547062}

Change-Id: Ie95ff321b2f5cdb0448e83bbba3a77b7954aab34
Reviewed-on: https://chromium-review.googlesource.com/987102
Commit-Queue: Carlos IL <carlosil@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547061}

This ports the following wiki pages into markdown:
https://www.chromium.org/developers/testing/gpu-testing
https://www.chromium.org/developers/testing/gpu-testing/gpu-bot-details
https://www.chromium.org/developers/how-tos/gpu-wrangling
https://www.chromium.org/developers/how-tos/debugging-gpu-related-code

and updates *some* of the old outdated content.

Bug: 813153
Change-Id: Ic5f1b58659bbdb691343785cb18c50f4d55c177f
Reviewed-on: https://chromium-review.googlesource.com/987233Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547060}

- Creates History Coordinator and TableViewController files.
- The Coordinator presents a TableViewContainer with the newly created HistoryTableVC.
- HistoryTableVC is no-op, only inherits from ChromeTableVC.

Screenshot:
https://drive.google.com/open?id=1FuHK2MaTRNCJ9HhkBZO3zGPjEiRY7Ih1

Bug: 805192
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ia090ed755e5a67097cf21b88fad0d198b405e8bf
Reviewed-on: https://chromium-review.googlesource.com/985235Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547059}

This was just needless indirection.

BUG=none
TEST=none
TBR=rohitrao

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I9b052d50e21b29e5a18181c99f0b4be974e10046
Reviewed-on: https://chromium-review.googlesource.com/987101Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547058}

Bug: 773295
Change-Id: I5a1783b49d8e20119843af96919bc341d6612f6e
Reviewed-on: https://chromium-review.googlesource.com/986675
Commit-Queue: Mark Pilgrim <pilgrim@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547057}

I introduced a bad feature flag infobar for SignedHTTPExchange.
[1] https://chromium.googlesource.com/chromium/src/+/a753229
This CL introduced the bad flag infobar to Android Chrome not only for
SignedHTTPExchange but also for all bad flags which are listed as kBadFlags in
bad_flags_prompt.cc.
Before this CL, Android Chrome didn't show any bad flag infobar.

This change caused parformance regressions because a bad flag
"--ignore-certificate-errors-spki-list" is used for perfomance testing.
(crbug.com/822258#c13)

So I added the check of "--enable-automation" flag in ShowBadFlagsPrompt().
[2] https://chromium.googlesource.com/chromium/src/+/33b13b2
And I added --enable-automation flag in GetFromBrowserOptions() in catapult.
[3] https://chromium.googlesource.com/catapult.git/+/df3154e
I thought that this check already existed in startup_browser_creator_impl.cc for
Desktop not to show the infobar during tests.
But on Desktop, a infobar for the automation is always shown when the flag is set.
https://chromium.googlesource.com/chromium/src/+/7a66b24

After the CL [3] pixel_tests are failing on Windows.
https://chromium-review.googlesource.com/c/chromium/src/+/969827
And Catapult AutoRoll is being blocked by the failure.
https://crbug.com/824779
I think this is due to the shadow of the infobar.

What I wanted to do was to show the infobar for SignedHTTPExchange.
And I think we don't need to show the bad flag infobar on Android for the flags
which can't be added on non-rooted devices.

So this CL changes the behavior of Android Chrome to show the the infobar only
for flags which are available in about:flags.


Bug: 825082,803774,822258
Change-Id: Ieee2bee3f31219645c642d9238599ff82483feeb
Reviewed-on: https://chromium-review.googlesource.com/977252
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547056}

Change-Id: I30afa26406d7313a220fada540f211026bf255f9
Reviewed-on: https://chromium-review.googlesource.com/985963Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Paul Irish <paulirish@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547055}

This cl adds the mechanism to make Keyboard Shortcut Viewer (KSV)
searchable in launcher.
1. Adds an InternalDataSource.
2. Adds an InternalAppResult.
3. Adds unit tests for searching internal app.

Bug: 790748
Test: manual and AppSearchProviderTest.FetchInternalApp
Change-Id: I8cae318b51d75516575c9b02cb7565b1dc748951
Reviewed-on: https://chromium-review.googlesource.com/982995
Commit-Queue: Tao Wu <wutao@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547054}

When ServiceWorkerServicification is enabled, this CL is to make
ServiceWorkerURLLoaderJob and ServiceWorkerSubresourceLoader work without
NetworkService. This CL tries to create an URLLoaderRequestHandler for a service
worker (ServiceWorkerControlleeRequestHandler) even if no NetworkService flag.

ServiceWorkerServicification still doesn't work since
ServiceWorkerURLLoaderJob::ProceedWithResponse() hasn't been implemented yet.

Bug: 752394
Change-Id: I808346f248bba254e20e708d372dde46ecc103fe
Reviewed-on: https://chromium-review.googlesource.com/888361Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547053}

Since notification_helper is a standalone executable, adding UMA support for
it needs extra work. We need to create persistent histograms in memory and
write the memory to a file upon exit of the process. These files are
accumulated inside a new directory called NotificationHelperMetrics under User
Data directory, and will eventually be reported by the browser process.

This CL moves persistent_histogram_storage.{h,cc} from chrome/installer/setup
to base/metrics as the class is now also used by notification_helper.exe, in
addition to setup.exe. This CL updates this class for general-purpose usage,
and adds unit tests for it.

This CL also logs the runtime of the notification_helper process to UMA.

Bug: 734095
Change-Id: Ia95f002378718b0e033f8da1aa7c260ec04030c3
Reviewed-on: https://chromium-review.googlesource.com/959543
Commit-Queue: Xi Cheng <chengx@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547052}

This is a re-land of 865455, which actually works.

TEST=ran video_decoder ppapi example

Bug: 754986
Change-Id: Ibf0e20244173b8ade0c1fca134825b2cd2ace660
Reviewed-on: https://chromium-review.googlesource.com/902459
Commit-Queue: Fredrik Hubinette <hubbe@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547051}

This is a simple mitigation, but not a complete fix, for
crbug.com/488043 and crbug.com/823387. It is intended to improve
robustness against both those sorts of bugs, and also against servers or
proxies which repeatedly request auth for whatever reason.

Although RestartWith* calls are typically associated with a user prompt,
but in other scenarios (remembered preferences, extensions, multi-leg
authentication), they may be triggered automatically. To avoid looping
forever, bound the number of restarts.

This will be followed by the complete fix for crbug.com/823387, but this
is intended to be small enough to hopefully merge.

Bug: 488043, 823387
Change-Id: Ieb0193ba7aad93efe6e7e1e4cf3355c1fb53f811
Reviewed-on: https://chromium-review.googlesource.com/986677Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547050}

Change-Id: I484eff5ebcd86ff973a57eeaa01715a06ac5983f
Reviewed-on: https://chromium-review.googlesource.com/986594Reviewed-by: Helen Li <xunjieli@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547049}

This base::RefCountedMemory subclass owns a base::SharedMemory instance.
Use this class to easily access data in shared memory via the
base::RefCountedMemory interface without having to copy it out to a
std::string or std::vector.

Use this in printing code to avoid a bunch of copying.

Change-Id: I275eacb3af0250d352ec909429d8563b28b1b57e
Reviewed-on: https://chromium-review.googlesource.com/978641
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Wei Li <weili@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547048}

chrome_browser_main_chromeos.cc was only initializing the
DisplayPowerServiceProvider class, which exports the
SetPower method for the org.chromium.DisplayService D-Bus
service, for ash::Config::CLASSIC. We appear to be using
ash::Config::MUS now. Initialize the provider for everything
besides ash::Config::MASH instead.

Bug: 827026
Change-Id: Ic444682d63ff40a762f80b859d1a4795149e4d60
Reviewed-on: https://chromium-review.googlesource.com/987106Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547047}

Bug: 683256
Change-Id: I3735b47e983028b08b379dfc716eea78e3b977fd
Reviewed-on: https://chromium-review.googlesource.com/985641
Commit-Queue: agrieve <agrieve@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547046}

Due to variable shadowing the exclusion space was always null after
cloning, causing problems with fragment caching.

R=eae@chromium.org
BUG=635619

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I5aca88fdc693f1ad64848f43a108953bf1fc8f65
Reviewed-on: https://chromium-review.googlesource.com/986992Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547045}

https://chromium.googlesource.com/angle/angle.git/+log/a43994c9dd3a..5cf4d06cd460

$ git log a43994c9d..5cf4d06cd --date=short --no-merges --format='%ad %ae %s'
2018-03-29 ynovikov Further reduce number of uniforms in UniformsBenchmark.Run/gles_matrix

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=lucferron@chromium.org

Change-Id: I16a75981eaed86da8967c3108e1dc991581a2dcd
Reviewed-on: https://chromium-review.googlesource.com/986875Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#547044}

Per DidFinishNavigation documentation, this callback can be called for
replaced navigations, in which case NavigationContext::HasCommitted will
return false.

This CL adds an early return to HistoryTabHelper::DidFinishNavigation
if the navigation was not committed.

Bug: 813024
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I7a0a1f180faae9715b4992d3f7b810e3287a7cda
Reviewed-on: https://chromium-review.googlesource.com/984376Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547043}

This won't block CQ, but will let us see if a potential fix works.

Bug: 826735
Change-Id: I23c8e9a7b1df04206313df3fdbec58d733d17f7f
Reviewed-on: https://chromium-review.googlesource.com/986947Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547042}

As a preparation for enabling to establish WebSocket connections off the main
thread, this CL reduces dependencies on Document in DocumentWebSocketChannel
for making it thread-safe.

This CL depends on:
https://chromium-review.googlesource.com/c/chromium/src/+/984754

Bug: 825740
Change-Id: I023bb8343415adbf45e99e74218ef70d9b35bf6a
Reviewed-on: https://chromium-review.googlesource.com/985812
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547041}

Background:
The app list goes back when it loses focus or VKEY_BROWSER_BACK is
received. Tapping on the back button on shelf will triggers back actions
twice.

Change:
Prevent handling in AppListPresenterDelegate when the back button is
clicked.

BUG=819668

Change-Id: I8e11e479cbcbe8bf917006cdf8f4ebacda94ace5
Reviewed-on: https://chromium-review.googlesource.com/985417
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547040}

WebRunner will be used on Fuchsia to run web applications.

Bug: 822474
Change-Id: I56b2fd4bf653bb2c77a013b3134f6dba8065289a
Reviewed-on: https://chromium-review.googlesource.com/965255Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Ben Goodger <ben@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547039}

This CL adds a keyword_separator_view_.

The suggestion view and keyword view were using the same separator (a
hyphen character). The text was small and jumping between the views isn't
seen per se, but I'm looking to simplify/detangle the code; and not
sharing ui elements helps disconnect them.

Bug: None
Change-Id: I507f0e6475866722106d8dd85386ff7be6a76d68
Reviewed-on: https://chromium-review.googlesource.com/987053Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547038}

This matches Cocoa behavior.

Bug: 826838
Change-Id: I85e1325ecf1c025fe05c5967d00845cd2f56dea2
Reviewed-on: https://chromium-review.googlesource.com/986852
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547037}

Bug: 827209
Change-Id: I732d3fefd4096008a33604281a66e7fa846f702f
Reviewed-on: https://chromium-review.googlesource.com/987013Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Peter Mayo <petermayo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547036}

Insets are used to resize the visual viewport of a renderer when the
virtual keyboard appears, without resizing the widget geometry. For
a <webview>, this plumbing was missing. This led to the virtual
keyboard not allowing overscroll or scrolling focused input fields into
view when the content is in a <webview>.

Bug: 740223
Change-Id: I62837fb09ae7b3590c198643259daf407028d8b6
Reviewed-on: https://chromium-review.googlesource.com/985020
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547035}

Some instructions I've used to build years-old versions of Chromium.

Bug: None
Change-Id: Id8951de8f6dcad1100ed34ee7f71e094b629333b
Reviewed-on: https://chromium-review.googlesource.com/966978
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547034}

As a preparation for enabling to establish WebSocket connections off the main
thread, this CL reduces dependencies on Document in DocumentWebSocketChannel
for making it thread-safe. Specifically, this replaces GetDocument() calls for
the traces and the inspector with GetExecutionContext().

Bug: 825740
Change-Id: If2f4afd30c30453388de5e4e50ec7169025e8b4b
Reviewed-on: https://chromium-review.googlesource.com/984754
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547033}

We can use more verbose page title instead of "DelegatedFrameHost" to
pass to the SurfaceManager for debugging purposes. It is easier to track
what FrameSink is associated with what Debug Label if these labels are
page titles.

Bug: 816802
Change-Id: If5aa98fc7e9225d2798f85ca21d6ab221c02514b
Reviewed-on: https://chromium-review.googlesource.com/984172
Commit-Queue: Illia Martyniuk <illiam@google.com>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547032}

Previously Download Manager used infobar background shadow and white
view for the background. Now the background is image view with resizable
image. The image is different for regular and compact user interface
size.

Bug: 823510
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Idfd7528cdbe2c9903e3cf23428da27b655dc80ff
Reviewed-on: https://chromium-review.googlesource.com/986720Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547031}

This CL fixes two issues that could cause a backgrounded webVR page to
receive the displayactivate event and start webVR presentation while
not visible.

The first is an issue where the ContentViewCore could be focused while
paused if the view hierarchy changes, switching Android view focus while
the Activity is paused.

The second is an issue where we the stored state to handle
displayactivate on headset insertion wasn't getting cleared when
launched by an intent rather than headset insertion.

Bug: 826983
Change-Id: Ic3426f36261b3dcdd44ce7162dff4a9b00fbef39
Reviewed-on: https://chromium-review.googlesource.com/986465Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Yash Malik <ymalik@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547030}

Due to some other issues with properly getting SSOService object to
pass to FeedbackKit, this CL adds a feature flag to use FeedbackKit V2
but disable passing of SSOService object.

This will cause feedback reports to be filed as anonymous.

Bug: 814587
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Iaa603b5c4344ce0d97596309b368d8cd410ad381
Reviewed-on: https://chromium-review.googlesource.com/986941
Commit-Queue: Peter Lee <pkl@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547029}

When getting a controller service worker, clients expect that the
controller is running. This CL makes sure the controller is running
when a client queries ControllerServiceWorker via
ControllerServiceWorkerConnector.

Note that there is another path to get ControllerServiceWorker, i.e.,
ServiceWorkerProviderHost::GetControllerServiceWorkerPtr(). This CL
doesn't update it yet because we need to change it as an async method.
A follow-up CL will update it.

Bug: 797222
Change-Id: I9b3df8e87d4c184266083041de6a3e888efd9413
Reviewed-on: https://chromium-review.googlesource.com/981842
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547028}