GitLab

This is (at this time) not complete. There are some outstanding issues to be resolved marked with TODO(skuhne) which I will address before submitting. This is meant to be a "preview".

What does it do?

It tracks the creation of all browsers / V1 / V2 applications and maximizes them automatically. Non maximizable windows will get centered and a layer will be put behind them. Note that not all windows can be maximized. Dialogs, tray, .. will remain in their window state.

The missing things:
- Background cover layer
- Removing of the restore button from the caption (different CL)
- Suppression of restore / fullscreen request events of any of the tracked windows.

BUG=337563
TEST=unit tests

Review URL: https://codereview.chromium.org/167503002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252211 0039d316-1c4b-4281-b951-d872f2087c98

This patch is a follow-up to issue 147353011.

The patch adds a display mechanism for the about:invalidations page
that shows a table with every implementer of InvalidationHandler that
has registered for at least one ObjectId for invalidations. The table
also registers for every ObjectId how many invalidations were received
of that kind, the last time one of those arrived and what was the
payload it contained, in case there were any.

There are minimal modifications to every file that implemented
InvalidationHandler because there was a small change in the interface,
in order to be able to return a string stating who is the owner of the
InvalidationHandler without passing raw pointers around.

BUG=263863

Review URL: https://codereview.chromium.org/159773006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252210 0039d316-1c4b-4281-b951-d872f2087c98

  - race on WTF::s_shutdown (issue 345240)
  - races in WebRtcBrowserTest.CallWithDataAndMedia (issue 345245)
  - race on cc::s_next_layer_id (issue 345251)

BUG=345240,345245,345251
TBR=earthdok@chromium.org

Review URL: https://codereview.chromium.org/169303008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252209 0039d316-1c4b-4281-b951-d872f2087c98

BUG=333515

Review URL: https://codereview.chromium.org/172863003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252208 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
NOTRY=true

Review URL: https://codereview.chromium.org/171773007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252207 0039d316-1c4b-4281-b951-d872f2087c98

Makes changes to how the state is recorded in zero_suggest_provider
to facilitate moving out ParseSuggestResults into super class.

Replaces navigation_results_, query_matches_map_, and
verbatim_relevance_ objects with a Results results_ instance. The latter
keeps track of navigation_results_ and query_results_ and constructs
the query matches map on when it's needed.

verbatim_relevance_ in the old code is only used to see the current url
match (based on the server relevance returned in the previous request
or a static value). The new code keeps track of the server verbatim
relevance in results_ and uses an accessor to get either server results
or a constant value if no server results are available, matching the
old semantics.

Merged FillResults with ParseSuggestResults function and moved match
map creation code into ConvertResultsToAutocompleteMatches where it's
used.

BUG=338955
TBR=mpearson

Review URL: https://codereview.chromium.org/171323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252206 0039d316-1c4b-4281-b951-d872f2087c98

The layer tree seems to receive gesture events before it's initialized
(or while being destroyed). This means the pinch events get executed
while InnerViewportScrollLayer() == NULL, which was assumed to be non
NULL. The event handler should probably not be sending events to an
uninitialized layer tree but in the mean time I've disabled the
DCHECK and added an early out to prevent crashes.

BUG=340303

Review URL: https://codereview.chromium.org/170743004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252205 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true
TBR=mbarbella@chromium.org
TBR=inferno@chromium.org

Review URL: https://codereview.chromium.org/168283011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252204 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None, no functional changes.
R=brianderson@chromium.org

Review URL: https://codereview.chromium.org/167053004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252203 0039d316-1c4b-4281-b951-d872f2087c98

BUG=338247
TEST=
1.Launch chrome://settings..ctrl+D,save the Bookmark in Bookmark Bar.
2.Open 3 to 4 new Tabs via ctrl+T,in chrome://settings page Drag the Bookmark from the Bookmark Bar.
3.Hover the Dragged Bookmark over the second New-Tab and Release the Bookmark over the New-Tab.
4.Hover the Dragged Bookmark over the third New-Tab (the tab gets activated) and Release the Bookmark over the New-Tab.
5.Close browser - should not crash.

Review URL: https://codereview.chromium.org/140663013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252201 0039d316-1c4b-4281-b951-d872f2087c98

BUG=343996

Review URL: https://codereview.chromium.org/167673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252200 0039d316-1c4b-4281-b951-d872f2087c98

BUG=344982
NOTRY=true

Review URL: https://codereview.chromium.org/172813003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252198 0039d316-1c4b-4281-b951-d872f2087c98

Inline the Windows-specific NativeShowMessageBox.
Pass the parent HWND argument to the underlying call.
Use MB_ICONQUESTION for MESSAGE_BOX_TYPE_QUESTION.

BUG=NONE
TEST=No Win MessageBox regressions; better icon for any fallback question MessageBox.
R=sky@chromium.org

Review URL: https://codereview.chromium.org/172633004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252197 0039d316-1c4b-4281-b951-d872f2087c98

Since IPC fuzzer compiles outside of the normal chromium build,
there can be some symbols which we don't properly get defined,
so define them locally for now.

TBR=aedla@chromium.org

Review URL: https://codereview.chromium.org/168283010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252196 0039d316-1c4b-4281-b951-d872f2087c98

Created a listener in ContentVideoViewLegacy that interested classes can
use to listen for changes in the media controls visibility. Also changed
the touch listener to listen to the whole screen instead of just the
surface view for toggling the media controls visibility.

The corresponding downstream CL:
https://chrome-internal-review.googlesource.com/#/c/155197/

The original CL by maybelle@:
https://codereview.chromium.org/164273002/

BUG=341498
NOTRY=true

Review URL: https://codereview.chromium.org/171233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252195 0039d316-1c4b-4281-b951-d872f2087c98

R=raymes@chromium.org, bbudge, raymes
BUG=327351

Review URL: https://codereview.chromium.org/150663007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252194 0039d316-1c4b-4281-b951-d872f2087c98

Doing a regular user mount with the ephemeral flag doesn't work very well since cryptohome expects the machine to either have an owner or be enterprise owned for normal user mounts, even if ephemeral. This CL switches us to using the mount guest path in cryptohome.
This involves changing the path followed by LoginUtils::PrepareProfile since there are multiple things that it does that we either do not want, or cannot have, for a guest mount.

Additionally, we cannot MountGuest with our normal demo mode user_id since Cryptohome (and a few other cros components) expect the username for a guest mount to be $guest. To get around this, we mount crytohome with $guest as the username, but once the mount is done, we switch the username back to the demo user name for the rest of the processsing being done in Chrome.

R=dpolukhin@chromium.org, xiyuan@chromium.org
BUG=345038
TEST=Tested on a device on OOBE with the TPM cleared.

Review URL: https://codereview.chromium.org/171423009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252193 0039d316-1c4b-4281-b951-d872f2087c98

This approach won't let use share an array buffer with blink, however,
it's good enough for a mojo js app.

For gin::Wrappable objects that want to interact with blink APIs, they
need to provide a custom converter to and from WebArrayBuffer(View)

BUG=none
R=abarth@chromium.org, dslomov@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/172133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252190 0039d316-1c4b-4281-b951-d872f2087c98

* Class monitors for when the given package has been installed on the device.

* Timeouts added to prevent this from spinning forever.

* Test runs the InstallerDelegate on a separate thread so the Handler events are processed instead of sitting idly.

* An attempt at using BroadcastReceivers was made to catch http://developer.android.com/reference/android/content/Intent.html#ACTION_PACKAGE_ADDED,
but the broadcast is fired when the package is added and not when the package finishes installing.

* Adds dfalcantara@ to OWNERs for app banners directories

NOTRY=true
BUG=341556
TEST=InstallerDelegateTest
R=yfriedman@chromium.org

Review URL: https://codereview.chromium.org/156013005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252189 0039d316-1c4b-4281-b951-d872f2087c98

FileSystemInterface has nothing to do with ClientContext

BUG=None
TEST=build
R=kinaba@chromium.org

Review URL: https://codereview.chromium.org/168363003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252188 0039d316-1c4b-4281-b951-d872f2087c98

This will allow the definition to be removed from NaCl's irt.h.

BUG=https://code.google.com/p/nativeclient/issues/detail?id=3787
TEST=build
R=teravest@chromium.org

Review URL: https://codereview.chromium.org/172633005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252185 0039d316-1c4b-4281-b951-d872f2087c98

BUG=303491
R=arv@chromium.org, koz@chromium.org

Review URL: https://codereview.chromium.org/169683005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252180 0039d316-1c4b-4281-b951-d872f2087c98

The page can receive messages from the plugin that instruct it to scroll to a particular page.

BUG=303491
R=arv@chromium.org, koz@chromium.org

Review URL: https://codereview.chromium.org/165813004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252178 0039d316-1c4b-4281-b951-d872f2087c98

The PDF extension needs to compute the most visible page frequently so we use
a binary search.

BUG=303491
R=arv@chromium.org, koz@chromium.org

Review URL: https://codereview.chromium.org/170163003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252177 0039d316-1c4b-4281-b951-d872f2087c98

This hooks up the page-indicator (so that the correct page is displayed) and
the progress bar (so that the correct progress is displayed) in PDF.

BUG=303491
R=arv@chromium.org, koz@chromium.org

Review URL: https://codereview.chromium.org/138703009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252175 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252172 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=%2Ftrunk&range=167305%3A167448&mode=html

TBR=acolwel

Review URL: https://codereview.chromium.org/173413003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252171 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252169 0039d316-1c4b-4281-b951-d872f2087c98

TODO(dbeam): re-enable when we figure out how a webpage can request this field.

R=estade@chromium.org, rouslan@chromium.org
BUG=340929
TEST=unit_tests, no CN or KR in rAc() country dropdown or suggestions for now :(

Review URL: https://codereview.chromium.org/172783003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252167 0039d316-1c4b-4281-b951-d872f2087c98

This is to make sure I found all the bots that used to pass this. I'll
completely remove the flag in a day or two.

Also remove the function for printing usage information. I accidentally removed
processing for --help in r252034, but having a --help flag for printing --help
as only supported flag is a bit silly anyways, so get rid of this.

(Depends on https://codereview.chromium.org/170783015/
and https://chrome-internal-review.googlesource.com/#/c/155292/)

BUG=330631
R=yfriedman@chromium.org

Review URL: https://codereview.chromium.org/173003003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252166 0039d316-1c4b-4281-b951-d872f2087c98

When a child resource is unused for the frame, but is exported, we mark it for
deletion, pending the return from the top-level parent.
However, we may receive that resource again from the child, and start using it,
before we got the return, so at that point we should unmark the resource for
deletion, because leaving it marked will make us return the resource to the
child when we receive it back from the top-level parent.

BUG=342061

Review URL: https://codereview.chromium.org/170173004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252164 0039d316-1c4b-4281-b951-d872f2087c98

ERR_FILE_NOT_FOUND was being returned before, which is rather
misleading.

ERR_INVALID_RESPONSE is a very rare error, and currently just uses the
generic error page, with no strings of its own.  If this CL significantly
increases the frequency of the error, we should add strings for it.

BUG=344633

Review URL: https://codereview.chromium.org/165983007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252163 0039d316-1c4b-4281-b951-d872f2087c98

There were several cases where we were passing DIP coordinates for gestures
being filtered and/or ack'ed in ContentViewCore.  Fix this by re-scaling
gesture-related coordinates to pixels before sending them to ContentViewCore.

NOTRY=true

Review URL: https://codereview.chromium.org/165393014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252162 0039d316-1c4b-4281-b951-d872f2087c98

Viewport preferences are overridden even with the --enable-viewport flag passed in.

BUG=343993

Review URL: https://codereview.chromium.org/166033008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252161 0039d316-1c4b-4281-b951-d872f2087c98

This CL converts blink::WebString to std::string in WebMediaPlayerImpl and WebMediaPlayerAndroid so that internal chromium classes don't need to deal with blink::WebString anymore.

Changes about logging:
- Use base::string16 so that if non-ascii parameters can be shown correctly.
- Move logging to public methods so that parameters can be logged before being converted to ASCII.

BUG=252065
TEST=KeySystemsTest updated.
R=ddorwin@chromium.org

Review URL: https://codereview.chromium.org/170783010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252160 0039d316-1c4b-4281-b951-d872f2087c98

> Implement inline signin with iframe
> 
> =+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=
> This is a dup of https://codereview.chromium.org/130963006/ since I cannot
> upload to that issue.  The only change is to address Xiyuan's two comments
> in patchset 3 of that CL.
> =+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=
> 
> Inline signin chrome://chrome-signin is currently implemented using webview embedded in webUI, which breaks a couple of features in webUI and has serious accessbility issues. Since webview will be reimplemented based on OOPIF in the near future, and all the issues we have today will no longer apply, thus it is not worth the effort to fix them as they are throw away work. Instead, as suggested by John and prototyped in https://codereview.chromium.org/141363006/, we decide to switch to iframe instead. A few issues worth to mention,
> 
> 1. The iframe shares the same renderer as the embedder webUI, and thus could be potentially exposed to dangerous webUI privileges. John suggested a fix by assigning a unique storage partition ID to the inline signin page. As a result the inline signin and its embedded web content should never share the same renderer with other webUI pages.
> 
> 2. webview provides a direct API to inject script and to monitor requests/responses, which is not (directly) available with iframe. The CL works around the issue using content script and background script, quite similar to what CrOS is doing for SAML flow today. Thus it is also the first step towards unifying SAML flows on CrOS and desktop.
> 
> 3. with webview approach, we used to have a unique temporary partition for each instance of inline signin, in order to make sure multiple instances do not interfere with each other. This is more difficult with the iframe approach, since the partition ID is hardcoded in a quite low layer. In this CL, all inline signin pages share the same persistent partition, which means we have to handle the case when user loads the sign in page with a dirty cookie jar, and thus the newly connected user may not be stored in the primary session. The CL solves the issue by reading 'session_index' from 'google-accounts-signin' header.
> 
> BUG=338127
> 
> Review URL: https://codereview.chromium.org/134263005

TBR=rogerta@chromium.org

Review URL: https://codereview.chromium.org/173193005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252159 0039d316-1c4b-4281-b951-d872f2087c98

BUG=344943

Review URL: https://codereview.chromium.org/172263003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252157 0039d316-1c4b-4281-b951-d872f2087c98

The tests have changed significantly since they were first disabled. Add a
WaitForStop or two for good measure, but leave them as-is for the most part.
They can be disabled again if they still flake. Merge their custom prerender
loader into the main one; it's mostly the same.

In addition, for better test coverage, add a new test which asserts on events
received when a <link rel=prerender> is added for an existing prerender after
that prerender has loaded. Significantly rework the prerender events logic
to allow the test framework to wait on an event being received in the loader.

Fix implementation of set_loader_query_and_fragment to not produce URLs with
two ?s.

Original Review URL: https://codereview.chromium.org/142013004

BUG=167340, 128841

Review URL: https://codereview.chromium.org/166273007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252156 0039d316-1c4b-4281-b951-d872f2087c98

BUG=344909
TEST=Manual - follow steps in the bug.

Review URL: https://codereview.chromium.org/172243005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252155 0039d316-1c4b-4281-b951-d872f2087c98

This fixes and re-enables all the host driven sync tests.

NOTRY=true
BUG=329757,309997,311091

Review URL: https://codereview.chromium.org/168833004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252154 0039d316-1c4b-4281-b951-d872f2087c98